@vellumai/assistant 0.10.2 → 0.10.3-dev.202606252046.9075fd5

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (546) hide show
  1. package/bun.lock +20 -0
  2. package/docs/workspace-tools.md +42 -33
  3. package/eslint-rules/cli-no-daemon-internals.js +6 -0
  4. package/node_modules/@vellumai/gateway-client/src/__tests__/guardian-delivery-contract.test.ts +91 -0
  5. package/node_modules/@vellumai/gateway-client/src/__tests__/trust-verdict-contract.test.ts +31 -0
  6. package/node_modules/@vellumai/gateway-client/src/gateway-ipc-contracts.ts +44 -0
  7. package/node_modules/@vellumai/gateway-client/src/guardian-delivery-contract.ts +48 -0
  8. package/node_modules/@vellumai/gateway-client/src/index.ts +14 -0
  9. package/node_modules/@vellumai/gateway-client/src/trust-verdict-contract.ts +17 -0
  10. package/node_modules/@vellumai/service-contracts/package.json +1 -0
  11. package/node_modules/@vellumai/service-contracts/src/__tests__/channels.test.ts +28 -0
  12. package/node_modules/@vellumai/service-contracts/src/channels.ts +41 -0
  13. package/node_modules/@vellumai/service-contracts/src/index.ts +1 -0
  14. package/openapi.yaml +196 -56
  15. package/package.json +4 -1
  16. package/scripts/test.sh +36 -15
  17. package/src/__tests__/actor-token-service.test.ts +36 -14
  18. package/src/__tests__/actor-trust-resolver-address-fallback.test.ts +83 -31
  19. package/src/__tests__/agent-loop-override-profile.test.ts +1 -0
  20. package/src/__tests__/agent-wake-disk-pressure-callsite.test.ts +2 -0
  21. package/src/__tests__/agent-wake-override-profile.test.ts +2 -0
  22. package/src/__tests__/annotate-activity-metadata.test.ts +2 -0
  23. package/src/__tests__/annotate-risk-options.test.ts +2 -0
  24. package/src/__tests__/approval-cascade.test.ts +2 -0
  25. package/src/__tests__/assistant-attachments.test.ts +42 -0
  26. package/src/__tests__/background-workers-disk-pressure.test.ts +2 -0
  27. package/src/__tests__/btw-routes.test.ts +2 -0
  28. package/src/__tests__/build-persisted-content.test.ts +2 -0
  29. package/src/__tests__/call-controller.test.ts +19 -0
  30. package/src/__tests__/channel-approval-routes.test.ts +21 -26
  31. package/src/__tests__/channel-delivery-store.test.ts +28 -0
  32. package/src/__tests__/channel-guardian.test.ts +164 -78
  33. package/src/__tests__/channel-inbound-disk-pressure.test.ts +11 -19
  34. package/src/__tests__/channel-reply-delivery.test.ts +2 -0
  35. package/src/__tests__/code-search-tool.test.ts +585 -0
  36. package/src/__tests__/compaction-events.test.ts +2 -0
  37. package/src/__tests__/compaction-ledger-store.test.ts +128 -0
  38. package/src/__tests__/compaction.benchmark.test.ts +2 -0
  39. package/src/__tests__/compactor-call-site-logging.test.ts +2 -0
  40. package/src/__tests__/compactor-low-watermark-cut.test.ts +2 -0
  41. package/src/__tests__/compactor-preserved-tail-count.test.ts +2 -0
  42. package/src/__tests__/compactor-summary-call-truncation.test.ts +2 -0
  43. package/src/__tests__/compactor-web-search-strip.test.ts +2 -0
  44. package/src/__tests__/config-loader-backfill.test.ts +123 -10
  45. package/src/__tests__/config-schema.test.ts +1 -0
  46. package/src/__tests__/confirmation-request-guardian-bridge.test.ts +31 -29
  47. package/src/__tests__/consult-deadline.test.ts +60 -0
  48. package/src/__tests__/contact-store-interaction-info.test.ts +156 -0
  49. package/src/__tests__/contact-store-user-file.test.ts +7 -10
  50. package/src/__tests__/contacts-relay-reads.test.ts +19 -24
  51. package/src/__tests__/contacts-write.test.ts +0 -2
  52. package/src/__tests__/conversation-abort-tool-results.test.ts +2 -0
  53. package/src/__tests__/conversation-agent-loop-disk-pressure.test.ts +2 -0
  54. package/src/__tests__/conversation-agent-loop-inference-profile.test.ts +2 -0
  55. package/src/__tests__/conversation-agent-loop-overflow.test.ts +2 -0
  56. package/src/__tests__/conversation-agent-loop.test.ts +134 -0
  57. package/src/__tests__/conversation-analysis-routes.test.ts +2 -0
  58. package/src/__tests__/conversation-app-control-lifecycle.test.ts +2 -0
  59. package/src/__tests__/conversation-attention-telegram.test.ts +9 -11
  60. package/src/__tests__/conversation-confirmation-signals.test.ts +2 -0
  61. package/src/__tests__/conversation-fork-crud.test.ts +354 -24
  62. package/src/__tests__/conversation-history-web-search.test.ts +2 -0
  63. package/src/__tests__/conversation-load-history-repair.test.ts +2 -0
  64. package/src/__tests__/conversation-load-history-stripped.test.ts +2 -0
  65. package/src/__tests__/conversation-pairing.test.ts +2 -0
  66. package/src/__tests__/conversation-process-app-control-preactivation.test.ts +2 -0
  67. package/src/__tests__/conversation-process-callsite.test.ts +2 -0
  68. package/src/__tests__/conversation-provider-retry-repair.test.ts +2 -0
  69. package/src/__tests__/conversation-queue.test.ts +91 -0
  70. package/src/__tests__/conversation-routes-guardian-reply.test.ts +14 -0
  71. package/src/__tests__/conversation-routes-slash-commands.test.ts +14 -0
  72. package/src/__tests__/conversation-slash-queue.test.ts +2 -0
  73. package/src/__tests__/conversation-slash-unknown.test.ts +2 -0
  74. package/src/__tests__/conversation-speed-override.test.ts +2 -0
  75. package/src/__tests__/conversation-surfaces-task-progress.test.ts +29 -0
  76. package/src/__tests__/conversation-title-service.test.ts +2 -0
  77. package/src/__tests__/conversation-tool-setup-attribution.test.ts +47 -0
  78. package/src/__tests__/conversation-usage.test.ts +2 -0
  79. package/src/__tests__/conversation-workspace-cache-state.test.ts +2 -0
  80. package/src/__tests__/conversation-workspace-injection.test.ts +2 -0
  81. package/src/__tests__/conversation-workspace-tool-tracking.test.ts +2 -0
  82. package/src/__tests__/credential-security-invariants.test.ts +1 -1
  83. package/src/__tests__/db-compaction-events-migration.test.ts +129 -0
  84. package/src/__tests__/db-migration-rollback.test.ts +205 -171
  85. package/src/__tests__/db-test-helpers.ts +5 -4
  86. package/src/__tests__/delete-propagation.test.ts +5 -3
  87. package/src/__tests__/deterministic-verification-control-plane.test.ts +4 -2
  88. package/src/__tests__/disk-pressure-guard.test.ts +41 -0
  89. package/src/__tests__/dm-backfill.test.ts +6 -4
  90. package/src/__tests__/dm-persistence.test.ts +2 -0
  91. package/src/__tests__/emit-signal-routing-intent.test.ts +7 -6
  92. package/src/__tests__/events-dev-bypass-actor.test.ts +7 -1
  93. package/src/__tests__/exploration-drift-hook.test.ts +3 -2
  94. package/src/__tests__/filing-service.test.ts +2 -0
  95. package/src/__tests__/guardian-binding-drift-heal.test.ts +104 -19
  96. package/src/__tests__/guardian-dispatch.test.ts +140 -1
  97. package/src/__tests__/guardian-expiry-notifier.test.ts +282 -0
  98. package/src/__tests__/guardian-outbound-http.test.ts +13 -0
  99. package/src/__tests__/guardian-routing-state.test.ts +6 -10
  100. package/src/__tests__/heartbeat-disk-pressure.test.ts +2 -0
  101. package/src/__tests__/heartbeat-service.test.ts +2 -0
  102. package/src/__tests__/helpers/channel-test-adapter.ts +46 -19
  103. package/src/__tests__/helpers/create-guardian-binding.ts +15 -23
  104. package/src/__tests__/helpers/mock-logger.ts +1 -0
  105. package/src/__tests__/helpers/seed-contact-channel.ts +96 -0
  106. package/src/__tests__/host-app-control-routes.test.ts +24 -30
  107. package/src/__tests__/host-bash-routes.test.ts +31 -41
  108. package/src/__tests__/host-browser-routes.test.ts +26 -32
  109. package/src/__tests__/host-cu-routes-targeted.test.ts +25 -33
  110. package/src/__tests__/host-file-routes-targeted.test.ts +40 -52
  111. package/src/__tests__/host-transfer-routes-targeted.test.ts +31 -43
  112. package/src/__tests__/http-user-message-parity.test.ts +290 -8
  113. package/src/__tests__/inbound-invite-redemption.test.ts +115 -10
  114. package/src/__tests__/inbound-slack-persistence.test.ts +2 -0
  115. package/src/__tests__/invite-redemption-service.test.ts +471 -53
  116. package/src/__tests__/invite-routes-http.test.ts +34 -0
  117. package/src/__tests__/invite-service-ipc.test.ts +65 -2
  118. package/src/__tests__/llm-context-normalization.test.ts +105 -0
  119. package/src/__tests__/llm-request-log-error-payload.test.ts +71 -9
  120. package/src/__tests__/llm-usage-store.test.ts +25 -0
  121. package/src/__tests__/mcp-config-secret-boundary.test.ts +392 -0
  122. package/src/__tests__/mcp-health-check.test.ts +2 -1
  123. package/src/__tests__/media-stream-server-integration.test.ts +127 -0
  124. package/src/__tests__/memory-retrieval-hook.test.ts +2 -0
  125. package/src/__tests__/messaging-send-tool.test.ts +2 -0
  126. package/src/__tests__/migration-import-from-url.test.ts +2 -2
  127. package/src/__tests__/mtime-cache.test.ts +275 -5
  128. package/src/__tests__/native-web-search.test.ts +2 -0
  129. package/src/__tests__/non-member-access-request.test.ts +191 -17
  130. package/src/__tests__/notification-broadcaster.test.ts +4 -0
  131. package/src/__tests__/notification-decision-recipient-context.test.ts +33 -32
  132. package/src/__tests__/notification-deep-link.test.ts +6 -0
  133. package/src/__tests__/notification-guardian-path.test.ts +19 -0
  134. package/src/__tests__/onboarding-persona-write.test.ts +52 -22
  135. package/src/__tests__/openai-provider.test.ts +22 -12
  136. package/src/__tests__/openai-responses-provider.test.ts +12 -2
  137. package/src/__tests__/outbound-slack-persistence.test.ts +2 -0
  138. package/src/__tests__/pending-interactions-resolved-event.test.ts +7 -4
  139. package/src/__tests__/persist-onboarding-artifacts.test.ts +1 -0
  140. package/src/__tests__/persistence-secret-redaction.test.ts +2 -0
  141. package/src/__tests__/persona-resolver.test.ts +75 -45
  142. package/src/__tests__/plugin-bootstrap.test.ts +21 -83
  143. package/src/__tests__/plugin-disabled-state.test.ts +190 -0
  144. package/src/__tests__/plugin-pipeline.test.ts +96 -0
  145. package/src/__tests__/plugin-route-contribution.test.ts +6 -19
  146. package/src/__tests__/plugin-tool-contribution.test.ts +5 -20
  147. package/src/__tests__/plugin-types.test.ts +2 -4
  148. package/src/__tests__/process-message-background-slack.test.ts +2 -0
  149. package/src/__tests__/process-message-display-content.test.ts +2 -0
  150. package/src/__tests__/provider-error-scenarios.test.ts +5 -4
  151. package/src/__tests__/provider-usage-tracking.test.ts +39 -0
  152. package/src/__tests__/reaction-intercept-cold-cache-warm.test.ts +135 -0
  153. package/src/__tests__/reaction-intercept-member-verdict-warm.test.ts +158 -0
  154. package/src/__tests__/reaction-persistence.test.ts +51 -4
  155. package/src/__tests__/regenerate-fire-and-forget-trace.test.ts +2 -0
  156. package/src/__tests__/registry.test.ts +4 -1
  157. package/src/__tests__/relay-server.test.ts +758 -32
  158. package/src/__tests__/runtime-attachment-metadata.test.ts +9 -12
  159. package/src/__tests__/secret-ingress-http.test.ts +14 -0
  160. package/src/__tests__/send-endpoint-busy.test.ts +30 -8
  161. package/src/__tests__/settings-routes.test.ts +32 -0
  162. package/src/__tests__/skills.test.ts +44 -0
  163. package/src/__tests__/slack-inbound-verification.test.ts +47 -2
  164. package/src/__tests__/sse-actor-principal-guardian-source.test.ts +79 -0
  165. package/src/__tests__/steer-on-enqueue-question.test.ts +181 -0
  166. package/src/__tests__/stt-hints.test.ts +49 -15
  167. package/src/__tests__/subagent-detail.test.ts +27 -0
  168. package/src/__tests__/subagent-disposal.test.ts +65 -0
  169. package/src/__tests__/subagent-fork-prompt-role.test.ts +195 -0
  170. package/src/__tests__/subagent-fork-spawn.test.ts +6 -7
  171. package/src/__tests__/subagent-notify-parent.test.ts +2 -0
  172. package/src/__tests__/subagent-role-registry.test.ts +24 -6
  173. package/src/__tests__/subagent-spawn-and-await.test.ts +546 -0
  174. package/src/__tests__/subagent-spawn-tool-fork.test.ts +2 -0
  175. package/src/__tests__/subagent-tools.test.ts +398 -1
  176. package/src/__tests__/suggestion-routes.test.ts +2 -0
  177. package/src/__tests__/thread-backfill.test.ts +3 -3
  178. package/src/__tests__/title-generate-hook.test.ts +2 -0
  179. package/src/__tests__/tool-executor-lifecycle-events.test.ts +2 -0
  180. package/src/__tests__/tool-executor.test.ts +16 -11
  181. package/src/__tests__/tool-preview-lifecycle.test.ts +2 -0
  182. package/src/__tests__/tool-result-metadata-plumbing.test.ts +2 -0
  183. package/src/__tests__/tool-start-timestamp.test.ts +2 -0
  184. package/src/__tests__/trusted-contact-approval-notifier.test.ts +37 -51
  185. package/src/__tests__/trusted-contact-inline-approval-integration.test.ts +12 -12
  186. package/src/__tests__/trusted-contact-lifecycle-notifications.test.ts +9 -7
  187. package/src/__tests__/trusted-contact-multichannel.test.ts +16 -7
  188. package/src/__tests__/trusted-contact-verification.test.ts +79 -54
  189. package/src/__tests__/twilio-routes.test.ts +96 -0
  190. package/src/__tests__/ui-file-upload-surface.test.ts +86 -0
  191. package/src/__tests__/verification-control-plane-policy.test.ts +2 -0
  192. package/src/__tests__/voice-guardian-cold-cache-warm.test.ts +137 -0
  193. package/src/__tests__/voice-invite-redemption.test.ts +216 -20
  194. package/src/__tests__/web-search-backend-failure.test.ts +2 -0
  195. package/src/__tests__/workspace-migration-102-preserve-heartbeat-enabled-for-existing-workspaces.test.ts +3 -3
  196. package/src/__tests__/workspace-migration-111-prune-seeded-callsite-defaults.test.ts +208 -0
  197. package/src/__tests__/workspace-migration-112-remove-advisor-callsite-override.test.ts +170 -0
  198. package/src/__tests__/workspace-migration-drop-user-md.test.ts +196 -238
  199. package/src/__tests__/workspace-migration-remove-hooks.test.ts +14 -35
  200. package/src/__tests__/workspace-tool-loader.test.ts +195 -2
  201. package/src/a2a/__tests__/e2e-a2a-channel.test.ts +35 -47
  202. package/src/agent/loop-exclusive-tool.test.ts +154 -0
  203. package/src/agent/loop-native-web-search.test.ts +200 -0
  204. package/src/agent/loop.ts +164 -1
  205. package/src/api/constants/sse-replay.ts +41 -0
  206. package/src/api/events/conversation-notice.ts +26 -0
  207. package/src/api/index.ts +19 -1
  208. package/src/api/responses/llm-request-log-entry.ts +29 -0
  209. package/src/api/responses/subagent-detail.ts +17 -0
  210. package/src/api/surfaces.ts +39 -3
  211. package/src/approvals/guardian-channel-delivery.ts +30 -0
  212. package/src/approvals/guardian-expiry-notifier.ts +148 -0
  213. package/src/approvals/guardian-request-resolvers.ts +17 -15
  214. package/src/calls/__tests__/relay-setup-router.test.ts +267 -17
  215. package/src/calls/call-domain.ts +3 -3
  216. package/src/calls/guardian-dispatch.ts +14 -9
  217. package/src/calls/inbound-trust-reader.ts +24 -2
  218. package/src/calls/media-stream-server.ts +21 -0
  219. package/src/calls/relay-access-wait.ts +6 -6
  220. package/src/calls/relay-server.ts +188 -51
  221. package/src/calls/relay-setup-router.ts +47 -17
  222. package/src/calls/relay-verification.ts +4 -4
  223. package/src/calls/stt-hints.ts +9 -12
  224. package/src/calls/twilio-routes.ts +14 -4
  225. package/src/channels/types.ts +10 -20
  226. package/src/cli/commands/__tests__/cache.test.ts +8 -1
  227. package/src/cli/commands/__tests__/conversations-slack.test.ts +1 -0
  228. package/src/cli/commands/cache.ts +194 -181
  229. package/src/cli/commands/contacts.ts +10 -7
  230. package/src/cli/commands/db/__tests__/repair.test.ts +6 -5
  231. package/src/cli/commands/db/status.ts +37 -1
  232. package/src/cli/commands/mcp.ts +252 -218
  233. package/src/cli/commands/memory/__tests__/worker.test.ts +432 -0
  234. package/src/cli/commands/memory/index.ts +2 -0
  235. package/src/cli/commands/memory/worker.ts +242 -0
  236. package/src/cli/commands/plugins.ts +125 -13
  237. package/src/cli/lib/__tests__/install-from-github.test.ts +102 -0
  238. package/src/cli/lib/__tests__/list-installed-plugins.test.ts +160 -1
  239. package/src/cli/lib/__tests__/publish-plugin.test.ts +404 -0
  240. package/src/cli/lib/list-installed-plugins.ts +179 -1
  241. package/src/cli/lib/publish-plugin.ts +633 -0
  242. package/src/config/__tests__/loader-callsite-strip-fallback.test.ts +143 -0
  243. package/src/config/__tests__/sync-gated-profiles.test.ts +16 -10
  244. package/src/config/bundled-skills/contacts/tools/contact-merge.ts +27 -17
  245. package/src/config/bundled-skills/contacts/tools/contact-search.ts +13 -3
  246. package/src/config/bundled-skills/subagent/SKILL.md +17 -2
  247. package/src/config/bundled-skills/subagent/TOOLS.json +5 -4
  248. package/src/config/call-site-defaults.ts +0 -6
  249. package/src/config/feature-flag-registry.json +5 -13
  250. package/src/config/llm-resolver.ts +0 -3
  251. package/src/config/loader.ts +38 -5
  252. package/src/config/prune-seeded-callsite-defaults.ts +110 -0
  253. package/src/config/schemas/__tests__/memory-v3.test.ts +1 -0
  254. package/src/config/schemas/call-site-catalog.ts +0 -7
  255. package/src/config/schemas/heartbeat.ts +2 -5
  256. package/src/config/schemas/llm.ts +3 -12
  257. package/src/config/schemas/memory-lifecycle.ts +12 -0
  258. package/src/config/schemas/memory-v3.ts +7 -0
  259. package/src/config/schemas/memory.ts +4 -0
  260. package/src/config/schemas/timeouts.ts +8 -0
  261. package/src/config/seed-inference-profiles.ts +30 -34
  262. package/src/config/skills.ts +27 -5
  263. package/src/config/sync-gated-profiles.ts +12 -16
  264. package/src/contacts/__tests__/contacts-write-revoke-relay.test.ts +128 -0
  265. package/src/contacts/__tests__/guardian-delivery-reader.test.ts +312 -0
  266. package/src/contacts/__tests__/member-write-relay.test.ts +226 -0
  267. package/src/contacts/contact-store.ts +27 -237
  268. package/src/contacts/contacts-write.ts +18 -55
  269. package/src/contacts/gateway-channel-read.ts +51 -0
  270. package/src/contacts/guardian-delivery-reader.ts +223 -0
  271. package/src/contacts/member-write-relay.ts +183 -0
  272. package/src/contacts/types.ts +3 -15
  273. package/src/daemon/__tests__/conversation-tool-setup-exclude.test.ts +35 -0
  274. package/src/daemon/__tests__/conversation-tool-setup.test.ts +0 -44
  275. package/src/daemon/assistant-attachments.ts +27 -4
  276. package/src/daemon/conversation-agent-loop.ts +28 -0
  277. package/src/daemon/conversation-notices.ts +60 -0
  278. package/src/daemon/conversation-process.ts +35 -16
  279. package/src/daemon/conversation-surfaces.ts +111 -38
  280. package/src/daemon/conversation-tool-setup.ts +71 -30
  281. package/src/daemon/conversation.ts +23 -1
  282. package/src/daemon/disk-pressure-guard.ts +12 -2
  283. package/src/daemon/event-loop-watchdog.ts +28 -1
  284. package/src/daemon/external-plugins-bootstrap.ts +17 -41
  285. package/src/daemon/handlers/__tests__/config-a2a-accept.test.ts +0 -1
  286. package/src/daemon/handlers/__tests__/config-a2a-complete.test.ts +0 -2
  287. package/src/daemon/handlers/__tests__/config-a2a-redeem.test.ts +25 -2
  288. package/src/daemon/handlers/__tests__/config-channels.test.ts +220 -0
  289. package/src/daemon/handlers/config-a2a.ts +6 -14
  290. package/src/daemon/handlers/config-channels.ts +67 -26
  291. package/src/daemon/handlers/conversations.ts +77 -0
  292. package/src/daemon/lifecycle.ts +16 -0
  293. package/src/daemon/mcp-reload-service.ts +10 -0
  294. package/src/daemon/memory-v2-startup.test.ts +72 -0
  295. package/src/daemon/memory-v2-startup.ts +87 -19
  296. package/src/daemon/message-types/conversations.ts +2 -0
  297. package/src/daemon/message-types/surfaces.ts +12 -12
  298. package/src/daemon/server.ts +0 -4
  299. package/src/daemon/shutdown-handlers.ts +20 -0
  300. package/src/daemon/tool-setup-types.ts +9 -0
  301. package/src/heartbeat/heartbeat-service.ts +5 -0
  302. package/src/home/relationship-state-writer.ts +5 -0
  303. package/src/hooks/hook-loader.ts +341 -0
  304. package/src/ipc/__tests__/clients-list-ipc.test.ts +1 -1
  305. package/src/ipc/assistant-server.ts +2 -2
  306. package/src/mcp/__tests__/mcp-auth-orchestrator.test.ts +1 -0
  307. package/src/mcp/client.ts +15 -1
  308. package/src/mcp/mcp-auth-orchestrator.ts +6 -1
  309. package/src/mcp/mcp-header-store.ts +134 -0
  310. package/src/mcp/mcp-oauth-provider.ts +19 -8
  311. package/src/memory/__tests__/301-create-watchdog-events.test.ts +110 -0
  312. package/src/memory/__tests__/memory-retrospective-job.test.ts +8 -0
  313. package/src/memory/__tests__/prompt-override.test.ts +192 -0
  314. package/src/memory/__tests__/watchdog-events-store.test.ts +161 -0
  315. package/src/memory/compaction-ledger-store.ts +107 -0
  316. package/src/memory/conversation-crud.ts +129 -61
  317. package/src/memory/db-connection.ts +22 -3
  318. package/src/memory/db-init.ts +37 -503
  319. package/src/memory/db-singleton.ts +6 -4
  320. package/src/memory/jobs-worker.ts +104 -0
  321. package/src/memory/llm-request-log-store.ts +26 -1
  322. package/src/memory/llm-usage-store.ts +48 -20
  323. package/src/memory/memory-retrospective-job.ts +14 -8
  324. package/src/memory/migrations/209-strip-thinking-from-consolidated.ts +152 -56
  325. package/src/memory/migrations/300-add-processing-started-at.ts +30 -0
  326. package/src/memory/migrations/301-create-watchdog-events.ts +45 -0
  327. package/src/memory/migrations/302-create-compaction-events.ts +107 -0
  328. package/src/memory/migrations/__tests__/209-strip-thinking-from-consolidated.test.ts +297 -0
  329. package/src/memory/migrations/__tests__/run-migrations.test.ts +2 -2
  330. package/src/memory/migrations/run-migrations.ts +106 -10
  331. package/src/memory/migrations/validate-migration-state.ts +105 -67
  332. package/src/memory/prompt-override.ts +129 -0
  333. package/src/memory/schema/contacts.ts +6 -2
  334. package/src/memory/schema/conversations.ts +37 -0
  335. package/src/memory/schema/infrastructure.ts +20 -0
  336. package/src/memory/steps.ts +1294 -0
  337. package/src/memory/v2/__tests__/cli-command-store.test.ts +25 -0
  338. package/src/memory/v2/__tests__/skill-store.test.ts +80 -0
  339. package/src/memory/v2/cli-command-store.ts +75 -38
  340. package/src/memory/v2/prompts/consolidation.ts +13 -82
  341. package/src/memory/v2/prompts/router.ts +21 -93
  342. package/src/memory/v2/skill-store.ts +68 -31
  343. package/src/memory/watchdog-events-store.ts +87 -0
  344. package/src/memory/worker-control.ts +204 -0
  345. package/src/memory/worker-process.ts +89 -0
  346. package/src/messaging/channel-binding-metadata.ts +31 -0
  347. package/src/messaging/provider-types.ts +8 -0
  348. package/src/messaging/providers/slack/binding-metadata.ts +60 -0
  349. package/src/notifications/__tests__/broadcaster.test.ts +8 -8
  350. package/src/notifications/__tests__/connected-channels.test.ts +86 -0
  351. package/src/notifications/__tests__/decision-engine.test.ts +78 -9
  352. package/src/notifications/__tests__/destination-resolver.test.ts +151 -0
  353. package/src/notifications/broadcaster.ts +8 -1
  354. package/src/notifications/decision-engine.ts +15 -7
  355. package/src/notifications/destination-resolver.ts +53 -25
  356. package/src/notifications/emit-signal.ts +34 -15
  357. package/src/onboarding/checkin-event.test.ts +222 -0
  358. package/src/onboarding/checkin-event.ts +321 -0
  359. package/src/onboarding/schedule-checkin.ts +190 -0
  360. package/src/permissions/question-prompter.test.ts +1 -1
  361. package/src/permissions/question-prompter.ts +7 -4
  362. package/src/plugin-api/index.ts +12 -12
  363. package/src/plugin-api/types.ts +12 -14
  364. package/src/plugin-api/vision-support.test.ts +28 -4
  365. package/src/plugin-api/vision-support.ts +66 -31
  366. package/src/plugins/defaults/empty-response/hooks/post-model-call.ts +2 -2
  367. package/src/plugins/defaults/empty-response/hooks/stop.ts +2 -2
  368. package/src/plugins/defaults/exploration-drift/hooks/post-tool-use.ts +4 -3
  369. package/src/plugins/defaults/history-repair/hooks/post-model-call.ts +2 -2
  370. package/src/plugins/defaults/history-repair/hooks/stop.ts +2 -2
  371. package/src/plugins/defaults/history-repair/hooks/user-prompt-submit.ts +2 -2
  372. package/src/plugins/defaults/image-fallback/__tests__/image-fallback.test.ts +47 -7
  373. package/src/plugins/defaults/image-fallback/hooks/post-tool-use.ts +12 -13
  374. package/src/plugins/defaults/image-fallback/hooks/user-prompt-submit.ts +14 -22
  375. package/src/plugins/defaults/image-fallback/src/caption-blocks.ts +42 -11
  376. package/src/plugins/defaults/image-recovery/hooks/post-model-call.ts +2 -2
  377. package/src/plugins/defaults/image-recovery/hooks/stop.ts +2 -2
  378. package/src/plugins/defaults/index.ts +0 -35
  379. package/src/plugins/defaults/max-tokens-continue/hooks/post-model-call.ts +2 -2
  380. package/src/plugins/defaults/max-tokens-continue/hooks/stop.ts +2 -2
  381. package/src/plugins/defaults/memory-retrieval/hooks/post-compact.ts +2 -2
  382. package/src/plugins/defaults/memory-retrieval/hooks/user-prompt-submit.ts +2 -2
  383. package/src/plugins/defaults/memory-v3-shadow/__tests__/injection.test.ts +33 -3
  384. package/src/plugins/defaults/memory-v3-shadow/__tests__/pool-select.test.ts +48 -4
  385. package/src/plugins/defaults/memory-v3-shadow/__tests__/shadow-plugin.test.ts +4 -8
  386. package/src/plugins/defaults/memory-v3-shadow/hooks/post-compact.ts +2 -2
  387. package/src/plugins/defaults/memory-v3-shadow/hooks/user-prompt-submit.ts +2 -2
  388. package/src/plugins/defaults/memory-v3-shadow/injector.ts +43 -15
  389. package/src/plugins/defaults/memory-v3-shadow/orchestrate.ts +11 -2
  390. package/src/plugins/defaults/memory-v3-shadow/pool-select.test.ts +146 -0
  391. package/src/plugins/defaults/memory-v3-shadow/pool-select.ts +77 -13
  392. package/src/plugins/defaults/memory-v3-shadow/shadow-plugin.ts +12 -11
  393. package/src/plugins/defaults/surface-completion-nudge/hooks/post-model-call.ts +2 -2
  394. package/src/plugins/defaults/surface-completion-nudge/hooks/stop.ts +2 -2
  395. package/src/plugins/defaults/task-progress-nudge/hooks/post-tool-use.ts +2 -2
  396. package/src/plugins/defaults/title-generate/hooks/stop.ts +2 -2
  397. package/src/plugins/defaults/title-generate/hooks/user-prompt-submit.ts +2 -2
  398. package/src/plugins/defaults/tool-error/hooks/post-tool-use.ts +2 -2
  399. package/src/plugins/defaults/tool-result-truncate/hooks/post-tool-use.ts +2 -2
  400. package/src/plugins/disabled-state.ts +31 -0
  401. package/src/plugins/external-plugin-loader.ts +2 -2
  402. package/src/plugins/mtime-cache.ts +186 -330
  403. package/src/plugins/pipeline.ts +111 -13
  404. package/src/plugins/registry.ts +59 -16
  405. package/src/plugins/surface-import.ts +121 -0
  406. package/src/plugins/types.ts +7 -9
  407. package/src/prompts/persona-resolver.ts +43 -11
  408. package/src/providers/anthropic/client.ts +5 -0
  409. package/src/providers/call-site-routing.ts +45 -0
  410. package/src/providers/model-catalog.ts +16 -0
  411. package/src/providers/openai/__tests__/api-error-normalization.test.ts +321 -0
  412. package/src/providers/openai/api-error-normalization.ts +270 -0
  413. package/src/providers/openai/chat-completions-provider.ts +37 -83
  414. package/src/providers/openai/responses-provider.ts +50 -46
  415. package/src/providers/openrouter/client.ts +5 -0
  416. package/src/providers/provider-send-message.ts +10 -0
  417. package/src/providers/ratelimit.ts +10 -0
  418. package/src/providers/registry.ts +1 -1
  419. package/src/providers/retry.ts +10 -0
  420. package/src/providers/types.ts +22 -0
  421. package/src/providers/usage-tracking.ts +10 -0
  422. package/src/runtime/__tests__/channel-verification-service.test.ts +133 -0
  423. package/src/runtime/__tests__/guardian-vellum-migration.test.ts +184 -0
  424. package/src/runtime/__tests__/is-guardian-bound-for-channel.test.ts +66 -0
  425. package/src/runtime/__tests__/local-principal-trust.test.ts +162 -0
  426. package/src/runtime/__tests__/member-verdict-cache.test.ts +119 -0
  427. package/src/runtime/__tests__/trust-verdict-consumer.test.ts +402 -123
  428. package/src/runtime/access-request-helper.ts +18 -39
  429. package/src/runtime/actor-trust-resolver.ts +46 -19
  430. package/src/runtime/anchored-guardian.test.ts +109 -0
  431. package/src/runtime/anchored-guardian.ts +86 -0
  432. package/src/runtime/assistant-event-hub.ts +1 -1
  433. package/src/runtime/assistant-stream-state.ts +9 -2
  434. package/src/runtime/auth/__tests__/require-bound-guardian.test.ts +99 -0
  435. package/src/runtime/auth/require-bound-guardian.ts +21 -11
  436. package/src/runtime/channel-verification-service.ts +56 -31
  437. package/src/runtime/confirmation-request-guardian-bridge.ts +3 -3
  438. package/src/runtime/guardian-vellum-migration.ts +69 -8
  439. package/src/runtime/invite-redemption-service.ts +213 -187
  440. package/src/runtime/local-actor-identity.test.ts +108 -0
  441. package/src/runtime/local-actor-identity.ts +85 -13
  442. package/src/runtime/local-principal-trust.ts +52 -0
  443. package/src/runtime/member-verdict-cache.ts +0 -0
  444. package/src/runtime/pending-interactions.ts +11 -1
  445. package/src/runtime/routes/__tests__/channel-verification-revoke.test.ts +56 -5
  446. package/src/runtime/routes/__tests__/channel-verification-routes.test.ts +1 -1
  447. package/src/runtime/routes/__tests__/contact-routes.test.ts +305 -0
  448. package/src/runtime/routes/__tests__/global-search-routes.test.ts +92 -0
  449. package/src/runtime/routes/__tests__/http-adapter-actor-header.test.ts +129 -0
  450. package/src/runtime/routes/__tests__/surface-action-routes.test.ts +188 -0
  451. package/src/runtime/routes/browser-routes.ts +1 -1
  452. package/src/runtime/routes/canonical-guardian-expiry-sweep.ts +13 -5
  453. package/src/runtime/routes/channel-verification-routes.ts +3 -3
  454. package/src/runtime/routes/contact-routes.ts +48 -57
  455. package/src/runtime/routes/conversation-cli-routes.ts +4 -5
  456. package/src/runtime/routes/conversation-list-routes.ts +4 -7
  457. package/src/runtime/routes/conversation-query-routes.ts +72 -0
  458. package/src/runtime/routes/conversation-routes.ts +84 -85
  459. package/src/runtime/routes/events-routes.ts +2 -2
  460. package/src/runtime/routes/global-search-routes.ts +3 -1
  461. package/src/runtime/routes/guardian-action-routes.ts +4 -5
  462. package/src/runtime/routes/host-app-control-routes.ts +5 -4
  463. package/src/runtime/routes/host-bash-routes.ts +5 -4
  464. package/src/runtime/routes/host-browser-routes.ts +9 -11
  465. package/src/runtime/routes/host-cu-routes.ts +5 -4
  466. package/src/runtime/routes/host-file-routes.ts +5 -4
  467. package/src/runtime/routes/host-transfer-routes.ts +6 -6
  468. package/src/runtime/routes/http-adapter.ts +16 -1
  469. package/src/runtime/routes/identity-routes.ts +3 -2
  470. package/src/runtime/routes/inbound-message-handler.ts +5 -5
  471. package/src/runtime/routes/inbound-stages/acl-enforcement.test.ts +97 -5
  472. package/src/runtime/routes/inbound-stages/acl-enforcement.ts +61 -59
  473. package/src/runtime/routes/inbound-stages/background-dispatch.ts +13 -5
  474. package/src/runtime/routes/inbound-stages/escalation-intercept.ts +7 -7
  475. package/src/runtime/routes/inbound-stages/guardian-activation-intercept.test.ts +21 -8
  476. package/src/runtime/routes/inbound-stages/guardian-activation-intercept.ts +14 -3
  477. package/src/runtime/routes/inbound-stages/reaction-intercept.ts +19 -0
  478. package/src/runtime/routes/index.ts +2 -0
  479. package/src/runtime/routes/llm-context-normalization.ts +83 -0
  480. package/src/runtime/routes/mcp-auth-routes.ts +171 -19
  481. package/src/runtime/routes/migration-rollback-routes.ts +4 -3
  482. package/src/runtime/routes/migration-routes.ts +4 -1
  483. package/src/runtime/routes/onboarding-checkin-routes.ts +86 -0
  484. package/src/runtime/routes/settings-routes.ts +8 -3
  485. package/src/runtime/routes/subagents-routes.ts +5 -0
  486. package/src/runtime/routes/surface-action-routes.ts +42 -56
  487. package/src/runtime/services/__tests__/conversation-serializer.test.ts +1 -0
  488. package/src/runtime/services/conversation-serializer.ts +13 -58
  489. package/src/runtime/tool-grant-request-helper.ts +3 -3
  490. package/src/runtime/trust-verdict-consumer.ts +111 -40
  491. package/src/runtime/verification-outbound-actions.ts +18 -18
  492. package/src/signals/user-message.ts +16 -0
  493. package/src/subagent/__tests__/consult-prompt.test.ts +35 -0
  494. package/src/{plugins/defaults/advisor/__tests__/transcript.test.ts → subagent/__tests__/consult-transcript.test.ts} +47 -10
  495. package/src/{plugins/defaults/advisor/steering.ts → subagent/consult-prompt.ts} +22 -32
  496. package/src/{plugins/defaults/advisor/transcript.ts → subagent/consult-transcript.ts} +18 -8
  497. package/src/subagent/index.ts +1 -1
  498. package/src/subagent/manager.ts +254 -33
  499. package/src/subagent/types.ts +11 -4
  500. package/src/telemetry/types.ts +34 -1
  501. package/src/telemetry/usage-telemetry-reporter.test.ts +3 -2
  502. package/src/telemetry/usage-telemetry-reporter.ts +87 -3
  503. package/src/tools/ask-question/ask-question-tool.test.ts +29 -0
  504. package/src/tools/ask-question/ask-question-tool.ts +13 -0
  505. package/src/tools/executor.ts +4 -4
  506. package/src/tools/filesystem/search.ts +543 -0
  507. package/src/tools/registry.ts +38 -0
  508. package/src/tools/shared/filesystem/path-policy.ts +12 -5
  509. package/src/tools/subagent/consult-deadline.ts +49 -0
  510. package/src/tools/subagent/spawn.ts +234 -5
  511. package/src/tools/tool-approval-handler.ts +1 -1
  512. package/src/tools/tool-defaults.ts +9 -2
  513. package/src/tools/tool-manifest.ts +3 -0
  514. package/src/tools/types.ts +131 -25
  515. package/src/tools/workspace-tools/loader.ts +348 -244
  516. package/src/util/errors.ts +26 -1
  517. package/src/util/logger.ts +9 -0
  518. package/src/util/platform.ts +19 -0
  519. package/src/util/telemetry-db-path.ts +24 -0
  520. package/src/workflows/library.test.ts +140 -0
  521. package/src/workflows/library.ts +82 -28
  522. package/src/workspace/migrations/017-seed-persona-dirs.ts +3 -34
  523. package/src/workspace/migrations/019-scope-journal-to-guardian.ts +3 -24
  524. package/src/workspace/migrations/031-drop-user-md.ts +232 -148
  525. package/src/workspace/migrations/048-remove-workspace-hooks.ts +14 -66
  526. package/src/workspace/migrations/111-prune-seeded-callsite-defaults.ts +134 -0
  527. package/src/workspace/migrations/112-remove-advisor-callsite-override.ts +64 -0
  528. package/src/workspace/migrations/registry.ts +4 -0
  529. package/src/__tests__/workspace-tools-watcher-flag.test.ts +0 -70
  530. package/src/daemon/workspace-tools-watcher.ts +0 -328
  531. package/src/memory/migrations/registry.ts +0 -573
  532. package/src/plugins/defaults/advisor/__tests__/advisor-gate.test.ts +0 -56
  533. package/src/plugins/defaults/advisor/__tests__/advisor-state-store.test.ts +0 -43
  534. package/src/plugins/defaults/advisor/__tests__/agent-loop-integration.test.ts +0 -137
  535. package/src/plugins/defaults/advisor/__tests__/consult.test.ts +0 -153
  536. package/src/plugins/defaults/advisor/__tests__/hooks.test.ts +0 -138
  537. package/src/plugins/defaults/advisor/advisor-gate.ts +0 -29
  538. package/src/plugins/defaults/advisor/advisor-state-store.ts +0 -94
  539. package/src/plugins/defaults/advisor/config.ts +0 -21
  540. package/src/plugins/defaults/advisor/consult.ts +0 -93
  541. package/src/plugins/defaults/advisor/hooks/post-model-call.ts +0 -34
  542. package/src/plugins/defaults/advisor/hooks/pre-model-call.ts +0 -30
  543. package/src/plugins/defaults/advisor/hooks/user-prompt-submit.ts +0 -19
  544. package/src/plugins/defaults/advisor/package.json +0 -14
  545. package/src/plugins/defaults/advisor/tools/advisor.ts +0 -65
  546. package/src/providers/openai/__tests__/api-error-detail.test.ts +0 -120
@@ -0,0 +1,45 @@
1
+ import { Database } from "bun:sqlite";
2
+
3
+ import { getTelemetryDbPath } from "../../util/telemetry-db-path.js";
4
+ import {
5
+ type DrizzleDb,
6
+ getTelemetrySqlite,
7
+ } from "../db-connection.js";
8
+
9
+ /**
10
+ * Create the `watchdog_events` table on the dedicated telemetry database
11
+ * (`assistant-telemetry.db`), not the main DB. The migration runner passes the
12
+ * main DrizzleDb, but this table lives on the telemetry connection, so we open
13
+ * that connection and run DDL against it directly. The dedicated connection
14
+ * itself performs no DDL on open, so this migration owns the schema.
15
+ *
16
+ * Idempotent (`IF NOT EXISTS`). Writes are gated on `share_analytics`
17
+ * consent at the store level, so opted-out rows never exist and the
18
+ * reporter's standard 0 watermark default is safe. The index backs the
19
+ * telemetry reporter's compound `(created_at, id)` watermark cursor.
20
+ *
21
+ * The `mainDb` parameter is accepted to satisfy the migration-step signature but
22
+ * is not used — this migration operates exclusively on the telemetry DB.
23
+ */
24
+ export function createWatchdogEventsTable(_mainDb: DrizzleDb): void {
25
+ let raw: Database | null = getTelemetrySqlite();
26
+ if (!raw) {
27
+ // The dedicated connection failed to open (logged by openDedicatedDb).
28
+ // Fall back to opening the file directly so the migration still runs —
29
+ // the singleton will pick it up on a later access. This mirrors the
30
+ // fail-soft pattern of the other dedicated-DB migrations.
31
+ raw = new Database(getTelemetryDbPath());
32
+ }
33
+ raw.exec(/*sql*/ `
34
+ CREATE TABLE IF NOT EXISTS watchdog_events (
35
+ id TEXT PRIMARY KEY,
36
+ created_at INTEGER NOT NULL,
37
+ check_name TEXT NOT NULL,
38
+ value REAL,
39
+ detail TEXT
40
+ )
41
+ `);
42
+ raw.exec(
43
+ /*sql*/ `CREATE INDEX IF NOT EXISTS idx_watchdog_events_created_at_id ON watchdog_events (created_at, id)`,
44
+ );
45
+ }
@@ -0,0 +1,107 @@
1
+ import { type DrizzleDb, getSqliteFrom } from "../db-connection.js";
2
+
3
+ /**
4
+ * Create the append-only `conversation_compaction_events` ledger and backfill
5
+ * one event per already-compacted conversation from its current cache columns.
6
+ *
7
+ * The `conversations` row keeps the latest compaction
8
+ * (`context_summary` / `context_compacted_message_count` /
9
+ * `context_compacted_at`) as the hot-path cache the load path reads; this table
10
+ * preserves the full history so a fork can inherit the most recent compaction
11
+ * whose event time predates the message it forks from. Pre-feature history
12
+ * beyond the latest compaction is unrecoverable, so existing rows seed exactly
13
+ * one event.
14
+ *
15
+ * Idempotent: table creation is guarded on sqlite_master; the backfill is
16
+ * guarded by a memory_checkpoints key and a per-conversation NOT EXISTS so a
17
+ * lost checkpoint cannot duplicate rows.
18
+ */
19
+ export function migrateCreateCompactionEvents(database: DrizzleDb): void {
20
+ const raw = getSqliteFrom(database);
21
+
22
+ const tableExists = raw
23
+ .query(
24
+ `SELECT 1 FROM sqlite_master WHERE type = 'table' AND name = 'conversation_compaction_events'`,
25
+ )
26
+ .get();
27
+
28
+ if (!tableExists) {
29
+ try {
30
+ raw.exec("BEGIN");
31
+
32
+ raw.exec(/*sql*/ `
33
+ CREATE TABLE conversation_compaction_events (
34
+ id TEXT PRIMARY KEY,
35
+ conversation_id TEXT NOT NULL REFERENCES conversations(id) ON DELETE CASCADE,
36
+ compacted_at INTEGER NOT NULL,
37
+ summary TEXT NOT NULL,
38
+ compacted_message_count INTEGER NOT NULL,
39
+ created_at INTEGER NOT NULL
40
+ )
41
+ `);
42
+
43
+ raw.exec(/*sql*/ `
44
+ CREATE INDEX idx_compaction_events_conv_at
45
+ ON conversation_compaction_events(conversation_id, compacted_at)
46
+ `);
47
+
48
+ raw.exec("COMMIT");
49
+ } catch (e) {
50
+ try {
51
+ raw.exec("ROLLBACK");
52
+ } catch {
53
+ /* no active transaction */
54
+ }
55
+ throw e;
56
+ }
57
+ }
58
+
59
+ const checkpointKey = "backfill_conversation_compaction_events_v1";
60
+ const checkpoint = raw
61
+ .query(`SELECT 1 FROM memory_checkpoints WHERE key = ?`)
62
+ .get(checkpointKey);
63
+ if (checkpoint) return;
64
+
65
+ try {
66
+ raw.exec("BEGIN");
67
+
68
+ raw
69
+ .query(
70
+ /*sql*/ `
71
+ INSERT INTO conversation_compaction_events
72
+ (id, conversation_id, compacted_at, summary, compacted_message_count, created_at)
73
+ SELECT
74
+ lower(hex(randomblob(16))),
75
+ c.id,
76
+ c.context_compacted_at,
77
+ c.context_summary,
78
+ c.context_compacted_message_count,
79
+ ?
80
+ FROM conversations c
81
+ WHERE c.context_compacted_message_count > 0
82
+ AND c.context_compacted_at IS NOT NULL
83
+ AND c.context_summary IS NOT NULL
84
+ AND NOT EXISTS (
85
+ SELECT 1 FROM conversation_compaction_events e
86
+ WHERE e.conversation_id = c.id
87
+ )
88
+ `,
89
+ )
90
+ .run(Date.now());
91
+
92
+ raw
93
+ .query(
94
+ `INSERT OR IGNORE INTO memory_checkpoints (key, value, updated_at) VALUES (?, '1', ?)`,
95
+ )
96
+ .run(checkpointKey, Date.now());
97
+
98
+ raw.exec("COMMIT");
99
+ } catch (e) {
100
+ try {
101
+ raw.exec("ROLLBACK");
102
+ } catch {
103
+ /* no active transaction */
104
+ }
105
+ throw e;
106
+ }
107
+ }
@@ -0,0 +1,297 @@
1
+ /**
2
+ * Tests for migration 209 — stripping thinking / redacted_thinking blocks from
3
+ * persisted assistant messages.
4
+ *
5
+ * The migration rewrites content entirely inside SQLite (JSON1), dispatched a
6
+ * rowid window at a time through `runAsyncSqlite`. These tests drive the step
7
+ * directly against a real DB and assert the at-rest content, idempotency,
8
+ * scoping (assistant rows only), tolerance of malformed content, and that the
9
+ * persisted rowid watermark is honored for resume.
10
+ */
11
+ import { describe, expect, test } from "bun:test";
12
+
13
+ const { getDb, getSqlite } = await import("../../db-connection.js");
14
+ const { initializeDb } = await import("../../db-init.js");
15
+ const {
16
+ migrateStripThinkingFromConsolidated,
17
+ ROWID_WINDOW,
18
+ WINDOW_TIMEOUT_MS,
19
+ } = await import("../209-strip-thinking-from-consolidated.js");
20
+
21
+ await initializeDb();
22
+
23
+ const CONV = "conv-209";
24
+ getSqlite()
25
+ .query(
26
+ `INSERT OR IGNORE INTO conversations (id, created_at, updated_at) VALUES (?, ?, ?)`,
27
+ )
28
+ .run(CONV, Date.now(), Date.now());
29
+
30
+ let seq = 0;
31
+ function insert(role: string, content: string): { id: string; rowid: number } {
32
+ const id = `m209-${seq++}`;
33
+ getSqlite()
34
+ .query(
35
+ `INSERT INTO messages (id, conversation_id, role, content, created_at) VALUES (?, ?, ?, ?, ?)`,
36
+ )
37
+ .run(id, CONV, role, content, Date.now());
38
+ const rowid = (
39
+ getSqlite()
40
+ .query(`SELECT rowid AS r FROM messages WHERE id = ?`)
41
+ .get(id) as { r: number }
42
+ ).r;
43
+ return { id, rowid };
44
+ }
45
+
46
+ /** Insert at an explicit rowid so a test can place rows on either side of a
47
+ * window boundary without materializing every intervening row. */
48
+ function insertAt(
49
+ rowid: number,
50
+ role: string,
51
+ content: string,
52
+ ): { id: string; rowid: number } {
53
+ const id = `m209-at-${rowid}`;
54
+ getSqlite()
55
+ .query(
56
+ `INSERT INTO messages (rowid, id, conversation_id, role, content, created_at) VALUES (?, ?, ?, ?, ?, ?)`,
57
+ )
58
+ .run(rowid, id, CONV, role, content, Date.now());
59
+ return { id, rowid };
60
+ }
61
+
62
+ function content(id: string): string {
63
+ return (
64
+ getSqlite().query(`SELECT content FROM messages WHERE id = ?`).get(id) as {
65
+ content: string;
66
+ }
67
+ ).content;
68
+ }
69
+
70
+ function blocks(id: string): Array<Record<string, unknown>> {
71
+ return JSON.parse(content(id));
72
+ }
73
+
74
+ /** The persisted resume watermark, or null once the sweep has cleared it. */
75
+ function watermark(): unknown {
76
+ return getSqlite()
77
+ .query(`SELECT value FROM memory_checkpoints WHERE key = ?`)
78
+ .get("migration_209_strip_thinking_watermark");
79
+ }
80
+
81
+ describe("migration 209 — strip thinking from consolidated assistant messages", () => {
82
+ test("strips thinking blocks but keeps text and tool_use, preserving order", async () => {
83
+ const { id } = insert(
84
+ "assistant",
85
+ JSON.stringify([
86
+ { type: "thinking", thinking: "secret", signature: "sig" },
87
+ { type: "text", text: "hello" },
88
+ { type: "tool_use", id: "t1", name: "x", input: { a: 1 } },
89
+ ]),
90
+ );
91
+
92
+ await migrateStripThinkingFromConsolidated(getDb());
93
+
94
+ expect(blocks(id)).toEqual([
95
+ { type: "text", text: "hello" },
96
+ { type: "tool_use", id: "t1", name: "x", input: { a: 1 } },
97
+ ]);
98
+ });
99
+
100
+ test("strips redacted_thinking blocks", async () => {
101
+ const { id } = insert(
102
+ "assistant",
103
+ JSON.stringify([
104
+ { type: "redacted_thinking", data: "blob" },
105
+ { type: "text", text: "world" },
106
+ ]),
107
+ );
108
+
109
+ await migrateStripThinkingFromConsolidated(getDb());
110
+
111
+ expect(blocks(id)).toEqual([{ type: "text", text: "world" }]);
112
+ });
113
+
114
+ test("all-thinking message becomes the null-byte placeholder sentinel", async () => {
115
+ const { id } = insert(
116
+ "assistant",
117
+ JSON.stringify([
118
+ { type: "thinking", thinking: "a", signature: "s1" },
119
+ { type: "redacted_thinking", data: "b" },
120
+ ]),
121
+ );
122
+
123
+ await migrateStripThinkingFromConsolidated(getDb());
124
+
125
+ const result = blocks(id);
126
+ expect(result).toHaveLength(1);
127
+ expect(result[0].type).toBe("text");
128
+ expect(result[0].text).toBe("\x00__PLACEHOLDER__[internal blocks omitted]");
129
+ // The leading byte must be a literal NUL, produced by SQLite's char(0).
130
+ expect((result[0].text as string).charCodeAt(0)).toBe(0);
131
+ });
132
+
133
+ test("preserves blocks with a missing/null type", async () => {
134
+ const { id } = insert(
135
+ "assistant",
136
+ JSON.stringify([
137
+ { type: "thinking", thinking: "x", signature: "s" },
138
+ { foo: "bar" },
139
+ { type: "text", text: "kept" },
140
+ ]),
141
+ );
142
+
143
+ await migrateStripThinkingFromConsolidated(getDb());
144
+
145
+ expect(blocks(id)).toEqual([
146
+ { foo: "bar" },
147
+ { type: "text", text: "kept" },
148
+ ]);
149
+ });
150
+
151
+ test("leaves thinking-free assistant messages untouched", async () => {
152
+ const original = JSON.stringify([
153
+ { type: "text", text: "I was thinking about lunch" },
154
+ ]);
155
+ const { id } = insert("assistant", original);
156
+
157
+ await migrateStripThinkingFromConsolidated(getDb());
158
+
159
+ // Substring 'thinking' appears in the text but no block is of thinking type.
160
+ expect(content(id)).toBe(original);
161
+ });
162
+
163
+ test("does not touch non-assistant roles", async () => {
164
+ const original = JSON.stringify([
165
+ { type: "thinking", thinking: "x", signature: "s" },
166
+ { type: "text", text: "u" },
167
+ ]);
168
+ const { id } = insert("user", original);
169
+
170
+ await migrateStripThinkingFromConsolidated(getDb());
171
+
172
+ expect(content(id)).toBe(original);
173
+ });
174
+
175
+ test("tolerates non-array and invalid JSON content", async () => {
176
+ const obj = insert(
177
+ "assistant",
178
+ JSON.stringify({ type: "thinking", thinking: "x" }),
179
+ );
180
+ const invalid = insert("assistant", "{not json with thinking");
181
+
182
+ await migrateStripThinkingFromConsolidated(getDb());
183
+
184
+ expect(content(obj.id)).toBe(
185
+ JSON.stringify({ type: "thinking", thinking: "x" }),
186
+ );
187
+ expect(content(invalid.id)).toBe("{not json with thinking");
188
+ });
189
+
190
+ test("is idempotent across repeated runs", async () => {
191
+ const { id } = insert(
192
+ "assistant",
193
+ JSON.stringify([
194
+ { type: "thinking", thinking: "x", signature: "s" },
195
+ { type: "text", text: "stable" },
196
+ ]),
197
+ );
198
+
199
+ await migrateStripThinkingFromConsolidated(getDb());
200
+ const once = content(id);
201
+ await migrateStripThinkingFromConsolidated(getDb());
202
+ const twice = content(id);
203
+
204
+ expect(twice).toBe(once);
205
+ expect(blocks(id)).toEqual([{ type: "text", text: "stable" }]);
206
+ });
207
+
208
+ test("honors the persisted rowid watermark and resumes above it", async () => {
209
+ const below = insert(
210
+ "assistant",
211
+ JSON.stringify([
212
+ { type: "thinking", thinking: "x", signature: "s" },
213
+ { type: "text", text: "below" },
214
+ ]),
215
+ );
216
+ const above = insert(
217
+ "assistant",
218
+ JSON.stringify([
219
+ { type: "thinking", thinking: "y", signature: "s" },
220
+ { type: "text", text: "above" },
221
+ ]),
222
+ );
223
+
224
+ // Pretend a prior run already swept through `below`'s rowid: the sweep must
225
+ // resume strictly above it, leaving `below` untouched and cleaning `above`.
226
+ getSqlite()
227
+ .query(
228
+ `INSERT OR REPLACE INTO memory_checkpoints (key, value, updated_at) VALUES (?, ?, ?)`,
229
+ )
230
+ .run(
231
+ "migration_209_strip_thinking_watermark",
232
+ String(below.rowid),
233
+ Date.now(),
234
+ );
235
+
236
+ await migrateStripThinkingFromConsolidated(getDb());
237
+
238
+ expect(blocks(below.id)).toEqual([
239
+ { type: "thinking", thinking: "x", signature: "s" },
240
+ { type: "text", text: "below" },
241
+ ]);
242
+ expect(blocks(above.id)).toEqual([{ type: "text", text: "above" }]);
243
+
244
+ // The watermark is cleared once the sweep reaches the end of the table.
245
+ expect(watermark()).toBeNull();
246
+ });
247
+
248
+ test("sweeps a rowid span wider than one window across multiple windows", async () => {
249
+ // Place rows on either side of a window boundary so the sweep must iterate
250
+ // the window loop more than once to reach them. The original 100k window
251
+ // collapsed any table smaller than itself into a single subprocess sweep —
252
+ // this exercises the bounded-window loop that replaces it.
253
+ const base =
254
+ (
255
+ getSqlite().query(`SELECT MAX(rowid) AS m FROM messages`).get() as {
256
+ m: number | null;
257
+ }
258
+ ).m ?? 0;
259
+ const first = insertAt(
260
+ base + ROWID_WINDOW,
261
+ "assistant",
262
+ JSON.stringify([
263
+ { type: "thinking", thinking: "a", signature: "s" },
264
+ { type: "text", text: "first" },
265
+ ]),
266
+ );
267
+ const second = insertAt(
268
+ base + 2 * ROWID_WINDOW + 1,
269
+ "assistant",
270
+ JSON.stringify([
271
+ { type: "thinking", thinking: "b", signature: "s" },
272
+ { type: "text", text: "second" },
273
+ ]),
274
+ );
275
+
276
+ await migrateStripThinkingFromConsolidated(getDb());
277
+
278
+ // Both rows are cleaned even though they sit in different windows, and the
279
+ // sweep runs to completion (watermark cleared) rather than stalling on the
280
+ // first window.
281
+ expect(blocks(first.id)).toEqual([{ type: "text", text: "first" }]);
282
+ expect(blocks(second.id)).toEqual([{ type: "text", text: "second" }]);
283
+ expect(watermark()).toBeNull();
284
+ });
285
+
286
+ test("keeps the sweep window and timeout bounded so it cannot overrun a whole table", () => {
287
+ // Regression guard: ROWID_WINDOW was 100_000, larger than a typical
288
+ // messages table, so the entire table swept in one subprocess that overran
289
+ // runAsyncSqlite's 1h cap, never advanced the watermark, and re-ran the
290
+ // identical doomed window every boot. The window must stay small enough that
291
+ // a single window finishes well within its timeout, and the per-window cap
292
+ // must stay below the 1h whole-process default so a stuck window surfaces in
293
+ // minutes instead of blocking startup for an hour.
294
+ expect(ROWID_WINDOW).toBeLessThanOrEqual(10_000);
295
+ expect(WINDOW_TIMEOUT_MS).toBeLessThan(60 * 60 * 1000);
296
+ });
297
+ });
@@ -54,7 +54,7 @@ describe("runMigrationSteps — checkpointing", () => {
54
54
 
55
55
  test("records step completions in the shared memory_checkpoints ledger", async () => {
56
56
  /**
57
- * Step bookkeeping lives in the same memory_checkpoints table the registry
57
+ * Step bookkeeping lives in the same memory_checkpoints table the step runner
58
58
  * uses, under the `step:` namespace — one ledger for all applied state.
59
59
  */
60
60
 
@@ -110,7 +110,7 @@ describe("runMigrationSteps — checkpointing", () => {
110
110
  * before the loop so a migration interrupted mid-flight re-runs this boot.
111
111
  */
112
112
 
113
- // GIVEN a database with a stalled registry checkpoint left by a crash
113
+ // GIVEN a database with a stalled step checkpoint left by a crash
114
114
  const db = createTestDb();
115
115
  const raw = getSqliteFrom(db);
116
116
  raw.run(
@@ -4,10 +4,45 @@ import { type DrizzleDb, getSqliteFrom } from "../db-connection.js";
4
4
 
5
5
  const log = getLogger("db-init");
6
6
 
7
+ /**
8
+ * Rollback metadata for a migration step that can be reversed.
9
+ *
10
+ * A single step may carry multiple rollback entries (e.g. migration 162 has
11
+ * two: one for the timestamp conversion and one for the table rebuild). Each
12
+ * entry has its own monotonic version number for rollback ordering and its
13
+ * own `down()` function.
14
+ */
15
+ export interface RollbackEntry {
16
+ /** Monotonic version used for rollback ordering. */
17
+ version: number;
18
+ /** Human-readable description for diagnostics. */
19
+ description: string;
20
+ /** Reverse the migration. Must be idempotent — safe to re-run. */
21
+ down: (database: DrizzleDb) => void;
22
+ }
23
+
24
+ /**
25
+ * Object form of a migration step, carrying optional rollback metadata and
26
+ * dependency declarations inline — no separate registry needed.
27
+ */
28
+ export interface MigrationStepObject {
29
+ /** Step name — used for `step:*` checkpoint key, logging, and skip logic. */
30
+ name: string;
31
+ /** Forward migration body. */
32
+ run: (database: DrizzleDb) => void | Promise<void>;
33
+ /** Step names that must complete before this step runs. */
34
+ dependsOn?: string[];
35
+ /** Rollback entries — present if this step has down() function(s). */
36
+ rollback?: RollbackEntry[];
37
+ }
38
+
7
39
  /**
8
40
  * A single forward migration step, identified for checkpointing and logging by
9
41
  * its `.name`. Anonymous steps (empty `.name`) cannot be tracked and always run.
10
42
  *
43
+ * Bare function steps are identified by `Function.name`. Object-form steps
44
+ * carry an explicit `name` plus optional `rollback` and `dependsOn` metadata.
45
+ *
11
46
  * A step may be synchronous or return a promise. The runner awaits an async
12
47
  * step to completion before checkpointing it and moving on, so ordering is
13
48
  * preserved exactly as for sync steps: step N+1 never starts — and is never
@@ -16,7 +51,56 @@ const log = getLogger("db-init");
16
51
  * thread between batches while still guaranteeing later migrations observe its
17
52
  * completed result.
18
53
  */
19
- export type MigrationStep = (database: DrizzleDb) => void | Promise<void>;
54
+ export type MigrationStep =
55
+ | MigrationStepObject
56
+ | ((database: DrizzleDb) => void | Promise<void>);
57
+
58
+ /**
59
+ * Normalize a {@link MigrationStep} (which may be a bare function or an object)
60
+ * into its object form so callers don't need to type-narrow.
61
+ */
62
+ export function normalizeStep(step: MigrationStep): MigrationStepObject {
63
+ if (typeof step === "function") {
64
+ return { name: step.name, run: step };
65
+ }
66
+ return step;
67
+ }
68
+
69
+ /**
70
+ * Extract the step name from either form of {@link MigrationStep}.
71
+ */
72
+ export function getStepName(step: MigrationStep): string {
73
+ return typeof step === "function" ? step.name : step.name;
74
+ }
75
+
76
+ /**
77
+ * Get the maximum rollback version across all steps that carry rollback
78
+ * metadata. Returns 0 if no steps have rollback entries.
79
+ */
80
+ export function getMaxRollbackVersion(steps: MigrationStep[]): number {
81
+ let max = 0;
82
+ for (const step of steps) {
83
+ if (typeof step === "function") continue;
84
+ if (!step.rollback) continue;
85
+ for (const entry of step.rollback) {
86
+ if (entry.version > max) max = entry.version;
87
+ }
88
+ }
89
+ return max;
90
+ }
91
+
92
+ /**
93
+ * Collect all step names that appear in the steps array (both bare-function
94
+ * and object-form). Used by {@link validateMigrationState} to detect
95
+ * checkpoints from a newer daemon version.
96
+ */
97
+ export function getKnownStepNames(steps: MigrationStep[]): Set<string> {
98
+ const names = new Set<string>();
99
+ for (const step of steps) {
100
+ names.add(getStepName(step));
101
+ }
102
+ return names;
103
+ }
20
104
 
21
105
  export interface MigrationRunResult {
22
106
  /** Steps that ran and completed successfully this boot. */
@@ -30,9 +114,8 @@ export interface MigrationRunResult {
30
114
  /**
31
115
  * Prefix under which forward-step completions are recorded in the shared
32
116
  * `memory_checkpoints` ledger. A distinct namespace keeps step bookkeeping from
33
- * colliding with registry checkpoint keys (`migration_*`, `backfill_*`,
34
- * `drop_*`) and is deliberately chosen so `validateMigrationState` does not
35
- * mistake a step record for an unknown registry migration.
117
+ * colliding with legacy checkpoint keys (`migration_*`, `backfill_*`,
118
+ * `drop_*`) left by older migration functions.
36
119
  */
37
120
  export const STEP_CHECKPOINT_PREFIX = "step:";
38
121
 
@@ -160,9 +243,13 @@ export async function runMigrationSteps(
160
243
  const skipped: string[] = [];
161
244
  const ran: string[] = [];
162
245
 
163
- for (const step of steps) {
164
- const name = step.name;
246
+ const totalSteps = steps.length;
247
+ for (const [index, step] of steps.entries()) {
248
+ const obj = normalizeStep(step);
249
+ const name = obj.name;
165
250
  const checkpointable = name !== "";
251
+ // 1-based position of this step in the ordered migration sequence.
252
+ const stepNumber = index + 1;
166
253
 
167
254
  if (checkpointable && applied.has(name)) {
168
255
  skipped.push(name);
@@ -174,12 +261,18 @@ export async function runMigrationSteps(
174
261
  if (checkpointable) {
175
262
  markStarted.run(`${STEP_CHECKPOINT_PREFIX}${name}`, Date.now());
176
263
  }
177
- log.info({ migration: name }, `Starting migration: ${name}`);
178
- const result = step(database);
264
+ log.info(
265
+ { migration: name, step: stepNumber, totalSteps },
266
+ "Migration started",
267
+ );
268
+ const result = obj.run(database);
179
269
  if (result instanceof Promise) {
180
270
  await result;
181
271
  }
182
- log.info({ migration: name }, `Migration succeeded: ${name}`);
272
+ log.info(
273
+ { migration: name, step: stepNumber, totalSteps },
274
+ "Migration succeeded",
275
+ );
183
276
  if (checkpointable) {
184
277
  markApplied.run(`${STEP_CHECKPOINT_PREFIX}${name}`, Date.now());
185
278
  ran.push(name);
@@ -189,7 +282,10 @@ export async function runMigrationSteps(
189
282
  // recoverCrashedMigrations will detect it on the next boot, log
190
283
  // a warning, and clear it so the step re-runs.
191
284
  failed.push(name);
192
- log.error({ err, migration: name }, `Migration failed: ${name}`);
285
+ log.error(
286
+ { err, migration: name, step: stepNumber, totalSteps },
287
+ "Migration failed",
288
+ );
193
289
  }
194
290
  }
195
291