@vellumai/assistant 0.10.2 → 0.10.3-dev.202606252046.9075fd5

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (546) hide show
  1. package/bun.lock +20 -0
  2. package/docs/workspace-tools.md +42 -33
  3. package/eslint-rules/cli-no-daemon-internals.js +6 -0
  4. package/node_modules/@vellumai/gateway-client/src/__tests__/guardian-delivery-contract.test.ts +91 -0
  5. package/node_modules/@vellumai/gateway-client/src/__tests__/trust-verdict-contract.test.ts +31 -0
  6. package/node_modules/@vellumai/gateway-client/src/gateway-ipc-contracts.ts +44 -0
  7. package/node_modules/@vellumai/gateway-client/src/guardian-delivery-contract.ts +48 -0
  8. package/node_modules/@vellumai/gateway-client/src/index.ts +14 -0
  9. package/node_modules/@vellumai/gateway-client/src/trust-verdict-contract.ts +17 -0
  10. package/node_modules/@vellumai/service-contracts/package.json +1 -0
  11. package/node_modules/@vellumai/service-contracts/src/__tests__/channels.test.ts +28 -0
  12. package/node_modules/@vellumai/service-contracts/src/channels.ts +41 -0
  13. package/node_modules/@vellumai/service-contracts/src/index.ts +1 -0
  14. package/openapi.yaml +196 -56
  15. package/package.json +4 -1
  16. package/scripts/test.sh +36 -15
  17. package/src/__tests__/actor-token-service.test.ts +36 -14
  18. package/src/__tests__/actor-trust-resolver-address-fallback.test.ts +83 -31
  19. package/src/__tests__/agent-loop-override-profile.test.ts +1 -0
  20. package/src/__tests__/agent-wake-disk-pressure-callsite.test.ts +2 -0
  21. package/src/__tests__/agent-wake-override-profile.test.ts +2 -0
  22. package/src/__tests__/annotate-activity-metadata.test.ts +2 -0
  23. package/src/__tests__/annotate-risk-options.test.ts +2 -0
  24. package/src/__tests__/approval-cascade.test.ts +2 -0
  25. package/src/__tests__/assistant-attachments.test.ts +42 -0
  26. package/src/__tests__/background-workers-disk-pressure.test.ts +2 -0
  27. package/src/__tests__/btw-routes.test.ts +2 -0
  28. package/src/__tests__/build-persisted-content.test.ts +2 -0
  29. package/src/__tests__/call-controller.test.ts +19 -0
  30. package/src/__tests__/channel-approval-routes.test.ts +21 -26
  31. package/src/__tests__/channel-delivery-store.test.ts +28 -0
  32. package/src/__tests__/channel-guardian.test.ts +164 -78
  33. package/src/__tests__/channel-inbound-disk-pressure.test.ts +11 -19
  34. package/src/__tests__/channel-reply-delivery.test.ts +2 -0
  35. package/src/__tests__/code-search-tool.test.ts +585 -0
  36. package/src/__tests__/compaction-events.test.ts +2 -0
  37. package/src/__tests__/compaction-ledger-store.test.ts +128 -0
  38. package/src/__tests__/compaction.benchmark.test.ts +2 -0
  39. package/src/__tests__/compactor-call-site-logging.test.ts +2 -0
  40. package/src/__tests__/compactor-low-watermark-cut.test.ts +2 -0
  41. package/src/__tests__/compactor-preserved-tail-count.test.ts +2 -0
  42. package/src/__tests__/compactor-summary-call-truncation.test.ts +2 -0
  43. package/src/__tests__/compactor-web-search-strip.test.ts +2 -0
  44. package/src/__tests__/config-loader-backfill.test.ts +123 -10
  45. package/src/__tests__/config-schema.test.ts +1 -0
  46. package/src/__tests__/confirmation-request-guardian-bridge.test.ts +31 -29
  47. package/src/__tests__/consult-deadline.test.ts +60 -0
  48. package/src/__tests__/contact-store-interaction-info.test.ts +156 -0
  49. package/src/__tests__/contact-store-user-file.test.ts +7 -10
  50. package/src/__tests__/contacts-relay-reads.test.ts +19 -24
  51. package/src/__tests__/contacts-write.test.ts +0 -2
  52. package/src/__tests__/conversation-abort-tool-results.test.ts +2 -0
  53. package/src/__tests__/conversation-agent-loop-disk-pressure.test.ts +2 -0
  54. package/src/__tests__/conversation-agent-loop-inference-profile.test.ts +2 -0
  55. package/src/__tests__/conversation-agent-loop-overflow.test.ts +2 -0
  56. package/src/__tests__/conversation-agent-loop.test.ts +134 -0
  57. package/src/__tests__/conversation-analysis-routes.test.ts +2 -0
  58. package/src/__tests__/conversation-app-control-lifecycle.test.ts +2 -0
  59. package/src/__tests__/conversation-attention-telegram.test.ts +9 -11
  60. package/src/__tests__/conversation-confirmation-signals.test.ts +2 -0
  61. package/src/__tests__/conversation-fork-crud.test.ts +354 -24
  62. package/src/__tests__/conversation-history-web-search.test.ts +2 -0
  63. package/src/__tests__/conversation-load-history-repair.test.ts +2 -0
  64. package/src/__tests__/conversation-load-history-stripped.test.ts +2 -0
  65. package/src/__tests__/conversation-pairing.test.ts +2 -0
  66. package/src/__tests__/conversation-process-app-control-preactivation.test.ts +2 -0
  67. package/src/__tests__/conversation-process-callsite.test.ts +2 -0
  68. package/src/__tests__/conversation-provider-retry-repair.test.ts +2 -0
  69. package/src/__tests__/conversation-queue.test.ts +91 -0
  70. package/src/__tests__/conversation-routes-guardian-reply.test.ts +14 -0
  71. package/src/__tests__/conversation-routes-slash-commands.test.ts +14 -0
  72. package/src/__tests__/conversation-slash-queue.test.ts +2 -0
  73. package/src/__tests__/conversation-slash-unknown.test.ts +2 -0
  74. package/src/__tests__/conversation-speed-override.test.ts +2 -0
  75. package/src/__tests__/conversation-surfaces-task-progress.test.ts +29 -0
  76. package/src/__tests__/conversation-title-service.test.ts +2 -0
  77. package/src/__tests__/conversation-tool-setup-attribution.test.ts +47 -0
  78. package/src/__tests__/conversation-usage.test.ts +2 -0
  79. package/src/__tests__/conversation-workspace-cache-state.test.ts +2 -0
  80. package/src/__tests__/conversation-workspace-injection.test.ts +2 -0
  81. package/src/__tests__/conversation-workspace-tool-tracking.test.ts +2 -0
  82. package/src/__tests__/credential-security-invariants.test.ts +1 -1
  83. package/src/__tests__/db-compaction-events-migration.test.ts +129 -0
  84. package/src/__tests__/db-migration-rollback.test.ts +205 -171
  85. package/src/__tests__/db-test-helpers.ts +5 -4
  86. package/src/__tests__/delete-propagation.test.ts +5 -3
  87. package/src/__tests__/deterministic-verification-control-plane.test.ts +4 -2
  88. package/src/__tests__/disk-pressure-guard.test.ts +41 -0
  89. package/src/__tests__/dm-backfill.test.ts +6 -4
  90. package/src/__tests__/dm-persistence.test.ts +2 -0
  91. package/src/__tests__/emit-signal-routing-intent.test.ts +7 -6
  92. package/src/__tests__/events-dev-bypass-actor.test.ts +7 -1
  93. package/src/__tests__/exploration-drift-hook.test.ts +3 -2
  94. package/src/__tests__/filing-service.test.ts +2 -0
  95. package/src/__tests__/guardian-binding-drift-heal.test.ts +104 -19
  96. package/src/__tests__/guardian-dispatch.test.ts +140 -1
  97. package/src/__tests__/guardian-expiry-notifier.test.ts +282 -0
  98. package/src/__tests__/guardian-outbound-http.test.ts +13 -0
  99. package/src/__tests__/guardian-routing-state.test.ts +6 -10
  100. package/src/__tests__/heartbeat-disk-pressure.test.ts +2 -0
  101. package/src/__tests__/heartbeat-service.test.ts +2 -0
  102. package/src/__tests__/helpers/channel-test-adapter.ts +46 -19
  103. package/src/__tests__/helpers/create-guardian-binding.ts +15 -23
  104. package/src/__tests__/helpers/mock-logger.ts +1 -0
  105. package/src/__tests__/helpers/seed-contact-channel.ts +96 -0
  106. package/src/__tests__/host-app-control-routes.test.ts +24 -30
  107. package/src/__tests__/host-bash-routes.test.ts +31 -41
  108. package/src/__tests__/host-browser-routes.test.ts +26 -32
  109. package/src/__tests__/host-cu-routes-targeted.test.ts +25 -33
  110. package/src/__tests__/host-file-routes-targeted.test.ts +40 -52
  111. package/src/__tests__/host-transfer-routes-targeted.test.ts +31 -43
  112. package/src/__tests__/http-user-message-parity.test.ts +290 -8
  113. package/src/__tests__/inbound-invite-redemption.test.ts +115 -10
  114. package/src/__tests__/inbound-slack-persistence.test.ts +2 -0
  115. package/src/__tests__/invite-redemption-service.test.ts +471 -53
  116. package/src/__tests__/invite-routes-http.test.ts +34 -0
  117. package/src/__tests__/invite-service-ipc.test.ts +65 -2
  118. package/src/__tests__/llm-context-normalization.test.ts +105 -0
  119. package/src/__tests__/llm-request-log-error-payload.test.ts +71 -9
  120. package/src/__tests__/llm-usage-store.test.ts +25 -0
  121. package/src/__tests__/mcp-config-secret-boundary.test.ts +392 -0
  122. package/src/__tests__/mcp-health-check.test.ts +2 -1
  123. package/src/__tests__/media-stream-server-integration.test.ts +127 -0
  124. package/src/__tests__/memory-retrieval-hook.test.ts +2 -0
  125. package/src/__tests__/messaging-send-tool.test.ts +2 -0
  126. package/src/__tests__/migration-import-from-url.test.ts +2 -2
  127. package/src/__tests__/mtime-cache.test.ts +275 -5
  128. package/src/__tests__/native-web-search.test.ts +2 -0
  129. package/src/__tests__/non-member-access-request.test.ts +191 -17
  130. package/src/__tests__/notification-broadcaster.test.ts +4 -0
  131. package/src/__tests__/notification-decision-recipient-context.test.ts +33 -32
  132. package/src/__tests__/notification-deep-link.test.ts +6 -0
  133. package/src/__tests__/notification-guardian-path.test.ts +19 -0
  134. package/src/__tests__/onboarding-persona-write.test.ts +52 -22
  135. package/src/__tests__/openai-provider.test.ts +22 -12
  136. package/src/__tests__/openai-responses-provider.test.ts +12 -2
  137. package/src/__tests__/outbound-slack-persistence.test.ts +2 -0
  138. package/src/__tests__/pending-interactions-resolved-event.test.ts +7 -4
  139. package/src/__tests__/persist-onboarding-artifacts.test.ts +1 -0
  140. package/src/__tests__/persistence-secret-redaction.test.ts +2 -0
  141. package/src/__tests__/persona-resolver.test.ts +75 -45
  142. package/src/__tests__/plugin-bootstrap.test.ts +21 -83
  143. package/src/__tests__/plugin-disabled-state.test.ts +190 -0
  144. package/src/__tests__/plugin-pipeline.test.ts +96 -0
  145. package/src/__tests__/plugin-route-contribution.test.ts +6 -19
  146. package/src/__tests__/plugin-tool-contribution.test.ts +5 -20
  147. package/src/__tests__/plugin-types.test.ts +2 -4
  148. package/src/__tests__/process-message-background-slack.test.ts +2 -0
  149. package/src/__tests__/process-message-display-content.test.ts +2 -0
  150. package/src/__tests__/provider-error-scenarios.test.ts +5 -4
  151. package/src/__tests__/provider-usage-tracking.test.ts +39 -0
  152. package/src/__tests__/reaction-intercept-cold-cache-warm.test.ts +135 -0
  153. package/src/__tests__/reaction-intercept-member-verdict-warm.test.ts +158 -0
  154. package/src/__tests__/reaction-persistence.test.ts +51 -4
  155. package/src/__tests__/regenerate-fire-and-forget-trace.test.ts +2 -0
  156. package/src/__tests__/registry.test.ts +4 -1
  157. package/src/__tests__/relay-server.test.ts +758 -32
  158. package/src/__tests__/runtime-attachment-metadata.test.ts +9 -12
  159. package/src/__tests__/secret-ingress-http.test.ts +14 -0
  160. package/src/__tests__/send-endpoint-busy.test.ts +30 -8
  161. package/src/__tests__/settings-routes.test.ts +32 -0
  162. package/src/__tests__/skills.test.ts +44 -0
  163. package/src/__tests__/slack-inbound-verification.test.ts +47 -2
  164. package/src/__tests__/sse-actor-principal-guardian-source.test.ts +79 -0
  165. package/src/__tests__/steer-on-enqueue-question.test.ts +181 -0
  166. package/src/__tests__/stt-hints.test.ts +49 -15
  167. package/src/__tests__/subagent-detail.test.ts +27 -0
  168. package/src/__tests__/subagent-disposal.test.ts +65 -0
  169. package/src/__tests__/subagent-fork-prompt-role.test.ts +195 -0
  170. package/src/__tests__/subagent-fork-spawn.test.ts +6 -7
  171. package/src/__tests__/subagent-notify-parent.test.ts +2 -0
  172. package/src/__tests__/subagent-role-registry.test.ts +24 -6
  173. package/src/__tests__/subagent-spawn-and-await.test.ts +546 -0
  174. package/src/__tests__/subagent-spawn-tool-fork.test.ts +2 -0
  175. package/src/__tests__/subagent-tools.test.ts +398 -1
  176. package/src/__tests__/suggestion-routes.test.ts +2 -0
  177. package/src/__tests__/thread-backfill.test.ts +3 -3
  178. package/src/__tests__/title-generate-hook.test.ts +2 -0
  179. package/src/__tests__/tool-executor-lifecycle-events.test.ts +2 -0
  180. package/src/__tests__/tool-executor.test.ts +16 -11
  181. package/src/__tests__/tool-preview-lifecycle.test.ts +2 -0
  182. package/src/__tests__/tool-result-metadata-plumbing.test.ts +2 -0
  183. package/src/__tests__/tool-start-timestamp.test.ts +2 -0
  184. package/src/__tests__/trusted-contact-approval-notifier.test.ts +37 -51
  185. package/src/__tests__/trusted-contact-inline-approval-integration.test.ts +12 -12
  186. package/src/__tests__/trusted-contact-lifecycle-notifications.test.ts +9 -7
  187. package/src/__tests__/trusted-contact-multichannel.test.ts +16 -7
  188. package/src/__tests__/trusted-contact-verification.test.ts +79 -54
  189. package/src/__tests__/twilio-routes.test.ts +96 -0
  190. package/src/__tests__/ui-file-upload-surface.test.ts +86 -0
  191. package/src/__tests__/verification-control-plane-policy.test.ts +2 -0
  192. package/src/__tests__/voice-guardian-cold-cache-warm.test.ts +137 -0
  193. package/src/__tests__/voice-invite-redemption.test.ts +216 -20
  194. package/src/__tests__/web-search-backend-failure.test.ts +2 -0
  195. package/src/__tests__/workspace-migration-102-preserve-heartbeat-enabled-for-existing-workspaces.test.ts +3 -3
  196. package/src/__tests__/workspace-migration-111-prune-seeded-callsite-defaults.test.ts +208 -0
  197. package/src/__tests__/workspace-migration-112-remove-advisor-callsite-override.test.ts +170 -0
  198. package/src/__tests__/workspace-migration-drop-user-md.test.ts +196 -238
  199. package/src/__tests__/workspace-migration-remove-hooks.test.ts +14 -35
  200. package/src/__tests__/workspace-tool-loader.test.ts +195 -2
  201. package/src/a2a/__tests__/e2e-a2a-channel.test.ts +35 -47
  202. package/src/agent/loop-exclusive-tool.test.ts +154 -0
  203. package/src/agent/loop-native-web-search.test.ts +200 -0
  204. package/src/agent/loop.ts +164 -1
  205. package/src/api/constants/sse-replay.ts +41 -0
  206. package/src/api/events/conversation-notice.ts +26 -0
  207. package/src/api/index.ts +19 -1
  208. package/src/api/responses/llm-request-log-entry.ts +29 -0
  209. package/src/api/responses/subagent-detail.ts +17 -0
  210. package/src/api/surfaces.ts +39 -3
  211. package/src/approvals/guardian-channel-delivery.ts +30 -0
  212. package/src/approvals/guardian-expiry-notifier.ts +148 -0
  213. package/src/approvals/guardian-request-resolvers.ts +17 -15
  214. package/src/calls/__tests__/relay-setup-router.test.ts +267 -17
  215. package/src/calls/call-domain.ts +3 -3
  216. package/src/calls/guardian-dispatch.ts +14 -9
  217. package/src/calls/inbound-trust-reader.ts +24 -2
  218. package/src/calls/media-stream-server.ts +21 -0
  219. package/src/calls/relay-access-wait.ts +6 -6
  220. package/src/calls/relay-server.ts +188 -51
  221. package/src/calls/relay-setup-router.ts +47 -17
  222. package/src/calls/relay-verification.ts +4 -4
  223. package/src/calls/stt-hints.ts +9 -12
  224. package/src/calls/twilio-routes.ts +14 -4
  225. package/src/channels/types.ts +10 -20
  226. package/src/cli/commands/__tests__/cache.test.ts +8 -1
  227. package/src/cli/commands/__tests__/conversations-slack.test.ts +1 -0
  228. package/src/cli/commands/cache.ts +194 -181
  229. package/src/cli/commands/contacts.ts +10 -7
  230. package/src/cli/commands/db/__tests__/repair.test.ts +6 -5
  231. package/src/cli/commands/db/status.ts +37 -1
  232. package/src/cli/commands/mcp.ts +252 -218
  233. package/src/cli/commands/memory/__tests__/worker.test.ts +432 -0
  234. package/src/cli/commands/memory/index.ts +2 -0
  235. package/src/cli/commands/memory/worker.ts +242 -0
  236. package/src/cli/commands/plugins.ts +125 -13
  237. package/src/cli/lib/__tests__/install-from-github.test.ts +102 -0
  238. package/src/cli/lib/__tests__/list-installed-plugins.test.ts +160 -1
  239. package/src/cli/lib/__tests__/publish-plugin.test.ts +404 -0
  240. package/src/cli/lib/list-installed-plugins.ts +179 -1
  241. package/src/cli/lib/publish-plugin.ts +633 -0
  242. package/src/config/__tests__/loader-callsite-strip-fallback.test.ts +143 -0
  243. package/src/config/__tests__/sync-gated-profiles.test.ts +16 -10
  244. package/src/config/bundled-skills/contacts/tools/contact-merge.ts +27 -17
  245. package/src/config/bundled-skills/contacts/tools/contact-search.ts +13 -3
  246. package/src/config/bundled-skills/subagent/SKILL.md +17 -2
  247. package/src/config/bundled-skills/subagent/TOOLS.json +5 -4
  248. package/src/config/call-site-defaults.ts +0 -6
  249. package/src/config/feature-flag-registry.json +5 -13
  250. package/src/config/llm-resolver.ts +0 -3
  251. package/src/config/loader.ts +38 -5
  252. package/src/config/prune-seeded-callsite-defaults.ts +110 -0
  253. package/src/config/schemas/__tests__/memory-v3.test.ts +1 -0
  254. package/src/config/schemas/call-site-catalog.ts +0 -7
  255. package/src/config/schemas/heartbeat.ts +2 -5
  256. package/src/config/schemas/llm.ts +3 -12
  257. package/src/config/schemas/memory-lifecycle.ts +12 -0
  258. package/src/config/schemas/memory-v3.ts +7 -0
  259. package/src/config/schemas/memory.ts +4 -0
  260. package/src/config/schemas/timeouts.ts +8 -0
  261. package/src/config/seed-inference-profiles.ts +30 -34
  262. package/src/config/skills.ts +27 -5
  263. package/src/config/sync-gated-profiles.ts +12 -16
  264. package/src/contacts/__tests__/contacts-write-revoke-relay.test.ts +128 -0
  265. package/src/contacts/__tests__/guardian-delivery-reader.test.ts +312 -0
  266. package/src/contacts/__tests__/member-write-relay.test.ts +226 -0
  267. package/src/contacts/contact-store.ts +27 -237
  268. package/src/contacts/contacts-write.ts +18 -55
  269. package/src/contacts/gateway-channel-read.ts +51 -0
  270. package/src/contacts/guardian-delivery-reader.ts +223 -0
  271. package/src/contacts/member-write-relay.ts +183 -0
  272. package/src/contacts/types.ts +3 -15
  273. package/src/daemon/__tests__/conversation-tool-setup-exclude.test.ts +35 -0
  274. package/src/daemon/__tests__/conversation-tool-setup.test.ts +0 -44
  275. package/src/daemon/assistant-attachments.ts +27 -4
  276. package/src/daemon/conversation-agent-loop.ts +28 -0
  277. package/src/daemon/conversation-notices.ts +60 -0
  278. package/src/daemon/conversation-process.ts +35 -16
  279. package/src/daemon/conversation-surfaces.ts +111 -38
  280. package/src/daemon/conversation-tool-setup.ts +71 -30
  281. package/src/daemon/conversation.ts +23 -1
  282. package/src/daemon/disk-pressure-guard.ts +12 -2
  283. package/src/daemon/event-loop-watchdog.ts +28 -1
  284. package/src/daemon/external-plugins-bootstrap.ts +17 -41
  285. package/src/daemon/handlers/__tests__/config-a2a-accept.test.ts +0 -1
  286. package/src/daemon/handlers/__tests__/config-a2a-complete.test.ts +0 -2
  287. package/src/daemon/handlers/__tests__/config-a2a-redeem.test.ts +25 -2
  288. package/src/daemon/handlers/__tests__/config-channels.test.ts +220 -0
  289. package/src/daemon/handlers/config-a2a.ts +6 -14
  290. package/src/daemon/handlers/config-channels.ts +67 -26
  291. package/src/daemon/handlers/conversations.ts +77 -0
  292. package/src/daemon/lifecycle.ts +16 -0
  293. package/src/daemon/mcp-reload-service.ts +10 -0
  294. package/src/daemon/memory-v2-startup.test.ts +72 -0
  295. package/src/daemon/memory-v2-startup.ts +87 -19
  296. package/src/daemon/message-types/conversations.ts +2 -0
  297. package/src/daemon/message-types/surfaces.ts +12 -12
  298. package/src/daemon/server.ts +0 -4
  299. package/src/daemon/shutdown-handlers.ts +20 -0
  300. package/src/daemon/tool-setup-types.ts +9 -0
  301. package/src/heartbeat/heartbeat-service.ts +5 -0
  302. package/src/home/relationship-state-writer.ts +5 -0
  303. package/src/hooks/hook-loader.ts +341 -0
  304. package/src/ipc/__tests__/clients-list-ipc.test.ts +1 -1
  305. package/src/ipc/assistant-server.ts +2 -2
  306. package/src/mcp/__tests__/mcp-auth-orchestrator.test.ts +1 -0
  307. package/src/mcp/client.ts +15 -1
  308. package/src/mcp/mcp-auth-orchestrator.ts +6 -1
  309. package/src/mcp/mcp-header-store.ts +134 -0
  310. package/src/mcp/mcp-oauth-provider.ts +19 -8
  311. package/src/memory/__tests__/301-create-watchdog-events.test.ts +110 -0
  312. package/src/memory/__tests__/memory-retrospective-job.test.ts +8 -0
  313. package/src/memory/__tests__/prompt-override.test.ts +192 -0
  314. package/src/memory/__tests__/watchdog-events-store.test.ts +161 -0
  315. package/src/memory/compaction-ledger-store.ts +107 -0
  316. package/src/memory/conversation-crud.ts +129 -61
  317. package/src/memory/db-connection.ts +22 -3
  318. package/src/memory/db-init.ts +37 -503
  319. package/src/memory/db-singleton.ts +6 -4
  320. package/src/memory/jobs-worker.ts +104 -0
  321. package/src/memory/llm-request-log-store.ts +26 -1
  322. package/src/memory/llm-usage-store.ts +48 -20
  323. package/src/memory/memory-retrospective-job.ts +14 -8
  324. package/src/memory/migrations/209-strip-thinking-from-consolidated.ts +152 -56
  325. package/src/memory/migrations/300-add-processing-started-at.ts +30 -0
  326. package/src/memory/migrations/301-create-watchdog-events.ts +45 -0
  327. package/src/memory/migrations/302-create-compaction-events.ts +107 -0
  328. package/src/memory/migrations/__tests__/209-strip-thinking-from-consolidated.test.ts +297 -0
  329. package/src/memory/migrations/__tests__/run-migrations.test.ts +2 -2
  330. package/src/memory/migrations/run-migrations.ts +106 -10
  331. package/src/memory/migrations/validate-migration-state.ts +105 -67
  332. package/src/memory/prompt-override.ts +129 -0
  333. package/src/memory/schema/contacts.ts +6 -2
  334. package/src/memory/schema/conversations.ts +37 -0
  335. package/src/memory/schema/infrastructure.ts +20 -0
  336. package/src/memory/steps.ts +1294 -0
  337. package/src/memory/v2/__tests__/cli-command-store.test.ts +25 -0
  338. package/src/memory/v2/__tests__/skill-store.test.ts +80 -0
  339. package/src/memory/v2/cli-command-store.ts +75 -38
  340. package/src/memory/v2/prompts/consolidation.ts +13 -82
  341. package/src/memory/v2/prompts/router.ts +21 -93
  342. package/src/memory/v2/skill-store.ts +68 -31
  343. package/src/memory/watchdog-events-store.ts +87 -0
  344. package/src/memory/worker-control.ts +204 -0
  345. package/src/memory/worker-process.ts +89 -0
  346. package/src/messaging/channel-binding-metadata.ts +31 -0
  347. package/src/messaging/provider-types.ts +8 -0
  348. package/src/messaging/providers/slack/binding-metadata.ts +60 -0
  349. package/src/notifications/__tests__/broadcaster.test.ts +8 -8
  350. package/src/notifications/__tests__/connected-channels.test.ts +86 -0
  351. package/src/notifications/__tests__/decision-engine.test.ts +78 -9
  352. package/src/notifications/__tests__/destination-resolver.test.ts +151 -0
  353. package/src/notifications/broadcaster.ts +8 -1
  354. package/src/notifications/decision-engine.ts +15 -7
  355. package/src/notifications/destination-resolver.ts +53 -25
  356. package/src/notifications/emit-signal.ts +34 -15
  357. package/src/onboarding/checkin-event.test.ts +222 -0
  358. package/src/onboarding/checkin-event.ts +321 -0
  359. package/src/onboarding/schedule-checkin.ts +190 -0
  360. package/src/permissions/question-prompter.test.ts +1 -1
  361. package/src/permissions/question-prompter.ts +7 -4
  362. package/src/plugin-api/index.ts +12 -12
  363. package/src/plugin-api/types.ts +12 -14
  364. package/src/plugin-api/vision-support.test.ts +28 -4
  365. package/src/plugin-api/vision-support.ts +66 -31
  366. package/src/plugins/defaults/empty-response/hooks/post-model-call.ts +2 -2
  367. package/src/plugins/defaults/empty-response/hooks/stop.ts +2 -2
  368. package/src/plugins/defaults/exploration-drift/hooks/post-tool-use.ts +4 -3
  369. package/src/plugins/defaults/history-repair/hooks/post-model-call.ts +2 -2
  370. package/src/plugins/defaults/history-repair/hooks/stop.ts +2 -2
  371. package/src/plugins/defaults/history-repair/hooks/user-prompt-submit.ts +2 -2
  372. package/src/plugins/defaults/image-fallback/__tests__/image-fallback.test.ts +47 -7
  373. package/src/plugins/defaults/image-fallback/hooks/post-tool-use.ts +12 -13
  374. package/src/plugins/defaults/image-fallback/hooks/user-prompt-submit.ts +14 -22
  375. package/src/plugins/defaults/image-fallback/src/caption-blocks.ts +42 -11
  376. package/src/plugins/defaults/image-recovery/hooks/post-model-call.ts +2 -2
  377. package/src/plugins/defaults/image-recovery/hooks/stop.ts +2 -2
  378. package/src/plugins/defaults/index.ts +0 -35
  379. package/src/plugins/defaults/max-tokens-continue/hooks/post-model-call.ts +2 -2
  380. package/src/plugins/defaults/max-tokens-continue/hooks/stop.ts +2 -2
  381. package/src/plugins/defaults/memory-retrieval/hooks/post-compact.ts +2 -2
  382. package/src/plugins/defaults/memory-retrieval/hooks/user-prompt-submit.ts +2 -2
  383. package/src/plugins/defaults/memory-v3-shadow/__tests__/injection.test.ts +33 -3
  384. package/src/plugins/defaults/memory-v3-shadow/__tests__/pool-select.test.ts +48 -4
  385. package/src/plugins/defaults/memory-v3-shadow/__tests__/shadow-plugin.test.ts +4 -8
  386. package/src/plugins/defaults/memory-v3-shadow/hooks/post-compact.ts +2 -2
  387. package/src/plugins/defaults/memory-v3-shadow/hooks/user-prompt-submit.ts +2 -2
  388. package/src/plugins/defaults/memory-v3-shadow/injector.ts +43 -15
  389. package/src/plugins/defaults/memory-v3-shadow/orchestrate.ts +11 -2
  390. package/src/plugins/defaults/memory-v3-shadow/pool-select.test.ts +146 -0
  391. package/src/plugins/defaults/memory-v3-shadow/pool-select.ts +77 -13
  392. package/src/plugins/defaults/memory-v3-shadow/shadow-plugin.ts +12 -11
  393. package/src/plugins/defaults/surface-completion-nudge/hooks/post-model-call.ts +2 -2
  394. package/src/plugins/defaults/surface-completion-nudge/hooks/stop.ts +2 -2
  395. package/src/plugins/defaults/task-progress-nudge/hooks/post-tool-use.ts +2 -2
  396. package/src/plugins/defaults/title-generate/hooks/stop.ts +2 -2
  397. package/src/plugins/defaults/title-generate/hooks/user-prompt-submit.ts +2 -2
  398. package/src/plugins/defaults/tool-error/hooks/post-tool-use.ts +2 -2
  399. package/src/plugins/defaults/tool-result-truncate/hooks/post-tool-use.ts +2 -2
  400. package/src/plugins/disabled-state.ts +31 -0
  401. package/src/plugins/external-plugin-loader.ts +2 -2
  402. package/src/plugins/mtime-cache.ts +186 -330
  403. package/src/plugins/pipeline.ts +111 -13
  404. package/src/plugins/registry.ts +59 -16
  405. package/src/plugins/surface-import.ts +121 -0
  406. package/src/plugins/types.ts +7 -9
  407. package/src/prompts/persona-resolver.ts +43 -11
  408. package/src/providers/anthropic/client.ts +5 -0
  409. package/src/providers/call-site-routing.ts +45 -0
  410. package/src/providers/model-catalog.ts +16 -0
  411. package/src/providers/openai/__tests__/api-error-normalization.test.ts +321 -0
  412. package/src/providers/openai/api-error-normalization.ts +270 -0
  413. package/src/providers/openai/chat-completions-provider.ts +37 -83
  414. package/src/providers/openai/responses-provider.ts +50 -46
  415. package/src/providers/openrouter/client.ts +5 -0
  416. package/src/providers/provider-send-message.ts +10 -0
  417. package/src/providers/ratelimit.ts +10 -0
  418. package/src/providers/registry.ts +1 -1
  419. package/src/providers/retry.ts +10 -0
  420. package/src/providers/types.ts +22 -0
  421. package/src/providers/usage-tracking.ts +10 -0
  422. package/src/runtime/__tests__/channel-verification-service.test.ts +133 -0
  423. package/src/runtime/__tests__/guardian-vellum-migration.test.ts +184 -0
  424. package/src/runtime/__tests__/is-guardian-bound-for-channel.test.ts +66 -0
  425. package/src/runtime/__tests__/local-principal-trust.test.ts +162 -0
  426. package/src/runtime/__tests__/member-verdict-cache.test.ts +119 -0
  427. package/src/runtime/__tests__/trust-verdict-consumer.test.ts +402 -123
  428. package/src/runtime/access-request-helper.ts +18 -39
  429. package/src/runtime/actor-trust-resolver.ts +46 -19
  430. package/src/runtime/anchored-guardian.test.ts +109 -0
  431. package/src/runtime/anchored-guardian.ts +86 -0
  432. package/src/runtime/assistant-event-hub.ts +1 -1
  433. package/src/runtime/assistant-stream-state.ts +9 -2
  434. package/src/runtime/auth/__tests__/require-bound-guardian.test.ts +99 -0
  435. package/src/runtime/auth/require-bound-guardian.ts +21 -11
  436. package/src/runtime/channel-verification-service.ts +56 -31
  437. package/src/runtime/confirmation-request-guardian-bridge.ts +3 -3
  438. package/src/runtime/guardian-vellum-migration.ts +69 -8
  439. package/src/runtime/invite-redemption-service.ts +213 -187
  440. package/src/runtime/local-actor-identity.test.ts +108 -0
  441. package/src/runtime/local-actor-identity.ts +85 -13
  442. package/src/runtime/local-principal-trust.ts +52 -0
  443. package/src/runtime/member-verdict-cache.ts +0 -0
  444. package/src/runtime/pending-interactions.ts +11 -1
  445. package/src/runtime/routes/__tests__/channel-verification-revoke.test.ts +56 -5
  446. package/src/runtime/routes/__tests__/channel-verification-routes.test.ts +1 -1
  447. package/src/runtime/routes/__tests__/contact-routes.test.ts +305 -0
  448. package/src/runtime/routes/__tests__/global-search-routes.test.ts +92 -0
  449. package/src/runtime/routes/__tests__/http-adapter-actor-header.test.ts +129 -0
  450. package/src/runtime/routes/__tests__/surface-action-routes.test.ts +188 -0
  451. package/src/runtime/routes/browser-routes.ts +1 -1
  452. package/src/runtime/routes/canonical-guardian-expiry-sweep.ts +13 -5
  453. package/src/runtime/routes/channel-verification-routes.ts +3 -3
  454. package/src/runtime/routes/contact-routes.ts +48 -57
  455. package/src/runtime/routes/conversation-cli-routes.ts +4 -5
  456. package/src/runtime/routes/conversation-list-routes.ts +4 -7
  457. package/src/runtime/routes/conversation-query-routes.ts +72 -0
  458. package/src/runtime/routes/conversation-routes.ts +84 -85
  459. package/src/runtime/routes/events-routes.ts +2 -2
  460. package/src/runtime/routes/global-search-routes.ts +3 -1
  461. package/src/runtime/routes/guardian-action-routes.ts +4 -5
  462. package/src/runtime/routes/host-app-control-routes.ts +5 -4
  463. package/src/runtime/routes/host-bash-routes.ts +5 -4
  464. package/src/runtime/routes/host-browser-routes.ts +9 -11
  465. package/src/runtime/routes/host-cu-routes.ts +5 -4
  466. package/src/runtime/routes/host-file-routes.ts +5 -4
  467. package/src/runtime/routes/host-transfer-routes.ts +6 -6
  468. package/src/runtime/routes/http-adapter.ts +16 -1
  469. package/src/runtime/routes/identity-routes.ts +3 -2
  470. package/src/runtime/routes/inbound-message-handler.ts +5 -5
  471. package/src/runtime/routes/inbound-stages/acl-enforcement.test.ts +97 -5
  472. package/src/runtime/routes/inbound-stages/acl-enforcement.ts +61 -59
  473. package/src/runtime/routes/inbound-stages/background-dispatch.ts +13 -5
  474. package/src/runtime/routes/inbound-stages/escalation-intercept.ts +7 -7
  475. package/src/runtime/routes/inbound-stages/guardian-activation-intercept.test.ts +21 -8
  476. package/src/runtime/routes/inbound-stages/guardian-activation-intercept.ts +14 -3
  477. package/src/runtime/routes/inbound-stages/reaction-intercept.ts +19 -0
  478. package/src/runtime/routes/index.ts +2 -0
  479. package/src/runtime/routes/llm-context-normalization.ts +83 -0
  480. package/src/runtime/routes/mcp-auth-routes.ts +171 -19
  481. package/src/runtime/routes/migration-rollback-routes.ts +4 -3
  482. package/src/runtime/routes/migration-routes.ts +4 -1
  483. package/src/runtime/routes/onboarding-checkin-routes.ts +86 -0
  484. package/src/runtime/routes/settings-routes.ts +8 -3
  485. package/src/runtime/routes/subagents-routes.ts +5 -0
  486. package/src/runtime/routes/surface-action-routes.ts +42 -56
  487. package/src/runtime/services/__tests__/conversation-serializer.test.ts +1 -0
  488. package/src/runtime/services/conversation-serializer.ts +13 -58
  489. package/src/runtime/tool-grant-request-helper.ts +3 -3
  490. package/src/runtime/trust-verdict-consumer.ts +111 -40
  491. package/src/runtime/verification-outbound-actions.ts +18 -18
  492. package/src/signals/user-message.ts +16 -0
  493. package/src/subagent/__tests__/consult-prompt.test.ts +35 -0
  494. package/src/{plugins/defaults/advisor/__tests__/transcript.test.ts → subagent/__tests__/consult-transcript.test.ts} +47 -10
  495. package/src/{plugins/defaults/advisor/steering.ts → subagent/consult-prompt.ts} +22 -32
  496. package/src/{plugins/defaults/advisor/transcript.ts → subagent/consult-transcript.ts} +18 -8
  497. package/src/subagent/index.ts +1 -1
  498. package/src/subagent/manager.ts +254 -33
  499. package/src/subagent/types.ts +11 -4
  500. package/src/telemetry/types.ts +34 -1
  501. package/src/telemetry/usage-telemetry-reporter.test.ts +3 -2
  502. package/src/telemetry/usage-telemetry-reporter.ts +87 -3
  503. package/src/tools/ask-question/ask-question-tool.test.ts +29 -0
  504. package/src/tools/ask-question/ask-question-tool.ts +13 -0
  505. package/src/tools/executor.ts +4 -4
  506. package/src/tools/filesystem/search.ts +543 -0
  507. package/src/tools/registry.ts +38 -0
  508. package/src/tools/shared/filesystem/path-policy.ts +12 -5
  509. package/src/tools/subagent/consult-deadline.ts +49 -0
  510. package/src/tools/subagent/spawn.ts +234 -5
  511. package/src/tools/tool-approval-handler.ts +1 -1
  512. package/src/tools/tool-defaults.ts +9 -2
  513. package/src/tools/tool-manifest.ts +3 -0
  514. package/src/tools/types.ts +131 -25
  515. package/src/tools/workspace-tools/loader.ts +348 -244
  516. package/src/util/errors.ts +26 -1
  517. package/src/util/logger.ts +9 -0
  518. package/src/util/platform.ts +19 -0
  519. package/src/util/telemetry-db-path.ts +24 -0
  520. package/src/workflows/library.test.ts +140 -0
  521. package/src/workflows/library.ts +82 -28
  522. package/src/workspace/migrations/017-seed-persona-dirs.ts +3 -34
  523. package/src/workspace/migrations/019-scope-journal-to-guardian.ts +3 -24
  524. package/src/workspace/migrations/031-drop-user-md.ts +232 -148
  525. package/src/workspace/migrations/048-remove-workspace-hooks.ts +14 -66
  526. package/src/workspace/migrations/111-prune-seeded-callsite-defaults.ts +134 -0
  527. package/src/workspace/migrations/112-remove-advisor-callsite-override.ts +64 -0
  528. package/src/workspace/migrations/registry.ts +4 -0
  529. package/src/__tests__/workspace-tools-watcher-flag.test.ts +0 -70
  530. package/src/daemon/workspace-tools-watcher.ts +0 -328
  531. package/src/memory/migrations/registry.ts +0 -573
  532. package/src/plugins/defaults/advisor/__tests__/advisor-gate.test.ts +0 -56
  533. package/src/plugins/defaults/advisor/__tests__/advisor-state-store.test.ts +0 -43
  534. package/src/plugins/defaults/advisor/__tests__/agent-loop-integration.test.ts +0 -137
  535. package/src/plugins/defaults/advisor/__tests__/consult.test.ts +0 -153
  536. package/src/plugins/defaults/advisor/__tests__/hooks.test.ts +0 -138
  537. package/src/plugins/defaults/advisor/advisor-gate.ts +0 -29
  538. package/src/plugins/defaults/advisor/advisor-state-store.ts +0 -94
  539. package/src/plugins/defaults/advisor/config.ts +0 -21
  540. package/src/plugins/defaults/advisor/consult.ts +0 -93
  541. package/src/plugins/defaults/advisor/hooks/post-model-call.ts +0 -34
  542. package/src/plugins/defaults/advisor/hooks/pre-model-call.ts +0 -30
  543. package/src/plugins/defaults/advisor/hooks/user-prompt-submit.ts +0 -19
  544. package/src/plugins/defaults/advisor/package.json +0 -14
  545. package/src/plugins/defaults/advisor/tools/advisor.ts +0 -65
  546. package/src/providers/openai/__tests__/api-error-detail.test.ts +0 -120
@@ -31,16 +31,33 @@ import {
31
31
 
32
32
  // ── Mock state ────────────────────────────────────────────────────
33
33
 
34
+ interface GuardianDeliveryStub {
35
+ channelType: string;
36
+ address: string;
37
+ status: string;
38
+ }
39
+
34
40
  let mockWorkspaceDir: string = "";
35
- let mockVellumGuardian: {
36
- contact: { userFile: string | null };
37
- channel: Record<string, unknown>;
38
- } | null = null;
39
- let mockAnyGuardian: {
40
- contact: { userFile: string | null };
41
- channels: Record<string, unknown>[];
42
- } | null = null;
41
+ // Gateway guardian delivery cache, keyed by the same source the production
42
+ // peek reads; the guardian's userFile (local INFO) is joined separately via
43
+ // findContactByAddress on the delivery's address.
44
+ let mockGuardianDeliveries: GuardianDeliveryStub[] = [];
43
45
  let mockContactsByAddress: Record<string, { userFile: string | null }> = {};
46
+ // Simulates a cold sync cache: the sync `peek` returns nothing until the async
47
+ // `getGuardianDelivery` warm runs and populates `mockGuardianDeliveries`. The
48
+ // pending list is what the warm reveals.
49
+ let pendingWarmDeliveries: GuardianDeliveryStub[] | null = null;
50
+
51
+ /**
52
+ * Seed a vellum guardian: a gateway delivery for the vellum channel plus the
53
+ * local contact (by address) carrying its userFile.
54
+ */
55
+ function seedVellumGuardian(userFile: string | null): void {
56
+ mockGuardianDeliveries = [
57
+ { channelType: "vellum", address: "vellum:self", status: "active" },
58
+ ];
59
+ mockContactsByAddress["vellum:vellum:self"] = { userFile };
60
+ }
44
61
 
45
62
  // ── Mock modules (must precede imports from the module under test) ──
46
63
 
@@ -51,13 +68,32 @@ mock.module("../util/platform.js", () => ({
51
68
  mock.module("../contacts/contact-store.js", () => ({
52
69
  findContactByAddress: (channelType: string, address: string) =>
53
70
  mockContactsByAddress[`${channelType}:${address}`] ?? null,
54
- findGuardianForChannel: (channelType: string) =>
55
- channelType === "vellum" ? mockVellumGuardian : null,
56
- listGuardianChannels: () => mockAnyGuardian,
71
+ }));
72
+
73
+ mock.module("../contacts/guardian-delivery-reader.js", () => ({
74
+ peekCachedGuardianDelivery: (input?: { channelTypes?: string[] }) => {
75
+ if (!input?.channelTypes) return mockGuardianDeliveries;
76
+ return mockGuardianDeliveries.filter((g) =>
77
+ input.channelTypes!.includes(g.channelType),
78
+ );
79
+ },
80
+ // Warming the cache: reveals the pending guardian to the sync peek above,
81
+ // mirroring how the production single-flight read populates the cache key.
82
+ getGuardianDelivery: async (_input?: { channelTypes?: string[] }) => {
83
+ if (pendingWarmDeliveries) {
84
+ mockGuardianDeliveries = pendingWarmDeliveries;
85
+ pendingWarmDeliveries = null;
86
+ }
87
+ return mockGuardianDeliveries;
88
+ },
89
+ guardianForChannel: (list: GuardianDeliveryStub[], channelType: string) =>
90
+ list.find((g) => g.channelType === channelType && g.status === "active"),
91
+ anyGuardian: (list: GuardianDeliveryStub[]) => list[0],
57
92
  }));
58
93
 
59
94
  // Import AFTER mocks so the module under test binds to the stubbed
60
95
  // implementations.
96
+ import { getGuardianDelivery } from "../contacts/guardian-delivery-reader.js";
61
97
  import type { TrustContext } from "../daemon/trust-context.js";
62
98
  import {
63
99
  ensureGuardianPersonaFile,
@@ -83,9 +119,9 @@ afterAll(() => {
83
119
  beforeEach(() => {
84
120
  // Fresh workspace per test, so filesystem state doesn't leak.
85
121
  mockWorkspaceDir = mkdtempSync(join(testRoot, "ws-"));
86
- mockVellumGuardian = null;
87
- mockAnyGuardian = null;
122
+ mockGuardianDeliveries = [];
88
123
  mockContactsByAddress = {};
124
+ pendingWarmDeliveries = null;
89
125
  });
90
126
 
91
127
  afterEach(() => {
@@ -96,21 +132,35 @@ afterEach(() => {
96
132
 
97
133
  describe("resolveGuardianPersonaPath", () => {
98
134
  test("returns null when no guardian exists", () => {
99
- mockVellumGuardian = null;
100
- mockAnyGuardian = null;
101
135
 
102
136
  expect(resolveGuardianPersonaPath()).toBeNull();
103
137
  });
104
138
 
105
139
  test("returns absolute path when guardian has userFile set", () => {
106
- mockVellumGuardian = {
107
- contact: { userFile: "alice.md" },
108
- channel: {},
109
- };
140
+ seedVellumGuardian("alice.md");
110
141
 
111
142
  const result = resolveGuardianPersonaPath();
112
143
  expect(result).toBe(join(mockWorkspaceDir, "users", "alice.md"));
113
144
  });
145
+
146
+ test("falls back to default (null path) on a cold cache, but resolves the guardian after a warm", async () => {
147
+ // Cold start: the guardian binding exists upstream but the sync cache is
148
+ // empty, so a bare sync resolution misses it and falls back to default.
149
+ pendingWarmDeliveries = [
150
+ { channelType: "vellum", address: "vellum:self", status: "active" },
151
+ ];
152
+ mockContactsByAddress["vellum:vellum:self"] = { userFile: "alice.md" };
153
+
154
+ expect(resolveGuardianPersonaPath()).toBeNull();
155
+
156
+ // Async callers warm the vellum guardian-delivery cache before the sync
157
+ // resolution; afterwards the guardian slug resolves instead of default.md.
158
+ await getGuardianDelivery({ channelTypes: ["vellum"] });
159
+
160
+ expect(resolveGuardianPersonaPath()).toBe(
161
+ join(mockWorkspaceDir, "users", "alice.md"),
162
+ );
163
+ });
114
164
  });
115
165
 
116
166
  // ── ensureGuardianPersonaFile ──────────────────────────────────────
@@ -156,17 +206,12 @@ describe("ensureGuardianPersonaFile", () => {
156
206
 
157
207
  describe("resolveGuardianPersonaStrict", () => {
158
208
  test("returns null when no guardian contact exists", () => {
159
- mockVellumGuardian = null;
160
- mockAnyGuardian = null;
161
209
 
162
210
  expect(resolveGuardianPersonaStrict()).toBeNull();
163
211
  });
164
212
 
165
213
  test("returns null when the guardian's own file is missing, even if default.md exists", () => {
166
- mockVellumGuardian = {
167
- contact: { userFile: "alice.md" },
168
- channel: {},
169
- };
214
+ seedVellumGuardian("alice.md");
170
215
 
171
216
  // default.md is populated but alice.md is not on disk.
172
217
  const usersDir = join(mockWorkspaceDir, "users");
@@ -185,10 +230,7 @@ describe("resolveGuardianPersonaStrict", () => {
185
230
  });
186
231
 
187
232
  test("returns guardian file content when present", () => {
188
- mockVellumGuardian = {
189
- contact: { userFile: "alice.md" },
190
- channel: {},
191
- };
233
+ seedVellumGuardian("alice.md");
192
234
 
193
235
  const usersDir = join(mockWorkspaceDir, "users");
194
236
  mkdirSync(usersDir, { recursive: true });
@@ -260,10 +302,7 @@ describe("isGuardianPersonaCustomized", () => {
260
302
 
261
303
  describe("resolveUserSlug (guardian trust, no requester identity)", () => {
262
304
  test("guardian trust context without requesterExternalUserId resolves the guardian user file", () => {
263
- mockVellumGuardian = {
264
- contact: { userFile: "alice.md" },
265
- channel: {},
266
- };
305
+ seedVellumGuardian("alice.md");
267
306
 
268
307
  const trustContext = {
269
308
  sourceChannel: "vellum",
@@ -274,10 +313,7 @@ describe("resolveUserSlug (guardian trust, no requester identity)", () => {
274
313
  });
275
314
 
276
315
  test("non-guardian trust context without requesterExternalUserId does not borrow the guardian persona", () => {
277
- mockVellumGuardian = {
278
- contact: { userFile: "alice.md" },
279
- channel: {},
280
- };
316
+ seedVellumGuardian("alice.md");
281
317
 
282
318
  const trustContext = {
283
319
  sourceChannel: "vellum",
@@ -291,10 +327,7 @@ describe("resolveUserSlug (guardian trust, no requester identity)", () => {
291
327
  // The verdict-bound guardian is looked up by its address, not by the
292
328
  // most-recently-verified channel guardian, so a different channel guardian
293
329
  // does not shadow the verdict's binding.
294
- mockVellumGuardian = {
295
- contact: { userFile: "wrong-guardian.md" },
296
- channel: {},
297
- };
330
+ seedVellumGuardian("wrong-guardian.md");
298
331
  mockContactsByAddress["telegram:guardian-tg"] = {
299
332
  userFile: "alice.md",
300
333
  };
@@ -309,10 +342,7 @@ describe("resolveUserSlug (guardian trust, no requester identity)", () => {
309
342
  });
310
343
 
311
344
  test("falls back to the channel guardian when the verdict carries no guardian identity", () => {
312
- mockVellumGuardian = {
313
- contact: { userFile: "alice.md" },
314
- channel: {},
315
- };
345
+ seedVellumGuardian("alice.md");
316
346
 
317
347
  const trustContext = {
318
348
  sourceChannel: "vellum",
@@ -2,34 +2,21 @@
2
2
  * Tests for plugin bootstrap (PR 14).
3
3
  *
4
4
  * Covers:
5
- * - A noop `init()` fires with a valid `PluginInitContext` that exposes every
5
+ * - A noop `init()` fires with a valid `InitContext` that exposes every
6
6
  * documented field.
7
- * - `requiresCredential` entries are resolved through the credential store
8
- * helper and arrive in `ctx.credentials`.
9
7
  * - Version-mismatch registration fails with an error that names the plugin
10
8
  * (the registry enforces this at `registerPlugin` time, so bootstrap never
11
9
  * sees the malformed plugin).
12
10
  * - Shutdown hook walks plugins in reverse registration order.
13
11
  *
14
- * Uses `mock.module` to stub `security/secure-keys.js` so credential
15
- * resolution doesn't hit the real backend. `resetPluginRegistryForTests()`
16
- * isolates registry state between cases.
12
+ * `resetPluginRegistryForTests()` isolates registry state between cases.
17
13
  */
18
14
 
19
15
  import { existsSync } from "node:fs";
20
16
  import { rm } from "node:fs/promises";
21
17
  import { tmpdir } from "node:os";
22
18
  import { join } from "node:path";
23
- import { beforeEach, describe, expect, mock, test } from "bun:test";
24
-
25
- // Mock credential store before importing the bootstrap module so the
26
- // module-under-test captures the stubbed binding.
27
- const getSecureKeyAsyncMock = mock(
28
- async (_account: string): Promise<string | undefined> => undefined,
29
- );
30
- mock.module("../security/secure-keys.js", () => ({
31
- getSecureKeyAsync: getSecureKeyAsyncMock,
32
- }));
19
+ import { beforeEach, describe, expect, test } from "bun:test";
33
20
 
34
21
  import { clearFeatureFlagOverridesCache } from "../config/assistant-feature-flags.js";
35
22
  import { bootstrapPlugins } from "../daemon/external-plugins-bootstrap.js";
@@ -42,7 +29,7 @@ import {
42
29
  registerPlugin,
43
30
  resetPluginRegistryForTests,
44
31
  } from "../plugins/registry.js";
45
- import { type Plugin, type PluginInitContext } from "../plugins/types.js";
32
+ import { type InitContext, type Plugin } from "../plugins/types.js";
46
33
  import { APP_VERSION } from "../version.js";
47
34
  import { setOverridesForTesting } from "./feature-flag-test-helpers.js";
48
35
 
@@ -64,11 +51,10 @@ function buildPlugin(
64
51
  name: string,
65
52
  extras: Partial<Omit<Plugin, "manifest" | "hooks">> & {
66
53
  hooks?: Plugin["hooks"];
67
- init?: (ctx: PluginInitContext) => Promise<void>;
54
+ init?: (ctx: InitContext) => Promise<void>;
68
55
  onShutdown?: () => Promise<void>;
69
56
  } = {},
70
57
  options: {
71
- requiresCredential?: string[];
72
58
  requiresFlag?: string[];
73
59
  } = {},
74
60
  ): Plugin {
@@ -94,9 +80,6 @@ function buildPlugin(
94
80
  manifest: {
95
81
  name,
96
82
  version: "0.0.1",
97
- ...(options.requiresCredential
98
- ? { requiresCredential: options.requiresCredential }
99
- : {}),
100
83
  ...(options.requiresFlag ? { requiresFlag: options.requiresFlag } : {}),
101
84
  },
102
85
  ...rest,
@@ -107,8 +90,6 @@ function buildPlugin(
107
90
  describe("plugin bootstrap", () => {
108
91
  beforeEach(async () => {
109
92
  resetPluginRegistryForTests();
110
- getSecureKeyAsyncMock.mockReset();
111
- getSecureKeyAsyncMock.mockImplementation(async () => undefined);
112
93
  // Reset feature-flag cache so tests start from a known state. Individual
113
94
  // tests that exercise `requiresFlag` use `setOverridesForTesting(...)`
114
95
  // to install their own overrides.
@@ -117,8 +98,8 @@ describe("plugin bootstrap", () => {
117
98
  await rm(TEST_WORKSPACE_DIR, { recursive: true, force: true });
118
99
  });
119
100
 
120
- test("noop plugin: init fires with a fully-populated PluginInitContext", async () => {
121
- let received: PluginInitContext | undefined;
101
+ test("noop plugin: init fires with a fully-populated InitContext", async () => {
102
+ let received: InitContext | undefined;
122
103
  const plugin: Plugin = buildPlugin("alpha", {
123
104
  async init(ctx) {
124
105
  received = ctx;
@@ -133,7 +114,6 @@ describe("plugin bootstrap", () => {
133
114
 
134
115
  // Every documented field must be present on the context passed to init.
135
116
  expect(ctx.config).toBeUndefined(); // no `plugins.alpha` block in fake config
136
- expect(ctx.credentials).toEqual({});
137
117
  expect(ctx.logger).toBeDefined();
138
118
  expect(typeof (ctx.logger as { info: unknown }).info).toBe("function");
139
119
  // Storage dir lives under getWorkspaceDir()/plugins-data/<name> and must have
@@ -145,52 +125,6 @@ describe("plugin bootstrap", () => {
145
125
  expect(ctx.assistantVersion).toBe(APP_VERSION);
146
126
  });
147
127
 
148
- test("credential resolution: init receives the resolved value under credentials[key]", async () => {
149
- getSecureKeyAsyncMock.mockImplementation(async (account: string) => {
150
- if (account === "some-key") return "super-secret-value";
151
- return undefined;
152
- });
153
-
154
- let received: PluginInitContext | undefined;
155
- const plugin = buildPlugin(
156
- "credentialed",
157
- {
158
- async init(ctx) {
159
- received = ctx;
160
- },
161
- },
162
- { requiresCredential: ["some-key"] },
163
- );
164
- registerPlugin(plugin);
165
-
166
- await bootstrapPlugins();
167
-
168
- expect(getSecureKeyAsyncMock).toHaveBeenCalledTimes(1);
169
- expect(getSecureKeyAsyncMock).toHaveBeenCalledWith("some-key");
170
- expect(received?.credentials).toEqual({ "some-key": "super-secret-value" });
171
- });
172
-
173
- test("credential resolution: a plugin whose required credential is missing is skipped, not fatal", async () => {
174
- // GIVEN a plugin that requires a credential the store cannot resolve
175
- getSecureKeyAsyncMock.mockImplementation(async () => undefined);
176
- registerPlugin(
177
- buildPlugin(
178
- "missing-cred",
179
- { async init() {} },
180
- { requiresCredential: ["absent-key"] },
181
- ),
182
- );
183
-
184
- // WHEN bootstrap runs
185
- // THEN it completes without throwing — the unresolvable credential is
186
- // contained to that plugin (same per-plugin isolation as an init throw)
187
- await bootstrapPlugins();
188
-
189
- // AND the plugin is dropped from the registry
190
- const names = getRegisteredPlugins().map((p) => p.manifest.name);
191
- expect(names).not.toContain("missing-cred");
192
- });
193
-
194
128
  test("version mismatch: external plugin loader rejects when peerDependency unsatisfied", async () => {
195
129
  // Host-compat negotiation lives in the external-plugin loader against
196
130
  // `peerDependencies["@vellumai/plugin-api"]`. The registry no longer
@@ -541,11 +475,13 @@ describe("plugin bootstrap", () => {
541
475
  //
542
476
  // A plugin is disabled when a `.disabled` file exists at
543
477
  // <workspace>/plugins/<manifest-name>/.disabled. The bootstrap must
544
- // skip the plugin entirely — no init, no tools, no routes, no shutdown
545
- // hook — and remove it from the registry, mirroring the requiresFlag
546
- // gate.
478
+ // skip the plugin's init, tools, routes, and shutdown hook. Unlike the
479
+ // requiresFlag gate, the plugin is NOT removed from the registry — its
480
+ // hooks stay registered and are filtered at read time by
481
+ // `isPluginDisabled` in `getHooksFor`, so `assistant plugins enable`
482
+ // takes effect on the next turn without a restart.
547
483
 
548
- test(".disabled sentinel: init does not fire and plugin is unregistered", async () => {
484
+ test(".disabled sentinel: init does not fire and hooks are filtered at read time", async () => {
549
485
  let initFired = false;
550
486
  const plugin = buildPlugin("sentinel-off", {
551
487
  async init() {
@@ -555,11 +491,7 @@ describe("plugin bootstrap", () => {
555
491
  registerPlugin(plugin);
556
492
 
557
493
  // Create the .disabled sentinel in the workspace plugins dir.
558
- const sentinelDir = join(
559
- TEST_WORKSPACE_DIR,
560
- "plugins",
561
- "sentinel-off",
562
- );
494
+ const sentinelDir = join(TEST_WORKSPACE_DIR, "plugins", "sentinel-off");
563
495
  const { mkdir, writeFile } = await import("node:fs/promises");
564
496
  await mkdir(sentinelDir, { recursive: true });
565
497
  await writeFile(join(sentinelDir, ".disabled"), "");
@@ -567,8 +499,14 @@ describe("plugin bootstrap", () => {
567
499
  await bootstrapPlugins();
568
500
 
569
501
  expect(initFired).toBe(false);
502
+ // The plugin stays in the registry (not unregistered) so its hooks can
503
+ // be re-enabled at runtime by removing the sentinel.
570
504
  const names = getRegisteredPlugins().map((p) => p.manifest.name);
571
- expect(names).not.toContain("sentinel-off");
505
+ expect(names).toContain("sentinel-off");
506
+ // But its hooks are filtered out at read time by `isPluginDisabled`.
507
+ const { getHooksFor } = await import("../plugins/registry.js");
508
+ const hooks = await getHooksFor("init");
509
+ expect(hooks).toHaveLength(0);
572
510
 
573
511
  await rm(sentinelDir, { recursive: true, force: true });
574
512
  });
@@ -0,0 +1,190 @@
1
+ /**
2
+ * Tests for per-surface plugin disabled-state filtering.
3
+ *
4
+ * Verifies that `assistant plugins disable default-*` takes effect on the
5
+ * next turn without a daemon restart. The `.disabled` sentinel is checked at
6
+ * read time by each surface (`getHooksFor` for hooks,
7
+ * `getPluginToolDefinitions` for tools) rather than at boot, so toggling the
8
+ * sentinel file at runtime is immediately reflected.
9
+ */
10
+
11
+ import { existsSync } from "node:fs";
12
+ import { mkdir, rm, writeFile } from "node:fs/promises";
13
+ import { tmpdir } from "node:os";
14
+ import { join } from "node:path";
15
+ import { afterEach, beforeEach, describe, expect, test } from "bun:test";
16
+
17
+ import { RiskLevel } from "../permissions/types.js";
18
+ import {
19
+ getHooksFor,
20
+ registerPlugin,
21
+ resetPluginRegistryForTests,
22
+ unregisterPlugin,
23
+ } from "../plugins/registry.js";
24
+ import { type HookFunction, type Plugin } from "../plugins/types.js";
25
+ import {
26
+ getPluginToolDefinitions,
27
+ registerPluginTools,
28
+ } from "../tools/registry.js";
29
+ import type { Tool, ToolContext, ToolExecutionResult } from "../tools/types.js";
30
+
31
+ const TEST_WORKSPACE_DIR = join(
32
+ tmpdir(),
33
+ `vellum-plugin-disabled-state-test-${process.pid}-${Date.now()}`,
34
+ );
35
+ process.env.VELLUM_WORKSPACE_DIR = TEST_WORKSPACE_DIR;
36
+
37
+ async function createSentinel(name: string): Promise<void> {
38
+ const dir = join(TEST_WORKSPACE_DIR, "plugins", name);
39
+ await mkdir(dir, { recursive: true });
40
+ await writeFile(join(dir, ".disabled"), "");
41
+ }
42
+
43
+ async function removeSentinel(name: string): Promise<void> {
44
+ const dir = join(TEST_WORKSPACE_DIR, "plugins", name);
45
+ await rm(dir, { recursive: true, force: true });
46
+ }
47
+
48
+ function buildPlugin(
49
+ name: string,
50
+ hooks: Record<string, HookFunction> = {},
51
+ ): Plugin {
52
+ return {
53
+ manifest: { name, version: "1.0.0" },
54
+ hooks,
55
+ };
56
+ }
57
+
58
+ function makeFakeTool(name: string): Tool {
59
+ return {
60
+ name,
61
+ description: `Fake ${name}`,
62
+ defaultRiskLevel: RiskLevel.Low,
63
+ executionTarget: "sandbox",
64
+ input_schema: { type: "object", properties: {}, required: [] },
65
+ category: "plugin",
66
+ async execute(
67
+ _input: Record<string, unknown>,
68
+ _context: ToolContext,
69
+ ): Promise<ToolExecutionResult> {
70
+ return { content: "ok", isError: false };
71
+ },
72
+ };
73
+ }
74
+
75
+ beforeEach(() => {
76
+ resetPluginRegistryForTests();
77
+ });
78
+
79
+ afterEach(async () => {
80
+ // Clean up any sentinel files created during the test.
81
+ const pluginsDir = join(TEST_WORKSPACE_DIR, "plugins");
82
+ if (existsSync(pluginsDir)) {
83
+ await rm(pluginsDir, { recursive: true, force: true });
84
+ }
85
+ });
86
+
87
+ describe("per-surface disabled-state filtering", () => {
88
+ test("getHooksFor filters out hooks from a disabled plugin", async () => {
89
+ const plugin = buildPlugin("default-test-hook", {
90
+ "user-prompt-submit": () => Promise.resolve(),
91
+ });
92
+ registerPlugin(plugin);
93
+
94
+ // Before disabling: hook is included.
95
+ const hooksBefore = await getHooksFor("user-prompt-submit");
96
+ expect(hooksBefore).toHaveLength(1);
97
+
98
+ // Disable via sentinel.
99
+ await createSentinel("default-test-hook");
100
+
101
+ // After disabling: hook is filtered out at read time.
102
+ const hooksAfter = await getHooksFor("user-prompt-submit");
103
+ expect(hooksAfter).toHaveLength(0);
104
+
105
+ // Clean up.
106
+ await removeSentinel("default-test-hook");
107
+ });
108
+
109
+ test("getHooksFor re-includes hooks when a disabled plugin is re-enabled", async () => {
110
+ const plugin = buildPlugin("default-test-reenable", {
111
+ "user-prompt-submit": () => Promise.resolve(),
112
+ });
113
+ registerPlugin(plugin);
114
+
115
+ // Disable.
116
+ await createSentinel("default-test-reenable");
117
+ let hooks = await getHooksFor("user-prompt-submit");
118
+ expect(hooks).toHaveLength(0);
119
+
120
+ // Re-enable by removing the sentinel.
121
+ await removeSentinel("default-test-reenable");
122
+ hooks = await getHooksFor("user-prompt-submit");
123
+ expect(hooks).toHaveLength(1);
124
+ });
125
+
126
+ test("getPluginToolDefinitions filters out tools from a disabled plugin", async () => {
127
+ const plugin: Plugin = {
128
+ manifest: { name: "default-test-tools", version: "1.0.0" },
129
+ tools: [makeFakeTool("test_tool")],
130
+ };
131
+ registerPlugin(plugin);
132
+ registerPluginTools("default-test-tools", plugin.tools!);
133
+
134
+ // Before disabling: tool is visible.
135
+ let defs = getPluginToolDefinitions();
136
+ expect(defs.some((d) => d.name === "test_tool")).toBe(true);
137
+
138
+ // Disable via sentinel.
139
+ await createSentinel("default-test-tools");
140
+
141
+ // After disabling: tool is filtered out.
142
+ defs = getPluginToolDefinitions();
143
+ expect(defs.some((d) => d.name === "test_tool")).toBe(false);
144
+
145
+ // Re-enable.
146
+ await removeSentinel("default-test-tools");
147
+ defs = getPluginToolDefinitions();
148
+ expect(defs.some((d) => d.name === "test_tool")).toBe(true);
149
+ });
150
+
151
+ test("disabling one plugin does not affect others", async () => {
152
+ const pluginA = buildPlugin("default-test-alpha", {
153
+ "user-prompt-submit": () => Promise.resolve(),
154
+ });
155
+ const pluginB = buildPlugin("default-test-beta", {
156
+ "user-prompt-submit": () => Promise.resolve(),
157
+ });
158
+ registerPlugin(pluginA);
159
+ registerPlugin(pluginB);
160
+
161
+ // Both visible.
162
+ let hooks = await getHooksFor("user-prompt-submit");
163
+ expect(hooks).toHaveLength(2);
164
+
165
+ // Disable only alpha.
166
+ await createSentinel("default-test-alpha");
167
+ hooks = await getHooksFor("user-prompt-submit");
168
+ expect(hooks).toHaveLength(1);
169
+
170
+ // Re-enable alpha.
171
+ await removeSentinel("default-test-alpha");
172
+ hooks = await getHooksFor("user-prompt-submit");
173
+ expect(hooks).toHaveLength(2);
174
+ });
175
+
176
+ test("unregisterPlugin removes hooks from the hook registry", async () => {
177
+ const plugin = buildPlugin("default-test-unreg", {
178
+ "user-prompt-submit": () => Promise.resolve(),
179
+ });
180
+ registerPlugin(plugin);
181
+
182
+ let hooks = await getHooksFor("user-prompt-submit");
183
+ expect(hooks).toHaveLength(1);
184
+
185
+ unregisterPlugin("default-test-unreg");
186
+
187
+ hooks = await getHooksFor("user-prompt-submit");
188
+ expect(hooks).toHaveLength(0);
189
+ });
190
+ });
@@ -0,0 +1,96 @@
1
+ import { beforeEach, describe, expect, test } from "bun:test";
2
+
3
+ import { runHook } from "../plugins/pipeline.js";
4
+ import {
5
+ registerPlugin,
6
+ resetPluginRegistryForTests,
7
+ } from "../plugins/registry.js";
8
+
9
+ beforeEach(() => {
10
+ resetPluginRegistryForTests();
11
+ });
12
+
13
+ describe("plugin pipeline", () => {
14
+ test("logs and skips failed hooks while preserving threaded mutations", async () => {
15
+ registerPlugin({
16
+ manifest: {
17
+ name: "test-first-hook",
18
+ version: "1.0.0",
19
+ },
20
+ hooks: {
21
+ "user-prompt-submit": async () => ({
22
+ value: 1,
23
+ }),
24
+ },
25
+ });
26
+ registerPlugin({
27
+ manifest: {
28
+ name: "test-throwing-hook",
29
+ version: "1.0.0",
30
+ },
31
+ hooks: {
32
+ "user-prompt-submit": async () => {
33
+ throw new Error("hook failed");
34
+ },
35
+ },
36
+ });
37
+ registerPlugin({
38
+ manifest: {
39
+ name: "test-final-hook",
40
+ version: "1.0.0",
41
+ },
42
+ hooks: {
43
+ "user-prompt-submit": async (ctx: { value: number }) => ({
44
+ value: ctx.value + 1,
45
+ }),
46
+ },
47
+ });
48
+
49
+ const result = await runHook("user-prompt-submit", { value: 0 });
50
+
51
+ expect(result).toEqual({ value: 2 });
52
+ });
53
+
54
+ test("discards in-place mutations from a failed hook", async () => {
55
+ registerPlugin({
56
+ manifest: {
57
+ name: "test-first-hook",
58
+ version: "1.0.0",
59
+ },
60
+ hooks: {
61
+ "user-prompt-submit": async (ctx: { items: string[] }) => {
62
+ ctx.items.push("first");
63
+ },
64
+ },
65
+ });
66
+ registerPlugin({
67
+ manifest: {
68
+ name: "test-throwing-hook",
69
+ version: "1.0.0",
70
+ },
71
+ hooks: {
72
+ "user-prompt-submit": async (ctx: { items: string[] }) => {
73
+ ctx.items.push("failed");
74
+ throw new Error("hook failed");
75
+ },
76
+ },
77
+ });
78
+ registerPlugin({
79
+ manifest: {
80
+ name: "test-final-hook",
81
+ version: "1.0.0",
82
+ },
83
+ hooks: {
84
+ "user-prompt-submit": async (ctx: { items: string[] }) => {
85
+ ctx.items.push("final");
86
+ },
87
+ },
88
+ });
89
+
90
+ const result = await runHook<{ items: string[] }>("user-prompt-submit", {
91
+ items: [],
92
+ });
93
+
94
+ expect(result.items).toEqual(["first", "final"]);
95
+ });
96
+ });