@the-bearded-bear/claude-craft 8.26.0 → 8.27.0

package/Tools/Ralph/lib/dod-validator.sh

@@ -9,7 +9,7 @@ set -euo pipefail
 DOD_COMPLETION_MARKER="${DOD_COMPLETION_MARKER:-<promise>COMPLETE</promise>}"
 
 # DoD validator types
-declare -A DOD_VALIDATORS=(
+declare -gA DOD_VALIDATORS=(
     ["command"]="validate_command"
     ["output_contains"]="validate_output_contains"
     ["file_changed"]="validate_file_changed"
@@ -27,12 +27,12 @@ validate_dod() {
 
     # If no config, use simple completion marker check
     if [[ -z "$config_file" || ! -f "$config_file" ]]; then
-        return $(validate_simple_completion "$output")
+        validate_simple_completion "$output"; return
     fi
 
     # Check if yq is available for YAML parsing
     if ! command -v yq &> /dev/null; then
-        return $(validate_simple_completion "$output")
+        validate_simple_completion "$output"; return
     fi
 
     # Get DoD checklist from config
@@ -44,7 +44,7 @@ validate_dod() {
         if [[ -n "$marker" ]]; then
             DOD_COMPLETION_MARKER="$marker"
         fi
-        return $(validate_simple_completion "$output")
+        validate_simple_completion "$output"; return
     fi
 
     # Process checklist items
@@ -52,14 +52,14 @@ validate_dod() {
     local results=()
 
     # Get count of checklist items
-    local count=$(echo "$checklist" | yq e 'length' -)
+    local count=$(echo "$checklist" | yq e 'length' -) || true
 
     for ((i=0; i<count; i++)); do
         local item=$(yq e ".definition_of_done.checklist[$i]" "$config_file")
-        local id=$(echo "$item" | yq e '.id' -)
-        local name=$(echo "$item" | yq e '.name' -)
-        local type=$(echo "$item" | yq e '.type' -)
-        local required=$(echo "$item" | yq e '.required // true' -)
+        local id=$(echo "$item" | yq e '.id' -) || true
+        local name=$(echo "$item" | yq e '.name' -) || true
+        local type=$(echo "$item" | yq e '.type' -) || true
+        local required=$(echo "$item" | yq e '.required // true' -) || true
 
         # Validate based on type
         local passed=false
@@ -67,7 +67,7 @@ validate_dod() {
 
         case "$type" in
             command)
-                local cmd=$(echo "$item" | yq e '.command' -)
+                local cmd=$(echo "$item" | yq e '.command' -) || true
                 if validate_command "$cmd"; then
                     passed=true
                     message="Command passed"
@@ -76,7 +76,7 @@ validate_dod() {
                 fi
                 ;;
             output_contains)
-                local pattern=$(echo "$item" | yq e '.pattern' -)
+                local pattern=$(echo "$item" | yq e '.pattern' -) || true
                 if validate_output_contains "$output" "$pattern"; then
                     passed=true
                     message="Pattern found"
@@ -85,7 +85,7 @@ validate_dod() {
                 fi
                 ;;
             file_changed)
-                local pattern=$(echo "$item" | yq e '.pattern' -)
+                local pattern=$(echo "$item" | yq e '.pattern' -) || true
                 if validate_file_changed "$pattern"; then
                     passed=true
                     message="Files changed"
@@ -94,7 +94,7 @@ validate_dod() {
                 fi
                 ;;
             hook)
-                local script=$(echo "$item" | yq e '.script' -)
+                local script=$(echo "$item" | yq e '.script' -) || true
                 if validate_hook "$script" "$output"; then
                     passed=true
                     message="Hook passed"
@@ -103,7 +103,7 @@ validate_dod() {
                 fi
                 ;;
             human)
-                local prompt=$(echo "$item" | yq e '.prompt // ""' -)
+                local prompt=$(echo "$item" | yq e '.prompt // ""' -) || true
                 if validate_human "$name" "$prompt"; then
                     passed=true
                     message="Human approved"
@@ -209,13 +209,13 @@ validate_file_changed() {
 
     # Use git to check for changes matching pattern
     if command -v git &> /dev/null && git rev-parse --git-dir &> /dev/null; then
-        local changes=$(git status --porcelain 2>/dev/null | grep -E "$pattern" | wc -l)
+        local changes=$(git status --porcelain 2>/dev/null | grep -E "$pattern" | wc -l) || true
         if [[ $changes -gt 0 ]]; then
             return 0
         fi
     else
         # Fallback: check for recently modified files
-        local changes=$(find . -name "$pattern" -mmin -5 2>/dev/null | wc -l)
+        local changes=$(find . -name "$pattern" -mmin -5 2>/dev/null | wc -l) || true
         if [[ $changes -gt 0 ]]; then
             return 0
         fi
@@ -381,7 +381,7 @@ export_dod_status() {
 
     # Count checks
     local total
-    total=$(echo "$checklist" | yq e 'length' -)
+    total=$(echo "$checklist" | yq e 'length' -) || total=0
 
     local required=0
     for ((i=0; i<total; i++)); do
@@ -424,7 +424,7 @@ get_dod_summary() {
 
     # Build summary
     local count
-    count=$(echo "$checklist" | yq e 'length' -)
+    count=$(echo "$checklist" | yq e 'length' -) || count=0
 
     local checks="["
     for ((i=0; i<count; i++)); do

package/Tools/Ralph/lib/escalation-service.sh

@@ -21,7 +21,7 @@ ESCALATION_RESOLVED_DIR=""
 ESCALATION_AUDIT_FILE=""
 
 # Escalation priorities
-declare -A ESCALATION_PRIORITIES=(
+declare -gA ESCALATION_PRIORITIES=(
     ["critical"]=1
     ["high"]=2
     ["medium"]=3
@@ -188,7 +188,7 @@ list_escalations() {
             priority=$(yq e '.priority' "$file")
 
             printf "[%s] %s: %s - %s (%s)\n" "$priority" "$id" "$level" "$error_type" "$created"
-            ((count++))
+            count=$((count + 1))
         fi
     done
 
@@ -295,7 +295,9 @@ check_escalation_timeouts() {
 get_pending_count() {
     local count=0
     for file in "$ESCALATION_QUEUE_DIR"/*.yaml; do
-        [[ -f "$file" ]] && ((count++))
+        if [[ -f "$file" ]]; then
+            count=$((count + 1))
+        fi
     done
     echo "$count"
 }
@@ -421,7 +423,7 @@ build_slack_payload() {
 
     local title="Ralph Escalation: $event"
     local truncated_details
-    truncated_details=$(echo "$details" | head -c 500 | tr '\n' ' ')
+    truncated_details=$(echo "$details" | head -c 500 | tr '\n' ' ') || true
 
     jq -n \
         --arg color "$color" \
@@ -441,7 +443,7 @@ build_teams_payload() {
     [[ "$event" == "resolved" ]] && color="good"
 
     local truncated_details
-    truncated_details=$(echo "$details" | head -c 500 | tr '\n' ' ')
+    truncated_details=$(echo "$details" | head -c 500 | tr '\n' ' ') || true
 
     jq -n \
         --arg type "MessageCard" \
@@ -462,7 +464,7 @@ build_discord_payload() {
     [[ "$event" == "resolved" ]] && color=65280  # Green
 
     local truncated_details
-    truncated_details=$(echo "$details" | head -c 500 | tr '\n' ' ')
+    truncated_details=$(echo "$details" | head -c 500 | tr '\n' ' ') || true
 
     jq -n \
         --arg title "Ralph Escalation: $event" \
@@ -479,7 +481,7 @@ build_generic_payload() {
     local id="$1" event="$2" level="$3" error="$4" details="$5" session="$6"
 
     local truncated_details
-    truncated_details=$(echo "$details" | head -c 500 | tr '\n' ' ')
+    truncated_details=$(echo "$details" | head -c 500 | tr '\n' ' ') || true
 
     jq -n \
         --arg event "$event" \

package/Tools/Ralph/lib/hooks-generator.sh

@@ -95,7 +95,8 @@ generate_hooks_config() {
     # Merge with existing settings
     local merged
     if command -v jq &>/dev/null; then
-        merged=$(echo "$existing_settings" | jq --argjson hooks "$hooks_config" '. + {hooks: $hooks}')
+        merged=$(echo "$existing_settings" | jq --argjson hooks "$hooks_config" '. + {hooks: $hooks}') \
+            || merged="{\"hooks\": $hooks_config}"
     else
         # Fallback: just write hooks config
         merged="{\"hooks\": $hooks_config}"

package/Tools/Ralph/lib/loop-finalizer.sh

@@ -56,7 +56,7 @@ ralph_finalize_loop() {
 
     # Save sprint progress before summary
     if type save_sprint_progress &>/dev/null; then
-        save_sprint_progress "$session_id"
+        save_sprint_progress "$session_id" || print_verbose "No sprint progress file to save"
     fi
 
     # Save metrics export

package/Tools/Ralph/lib/loop.sh

@@ -13,6 +13,30 @@ CLAUDE_ARGS="${CLAUDE_ARGS:-}"
 # Claude Invocation
 # =============================================================================
 
+# Print a random RFC 4122 v4 UUID (`claude --session-id` requires a valid UUID).
+generate_uuid() {
+    if [[ -r /proc/sys/kernel/random/uuid ]]; then
+        cat /proc/sys/kernel/random/uuid
+    elif command -v uuidgen &> /dev/null; then
+        uuidgen | tr '[:upper:]' '[:lower:]'
+    else
+        local hex
+        hex=$(od -An -N16 -tx1 /dev/urandom | tr -d ' \n') || true
+        printf '%s-%s-4%s-%x%s-%s\n' "${hex:0:8}" "${hex:8:4}" "${hex:13:3}" \
+            $(( (0x${hex:16:1} & 0x3) | 0x8 )) "${hex:17:3}" "${hex:20:12}"
+    fi
+}
+
+# Print the Claude session UUID pinned to a Ralph session, or nothing if
+# Claude has not been invoked yet for it. Always succeeds (set -e safe).
+get_claude_session_uuid() {
+    local id_file="$RALPH_SESSION_BASE/sessions/$1/claude_session_id"
+    if [[ -n "$1" && -s "$id_file" ]]; then
+        cat "$id_file"
+    fi
+    return 0
+}
+
 invoke_claude() {
     local session_id="$1"
     local prompt="$2"
@@ -25,9 +49,21 @@ invoke_claude() {
     local -a cmd
     IFS=' ' read -r -a cmd <<< "${CLAUDE_COMMAND:-claude}"
 
-    # Add continue flag if we have a session
+    # Pin an explicit Claude session per Ralph session. `--continue` resumes
+    # "the most recent conversation in this directory", which parallel workers
+    # (and unrelated user sessions) would share.
     if [[ -n "$session_id" ]]; then
-        cmd+=(--continue)
+        local claude_session_uuid
+        claude_session_uuid=$(get_claude_session_uuid "$session_id")
+        if [[ -n "$claude_session_uuid" ]]; then
+            cmd+=(--resume "$claude_session_uuid")
+        else
+            local id_file="$RALPH_SESSION_BASE/sessions/$session_id/claude_session_id"
+            claude_session_uuid=$(generate_uuid)
+            mkdir -p "$(dirname "$id_file")"
+            echo "$claude_session_uuid" > "$id_file"
+            cmd+=(--session-id "$claude_session_uuid")
+        fi
     fi
 
     # Add prompt
@@ -39,12 +75,11 @@ invoke_claude() {
     # Execute with timeout
     local timeout_sec=$((timeout / 1000))
     local output
-    local exit_code
+    local exit_code=0
 
     # Use timeout command if available
     if command -v timeout &> /dev/null; then
-        output=$(timeout "${timeout_sec}s" "${cmd[@]}" "$prompt" 2>&1)
-        exit_code=$?
+        output=$(timeout "${timeout_sec}s" "${cmd[@]}" "$prompt" 2>&1) || exit_code=$?
 
         # Check for timeout (exit code 124)
         if [[ $exit_code -eq 124 ]]; then
@@ -53,8 +88,7 @@ invoke_claude() {
         fi
     else
         # Fallback without timeout
-        output=$("${cmd[@]}" "$prompt" 2>&1)
-        exit_code=$?
+        output=$("${cmd[@]}" "$prompt" 2>&1) || exit_code=$?
     fi
 
     # Log result
@@ -104,7 +138,7 @@ detect_file_changes() {
 
     # Use git to detect changes if available
     if command -v git &> /dev/null && git rev-parse --git-dir &> /dev/null; then
-        local changes=$(git status --porcelain 2>/dev/null | wc -l)
+        local changes=$(git status --porcelain 2>/dev/null | wc -l) || true
         log_session "$session_id" "DEBUG" "Detected $changes file changes"
         echo "$changes"
     else
@@ -112,7 +146,7 @@ detect_file_changes() {
         local changes=0
         for dir in src lib app tests; do
             if [[ -d "$dir" ]]; then
-                local recent=$(find "$dir" -type f -mmin -1 2>/dev/null | wc -l)
+                local recent=$(find "$dir" -type f -mmin -1 2>/dev/null | wc -l) || true
                 changes=$((changes + recent))
             fi
         done
@@ -219,7 +253,7 @@ get_loop_state() {
         status: (.status // "unknown"),
         circuit_breaker: (.circuit_breaker // {}),
         dod_results: (.dod_results // [])
-    }' 2>/dev/null)
+    }' 2>/dev/null) || result=""
 
     if [[ -n "$result" ]]; then
         echo "$result"

package/Tools/Ralph/lib/metrics-exporter.sh

@@ -12,7 +12,7 @@ METRICS_REALTIME_ENABLED="${METRICS_REALTIME_ENABLED:-true}"
 METRICS_REALTIME_INTERVAL="${METRICS_REALTIME_INTERVAL:-1000}"
 
 # Metrics data
-declare -A METRICS_DATA
+declare -gA METRICS_DATA
 METRICS_START_TIME=0
 METRICS_ITERATION_TIMES=()
 METRICS_CONTEXT_SAMPLES=()