@semiont/react-ui 0.5.26 → 0.5.28

package/src/components/resource/panels/__tests__/ResourceInfoPanel.test.tsx

@@ -2,8 +2,10 @@ import { describe, it, expect, vi, beforeEach } from 'vitest';
 import React from 'react';
 import { render, screen, fireEvent, waitFor } from '@testing-library/react';
 import '@testing-library/jest-dom';
-import type { EventBus } from '@semiont/core';
-import type { SemiontClient, SemiontSession } from '@semiont/sdk';
+import { BehaviorSubject } from 'rxjs';
+import type { EventBus, ResourceDescriptor } from '@semiont/core';
+import { resourceId as makeResourceId } from '@semiont/core';
+import type { CacheObservable, CacheState, SemiontClient, SemiontSession } from '@semiont/sdk';
 import { ResourceInfoPanel } from '../ResourceInfoPanel';
 import { createTestSemiontWrapper } from '../../../../test-utils';
 
@@ -95,7 +97,9 @@ const renderWithEventBus = (component: React.ReactElement<{ session: SemiontSess
   );
   // The component is provider-free: inject the factory session so it is the
   // SAME session whose client the tracker spies on / whose bus it subscribes.
-  return render(React.cloneElement(component, { session }), { wrapper: Wrapper });
+  // The injected session/client are returned too: a test that spies on what the
+  // panel calls has to spy on THIS client, not a second factory's.
+  return { ...render(React.cloneElement(component, { session }), { wrapper: Wrapper }), session, client };
 };
 
 describe('ResourceInfoPanel Component', () => {
@@ -279,17 +283,19 @@ describe('ResourceInfoPanel Component', () => {
   });
 
   describe('Generate Action', () => {
+    // The shell's collapsible header is ALSO a button named "Generate", so the
+    // form control is targeted by its exact accessible name (the ✨ is part of it).
     it('renders the Generate button when onGenerate is provided', () => {
       renderWithEventBus(
         <ResourceInfoPanel {...defaultProps} onGenerate={() => {}} />
       );
-      expect(screen.getByRole('button', { name: /Generate/i })).toBeInTheDocument();
+      expect(screen.getByRole('button', { name: '✨ Generate' })).toBeInTheDocument();
       expect(screen.getByText("Generate a new resource from this one's context")).toBeInTheDocument();
     });
 
     it('hides the Generate button when onGenerate is omitted', () => {
       renderWithEventBus(<ResourceInfoPanel {...defaultProps} />);
-      expect(screen.queryByRole('button', { name: /Generate/i })).not.toBeInTheDocument();
+      expect(screen.queryByRole('button', { name: '✨ Generate' })).not.toBeInTheDocument();
     });
 
     it('calls onGenerate when clicked', () => {
@@ -297,9 +303,117 @@ describe('ResourceInfoPanel Component', () => {
       renderWithEventBus(
         <ResourceInfoPanel {...defaultProps} onGenerate={onGenerate} />
       );
-      fireEvent.click(screen.getByRole('button', { name: /Generate/i }));
+      fireEvent.click(screen.getByRole('button', { name: '✨ Generate' }));
       expect(onGenerate).toHaveBeenCalledTimes(1);
     });
+
+    // ── GENERATE-FROM-RESOURCE P2 (D7/D8): the panel is the progress surface ──
+
+    it('the Generate control lives inside the assist shell (D7)', () => {
+      const { container } = renderWithEventBus(
+        <ResourceInfoPanel {...defaultProps} onGenerate={() => {}}
+          isGenerating={false} generationProgress={null} />
+      );
+      const shell = container.querySelector('.semiont-assist-widget[data-type="generation"]');
+      expect(shell).not.toBeNull();
+      expect(shell!.querySelector('button')).not.toBeNull(); // the form IS the Generate control
+    });
+
+    it('progress replaces the Generate form while a generation runs', () => {
+      const { container } = renderWithEventBus(
+        <ResourceInfoPanel {...defaultProps} onGenerate={() => {}}
+          isGenerating
+          generationProgress={{ percentage: 40, message: { code: 'generating-resource' } }} />
+      );
+      expect(container.querySelector('.semiont-assist-progress')).not.toBeNull();
+      expect(screen.queryByRole('button', { name: '✨ Generate' })).toBeNull();
+    });
+
+    it('the ended frame links the generated resource by name, and dismisses (D8)', () => {
+      const onDismissProgress = vi.fn();
+      const { client } = renderWithEventBus(
+        <ResourceInfoPanel {...defaultProps} onGenerate={() => {}}
+          isGenerating={false}
+          generationProgress={{ percentage: 100, message: { code: 'complete-generated', truncated: false } }}
+          generationOutcome={{
+            resourceId: makeResourceId('urn:semiont:resource:new1'),
+            resourceName: 'Summary of PB',
+            truncated: false,
+          }}
+          onDismissProgress={onDismissProgress} />
+      );
+      const openSpy = vi.spyOn(client.browse, 'openResource');
+
+      fireEvent.click(screen.getByRole('button', { name: 'Summary of PB' }));
+      expect(openSpy).toHaveBeenCalledTimes(1);
+      expect(String(openSpy.mock.calls[0]![0])).toBe('urn:semiont:resource:new1');
+
+      fireEvent.click(screen.getByTestId('semiont-assist-control'));
+      expect(onDismissProgress).toHaveBeenCalledTimes(1);
+    });
+
+    it('a truncated completion says so; a natural stop does not (GFR P3b, D6)', () => {
+      // The mocked translator echoes unknown keys, so the assertion reads the
+      // KEY the real assistProgressCopy branch picked — structure, not copy.
+      const base = { ...defaultProps, onGenerate: () => {}, isGenerating: false };
+      const { unmount } = renderWithEventBus(
+        <ResourceInfoPanel {...base}
+          generationProgress={{ percentage: 100, message: { code: 'complete-generated', truncated: true } }} />
+      );
+      expect(screen.getByTestId('semiont-assist-status').textContent)
+        .toContain('codeCompleteGeneratedTruncated');
+      unmount();
+
+      renderWithEventBus(
+        <ResourceInfoPanel {...base}
+          generationProgress={{ percentage: 100, message: { code: 'complete-generated', truncated: false } }} />
+      );
+      expect(screen.getByTestId('semiont-assist-status').textContent)
+        .toContain('codeCompleteGenerated');
+      expect(screen.getByTestId('semiont-assist-status').textContent)
+        .not.toContain('Truncated');
+    });
+
+    it('the ended frame speaks completion even when the final progress frame lost the race (GENERATION-ARRIVAL D4/D5)', () => {
+      // The screenshot case: last frame is the 95% "creating" payload, the
+      // terminal 100% frame never arrived — but the outcome did. The sentence
+      // derives from the OUTCOME, not the racing frame.
+      renderWithEventBus(
+        <ResourceInfoPanel {...defaultProps} onGenerate={() => {}}
+          isGenerating={false}
+          generationProgress={{ percentage: 95, message: { code: 'creating-resource' } }}
+          generationOutcome={{
+            resourceId: makeResourceId('urn:semiont:resource:new1'),
+            resourceName: 'Summary of PB',
+            truncated: false,
+          }} />
+      );
+      expect(screen.getByTestId('semiont-assist-status').textContent).toBe('codeCompleteGenerated');
+    });
+
+    it('a truncated outcome says so — the bit rides the outcome, not the racing frame (D5)', () => {
+      renderWithEventBus(
+        <ResourceInfoPanel {...defaultProps} onGenerate={() => {}}
+          isGenerating={false}
+          generationProgress={{ percentage: 95, message: { code: 'creating-resource' } }}
+          generationOutcome={{
+            resourceId: makeResourceId('urn:semiont:resource:new1'),
+            resourceName: 'Summary of PB',
+            truncated: true,
+          }} />
+      );
+      expect(screen.getByTestId('semiont-assist-status').textContent).toBe('codeCompleteGeneratedTruncated');
+    });
+
+    it('no outcome, no link: the ended frame renders without one until job:complete arrives', () => {
+      renderWithEventBus(
+        <ResourceInfoPanel {...defaultProps} onGenerate={() => {}}
+          isGenerating={false}
+          generationProgress={{ percentage: 100, message: { code: 'complete-generated', truncated: false } }}
+          generationOutcome={null} />
+      );
+      expect(screen.queryByText('Summary of PB')).toBeNull();
+    });
   });
 
   describe('Provenance Section', () => {
@@ -348,7 +462,9 @@ describe('ResourceInfoPanel Component', () => {
       expect(screen.getByText('Alice, Bob')).toBeInTheDocument();
     });
 
-    it('should render wasDerivedFrom when provided', () => {
+    it('should render wasDerivedFrom when provided — the id is the unresolved fallback', () => {
+      // The factory client's fetch fails in jsdom (no server), so the
+      // descriptor never resolves and the raw id stays as the honest label.
       renderWithEventBus(
         <ResourceInfoPanel
           {...defaultProps}
@@ -359,6 +475,68 @@ describe('ResourceInfoPanel Component', () => {
       expect(screen.getByText('urn:semiont:resource:abc123')).toBeInTheDocument();
     });
 
+    it('a derived-from id is a LINK, and clicking it opens that resource', () => {
+      // Rendering the id is half the feature; the provenance chain is only
+      // walkable if the id navigates. The click goes through the session's
+      // client, so a panel handed no session must not throw either — the
+      // optional chain below is load-bearing, not defensive noise.
+      // `renderWithEventBus` injects its own per-test session via cloneElement,
+      // so the spy has to go on THAT client — one created here would never be
+      // the one the button calls.
+      const { client } = renderWithEventBus(
+        <ResourceInfoPanel
+          {...defaultProps}
+          wasDerivedFrom="urn:semiont:resource:abc123"
+        />
+      );
+      const openSpy = vi.spyOn(client.browse, 'openResource');
+
+      fireEvent.click(screen.getByText('urn:semiont:resource:abc123'));
+      expect(openSpy).toHaveBeenCalledTimes(1);
+      expect(String(openSpy.mock.calls[0]![0])).toBe('urn:semiont:resource:abc123');
+    });
+
+    it('resolves the derived-from id to its resource NAME; clicks still navigate by id', () => {
+      // The id is wire identity, not presentation. Once `browse.resource`
+      // serves the source's descriptor, the link wears its name — the raw
+      // hash only survives while the descriptor is unresolved (pin below).
+      const { SemiontWrapper, session, client } = createTestSemiontWrapper();
+      vi.spyOn(client.browse, 'resource').mockReturnValue(
+        new BehaviorSubject<CacheState<ResourceDescriptor>>({
+          status: 'ready',
+          value: { '@id': 'urn:semiont:resource:abc123', name: 'Source Doc' } as ResourceDescriptor,
+        }) as unknown as CacheObservable<ResourceDescriptor>,
+      );
+      const openSpy = vi.spyOn(client.browse, 'openResource');
+      render(
+        <ResourceInfoPanel
+          {...defaultProps}
+          session={session}
+          wasDerivedFrom="urn:semiont:resource:abc123"
+        />,
+        { wrapper: ({ children }) => <SemiontWrapper>{children}</SemiontWrapper> },
+      );
+
+      expect(screen.getByText('Source Doc')).toBeInTheDocument();
+      expect(screen.queryByText('urn:semiont:resource:abc123')).toBeNull();
+
+      fireEvent.click(screen.getByText('Source Doc'));
+      expect(String(openSpy.mock.calls[0]![0])).toBe('urn:semiont:resource:abc123');
+    });
+
+    it('renders every id when the resource derives from several', () => {
+      renderWithEventBus(
+        <ResourceInfoPanel
+          {...defaultProps}
+          wasDerivedFrom={['urn:semiont:resource:a', 'urn:semiont:resource:b'] as never}
+        />
+      );
+      // The separator lives inside the button (`{i > 0 && ', '}{id}`), so the
+      // second one's text node is ", urn:…:b" — matched loosely on purpose.
+      expect(screen.getByText(/urn:semiont:resource:a/)).toBeInTheDocument();
+      expect(screen.getByText(/urn:semiont:resource:b/)).toBeInTheDocument();
+    });
+
     it('falls back to generator for attribution when wasAttributedTo is absent', () => {
       renderWithEventBus(
         <ResourceInfoPanel

package/src/components/resource/panels/__tests__/TagEntry.test.tsx

@@ -183,7 +183,6 @@ describe('TagEntry', () => {
 
       expect(clickHandler).toHaveBeenCalledWith({
         annotationId: 'tag-1',
-        motivation: 'tagging',
       });
 
       subscription.unsubscribe();

package/src/components/settings/SettingsPanel.css

@@ -15,10 +15,6 @@
   color: var(--semiont-text-primary);
 }
 
-[data-theme="dark"] .semiont-settings-panel__title {
-  color: var(--semiont-text-primary);
-}
-
 .semiont-settings-panel__content {
   display: flex;
   flex-direction: column;

package/src/features/auth/auth.css

@@ -53,19 +53,11 @@
   margin-bottom: 0.5rem;
 }
 
-[data-theme="dark"] .semiont-auth__welcome {
-  color: var(--semiont-text-primary);
-}
-
 .semiont-auth__subtitle {
   font-size: 1rem;
   color: var(--semiont-text-secondary);
 }
 
-[data-theme="dark"] .semiont-auth__subtitle {
-  color: var(--semiont-text-secondary);
-}
-
 /* Error display */
 .semiont-auth__error-container {
   margin-bottom: 1.5rem;
@@ -129,10 +121,6 @@
   letter-spacing: 0.05em;
 }
 
-[data-theme="dark"] .semiont-auth__divider-text {
-  color: var(--semiont-text-secondary);
-}
-
 /* Info text */
 .semiont-auth__info {
   text-align: center;
@@ -227,10 +215,6 @@
   margin-bottom: 0.5rem;
 }
 
-[data-theme="dark"] .semiont-auth__signup-title {
-  color: var(--semiont-text-primary);
-}
-
 .semiont-auth__signup-content {
   display: flex;
   flex-direction: column;
@@ -244,10 +228,6 @@
   line-height: 1.5;
 }
 
-[data-theme="dark"] .semiont-auth__signup-info {
-  color: var(--semiont-text-secondary);
-}
-
 .semiont-auth__signup-footer {
   text-align: center;
   padding-top: 1rem;
@@ -350,16 +330,12 @@
   display: inline-block;
 }
 
-[data-theme="dark"] .semiont-form__url-status--checking {
-  color: var(--semiont-text-tertiary);
-}
-
 .semiont-form__url-status--ok {
   color: var(--semiont-color-success);
 }
 
 [data-theme="dark"] .semiont-form__url-status--ok {
-  color: var(--semiont-color-success);
+  color: var(--semiont-color-success-light);
 }
 
 .semiont-form__url-status--error {
@@ -367,5 +343,5 @@
 }
 
 [data-theme="dark"] .semiont-form__url-status--error {
-  color: var(--semiont-color-error);
+  color: var(--semiont-color-error-light);
 }

package/src/features/resource-compose/__tests__/ResourceComposePage.test.tsx

@@ -28,10 +28,7 @@ vi.mock('../../../components/CodeMirrorRenderer', () => ({
 const createMockTranslations = () => ({
   title: 'Compose Resource',
   titleEditClone: 'Edit Cloned Resource',
-  titleCompleteReference: 'Complete Reference',
   subtitleClone: 'Editing a cloned resource',
-  subtitleReference: 'Creating a new resource for reference',
-  linkedNoticePrefix: 'This resource will be linked',
   resourceName: 'Resource Name',
   resourceNamePlaceholder: 'Enter resource name',
   entityTypes: 'Entity Types',
@@ -53,9 +50,7 @@ const createMockTranslations = () => ({
   cancel: 'Cancel',
   saving: 'Saving...',
   creating: 'Creating...',
-  creatingAndLinking: 'Creating and linking...',
   saveClonedResource: 'Save Cloned Resource',
-  createAndLinkResource: 'Create and Link Resource',
   createResource: 'Create Resource',
 });
 
@@ -207,66 +202,6 @@ describe('ResourceComposePage', () => {
     });
   });
 
-  describe('Reference Completion Mode', () => {
-    it('shows reference completion title', () => {
-      const props = createMockProps({
-        mode: 'reference',
-        referenceData: {
-          annotationUri: 'http://localhost:8080/annotations/ref-1',
-          sourceDocumentId: 'doc-1',
-          name: 'Referenced Resource',
-          entityTypes: ['Document'],
-        },
-      });
-      renderWithProviders(<ResourceComposePage {...props} />);
-
-      expect(screen.getByText('Complete Reference')).toBeInTheDocument();
-      expect(screen.getByText('Creating a new resource for reference')).toBeInTheDocument();
-      expect(screen.getByText('This resource will be linked')).toBeInTheDocument();
-    });
-
-    it('initializes with reference data', () => {
-      const props = createMockProps({
-        mode: 'reference',
-        referenceData: {
-          annotationUri: 'http://localhost:8080/annotations/ref-1',
-          sourceDocumentId: 'doc-1',
-          name: 'Referenced Resource',
-          entityTypes: ['Document', 'Article'],
-        },
-      });
-      renderWithProviders(<ResourceComposePage {...props} />);
-
-      const nameInput = screen.getByLabelText('Resource Name') as HTMLInputElement;
-      expect(nameInput.value).toBe('Referenced Resource');
-
-      expect(screen.getByText('Document')).toBeInTheDocument();
-      expect(screen.getByText('Article')).toBeInTheDocument();
-    });
-
-    it('shows entity types as read-only when provided', () => {
-      const props = createMockProps({
-        mode: 'reference',
-        referenceData: {
-          annotationUri: 'http://localhost:8080/annotations/ref-1',
-          sourceDocumentId: 'doc-1',
-          name: 'Referenced Resource',
-          entityTypes: ['Document'],
-        },
-      });
-      renderWithProviders(<ResourceComposePage {...props} />);
-
-      // Should show read-only entity types
-      expect(screen.getByText('Document')).toBeInTheDocument();
-
-      // Should not show selectable buttons
-      expect(screen.queryByRole('button', { name: /Document entity type/ })).not.toBeInTheDocument();
-    });
-  });
-
-  // Entity Type Selection tests removed - functionality not present in current component
-  // The component only displays entity types in reference mode, doesn't have selection buttons
-
   describe('Content Input Method', () => {
     it('defaults to write mode', () => {
       const props = createMockProps();