@semiont/react-ui 0.5.26 → 0.5.28

package/src/components/modals/__tests__/ResourceGenerateModal.test.tsx

@@ -1,79 +1,55 @@
 /**
- * GENERATE-FROM-BUTTON P2/P4 — the resource-generate flow modal.
+ * GENERATE-FROM-BUTTON P2/P4 → FLOW-LIFECYCLE-CONVERGENCE P3 →
+ * GATHER-AT-THE-TOP P2 — the resource-generate flow modal.
  *
- * Drives the step machine: configure-gather → review → configure-generation.
- * `useResourceGather` is mocked so we control the gathered context and assert
- * how the step wires `gather()` (incl. the Phase-4 exclusion threading) and
- * `onGenerateSubmit`. `useSemiont` is mocked to feed the entity-type options.
+ * One composite stack, no step machine: the gather controls sit at the TOP,
+ * the gathered evidence appears below them once gather fires, and the
+ * generation params render beneath the evidence once context arrives —
+ * [gather zone] → [evidence] → [act zone], the same grammar the resolve
+ * wizard expresses. Gather state arrives as PROPS (the page reads
+ * `gather.resourceContext$` and friends off the state unit) and the gather
+ * itself is an `onGather` callback — the modal mocks no hook and reaches for
+ * no provider (FLC A6). Entity-type options are owner-supplied, so a failed
+ * load cannot surface as an empty vocabulary.
  */
 import { describe, it, expect, vi, beforeEach, type Mock } from 'vitest';
 import { render, screen, fireEvent } from '@testing-library/react';
 import '@testing-library/jest-dom';
-import { BehaviorSubject, of } from 'rxjs';
 import type { GatheredContext } from '@semiont/core';
+import type { ResourceGatherOptions } from '@semiont/sdk';
 import type { GenerationConfig } from '../ConfigureGenerationStep';
+import { ResourceGenerateModal } from '../ResourceGenerateModal';
 
 const RESOURCE_CONTEXT = {
-  focus: { kind: 'resource', resource: { id: 'res-1', name: 'My Resource' }, summary: 'A short summary' },
+  focus: { kind: 'resource', resource: { '@id': 'res-1', name: 'My Resource' }, summary: 'A short summary' },
   graph: { nodes: [{ id: 'res-1', type: 'resource', label: 'My Resource' }], edges: [] },
   metadata: {},
 } as unknown as GatheredContext;
 
-// Mutable hook state + spies, shared with the hoisted vi.mock factory.
-const h = vi.hoisted(() => ({
-  gather: vi.fn(),
-  reset: vi.fn(),
-  state: { context: null as unknown, loading: false, error: null as Error | null },
-}));
-
-vi.mock('../../../hooks/useResourceGather', () => ({
-  useResourceGather: () => ({
-    context: h.state.context,
-    loading: h.state.loading,
-    error: h.state.error,
-    gather: h.gather,
-    reset: h.reset,
-  }),
-}));
-
-// The modal no longer fetches entity types; the owner supplies them, so a
-// failed load cannot surface as an empty vocabulary. The stable-observable
-// note below is kept because the client mock still backs other calls.
-// See .plans/PANEL-FAILURE-STATES.md
-// Stable observable instance — the modal calls `entityTypes()` inline in
-// render, so a fresh observable each call would re-subscribe every render and
-// loop. The real SDK returns a cached observable; mirror that here.
-const entityTypes$ = of<string[]>(['Person', 'Topic']);
-const mockClient = { browse: { entityTypes: () => entityTypes$ } };
-const activeSession$ = new BehaviorSubject<unknown>({ client: mockClient });
-vi.mock('../../../session/SemiontProvider', async () => {
-  const actual = await vi.importActual<typeof import('../../../session/SemiontProvider')>('../../../session/SemiontProvider');
-  return { ...actual, useSemiont: () => ({ activeSession$ }) };
-});
-
-import { ResourceGenerateModal } from '../ResourceGenerateModal';
-
 const T = {
-  gatherTitle: 'Configure Gather',
-  reviewTitle: 'Review Context',
-  configureTitle: 'Configure Generation',
-  next: 'Next',
-  back: 'Back',
-  cancel: 'Cancel',
+  title: 'Generate from this Resource',
   gatherIntro: 'Choose what to include.',
   includeContent: 'Include content',
   includeSummary: 'Include summary',
   gatherDepth: 'Depth',
   gatherMaxResources: 'Max resources',
   gatherButton: 'Gather',
-  excludeLabel: 'Exclude from recall',
+  recallLabel: 'Included in recall — deselect to exclude',
   loadingContext: 'Gathering…',
   failedContext: 'Failed',
   sourceContextLabel: 'Resource',
   connectionsLabel: 'Connections',
   citedByLabel: 'Cited by',
+  graphPaneTitle: 'In the graph',
+  graphEmpty: 'No links yet.', resourceLinkLabel: 'Resource link',
+  corpusPaneTitle: 'In the corpus',
+  corpusEmpty: 'Nothing similar in the corpus.',
+  excludedReceipt: '{{types}} excluded from this recall',
+  machineRead: 'OCR',
+  score: 'Score',
   resourceTitle: 'New resource title',
   resourceTitlePlaceholder: 'Title…',
+  saveLocation: 'Save location',
   additionalInstructions: 'Additional Instructions',
   additionalInstructionsPlaceholder: 'Optional…',
   language: 'Language',
@@ -83,11 +59,17 @@ const T = {
   creativityCreative: 'Creative',
   maxLength: 'Max Length',
   maxLengthHelp: 'Max help',
+  maxLengthCeiling: 'Limited to {{maxOutputTokens}} tokens by {{model}}.',
   generate: 'Generate',
+  discardDraftPrompt: 'Discard this draft?',
+  discardDraft: 'Discard',
+  keepEditing: 'Keep editing',
+  editGather: 'Change gather settings',
 };
 
 let onClose: Mock<() => void>;
 let onGenerateSubmit: Mock<(resourceId: string, config: GenerationConfig) => void>;
+let onGather: Mock<(options: ResourceGatherOptions) => void>;
 
 function renderModal(props: Partial<React.ComponentProps<typeof ResourceGenerateModal>> = {}) {
   return render(
@@ -99,6 +81,10 @@ function renderModal(props: Partial<React.ComponentProps<typeof ResourceGenerate
       locale="en"
       entityTypeOptions={['Person', 'Topic']}
       onGenerateSubmit={onGenerateSubmit}
+      gatherContext={null}
+      gatherLoading={false}
+      gatherError={null}
+      onGather={onGather}
       translations={T}
       {...props}
     />,
@@ -110,39 +96,81 @@ describe('ResourceGenerateModal', () => {
     vi.clearAllMocks();
     onClose = vi.fn<() => void>();
     onGenerateSubmit = vi.fn<(resourceId: string, config: GenerationConfig) => void>();
-    h.state = { context: null, loading: false, error: null };
-    activeSession$.next({ client: mockClient });
+    onGather = vi.fn<(options: ResourceGatherOptions) => void>();
     // jsdom doesn't implement scrollIntoView; GatherContextStep may call it.
     Element.prototype.scrollIntoView = vi.fn();
   });
 
   it('renders nothing when closed', () => {
     renderModal({ isOpen: false });
-    expect(screen.queryByText('Configure Gather')).not.toBeInTheDocument();
+    expect(screen.queryByText(T.title)).not.toBeInTheDocument();
   });
 
-  it('opens on the configure-gather step with the exclusion options', () => {
-    renderModal();
-    expect(screen.getByText('Configure Gather')).toBeInTheDocument(); // step title
-    expect(screen.getByText('Choose what to include.')).toBeInTheDocument();
-    expect(screen.getByLabelText('Include content')).toBeInTheDocument();
+  it('opens with the gather controls at the top and nothing below them yet', () => {
+    // Stale slots must not leak a previous run's evidence into a fresh open:
+    // even with a context PROP already present, nothing renders below the
+    // controls until THIS run's gather fires.
+    const { baseElement } = renderModal({ gatherContext: RESOURCE_CONTEXT });
+    expect(screen.getByText(T.title)).toBeInTheDocument(); // the one modal title
+    expect(screen.getByText(T.gatherIntro)).toBeInTheDocument();
+    expect(screen.getByLabelText(T.includeContent)).toBeInTheDocument();
     expect(screen.getByRole('button', { name: 'Person' })).toBeInTheDocument();
     expect(screen.getByRole('button', { name: 'Topic' })).toBeInTheDocument();
+    expect(baseElement.querySelector('.semiont-wizard__step-scroll')).not.toBeNull();
+    expect(screen.queryByText(T.graphPaneTitle)).not.toBeInTheDocument();
+    expect(screen.queryByLabelText(T.resourceTitle)).not.toBeInTheDocument();
   });
 
-  it('submitting the gather step calls gather() and advances to review (exclusion omitted when none picked)', () => {
+  it('Gather emits onGather; the spent controls collapse to a receipt of what fired', () => {
+    // The modal no longer knows how to gather — it says WHAT to gather and the
+    // page wires the state unit (FLC D3). No resourceId in the payload: the
+    // owner already holds it.
+    const { baseElement } = renderModal({ gatherLoading: true });
+    fireEvent.click(screen.getByRole('button', { name: /Gather/ }));
+    expect(onGather).toHaveBeenCalledWith({ includeContent: true, includeSummary: true, depth: 2, maxResources: 10 });
+    expect(baseElement.querySelector('.semiont-gather__loading')).not.toBeNull();
+    // The form's job is done: it folds into a one-line receipt of what THIS
+    // gather asked for, and the evidence leads the pane. The form stays
+    // mounted (hidden) so its values survive for the expand path.
+    const receipt = screen.getByTitle(T.editGather);
+    expect(receipt.textContent).toContain(`${T.gatherDepth} 2`);
+    expect(receipt.textContent).toContain(`${T.gatherMaxResources} 10`);
+    expect(receipt.textContent).toContain(T.includeContent);
+    expect(screen.getByText(T.gatherIntro)).not.toBeVisible();
+  });
+
+  it('the receipt names the exclusions of THIS recall', () => {
     renderModal();
+    fireEvent.click(screen.getByRole('button', { name: 'Person' }));
     fireEvent.click(screen.getByRole('button', { name: /Gather/ }));
-    expect(h.gather).toHaveBeenCalledWith('res-1', { includeContent: true, includeSummary: true, depth: 2, maxResources: 10 });
-    expect(screen.getByText('Review Context')).toBeInTheDocument(); // step title flipped
-    expect(screen.getByRole('button', { name: /Next/ })).toBeDisabled(); // no context yet
+    expect(screen.getByTitle(T.editGather).textContent)
+      .toContain('Person excluded from this recall');
   });
 
-  it('threads picked entity types into the gather call', () => {
+  it('the receipt expands back to the form — values preserved — and re-gather collapses again', () => {
+    renderModal({ gatherContext: RESOURCE_CONTEXT });
+    fireEvent.change(screen.getByLabelText(T.gatherDepth), { target: { value: '4' } });
+    fireEvent.click(screen.getByRole('button', { name: /Gather/ }));
+    expect(screen.getByTitle(T.editGather).textContent).toContain(`${T.gatherDepth} 4`);
+
+    fireEvent.click(screen.getByTitle(T.editGather));
+    const depthInput = screen.getByLabelText(T.gatherDepth);
+    expect(depthInput).toBeVisible();
+    expect(depthInput).toHaveValue(4); // not re-initialized — the form never unmounted
+    expect(screen.queryByTitle(T.editGather)).not.toBeInTheDocument();
+
+    fireEvent.change(depthInput, { target: { value: '3' } });
+    fireEvent.click(screen.getByRole('button', { name: /Gather/ }));
+    expect(onGather).toHaveBeenCalledTimes(2);
+    expect(onGather).toHaveBeenLastCalledWith(expect.objectContaining({ depth: 3 }));
+    expect(screen.getByTitle(T.editGather).textContent).toContain(`${T.gatherDepth} 3`);
+  });
+
+  it('threads crossed-off entity types into the gather options as the exclude list', () => {
     renderModal();
-    fireEvent.click(screen.getByRole('button', { name: 'Person' })); // select to exclude
+    fireEvent.click(screen.getByRole('button', { name: 'Person' })); // cross off the recall
     fireEvent.click(screen.getByRole('button', { name: /Gather/ }));
-    expect(h.gather).toHaveBeenCalledWith('res-1', {
+    expect(onGather).toHaveBeenCalledWith({
       includeContent: true,
       includeSummary: true,
       depth: 2,
@@ -151,17 +179,34 @@ describe('ResourceGenerateModal', () => {
     });
   });
 
-  it('walks gather → review → configure-generation → emits onGenerateSubmit then closes', () => {
-    h.state.context = RESOURCE_CONTEXT; // gather already resolved
+  it('every entity type starts INCLUDED — deselecting is what excludes (recall chips)', () => {
+    // The SDK's wire is an exclude list, but the natural posture is
+    // "everything is in the recall until you say otherwise": chips render
+    // included by default and a click crosses one off.
     renderModal();
+    expect(screen.getByText(T.recallLabel)).toBeInTheDocument();
+    const person = screen.getByRole('button', { name: 'Person' });
+    const topic = screen.getByRole('button', { name: 'Topic' });
+    expect(person).toHaveAttribute('aria-pressed', 'true');
+    expect(person).toHaveAttribute('data-included', 'true');
+    expect(person.className).toContain('semiont-form__recall-chip');
+
+    fireEvent.click(person);
+    expect(person).toHaveAttribute('aria-pressed', 'false');
+    expect(person).toHaveAttribute('data-included', 'false');
+    expect(topic).toHaveAttribute('aria-pressed', 'true'); // the rest stay in
+
+    fireEvent.click(person); // back in — the toggle round-trips
+    expect(person).toHaveAttribute('aria-pressed', 'true');
+  });
+
+  it('params render beneath the evidence once context arrives; Generate emits and closes', () => {
+    renderModal({ gatherContext: RESOURCE_CONTEXT }); // gather resolves immediately
 
-    fireEvent.click(screen.getByRole('button', { name: /Gather/ })); // → review
-    const next = screen.getByRole('button', { name: /Next/ });
-    expect(next).toBeEnabled();
-    fireEvent.click(next); // → configure-generation
+    fireEvent.click(screen.getByRole('button', { name: /Gather/ }));
 
-    fireEvent.change(screen.getByLabelText('New resource title'), { target: { value: 'Generated Doc' } });
-    fireEvent.change(screen.getByLabelText('Save location'), { target: { value: 'generated/out.md' } });
+    fireEvent.change(screen.getByLabelText(T.resourceTitle), { target: { value: 'Generated Doc' } });
+    fireEvent.change(screen.getByLabelText(T.saveLocation), { target: { value: 'generated/out.md' } });
     fireEvent.click(screen.getByRole('button', { name: /Generate/ }));
 
     expect(onGenerateSubmit).toHaveBeenCalledTimes(1);
@@ -176,22 +221,38 @@ describe('ResourceGenerateModal', () => {
     expect(onClose).toHaveBeenCalled();
   });
 
-  it('Back from configure-generation returns to review', () => {
-    h.state.context = RESOURCE_CONTEXT;
-    renderModal();
-    fireEvent.click(screen.getByRole('button', { name: /Gather/ })); // → review
-    fireEvent.click(screen.getByRole('button', { name: /Next/ }));   // → configure-generation
-    expect(screen.getByText('Configure Generation')).toBeInTheDocument();
-    fireEvent.click(screen.getByRole('button', { name: /Back/ }));   // → review
-    expect(screen.getByText('Review Context')).toBeInTheDocument();
+  it('a failed gather shows its failure in place', () => {
+    // The props are the state unit's slots verbatim; the modal renders them
+    // without owning them (FLC A6).
+    renderModal({ gatherLoading: true });
+    fireEvent.click(screen.getByRole('button', { name: /Gather/ }));
+
+    render(
+      <ResourceGenerateModal
+        isOpen onClose={onClose} resourceId="res-1" defaultTitle="Default Title"
+        locale="en" entityTypeOptions={['Person', 'Topic']} onGenerateSubmit={onGenerateSubmit}
+        gatherContext={null} gatherLoading={false} gatherError={new Error('boom')}
+        onGather={onGather} translations={T}
+      />,
+    );
+    fireEvent.click(screen.getAllByRole('button', { name: /Gather/ }).at(-1)!);
+    expect(screen.getByText(T.failedContext)).toBeInTheDocument();
   });
 
-  it('Back from review returns to the configure-gather step', () => {
-    renderModal();
-    fireEvent.click(screen.getByRole('button', { name: /Gather/ })); // → review
-    expect(screen.getByText('Review Context')).toBeInTheDocument();
-    fireEvent.click(screen.getByRole('button', { name: /Back/ })); // → configure-gather
-    expect(screen.getByText('Configure Gather')).toBeInTheDocument();
+  it('re-Gather refreshes the evidence in place — the stack stays', () => {
+    renderModal({ gatherContext: RESOURCE_CONTEXT });
+    fireEvent.click(screen.getByRole('button', { name: /Gather/ }));
+    fireEvent.click(screen.getByTitle(T.editGather)); // expand the receipt
+    fireEvent.click(screen.getByRole('button', { name: /Gather/ })); // tweak-and-regather
+    expect(onGather).toHaveBeenCalledTimes(2);
+    expect(screen.getByText(T.graphPaneTitle)).toBeInTheDocument();
+    expect(screen.getByLabelText(T.resourceTitle)).toBeInTheDocument();
+  });
+
+  it('no Back anywhere — a single stack has nothing to go back to (D6)', () => {
+    renderModal({ gatherContext: RESOURCE_CONTEXT });
+    fireEvent.click(screen.getByRole('button', { name: /Gather/ }));
+    expect(screen.queryAllByRole('button', { name: /Back/ })).toHaveLength(0);
   });
 
   it('the header close button calls onClose', () => {
@@ -199,4 +260,135 @@ describe('ResourceGenerateModal', () => {
     fireEvent.click(screen.getByLabelText('Close'));
     expect(onClose).toHaveBeenCalledTimes(1);
   });
+
+  it('opening seeds the proposed title from defaultTitle, even one that arrived after mount (GFR A4)', () => {
+    // The page passes the source resource's name, which loads asynchronously —
+    // a draft seeded only in the useState initializer holds whatever was there
+    // at FIRST render, which for the real page was ''. Opening is the moment
+    // that matters: the draft re-seeds then.
+    const { rerender } = render(
+      <ResourceGenerateModal
+        isOpen={false} onClose={onClose} resourceId="res-1" defaultTitle=""
+        locale="en" entityTypeOptions={[]} onGenerateSubmit={onGenerateSubmit}
+        gatherContext={RESOURCE_CONTEXT} gatherLoading={false} gatherError={null}
+        onGather={onGather} translations={T}
+      />,
+    );
+    rerender(
+      <ResourceGenerateModal
+        isOpen onClose={onClose} resourceId="res-1" defaultTitle="PB"
+        locale="en" entityTypeOptions={[]} onGenerateSubmit={onGenerateSubmit}
+        gatherContext={RESOURCE_CONTEXT} gatherLoading={false} gatherError={null}
+        onGather={onGather} translations={T}
+      />,
+    );
+    fireEvent.click(screen.getByRole('button', { name: /Gather/ }));
+    expect(screen.getByLabelText(T.resourceTitle)).toHaveValue('PB');
+  });
+
+  it('evidence stays in view above the params — ONE scroll pane, nothing scrolls alone (A3)', () => {
+    const { baseElement } = renderModal({ gatherContext: RESOURCE_CONTEXT });
+    fireEvent.click(screen.getByRole('button', { name: /Gather/ }));
+
+    const scroll = baseElement.querySelector('.semiont-wizard__step-scroll');
+    expect(scroll).not.toBeNull();
+    expect(scroll!.querySelector('.semiont-gather__outer')).not.toBeNull();      // the evidence
+    expect(screen.getByText(T.graphPaneTitle)).toBeInTheDocument();              // graph pane up
+    expect(screen.getByLabelText(T.resourceTitle)).toBeInTheDocument();          // the form, below
+    for (const form of Array.from(scroll!.querySelectorAll('form.semiont-form'))) {
+      expect(form.className).not.toContain('semiont-form--scrollable');
+    }
+  });
+
+  it('the panel carries the widened class (GEP P2, D2)', () => {
+    const { baseElement } = renderModal();
+    const panel = baseElement.querySelector('.semiont-search-modal__panel--gather');
+    expect(panel).not.toBeNull();
+    expect(panel!.className).toContain('semiont-search-modal__panel--wide');
+  });
+
+  it('every footer is the wizard footer — no dismissal, no flex (GFR A5)', () => {
+    // The modal renders via a HeadlessUI portal, so query the whole document.
+    const { baseElement } = renderModal({ gatherContext: RESOURCE_CONTEXT });
+    const footerPins = () => {
+      expect(baseElement.querySelector('.semiont-modal__actions--wizard')).not.toBeNull();
+      expect(baseElement.querySelectorAll('.semiont-button--flex')).toHaveLength(0);
+      const footerButtons = Array.from(
+        baseElement.querySelectorAll('.semiont-modal__actions button'),
+      ).map((b) => b.textContent ?? '');
+      expect(footerButtons.filter((l) => /cancel|✕/i.test(l))).toEqual([]);
+    };
+
+    footerPins(); // controls alone
+    fireEvent.click(screen.getByRole('button', { name: /Gather/ }));
+    footerPins(); // the full stack: Gather footer + Generate footer
+  });
+});
+
+// GATHER-AT-THE-TOP P1: dismissal guards typed work. D5 — typed text only
+// (title beyond the seeded default, save location, instructions); checkbox,
+// depth, and exclusion state is cheap to redo and never nags.
+describe('ResourceGenerateModal — dismissal guards typed work (GATHER-AT-THE-TOP P1)', () => {
+  beforeEach(() => {
+    onClose = vi.fn();
+    onGenerateSubmit = vi.fn();
+    onGather = vi.fn();
+  });
+
+  it('a typed save location guards dismissal; Keep editing stays, Discard closes', () => {
+    renderModal({ gatherContext: RESOURCE_CONTEXT });
+    fireEvent.click(screen.getByRole('button', { name: /Gather/ })); // reveal the stack
+    fireEvent.change(screen.getByLabelText(T.saveLocation), { target: { value: 'generated/out.md' } });
+
+    fireEvent.click(screen.getByLabelText('Close'));
+    expect(onClose).not.toHaveBeenCalled();
+    expect(screen.getByText(T.discardDraftPrompt)).toBeInTheDocument();
+
+    fireEvent.click(screen.getByRole('button', { name: T.keepEditing }));
+    expect(screen.queryByText(T.discardDraftPrompt)).not.toBeInTheDocument();
+    expect(screen.getByLabelText(T.saveLocation)).toHaveValue('generated/out.md');
+    expect(onClose).not.toHaveBeenCalled();
+
+    fireEvent.click(screen.getByLabelText('Close'));
+    fireEvent.click(screen.getByRole('button', { name: T.discardDraft }));
+    expect(onClose).toHaveBeenCalledTimes(1);
+  });
+
+  it('a clean draft dismisses without any prompt', () => {
+    renderModal({ gatherContext: RESOURCE_CONTEXT });
+    fireEvent.click(screen.getByRole('button', { name: /Gather/ }));
+
+    fireEvent.click(screen.getByLabelText('Close'));
+    expect(screen.queryByText(T.discardDraftPrompt)).not.toBeInTheDocument();
+    expect(onClose).toHaveBeenCalledTimes(1);
+  });
+
+  it('a defaultTitle arriving mid-flow does not fake a dirty draft', () => {
+    // The source resource's name loads asynchronously: the baseline moves
+    // while the modal is open, the user has typed nothing. Dirtiness compares
+    // against what was SEEDED, not the live prop.
+    const { rerender } = renderModal({ defaultTitle: '', gatherContext: RESOURCE_CONTEXT });
+    fireEvent.click(screen.getByRole('button', { name: /Gather/ }));
+    rerender(
+      <ResourceGenerateModal
+        isOpen onClose={onClose} resourceId="res-1" defaultTitle="Loaded Name"
+        locale="en" entityTypeOptions={['Person', 'Topic']} onGenerateSubmit={onGenerateSubmit}
+        gatherContext={RESOURCE_CONTEXT} gatherLoading={false} gatherError={null}
+        onGather={onGather} translations={T}
+      />,
+    );
+
+    fireEvent.click(screen.getByLabelText('Close'));
+    expect(screen.queryByText(T.discardDraftPrompt)).not.toBeInTheDocument();
+    expect(onClose).toHaveBeenCalledTimes(1);
+  });
+
+  it('non-text state alone never nags — exclusions and depth are cheap to redo (D5)', () => {
+    renderModal();
+    fireEvent.click(screen.getByRole('button', { name: 'Person' })); // cross off the recall
+
+    fireEvent.click(screen.getByLabelText('Close'));
+    expect(screen.queryByText(T.discardDraftPrompt)).not.toBeInTheDocument();
+    expect(onClose).toHaveBeenCalledTimes(1);
+  });
 });

package/src/components/modals/__tests__/SearchModal.search-wiring.test.tsx

@@ -14,7 +14,7 @@
 import { describe, it, expect, beforeEach, vi } from 'vitest';
 import { asStates } from '../../../__tests__/test-client';
 import { screen, fireEvent, waitFor, act } from '@testing-library/react';
-import { BehaviorSubject } from 'rxjs';
+import { BehaviorSubject, map } from 'rxjs';
 import { renderWithProviders } from '../../../test-utils';
 import '@testing-library/jest-dom';
 import { SearchModal } from '../SearchModal';
@@ -34,7 +34,11 @@ vi.mock('@headlessui/react', () => ({
 
 // Mock the http-transport Observable surface
 const browseResourcesSubject = new BehaviorSubject<any[] | undefined>(undefined);
-const browseResourcesMock = vi.fn(() => asStates(browseResourcesSubject.asObservable()));
+const browseResourcesMock = vi.fn(() => asStates(browseResourcesSubject.asObservable().pipe(
+  // Arrays get the list envelope `resources()` now emits; `undefined`
+  // passes through as the pending state.
+  map((v) => (Array.isArray(v) ? { resources: v, total: v.length, offset: 0, limit: 20, matchKind: 'lexical' } : v)),
+)));
 
 // Stable client reference — useSemiont is called on every render, so a
 // fresh object literal would invalidate useMemo deps and restart the RxJS

package/src/components/modals/__tests__/SearchResultsStep.test.tsx

@@ -0,0 +1,61 @@
+/**
+ * GATHER-EVIDENCE-PANES D10 (amended 2026-08-19) — `SearchResultsStep` is pure
+ * RESULTS: ranked rows with scores and Link buttons, nothing else.
+ *
+ * The evidence lives with the HOST: the wizard stacks the full display-only
+ * `GatherContextStep` (quotation, graph pane, corpus pane, collapsed strategy
+ * band) above this step, exactly as on the configure steps. The original D10
+ * concern — corpus matches beside real results reading as a second, staler
+ * ranking — dissolved with the stacking: evidence sits above the strategy
+ * band, results below it, no competing side-by-side columns. This step
+ * therefore renders NO context of its own; a gather pane appearing here means
+ * someone re-embedded the minimal context redux this amendment deleted.
+ */
+import { describe, it, expect, vi } from 'vitest';
+import { render, screen } from '@testing-library/react';
+import '@testing-library/jest-dom';
+import { SearchResultsStep } from '../SearchResultsStep';
+
+const T = { noResults: 'None', score: 'Score', link: 'Link', back: 'Back' };
+
+const RESULTS = [
+  { '@id': 'r1', name: 'Martin Pauls', score: 57.46, matchReason: 'connected; semantic match' },
+  { '@id': 'r2', name: 'Arthur Fisher', score: 25.46, description: 'a citing resource' },
+] as never[];
+
+describe('SearchResultsStep — pure results (D10 amended)', () => {
+  it('renders ranked rows: name, score, reason, and a Link button each', () => {
+    render(
+      <SearchResultsStep results={RESULTS} onBack={vi.fn()} onLink={vi.fn()} translations={T} />,
+    );
+    expect(screen.getByText('Martin Pauls')).toBeInTheDocument();
+    expect(screen.getByText(`${T.score}: 57.46`)).toBeInTheDocument();
+    expect(screen.getByText('connected; semantic match')).toBeInTheDocument();
+    expect(screen.getByText('a citing resource')).toBeInTheDocument();
+    expect(screen.getAllByRole('button', { name: `🔗 ${T.link}` })).toHaveLength(2);
+  });
+
+  it('links the row that was clicked, by @id', () => {
+    const onLink = vi.fn();
+    render(
+      <SearchResultsStep results={RESULTS} onBack={vi.fn()} onLink={onLink} translations={T} />,
+    );
+    screen.getAllByRole('button', { name: `🔗 ${T.link}` })[1]!.click();
+    expect(onLink).toHaveBeenCalledWith('r2');
+  });
+
+  it('shows the empty state when nothing matched', () => {
+    render(
+      <SearchResultsStep results={[]} onBack={vi.fn()} onLink={vi.fn()} translations={T} />,
+    );
+    expect(screen.getByText(T.noResults)).toBeInTheDocument();
+  });
+
+  it('renders no context of its own — the host owns the evidence', () => {
+    const { container } = render(
+      <SearchResultsStep results={RESULTS} onBack={vi.fn()} onLink={vi.fn()} translations={T} />,
+    );
+    expect(container.querySelector('.semiont-gather-pane')).toBeNull();
+    expect(container.querySelector('.semiont-search-results__two-pane')).toBeNull();
+  });
+});