@sapui5/sap.ushell 1.138.1 → 1.139.0

package/src/main/js/sap/ushell/services/ShellNavigationInternal.js

@@ -7,7 +7,11 @@ sap.ui.define([
     "sap/ui/core/EventBus",
     "sap/ushell/services/ShellNavigationHashChanger",
     "sap/ui/core/routing/HashChanger"
-], function (EventBus, ShellNavigationHashChanger, HashChanger) {
+], (
+    EventBus,
+    ShellNavigationHashChanger,
+    HashChanger
+) => {
     "use strict";
 
     /* global hasher */
@@ -73,14 +77,14 @@ sap.ui.define([
      */
     function ShellNavigationInternal (oContainerInterface, sParameters, oServiceConfiguration) {
         function requestReload () {
-            sap.ui.require(["sap/m/MessageBox"], function (MessageBox) {
+            sap.ui.require(["sap/m/MessageBox"], (MessageBox) => {
                 MessageBox.show("Due to a configuration change on the server,\nclient and server are out of sync.\n We strongly recommend to reload the page soon.\nReload page now?", {
                     icon: MessageBox.Icon.ERROR,
                     title: "Client out of sync with server.",
                     actions: [MessageBox.Action.YES, MessageBox.Action.NO],
                     onClose: function (oAction) {
                         if (oAction === MessageBox.Action.YES) {
-                            window.setTimeout(function () {
+                            window.setTimeout(() => {
                                 window.location.reload();
                             }, 0);
                         }
@@ -89,22 +93,22 @@ sap.ui.define([
             });
         }
 
-        var oServiceConfig = oServiceConfiguration && oServiceConfiguration.config;
+        const oServiceConfig = oServiceConfiguration && oServiceConfiguration.config;
 
         // instantiate and exchange the HashChanger from UI5
         this.hashChanger = new ShellNavigationHashChanger(oServiceConfig);
 
         this._navigationFilterForForwardingToRegisteredRouters = function (AppLifeCycle, sHash) {
-            var bMatchedFLPRouters = this._aRouters.some(function (oRouter) {
+            const bMatchedFLPRouters = this._aRouters.some((oRouter) => {
                 return oRouter.match(sHash);
             });
 
             if (bMatchedFLPRouters) {
-                var oCurrentApplication = AppLifeCycle.getCurrentApplication();
-                var bIsApp = oCurrentApplication && oCurrentApplication.componentInstance && !oCurrentApplication.homePage;
+                const oCurrentApplication = AppLifeCycle.getCurrentApplication();
+                const bIsApp = oCurrentApplication && oCurrentApplication.componentInstance && !oCurrentApplication.homePage;
 
                 if (bIsApp) {
-                    var oAppRouter = oCurrentApplication.componentInstance.getRouter();
+                    const oAppRouter = oCurrentApplication.componentInstance.getRouter();
 
                     if (oAppRouter) {
                         // Avoid unexpected route matched in the application
@@ -125,7 +129,6 @@ sap.ui.define([
          *   An object like:
          *   <pre>
          *   {
-         *      "status": sap.ushell.NavigationState.Navigating,
          *      "isCrossAppNavigation": true,
          *      "innerAppRoute": "employee/overview"
          *   }
@@ -137,11 +140,10 @@ sap.ui.define([
          * @private
          */
         this.getNavigationContext = function () {
-            var oNavigationState = this.hashChanger.getCurrentNavigationState();
-            var bIsExternalNavigation = !this.hashChanger.isInnerAppNavigation(oNavigationState.oldHash, oNavigationState.newHash);
+            const oNavigationState = this.hashChanger.getCurrentNavigationState();
+            const bIsExternalNavigation = !this.hashChanger.isInnerAppNavigation(oNavigationState.oldHash, oNavigationState.newHash);
 
             return {
-                status: oNavigationState.status,
                 isCrossAppNavigation: bIsExternalNavigation,
                 innerAppRoute: this.hashChanger.getHash()
             };
@@ -167,6 +169,8 @@ sap.ui.define([
         /**
          * Set the value of the property this._bIsInitialNavigation.
          *
+         * @param {boolean} isInitialNavigation whether the initial navigation flag should be true.
+         *
          * @private
          */
         this.setIsInitialNavigation = function (isInitialNavigation) {
@@ -307,7 +311,7 @@ sap.ui.define([
          *   and navigates to it.
          * @param {object} oComponent optional, a SAP UI5 Component
          * @param {boolean} bWriteHistory writeHistory whether to create a history record (true, undefined) or replace the hash (false)
-         * @returns {Promise<undefined>} A Promise which resolves once the navigation was triggered
+         * @returns {Promise} A Promise which resolves once the navigation was triggered
          *
          * @private
          */
@@ -353,7 +357,7 @@ sap.ui.define([
             this._bIsInitialNavigation = true;
             hasher.prependHash = "";
             HashChanger.replaceHashChanger(this.hashChanger);
-            var oBus = EventBus.getInstance();
+            const oBus = EventBus.getInstance();
             oBus.subscribe("sap.ui.core.UnrecoverableClientStateCorruption", "RequestReload", requestReload);
             this.hashChanger.initShellNavigation(fnShellCallback);
 
@@ -437,9 +441,9 @@ sap.ui.define([
          * @private
          */
         this.replaceHashWithoutNavigation = function (sNewHash) {
-            hasher.changed.active = false; //disable changed signal
-            this._fnOriginalSetHash(sNewHash); //set hash without dispatching changed signal
-            hasher.changed.active = true; //re-enable signal
+            hasher.changed.active = false; // disable changed signal
+            this._fnOriginalSetHash(sNewHash); // set hash without dispatching changed signal
+            hasher.changed.active = true; // re-enable signal
         };
 
         /**
@@ -498,7 +502,7 @@ sap.ui.define([
         };
 
         // this navigation filter must always be the first filter
-        this.registerNavigationFilter(function () {
+        this.registerNavigationFilter(() => {
             /**
              * Checks whether the current hashChange event is triggered by the application by calling either
              * setHash or replaceHash method on the HashChanger.
@@ -517,7 +521,7 @@ sap.ui.define([
 
             // continue with hashChange event processing
             return this.NavigationFilterStatus.Continue;
-        }.bind(this));
+        });
 
         /**
          * This helper allows to register ShellNavigationInternal filters which depend on additional services, which might not be

package/src/main/js/sap/ushell/services/SmartNavigation.js

@@ -12,7 +12,7 @@
  * it is pertinent that the API user employs this service's version of <code>toExternal()</code> for cross application
  * navigation (instead) of using the one provided by CrossApplicationNavigation service.</p>
  *
- * @version 1.138.1
+ * @version 1.139.0
  *
  * @deprecated since 1.112. Please use the CrossApplicationNavigation service instead.
  */
@@ -23,14 +23,14 @@ sap.ui.define([
     "sap/base/Log",
     "sap/ushell/utils/UrlParsing",
     "sap/ushell/Container"
-], function (
+], (
     jQuery,
     utils,
     AppConfiguration,
     Log,
     UrlParsing,
     Container
-) {
+) => {
     "use strict";
 
     /**
@@ -59,6 +59,10 @@ sap.ui.define([
      * @augments sap.ushell.services.Service
      * @hideconstructor
      *
+     * @param {object} oContainerInterface the container interface, not used.
+     * @param {string} sParameters the parameter string, not used.
+     * @param {object} oServiceConfig the service configuration.
+     *
      * @see sap.ushell.Container#getServiceAsync
      * @since 1.44.0
      * @public
@@ -87,6 +91,7 @@ sap.ui.define([
      * Internally, this method delegates to {@link sap.ushell.services.CrossApplicationNavigation#getLinks}
      * and then sorts the resulting list accordingly.
      *
+     * @param {object|Array<Array<object>>} [oArgs] An object containing nominal arguments for the method.
      * @returns {jQuery.Promise} Resolves with an array of link objects
      *   sorted according to their relevance to the calling application.
      *
@@ -95,7 +100,7 @@ sap.ui.define([
      * @public
      */
     SmartNavigation.prototype.getLinks = function (oArgs) {
-        var oDeferred = new jQuery.Deferred();
+        const oDeferred = new jQuery.Deferred();
 
         Log.error("Call to deprecated service: 'SmartNavigation.getLinks'. Please use 'CrossApplicationNavigation.getLinks' instead",
             null,
@@ -103,8 +108,8 @@ sap.ui.define([
         );
 
         this._oCrossAppNavigationServicePromise
-            .then(function (CrossApplicationNavigationService) {
-                var oAllLinksPromise = CrossApplicationNavigationService.getLinks(oArgs);
+            .then((CrossApplicationNavigationService) => {
+                const oAllLinksPromise = CrossApplicationNavigationService.getLinks(oArgs);
 
                 if (!this._isTrackingEnabled(this._oServiceConfig)) {
                     oAllLinksPromise
@@ -114,9 +119,9 @@ sap.ui.define([
                     return;
                 }
 
-                var oCurrentApplication = AppConfiguration.getCurrentApplication();
-                var sFromCurrentShellHash = oCurrentApplication.sShellHash;
-                var oAppComponent = oCurrentApplication.componentHandle;
+                const oCurrentApplication = AppConfiguration.getCurrentApplication();
+                const sFromCurrentShellHash = oCurrentApplication.sShellHash;
+                let oAppComponent = oCurrentApplication.componentHandle;
 
                 if (oCurrentApplication.componentHandle) {
                     oAppComponent = oCurrentApplication.componentHandle.getInstance();
@@ -134,24 +139,24 @@ sap.ui.define([
                     return;
                 }
 
-                var oNavigationOccurrencesPromise = this._getNavigationOccurrences(sFromCurrentShellHash, oAppComponent);
+                const oNavigationOccurrencesPromise = this._getNavigationOccurrences(sFromCurrentShellHash, oAppComponent);
 
                 jQuery.when(oAllLinksPromise, oNavigationOccurrencesPromise)
-                    .done(function (aLinks, aNavigationOccurrences) {
+                    .done((aLinks, aNavigationOccurrences) => {
                         if (aNavigationOccurrences.length === 0) {
                             oDeferred.resolve(aLinks);
                             return;
                         }
 
-                        var aPreparedLinks = this._prepareLinksForSorting(aLinks, aNavigationOccurrences);
-                        aLinks = aPreparedLinks.sort(function (oLink, oOtherLink) {
+                        const aPreparedLinks = this._prepareLinksForSorting(aLinks, aNavigationOccurrences);
+                        aLinks = aPreparedLinks.sort((oLink, oOtherLink) => {
                             return oOtherLink.clickCount - oLink.clickCount;
                         });
 
                         oDeferred.resolve(aLinks);
-                    }.bind(this))
+                    })
                     .fail(oDeferred.reject);
-            }.bind(this))
+            })
             .catch(oDeferred.reject);
 
         return oDeferred.promise();
@@ -161,13 +166,14 @@ sap.ui.define([
      * Usage of this method in place of {@link sap.ushell.services.CrossApplicationNavigation#toExternal}
      * drives the smartness of the results returned by {@link sap.ushell.services.SmartNavigation#getLinks}.
      *
+     * @param {object} [oArgs] An object containing nominal arguments for the method.
      * @see sap.ushell.services.CrossApplicationNavigation#toExternal
      * @since 1.44.0
      * @public
      * @function
      */
     SmartNavigation.prototype.toExternal = function (oArgs) {
-        var aArguments = arguments;
+        const aArguments = arguments;
 
         Log.error("Call to deprecated service: 'SmartNavigation.toExternal'. Please use 'CrossApplicationNavigation.toExternal' instead",
             null,
@@ -175,15 +181,15 @@ sap.ui.define([
         );
 
         this._oCrossAppNavigationServicePromise
-            .then(function (CrossApplicationNavigationService) {
+            .then((CrossApplicationNavigationService) => {
                 if (!this._isTrackingEnabled(this._oServiceConfig)) {
                     CrossApplicationNavigationService.toExternal.apply(CrossApplicationNavigationService, aArguments);
                     return;
                 }
 
-                var oCurrentApplication = AppConfiguration.getCurrentApplication();
-                var sFromCurrentShellHash = oCurrentApplication.sShellHash;
-                var oAppComponent = oCurrentApplication.componentHandle;
+                const oCurrentApplication = AppConfiguration.getCurrentApplication();
+                const sFromCurrentShellHash = oCurrentApplication.sShellHash;
+                let oAppComponent = oCurrentApplication.componentHandle;
 
                 if (oCurrentApplication.componentHandle) {
                     oAppComponent = oCurrentApplication.componentHandle.getInstance();
@@ -199,7 +205,7 @@ sap.ui.define([
                     return;
                 }
 
-                var sDestinationShellHash = this._getHashFromOArgs(oArgs.target);
+                const sDestinationShellHash = this._getHashFromOArgs(oArgs.target);
                 if (!sDestinationShellHash) {
                     Log.warning("Destination hash does not conform with the ushell guidelines. Navigation will not be tracked.", null, "sap.ushell.services.SmartNavigation");
 
@@ -208,16 +214,17 @@ sap.ui.define([
                 }
 
                 this._recordNavigationOccurrences(sFromCurrentShellHash, sDestinationShellHash, oAppComponent)
-                    .then(function () {
+                    .then(() => {
                         CrossApplicationNavigationService.toExternal.apply(CrossApplicationNavigationService, aArguments);
                     });
-            }.bind(this));
+            });
     };
 
     /**
      * Completely delegates to {@link sap.ushell.services.CrossApplicationNavigation#hrefForExternal},
      * and may be used in place of the other with exactly the same outcome.
      *
+     * @returns {string} A href for the specified parameters as an *external* shell hash.
      * @see sap.ushell.services.CrossApplicationNavigation#hrefForExternal
      * @since 1.46.0
      * @public
@@ -230,7 +237,7 @@ sap.ui.define([
         );
 
         // Container.getService is OK because alternatives are provided for external use. The function is not called by ushell itself.
-        var CrossApplicationNavigationService = Container.getService("CrossApplicationNavigation"); // LEGACY API (deprecated)
+        const CrossApplicationNavigationService = Container.getService("CrossApplicationNavigation"); // LEGACY API (deprecated)
 
         return CrossApplicationNavigationService.hrefForExternal.apply(CrossApplicationNavigationService, arguments);
     };
@@ -245,31 +252,28 @@ sap.ui.define([
      * @since 1.94.0
      * @public
      */
-    SmartNavigation.prototype.hrefForExternalAsync = function () {
-        var aArguments = arguments;
-
+    SmartNavigation.prototype.hrefForExternalAsync = async function () {
         Log.error("Call to deprecated service: 'SmartNavigation.hrefForExternalAsync'. Please use 'CrossApplicationNavigation.hrefForExternalAsync' instead",
             null,
             "sap.ushell.services.SmartNavigation"
         );
 
-        return this._oCrossAppNavigationServicePromise
-            .then(function (CrossApplicationNavigationService) {
-                return CrossApplicationNavigationService.hrefForExternalAsync.apply(CrossApplicationNavigationService, aArguments);
-            });
+        const oCANService = await this._oCrossAppNavigationServicePromise;
+        return oCANService.hrefForExternalAsync.apply(oCANService, arguments);
     };
 
     /**
      * Completely delegates to {@link sap.ushell.services.CrossApplicationNavigation#getPrimaryIntent},
      * and either may be used in place of the other with exactly the same outcome.
      *
+     * @returns {jQuery.Promise} Resolves to an object when a relevant link object exists.
      * @see sap.ushell.services.CrossApplicationNavigation#getPrimaryIntent
      * @since 1.48.0
      * @public
      */
     SmartNavigation.prototype.getPrimaryIntent = function () {
-        var oDeferred = new jQuery.Deferred();
-        var aArguments = arguments;
+        const oDeferred = new jQuery.Deferred();
+        const aArguments = arguments;
 
         Log.error("Call to deprecated service: 'SmartNavigation.getPrimaryIntent'. Please use 'CrossApplicationNavigation.getPrimaryIntent' instead",
             null,
@@ -277,7 +281,7 @@ sap.ui.define([
         );
 
         this._oCrossAppNavigationServicePromise
-            .then(function (CrossApplicationNavigationService) {
+            .then((CrossApplicationNavigationService) => {
                 CrossApplicationNavigationService.getPrimaryIntent.apply(CrossApplicationNavigationService, aArguments)
                     .done(oDeferred.resolve)
                     .fail(oDeferred.reject);
@@ -321,10 +325,9 @@ sap.ui.define([
             return jQuery.when(null);
         }
 
-        var oTarget = oArgs.target;
-        var oCurrentApplication = AppConfiguration.getCurrentApplication();
-        var sFromCurrentShellHash = oCurrentApplication.sShellHash;
-        var sDestinationShellHash;
+        const oTarget = oArgs.target;
+        const oCurrentApplication = AppConfiguration.getCurrentApplication();
+        const sFromCurrentShellHash = oCurrentApplication.sShellHash;
 
         if (!sFromCurrentShellHash) {
             // Possibly the application (the calling component belongs to) has not initialized fully.
@@ -334,7 +337,7 @@ sap.ui.define([
             return jQuery.when(null);
         }
 
-        sDestinationShellHash = this._getHashFromOArgs(oTarget);
+        const sDestinationShellHash = this._getHashFromOArgs(oTarget);
         // Check if a valid destination was provided
         if (!sDestinationShellHash) {
             Log.warning("Navigation not tracked - no valid destination provided", null, "sap.ushell.services.SmartNavigation");
@@ -342,7 +345,7 @@ sap.ui.define([
             return jQuery.when(null);
         }
 
-        Log.debug("Navigation to " + sDestinationShellHash + " was tracked out of " + sFromCurrentShellHash, null, "sap.ushell.services.SmartNavigation");
+        Log.debug(`Navigation to ${sDestinationShellHash} was tracked out of ${sFromCurrentShellHash}`, null, "sap.ushell.services.SmartNavigation");
 
         return this._recordNavigationOccurrences(sFromCurrentShellHash, sDestinationShellHash, oCurrentApplication.componentHandle.getInstance());
     };
@@ -370,15 +373,15 @@ sap.ui.define([
      * @returns {int} Hash code of the input value.
      */
     SmartNavigation.prototype._getHashCode = function (vAny) {
-        var sAny = vAny + "";
+        const sAny = `${vAny}`;
 
         if (this._oHashCodeCache[sAny]) {
             return this._oHashCodeCache[sAny];
         }
 
-        var iHash = 0;
+        let iHash = 0;
 
-        var iLength = sAny.length;
+        let iLength = sAny.length;
         while (iLength--) {
             iHash = (iHash << 5) - iHash + (sAny.charCodeAt(iLength) | 0);
             iHash |= 0;
@@ -397,13 +400,14 @@ sap.ui.define([
      * @private
      */
     SmartNavigation.prototype._getBaseHashPart = function (sIntent) {
-        var oTarget = UrlParsing.parseShellHash(sIntent);
+        const oTarget = UrlParsing.parseShellHash(sIntent);
 
         if (oTarget && oTarget.semanticObject && oTarget.action) {
-            return oTarget.semanticObject + "-" + oTarget.action;
+            return `${oTarget.semanticObject}-${oTarget.action}`;
         }
 
-        throw "Invalid intent `" + sIntent + "`";
+        // eslint-disable-next-line no-throw-literal
+        throw `Invalid intent \`${sIntent}\``;
     };
 
     /**
@@ -423,7 +427,7 @@ sap.ui.define([
         }
 
         if (oArgs.semanticObject && oArgs.action) {
-            return oArgs.semanticObject + "-" + oArgs.action;
+            return `${oArgs.semanticObject}-${oArgs.action}`;
         }
 
         return null;
@@ -450,40 +454,40 @@ sap.ui.define([
      * @private
      */
     SmartNavigation.prototype._getNavigationOccurrences = function (sFromCurrentShellHash, oComponent) {
-        var oDeferred = new jQuery.Deferred();
+        const oDeferred = new jQuery.Deferred();
 
-        var sPersContainerKey = this._getPersContainerKey(sFromCurrentShellHash);
+        const sPersContainerKey = this._getPersContainerKey(sFromCurrentShellHash);
 
         this._oPersonalizationServicePromise
-            .then(function (PersonalizationService) {
-                var oContainerPromise = PersonalizationService.getContainer(sPersContainerKey, {
+            .then((PersonalizationService) => {
+                const oContainerPromise = PersonalizationService.getContainer(sPersContainerKey, {
                     keyCategory: PersonalizationService.constants.keyCategory.FIXED_KEY,
                     writeFrequency: PersonalizationService.constants.writeFrequency.HIGH,
                     clientStorageAllowed: true
                 }, oComponent);
 
                 oContainerPromise
-                    .done(function (oContainer) {
-                        var aItemKeys = oContainer.getItemKeys();
+                    .done((oContainer) => {
+                        const aItemKeys = oContainer.getItemKeys();
 
-                        var aItemsWithClickCount = aItemKeys.map(function (sSemanticObject) {
-                            var oSemanticObjectHistoryEntry = oContainer.getItemValue(sSemanticObject);
-                            var aActions = Object.keys(oSemanticObjectHistoryEntry.actions);
+                        const aItemsWithClickCount = aItemKeys.map((sSemanticObject) => {
+                            const oSemanticObjectHistoryEntry = oContainer.getItemValue(sSemanticObject);
+                            const aActions = Object.keys(oSemanticObjectHistoryEntry.actions);
 
-                            return aActions.map(function (sAction) {
-                                var oAction = oSemanticObjectHistoryEntry.actions[sAction];
-                                var iAggregatedClickCount = oAction.dailyFrequency.reduce(function (aggregate, iPastNthDayUsageCount) {
+                            return aActions.map((sAction) => {
+                                const oAction = oSemanticObjectHistoryEntry.actions[sAction];
+                                const iAggregatedClickCount = oAction.dailyFrequency.reduce((aggregate, iPastNthDayUsageCount) => {
                                     return aggregate + iPastNthDayUsageCount;
                                 }, 0);
 
                                 return {
-                                    intent: sSemanticObject + "-" + sAction,
+                                    intent: `${sSemanticObject}-${sAction}`,
                                     clickCount: iAggregatedClickCount
                                 };
                             });
                         });
 
-                        var aFlattenedList = aItemsWithClickCount.reduce(function (aEveryIntent, aSOSpecificIntentSet) {
+                        const aFlattenedList = aItemsWithClickCount.reduce((aEveryIntent, aSOSpecificIntentSet) => {
                             Array.prototype.push.apply(aEveryIntent, aSOSpecificIntentSet);
                             return aEveryIntent;
                         }, []);
@@ -509,20 +513,20 @@ sap.ui.define([
      * @private
      */
     SmartNavigation.prototype._prepareLinksForSorting = function (aLinks, aNavigationOccurrences) {
-        var mNavigationOccurrences = {};
+        const mNavigationOccurrences = {};
 
-        aNavigationOccurrences.forEach(function (oNavigationOccurrence) {
+        aNavigationOccurrences.forEach((oNavigationOccurrence) => {
             mNavigationOccurrences[oNavigationOccurrence.intent] = oNavigationOccurrence;
         });
 
-        aLinks.forEach(function (oLink) {
-            var sBaseHashPart = this._getBaseHashPart(oLink.intent);
-            var oLinkNavigationOccurrence = mNavigationOccurrences[sBaseHashPart];
+        aLinks.forEach((oLink) => {
+            const sBaseHashPart = this._getBaseHashPart(oLink.intent);
+            const oLinkNavigationOccurrence = mNavigationOccurrences[sBaseHashPart];
 
             oLink.clickCount = oLinkNavigationOccurrence
                 ? oLinkNavigationOccurrence.clickCount
                 : 0;
-        }.bind(this));
+        });
 
         return aLinks;
     };
@@ -538,24 +542,24 @@ sap.ui.define([
      * @private
      */
     SmartNavigation.prototype._recordNavigationOccurrences = function (sFromCurrentShellHash, sToDestinationShellHash, oComponent) {
-        var oTargetDestination = UrlParsing.parseShellHash(sToDestinationShellHash);
-        var sPersContainerKey = this._getPersContainerKey(sFromCurrentShellHash);
-        var sSemanticObject = oTargetDestination.semanticObject;
+        const oTargetDestination = UrlParsing.parseShellHash(sToDestinationShellHash);
+        const sPersContainerKey = this._getPersContainerKey(sFromCurrentShellHash);
+        const sSemanticObject = oTargetDestination.semanticObject;
 
-        var oDeferred = new jQuery.Deferred();
+        const oDeferred = new jQuery.Deferred();
 
         this._oPersonalizationServicePromise
-            .then(function (PersonalizationService) {
-                var oContainerPromise = PersonalizationService.getContainer(sPersContainerKey, {
+            .then((PersonalizationService) => {
+                const oContainerPromise = PersonalizationService.getContainer(sPersContainerKey, {
                     keyCategory: PersonalizationService.constants.keyCategory.FIXED_KEY,
                     writeFrequency: PersonalizationService.constants.writeFrequency.HIGH,
                     clientStorageAllowed: true
                 }, oComponent);
 
                 oContainerPromise
-                    .done(function (oContainer) {
-                        var oSemanticObjectHistoryEntry = oContainer.getItemValue(sSemanticObject);
-                        var sAction = oTargetDestination.action;
+                    .done((oContainer) => {
+                        let oSemanticObjectHistoryEntry = oContainer.getItemValue(sSemanticObject);
+                        const sAction = oTargetDestination.action;
 
                         if (!oSemanticObjectHistoryEntry) {
                             oSemanticObjectHistoryEntry = {
@@ -569,7 +573,7 @@ sap.ui.define([
                             };
                         }
 
-                        var oActionHistoryEntry = oSemanticObjectHistoryEntry.actions[sAction];
+                        let oActionHistoryEntry = oSemanticObjectHistoryEntry.actions[sAction];
 
                         if (!oActionHistoryEntry) {
                             oActionHistoryEntry = {
@@ -590,9 +594,9 @@ sap.ui.define([
                         oContainer.save()
                             .done(oDeferred.resolve)
                             .fail(oDeferred.reject);
-                    }.bind(this))
+                    })
                     .fail(oDeferred.reject);
-            }.bind(this))
+            })
             .catch(oDeferred.reject);
 
         return oDeferred.promise();
@@ -609,9 +613,9 @@ sap.ui.define([
      * @private
      */
     SmartNavigation.prototype._updateHistoryEntryWithCurrentUsage = function (oHistoryEntry) {
-        var iNow = Date.now();
-        var iTimePassedSinceLastVisit = iNow - oHistoryEntry.latestVisit;
-        var iDaysPassedSinceLastVisit = Math.floor(iTimePassedSinceLastVisit / SmartNavigation.ONE_DAY_IN_MILLISECOND);
+        const iNow = Date.now();
+        const iTimePassedSinceLastVisit = iNow - oHistoryEntry.latestVisit;
+        let iDaysPassedSinceLastVisit = Math.floor(iTimePassedSinceLastVisit / SmartNavigation.ONE_DAY_IN_MILLISECOND);
 
         // Account for dormant days between previous and latest usages.
         while (iDaysPassedSinceLastVisit--) {