@sapui5/sap.ushell 1.138.1 → 1.139.0

package/src/main/js/sap/ushell/components/tiles/indicatorcomparison/ComparisonTile.controller.js

@@ -14,41 +14,41 @@ sap.ui.define([
     "sap/m/library",
     "sap/base/Log"
     // "sap/ushell/components/tiles/indicatorTileUtils/cache" // do not migrate
-], function (
+], (
     generic,
     mobileLibrary,
     Log
     // cache // do not migrate
-) {
+) => {
     "use strict";
 
     // shortcut for sap.m.DeviationIndicator
-    var DeviationIndicator = mobileLibrary.DeviationIndicator;
+    const DeviationIndicator = mobileLibrary.DeviationIndicator;
 
     // shortcut for sap.m.ValueColor
-    var ValueColor = mobileLibrary.ValueColor;
+    const ValueColor = mobileLibrary.ValueColor;
 
     // shortcut for sap.m.Size
-    var Size = mobileLibrary.Size;
+    const Size = mobileLibrary.Size;
 
     // shortcut for sap.m.LoadState
-    var LoadState = mobileLibrary.LoadState;
+    const LoadState = mobileLibrary.LoadState;
 
     // shortcut for sap.m.FrameType
-    var FrameType = mobileLibrary.FrameType;
+    const FrameType = mobileLibrary.FrameType;
 
     /* eslint-disable block-scoped-var */ // TODO: remove eslint-disable
 
-    var ComparisonTileController = generic.extend("sap.ushell.components.tiles.indicatorcomparison.ComparisonTile", {
+    const ComparisonTileController = generic.extend("sap.ushell.components.tiles.indicatorcomparison.ComparisonTile", {
         onInit: function () {
             this.KPI_VALUE_REQUIRED = false;
         },
         _processDataForComparisonChart: function (data, measure, unit) {
-            var finalOutput = [], LABEL_MAPPING = {}, i, tempObject, l;
-            var tempVar;
-            var aTitles = [];
-            var that = this;
-            var unitValue = null;
+            const finalOutput = []; const LABEL_MAPPING = {}; let i; let tempObject; let l;
+            let tempVar;
+            let aTitles = [];
+            const that = this;
+            let unitValue = null;
             for (i = 0; i < data.results.length; i++) {
                 var eachData = data.results[i];
             }
@@ -58,16 +58,16 @@ sap.ui.define([
                 LABEL_MAPPING[tempObject.key] = tempObject.value;
             }
 
-            var columnName = that.oConfig.TILE_PROPERTIES.COLUMN_NAMES || that.oConfig.EVALUATION.COLUMN_NAMES;
+            const columnName = that.oConfig.TILE_PROPERTIES.COLUMN_NAMES || that.oConfig.EVALUATION.COLUMN_NAMES;
             for (i = 0; i < columnName.length; i++) {
-                var temp = {};
-                var columnObject = columnName[i];
+                const temp = {};
+                const columnObject = columnName[i];
                 temp.value = Number(eachData[columnObject.COLUMN_NAME]);
-                var calculatedValueForScaling = Number(eachData[columnObject.COLUMN_NAME]);
+                let calculatedValueForScaling = Number(eachData[columnObject.COLUMN_NAME]);
 
-                var isEvaluationThresholdMeasure = false;
-                var tMeasures = that._getEvaluationThresholdMeasures();
-                var mIndex = tMeasures ? Array.prototype.indexOf.call(tMeasures, columnObject.COLUMN_NAME) : -1;
+                let isEvaluationThresholdMeasure = false;
+                const tMeasures = that._getEvaluationThresholdMeasures();
+                const mIndex = tMeasures ? Array.prototype.indexOf.call(tMeasures, columnObject.COLUMN_NAME) : -1;
                 if (mIndex > -1) {
                     /* the measure is a kpi measure or a threshold measure */
                     isEvaluationThresholdMeasure = true;
@@ -76,7 +76,7 @@ sap.ui.define([
                 if (that.oConfig.EVALUATION.SCALING == -2 && isEvaluationThresholdMeasure) {
                     calculatedValueForScaling *= 100;
                 }
-                var c = that.isCurrencyMeasure(columnObject.COLUMN_NAME);
+                const c = that.isCurrencyMeasure(columnObject.COLUMN_NAME);
                 if (unit && unit[i] && eachData[unit[i].name]) {
                     unitValue = eachData[unit[i].name];
                 }
@@ -87,7 +87,7 @@ sap.ui.define([
                 temp.displayValue = tempVar.toString();
                 if (unit) {
                     if (unit[i] && eachData[unit[i].name]) {
-                        temp.displayValue += " " + eachData[unit[i].name];
+                        temp.displayValue += ` ${eachData[unit[i].name]}`;
                     }
                 }
                 temp.color = columnObject.semanticColor;
@@ -102,56 +102,56 @@ sap.ui.define([
         },
         fetchChartData: function (bRefreshClick, isAutoRefresh, fnSuccess, fnError) {
             function checkIfDataPresent (data, columnNames) {
-                var isPresent = false;
+                let isPresent = false;
                 if (data && data.results && data.results.length) {
-                    for (var i = 0, l = columnNames.length; i < l && !isPresent; i++) {
+                    for (let i = 0, l = columnNames.length; i < l && !isPresent; i++) {
                         isPresent = data.results[0][columnNames[i].COLUMN_NAME] !== null;
                     }
                 }
                 return isPresent;
             }
 
-            var that = this;
+            const that = this;
 
             try {
                 /* Preparing arguments for the prepareQueryServiceUri function */
-                var entitySet = this.oConfig.EVALUATION.ODATA_ENTITYSET;
-                var measure = this.oConfig.EVALUATION.COLUMN_NAME;
-                var measures = measure,
-                    j;
+                const entitySet = this.oConfig.EVALUATION.ODATA_ENTITYSET;
+                const measure = this.oConfig.EVALUATION.COLUMN_NAME;
+                let measures = measure;
+                let j;
                 if (this.oConfig.TILE_PROPERTIES.COLUMN_NAMES) {
                     for (j = 0; j < this.oConfig.TILE_PROPERTIES.COLUMN_NAMES.length; j++) {
                         if (this.oConfig.TILE_PROPERTIES.COLUMN_NAMES[j].COLUMN_NAME != this.oConfig.EVALUATION.COLUMN_NAME) {
-                            measures = measures + "," + this.oConfig.TILE_PROPERTIES.COLUMN_NAMES[j].COLUMN_NAME;
+                            measures = `${measures},${this.oConfig.TILE_PROPERTIES.COLUMN_NAMES[j].COLUMN_NAME}`;
                         }
                     }
                 } else {
                     for (j = 0; j < this.oConfig.EVALUATION.COLUMN_NAMES.length; j++) {
                         if (this.oConfig.EVALUATION.COLUMN_NAMES[j].COLUMN_NAME != this.oConfig.EVALUATION.COLUMN_NAME) {
-                            measures = measures + "," + this.oConfig.EVALUATION.COLUMN_NAMES[j].COLUMN_NAME;
+                            measures = `${measures},${this.oConfig.EVALUATION.COLUMN_NAMES[j].COLUMN_NAME}`;
                         }
                     }
                 }
 
-                //var data = this.oConfig.EVALUATION_VALUES;
-                var isRefreshClick = sap.ushell.components.tiles.indicatorTileUtils.util.getBoolValue(bRefreshClick);
-                var cachedValue = sap.ushell.components.tiles.indicatorTileUtils.cache.getKpivalueById(that.oConfig.TILE_PROPERTIES.id);
+                // var data = this.oConfig.EVALUATION_VALUES;
+                const isRefreshClick = sap.ushell.components.tiles.indicatorTileUtils.util.getBoolValue(bRefreshClick);
+                const cachedValue = sap.ushell.components.tiles.indicatorTileUtils.cache.getKpivalueById(that.oConfig.TILE_PROPERTIES.id);
 
                 if (sap.ushell.components.tiles.indicatorTileUtils.util.isDualTile(that.oConfig)) {
                     if (cachedValue) {
                         var tempData = cachedValue.Data && JSON.parse(cachedValue.Data);
                     }
                 }
-                var chipUpdateTime = that.oTileApi.configuration.getParameterValueAsString("timeStamp");
-                var isCacheValid = sap.ushell.components.tiles.indicatorTileUtils.util.isCacheValid(that.oConfig.TILE_PROPERTIES.id, chipUpdateTime, that.chipCacheTime, that.chipCacheTimeUnit, that.tilePressed);
+                const chipUpdateTime = that.oTileApi.configuration.getParameterValueAsString("timeStamp");
+                const isCacheValid = sap.ushell.components.tiles.indicatorTileUtils.util.isCacheValid(that.oConfig.TILE_PROPERTIES.id, chipUpdateTime, that.chipCacheTime, that.chipCacheTimeUnit, that.tilePressed);
                 if ((tempData && !tempData.rightData) || !cachedValue || (!isCacheValid && that.oTileApi.visible.isVisible()) || isRefreshClick || (isAutoRefresh && that.oTileApi.visible.isVisible()) || that.getView().getViewData().refresh) {
                     if (that.kpiValueFetchDeferred) {
                         that.kpiValueFetchDeferred = false;
-                        var variants = sap.ushell.components.tiles.indicatorTileUtils.util.prepareFilterStructure(this.oConfig.EVALUATION_FILTERS, this.oConfig.ADDITIONAL_FILTERS);
-                        var finalQuery = sap.ushell.components.tiles.indicatorTileUtils.util.prepareQueryServiceUri(that.oRunTimeODataModel, entitySet, measures, null, variants, 3);
-                        this.comparisionChartODataRef = finalQuery.model.read(finalQuery.uri, null, null, true, function (data) {
+                        const variants = sap.ushell.components.tiles.indicatorTileUtils.util.prepareFilterStructure(this.oConfig.EVALUATION_FILTERS, this.oConfig.ADDITIONAL_FILTERS);
+                        const finalQuery = sap.ushell.components.tiles.indicatorTileUtils.util.prepareQueryServiceUri(that.oRunTimeODataModel, entitySet, measures, null, variants, 3);
+                        this.comparisionChartODataRef = finalQuery.model.read(finalQuery.uri, null, null, true, (data) => {
                             that.kpiValueFetchDeferred = true;
-                            var writeData = {};
+                            let writeData = {};
                             if (finalQuery.unit) {
                                 writeData.unit = finalQuery.unit;
                             }
@@ -160,7 +160,7 @@ sap.ui.define([
                                 that.oConfig.TILE_PROPERTIES.FINALVALUE = data;
                                 that.oConfig.TILE_PROPERTIES.FINALVALUE = that._processDataForComparisonChart(that.oConfig.TILE_PROPERTIES.FINALVALUE, measures.split(",")[0], finalQuery.unit);
                                 writeData.data = that.oConfig.TILE_PROPERTIES.FINALVALUE;
-                                var cacheData = {};
+                                const cacheData = {};
                                 that.cacheTime = sap.ushell.components.tiles.indicatorTileUtils.util.getUTCDate();
 
                                 cacheData.ChipId = that.oConfig.TILE_PROPERTIES.id;
@@ -169,24 +169,24 @@ sap.ui.define([
                                 cacheData.CacheMaxAgeUnit = that.chipCacheTimeUnit;
                                 cacheData.CacheType = 1;
 
-                                var localCache = that.getLocalCache(cacheData);
+                                const localCache = that.getLocalCache(cacheData);
 
                                 that.updateDatajobScheduled = false;
-                                var key = that.oConfig.TILE_PROPERTIES.id + "data";
-                                var runningJob = sap.ushell.components.tiles.indicatorTileUtils.util.getScheduledJob(key);
+                                const key = `${that.oConfig.TILE_PROPERTIES.id}data`;
+                                let runningJob = sap.ushell.components.tiles.indicatorTileUtils.util.getScheduledJob(key);
                                 if (runningJob) {
                                     clearTimeout(runningJob);
                                     runningJob = undefined;
                                 }
                                 if (!sap.ushell.components.tiles.indicatorTileUtils.util.isDualTile(that.oConfig)) {
                                     sap.ushell.components.tiles.indicatorTileUtils.cache.setKpivalueById(that.oConfig.TILE_PROPERTIES.id, localCache);
-                                    var bUpdate = false;
+                                    let bUpdate = false;
                                     if (cachedValue) {
                                         bUpdate = true;
                                     }
                                     if (that.chipCacheTime) {
                                         sap.ushell.components.tiles.indicatorTileUtils.util.writeFrontendCacheByChipAndUserId(that.oTileApi, that.oConfig.TILE_PROPERTIES.id, cacheData,
-                                            bUpdate, function (data) {
+                                            bUpdate, (data) => {
                                                 if (data) {
                                                     that.cacheTime = data && data.CachedTime;
                                                     sap.ushell.components.tiles.indicatorTileUtils.cache.setKpivalueById(that.oConfig.TILE_PROPERTIES.id, data);
@@ -199,8 +199,8 @@ sap.ui.define([
                                             });
                                     }
                                 } else {
-                                    var tempCacheData = sap.ushell.components.tiles.indicatorTileUtils.cache.getKpivalueById(that.oConfig.TILE_PROPERTIES.id),
-                                        avilableCacheData;
+                                    const tempCacheData = sap.ushell.components.tiles.indicatorTileUtils.cache.getKpivalueById(that.oConfig.TILE_PROPERTIES.id);
+                                    let avilableCacheData;
                                     if (tempCacheData) {
                                         if (!tempCacheData.CachedTime) {
                                             tempCacheData.CachedTime = sap.ushell.components.tiles.indicatorTileUtils.util.getUTCDate();
@@ -236,17 +236,17 @@ sap.ui.define([
                                 sap.ushell.components.tiles.indicatorTileUtils.cache.setKpivalueById(that.oConfig.TILE_PROPERTIES.id, { empty: "empty" });
                                 that.setNoData();
                             }
-                        }, function (eObject) {
+                        }, (eObject) => {
                             that.kpiValueFetchDeferred = true;
                             if (eObject && eObject.response) {
-                                Log.error(eObject.message + " : " + eObject.request.requestUri);
+                                Log.error(`${eObject.message} : ${eObject.request.requestUri}`);
                                 fnError.call(that, eObject);
                             }
                         });
                     }
                 } else if (cachedValue && cachedValue.Data) {
-                    var kpiData;
-                    var tileType = that.oConfig && that.oConfig.TILE_PROPERTIES && that.oConfig.TILE_PROPERTIES.tileType;
+                    let kpiData;
+                    const tileType = that.oConfig && that.oConfig.TILE_PROPERTIES && that.oConfig.TILE_PROPERTIES.tileType;
                     if (tileType.indexOf("DT-") == -1) {
                         kpiData = cachedValue.Data && JSON.parse(cachedValue.Data);
                     } else {
@@ -276,7 +276,7 @@ sap.ui.define([
         },
 
         doProcess: function (bRefreshClick, isAutoRefresh) {
-            var that = this;
+            const that = this;
             this.setTextInTile();
             this.fetchChartData(bRefreshClick, isAutoRefresh, function (kpiValue) {
                 this.CALCULATED_KPI_VALUE = kpiValue;
@@ -286,7 +286,7 @@ sap.ui.define([
                 if (that.oConfig.TILE_PROPERTIES.frameType == FrameType.TwoByOne) {
                     that.oKpiTileView.oGenericTile.setFrameType(FrameType.TwoByOne);
                     that.getView().getViewData().parentController._updateTileModel(this.getTile().getModel().getData());
-                    var columnNames = {};
+                    const columnNames = {};
                     columnNames.data = this.CALCULATED_KPI_VALUE;
                     that.getView().getViewData().deferredObj.resolve();
                 } else {
@@ -304,7 +304,7 @@ sap.ui.define([
         },
 
         doDummyProcess: function () {
-            var that = this;
+            const that = this;
             this.setTextInTile();
             that._updateTileModel({
                 value: 8888,

package/src/main/js/sap/ushell/components/tiles/indicatorcomparison/ComparisonTile.view.js

@@ -16,7 +16,7 @@ sap.ui.define([
     "sap/ui/model/json/JSONModel",
     "sap/m/library"
     // "sap/ushell/components/tiles/sbtilecontent" // do not migrate
-], function (
+], (
     JSView,
     odata4analytics,
     smartBusinessUtil,
@@ -26,7 +26,7 @@ sap.ui.define([
     JSONModel,
     MobileLibrary
     // sbtilecontent // do not migrate
-) {
+) => {
     "use strict";
 
     sap.ui.getCore().loadLibrary("sap.suite.ui.microchart");
@@ -38,8 +38,8 @@ sap.ui.define([
         createContent: function () {
             this.setHeight("100%");
             this.setWidth("100%");
-            var Size = MobileLibrary.Size;
-            var that = this;
+            const Size = MobileLibrary.Size;
+            const that = this;
 
             that.oGenericTileData = {};
 

package/src/main/js/sap/ushell/components/tiles/indicatorcontribution/ContributionTile.controller.js

@@ -14,43 +14,43 @@ sap.ui.define([
     "sap/m/library",
     "sap/base/Log"
     // "sap/ushell/components/tiles/indicatorTileUtils/cache" // do not migrate
-], function (
+], (
     generic,
     mobileLibrary,
     Log
     // cache // do not migrate
-) {
+) => {
     "use strict";
 
     // shortcut for sap.m.DeviationIndicator
-    var DeviationIndicator = mobileLibrary.DeviationIndicator;
+    const DeviationIndicator = mobileLibrary.DeviationIndicator;
 
     // shortcut for sap.m.ValueColor
-    var ValueColor = mobileLibrary.ValueColor;
+    const ValueColor = mobileLibrary.ValueColor;
 
     // shortcut for sap.m.Size
-    var Size = mobileLibrary.Size;
+    const Size = mobileLibrary.Size;
 
     // shortcut for sap.m.LoadState
-    var LoadState = mobileLibrary.LoadState;
+    const LoadState = mobileLibrary.LoadState;
 
     // shortcut for sap.m.FrameType
-    var FrameType = mobileLibrary.FrameType;
+    const FrameType = mobileLibrary.FrameType;
 
     /* eslint-disable block-scoped-var */ // TODO: remove eslint-disable
 
-    var ContributionTileController = generic.extend("sap.ushell.components.tiles.indicatorcontribution.ContributionTile", {
+    const ContributionTileController = generic.extend("sap.ushell.components.tiles.indicatorcontribution.ContributionTile", {
         onInit: function () {
             this.KPI_VALUE_REQUIRED = false;
         },
         _processDataForComparisonChart: function (data, measure, dimension, unitProperty) {
-            var semanticColor = this.oConfig.TILE_PROPERTIES.semanticColorContribution;
-            var finalOutput = [];
-            var tempVar;
-            var unitValue;
-            for (var i = 0; i < data.results.length; i++) {
-                var eachData = data.results[i];
-                var temp = {};
+            const semanticColor = this.oConfig.TILE_PROPERTIES.semanticColorContribution;
+            const finalOutput = [];
+            let tempVar;
+            let unitValue;
+            for (let i = 0; i < data.results.length; i++) {
+                const eachData = data.results[i];
+                const temp = {};
                 try {
                     temp.title = eachData[dimension].toString();
                 } catch (e) {
@@ -58,11 +58,11 @@ sap.ui.define([
                 }
 
                 temp.value = Number(eachData[measure]);
-                var calculatedValueForScaling = Number(eachData[measure]);
+                let calculatedValueForScaling = Number(eachData[measure]);
                 if (this.oConfig.EVALUATION.SCALING == -2) {
                     calculatedValueForScaling *= 100;
                 }
-                var c = this.isCurrencyMeasure(measure);
+                const c = this.isCurrencyMeasure(measure);
                 unitValue = eachData[unitProperty];
                 tempVar = sap.ushell.components.tiles.indicatorTileUtils.util.getLocaleFormattedValue(calculatedValueForScaling, this.oConfig.EVALUATION.SCALING, this.oConfig.EVALUATION.DECIMAL_PRECISION, c, unitValue);
                 temp.displayValue = tempVar.toString();
@@ -81,12 +81,12 @@ sap.ui.define([
             return finalOutput;
         },
         fetchChartData: function (bRefreshClick, isAutoRefresh, fnSuccess, fnError) {
-            var that = this;
+            const that = this;
 
             try {
                 /* Preparing arguments for the prepareQueryServiceUri function */
-                var entitySet = this.oConfig.EVALUATION.ODATA_ENTITYSET,
-                    measure;
+                const entitySet = this.oConfig.EVALUATION.ODATA_ENTITYSET;
+                let measure;
                 that.setThresholdValues();
                 if (this.oConfig.TILE_PROPERTIES.semanticMeasure) {
                     /*
@@ -95,14 +95,14 @@ sap.ui.define([
                      * measure.push(this.oConfig.EVALUATION.COLUMN_NAME);
                      * measure.push(this.oConfig.TILE_PROPERTIES.semanticMeasure);
                      */
-                    measure = this.oConfig.EVALUATION.COLUMN_NAME + "," + this.oConfig.TILE_PROPERTIES.semanticMeasure;
+                    measure = `${this.oConfig.EVALUATION.COLUMN_NAME},${this.oConfig.TILE_PROPERTIES.semanticMeasure}`;
                 } else {
                     measure = this.oConfig.EVALUATION.COLUMN_NAME;
                 }
-                var unitProperty = null;
-                var dimension = this.oConfig.TILE_PROPERTIES.dimension;
-                var isRefreshClick = sap.ushell.components.tiles.indicatorTileUtils.util.getBoolValue(bRefreshClick);
-                var cachedValue = sap.ushell.components.tiles.indicatorTileUtils.cache.getKpivalueById(that.oConfig.TILE_PROPERTIES.id);
+                let unitProperty = null;
+                let dimension = this.oConfig.TILE_PROPERTIES.dimension;
+                const isRefreshClick = sap.ushell.components.tiles.indicatorTileUtils.util.getBoolValue(bRefreshClick);
+                const cachedValue = sap.ushell.components.tiles.indicatorTileUtils.cache.getKpivalueById(that.oConfig.TILE_PROPERTIES.id);
 
                 if (sap.ushell.components.tiles.indicatorTileUtils.util.isDualTile(that.oConfig)) {
                     if (cachedValue) {
@@ -110,28 +110,28 @@ sap.ui.define([
                     }
                 }
 
-                var chipUpdateTime = that.oTileApi.configuration.getParameterValueAsString("timeStamp");
-                var isCacheValid = sap.ushell.components.tiles.indicatorTileUtils.util.isCacheValid(that.oConfig.TILE_PROPERTIES.id, chipUpdateTime, that.chipCacheTime, that.chipCacheTimeUnit, that.tilePressed);
+                const chipUpdateTime = that.oTileApi.configuration.getParameterValueAsString("timeStamp");
+                const isCacheValid = sap.ushell.components.tiles.indicatorTileUtils.util.isCacheValid(that.oConfig.TILE_PROPERTIES.id, chipUpdateTime, that.chipCacheTime, that.chipCacheTimeUnit, that.tilePressed);
                 if ((tempData && !tempData.rightData) || !cachedValue || (!isCacheValid && that.oTileApi.visible.isVisible()) || isRefreshClick || (isAutoRefresh && that.oTileApi.visible.isVisible()) || that.getView().getViewData().refresh) {
                     if (that.kpiValueFetchDeferred) {
                         that.kpiValueFetchDeferred = false;
-                        var variants = sap.ushell.components.tiles.indicatorTileUtils.util.prepareFilterStructure(this.oConfig.EVALUATION_FILTERS, this.oConfig.ADDITIONAL_FILTERS);
-                        var orderByObject = {};
-                        orderByObject["0"] = measure + ",asc";
-                        orderByObject["1"] = measure + ",desc";
-                        orderByObject["2"] = dimension + ",asc";
-                        orderByObject["3"] = dimension + ",desc";
-                        var orderByElement = orderByObject[this.oConfig.TILE_PROPERTIES.sortOrder || "0"].split(",");
-                        var finalQuery = sap.ushell.components.tiles.indicatorTileUtils.util.prepareQueryServiceUri(that.oRunTimeODataModel, entitySet, measure, dimension, variants, 3);
+                        const variants = sap.ushell.components.tiles.indicatorTileUtils.util.prepareFilterStructure(this.oConfig.EVALUATION_FILTERS, this.oConfig.ADDITIONAL_FILTERS);
+                        const orderByObject = {};
+                        orderByObject["0"] = `${measure},asc`;
+                        orderByObject["1"] = `${measure},desc`;
+                        orderByObject["2"] = `${dimension},asc`;
+                        orderByObject["3"] = `${dimension},desc`;
+                        const orderByElement = orderByObject[this.oConfig.TILE_PROPERTIES.sortOrder || "0"].split(",");
+                        const finalQuery = sap.ushell.components.tiles.indicatorTileUtils.util.prepareQueryServiceUri(that.oRunTimeODataModel, entitySet, measure, dimension, variants, 3);
                         if (this.oConfig.TILE_PROPERTIES.semanticMeasure) {
-                            finalQuery.uri += "&$top=3&$orderby=" + orderByElement[0] + " " + orderByElement[2];
+                            finalQuery.uri += `&$top=3&$orderby=${orderByElement[0]} ${orderByElement[2]}`;
                         } else {
-                            finalQuery.uri += "&$top=3&$orderby=" + orderByElement[0] + " " + orderByElement[1];
+                            finalQuery.uri += `&$top=3&$orderby=${orderByElement[0]} ${orderByElement[1]}`;
                         }
 
-                        this.comparisionChartODataRef = finalQuery.model.read(finalQuery.uri, null, null, true, function (data) {
+                        this.comparisionChartODataRef = finalQuery.model.read(finalQuery.uri, null, null, true, (data) => {
                             that.kpiValueFetchDeferred = true;
-                            var writeData = {};
+                            let writeData = {};
                             if (data && data.results && data.results.length) {
                                 if (finalQuery.unit[0]) {
                                     that._updateTileModel({
@@ -147,7 +147,7 @@ sap.ui.define([
                                 that.oConfig.TILE_PROPERTIES.FINALVALUE = that._processDataForComparisonChart(that.oConfig.TILE_PROPERTIES.FINALVALUE, measure.split(",")[0], dimension, unitProperty);
                                 writeData.data = that.oConfig.TILE_PROPERTIES.FINALVALUE;
                                 writeData.isCurM = that.isACurrencyMeasure(that.oConfig.EVALUATION.COLUMN_NAME);
-                                var cacheData = {};
+                                const cacheData = {};
                                 that.cacheTime = sap.ushell.components.tiles.indicatorTileUtils.util.getUTCDate();
 
                                 cacheData.ChipId = that.oConfig.TILE_PROPERTIES.id;
@@ -156,24 +156,24 @@ sap.ui.define([
                                 cacheData.CacheMaxAgeUnit = that.chipCacheTimeUnit;
                                 cacheData.CacheType = 1;
 
-                                var localCache = that.getLocalCache(cacheData);
+                                const localCache = that.getLocalCache(cacheData);
 
                                 that.updateDatajobScheduled = false;
-                                var key = that.oConfig.TILE_PROPERTIES.id + "data";
-                                var runningJob = sap.ushell.components.tiles.indicatorTileUtils.util.getScheduledJob(key);
+                                const key = `${that.oConfig.TILE_PROPERTIES.id}data`;
+                                let runningJob = sap.ushell.components.tiles.indicatorTileUtils.util.getScheduledJob(key);
                                 if (runningJob) {
                                     clearTimeout(runningJob);
                                     runningJob = undefined;
                                 }
                                 if (!sap.ushell.components.tiles.indicatorTileUtils.util.isDualTile(that.oConfig)) {
                                     sap.ushell.components.tiles.indicatorTileUtils.cache.setKpivalueById(that.oConfig.TILE_PROPERTIES.id, localCache);
-                                    var bUpdate = false;
+                                    let bUpdate = false;
                                     if (cachedValue) {
                                         bUpdate = true;
                                     }
                                     if (that.chipCacheTime) {
                                         sap.ushell.components.tiles.indicatorTileUtils.util.writeFrontendCacheByChipAndUserId(that.oTileApi, that.oConfig.TILE_PROPERTIES.id, cacheData,
-                                            bUpdate, function (data) {
+                                            bUpdate, (data) => {
                                                 if (data) {
                                                     that.cacheTime = data && data.CachedTime;
                                                     sap.ushell.components.tiles.indicatorTileUtils.cache.setKpivalueById(that.oConfig.TILE_PROPERTIES.id, data);
@@ -185,8 +185,8 @@ sap.ui.define([
                                             });
                                     }
                                 } else {
-                                    var tempCacheData = sap.ushell.components.tiles.indicatorTileUtils.cache.getKpivalueById(that.oConfig.TILE_PROPERTIES.id),
-                                        avilableCacheData;
+                                    const tempCacheData = sap.ushell.components.tiles.indicatorTileUtils.cache.getKpivalueById(that.oConfig.TILE_PROPERTIES.id);
+                                    let avilableCacheData;
                                     if (tempCacheData) {
                                         if (!tempCacheData.CachedTime) {
                                             tempCacheData.CachedTime = sap.ushell.components.tiles.indicatorTileUtils.util.getUTCDate();
@@ -226,17 +226,17 @@ sap.ui.define([
                                 sap.ushell.components.tiles.indicatorTileUtils.cache.setKpivalueById(that.oConfig.TILE_PROPERTIES.id, { empty: "empty" });
                                 that.setNoData();
                             }
-                        }, function (eObject) {
+                        }, (eObject) => {
                             that.kpiValueFetchDeferred = true;
                             if (eObject && eObject.response) {
-                                Log.error(eObject.message + " : " + eObject.request.requestUri);
+                                Log.error(`${eObject.message} : ${eObject.request.requestUri}`);
                                 fnError.call(that, eObject);
                             }
                         });
                     }
                 } else if (cachedValue && cachedValue.Data) {
-                    var kpiData;
-                    var tileType = that.oConfig && that.oConfig.TILE_PROPERTIES && that.oConfig.TILE_PROPERTIES.tileType;
+                    let kpiData;
+                    const tileType = that.oConfig && that.oConfig.TILE_PROPERTIES && that.oConfig.TILE_PROPERTIES.tileType;
                     if (tileType.indexOf("DT-") == -1) {
                         kpiData = cachedValue.Data && JSON.parse(cachedValue.Data);
                     } else {
@@ -274,7 +274,7 @@ sap.ui.define([
             }
         },
         doProcess: function (bRefreshClick, isAutoRefresh) {
-            var that = this;
+            const that = this;
             this.DEFINITION_DATA = this.oConfig;
             this._updateTileModel(this.DEFINITION_DATA);
             this.setTextInTile();
@@ -304,7 +304,7 @@ sap.ui.define([
         },
 
         doDummyProcess: function () {
-            var that = this;
+            const that = this;
             that.setTextInTile();
             that._updateTileModel({
                 value: 8888,

package/src/main/js/sap/ushell/components/tiles/indicatorcontribution/ContributionTile.view.js

@@ -19,7 +19,7 @@ sap.ui.define([
     "sap/ui/model/json/JSONModel",
     "sap/m/library"
     // "sap/ushell/components/tiles/sbtilecontent" // do not migrate
-], function (
+], (
     JSView,
     odata4analytics,
     smartBusinessUtil,
@@ -29,7 +29,7 @@ sap.ui.define([
     JSONModel,
     MobileLibrary
     // sbtilecontent // do not migrate
-) {
+) => {
     "use strict";
 
     sap.ui.getCore().loadLibrary("sap.suite.ui.microchart");
@@ -42,8 +42,8 @@ sap.ui.define([
         createContent: function () {
             this.setHeight("100%");
             this.setWidth("100%");
-            var Size = MobileLibrary.Size;
-            var that = this;
+            const Size = MobileLibrary.Size;
+            const that = this;
 
             that.oGenericTileData = {
                 // subheader : "Lorem Ipsum SubHeader",
@@ -79,7 +79,7 @@ sap.ui.define([
                     path: "/data"
                 }
             });
-            //oComparisonTile
+            // oComparisonTile
             that.oNVConfS = new sap.ushell.components.tiles.sbtilecontent({
                 unit: "{/unit}",
                 size: "{/size}",