@sapui5/sap.ushell 1.138.1 → 1.139.0

package/src/main/js/sap/ushell/components/_HomepageManager/PersistentPageOperationAdapter.js

@@ -17,7 +17,7 @@ sap.ui.define([
     "sap/m/library",
     "sap/base/util/deepEqual",
     "sap/ushell/Container"
-], function (
+], (
     BaseObject,
     Config,
     oResources,
@@ -29,39 +29,39 @@ sap.ui.define([
     mobileLibrary,
     deepEqual,
     Container
-) {
+) => {
     "use strict";
 
     // shortcut for sap.m.GenericTileMode
-    var GenericTileMode = mobileLibrary.GenericTileMode;
+    const GenericTileMode = mobileLibrary.GenericTileMode;
 
     // shortcut for sap.m.LoadState
-    var LoadState = mobileLibrary.LoadState;
+    const LoadState = mobileLibrary.LoadState;
 
-    var PersistentPageOperationAdapter = BaseObject.extend("sap.ushell.components._HomepageManager.PersistentPageOperationAdapter", {
+    const PersistentPageOperationAdapter = BaseObject.extend("sap.ushell.components._HomepageManager.PersistentPageOperationAdapter", {
         constructor: function (oLaunchPageService) {
             BaseObject.call(this);
             this.oPageBuilderService = oLaunchPageService;
         },
 
         _getIsAppBox: function (oCatalogTile) {
-            var srvc = this.oPageBuilderService,
-                bIsAppBox = !!(srvc.getCatalogTileTargetURL(oCatalogTile)
+            const srvc = this.oPageBuilderService;
+            const bIsAppBox = !!(srvc.getCatalogTileTargetURL(oCatalogTile)
                     && (srvc.getCatalogTilePreviewTitle(oCatalogTile) || srvc.getCatalogTilePreviewSubtitle(oCatalogTile)));
             return bIsAppBox;
         },
 
         getCurrentHiddenGroupIds: function (oModel) {
-            var aGroups = oModel.getProperty("/groups"),
-                aHiddenGroupsIDs = [],
-                sGroupId,
-                groupIndex,
-                bGroupVisible;
+            const aGroups = oModel.getProperty("/groups");
+            const aHiddenGroupsIDs = [];
+            let sGroupId;
+            let groupIndex;
+            let bGroupVisible;
 
             for (groupIndex = 0; groupIndex < aGroups.length; groupIndex++) {
-                //check if have property isGroupVisible on aGroups if undefined set isGroupVisible true;
+                // check if have property isGroupVisible on aGroups if undefined set isGroupVisible true;
                 bGroupVisible = aGroups[groupIndex] ? aGroups[groupIndex].isGroupVisible : true;
-                //In case of edit mode - it may be that group was only created in RT and still doesn't have an object property
+                // In case of edit mode - it may be that group was only created in RT and still doesn't have an object property
                 if (aGroups[groupIndex].object) {
                     sGroupId = this.oPageBuilderService.getGroupId(aGroups[groupIndex].object);
                 }
@@ -73,12 +73,11 @@ sap.ui.define([
         },
 
         getPreparedTileModel: function (oTile, isGroupLocked, sTileType) {
-            var srvc = this.oPageBuilderService,
-                sTileUUID = fnGetUid(),
-                oTileModelData,
-                sSize = srvc.getTileSize(oTile),
-                aLinks = [],
-                oManifest;
+            const srvc = this.oPageBuilderService;
+            const sTileUUID = fnGetUid();
+            const sSize = srvc.getTileSize(oTile);
+            let aLinks = [];
+            let oManifest;
 
             sTileType = sTileType || srvc.getTileType(oTile);
 
@@ -88,24 +87,24 @@ sap.ui.define([
                 })];
             }
 
-            oTileModelData = {
-                "isCustomTile": !this._getIsAppBox(oTile),
-                "object": oTile,
-                "originalTileId": srvc.getTileId(oTile),
-                "uuid": sTileUUID,
-                "tileCatalogId": encodeURIComponent(srvc.getCatalogTileId(oTile)),
-                "tileCatalogIdStable": srvc.getStableCatalogTileId(oTile) || "",
-                "content": aLinks,
-                "long": sSize === "1x2",
+            const oTileModelData = {
+                isCustomTile: !this._getIsAppBox(oTile),
+                object: oTile,
+                originalTileId: srvc.getTileId(oTile),
+                uuid: sTileUUID,
+                tileCatalogId: encodeURIComponent(srvc.getCatalogTileId(oTile)),
+                tileCatalogIdStable: srvc.getStableCatalogTileId(oTile) || "",
+                content: aLinks,
+                long: sSize === "1x2",
                 // 'target' will be defined (and get a value) later on after the tile will be valid
-                "target": srvc.getTileTarget(oTile) || "",
-                "debugInfo": srvc.getTileDebugInfo(oTile),
-                "isTileIntentSupported": srvc.isTileIntentSupported(oTile),
-                "rgba": "",
-                "isLocked": isGroupLocked,
-                "showActionsIcon": Config.last("/core/home/enableTileActionsIcon"),
-                "isLinkPersonalizationSupported": srvc.isLinkPersonalizationSupported(oTile),
-                "navigationMode": undefined
+                target: srvc.getTileTarget(oTile) || "",
+                debugInfo: srvc.getTileDebugInfo(oTile),
+                isTileIntentSupported: srvc.isTileIntentSupported(oTile),
+                rgba: "",
+                isLocked: isGroupLocked,
+                showActionsIcon: Config.last("/core/home/enableTileActionsIcon"),
+                isLinkPersonalizationSupported: srvc.isLinkPersonalizationSupported(oTile),
+                navigationMode: undefined
             };
 
             if (sTileType === "card") {
@@ -121,27 +120,27 @@ sap.ui.define([
         },
 
         getPreparedGroupModel: function (oGroup, bDefault, bLast, oData) {
-            var srvc = this.oPageBuilderService,
-                aGroupTiles = (oGroup && srvc.getGroupTiles(oGroup)) || [],
-                aModelTiles = [],
-                aModelLinks = [],
-                i,
-                isSortable = Config.last("/core/shell/model/personalization"),
-                bHelpEnabled = Config.last("/core/extension/enableHelp");
+            const srvc = this.oPageBuilderService;
+            const aGroupTiles = (oGroup && srvc.getGroupTiles(oGroup)) || [];
+            const aModelTiles = [];
+            const aModelLinks = [];
+            let i;
+            const isSortable = Config.last("/core/shell/model/personalization");
+            const bHelpEnabled = Config.last("/core/extension/enableHelp");
 
             // in a new group scenario we create the group as null at first.
-            var bIsGroupLocked = !!(oGroup && srvc.isGroupLocked(oGroup)),
-                bIsGroupFeatured = !!(oGroup && srvc.isGroupFeatured(oGroup));
+            const bIsGroupLocked = !!(oGroup && srvc.isGroupLocked(oGroup));
+            const bIsGroupFeatured = !!(oGroup && srvc.isGroupFeatured(oGroup));
 
             for (i = 0; i < aGroupTiles.length; ++i) {
-                var oTile = aGroupTiles[i],
-                    sTileType = srvc.getTileType(oTile).toLowerCase(); //lowercase to make comparison easier
+                const oTile = aGroupTiles[i];
+                const sTileType = srvc.getTileType(oTile).toLowerCase(); // lowercase to make comparison easier
                 if (sTileType === "tile" || sTileType === "card") {
                     aModelTiles.push(this.getPreparedTileModel(aGroupTiles[i], bIsGroupLocked, sTileType));
                 } else if (sTileType === "link") {
                     aModelLinks.push(this.getPreparedTileModel(aGroupTiles[i], bIsGroupLocked, sTileType));
                 } else {
-                    Log.error("Unknown tile type: '" + sTileType + "'",
+                    Log.error(`Unknown tile type: '${sTileType}'`,
                         undefined,
                         "sap.ushell.components.HomepageManager"
                     );
@@ -165,7 +164,7 @@ sap.ui.define([
                 removable: !oGroup || srvc.isGroupRemovable(oGroup),
                 sortable: isSortable,
                 isGroupVisible: !oGroup || srvc.isGroupVisible(oGroup),
-                isEnabled: !bDefault, //Currently only default groups is considered as locked
+                isEnabled: !bDefault, // Currently only default groups is considered as locked
                 isLastGroup: bLast || false,
                 isRendered: !!(oData && oData.isRendered),
                 isGroupSelected: false
@@ -179,9 +178,9 @@ sap.ui.define([
         },
 
         _getGroupsFromServer: function () {
-            var that = this;
-            return new Promise(function (resolve, reject) {
-                that.oPageBuilderService.getGroups().done(function (aGroups) {
+            const that = this;
+            return new Promise((resolve, reject) => {
+                that.oPageBuilderService.getGroups().done((aGroups) => {
                     Measurement.end("FLP:DashboardManager.loadPersonalizedGroups");
                     resolve(aGroups);
                 }).fail(reject);
@@ -195,12 +194,12 @@ sap.ui.define([
          * @returns {object[]} Prepared groups model with tiles and links
          */
         loadGroupsFromArray: function (aGroups) {
-            var that = this;
-            //For Performance debug only, enabled only when URL parameter sap-flp-perf activated
+            const that = this;
+            // For Performance debug only, enabled only when URL parameter sap-flp-perf activated
             Measurement.start("FLP:DashboardManager.loadGroupsFromArray", "loadGroupsFromArray", "FLP");
             Measurement.start("FLP:DashboardManager.getDefaultGroup", "getDefaultGroup", "FLP");
-            return new Promise(function (resolve, reject) {
-                that.oPageBuilderService.getDefaultGroup().done(function (oDefaultGroup) {
+            return new Promise((resolve, reject) => {
+                that.oPageBuilderService.getDefaultGroup().done((oDefaultGroup) => {
                     Measurement.end("FLP:DashboardManager.getDefaultGroup");
                     // In case the user has no groups
                     if (aGroups.length === 0 && oDefaultGroup === undefined) {
@@ -208,22 +207,19 @@ sap.ui.define([
                         return;
                     }
 
-                    var i = 0,
-                        oNewGroupModel,
-                        aNewGroups = [],
-                        groupLength,
-                        iDefaultGroupIndex;
+                    let oNewGroupModel;
+                    const aNewGroups = [];
 
                     aGroups = that._sortGroups(oDefaultGroup, aGroups);
-                    iDefaultGroupIndex = aGroups.findIndex(function (oGroup) {
+                    const iDefaultGroupIndex = aGroups.findIndex((oGroup) => {
                         return deepEqual(oGroup, oDefaultGroup);
                     });
 
-                    groupLength = aGroups.length;
+                    const groupLength = aGroups.length;
 
                     Measurement.start("FLP:DashboardManager._getGroupModel", "_getGroupModel", "FLP");
 
-                    for (i = 0; i < groupLength; ++i) {
+                    for (let i = 0; i < groupLength; ++i) {
                         oNewGroupModel = that.getPreparedGroupModel(aGroups[i], i === iDefaultGroupIndex, i === groupLength - 1);
                         oNewGroupModel.index = i;
                         aNewGroups.push(oNewGroupModel);
@@ -246,15 +242,14 @@ sap.ui.define([
          * @returns {*} sorted group
          */
         _sortGroups: function (oDefaultGroup, aGroups) {
-            var i = 0,
-                that = this,
-                indexOfDefaultGroup = aGroups.findIndex(function (oGroup) {
-                    return deepEqual(oGroup, oDefaultGroup);
-                }),
-                lockedGroups = [],
-                buildSortedGroups,
-                oGroup,
-                isLocked;
+            let i = 0;
+            const that = this;
+            const indexOfDefaultGroup = aGroups.findIndex((oGroup) => {
+                return deepEqual(oGroup, oDefaultGroup);
+            });
+            const lockedGroups = [];
+            let oGroup;
+            let isLocked;
 
             // remove default group from array
             if (indexOfDefaultGroup > -1) {
@@ -275,16 +270,16 @@ sap.ui.define([
 
             // sort only locked groups
             if (!Config.last("/core/home/disableSortedLockedGroups")) {
-                lockedGroups.sort(function (x, y) {
-                    var xTitle = that.oPageBuilderService.getGroupTitle(x).toLowerCase(),
-                        yTitle = that.oPageBuilderService.getGroupTitle(y).toLowerCase();
+                lockedGroups.sort((x, y) => {
+                    const xTitle = that.oPageBuilderService.getGroupTitle(x).toLowerCase();
+                    const yTitle = that.oPageBuilderService.getGroupTitle(y).toLowerCase();
                     return xTitle < yTitle ? -1 : 1;
                 });
             }
             // Featured groups should always be at the top
-            lockedGroups.sort(function (x, y) {
-                var bIsXFeatured = that.oPageBuilderService.isGroupFeatured(x),
-                    bIsYFeatured = that.oPageBuilderService.isGroupFeatured(y);
+            lockedGroups.sort((x, y) => {
+                const bIsXFeatured = that.oPageBuilderService.isGroupFeatured(x);
+                const bIsYFeatured = that.oPageBuilderService.isGroupFeatured(y);
 
                 if (bIsXFeatured === bIsYFeatured) {
                     return 0;
@@ -294,7 +289,7 @@ sap.ui.define([
                 return 1;
             });
             // bring back default group to array
-            buildSortedGroups = lockedGroups;
+            const buildSortedGroups = lockedGroups;
             buildSortedGroups.push(oDefaultGroup);
             buildSortedGroups.push.apply(buildSortedGroups, aGroups);
 
@@ -302,13 +297,13 @@ sap.ui.define([
         },
 
         addGroupAt: function (oGroupModel, iGroupIndex, bIsDefaultGroup) {
-            var that = this;
+            const that = this;
 
-            return new Promise(function (resolve, reject) {
+            return new Promise((resolve, reject) => {
                 try {
                     if (iGroupIndex === undefined) {
                         that.oPageBuilderService.addGroup(oGroupModel.title)
-                            .done(function (oNewServerGroupObject) {
+                            .done((oNewServerGroupObject) => {
                                 resolve(
                                     that.getPreparedGroupModel(
                                         oNewServerGroupObject,
@@ -321,7 +316,7 @@ sap.ui.define([
                             .fail(reject);
                     } else {
                         that.oPageBuilderService.addGroupAt(oGroupModel.title, iGroupIndex)
-                            .done(function (oNewServerGroupObject) {
+                            .done((oNewServerGroupObject) => {
                                 resolve(
                                     that.getPreparedGroupModel(
                                         oNewServerGroupObject,
@@ -340,11 +335,11 @@ sap.ui.define([
         },
 
         renameGroup: function (oGroupModel, sNewTitle, sOldTitle) {
-            var that = this;
-            return new Promise(function (resolve, reject) {
+            const that = this;
+            return new Promise((resolve, reject) => {
                 try {
                     that.oPageBuilderService.setGroupTitle(oGroupModel.object, sNewTitle)
-                        .done(function () {
+                        .done(() => {
                             resolve();
                         })
                         .fail(reject);
@@ -355,13 +350,13 @@ sap.ui.define([
         },
 
         deleteGroup: function (oGroupModel) {
-            var that = this,
-                oServerGroupObject = oGroupModel.object;
+            const that = this;
+            const oServerGroupObject = oGroupModel.object;
 
-            return new Promise(function (resolve, reject) {
+            return new Promise((resolve, reject) => {
                 try {
                     that.oPageBuilderService.removeGroup(oServerGroupObject)
-                        .done(function () {
+                        .done(() => {
                             resolve();
                         })
                         .fail(reject);
@@ -372,11 +367,11 @@ sap.ui.define([
         },
 
         moveGroup: function (oGroupModel, iToIndex, oIndicesInModel) {
-            var that = this;
-            return new Promise(function (resolve, reject) {
+            const that = this;
+            return new Promise((resolve, reject) => {
                 try {
                     that.oPageBuilderService.moveGroup(oGroupModel.object, iToIndex)
-                        .done(function () {
+                        .done(() => {
                             resolve();
                         })
                         .fail(reject);
@@ -387,13 +382,13 @@ sap.ui.define([
         },
 
         resetGroup: function (oGroupModel, bIsDefaultGroup) {
-            var that = this,
-                oServerGroupObject = oGroupModel.object;
+            const that = this;
+            const oServerGroupObject = oGroupModel.object;
 
-            return new Promise(function (resolve, reject) {
+            return new Promise((resolve, reject) => {
                 try {
                     that.oPageBuilderService.resetGroup(oServerGroupObject)
-                        .done(function (oResetedServerObject) {
+                        .done((oResetedServerObject) => {
                             resolve(
                                 that.getPreparedGroupModel(
                                     oResetedServerObject || oServerGroupObject,
@@ -411,18 +406,18 @@ sap.ui.define([
         },
 
         refreshGroup: function (sGroupId) {
-            var that = this,
-                sErrorMsg = "Failed to refresh group with id:" + sGroupId + " in the model";
+            const that = this;
+            const sErrorMsg = `Failed to refresh group with id:${sGroupId} in the model`;
 
-            return new Promise(function (resolve) {
+            return new Promise((resolve) => {
                 that.oPageBuilderService.getGroups()
-                    .fail(function () {
+                    .fail(() => {
                         Log.error(sErrorMsg, null, "sap.ushell.components.HomepageManager");
                         resolve(null);
                     })
-                    .done(function (aGroups) {
-                        var oServerGroupModel = null;
-                        for (var i = 0; i < aGroups.length; i++) {
+                    .done((aGroups) => {
+                        let oServerGroupModel = null;
+                        for (let i = 0; i < aGroups.length; i++) {
                             if (that.oPageBuilderService.getGroupId(aGroups[i]) === sGroupId) {
                                 oServerGroupModel = aGroups[i];
                                 break;
@@ -430,14 +425,14 @@ sap.ui.define([
                         }
 
                         if (oServerGroupModel) {
-                            that.oPageBuilderService.getDefaultGroup().done(function (oDefaultGroup) {
-                                var bIsDefaultGroup = sGroupId === oDefaultGroup.getId(),
-                                    oGroupModel = that.getPreparedGroupModel(
-                                        oServerGroupModel,
-                                        bIsDefaultGroup,
-                                        false,
-                                        { isRendered: true }
-                                    );
+                            that.oPageBuilderService.getDefaultGroup().done((oDefaultGroup) => {
+                                const bIsDefaultGroup = sGroupId === oDefaultGroup.getId();
+                                const oGroupModel = that.getPreparedGroupModel(
+                                    oServerGroupModel,
+                                    bIsDefaultGroup,
+                                    false,
+                                    { isRendered: true }
+                                );
                                 resolve(oGroupModel);
                             });
                         } else {
@@ -448,11 +443,11 @@ sap.ui.define([
         },
 
         getIndexOfGroup: function (aGroups, oServerGroupObject) {
-            var nGroupIndex = -1,
-                that = this,
-                sGroupId = this.oPageBuilderService.getGroupId(oServerGroupObject);
-            aGroups.every(function (oModelGroup, nIndex) {
-                var sCurrentGroupId = that.oPageBuilderService.getGroupId(oModelGroup.object);
+            let nGroupIndex = -1;
+            const that = this;
+            const sGroupId = this.oPageBuilderService.getGroupId(oServerGroupObject);
+            aGroups.every((oModelGroup, nIndex) => {
+                const sCurrentGroupId = that.oPageBuilderService.getGroupId(oModelGroup.object);
                 if (sCurrentGroupId === sGroupId) {
                     nGroupIndex = nIndex;
                     return false;
@@ -463,17 +458,19 @@ sap.ui.define([
         },
 
         /**
-         * returns the adapter cosponsoring group index
+         * returns the adapter cosponsoring group index.
+         * @param {object} oGroupModel the model data representing the given group.
+         * @returns {Promise<int>} the original group index.
          */
         getOriginalGroupIndex: function (oGroupModel) {
-            var srvc = this.oPageBuilderService,
-                oServerGroupObject = oGroupModel.object,
-                oGroupsPromise = this.oPageBuilderService.getGroups();
-
-            return new Promise(function (resolve, reject) {
-                oGroupsPromise.done(function (aGroups) {
-                    var nGroupOrgIndex;
-                    for (var i = 0; i < aGroups.length; i++) {
+            const srvc = this.oPageBuilderService;
+            const oServerGroupObject = oGroupModel.object;
+            const oGroupsPromise = this.oPageBuilderService.getGroups();
+
+            return new Promise((resolve, reject) => {
+                oGroupsPromise.done((aGroups) => {
+                    let nGroupOrgIndex;
+                    for (let i = 0; i < aGroups.length; i++) {
                         if (srvc.getGroupId(aGroups[i]) === srvc.getGroupId(oServerGroupObject)) {
                             nGroupOrgIndex = i;
                             break;
@@ -485,28 +482,28 @@ sap.ui.define([
         },
 
         moveTile: function (oTileModel, oIndexInfo, oSourceGroup, oTargetGroup, sType) {
-            var that = this,
-                oServerTileObject,
-                oPromise = new Promise(function (resolve, reject) {
-                    try {
-                        var oResultPromise = that.oPageBuilderService.moveTile(
-                            oTileModel.object,
-                            oIndexInfo.tileIndex,
-                            oIndexInfo.newTileIndex,
-                            oSourceGroup.object,
-                            oTargetGroup.object,
-                            sType
-                        );
-                        oResultPromise.done(function (oTargetTile) {
-                            oServerTileObject = oTargetTile;
-                            resolve(oTargetTile);
-                        });
-                        oResultPromise.fail(reject);
-                    } catch (err) {
-                        reject();
-                    }
-                });
-            return oPromise.then(this._getTileViewAsPromise.bind(this)).then(function (oView) {
+            const that = this;
+            let oServerTileObject;
+            const oPromise = new Promise((resolve, reject) => {
+                try {
+                    const oResultPromise = that.oPageBuilderService.moveTile(
+                        oTileModel.object,
+                        oIndexInfo.tileIndex,
+                        oIndexInfo.newTileIndex,
+                        oSourceGroup.object,
+                        oTargetGroup.object,
+                        sType
+                    );
+                    oResultPromise.done((oTargetTile) => {
+                        oServerTileObject = oTargetTile;
+                        resolve(oTargetTile);
+                    });
+                    oResultPromise.fail(reject);
+                } catch (err) {
+                    reject();
+                }
+            });
+            return oPromise.then(this._getTileViewAsPromise.bind(this)).then((oView) => {
                 return Promise.resolve({
                     content: oView,
                     originalTileId: that.oPageBuilderService.getTileId(oServerTileObject),
@@ -516,15 +513,13 @@ sap.ui.define([
         },
 
         removeTile: function (oGroupModel, oTileModel) {
-            var that = this,
-                oServerTileObject = oTileModel.object,
-                sTileName = that.oPageBuilderService.getTileTitle(oServerTileObject),
-                oPromise;
-            oPromise = new Promise(function (resolve, reject) {
+            const oServerTileObject = oTileModel.object;
+            const sTileName = this.oPageBuilderService.getTileTitle(oServerTileObject);
+            return new Promise((resolve, reject) => {
                 try {
-                    that.oPageBuilderService.removeTile(oGroupModel.object, oServerTileObject)
+                    this.oPageBuilderService.removeTile(oGroupModel.object, oServerTileObject)
                         .done(
-                            function () {
+                            () => {
                                 oMessagingHelper.showLocalizedMessage("tile_deleted_msg", [sTileName, oGroupModel.title]);
                                 resolve();
                             })
@@ -533,17 +528,14 @@ sap.ui.define([
                     reject();
                 }
             });
-            return oPromise;
         },
 
         _getTileViewAsPromise: function (oTargetTile) {
-            var that = this,
-                oPromise = new Promise(function (resolve, reject) {
-                    var resultPromise = that.oPageBuilderService.getTileView(oTargetTile);
-                    resultPromise.done(resolve);
-                    resultPromise.fail(reject);
-                });
-            return oPromise;
+            return new Promise((resolve, reject) => {
+                const resultPromise = this.oPageBuilderService.getTileView(oTargetTile);
+                resultPromise.done(resolve);
+                resultPromise.fail(reject);
+            });
         },
 
         refreshTile: function (oServerTileObject) {
@@ -587,22 +579,21 @@ sap.ui.define([
          * Returns internal and external tile actions.
          * Tile actions can be provided by external providers registered using
          * @see sap.ushell.services.LaunchPage.registerTileActionsProvider,
-         * @alias sap.ushell.services.LaunchPage#getTileActions
          * and by internal provider that can provide tile actions
          * from the underlying implementation (i.e. adapter)
          *
-         * @param oTile
-         *   the tile
-         * @returns {object[]}
-         *   tile actions
+         * @alias sap.ushell.services.LaunchPage#getTileActions
+         *
+         * @param {object} oTile the tile
+         * @returns {object[]} tile actions
          */
         getTileActions: function (oTile) {
             return this.oPageBuilderService.getTileActions(oTile);
         },
 
         getFailedLinkView: function (oTileModel) {
-            var vSubHeader = this.oPageBuilderService.getCatalogTilePreviewSubtitle(oTileModel.object);
-            var vHeader = this.oPageBuilderService.getCatalogTilePreviewTitle(oTileModel.object);
+            const vSubHeader = this.oPageBuilderService.getCatalogTilePreviewSubtitle(oTileModel.object);
+            let vHeader = this.oPageBuilderService.getCatalogTilePreviewTitle(oTileModel.object);
 
             if (!vHeader && !vSubHeader) {
                 vHeader = oResources.i18n.getText("cannotLoadLinkInformation");
@@ -617,15 +608,15 @@ sap.ui.define([
         },
 
         getTileModelByCatalogTileId: function (sCatalogTileId) {
-            Log.error("Cannot get tile with id " + sCatalogTileId + ": Method is not supported");
+            Log.error(`Cannot get tile with id ${sCatalogTileId}: Method is not supported`);
         },
 
-        transformGroupModel: function (/*aGroups*/) {
+        transformGroupModel: function (/* aGroups */) {
             return;
         }
     });
 
-    var adapterInstance = null;
+    let adapterInstance = null;
     return {
         getInstance: function (oLaunchPageService) {
             if (!adapterInstance) {