@sapui5/sap.ushell 1.138.1 → 1.139.0

package/src/main/js/sap/ushell/components/MessagingHelper.js

@@ -3,16 +3,9 @@
 sap.ui.define([
     "sap/ushell/resources",
     "sap/ushell/Container"
-], function(resources, Container) {
+], (resources, Container) => {
     "use strict";
 
-    return {
-        getLocalizedText: getLocalizedText,
-        showLocalizedError: showLocalizedError,
-        showLocalizedErrorHelper: showLocalizedErrorHelper,
-        showLocalizedMessage: showLocalizedMessage
-    };
-
     /**
      * Return translated text.
      * @param {string} sMsgId
@@ -26,21 +19,6 @@ sap.ui.define([
         return resources.i18n.getText(sMsgId, aParams);
     }
 
-    /**
-     * Shows a localized message in the Message-Toast.
-     * @param {string} sMsgId
-     *      The localization id of the message
-     * @param {object} oParams
-     *      Additional parameters for the Message Toast showing the message. Can be undefined.
-     * @param {sap.ushell.services.Message.Type} [iType=sap.ushell.services.Message.Type.INFO]
-     *      The message type (optional)
-     */
-    function showLocalizedMessage (sMsgId, oParams, iType) {
-        Container.getServiceAsync("MessageInternal").then(function (oMessageService) {
-            oMessageService.show(iType || oMessageService.Type.INFO, getLocalizedText(sMsgId, oParams), oParams);
-        });
-    }
-
     /**
      * Shows a localized error message in the Message-Toast.
      * @param {string} sMsgId
@@ -50,7 +28,7 @@ sap.ui.define([
      *
      */
     function showLocalizedError (sMsgId, oParams) {
-        Container.getServiceAsync("MessageInternal").then(function (oMessageService) {
+        Container.getServiceAsync("MessageInternal").then((oMessageService) => {
             oMessageService.show(oMessageService.Type.ERROR, getLocalizedText(sMsgId, oParams), oParams);
         });
     }
@@ -69,4 +47,26 @@ sap.ui.define([
             showLocalizedError(sMsgId, oParams);
         };
     }
+
+    /**
+     * Shows a localized message in the Message-Toast.
+     * @param {string} sMsgId
+     *      The localization id of the message
+     * @param {object} oParams
+     *      Additional parameters for the Message Toast showing the message. Can be undefined.
+     * @param {sap.ushell.services.Message.Type} [iType=sap.ushell.services.Message.Type.INFO]
+     *      The message type (optional)
+     */
+    function showLocalizedMessage (sMsgId, oParams, iType) {
+        Container.getServiceAsync("MessageInternal").then((oMessageService) => {
+            oMessageService.show(iType || oMessageService.Type.INFO, getLocalizedText(sMsgId, oParams), oParams);
+        });
+    }
+
+    return {
+        getLocalizedText: getLocalizedText,
+        showLocalizedError: showLocalizedError,
+        showLocalizedErrorHelper: showLocalizedErrorHelper,
+        showLocalizedMessage: showLocalizedMessage
+    };
 });

package/src/main/js/sap/ushell/components/SharedComponentUtils.js

@@ -7,17 +7,17 @@ sap.ui.define([
     "sap/base/Log",
     "sap/ui/core/Component",
     "sap/ushell/Container"
-], function (
+], (
     Device,
     Config,
     EventHub,
     Log,
     Component,
     Container
-) {
+) => {
     "use strict";
 
-    var oSharedComponentUtils = {
+    const oSharedComponentUtils = {
         PERS_KEY: "flp.settings.FlpSettings",
         bFlpSettingsAdded: false,
 
@@ -47,8 +47,8 @@ sap.ui.define([
                 sap.ui.require([
                     "sap/ushell/components/ComponentKeysHandler",
                     "sap/ushell/renderer/AccessKeysHandler"
-                ], function (ComponentKeysHandler, AccessKeysHandler) {
-                    ComponentKeysHandler.getInstance().then(function (ComponentKeysHandlerInstance) {
+                ], (ComponentKeysHandler, AccessKeysHandler) => {
+                    ComponentKeysHandler.getInstance().then((ComponentKeysHandlerInstance) => {
                         AccessKeysHandler.registerAppKeysHandler(ComponentKeysHandlerInstance.handleFocusOnMe);
                     });
                 });
@@ -70,9 +70,9 @@ sap.ui.define([
                 return Promise.resolve(Config.last(sConfigPath));
             }
 
-            var sItemID = sConfigPath.split("/").pop();
+            const sItemID = sConfigPath.split("/").pop();
             return this._getPersonalization(sItemID)
-                .then(function (sValue) {
+                .then((sValue) => {
                     if (typeof sValue === "undefined") {
                         // change nothing if the config does not yet exist in the personalization; simply return current config value
                         return Config.last(sConfigPath);
@@ -80,7 +80,7 @@ sap.ui.define([
                     Config.emit(sConfigPath, sValue);
                     return sValue;
                 })
-                .catch(function () {
+                .catch(() => {
                     return Config.last(sConfigPath);
                 });
         },
@@ -94,11 +94,11 @@ sap.ui.define([
          */
         _getPersonalization: function (sItem) {
             return oSharedComponentUtils.getPersonalizer(sItem, Container.getRendererInternal("fiori2"))
-                .then(function (oPersonalizer) {
+                .then((oPersonalizer) => {
                     return oPersonalizer.getPersData();
                 })
-                .catch(function (sError) {
-                    Log.error("Failed to load " + sItem + " from the personalization", sError, "sap.ushell.components.flp.settings.FlpSettings");
+                .catch((sError) => {
+                    Log.error(`Failed to load ${sItem} from the personalization`, sError, "sap.ushell.components.flp.settings.FlpSettings");
                     return Promise.reject(sError);
                 });
         },
@@ -111,20 +111,20 @@ sap.ui.define([
          */
         getPersonalizer: function (sItem, oComponent) {
             return Container.getServiceAsync("PersonalizationV2")
-                .then(function (oPersonalizationService) {
-                    var oOwnerComponent = Component.getOwnerComponentFor(oComponent);
-                    var oScope = {
+                .then((oPersonalizationService) => {
+                    const oOwnerComponent = Component.getOwnerComponentFor(oComponent);
+                    const oScope = {
                         keyCategory: oPersonalizationService.KeyCategory.FIXED_KEY,
                         writeFrequency: oPersonalizationService.WriteFrequency.LOW,
                         clientStorageAllowed: true
                     };
-                    var oPersId = {
+                    const oPersId = {
                         container: this.PERS_KEY,
                         item: sItem
                     };
 
                     return oPersonalizationService.getPersonalizer(oPersId, oScope, oOwnerComponent);
-                }.bind(this));
+                });
         }
     };
 

package/src/main/js/sap/ushell/components/_HomepageManager/DashboardLoadingManager.js

@@ -10,19 +10,19 @@ sap.ui.define([
     "sap/ui/base/Object",
     "sap/ui/core/EventBus",
     "sap/ui/performance/Measurement"
-], function (
+], (
     deepExtend,
     BaseObject,
     EventBus,
     Measurement
-) {
+) => {
     "use strict";
 
-    var DashboardLoadingManager = BaseObject.extend("sap.ushell.components._HomepageManager.DashboardLoadingManager", {
+    const DashboardLoadingManager = BaseObject.extend("sap.ushell.components._HomepageManager.DashboardLoadingManager", {
         metadata: {},
 
         constructor: function (sId, mSettings) {
-            var oEventBus = EventBus.getInstance();
+            const oEventBus = EventBus.getInstance();
 
             this.currentVisibleTiles = [];
             this.aRefreshTiles = [];
@@ -54,30 +54,30 @@ sap.ui.define([
         manageDynamicTiles: function () {
             Measurement.average("DashboardLoadingManagerActiveDynamicTile", "Manage Active Dynamic Tiles", "FLP_SHELL");
 
-            var oTile;
-            var oTileObject;
-            var oNewActiveDynamicTiles = {};
-            var oCloneActiveTiles = deepExtend({}, this.oActiveDynamicTiles);
+            let oTile;
+            let oTileObject;
+            const oNewActiveDynamicTiles = {};
+            const oCloneActiveTiles = deepExtend({}, this.oActiveDynamicTiles);
 
-            //handle old dynamic tiles (that not exist in the visible tile that will be handle next in loop
-            for (var index = 0; index < this.currentVisibleTiles.length; index++) {
-                var oVisTile = this.currentVisibleTiles[index];
+            // handle old dynamic tiles (that not exist in the visible tile that will be handle next in loop
+            for (let index = 0; index < this.currentVisibleTiles.length; index++) {
+                const oVisTile = this.currentVisibleTiles[index];
                 if (!oVisTile.bIsExtanded) {
                     delete oCloneActiveTiles[oVisTile.oTile.uuid];
                 }
             }
 
-            for (var oKey in oCloneActiveTiles) {
+            for (const oKey in oCloneActiveTiles) {
                 oTile = this.oActiveDynamicTiles[oKey];
                 oTileObject = oTile.object;
                 this.oDashboardManager.setTileVisible(oTile, false);
             }
             // handle visible  dynamic tiles
-            for (var iVisibleTileIndex = 0; iVisibleTileIndex < this.currentVisibleTiles.length; iVisibleTileIndex++) {
-                var oVisObj = this.currentVisibleTiles[iVisibleTileIndex];
+            for (let iVisibleTileIndex = 0; iVisibleTileIndex < this.currentVisibleTiles.length; iVisibleTileIndex++) {
+                const oVisObj = this.currentVisibleTiles[iVisibleTileIndex];
                 if (!oVisObj.bIsExtanded) {
                     oTile = oVisObj.oTile;
-                    //refresh only the tiles that are not part of the active dynamic tiles and handled
+                    // refresh only the tiles that are not part of the active dynamic tiles and handled
                     oTileObject = oTile.object;
                     if (this.oActiveDynamicTiles[oTile.uuid] === undefined && oTileObject) {
                         this.oDashboardManager.setTileVisible(oTile, true);
@@ -100,21 +100,21 @@ sap.ui.define([
         manageBusyIndicatorTiles: function () {
             Measurement.average("DashboardLoadingManagerBusyIndicators", "Manage Busy Indicators on Tiles", "FLP_SHELL");
 
-            var iVisibleTileIndex,
-                oCurrentKey,
-                oCurrentTile,
-                oOtherBusyIndicatorTile,
-                aRemoveBusyIndicator = [],
-                bIsInVisibleTile,
-                aAddBusyIndicator = [];
+            let iVisibleTileIndex;
+            let oCurrentKey;
+            let oCurrentTile;
+            let oOtherBusyIndicatorTile;
+            const aRemoveBusyIndicator = [];
+            let bIsInVisibleTile;
+            const aAddBusyIndicator = [];
 
-            //remove busy indicators.
-            //this.oBusyIndicatorTiles - this.currentVisibleTiles
+            // remove busy indicators.
+            // this.oBusyIndicatorTiles - this.currentVisibleTiles
             for (oCurrentKey in this.oBusyIndicatorTiles) {
                 bIsInVisibleTile = true;
                 oOtherBusyIndicatorTile = this.oBusyIndicatorTiles[oCurrentKey];
                 if (this.oResolvedTiles[oCurrentKey] === undefined) {
-                    for (var i = 0; i < this.currentVisibleTiles.length; i++) {
+                    for (let i = 0; i < this.currentVisibleTiles.length; i++) {
                         if (this.currentVisibleTiles[i].oTile.uuid === oOtherBusyIndicatorTile.oTile.uuid) {
                             bIsInVisibleTile = false;
                             break;
@@ -127,8 +127,8 @@ sap.ui.define([
                 }
             }
 
-            //calculate busy indicators.
-            //this.currentVisibleTiles - this.oBusyIndicatorTiles - this.oResolvedTiles
+            // calculate busy indicators.
+            // this.currentVisibleTiles - this.oBusyIndicatorTiles - this.oResolvedTiles
             for (iVisibleTileIndex = 0; iVisibleTileIndex < this.currentVisibleTiles.length; iVisibleTileIndex++) {
                 oCurrentTile = this.currentVisibleTiles[iVisibleTileIndex];
                 if (this.oBusyIndicatorTiles[oCurrentTile.oTile.uuid] === undefined && this.oResolvedTiles[oCurrentTile.oTile.uuid] === undefined) {
@@ -136,10 +136,10 @@ sap.ui.define([
                 }
             }
 
-            //manage remove busy indicator.
+            // manage remove busy indicator.
             for (iVisibleTileIndex = 0; iVisibleTileIndex < aRemoveBusyIndicator.length; iVisibleTileIndex++) {
                 oCurrentTile = aRemoveBusyIndicator[iVisibleTileIndex];
-                //set tile view to none.
+                // set tile view to none.
                 if (oCurrentTile.oTile.content[0] && oCurrentTile.oTile.content[0].setState) {
                     if (oCurrentTile.oTile.content[0].getState) {
                         if (oCurrentTile.oTile.content[0].getState() !== "Failed") {
@@ -149,14 +149,14 @@ sap.ui.define([
                         oCurrentTile.oTile.content[0].setState();
                     }
                 }
-                //update this.oBusyIndicatorTiles.
+                // update this.oBusyIndicatorTiles.
                 delete this.oBusyIndicatorTiles[oCurrentTile.oTile.uuid];
             }
 
-            //manage add busy indicator.
+            // manage add busy indicator.
             for (iVisibleTileIndex = 0; iVisibleTileIndex < aAddBusyIndicator.length; iVisibleTileIndex++) {
                 oCurrentTile = aAddBusyIndicator[iVisibleTileIndex];
-                //set tile view to busy.
+                // set tile view to busy.
                 if (oCurrentTile.oTile.content[0] && oCurrentTile.oTile.content[0].setState) {
                     if (oCurrentTile.oTile.content[0].getState) {
                         if (oCurrentTile.oTile.content[0].getState() !== "Failed") {
@@ -166,7 +166,7 @@ sap.ui.define([
                         oCurrentTile.oTile.content[0].setState("Loading");
                     }
                 }
-                //update this.oBusyIndicatorTiles.
+                // update this.oBusyIndicatorTiles.
                 this.oBusyIndicatorTiles[oCurrentTile.oTile.uuid] = oCurrentTile;
             }
 
@@ -187,11 +187,11 @@ sap.ui.define([
         },
 
         _refreshTiles: function () {
-            for (var iVisibleTileIndex = 0; iVisibleTileIndex < this.currentVisibleTiles.length; iVisibleTileIndex++) {
-                var oTile = this.currentVisibleTiles[iVisibleTileIndex].oTile;
-                var tileObject = oTile.object;
+            for (let iVisibleTileIndex = 0; iVisibleTileIndex < this.currentVisibleTiles.length; iVisibleTileIndex++) {
+                const oTile = this.currentVisibleTiles[iVisibleTileIndex].oTile;
+                const tileObject = oTile.object;
                 if (tileObject) {
-                    for (var iRefreshTilesIndex = 0; iRefreshTilesIndex < this.aRefreshTiles.length; iRefreshTilesIndex++) {
+                    for (let iRefreshTilesIndex = 0; iRefreshTilesIndex < this.aRefreshTiles.length; iRefreshTilesIndex++) {
                         if (oTile.uuid === this.aRefreshTiles[iRefreshTilesIndex]) {
                             this.aRefreshTiles.splice(iRefreshTilesIndex, 1);
                             this.oDashboardManager.setTileVisible(oTile, true);
@@ -204,9 +204,9 @@ sap.ui.define([
         },
 
         _setTilesNoVisibility: function () {
-            for (var iVisibleTileIndex = 0; iVisibleTileIndex < this.currentVisibleTiles.length; iVisibleTileIndex++) {
-                var oTile = this.currentVisibleTiles[iVisibleTileIndex].oTile;
-                var tileObject = oTile.object;
+            for (let iVisibleTileIndex = 0; iVisibleTileIndex < this.currentVisibleTiles.length; iVisibleTileIndex++) {
+                const oTile = this.currentVisibleTiles[iVisibleTileIndex].oTile;
+                const tileObject = oTile.object;
                 if (tileObject) {
                     this.oDashboardManager.setTileVisible(oTile, false);
                 }
@@ -215,9 +215,9 @@ sap.ui.define([
         },
 
         manageTilesView: function () {
-            var iVisibleTileIndex,
-                oCurrentTile,
-                aRequestTileView = [];
+            let iVisibleTileIndex;
+            let oCurrentTile;
+            const aRequestTileView = [];
 
             for (iVisibleTileIndex = 0; iVisibleTileIndex < this.currentVisibleTiles.length; iVisibleTileIndex++) {
                 oCurrentTile = this.currentVisibleTiles[iVisibleTileIndex];

package/src/main/js/sap/ushell/components/_HomepageManager/PagingManager.js

@@ -7,12 +7,12 @@ sap.ui.define([
     "sap/ui/base/Object",
     "sap/ui/Device",
     "sap/ushell/Config"
-], function (BaseObject, Device, Config) {
+], (BaseObject, Device, Config) => {
     "use strict";
 
-    var TILE_MARGIN = 7; // one side, both vertical and horizontal, see themes/base/Tile.less
+    const TILE_MARGIN = 7; // one side, both vertical and horizontal, see themes/base/Tile.less
 
-    var PagingManager = BaseObject.extend("sap.ushell.components._HomepageManager.PagingManager", {
+    const PagingManager = BaseObject.extend("sap.ushell.components._HomepageManager.PagingManager", {
         metadata: {
             publicMethods: [
                 "setElementClass",
@@ -31,9 +31,9 @@ sap.ui.define([
             this.supportedElements = mSettings.supportedElements || "";
             this.tileHeight = 0;
             this.tileSize = {
-                "sapUshellTile": { width: 100, height: 100 },
-                "sapUshellLinkTile": { width: 40, height: 20 },
-                "default": { width: 40, height: 20 }
+                sapUshellTile: { width: 100, height: 100 },
+                sapUshellLinkTile: { width: 40, height: 20 },
+                default: { width: 40, height: 20 }
             };
         },
 
@@ -67,10 +67,10 @@ sap.ui.define([
             return bIsSmallSizeBehavior ? 148 : 176;
         },
 
-        /**
+        /*
          * Returns group height as fraction of the vertical viewport height
          */
-        getGroupHeight: function (oGroup, bFirstGroup, bEnablePersonazilation) {
+        getGroupHeight: function (oGroup, bFirstGroup, bEnablePersonalization) {
             // Implemented:
             // - respect group.isgroupvisible
             // - respect tile.long
@@ -88,34 +88,33 @@ sap.ui.define([
                 return 0;
             }
 
-            var aTiles = oGroup.tiles,
-                aLinks = oGroup.links,
-                bIsSmallSizeBehavior = Device.system.phone || Config.last("/core/home/sizeBehavior") === "Small",
-                iWidthNormalTile = this._getTileWidth(false, bIsSmallSizeBehavior),
-                iWidthLongTile = this._getTileWidth(true, bIsSmallSizeBehavior),
-                groupHeaderHeight = 48, // 3rem
-                groupContainerPadding = 8, // 0.5rem
-                iAvailableWidth = this.containerWidth - groupContainerPadding;
-
-            var iRowLength = 0,
-                iRowNumber = 1,
-                tile,
-                tileWidth,
-                i;
-
-            var someTilesAreVisible = aTiles.some(function (tile) {
+            const aTiles = oGroup.tiles;
+            const aLinks = oGroup.links;
+            const bIsSmallSizeBehavior = Device.system.phone || Config.last("/core/home/sizeBehavior") === "Small";
+            const iWidthNormalTile = this._getTileWidth(false, bIsSmallSizeBehavior);
+            const iWidthLongTile = this._getTileWidth(true, bIsSmallSizeBehavior);
+            const groupHeaderHeight = 48; // 3rem
+            const groupContainerPadding = 8; // 0.5rem
+            const iAvailableWidth = this.containerWidth - groupContainerPadding;
+
+            let iRowLength = 0;
+            let iRowNumber = 1;
+            let tileWidth;
+            let i;
+
+            const someTilesAreVisible = aTiles.some((tile) => {
                 return !!tile && tile.isTileIntentSupported !== false;
             });
             if (!someTilesAreVisible) {
-                if (oGroup.isGroupLocked || oGroup.isDefaultGroup || !bEnablePersonazilation || Device.system.phone) {
-                    //don't show empty lock group or default group
-                    //Additionally for the mobile or when personalisation is disabled, the title is hidden
+                if (oGroup.isGroupLocked || oGroup.isDefaultGroup || !bEnablePersonalization || Device.system.phone) {
+                    // don't show empty lock group or default group
+                    // Additionally for the mobile or when personalisation is disabled, the title is hidden
                     return 0;
                 }
                 return (groupHeaderHeight + groupContainerPadding) / this.containerHeight; // There is only header for groups without tiles.
             }
             // initial minimal height of an empty group
-            var iHeight = groupContainerPadding;
+            let iHeight = groupContainerPadding;
             // the topmost group does not have a header
             if (!bFirstGroup) {
                 iHeight += groupHeaderHeight;
@@ -127,6 +126,7 @@ sap.ui.define([
                 iHeight += 44;
             }
 
+            let tile;
             for (i = 0; i < aTiles.length; i++) {
                 if (iHeight > this.containerHeight) {
                     break; // the group is definitely bigger than the available space, exit
@@ -153,7 +153,7 @@ sap.ui.define([
         },
 
         setContainerSize: function (nHeight, nWidth) {
-            var totalNumberAllocatedTiles = this.getNumberOfAllocatedElements();
+            const totalNumberAllocatedTiles = this.getNumberOfAllocatedElements();
             this.containerHeight = nHeight;
             this.containerWidth = nWidth;
             this._changePageSize(totalNumberAllocatedTiles);
@@ -180,14 +180,14 @@ sap.ui.define([
         },
 
         _calcElementMatrix: function (className) {
-            var oElement = document.createElement("div");
+            const oElement = document.createElement("div");
             oElement.classList.add(className);
             document.body.appendChild(oElement);
-            var elementHeight = oElement.clientHeight;
-            var elementWidth = oElement.clientWidth;
-            var result;
+            const elementHeight = oElement.clientHeight;
+            const elementWidth = oElement.clientWidth;
+            let result;
 
-            //can be that styles was not loaded before calculation
+            // can be that styles was not loaded before calculation
             if (elementHeight < 20 || elementWidth < 40) {
                 result = this.tileSize[className] || this.tileSize.default;
             } else {
@@ -200,7 +200,11 @@ sap.ui.define([
         },
 
         _calcElementsPerPage: function () {
-            var supportedElementKey, baseUnitSize, supportedElement, matrix, mat, elementsPerColumn, elementsPerRow;
+            let supportedElementKey;
+            let baseUnitSize;
+            let supportedElement;
+            let matrix;
+            let mat;
 
             for (supportedElementKey in this.supportedElements) {
                 supportedElement = this.supportedElements[supportedElementKey];
@@ -214,16 +218,16 @@ sap.ui.define([
                 }
             }
 
-            //calculate sizeofSupportedelEmentInUnits
+            // calculate sizeofSupportedelEmentInUnits
             for (supportedElementKey in this.supportedElements) {
                 supportedElement = this.supportedElements[supportedElementKey];
                 mat = supportedElement.matrix;
                 supportedElement.sizeInBaseUnits = Math.round(mat.width / baseUnitSize.width * mat.height / baseUnitSize.height);
             }
 
-            //calc number of units can feet in a page.
-            elementsPerColumn = Math.round(this.containerWidth / baseUnitSize.width);
-            elementsPerRow = Math.round(this.containerHeight / baseUnitSize.height);
+            // calc number of units can feet in a page.
+            const elementsPerColumn = Math.round(this.containerWidth / baseUnitSize.width);
+            const elementsPerRow = Math.round(this.containerHeight / baseUnitSize.height);
 
             if (!elementsPerRow || !elementsPerColumn || elementsPerColumn === Infinity || elementsPerRow === Infinity || elementsPerColumn === 0 || elementsPerRow === 0) {
                 return 10;