@sapui5/sap.ushell 1.138.1 → 1.139.0

package/src/main/js/sap/ushell/components/tiles/indicatorDualDeviation/DualDeviation.controller.js

@@ -11,22 +11,22 @@ sap.ui.define([
     "sap/m/library",
     "sap/ui/thirdparty/jquery"
     // "sap/ushell/components/tiles/indicatorTileUtils/cache" // do not migrate
-], function (
+], (
     JSONModel,
     mobileLibrary,
     jQuery
     // cache // do not migrate
-) {
+) => {
     "use strict";
 
     // shortcut for sap.m.DeviationIndicator
-    var DeviationIndicator = mobileLibrary.DeviationIndicator;
+    const DeviationIndicator = mobileLibrary.DeviationIndicator;
 
     // shortcut for sap.m.ValueColor
-    var ValueColor = mobileLibrary.ValueColor;
+    const ValueColor = mobileLibrary.ValueColor;
 
     // shortcut for sap.m.LoadState
-    var LoadState = mobileLibrary.LoadState;
+    const LoadState = mobileLibrary.LoadState;
 
     /* eslint-disable block-scoped-var */ // TODO: remove eslint-disable
 
@@ -39,11 +39,11 @@ sap.ui.define([
 
         getThresholdsObjAndColor: function (thresholdObject) {
             try {
-                var oThresholdObjAndColor = {};
+                const oThresholdObjAndColor = {};
                 oThresholdObjAndColor.arrObj = [];
                 oThresholdObjAndColor.returnColor = ValueColor.Neutral;
-                var improvementDirection = this.DEFINITION_DATA.EVALUATION.GOAL_TYPE;
-                var wL, cL, cH, wH;
+                const improvementDirection = this.DEFINITION_DATA.EVALUATION.GOAL_TYPE;
+                let wL; let cL; let cH; let wH;
                 if (improvementDirection === "MI") {
                     cH = Number(thresholdObject.criticalHighValue) || 0;
                     wH = Number(thresholdObject.warningHighValue) || 0;
@@ -107,10 +107,10 @@ sap.ui.define([
         },
 
         getTrendIndicator: function (trendValue, value) {
-            var that = this;
+            const that = this;
             trendValue = Number(trendValue);
             try {
-                var trendIndicator = DeviationIndicator.None;
+                let trendIndicator = DeviationIndicator.None;
                 if (trendValue > value) {
                     trendIndicator = DeviationIndicator.Down;
                 } else if (trendValue < value) {
@@ -127,24 +127,24 @@ sap.ui.define([
         },
 
         _updateTileModel: function (newData) {
-            var modelData = this.getTile().getModel().getData();
+            const modelData = this.getTile().getModel().getData();
             jQuery.extend(modelData, newData);
             this.getTile().getModel().setData(modelData);
         },
 
         formSelectStatement: function (object) {
-            var tmpArray = Object.keys(object);
-            var sFormedMeasure = "";
-            for (var i = 0; i < tmpArray.length; i++) {
+            const tmpArray = Object.keys(object);
+            let sFormedMeasure = "";
+            for (let i = 0; i < tmpArray.length; i++) {
                 if ((object[tmpArray[i]] !== undefined) && (object.fullyFormedMeasure)) {
-                    sFormedMeasure += "," + object[tmpArray[i]];
+                    sFormedMeasure += `,${object[tmpArray[i]]}`;
                 }
             } return sFormedMeasure;
         },
 
         setThresholdValues: function () {
-            var that = this;
-            var oThresholdObject = {};
+            const that = this;
+            const oThresholdObject = {};
             oThresholdObject.fullyFormedMeasure = this.DEFINITION_DATA.EVALUATION.COLUMN_NAME;
             if (this.DEFINITION_DATA.EVALUATION.VALUES_SOURCE == "MEASURE") {
                 switch (this.DEFINITION_DATA.EVALUATION.GOAL_TYPE) {
@@ -184,24 +184,24 @@ sap.ui.define([
         },
 
         fetchKpiValue: function (fnSuccess, fnError) {
-            var that = this;
-            var kpiValue = 0;
+            const that = this;
+            let kpiValue = 0;
             try {
-                var sUri = this.DEFINITION_DATA.EVALUATION.ODATA_URL;
-                var sEntitySet = this.DEFINITION_DATA.EVALUATION.ODATA_ENTITYSET;
-                var sThresholdObject = this.setThresholdValues();
-                var sMeasure = sThresholdObject.fullyFormedMeasure;
-                var cachedValue = sap.ushell.components.tiles.indicatorTileUtils.cache.getKpivalueById(that.oConfig.TILE_PROPERTIES.id);
+                const sUri = this.DEFINITION_DATA.EVALUATION.ODATA_URL;
+                const sEntitySet = this.DEFINITION_DATA.EVALUATION.ODATA_ENTITYSET;
+                let sThresholdObject = this.setThresholdValues();
+                const sMeasure = sThresholdObject.fullyFormedMeasure;
+                const cachedValue = sap.ushell.components.tiles.indicatorTileUtils.cache.getKpivalueById(that.oConfig.TILE_PROPERTIES.id);
                 if (!cachedValue) {
-                    var variantData = sap.ushell.components.tiles.indicatorTileUtils.util.prepareFilterStructure(
+                    const variantData = sap.ushell.components.tiles.indicatorTileUtils.util.prepareFilterStructure(
                         this.DEFINITION_DATA.EVALUATION_FILTERS, this.DEFINITION_DATA.ADDITIONAL_FILTERS);
-                    var oQuery = sap.ushell.components.tiles.indicatorTileUtils.util.prepareQueryServiceUri(
+                    const oQuery = sap.ushell.components.tiles.indicatorTileUtils.util.prepareQueryServiceUri(
                         that.oTileApi.url.addSystemToServiceUrl(sUri), sEntitySet, sMeasure, null, variantData);
                     if (oQuery) {
                         this.QUERY_SERVICE_MODEL = oQuery.model;
                         this.queryUriForKpiValue = oQuery.uri;
                         try {
-                            this.queryServiceUriODataReadRef = this.QUERY_SERVICE_MODEL.read(oQuery.uri, null, null, true, function (data) {
+                            this.queryServiceUriODataReadRef = this.QUERY_SERVICE_MODEL.read(oQuery.uri, null, null, true, (data) => {
                                 that.writeData = {};
                                 if (data && data.results && data.results.length) {
                                     kpiValue = data.results[0][that.DEFINITION_DATA.EVALUATION.COLUMN_NAME];
@@ -214,8 +214,8 @@ sap.ui.define([
                                     }
                                     that.writeData.numericData = data;
 
-                                    var oScaledValue = "", trendIndicator;
-                                    var calculatedValueForScaling = kpiValue;
+                                    let oScaledValue = ""; let trendIndicator;
+                                    let calculatedValueForScaling = kpiValue;
                                     if (that.oConfig.EVALUATION.SCALING == -2) {
                                         calculatedValueForScaling *= 100;
                                         that.getView().oNumericContent.setFormatterValue(false);
@@ -248,7 +248,7 @@ sap.ui.define([
                                 } else {
                                     fnError.call(that, "no Response from QueryServiceUri");
                                 }
-                            }, function (eObject) {
+                            }, (eObject) => {
                                 if (eObject && eObject.response) {
                                     fnError.call(that, eObject.message);
                                 }
@@ -258,7 +258,7 @@ sap.ui.define([
                         }
                     }
                 } else if (cachedValue.data && cachedValue.data.results && cachedValue.data.results.length) {
-                    var calculatedValueForScaling, oScaledValue, trendIndicator;
+                    let calculatedValueForScaling; let oScaledValue; let trendIndicator;
                     sThresholdObject = that.setThresholdValues();
                     calculatedValueForScaling = cachedValue.data.results[0][that.DEFINITION_DATA.EVALUATION.COLUMN_NAME];
                     if (that.oConfig.EVALUATION.SCALING == -2) {
@@ -302,29 +302,29 @@ sap.ui.define([
         },
 
         flowWithoutDesignTimeCall: function () {
-            var that = this;
-            var formattedValue, formattedTargetvalue;
+            const that = this;
+            let formattedValue; let formattedTargetvalue;
             this.DEFINITION_DATA = this.oConfig;
             this._updateTileModel(this.DEFINITION_DATA);
             if (this.oTileApi.visible.isVisible() && !this.firstTimeVisible) {
                 this.firstTimeVisible = true;
                 this.fetchKpiValue(function (kpiValue, thresholdObject) {
-                    var calculatedValueForScaling = Number(kpiValue);
+                    let calculatedValueForScaling = Number(kpiValue);
                     if (this.oConfig.EVALUATION.SCALING == -2) {
                         calculatedValueForScaling *= 100;
                     }
                     formattedValue = sap.ushell.components.tiles.indicatorTileUtils.util.getLocaleFormattedValue(Number(calculatedValueForScaling),
                         this.oConfig.EVALUATION.SCALING, that.oConfig.EVALUATION.DECIMAL_PRECISION);
                     this.CALCULATED_KPI_VALUE = Number(kpiValue);
-                    var deviationTileObj = {};
-                    var thresholdsArrayObjAndColor = this.getThresholdsObjAndColor(thresholdObject);
-                    var actualKpiObj = { value: Number(kpiValue), color: thresholdsArrayObjAndColor.returnColor };
+                    const deviationTileObj = {};
+                    const thresholdsArrayObjAndColor = this.getThresholdsObjAndColor(thresholdObject);
+                    const actualKpiObj = { value: Number(kpiValue), color: thresholdsArrayObjAndColor.returnColor };
                     deviationTileObj.valueColor = actualKpiObj.color;
                     deviationTileObj.actualValueLabel = formattedValue.toString();
                     deviationTileObj.actual = actualKpiObj;
 
-                    var evalValue = this.DEFINITION_DATA.EVALUATION_VALUES,
-                        calculatedTargetValue;
+                    const evalValue = this.DEFINITION_DATA.EVALUATION_VALUES;
+                    let calculatedTargetValue;
                     if (this.DEFINITION_DATA.EVALUATION.VALUES_SOURCE == "MEASURE") {
                         calculatedTargetValue = Number(thresholdObject.targetValue);
                         if (this.oConfig.EVALUATION.SCALING == -2) {
@@ -335,7 +335,7 @@ sap.ui.define([
                         deviationTileObj.targetValue = Number(thresholdObject.targetValue);
                         deviationTileObj.targetValueLabel = formattedTargetvalue.toString();
                     } else {
-                        for (var itr = 0; itr < evalValue.length; itr++) {
+                        for (let itr = 0; itr < evalValue.length; itr++) {
                             if (evalValue[itr].TYPE === "TA") {
                                 calculatedTargetValue = Number(evalValue[itr].FIXED);
                                 if (this.oConfig.EVALUATION.SCALING == -2) {
@@ -347,11 +347,11 @@ sap.ui.define([
                             }
                         }
                     } this._updateTileModel(deviationTileObj);
-                    var navTarget = sap.ushell.components.tiles.indicatorTileUtils.util.getNavigationTarget(that.oConfig, that.system);
-                    that.oDualDeviationView.oGenericTile.$().wrap("<a href ='" + navTarget + "'></a>");
+                    const navTarget = sap.ushell.components.tiles.indicatorTileUtils.util.getNavigationTarget(that.oConfig, that.system);
+                    that.oDualDeviationView.oGenericTile.$().wrap(`<a href ='${navTarget}'></a>`);
                     this.oDualDeviationView.oGenericTile.setState(LoadState.Loaded);
 
-                    var status = "";
+                    let status = "";
                     if (deviationTileObj.valueColor == "Error") {
                         status = "sb.error";
                     }
@@ -365,7 +365,7 @@ sap.ui.define([
                         status = "sb.good";
                     }
 
-                    var valueObjNumeric = {
+                    const valueObjNumeric = {
                         status: status,
                         actual: calculatedValueForScaling,
                         target: thresholdObject.targetValue,
@@ -374,10 +374,10 @@ sap.ui.define([
                         wL: thresholdObject.warningLowValue,
                         cL: thresholdObject.criticalLowValue
                     };
-                    var valueObjDeviation = valueObjNumeric;
+                    const valueObjDeviation = valueObjNumeric;
 
-                    var oControlNumeric = that.oDualDeviationView.oGenericTile.getTileContent()[0].getContent();
-                    var oControlDeviation = that.oDualDeviationView.oGenericTile.getTileContent()[1].getContent();
+                    const oControlNumeric = that.oDualDeviationView.oGenericTile.getTileContent()[0].getContent();
+                    const oControlDeviation = that.oDualDeviationView.oGenericTile.getTileContent()[1].getContent();
                     sap.ushell.components.tiles.indicatorTileUtils.util.setTooltipInTile(oControlNumeric, "NT", valueObjNumeric);
                     sap.ushell.components.tiles.indicatorTileUtils.util.setTooltipInTile(oControlDeviation, "DT", valueObjDeviation);
                 }, this.logError);
@@ -385,14 +385,14 @@ sap.ui.define([
         },
 
         flowWithDesignTimeCall: function () {
-            var that = this;
+            const that = this;
             try {
-                var evaluationData = sap.ushell.components.tiles.indicatorTileUtils.cache.getEvaluationById(this.oConfig.EVALUATION.ID);
+                const evaluationData = sap.ushell.components.tiles.indicatorTileUtils.cache.getEvaluationById(this.oConfig.EVALUATION.ID);
                 if (evaluationData) {
                     that.oConfig.EVALUATION_FILTERS = evaluationData.EVALUATION_FILTERS;
                     that.flowWithoutDesignTimeCall();
                 } else {
-                    sap.ushell.components.tiles.indicatorTileUtils.util.getFilterFromRunTimeService(this.oConfig, function (filter) {
+                    sap.ushell.components.tiles.indicatorTileUtils.util.getFilterFromRunTimeService(this.oConfig, (filter) => {
                         that.oConfig.EVALUATION_FILTERS = filter;
                         sap.ushell.components.tiles.indicatorTileUtils.cache.setEvaluationById(that.oConfig.TILE_PROPERTIES.id, that.oConfig);
                         that.flowWithoutDesignTimeCall();
@@ -423,8 +423,8 @@ sap.ui.define([
         },
 
         setTextInTile: function () {
-            var that = this;
-            var titleObj = sap.ushell.components.tiles.indicatorTileUtils.util.getTileTitleSubtitle(this.oTileApi);
+            const that = this;
+            const titleObj = sap.ushell.components.tiles.indicatorTileUtils.util.getTileTitleSubtitle(this.oTileApi);
             this._updateTileModel({
                 header: titleObj.title || sap.ushell.components.tiles.indicatorTileUtils.util.getChipTitle(that.oConfig),
                 subheader: titleObj.subTitle || sap.ushell.components.tiles.indicatorTileUtils.util.getChipSubTitle(that.oConfig)
@@ -432,7 +432,7 @@ sap.ui.define([
         },
 
         onInit: function () {
-            var that = this;
+            const that = this;
 
             this.firstTimeVisible = false;
             this.oDualDeviationView = this.getView();
@@ -445,7 +445,7 @@ sap.ui.define([
             this.oDualDeviationView.oGenericTile.setState(LoadState.Loading);
             try {
                 sap.ushell.components.tiles.indicatorTileUtils.util.getParsedChip(
-                    that.oTileApi.configuration.getParameterValueAsString("tileConfiguration"), that.oTileApi.preview.isEnabled(), function (config) {
+                    that.oTileApi.configuration.getParameterValueAsString("tileConfiguration"), that.oTileApi.preview.isEnabled(), (config) => {
                         that.oConfig = config;
                         that.setTextInTile();
                         if (that.oTileApi.preview) {
@@ -470,7 +470,7 @@ sap.ui.define([
                             });
                             that.oDualDeviationView.oGenericTile.setState(LoadState.Loaded);
                         } else {
-                            that.oDualDeviationView.oGenericTile.attachPress(function () {
+                            that.oDualDeviationView.oGenericTile.attachPress(() => {
                                 sap.ushell.components.tiles.indicatorTileUtils.util.abortPendingODataCalls(that.queryServiceUriODataReadRef);
                                 sap.ushell.components.tiles.indicatorTileUtils.cache.setKpivalueById(that.oConfig.TILE_PROPERTIES.id, null);
                                 window.location.hash = sap.ushell.components.tiles.indicatorTileUtils.util.getNavigationTarget(that.oConfig, that.system);

package/src/main/js/sap/ushell/components/tiles/indicatorDualDeviation/DualDeviation.view.js

@@ -18,7 +18,7 @@ sap.ui.define([
     "sap/suite/ui/microchart/BulletMicroChart",
     "sap/m/GenericTile",
     "sap/ui/model/json/JSONModel"
-], function (
+], (
     JSView,
     NumberFormat,
     odata4analytics,
@@ -30,14 +30,14 @@ sap.ui.define([
     BulletMicroChart,
     GenericTile,
     JSONModel
-) {
+) => {
     "use strict";
 
     // shortcut for sap.m.Size
-    var Size = mobileLibrary.Size;
+    const Size = mobileLibrary.Size;
 
     // shortcut for sap.m.LoadState
-    var LoadState = mobileLibrary.LoadState;
+    const LoadState = mobileLibrary.LoadState;
 
     sap.ui.getCore().loadLibrary("sap.suite.ui.microchart");
 
@@ -46,17 +46,17 @@ sap.ui.define([
             return "tiles.indicatorDualDeviation.DualDeviation";
         },
         createContent: function () {
-            var that = this;
+            const that = this;
             this.setHeight("100%");
             this.setWidth("100%");
-            var header = "Lorem ipsum";
-            var subheader = "Lorem ipsum";
-            var titleObj = sap.ushell.components.tiles.indicatorTileUtils.util.getTileTitleSubtitle(this.getViewData().chip);
+            let header = "Lorem ipsum";
+            let subheader = "Lorem ipsum";
+            const titleObj = sap.ushell.components.tiles.indicatorTileUtils.util.getTileTitleSubtitle(this.getViewData().chip);
             if (titleObj.title && titleObj.subTitle) {
                 header = titleObj.title;
                 subheader = titleObj.subTitle;
             }
-            var deviationTileData = {
+            const deviationTileData = {
                 subheader: subheader,
                 header: header,
                 footerNum: "",
@@ -94,7 +94,7 @@ sap.ui.define([
                 content: that.oNumericContent
             });
 
-            var oBCDataTmpl = new BulletMicroChartData({
+            const oBCDataTmpl = new BulletMicroChartData({
                 value: "{value}",
                 color: "{color}"
             });
@@ -118,7 +118,7 @@ sap.ui.define([
                 showTargetValue: "{/showTargetValue}"
             });
 
-            var oNVConfS = new TileContent({
+            const oNVConfS = new TileContent({
                 unit: "{/unit}",
                 size: "{/size}",
                 footer: "{/footerNum}",
@@ -133,7 +133,7 @@ sap.ui.define([
                 tileContent: [that.oNumericTile, oNVConfS]
             });
 
-            var oGenericTileModel = new JSONModel();
+            const oGenericTileModel = new JSONModel();
             oGenericTileModel.setData(deviationTileData);
             that.oGenericTile.setModel(oGenericTileModel);