@openui5/sap.ui.rta 1.117.1 → 1.119.0

package/src/sap/ui/rta/util/changeVisualization/ChangeIndicator.js

@@ -42,7 +42,7 @@ sap.ui.define([
 	 * @alias sap.ui.rta.util.changeVisualization.ChangeIndicator
 	 * @author SAP SE
 	 * @since 1.84.0
-	 * @version 1.117.1
+	 * @version 1.119.0
 	 * @private
 	 */
 	var ChangeIndicator = Control.extend("sap.ui.rta.util.changeVisualization.ChangeIndicator", {
@@ -115,7 +115,7 @@ sap.ui.define([
 		},
 		renderer: {
 			apiVersion: 2,
-			render: function(oRm, oControl) {
+			render(oRm, oControl) {
 				oRm.openStart("div", oControl);
 				oRm.class("sapUiRtaChangeIndicator");
 				oRm.class("sapUiRtaChangeIndicatorChange");
@@ -132,7 +132,7 @@ sap.ui.define([
 				}
 				oRm.openEnd();
 				if (sTooltip) {
-					oRm.openStart("span", oControl.getId() + "-tooltip");
+					oRm.openStart("span", `${oControl.getId()}-tooltip`);
 					oRm.class("sapUiInvisibleText");
 					oRm.openEnd();
 					oRm.text(sTooltip);
@@ -141,12 +141,13 @@ sap.ui.define([
 				oRm.close("div");
 			}
 		},
-		constructor: function() {
+		// eslint-disable-next-line object-shorthand
+		constructor: function(...aArgs) {
 			this._oDetailModel = new JSONModel();
 			this._oDetailModel.setDefaultBindingMode("OneWay");
 			this._fnHoverTrue = this._setHoverStyleClasses.bind(this, true);
 			this._fnHoverFalse = this._setHoverStyleClasses.bind(this, false);
-			Control.prototype.constructor.apply(this, arguments);
+			Control.prototype.constructor.apply(this, aArgs);
 			// is needed to prevent that multiple events listeners are attached
 			// to the same overlay because setVisible is called multiple times
 			this._bEventAttachedToElement = false;
@@ -216,17 +217,17 @@ sap.ui.define([
 		} else {
 			var sShortenedElementLabel = ChangeVisualizationUtils.shortenString(sElementLabel);
 			var sChangeTextKey = (
-				"TXT_CHANGEVISUALIZATION_CHANGE_"
-				+ sCommandName.toUpperCase()
+				`TXT_CHANGEVISUALIZATION_CHANGE_${
+				 sCommandName.toUpperCase()}`
 			);
-			sDescriptionText = oRtaResourceBundle.getText(sChangeTextKey, sShortenedElementLabel);
-			sDescriptionTooltip = oRtaResourceBundle.getText(sChangeTextKey, sElementLabel);
+			sDescriptionText = oRtaResourceBundle.getText(sChangeTextKey, [sShortenedElementLabel]);
+			sDescriptionTooltip = oRtaResourceBundle.getText(sChangeTextKey, [sElementLabel]);
 		}
 		sDescriptionTooltip = sDescriptionText.length < sDescriptionTooltip.length ? sDescriptionTooltip : null;
 		var sDetailButtonText = oDescription && oDescription.buttonText;
 		var sIconTooltip = oRtaResourceBundle.getText(
-			"TXT_CHANGEVISUALIZATION_OVERVIEW_"
-			+ mChangeInformation.changeCategory.toUpperCase()
+			`TXT_CHANGEVISUALIZATION_OVERVIEW_${
+			 mChangeInformation.changeCategory.toUpperCase()}`
 		);
 
 		return {
@@ -271,8 +272,9 @@ sap.ui.define([
 		handleBrowserEventsOnIndicator.call(this, this, "attachBrowserEvent");
 	};
 
-	ChangeIndicator.prototype.setVisible = function(bVisible) {
-		Control.prototype.setVisible.apply(this, arguments);
+	ChangeIndicator.prototype.setVisible = function(...aArgs) {
+		const [bVisible] = aArgs;
+		Control.prototype.setVisible.apply(this, aArgs);
 		var oOverlay = Core.byId(this.getOverlayId());
 		// needed because the change indicator cleanup is only triggered on save and exit
 		if (oOverlay) {
@@ -291,10 +293,10 @@ sap.ui.define([
 		return this;
 	};
 
-	ChangeIndicator.prototype.focus = function() {
+	ChangeIndicator.prototype.focus = function(...aArgs) {
 		if (this.getDomRef()) {
 			// Element is rendered, focus immediately
-			Control.prototype.focus.apply(this, arguments);
+			Control.prototype.focus.apply(this, aArgs);
 			this._bScheduledForFocus = false;
 			return;
 		}
@@ -405,7 +407,7 @@ sap.ui.define([
 			this._iOldTabIndex = this.getDomRef().getAttribute("tabindex");
 			Fragment.load({
 				name: "sap.ui.rta.util.changeVisualization.ChangeIndicatorPopover",
-				id: this.sId + "Info",
+				id: `${this.sId}Info`,
 				controller: this
 			}).then(function(oPopover) {
 				oPopover._bOpenedByChangeIndicator = true;

package/src/sap/ui/rta/util/changeVisualization/ChangeIndicatorRegistry.js

@@ -39,7 +39,7 @@ sap.ui.define([
 	 * @alias sap.ui.rta.util.changeVisualization.ChangeIndicatorRegistry
 	 * @author SAP SE
 	 * @since 1.86.0
-	 * @version 1.117.1
+	 * @version 1.119.0
 	 * @private
 	 */
 	var ChangeIndicatorRegistry = ManagedObject.extend("sap.ui.rta.util.changeVisualization.ChangeIndicatorRegistry", {
@@ -60,8 +60,9 @@ sap.ui.define([
 				}
 			}
 		},
-		constructor: function() {
-			ManagedObject.prototype.constructor.apply(this, arguments);
+		// eslint-disable-next-line object-shorthand
+		constructor: function(...aArgs) {
+			ManagedObject.prototype.constructor.apply(this, aArgs);
 
 			// List of entries with indicator data, grouped by Change ID
 			this._oRegisteredChanges = {};
@@ -194,9 +195,7 @@ sap.ui.define([
 				sChangeCategory = Object.keys(aCategories).find(function(sChangeCategoryName) {
 					return includes(aCategories[sChangeCategoryName], sCommandName);
 				});
-				if (!sChangeCategory) {
-					sChangeCategory = ChangeCategories.OTHER;
-				}
+				sChangeCategory ||= ChangeCategories.OTHER;
 			}
 			var aChangeStates;
 			var aDraftChangesList = [];
@@ -259,9 +258,7 @@ sap.ui.define([
 
 	function getInfoFromChangeHandler(oAppComponent, oChange) {
 		var oSelector = oChange.getOriginalSelector && oChange.getOriginalSelector();
-		if (!oSelector) {
-			oSelector = oChange.getSelector && oChange.getSelector();
-		}
+		oSelector ||= oChange.getSelector && oChange.getSelector();
 		var oControl = JsControlTreeModifier.bySelector(oSelector, oAppComponent);
 		if (oControl) {
 			return ChangesWriteAPI.getChangeHandler({

package/src/sap/ui/rta/util/changeVisualization/ChangeVisualization.js

@@ -82,7 +82,7 @@ sap.ui.define([
 	 * @alias sap.ui.rta.util.changeVisualization.ChangeVisualization
 	 * @author SAP SE
 	 * @since 1.84.0
-	 * @version 1.117.1
+	 * @version 1.119.0
 	 * @private
 	 */
 	var ChangeVisualization = Control.extend("sap.ui.rta.util.changeVisualization.ChangeVisualization", {
@@ -110,12 +110,13 @@ sap.ui.define([
 				}
 			}
 		},
-		constructor: function() {
+		// eslint-disable-next-line object-shorthand
+		constructor: function(...aArgs) {
 			this._oChangeIndicatorRegistry = new ChangeIndicatorRegistry({
 				changeCategories: ChangeCategories.getCategories()
 			});
 
-			Control.prototype.constructor.apply(this, arguments);
+			Control.prototype.constructor.apply(this, aArgs);
 
 			this._oTextBundle = Core.getLibraryResourceBundle("sap.ui.rta");
 			this.setModel(new ResourceModel({
@@ -316,20 +317,18 @@ sap.ui.define([
 	};
 
 	ChangeVisualization.prototype._getChangeCategoryLabel = function(sChangeCategoryName, iChangesCount) {
-		var sLabelKey = "TXT_CHANGEVISUALIZATION_OVERVIEW_" + sChangeCategoryName.toUpperCase();
+		var sLabelKey = `TXT_CHANGEVISUALIZATION_OVERVIEW_${sChangeCategoryName.toUpperCase()}`;
 		return this._oTextBundle.getText(sLabelKey, [iChangesCount]);
 	};
 
 	ChangeVisualization.prototype._getChangeCategoryButton = function(sChangeCategoryName) {
-		var sButtonKey = "BTN_CHANGEVISUALIZATION_OVERVIEW_" + sChangeCategoryName.toUpperCase();
+		var sButtonKey = `BTN_CHANGEVISUALIZATION_OVERVIEW_${sChangeCategoryName.toUpperCase()}`;
 		return this._oTextBundle.getText(sButtonKey);
 	};
 
 	ChangeVisualization.prototype.openChangeCategorySelectionPopover = function(oEvent) {
-		if (!this._oToolbarButton) {
-			// Event bubbled through the toolbar, get original source
-			this._oToolbarButton = Core.byId(oEvent.getParameter("id"));
-		}
+		// Event bubbled through the toolbar, get original source
+		this._oToolbarButton ||= Core.byId(oEvent.getParameter("id"));
 		var oPopover = this.getPopover();
 
 		if (!oPopover) {
@@ -648,7 +647,7 @@ sap.ui.define([
 			selectChange: this.selectChange.bind(this)
 		});
 		oChangeIndicator.setModel(this._oChangeVisualizationModel);
-		oChangeIndicator.bindElement("/content/" + sSelectorId);
+		oChangeIndicator.bindElement(`/content/${sSelectorId}`);
 		oChangeIndicator.setModel(this.getModel("i18n"), "i18n");
 		this._oChangeIndicatorRegistry.registerChangeIndicator(sSelectorId, oChangeIndicator);
 	};

package/src/sap/ui/rta/util/changeVisualization/ChangeVisualizationUtils.js

@@ -28,7 +28,7 @@ sap.ui.define([
 		if (iStringLength > 60) {
 			var sFirstPart = sString.substring(0, 27);
 			var sLastPart = sString.substring(iStringLength - 27);
-			sString = sFirstPart + "(...)" + sLastPart;
+			sString = `${sFirstPart}(...)${sLastPart}`;
 		}
 		return sString;
 	};

package/src/sap/ui/rta/util/changeVisualization/commands/CombineVisualization.js

@@ -77,7 +77,7 @@ sap.ui.define([
 			),
 			descriptionTooltip: aLabels
 			.map(function(sLabel) {
-				return "\"" + sLabel + "\"";
+				return `"${sLabel}"`;
 			})
 			.join(",\n")
 		};

package/src/sap/ui/rta/util/changeVisualization/commands/CreateContainerVisualization.js

@@ -30,8 +30,8 @@ sap.ui.define([
 		var sShortenedElementLabel = ChangeVisualizationUtils.shortenString(sElementLabel);
 		var sTextKey = "TXT_CHANGEVISUALIZATION_CHANGE_CREATECONTAINER";
 		return {
-			descriptionText: oRtaResourceBundle.getText(sTextKey, sShortenedElementLabel),
-			descriptionTooltip: oRtaResourceBundle.getText(sTextKey, sElementLabel)
+			descriptionText: oRtaResourceBundle.getText(sTextKey, [sShortenedElementLabel]),
+			descriptionTooltip: oRtaResourceBundle.getText(sTextKey, [sElementLabel])
 		};
 	};
 

package/src/sap/ui/rta/util/changeVisualization/commands/MoveVisualization.js

@@ -28,8 +28,8 @@ sap.ui.define([
 	 */
 	MoveVisualization.getDescription = function(mPayload, sLabel, mPropertyBag) {
 		var oRtaResourceBundle = sap.ui.getCore().getLibraryResourceBundle("sap.ui.rta");
-		var sDescriptionText = oRtaResourceBundle.getText("TXT_CHANGEVISUALIZATION_CHANGE_MOVE_WITHIN", ChangeVisualizationUtils.shortenString(sLabel));
-		var sDescriptionTooltip = oRtaResourceBundle.getText("TXT_CHANGEVISUALIZATION_CHANGE_MOVE_WITHIN", sLabel);
+		var sDescriptionText = oRtaResourceBundle.getText("TXT_CHANGEVISUALIZATION_CHANGE_MOVE_WITHIN", [ChangeVisualizationUtils.shortenString(sLabel)]);
+		var sDescriptionTooltip = oRtaResourceBundle.getText("TXT_CHANGEVISUALIZATION_CHANGE_MOVE_WITHIN", [sLabel]);
 		var sButtonText;
 		var oAppComponent = mPropertyBag.appComponent;
 
@@ -43,8 +43,8 @@ sap.ui.define([
 		);
 
 		if (sSourceId !== sTargetId) {
-			sDescriptionText = oRtaResourceBundle.getText("TXT_CHANGEVISUALIZATION_CHANGE_MOVE", ChangeVisualizationUtils.shortenString(sLabel));
-			sDescriptionTooltip = (sSourceId && oRtaResourceBundle.getText("TXT_CHANGEVISUALIZATION_CHANGE_MOVE", sLabel)) || "";
+			sDescriptionText = oRtaResourceBundle.getText("TXT_CHANGEVISUALIZATION_CHANGE_MOVE", [ChangeVisualizationUtils.shortenString(sLabel)]);
+			sDescriptionTooltip = (sSourceId && oRtaResourceBundle.getText("TXT_CHANGEVISUALIZATION_CHANGE_MOVE", [sLabel])) || "";
 			sButtonText = sSourceId && oRtaResourceBundle.getText("BTN_CHANGEVISUALIZATION_SHOW_DEPENDENT_CONTAINER_MOVE");
 		}
 		return { descriptionText: sDescriptionText, descriptionTooltip: sDescriptionTooltip, buttonText: sButtonText };

package/src/sap/ui/rta/util/changeVisualization/commands/SplitVisualization.js

@@ -25,8 +25,8 @@ sap.ui.define([
 	 */
 	SplitVisualization.getDescription = function(mPayload, sLabel) {
 		var oRtaResourceBundle = Core.getLibraryResourceBundle("sap.ui.rta");
-		var sDescriptionText = oRtaResourceBundle.getText("TXT_CHANGEVISUALIZATION_CHANGE_SPLIT", ChangeVisualizationUtils.shortenString(sLabel));
-		var sDescriptionTooltip = oRtaResourceBundle.getText("TXT_CHANGEVISUALIZATION_CHANGE_SPLIT", sLabel);
+		var sDescriptionText = oRtaResourceBundle.getText("TXT_CHANGEVISUALIZATION_CHANGE_SPLIT", [ChangeVisualizationUtils.shortenString(sLabel)]);
+		var sDescriptionTooltip = oRtaResourceBundle.getText("TXT_CHANGEVISUALIZATION_CHANGE_SPLIT", [sLabel]);
 		var sButtonText = oRtaResourceBundle.getText("BTN_CHANGEVISUALIZATION_SHOW_DEPENDENT_CONTAINER_SPLIT");
 		return { descriptionText: sDescriptionText, descriptionTooltip: sDescriptionTooltip, buttonText: sButtonText};
 	};

package/src/sap/ui/rta/util/hasStableId.js

@@ -16,7 +16,7 @@ sap.ui.define([
 	"use strict";
 
 	function isCloneFromAggregationBinding(oControl) {
-		var sParentAggregationName = oControl.sParentAggregationName;
+		var {sParentAggregationName} = oControl;
 		var oParent = oControl.getParent();
 
 		if (oParent && sParentAggregationName) {

package/src/sap/ui/rta/util/showMessageBox.js

@@ -25,7 +25,7 @@ sap.ui.define([
 	}
 
 	function isLink(sText) {
-		var oRegex = new RegExp("^" + sLinkRegex + "$");
+		var oRegex = new RegExp(`^${sLinkRegex}$`);
 		return Array.isArray(oRegex.exec(sText));
 	}
 
@@ -90,6 +90,7 @@ sap.ui.define([
 						}
 					});
 
+					// eslint-disable-next-line prefer-spread
 					aSymbols.splice.apply(aSymbols, [i, 1].concat(aInsert));
 					i += aInsert.length;
 				}

package/src/sap/ui/rta/util/validateStableIds.js

@@ -59,7 +59,7 @@ sap.ui.define([
 			var oElementOverlay = aElementOverlays[i];
 			var oElement = oElementOverlay.getElement();
 			var bIsExtensionOverlay = aExtensionList.some(function(mViewExtension) { // eslint-disable-line no-loop-func
-				var ClassDeclaration = ObjectPath.get(mViewExtension.className);
+				var ClassDeclaration = sap.ui.require(mViewExtension.className.replace(/\./g, "/"));
 				var sExtensionName;
 				var sElementName;
 

package/src/sap/ui/rta/util/validateText.js

@@ -15,7 +15,7 @@ sap.ui.define([
 	var sEmptyTextKey = "\xa0";
 	var oValidators = {
 		noEmptyText: {
-			validatorFunction: function(sNewText) {
+			validatorFunction(sNewText) {
 				return sNewText !== sEmptyTextKey;
 			},
 			errorMessage: Core.getLibraryResourceBundle("sap.ui.rta").getText("RENAME_EMPTY_ERROR_TEXT")

package/src/sap/ui/rta/util/StylesLoader.js

@@ -1,31 +0,0 @@
-/*!
- * OpenUI5
- * (c) Copyright 2009-2023 SAP SE or an SAP affiliate company.
- * Licensed under the Apache License, Version 2.0 - see LICENSE.txt.
- */
-
-sap.ui.define([
-	"sap/ui/thirdparty/jquery", "sap/ui/core/Configuration"
-], function(jQuery, Configuration) {
-	"use strict";
-
-	var module = {};
-
-	/**
-	 * Loads styles from the specified file
-	 * @param {string} sFileName - Name of the file
-	 * @return {jqXHR} - returns jqXHR object which can be thenable
-	 */
-	module.loadStyles = function(sFileName) {
-		return jQuery.get(sap.ui.require.toUrl(("sap.ui.rta.assets." + sFileName).replace(/\./g, "/")) + ".css")
-		.then(function(sData) {
-			// TODO: check if it's possible to use UI5 standard mechanism for styles adjustments
-			if (Configuration.getRTL()) {
-				return sData.replace(/right/g, "left");
-			}
-			return sData;
-		});
-	};
-
-	return module;
-}, true);

package/src/sap/ui/rta/util/UrlParser.js

@@ -1,51 +0,0 @@
-/*!
- * OpenUI5
- * (c) Copyright 2009-2023 SAP SE or an SAP affiliate company.
- * Licensed under the Apache License, Version 2.0 - see LICENSE.txt.
- */
-
-sap.ui.define([], function() {
-	"use strict";
-
-	var module = {};
-
-	/**
-	 * Get URL Param by name
-	 * @param {string} sParamName - Parameter name
-	 * @return {string|undefined} - Returns value of the specified param or undefined if not found
-	 */
-	module.getParam = function(sParamName) {
-		return module.getParams()[sParamName];
-	};
-
-	/**
-	 * Get URL parameters object from the url or given url string
-	 * @param {string} [sUrl] - Url parameter string notation starting with ? and following key value pair
-	 * @returns {object} Object with key value pairs of given parameters
-	 */
-	module.getParams = function(sUrl) {
-		sUrl = (sUrl || sUrl === "") ? sUrl : document.location.search;
-		return sUrl
-		.replace(/^\?/, "")
-		.split("&")
-		.reduce(function(mParams, sParam) {
-			var aParts = sParam.split("="); // split on key/value
-			var sValue = aParts[1];
-
-			switch (sValue) {
-				case "true":
-					sValue = true;
-					break;
-				case "false":
-					sValue = false;
-					break;
-				default: break;
-			}
-
-			mParams[aParts[0]] = sValue;
-			return mParams;
-		}, {});
-	};
-
-	return module;
-}, true);