@openui5/sap.ui.rta 1.117.1 → 1.119.0

package/.eslintrc.json

@@ -26,6 +26,7 @@
 		"max-len": ["warn", {
 			"code": 140,
 			"ignorePattern": "@param|@returns|@description|<|QUnit.test",
+			"ignoreTemplateLiterals": true,
 			"ignoreUrls": true
 		}],
 		"space-before-function-paren": ["error", {
@@ -50,6 +51,29 @@
 		"quotes": ["error", "double", {
 			"avoidEscape": true,
 			"allowTemplateLiterals": true
-		}]
+		}],
+		"no-unsafe-optional-chaining": "error",
+		"prefer-const": ["error", { "ignoreReadBeforeAssign": true }],
+		"prefer-template": "error",
+		"rest-spread-spacing": ["error", "never"],
+		"template-curly-spacing": "error",
+		"object-shorthand": ["error", "always", { "ignoreConstructors": false, "avoidQuotes": true }],
+		"prefer-destructuring": ["error", {
+			"VariableDeclarator": {
+				"array": false,
+				"object": true
+			},
+			"AssignmentExpression": {
+				"array": true,
+				"object": false
+			}
+			}, {
+				"enforceForRenamedProperties": false
+			}
+		],
+		"prefer-rest-params": "error",
+		"prefer-spread": "error",
+		"logical-assignment-operators":["error", "always", { "enforceForIfStatements": true } ],
+		"require-await": "error"
 	}
 }

package/THIRDPARTY.txt

@@ -401,7 +401,7 @@ License: MIT
 License Text: https://github.com/SAP/openui5/blob/master/LICENSES/MIT.txt
 Contained in: src/sap.ui.integration/src/sap/ui/integration/thirdparty/adaptive-expressions.js
 
-Component: Markdown-it, version: 12.2.0
+Component: Markdown-it, version: 12.3.2
 Copyright: 2014 Vitaly Puzrin, Alex Kocharin
 License: MIT
 License Text: https://github.com/SAP/openui5/blob/master/LICENSES/MIT.txt
@@ -466,7 +466,7 @@ License: Apache-2.0
 License Text: https://github.com/SAP/openui5/blob/master/LICENSES/Apache-2.0.txt
 Contained in: lib/jsdoc/ui5/plugin.js
 
-Component: SAP Theming Base Content, version: 11.4.2
+Component: SAP Theming Base Content, version: 11.6.8
 Copyright: SAP SE or an SAP affiliate company and Theming Base Content contributors
 License: Apache-2.0
 License Text: https://github.com/SAP/openui5/blob/master/LICENSES/Apache-2.0.txt

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@openui5/sap.ui.rta",
-  "version": "1.117.1",
+  "version": "1.119.0",
   "description": "OpenUI5 UI Library sap.ui.rta",
   "author": "SAP SE (https://www.sap.com)",
   "license": "Apache-2.0",
@@ -14,10 +14,10 @@
     "url": "https://github.com/SAP/openui5.git"
   },
   "dependencies": {
-    "@openui5/sap.m": "1.117.1",
-    "@openui5/sap.ui.core": "1.117.1",
-    "@openui5/sap.ui.dt": "1.117.1",
-    "@openui5/sap.ui.fl": "1.117.1",
-    "@openui5/sap.ui.layout": "1.117.1"
+    "@openui5/sap.m": "1.119.0",
+    "@openui5/sap.ui.core": "1.119.0",
+    "@openui5/sap.ui.dt": "1.119.0",
+    "@openui5/sap.ui.fl": "1.119.0",
+    "@openui5/sap.ui.layout": "1.119.0"
   }
 }

package/src/sap/ui/rta/.library

@@ -6,7 +6,7 @@
   <copyright>OpenUI5
  * (c) Copyright 2009-2023 SAP SE or an SAP affiliate company.
  * Licensed under the Apache License, Version 2.0 - see LICENSE.txt.</copyright>
-  <version>1.117.1</version>
+  <version>1.119.0</version>
 
   <documentation>SAPUI5 library with RTA controls.</documentation>
 

package/src/sap/ui/rta/Client.js

@@ -57,7 +57,7 @@ sap.ui.define([
 	 * @alias sap.ui.rta.Client
 	 * @author SAP SE
 	 * @since 1.56.0
-	 * @version 1.117.1
+	 * @version 1.119.0
 	 * @private
 	 * @ui5-restricted
 	 */
@@ -84,8 +84,9 @@ sap.ui.define([
 		 */
 		_bInit: false,
 
-		constructor: function() {
-			ManagedObject.apply(this, arguments);
+		// eslint-disable-next-line object-shorthand
+		constructor: function(...aArgs) {
+			ManagedObject.apply(this, aArgs);
 
 			if (!this.getWindow()) {
 				throw new TypeError("sap.ui.rta.Client: window parameter is required");
@@ -175,8 +176,11 @@ sap.ui.define([
 					// Rejecting queued requests
 					var aRequests = this._aRequestQueue.slice();
 					this._aRequestQueue = [];
+					// eslint-disable-next-line max-nested-callbacks
 					aRequests.forEach(function(mRequest) {
-						mRequest.reject(new Error("sap.ui.rta.Client.getService(): connection to RuntimeAuthoring instance has been refused"));
+						mRequest.reject(
+							new Error("sap.ui.rta.Client.getService(): connection to RuntimeAuthoring instance has been refused")
+						);
 					});
 				}, this);
 
@@ -199,14 +203,14 @@ sap.ui.define([
 	 * After an object has been destroyed, it can no longer be used.
 	 * @public
 	 */
-	Client.prototype.destroy = function() {
+	Client.prototype.destroy = function(...aArgs) {
 		this._oPostMessageBus.unsubscribe(CHANNEL_ID, "getService", this._receiverMethods, this);
 		this._oPostMessageBus.unsubscribe(CHANNEL_ID, "callMethod", this._receiverMethods, this);
 		this._oPostMessageBus.unsubscribe(CHANNEL_ID, "subscribe", this._receiverMethods, this);
 		this._oPostMessageBus.unsubscribe(CHANNEL_ID, "unsubscribe", this._receiverMethods, this);
 		this._oPostMessageBus.unsubscribe(CHANNEL_ID, "event", this._receiverEvents, this);
 
-		ManagedObject.prototype.destroy.apply(this, arguments);
+		ManagedObject.prototype.destroy.apply(this, aArgs);
 	};
 
 	/**
@@ -300,7 +304,7 @@ sap.ui.define([
 				var mService = merge(
 					// Create placeholders for methods
 					aMethods.reduce(function(mResult, sMethodName) {
-						mResult[sMethodName] = function() {
+						mResult[sMethodName] = function(...aArgs) {
 							return this._sendRequest(this._createRequest({
 								target: oEvent.source,
 								origin: oEvent.origin,
@@ -309,7 +313,7 @@ sap.ui.define([
 								data: {
 									service: sServiceName,
 									method: sMethodName,
-									arguments: Array.prototype.slice.call(arguments)
+									arguments: aArgs
 								}
 							}));
 						}.bind(this);
@@ -320,19 +324,22 @@ sap.ui.define([
 				);
 
 				if (Array.isArray(aEvents) && aEvents.length > 0) {
-					if (!this._oServiceEventBus) {
-						this._oServiceEventBus = new ServiceEventBus();
-					}
+					this._oServiceEventBus ||= new ServiceEventBus();
 					merge(mService, {
 						attachEvent: function(sEventName, fnCallback, oContext) {
 							if (typeof (sEventName) !== "string" || !sEventName) {
-								throw new TypeError("sap.ui.rta.Client: sEventName must be a non-empty string when calling attachEvent() for a service");
+								throw new TypeError(
+									"sap.ui.rta.Client: sEventName must be a non-empty string when calling attachEvent() for a service"
+								);
 							}
 							if (typeof fnCallback !== "function") {
-								throw new TypeError("sap.ui.rta.Client: fnFunction must be a function when calling attachEvent() for a service");
+								throw new TypeError(
+									"sap.ui.rta.Client: fnFunction must be a function when calling attachEvent() for a service"
+								);
 							}
 
-							// 1. Check whether there are other subscribers for same event, if so, then receiver doesn't need second notification
+							// 1. Check whether there are other subscribers for same event, if so,
+							// then receiver doesn't need second notification
 							var oEventProvider = this._oServiceEventBus.getChannel(sServiceName);
 							var bShouldNotifyReceiver = !oEventProvider || !oEventProvider.hasListeners(sEventName);
 
@@ -351,7 +358,7 @@ sap.ui.define([
 										event: sEventName
 									}
 								})).then(function(mResponse) {
-									this._mEventHandlerIds[sServiceName + "," + sEventName] = mResponse.id;
+									this._mEventHandlerIds[`${sServiceName},${sEventName}`] = mResponse.id;
 
 									// Use case when detach happens before we received response from RTA instance
 									this._checkIfEventAlive(sServiceName, sEventName);
@@ -360,10 +367,14 @@ sap.ui.define([
 						}.bind(this),
 						detachEvent: function(sEventName, fnCallback, oContext) {
 							if (typeof (sEventName) !== "string" || !sEventName) {
-								throw new TypeError("sap.ui.rta.Client: sEventName must be a non-empty string when calling detachEvent() for a service");
+								throw new TypeError(
+									"sap.ui.rta.Client: sEventName must be a non-empty string when calling detachEvent() for a service"
+								);
 							}
 							if (typeof fnCallback !== "function") {
-								throw new TypeError("sap.ui.rta.Client: fnFunction must be a function when calling detachEvent() for a service");
+								throw new TypeError(
+									"sap.ui.rta.Client: fnFunction must be a function when calling detachEvent() for a service"
+								);
 							}
 
 							// 1. Unsubscribe from local EventBus
@@ -372,10 +383,10 @@ sap.ui.define([
 							// 2. Check and notify RTA instance if we don't want more events
 							this._checkIfEventAlive(sServiceName, sEventName);
 						}.bind(this),
-						attachEventOnce: function(sEventName, fnCallback, oContext) {
-							function fnOnce() {
+						attachEventOnce(sEventName, fnCallback, oContext) {
+							function fnOnce(...aArgs) {
 								mService.detachEvent(sEventName, fnOnce);
-								fnCallback.apply(oContext, arguments);
+								fnCallback.apply(oContext, aArgs);
 							}
 							mService.attachEvent(sEventName, fnOnce);
 						}
@@ -405,7 +416,7 @@ sap.ui.define([
 
 	Client.prototype._checkIfEventAlive = function(sServiceName, sEventName) {
 		var oEventProvider = this._oServiceEventBus.getChannel(sServiceName);
-		var sEventHandlerId = this._mEventHandlerIds[sServiceName + "," + sEventName];
+		var sEventHandlerId = this._mEventHandlerIds[`${sServiceName},${sEventName}`];
 
 		if (
 			(!oEventProvider || !oEventProvider.hasListeners(sEventName))