@openui5/sap.ui.rta 1.117.1 → 1.119.0

package/src/sap/ui/rta/plugin/Stretch.js

@@ -31,13 +31,12 @@ sap.ui.define([
 	 * @extends sap.ui.rta.plugin.Plugin
 	 *
 	 * @author SAP SE
-	 * @version 1.117.1
+	 * @version 1.119.0
 	 *
 	 * @constructor
 	 * @private
 	 * @since 1.60
 	 * @alias sap.ui.rta.plugin.Stretch
-	 * @experimental Since 1.60. This class is experimental and provides only limited functionality. Also the API might be changed in future.
 	 */
 	var Stretch = Plugin.extend("sap.ui.rta.plugin.Stretch", /** @lends sap.ui.rta.plugin.Stretch.prototype */ {
 		metadata: {
@@ -111,7 +110,7 @@ sap.ui.define([
 			iHeight -= parseInt(window.getComputedStyle(oParentGeometry.domRef, null).getPropertyValue("padding-top"));
 		}
 		var iParentSize = Math.round(oParentGeometry.size.width) * Math.round(iHeight);
-		aChildOverlays = aChildOverlays || OverlayUtil.getAllChildOverlays(oReferenceOverlay);
+		aChildOverlays ||= OverlayUtil.getAllChildOverlays(oReferenceOverlay);
 
 		var aChildrenGeometry = aChildOverlays.map(function(oChildOverlay) {
 			return oChildOverlay.getGeometry();
@@ -164,8 +163,9 @@ sap.ui.define([
 	 * @param {sap.ui.dt.DesignTime} oDesignTime DesignTime object
 	 * @override
 	 */
-	Stretch.prototype.setDesignTime = function(oDesignTime) {
-		Plugin.prototype.setDesignTime.apply(this, arguments);
+	Stretch.prototype.setDesignTime = function(...aArgs) {
+		const [oDesignTime] = aArgs;
+		Plugin.prototype.setDesignTime.apply(this, aArgs);
 
 		if (oDesignTime) {
 			oDesignTime.attachEventOnce("synced", this._onDTSynced, this);
@@ -197,12 +197,13 @@ sap.ui.define([
 	/**
 	 * @override
 	 */
-	Stretch.prototype.registerElementOverlay = function(oOverlay) {
+	Stretch.prototype.registerElementOverlay = function(...aArgs) {
+		const [oOverlay] = aArgs;
 		this._checkParentAndAddToStretchCandidates(oOverlay);
 
 		oOverlay.attachElementModified(this._onElementModified, this);
 
-		Plugin.prototype.registerElementOverlay.apply(this, arguments);
+		Plugin.prototype.registerElementOverlay.apply(this, aArgs);
 	};
 
 	/**
@@ -210,10 +211,11 @@ sap.ui.define([
 	 * @param  {sap.ui.dt.ElementOverlay} oOverlay overlay object
 	 * @override
 	 */
-	Stretch.prototype.deregisterElementOverlay = function(oOverlay) {
+	Stretch.prototype.deregisterElementOverlay = function(...aArgs) {
+		const [oOverlay] = aArgs;
 		toggleStyleClass(oOverlay, false);
 
-		Plugin.prototype.deregisterElementOverlay.apply(this, arguments);
+		Plugin.prototype.deregisterElementOverlay.apply(this, aArgs);
 	};
 
 	/**
@@ -242,18 +244,14 @@ sap.ui.define([
 		var oParams = oEvent.getParameters();
 		var oOverlay = oEvent.getSource();
 		if (oParams.type === "afterRendering") {
-			if (!this.fnDebounced) {
-				// the timeout should be changed to 0 as soon as DT refactoring is done
-				this.fnDebounced = _debounce(function() {
-					this._setStyleClassForAllStretchCandidates(this._getNewStretchCandidates(this._aOverlaysCollected));
-					this._aOverlaysCollected = [];
-					this.fnDebounced = undefined;
-				}.bind(this), 16);
-			}
-
-			if (!this._aOverlaysCollected) {
+			// the timeout should be changed to 0 as soon as DT refactoring is done
+			this.fnDebounced ||= _debounce(function() {
+				this._setStyleClassForAllStretchCandidates(this._getNewStretchCandidates(this._aOverlaysCollected));
 				this._aOverlaysCollected = [];
-			}
+				this.fnDebounced = undefined;
+			}.bind(this), 16);
+
+			this._aOverlaysCollected ||= [];
 
 			if (!includes(this._aOverlaysCollected, oOverlay)) {
 				this._aOverlaysCollected.push(oOverlay);

package/src/sap/ui/rta/plugin/additionalElements/ActionExtractor.js

@@ -32,10 +32,9 @@ sap.ui.define([
 	 * handled by the AdditionalElements Plugin (Reveal, Add Via Delegate, Add Custom)
 	 *
 	 * @author SAP SE
-	 * @version 1.117.1
+	 * @version 1.119.0
 	 * @private
 	 * @since 1.94
-	 * @experimental Since 1.94. This class is experimental and provides only limited functionality. Also the API might be changed in future.
 	 */
 	var ActionExtractor = {};
 
@@ -250,9 +249,7 @@ sap.ui.define([
 							} else {
 								bRevealEnabled = true;
 							}
-							if (!mRevealAction.getAggregationName) {
-								mRevealAction.getAggregationName = defaultGetAggregationName;
-							}
+							mRevealAction.getAggregationName ||= defaultGetAggregationName;
 
 							// Check if the invisible element can be moved to the target aggregation
 							if (bRevealEnabled && (sSourceAggregation !== sTargetAggregation)) {
@@ -329,7 +326,7 @@ sap.ui.define([
 		]).then(function(aAllActions) {
 			// join and condense all action data
 			var mAllActions = merge(aAllActions[0], aAllActions[1]);
-			oSourceElementOverlay._mAddActions = oSourceElementOverlay._mAddActions || {asSibling: {}, asChild: {}};
+			oSourceElementOverlay._mAddActions ||= {asSibling: {}, asChild: {}};
 			oSourceElementOverlay._mAddActions[sSiblingOrChild] = mAllActions;
 			return mAllActions;
 		});
@@ -429,9 +426,7 @@ sap.ui.define([
 					.then(function(mAction) {
 						if (mAction) {
 							mAction.addPropertyActionData.relevantContainer = mParents.relevantContainer;
-							if (!oReturn[mAction.aggregationName]) {
-								oReturn[mAction.aggregationName] = {};
-							}
+							oReturn[mAction.aggregationName] ||= {};
 							oReturn[mAction.aggregationName].addViaDelegate = mAction.addPropertyActionData;
 						}
 						return oReturn;

package/src/sap/ui/rta/plugin/additionalElements/AddElementsDialog.js

@@ -32,13 +32,11 @@ sap.ui.define([
 	 * @class Context - Dialog for available Fields in Runtime Authoring
 	 * @extends sap.ui.base.ManagedObject
 	 * @author SAP SE
-	 * @version 1.117.1
+	 * @version 1.119.0
 	 * @constructor
 	 * @private
 	 * @since 1.44
 	 * @alias sap.ui.rta.plugin.additionalElements.AddElementsDialog
-	 * @experimental Since 1.44. This class is experimental and provides only limited functionality. Also the API might be
-	 *			   changed in future.
 	 */
 	var AddElementsDialog = ManagedObject.extend("sap.ui.rta.plugin.additionalElements.AddElementsDialog", {
 		metadata: {
@@ -88,9 +86,7 @@ sap.ui.define([
 
 		this._oDialogPromise.then(function(oDialog) {
 			oDialog.setModel(this._oDialogModel);
-			if (!oRTAResourceModel) {
-				oRTAResourceModel = new ResourceModel({bundleName: "sap.ui.rta.messagebundle"});
-			}
+			oRTAResourceModel ||= new ResourceModel({bundleName: "sap.ui.rta.messagebundle"});
 			oDialog.setModel(oRTAResourceModel, "i18n");
 
 			oDialog.addStyleClass(Utils.getRtaStyleClassName());
@@ -99,18 +95,18 @@ sap.ui.define([
 
 			// retrieve List to set the sorting for the 'items' aggregation, since sap.ui.model.Sorter
 			// does not support binding to a model property...
-			this._oList = sap.ui.getCore().byId(this.getId() + "--rta_addElementsDialogList");
+			this._oList = sap.ui.getCore().byId(`${this.getId()}--rta_addElementsDialogList`);
 			this._bDescendingSortOrder = false;
 		}.bind(this));
 	};
 
-	AddElementsDialog.prototype.exit = function() {
+	AddElementsDialog.prototype.exit = function(...aArgs) {
 		this._oDialogPromise.then(function(oDialog) {
 			oDialog.destroy();
 		});
 
 		if (ManagedObject.prototype.exit) {
-			ManagedObject.prototype.exit.apply(this, arguments);
+			ManagedObject.prototype.exit.apply(this, aArgs);
 		}
 	};
 

package/src/sap/ui/rta/plugin/additionalElements/AdditionalElementsAnalyzer.js

@@ -61,7 +61,7 @@ sap.ui.define([
 	function _flattenProperties(aProperties) {
 		var aFlattenedProperties = aProperties.reduce(function(aFlattened, oProperty) {
 			if (Array.isArray(oProperty.properties)) {
-				// currently only one level supported by our dialogs, etc. => TODO make deep types possible
+				// only one level supported by our dialogs
 				// Only take the leaves, but attach the parent property name/label to it
 				aFlattened = aFlattened.concat(oProperty.properties.map(function(mInnerProp) {
 					mInnerProp.parentPropertyName = oProperty.label || oProperty.name;
@@ -241,7 +241,7 @@ sap.ui.define([
 				// unsupported: check existence of the property also in the navigation target
 				return (
 					sBindingPath === oModelProperty.bindingPath
-						|| sBindingPath.startsWith(oModelProperty.bindingPath + "/")
+						|| sBindingPath.startsWith(`${oModelProperty.bindingPath}/`)
 				);
 			});
 		})
@@ -430,7 +430,7 @@ sap.ui.define([
 		 *
 		 * @return {Promise} - returns a Promise which resolves with a list of hidden controls are available to display
 		 */
-		enhanceInvisibleElements: function(oElement, mActions) {
+		enhanceInvisibleElements(oElement, mActions) {
 			var mRevealData = mActions.reveal;
 			var mAddViaDelegate = mActions.addViaDelegate;
 
@@ -478,7 +478,7 @@ sap.ui.define([
 		 *
 		 * @return {Promise} - returns a Promise which resolves with a list of available to display delegate properties
 		 */
-		getUnrepresentedDelegateProperties: function(oElement, mAction) {
+		getUnrepresentedDelegateProperties(oElement, mAction) {
 			var sModelName = _getModelName(mAction);
 			var oDefaultAggregation = oElement.getMetadata().getAggregation();
 			var sAggregationName = oDefaultAggregation ? oDefaultAggregation.name : mAction.action.aggregation;

package/src/sap/ui/rta/plugin/additionalElements/AdditionalElementsPlugin.js

@@ -75,17 +75,18 @@ sap.ui.define([
 	 * @class The plugin allows to add additional elements that exist either hidden in the UI or in the OData service
 	 * @extends sap.ui.rta.plugin.Plugin
 	 * @author SAP SE
-	 * @version 1.117.1
+	 * @version 1.119.0
 	 * @constructor
 	 * @private
 	 * @since 1.44
 	 * @alias sap.ui.rta.plugin.additionalElements.AdditionalElementsPlugin
-	 * @experimental Since 1.44. This class is experimental and provides only limited functionality. Also the API might be changed in future.
 	 */
 	var AdditionalElementsPlugin = Plugin.extend("sap.ui.rta.plugin.additionalElements.AdditionalElementsPlugin", {
-		constructor: function(oPropertyBag) {
+		// eslint-disable-next-line object-shorthand
+		constructor: function(...aArgs) {
+			const [oPropertyBag] = aArgs;
 			oPropertyBag.dialog = new AddElementsDialog();
-			Plugin.apply(this, arguments);
+			Plugin.apply(this, aArgs);
 		},
 		metadata: {
 			// ---- object ----
@@ -103,19 +104,19 @@ sap.ui.define([
 		},
 
 		// For add elements plugin, include other aggregations which are potentially valid targets for hidden elements
-		_getRelevantOverlays: function(oOverlay) {
+		_getRelevantOverlays(oOverlay) {
 			var aRelevantOverlays = OverlayUtil.findAllOverlaysInContainer(oOverlay, /* bIncludeOtherAggregations= */true);
 
 			oOverlay.setRelevantOverlays(aRelevantOverlays);
 			return aRelevantOverlays;
 		},
 
-		getContextMenuText: function(bOverlayIsSibling, oOverlay, sAggregationName, bHasSubMenu) {
+		getContextMenuText(bOverlayIsSibling, oOverlay, sAggregationName, bHasSubMenu) {
 			var oTextResources;
 
 			function getGenericText() {
 				oTextResources = sap.ui.getCore().getLibraryResourceBundle("sap.ui.rta");
-				return oTextResources.getText("CTX_ADD_ELEMENTS", oTextResources.getText("MULTIPLE_CONTROL_NAME"));
+				return oTextResources.getText("CTX_ADD_ELEMENTS", [oTextResources.getText("MULTIPLE_CONTROL_NAME")]);
 			}
 
 			// When adding custom fields to a parent we don't know which control type will be added,
@@ -131,9 +132,7 @@ sap.ui.define([
 			}
 			var mParents = AdditionalElementsUtils.getParents(bOverlayIsSibling, oOverlay, this);
 			var mAllActions = ActionExtractor.getActionsOrUndef(bOverlayIsSibling, oOverlay);
-			if (!sAggregationName) {
-				sAggregationName = Object.keys(mAllActions)[0];
-			}
+			sAggregationName ||= Object.keys(mAllActions)[0];
 			var mActions = mAllActions[sAggregationName];
 
 			// Safeguarding
@@ -144,13 +143,13 @@ sap.ui.define([
 			return AdditionalElementsUtils.getText("CTX_ADD_ELEMENTS", mActions, mParents.parent, SINGULAR);
 		},
 
-		isAvailable: function(aElementOverlays, bOverlayIsSibling) {
+		isAvailable(aElementOverlays, bOverlayIsSibling) {
 			return aElementOverlays.every(function(oElementOverlay) {
 				return this._isEditableByPlugin(oElementOverlay, bOverlayIsSibling);
 			}, this);
 		},
 
-		isEnabled: function(aElementOverlays, bOverlayIsSibling, sAggregationName) {
+		isEnabled(aElementOverlays, bOverlayIsSibling, sAggregationName) {
 			if (aElementOverlays.length > 1) {
 				return false;
 			}
@@ -181,7 +180,7 @@ sap.ui.define([
 
 			var oCachedElements = this.getCachedElements(bOverlayIsSibling);
 			var bElementsAvailable = !!(oCachedElements && oCachedElements.length > 0);
-			bIsEnabled = bIsEnabled && bElementsAvailable;
+			bIsEnabled &&= bElementsAvailable;
 			return bIsEnabled;
 		},
 
@@ -193,7 +192,8 @@ sap.ui.define([
 		 * @param  {sap.ui.dt.Overlay} oOverlay Overlay object
 		 * @override
 		 */
-		registerElementOverlay: function(oOverlay) {
+		registerElementOverlay(...aArgs) {
+			const [oOverlay] = aArgs;
 			var oModel = oOverlay.getElement().getModel();
 			if (oModel) {
 				var oMetaModel = oModel.getMetaModel();
@@ -203,10 +203,10 @@ sap.ui.define([
 					}.bind(this));
 				}
 			}
-			Plugin.prototype.registerElementOverlay.apply(this, arguments);
+			Plugin.prototype.registerElementOverlay.apply(this, aArgs);
 		},
 
-		_checkIfCreateFunctionIsAvailable: function(mChangeHandlerSettings) {
+		_checkIfCreateFunctionIsAvailable(mChangeHandlerSettings) {
 			return !mChangeHandlerSettings ||
 				(
 					mChangeHandlerSettings &&
@@ -227,7 +227,7 @@ sap.ui.define([
 		 * @return {Promise} Returns a promise that resolves when the dialog closes
 		 * @private
 		 */
-		showAvailableElements: function(bOverlayIsSibling, sAggregationName, aResponsibleElementOverlays, iIndex, sControlName, sDisplayText) {
+		showAvailableElements(bOverlayIsSibling, sAggregationName, aResponsibleElementOverlays, iIndex, sControlName, sDisplayText) {
 			var oResponsibleElementOverlay = aResponsibleElementOverlays[0];
 			var mParents = AdditionalElementsUtils.getParents(bOverlayIsSibling, oResponsibleElementOverlay, this);
 			var vSiblingElement = bOverlayIsSibling && oResponsibleElementOverlay.getElement();
@@ -267,7 +267,7 @@ sap.ui.define([
 				if (sDisplayText) {
 					// Aggregation is part of title
 					var oTextResources = sap.ui.getCore().getLibraryResourceBundle("sap.ui.rta");
-					var sDialogTitle = oTextResources.getText("HEADER_ADDITIONAL_ELEMENTS_WITH_AGGREGATION", sDisplayText);
+					var sDialogTitle = oTextResources.getText("HEADER_ADDITIONAL_ELEMENTS_WITH_AGGREGATION", [sDisplayText]);
 					this.getDialog().setTitle(sDialogTitle);
 				} else if (sAggregationName || sControlName) {
 					// Only one aggregation, no aggregation in title
@@ -303,13 +303,13 @@ sap.ui.define([
 			});
 		},
 
-		_setDialogTitle: function(mActions, oParentElement, sControlName) {
+		_setDialogTitle(mActions, oParentElement, sControlName) {
 			var sDialogTitle = AdditionalElementsUtils.getText("HEADER_ADDITIONAL_ELEMENTS", mActions, oParentElement, PLURAL, sControlName);
 			this.getDialog().setTitle(sDialogTitle);
 		},
 
 		// Function called when custom field button was pressed
-		_onOpenCustomField: function(oEvent, bOverlayIsSibling) {
+		_onOpenCustomField(oEvent, bOverlayIsSibling) {
 			var sRtaStyleClassName = Utils.getRtaStyleClassName();
 			return FieldExtensibility.onTriggerCreateExtensionData(this.getExtensibilityInfo(bOverlayIsSibling), sRtaStyleClassName);
 		},
@@ -321,7 +321,7 @@ sap.ui.define([
 		 * @returns {object} Returns object with editable boolean values for "asChild" and "asSibling"
 		 * @protected
 		 */
-		_isEditable: function(oOverlay, mPropertyBag) {
+		_isEditable(oOverlay, mPropertyBag) {
 			return Promise.all([this._isEditableCheck(mPropertyBag.sourceElementOverlay, true), this._isEditableCheck(mPropertyBag.sourceElementOverlay, false)])
 			.then(function(aPromiseValues) {
 				return {
@@ -334,7 +334,7 @@ sap.ui.define([
 			});
 		},
 
-		_isEditableCheck: function(oOverlay, bOverlayIsSibling) {
+		_isEditableCheck(oOverlay, bOverlayIsSibling) {
 			return Promise.resolve()
 			.then(function() {
 				var mParents = AdditionalElementsUtils.getParents(bOverlayIsSibling, oOverlay, this);
@@ -366,11 +366,9 @@ sap.ui.define([
 					}.bind(this));
 				}.bind(this))
 				.then(function(bEditable) {
-					if (bEditable) {
-						bEditable =
-									this.hasStableId(oOverlay) // don't confuse the user/Web IDE by an editable overlay without stable ID
-									&& this.hasStableId(mParents.parentOverlay);
-					}
+					bEditable &&=
+								this.hasStableId(oOverlay) // don't confuse the user/Web IDE by an editable overlay without stable ID
+								&& this.hasStableId(mParents.parentOverlay);
 					return bEditable;
 				}.bind(this));
 			}.bind(this));
@@ -383,7 +381,7 @@ sap.ui.define([
 		 * @returns {Array} An array with all elements
 		 * @protected
 		 */
-		getAllElements: function(bOverlayIsSibling, aElementOverlays) {
+		getAllElements(bOverlayIsSibling, aElementOverlays) {
 			var oElementOverlay = aElementOverlays[0];
 			var mParents = AdditionalElementsUtils.getParents(bOverlayIsSibling, oElementOverlay, this);
 			var mActions;
@@ -442,7 +440,7 @@ sap.ui.define([
 		 * @param  {sap.ui.dt.ElementOverlay} aElementOverlays - List of overlays for which the context menu was opened
 		 * @return {object[]} Array containing the items with required data
 		 */
-		getMenuItems: function(aElementOverlays) {
+		getMenuItems(aElementOverlays) {
 			var aMenuItems = [];
 			var oMenuItem;
 			this.clearCachedElements();
@@ -474,7 +472,7 @@ sap.ui.define([
 			}.bind(this));
 		},
 
-		_buildMenuItem: function(sPluginId, bOverlayIsSibling, aElementOverlays, aElementsWithAggregations, bHasSubMenu) {
+		_buildMenuItem(sPluginId, bOverlayIsSibling, aElementOverlays, aElementsWithAggregations, bHasSubMenu) {
 			var aSubMenuItems;
 			var vHandler;
 			var sAggregationName;
@@ -519,7 +517,7 @@ sap.ui.define([
 			return oMenuItem;
 		},
 
-		_buildSubmenuItems: function(bOverlayIsSibling, aElementOverlays, aElementsWithAggregation) {
+		_buildSubmenuItems(bOverlayIsSibling, aElementOverlays, aElementsWithAggregation) {
 			var aSubMenuItems = [];
 			var sPluginId = bOverlayIsSibling ? "CTX_ADD_ELEMENTS_AS_SIBLING" : "CTX_ADD_ELEMENTS_AS_CHILD";
 			var iPosition = 0;
@@ -542,7 +540,7 @@ sap.ui.define([
 				var sAggregationName = mElementsWithAggregation.aggregation;
 				var sDisplayText = getMenuItemText(bOverlayIsSibling, sAggregationName, aElementOverlays);
 				var oItem = {
-					id: sPluginId + "_" + iPosition,
+					id: `${sPluginId}_${iPosition}`,
 					text: sDisplayText,
 					enabled: function(aElementOverlays) {
 						return this.isEnabled(aElementOverlays, bOverlayIsSibling, sAggregationName);
@@ -589,7 +587,7 @@ sap.ui.define([
 		// 		elements: [...]
 		// 	}
 		// ]
-		_combineAnalyzerResults: function(aAllPromises) {
+		_combineAnalyzerResults(aAllPromises) {
 			var aCollectedPromises = [];
 
 			aAllPromises.forEach(function(aPromisesByAggregation) {
@@ -616,44 +614,44 @@ sap.ui.define([
 			});
 		},
 
-		clearCachedElements: function() {
+		clearCachedElements() {
 			this._oCachedElements = undefined;
 		},
 
-		setCachedElements: function(aElements, bOverlayIsSibling) {
-			this._oCachedElements = this._oCachedElements || {};
+		setCachedElements(aElements, bOverlayIsSibling) {
+			this._oCachedElements ||= {};
 			this._oCachedElements[bOverlayIsSibling ? "asSibling" : "asChild"] = aElements;
 		},
 
-		getCachedElements: function(bOverlayIsSibling) {
+		getCachedElements(bOverlayIsSibling) {
 			if (this._oCachedElements) {
 				return this._oCachedElements[bOverlayIsSibling ? "asSibling" : "asChild"];
 			}
 			return undefined;
 		},
 
-		clearExtensibilityInfo: function(bOverlayIsSibling) {
+		clearExtensibilityInfo(bOverlayIsSibling) {
 			if (this._oExtensibilityInfo) {
 				this._oExtensibilityInfo[bOverlayIsSibling ? "asSibling" : "asChild"] = undefined;
 			}
 		},
 
-		setExtensibilityInfo: function(bOverlayIsSibling, oExtensibilityInfo) {
-			this._oExtensibilityInfo = this._oExtensibilityInfo || {};
+		setExtensibilityInfo(bOverlayIsSibling, oExtensibilityInfo) {
+			this._oExtensibilityInfo ||= {};
 			this._oExtensibilityInfo[bOverlayIsSibling ? "asSibling" : "asChild"] = oExtensibilityInfo;
 		},
 
-		getExtensibilityInfo: function(bOverlayIsSibling) {
+		getExtensibilityInfo(bOverlayIsSibling) {
 			if (this._oExtensibilityInfo) {
 				return this._oExtensibilityInfo[bOverlayIsSibling ? "asSibling" : "asChild"];
 			}
 			return undefined;
 		},
 
-		exit: function() {
+		exit(...aArgs) {
 			this.getDialog().destroy();
 			if (Plugin.prototype.exit) {
-				Plugin.prototype.exit.apply(this, arguments);
+				Plugin.prototype.exit.apply(this, aArgs);
 			}
 		}
 

package/src/sap/ui/rta/plugin/additionalElements/AdditionalElementsUtils.js

@@ -15,10 +15,9 @@ sap.ui.define([
 	 * Helper object containing methods for the AdditionalElements plugin
 	 *
 	 * @author SAP SE
-	 * @version 1.117.1
+	 * @version 1.119.0
 	 * @private
 	 * @since 1.94
-	 * @experimental Since 1.94. This class is experimental and provides only limited functionality. Also the API might be changed in future.
 	 */
 	var AdditionalElementsUtils = {};
 
@@ -102,7 +101,7 @@ sap.ui.define([
 		var oTextResources = sap.ui.getCore().getLibraryResourceBundle("sap.ui.rta");
 
 		if (aNonDuplicateNames.length === 1) {
-			sControlType = aNonDuplicateNames[0];
+			[sControlType] = aNonDuplicateNames;
 		} else if (sControlName) {
 			sControlType = sControlName;
 		} else {

package/src/sap/ui/rta/plugin/additionalElements/CommandBuilder.js

@@ -25,10 +25,9 @@ sap.ui.define([
 	 * Helper object to build the RTA commands resulting from the AdditionalElements Plugin
 	 *
 	 * @author SAP SE
-	 * @version 1.117.1
+	 * @version 1.119.0
 	 * @private
 	 * @since 1.94
-	 * @experimental Since 1.94. This class is experimental and provides only limited functionality. Also the API might be changed in future.
 	 */
 	var CommandBuilder = {};
 
@@ -63,9 +62,9 @@ sap.ui.define([
 			if (oMoveCommandForInvisible) {
 				oCompositeCommand.addCommand(oMoveCommandForInvisible);
 			} else {
-				Log.warning("No move action configured for "
-						+ mParents.parent.getMetadata().getName()
-						+ ", aggregation: " + oSelectedElement.aggregation, "sap.ui.rta");
+				Log.warning(`No move action configured for ${
+						 mParents.parent.getMetadata().getName()
+						 }, aggregation: ${oSelectedElement.aggregation}`, "sap.ui.rta");
 			}
 			return oCompositeCommand;
 		});
@@ -279,7 +278,7 @@ sap.ui.define([
 								createCommandsForAddViaDelegate.bind(this, mPropertyBag));
 							break;
 						default:
-							Log.error("Can't create command for untreated element.type " + oSelectedElement.type);
+							Log.error(`Can't create command for untreated element.type ${oSelectedElement.type}`);
 					}
 				}, this);
 				return oPromise.then(function() { return oCompositeCommand; });

package/src/sap/ui/rta/plugin/iframe/AddIFrame.js

@@ -24,7 +24,7 @@ sap.ui.define([
 	function getCreateMenuItemText(sAggregationName, sTextKey, oTextResources, oOverlay) {
 		var bSibling = !sAggregationName;
 		var oAction = this.getCreateAction(bSibling, oOverlay, sAggregationName);
-		return oTextResources.getText(sTextKey, oAction.text);
+		return oTextResources.getText(sTextKey, [oAction.text]);
 	}
 
 	function getAddIFrameCommand(oModifiedElement, mSettings, oDesignTimeMetadata, sVariantManagementKey) {
@@ -49,7 +49,8 @@ sap.ui.define([
 			url: mSettings.frameUrl,
 			width: sWidth,
 			height: sHeight,
-			title: mSettings.title
+			title: mSettings.title,
+			useLegacyNavigation: mSettings.useLegacyNavigation
 		}, oDesignTimeMetadata, sVariantManagementKey);
 	}
 
@@ -116,12 +117,12 @@ sap.ui.define([
 	 * @class The AddIFrame allows trigger AddIFrame operations on the overlay.
 	 * @extends sap.ui.rta.plugin.BaseCreate
 	 * @author SAP SE
-	 * @version 1.117.1
+	 * @version 1.119.0
 	 * @constructor
 	 * @private
 	 * @since 1.75
 	 * @alias sap.ui.rta.plugin.AddIFrame
-	 * @experimental Since 1.75. This class is experimental and provides only limited functionality. Also the API might be changed in future.
+	 *  Since 1.75. This class is experimental and provides only limited functionality. Also the API might be changed in future.
 	 */
 	var AddIFrame = BaseCreate.extend("sap.ui.rta.plugin.AddIFrame", /** @lends sap.ui.rta.plugin.AddIFrame.prototype */{
 		metadata: {
@@ -152,7 +153,7 @@ sap.ui.define([
 	 * @return {array} Array of context menu items
 	 * @override
 	 */
-	AddIFrame.prototype.getMenuItems = function(aElementOverlays) {
+	AddIFrame.prototype.getMenuItems = async function(aElementOverlays) {
 		function getCommonProperties(sAggregationName) {
 			var oTextResources = sap.ui.getCore().getLibraryResourceBundle("sap.ui.rta");
 			var sIFrameGroupText = oTextResources.getText("CTX_ADDIFRAME_GROUP");
@@ -171,8 +172,9 @@ sap.ui.define([
 			collectionName: "tnt",
 			fontFamily: "SAP-icons-TNT",
 			fontURI: sap.ui.require.toUrl("sap/tnt/themes/base/fonts"),
-			lazy: true
+			lazy: false
 		});
+		await IconPool.fontLoaded("tnt");
 
 		var iBaseRank = 140;
 		var aMenuItems = [];
@@ -198,7 +200,7 @@ sap.ui.define([
 			.map(function(oAction, iIndex) {
 				var oParentMenuItem = Object.assign({
 					action: oAction,
-					id: "CTX_CREATE_CHILD_IFRAME_" + oAction.aggregation.toUpperCase(),
+					id: `CTX_CREATE_CHILD_IFRAME_${oAction.aggregation.toUpperCase()}`,
 					rank: iBaseRank + 10 * iIndex
 				}, getCommonProperties.call(this, oAction.aggregation));