@openui5/sap.ui.rta 1.117.1 → 1.118.0

package/src/sap/ui/rta/appVariant/AppVariantDialog.js

@@ -56,9 +56,9 @@ function(
 	"use strict";
 
 	// shortcut for sap.ui.layout.form.SimpleFormLayout
-	var SimpleFormLayout = layoutLibrary.form.SimpleFormLayout;
+	var {SimpleFormLayout} = layoutLibrary.form;
 
-	var ValueState = coreLibrary.ValueState;
+	var {ValueState} = coreLibrary;
 
 	var oResources = sap.ui.getCore().getLibraryResourceBundle("sap.ui.rta");
 	var oDataSet;
@@ -114,21 +114,19 @@ function(
 	}
 
 	function _handleSelectDialog() {
-		if (!oSelectDialog) {
-			oSelectDialog = new SelectDialog("selectDialog", {
-				noDataText: oResources.getText("APP_VARIANT_ICON_NO_DATA"),
-				title: oResources.getText("APP_VARIANT_ICON_SELECT_ICON"),
-				search: function(oEvent) {
-					_handleSearch(oEvent);
-				},
-				confirm: function(oEvent) {
-					_handleClose(oEvent);
-				},
-				cancel: function(oEvent) {
-					_handleClose(oEvent);
-				}
-			});
-		}
+		oSelectDialog ||= new SelectDialog("selectDialog", {
+			noDataText: oResources.getText("APP_VARIANT_ICON_NO_DATA"),
+			title: oResources.getText("APP_VARIANT_ICON_SELECT_ICON"),
+			search(oEvent) {
+				_handleSearch(oEvent);
+			},
+			confirm(oEvent) {
+				_handleClose(oEvent);
+			},
+			cancel(oEvent) {
+				_handleClose(oEvent);
+			}
+		});
 
 		oSelectDialog.addStyleClass(RtaUtils.getRtaStyleClassName());
 
@@ -174,7 +172,7 @@ function(
 			value: "{/title}",
 			valueLiveUpdate: true,
 			placeholder: oResources.getText("SAVE_AS_DIALOG_PLACEHOLDER_TITLE_TEXT"),
-			liveChange: function() {
+			liveChange() {
 				var oSaveButton = sap.ui.getCore().byId("saveButton");
 				if (this.getValue() === "") {
 					this.setValueState(ValueState.Error); // if the field is empty after change, it will go red
@@ -212,10 +210,10 @@ function(
 
 		oIconInput = new Input("selectInput", {
 			showValueHelp: true,
-			liveChange: function(oEvent) {
+			liveChange(oEvent) {
 				_handleSelectDialog(oEvent);
 			},
-			valueHelpRequest: function(oEvent) {
+			valueHelpRequest(oEvent) {
 				_handleSelectDialog(oEvent);
 			},
 			value: "{/iconname}",
@@ -284,7 +282,7 @@ function(
 				cancel: {}
 			}
 		},
-		init: function() {
+		init() {
 			Dialog.prototype.init.apply(this);
 
 			// initialize dialog and create member variables.
@@ -314,12 +312,12 @@ function(
 			this._createButtons();
 			this.addStyleClass(RtaUtils.getRtaStyleClassName());
 		},
-		onAfterRendering: function() {
+		onAfterRendering() {
 			document.getElementById("title1").style.height = "0px";
 			document.getElementById("title2").style.height = "0px";
 			document.getElementById("tile").style.float = "left";
 		},
-		_onCreate: function() {
+		_onCreate() {
 			var sTitle = oTitleInput.getValue() || " ";
 			var sSubTitle = oSubTitleInput.getValue() || " ";
 			var sDescription = oDescriptionText.getValue() || " ";
@@ -336,7 +334,7 @@ function(
 			this.close();
 			this.destroy();
 		},
-		_createButtons: function() {
+		_createButtons() {
 			this.addButton(new Button("saveButton", {
 				text: oResources.getText("APP_VARIANT_DIALOG_SAVE"),
 				tooltip: oResources.getText("TOOLTIP_APP_VARIANT_DIALOG_SAVE"),
@@ -356,11 +354,11 @@ function(
 				}.bind(this)
 			}));
 		},
-		destroy: function() {
+		destroy(...aArgs) {
 			if (oCustomTileModel) {
 				oCustomTileModel.destroy();
 			}
-			Dialog.prototype.destroy.apply(this, arguments);
+			Dialog.prototype.destroy.apply(this, aArgs);
 		},
 		renderer: DialogRenderer
 	});

package/src/sap/ui/rta/appVariant/AppVariantManager.js

@@ -24,13 +24,11 @@ sap.ui.define([
 	 * @class
 	 * @extends sap.ui.base.ManagedObject
 	 * @author SAP SE
-	 * @version 1.117.1
+	 * @version 1.118.0
 	 * @constructor
 	 * @private
 	 * @since 1.53
 	 * @alias sap.ui.rta.appVariant.AppVariantManager
-	 * @experimental Since 1.53. This class is experimental and provides only limited functionality. Also the API might be
-	 *               changed in future.
 	 */
 	var AppVariantManager = ManagedObject.extend("sap.ui.rta.appVariant.AppVariantManager", {
 		metadata: {

package/src/sap/ui/rta/appVariant/AppVariantOverviewDialog.js

@@ -36,8 +36,9 @@ sap.ui.define([
 				cancel: {}
 			}
 		},
-		constructor: function() {
-			Dialog.prototype.constructor.apply(this, arguments);
+		// eslint-disable-next-line object-shorthand
+		constructor: function(...aArgs) {
+			Dialog.prototype.constructor.apply(this, aArgs);
 			this._oTextResources = sap.ui.getCore().getLibraryResourceBundle("sap.ui.rta");
 
 			// Create manage apps component
@@ -63,8 +64,8 @@ sap.ui.define([
 
 			this.addStyleClass(RtaUtils.getRtaStyleClassName());
 		},
-		destroy: function() {
-			Dialog.prototype.destroy.apply(this, arguments);
+		destroy(...aArgs) {
+			Dialog.prototype.destroy.apply(this, aArgs);
 		},
 		renderer: DialogRenderer
 	});

package/src/sap/ui/rta/appVariant/AppVariantUtils.js

@@ -67,7 +67,7 @@ sap.ui.define([
 			if (sTrimmedId[sTrimmedId.length - 1] === ".") {
 				sTrimmedId = sTrimmedId + sGuidString;
 			} else {
-				sTrimmedId = sTrimmedId + "." + sGuidString;
+				sTrimmedId = `${sTrimmedId}.${sGuidString}`;
 			}
 
 			return this.trimIdIfRequired(sTrimmedId);
@@ -82,7 +82,7 @@ sap.ui.define([
 		var aIdStrings = sBaseAppID.split(".");
 
 		if (aIdStrings[0] !== "customer") {
-			aIdStrings[0] = "customer." + aIdStrings[0];
+			aIdStrings[0] = `customer.${aIdStrings[0]}`;
 		}
 
 		var bRegFound = false;
@@ -98,7 +98,7 @@ sap.ui.define([
 
 		sChangedId = aIdStrings.join(".");
 		if (!bRegFound) {
-			sChangedId = sChangedId + "." + uid().replace(/-/g, "_");
+			sChangedId = `${sChangedId}.${uid().replace(/-/g, "_")}`;
 		}
 
 		sChangedId = this.trimIdIfRequired(sChangedId);
@@ -124,7 +124,7 @@ sap.ui.define([
 	};
 
 	AppVariantUtils.prepareTextsChange = function(sPropertyName, sPropertyValue) {
-		var sComment = "New " + sPropertyName + " entered by a key user via RTA tool";
+		var sComment = `New ${sPropertyName} entered by a key user via RTA tool`;
 		return this.getInlineChangeInput(sPropertyValue, sComment);
 	};
 
@@ -180,7 +180,7 @@ sap.ui.define([
 					oInboundInfo.addNewInboundRequired = true;
 					break;
 				case 1:
-					oInboundInfo.currentRunningInbound = aInboundsFound[0];
+					[oInboundInfo.currentRunningInbound] = aInboundsFound;
 					oInboundInfo.addNewInboundRequired = false;
 					break;
 				default:
@@ -194,7 +194,7 @@ sap.ui.define([
 	};
 
 	AppVariantUtils.getInboundPropertiesKey = function(sAppVariantId, sCurrentRunningInboundId, sPropertyName) {
-		return sAppVariantId + "_sap.app.crossNavigation.inbounds." + sCurrentRunningInboundId + "." + sPropertyName;
+		return `${sAppVariantId}_sap.app.crossNavigation.inbounds.${sCurrentRunningInboundId}.${sPropertyName}`;
 	};
 
 	AppVariantUtils.getInlineChangeForInboundPropertySaveAs = function(sCurrentRunningInboundId, sAppVariantId) {
@@ -245,8 +245,8 @@ sap.ui.define([
 			oProperty.content.inbound[sCurrentRunningInboundId] = {
 				semanticObject: oParsedHash.semanticObject,
 				action: oParsedHash.action,
-				title: "{{" + sInboundTitleKey + "}}",
-				subTitle: "{{" + sInboundSubTitleKey + "}}",
+				title: `{{${sInboundTitleKey}}}`,
+				subTitle: `{{${sInboundSubTitleKey}}}`,
 				icon: oAppVariantSpecificData.icon,
 				signature: {
 					parameters: {
@@ -301,11 +301,11 @@ sap.ui.define([
 			}, {
 				propertyPath: "title",
 				operation: "UPSERT",
-				propertyValue: "{{" + sInboundTitleKey + "}}"
+				propertyValue: `{{${sInboundTitleKey}}}`
 			}, {
 				propertyPath: "subTitle",
 				operation: "UPSERT",
-				propertyValue: "{{" + sInboundSubTitleKey + "}}"
+				propertyValue: `{{${sInboundSubTitleKey}}}`
 			}, {
 				propertyPath: "icon",
 				operation: "UPSERT",
@@ -343,16 +343,16 @@ sap.ui.define([
 
 	AppVariantUtils.getTransportInput = function(sPackageName, sNameSpace, sName, sType) {
 		return {
-			getPackage: function() {
+			getPackage() {
 				return sPackageName;
 			},
-			getNamespace: function() {
+			getNamespace() {
 				return sNameSpace;
 			},
-			getId: function() {
+			getId() {
 				return sName;
 			},
-			getDefinition: function() {
+			getDefinition() {
 				return {
 					fileType: sType
 				};
@@ -403,7 +403,7 @@ sap.ui.define([
 
 	AppVariantUtils.getText = function(sMessageKey, sText) {
 		var oTextResources = this.getTextResources();
-		return sText ? oTextResources.getText(sMessageKey, sText) : oTextResources.getText(sMessageKey);
+		return sText ? oTextResources.getText(sMessageKey, [sText]) : oTextResources.getText(sMessageKey);
 	};
 
 	AppVariantUtils._getErrorMessageText = function(oError) {
@@ -416,7 +416,7 @@ sap.ui.define([
 		} else if (oError.userMessage) {
 			sErrorMessage = oError.userMessage;
 		} else if (oError.iamAppId) {
-			sErrorMessage = "IAM App Id: " + oError.iamAppId;
+			sErrorMessage = `IAM App Id: ${oError.iamAppId}`;
 		} else {
 			sErrorMessage = oError.stack || oError.message || oError.status || oError;
 		}
@@ -426,10 +426,10 @@ sap.ui.define([
 
 	AppVariantUtils.buildErrorInfo = function(sMessageKey, oError, sAppVariantId) {
 		var sErrorMessage = this._getErrorMessageText(oError);
-		var sMessage = AppVariantUtils.getText(sMessageKey) + "\n\n";
+		var sMessage = `${AppVariantUtils.getText(sMessageKey)}\n\n`;
 
 		if (sAppVariantId) {
-			sMessage += AppVariantUtils.getText("MSG_APP_VARIANT_ID", sAppVariantId) + "\n";
+			sMessage += `${AppVariantUtils.getText("MSG_APP_VARIANT_ID", sAppVariantId)}\n`;
 		}
 
 		sMessage += AppVariantUtils.getText("MSG_TECHNICAL_ERROR", sErrorMessage);
@@ -451,8 +451,8 @@ sap.ui.define([
 		var sOverviewList = bSaveAsTriggeredFromRtaToolbar ? "" : "_OVERVIEW_LIST";
 		var sText = bIsS4HanaCloud ? undefined : sAppVariantId;
 
-		var sMessage = AppVariantUtils.getText("SAVE_APP_VARIANT_SUCCESS_MESSAGE") + "\n\n";
-		sMessage += AppVariantUtils.getText("SAVE_APP_VARIANT_SUCCESS_S4HANA_" + sSystemTag + "_MESSAGE" + sOverviewList, sText);
+		var sMessage = `${AppVariantUtils.getText("SAVE_APP_VARIANT_SUCCESS_MESSAGE")}\n\n`;
+		sMessage += AppVariantUtils.getText(`SAVE_APP_VARIANT_SUCCESS_S4HANA_${sSystemTag}_MESSAGE${sOverviewList}`, sText);
 
 		return {
 			text: sMessage,
@@ -563,7 +563,7 @@ sap.ui.define([
 				}
 			})
 			.catch(function(vError) {
-				throw new Error("Error navigating to FLP Homepage: " + vError);
+				throw new Error(`Error navigating to FLP Homepage: ${vError}`);
 			});
 		}
 		return Promise.resolve();

package/src/sap/ui/rta/appVariant/Feature.js

@@ -99,7 +99,7 @@ sap.ui.define([
 
 	return {
 		// To see the overview of app variants, a key user has created from an app
-		onGetOverview: function(bAsKeyUser, sLayer) {
+		onGetOverview(bAsKeyUser, sLayer) {
 			var oDescriptor = fnGetDescriptor();
 
 			return new Promise(function(resolve) {
@@ -115,9 +115,7 @@ sap.ui.define([
 				};
 
 				sap.ui.require([sOverviewPath], function(AppVariantOverviewDialog) {
-					if (!oAppVariantOverviewDialog) {
-						oAppVariantOverviewDialog = new AppVariantOverviewDialog(oProperties);
-					}
+					oAppVariantOverviewDialog ||= new AppVariantOverviewDialog(oProperties);
 
 					oAppVariantOverviewDialog.attachCancel(fnCancel);
 
@@ -137,7 +135,7 @@ sap.ui.define([
 		 * When this method returns <code>true</code> then a drop down menu button on the UI is shown where a user can choose app variant overview for either a key user or SAP developer.
 		 * When this method returns <code>false</code>, an app variant overview is shown only for a key user.
 		 */
-		isOverviewExtended: function() {
+		isOverviewExtended() {
 			var oUriParams = UriParameters.fromQuery(window.location.search);
 			var sMode = oUriParams.get("sap-ui-xx-app-variant-overview-extended");
 			if (!sMode) {
@@ -146,7 +144,7 @@ sap.ui.define([
 
 			return sMode.toLowerCase() === "true";
 		},
-		isManifestSupported: function() {
+		isManifestSupported() {
 			var oDescriptor = fnGetDescriptor();
 			return AppVariantUtils.getManifirstSupport(oDescriptor["sap.app"].id);
 		},
@@ -156,7 +154,7 @@ sap.ui.define([
 		 * @param {object} oLrepSerializer - Layered repository serializer
 		 * @returns {boolean} Boolean value
 		 */
-		isSaveAsAvailable: function(oRootControl, sCurrentLayer, oLrepSerializer) {
+		isSaveAsAvailable(oRootControl, sCurrentLayer, oLrepSerializer) {
 			oRootControlRunningApp = oRootControl;
 			oCommandSerializer = oLrepSerializer;
 
@@ -182,7 +180,7 @@ sap.ui.define([
 		 * @returns {Promise} Resolved promise with an app variant descriptor
 		 * @description Getting here an app variant descriptor from the layered repository.
 		 */
-		getAppVariantDescriptor: function(oRootControl) {
+		getAppVariantDescriptor(oRootControl) {
 			oRootControlRunningApp = oRootControl;
 			var oDescriptor = fnGetDescriptor();
 			if (oDescriptor["sap.app"] && oDescriptor["sap.app"].id) {
@@ -192,7 +190,7 @@ sap.ui.define([
 			}
 			return Promise.resolve(false);
 		},
-		_determineSelector: function(bIsRunningApp, oDescriptor) {
+		_determineSelector(bIsRunningApp, oDescriptor) {
 			return bIsRunningApp ? oRootControlRunningApp : {
 				appId: oDescriptor["sap.app"].id,
 				appVersion: oDescriptor["sap.app"].applicationVersion.version
@@ -208,7 +206,7 @@ sap.ui.define([
 		 * When 'Save As' triggered from the UI adaptation header bar, we set both flags <code>bSaveAsFromRta</code> and <code>bCopyUnsavedChanges</code> equal to <code>true</code>.
 		 * The flag <code>bCopyUnsavedChanges</code> is <code>true</code> if a key user presses 'Save As' from the running app entry in the app variant overview dialog.
 		 */
-		onSaveAs: function(bSaveAsFromRta, bCopyUnsavedChanges, sCurrentLayer, oSelectedAppVariant) {
+		onSaveAs(bSaveAsFromRta, bCopyUnsavedChanges, sCurrentLayer, oSelectedAppVariant) {
 			var bIsS4HanaCloud;
 			var oAppVariantSaveClosure;
 			var oDescriptor = fnGetDescriptor();
@@ -254,9 +252,7 @@ sap.ui.define([
 					return oAppVariantManager.createAppVariant(sAppVariantId, vSelector)
 					.catch(function(oError) {
 						var sMessageKey = oError.messageKey;
-						if (!sMessageKey) {
-							sMessageKey = "MSG_SAVE_APP_VARIANT_FAILED";
-						}
+						sMessageKey ||= "MSG_SAVE_APP_VARIANT_FAILED";
 
 						return AppVariantUtils.catchErrorDialog(oError, sMessageKey, sAppVariantId);
 					});
@@ -321,12 +317,10 @@ sap.ui.define([
 				};
 
 				sap.ui.require(["sap/ui/rta/appVariant/AppVariantManager"], function(AppVariantManager) {
-					if (!oAppVariantManager) {
-						oAppVariantManager = new AppVariantManager({
-							commandSerializer: oCommandSerializer,
-							layer: sCurrentLayer
-						});
-					}
+					oAppVariantManager ||= new AppVariantManager({
+						commandSerializer: oCommandSerializer,
+						layer: sCurrentLayer
+					});
 
 					return fnProcessSaveAsDialog()
 					.then(fnCreateInlineChanges) // Create the inline changes for application variant
@@ -355,17 +349,15 @@ sap.ui.define([
 		 * @returns {Promise} Resolved promise
 		 * @description Triggers a delete operation of the app variant.
 		 */
-		onDeleteFromOverviewDialog: function(sAppVariantId, bCurrentlyAdapting, sCurrentLayer) {
+		onDeleteFromOverviewDialog(sAppVariantId, bCurrentlyAdapting, sCurrentLayer) {
 			var bIsS4HanaCloud;
 			return new Promise(function(resolve) {
 				sap.ui.require(["sap/ui/rta/appVariant/AppVariantManager"], function(AppVariantManager) {
-					if (!oAppVariantManager) {
-						oAppVariantManager = new AppVariantManager({
-							rootControl: oRootControlRunningApp,
-							commandSerializer: oCommandSerializer,
-							layer: sCurrentLayer
-						});
-					}
+					oAppVariantManager ||= new AppVariantManager({
+						rootControl: oRootControlRunningApp,
+						commandSerializer: oCommandSerializer,
+						layer: sCurrentLayer
+					});
 
 					var fnDeleteAppVariant = function() {
 						return oAppVariantManager.deleteAppVariant(sAppVariantId)
@@ -374,9 +366,7 @@ sap.ui.define([
 								return Promise.reject("cancel");
 							}
 							var sMessageKey = oError.messageKey;
-							if (!sMessageKey) {
-								sMessageKey = "MSG_DELETE_APP_VARIANT_FAILED";
-							}
+							sMessageKey ||= "MSG_DELETE_APP_VARIANT_FAILED";
 							return AppVariantUtils.catchErrorDialog(oError, sMessageKey, sAppVariantId);
 						});
 					};

package/src/sap/ui/rta/appVariant/S4HanaCloudBackend.js

@@ -22,8 +22,9 @@ sap.ui.define([
 		metadata: {
 			library: "sap.ui.rta"
 		},
-		constructor: function() {
-			ManagedObject.apply(this, arguments);
+		// eslint-disable-next-line object-shorthand
+		constructor: function(...aArgs) {
+			ManagedObject.apply(this, aArgs);
 		}
 	});
 
@@ -38,7 +39,12 @@ sap.ui.define([
 	 *                    or rejects if the required ODATA service /sap/opu/odata/sap/APS_IAM_APP_SRV is not there
 	 * @async
 	 */
-	S4HanaCloudBackend.prototype.notifyFlpCustomizingIsReady = function(sIamAppId, bAppVarCreation, iCheckIntervallMsec, iMaxNumberOfChecks) {
+	S4HanaCloudBackend.prototype.notifyFlpCustomizingIsReady = function(
+		sIamAppId,
+		bAppVarCreation,
+		iCheckIntervallMsec,
+		iMaxNumberOfChecks
+	) {
 		var that = this;
 		return new Promise(function(resolve, reject) {
 			// Check inputs and determine defaults
@@ -66,7 +72,7 @@ sap.ui.define([
 				// ... Reject if publishing return an error or is locked
 				}).catch(function(oError) {
 					var sText = bAppVarCreation ? "creation" : "deletion";
-					Log.error("Catalog publishing failed for app variant " + sText + ". AppVarStatus is " + oError.message);
+					Log.error(`Catalog publishing failed for app variant ${sText}. AppVarStatus is ${oError.message}`);
 					reject({ iamAppId: sIamAppId, error: oError.message});
 				});
 			}
@@ -79,7 +85,7 @@ sap.ui.define([
 	S4HanaCloudBackend._isAppReady = function(oAppStatusResponse, bAppVarCreation) {
 		var aCatalogList = oAppStatusResponse.data.results;
 		if (!Array.isArray(aCatalogList)) {
-			throw new Error(oAppStatusResponse.requestUri + " returned unexpected result: " + oAppStatusResponse);
+			throw new Error(`${oAppStatusResponse.requestUri} returned unexpected result: ${oAppStatusResponse}`);
 		}
 
 		var bIsUnpublished = aCatalogList.every(function(oCatalog) {
@@ -111,18 +117,16 @@ sap.ui.define([
 	};
 
 	S4HanaCloudBackend._getODataModel = function() {
-		if (!oModelPromise) {
-			oModelPromise = new Promise(function(resolve, reject) {
-				var oModel = new ODataModel("/sap/opu/odata/sap/APS_IAM_APP_SRV");
-				oModel.attachMetadataFailed(function(oError) {
-					reject(oError);
-					oModelPromise = null;
-				});
-				oModel.metadataLoaded().then(function() {
-					resolve(oModel);
-				});
+		oModelPromise ||= new Promise(function(resolve, reject) {
+			var oModel = new ODataModel("/sap/opu/odata/sap/APS_IAM_APP_SRV");
+			oModel.attachMetadataFailed(function(oError) {
+				reject(oError);
+				oModelPromise = null;
 			});
-		}
+			oModel.metadataLoaded().then(function() {
+				resolve(oModel);
+			});
+		});
 		return oModelPromise;
 	};
 
@@ -135,7 +139,7 @@ sap.ui.define([
 				reject(oError);
 			};
 
-			oModel.read("/aps_iam_app_ddl('" + sIamAppId + "')/to_BusinessCatalogAssignment", {success: fnSuccess, error: fnFailure});
+			oModel.read(`/aps_iam_app_ddl('${sIamAppId}')/to_BusinessCatalogAssignment`, {success: fnSuccess, error: fnFailure});
 		});
 	};
 

package/src/sap/ui/rta/appVariant/Utils.js

@@ -23,9 +23,9 @@ function(
 
 	var Utils = {};
 
-	var sModulePath = sap.ui.require.toUrl("sap/ui/rta/appVariant/manageApps/") + "webapp";
+	var sModulePath = `${sap.ui.require.toUrl("sap/ui/rta/appVariant/manageApps/")}webapp`;
 	var oI18n = ResourceBundle.create({
-		url: sModulePath + "/i18n/i18n.properties"
+		url: `${sModulePath}/i18n/i18n.properties`
 	});
 
 	Utils._checkNavigationSupported = function(oNavigationParams) {
@@ -35,7 +35,7 @@ function(
 			return oNavigationService.getLinks(oNavigationParams);
 		})
 		.catch(function(vError) {
-			throw new Error("Error retrieving ushell service CrossApplicationNavigation: " + vError);
+			throw new Error(`Error retrieving ushell service CrossApplicationNavigation: ${vError}`);
 		});
 	};
 
@@ -179,6 +179,7 @@ function(
 		// Adding the tooltip to every icon which is shown on the App Variant Overview Dialog
 		var sIconUrl = oAppVariantInfo.iconUrl;
 		if (sIconUrl && IconPool.isIconURI(sIconUrl)) {
+			// eslint-disable-next-line prefer-destructuring
 			oAppVariantInfo.iconText = sIconUrl.split("//")[1];
 		}
 

package/src/sap/ui/rta/appVariant/manageApps/webapp/Component.js

@@ -27,11 +27,12 @@ sap.ui.define([
 			}
 		},
 
-		constructor: function() {
-			_sIdRunningApp = arguments[1].idRunningApp;
-			_bKeyUser = arguments[1].isOverviewForKeyUser;
-			_sLayer = arguments[1].layer;
-			UIComponent.prototype.constructor.apply(this, arguments);
+		// eslint-disable-next-line object-shorthand
+		constructor: function(...aArgs) {
+			_sIdRunningApp = aArgs[1].idRunningApp;
+			_bKeyUser = aArgs[1].isOverviewForKeyUser;
+			_sLayer = aArgs[1].layer;
+			UIComponent.prototype.constructor.apply(this, aArgs);
 		},
 
 		/**
@@ -39,12 +40,12 @@ sap.ui.define([
 		 * @public
 		 * @override
 		 */
-		init: function() {
+		init(...aArgs) {
 			this.setIdRunningApp(_sIdRunningApp);
 			this.setIsOverviewForKeyUser(_bKeyUser);
 			this.setLayer(_sLayer);
 			// call the base component's init function
-			UIComponent.prototype.init.apply(this, arguments);
+			UIComponent.prototype.init.apply(this, aArgs);
 		}
 	});
 });