@openui5/sap.ui.rta 1.117.1 → 1.118.0

package/src/sap/ui/rta/plugin/RTAElementMover.js

@@ -35,13 +35,12 @@ function(
 	 * The RTAElementMover is responsible for the RTA specific adaptation of element movements.
 	 *
 	 * @author SAP SE
-	 * @version 1.117.1
+	 * @version 1.118.0
 	 *
 	 * @constructor
 	 * @private
 	 * @since 1.34
 	 * @alias sap.ui.rta.plugin.RTAElementMover
-	 * @experimental Since 1.34. This class is experimental and provides only limited functionality. Also the API might be changed in future.
 	 */
 	var RTAElementMover = ElementMover.extend("sap.ui.rta.plugin.RTAElementMover", /** @lends sap.ui.rta.plugin.RTAElementMover.prototype */ {
 		metadata: {
@@ -109,7 +108,7 @@ function(
 		// Direct children of template aggregations should not be movable
 		// because their order is defined based on the underlying data
 		var oElement = oOverlay.getElement();
-		if (ElementUtil.isElementDirectTemplateChild(oElement)) {
+		if (oElement.isDestroyStarted() || ElementUtil.isElementDirectTemplateChild(oElement)) {
 			return Promise.resolve(false);
 		}
 
@@ -121,11 +120,9 @@ function(
 
 		return this.isMoveAvailableOnRelevantContainer(oOverlay)
 		.then(function(bValid) {
-			if (bValid) {
-				bValid = this.oBasePlugin.hasStableId(oOverlay) &&
+			bValid &&= this.oBasePlugin.hasStableId(oOverlay) &&
 					this.oBasePlugin.hasStableId(oParentElementOverlay) &&
 					this.oBasePlugin.hasStableId(oRelevantContainerOverlay);
-			}
 			return bValid;
 		}.bind(this))
 		.then(function(bValid) {

package/src/sap/ui/rta/plugin/Remove.js

@@ -29,12 +29,11 @@ sap.ui.define([
 	 * @class The Remove allows trigger remove operations on the overlay
 	 * @extends sap.ui.rta.plugin.Plugin
 	 * @author SAP SE
-	 * @version 1.117.1
+	 * @version 1.118.0
 	 * @constructor
 	 * @private
 	 * @since 1.34
 	 * @alias sap.ui.rta.plugin.Remove
-	 * @experimental Since 1.34. This class is experimental and provides only limited functionality. Also the API might be changed in future.
 	 */
 	var Remove = Plugin.extend("sap.ui.rta.plugin.Remove", /** @lends sap.ui.rta.plugin.Remove.prototype */{
 		metadata: {
@@ -51,11 +50,12 @@ sap.ui.define([
 	 * @param {sap.ui.dt.Overlay} oOverlay overlay object
 	 * @override
 	 */
-	Remove.prototype.registerElementOverlay = function(oOverlay) {
+	Remove.prototype.registerElementOverlay = function(...aArgs) {
+		const [oOverlay] = aArgs;
 		if (this.isEnabled([oOverlay])) {
 			oOverlay.attachBrowserEvent("keydown", this._onKeyDown, this);
 		}
-		Plugin.prototype.registerElementOverlay.apply(this, arguments);
+		Plugin.prototype.registerElementOverlay.apply(this, aArgs);
 	};
 
 	/**
@@ -160,11 +160,12 @@ sap.ui.define([
 	 * @param {sap.ui.dt.Overlay} oOverlay overlay object
 	 * @override
 	 */
-	Remove.prototype.deregisterElementOverlay = function(oOverlay) {
+	Remove.prototype.deregisterElementOverlay = function(...aArgs) {
+		const [oOverlay] = aArgs;
 		if (this.isEnabled([oOverlay])) {
 			oOverlay.detachBrowserEvent("keydown", this._onKeyDown, this);
 		}
-		Plugin.prototype.deregisterElementOverlay.apply(this, arguments);
+		Plugin.prototype.deregisterElementOverlay.apply(this, aArgs);
 	};
 
 	/**
@@ -298,9 +299,7 @@ sap.ui.define([
 				}).shift();
 			}
 		}
-		if (!oNextOverlaySelection) {
-			oNextOverlaySelection = OverlayRegistry.getOverlay(aSelectedOverlays[0].getRelevantContainer());
-		}
+		oNextOverlaySelection ||= OverlayRegistry.getOverlay(aSelectedOverlays[0].getRelevantContainer());
 		return oNextOverlaySelection;
 	};
 

package/src/sap/ui/rta/plugin/Rename.js

@@ -28,14 +28,12 @@ sap.ui.define([
 	 * @extends sap.ui.rta.plugin.Plugin
 	 *
 	 * @author SAP SE
-	 * @version 1.117.1
+	 * @version 1.118.0
 	 *
 	 * @constructor
 	 * @private
 	 * @since 1.30
 	 * @alias sap.ui.rta.plugin.Rename
-	 * @experimental Since 1.30. This class is experimental and provides only limited functionality. Also the API might be
-	 *               changed in future.
 	 */
 	var Rename = Plugin.extend("sap.ui.rta.plugin.Rename", /** @lends sap.ui.rta.plugin.Rename.prototype */ {
 		metadata: {
@@ -61,8 +59,8 @@ sap.ui.define([
 	/**
 	 * @override
 	 */
-	Rename.prototype.exit = function() {
-		Plugin.prototype.exit.apply(this, arguments);
+	Rename.prototype.exit = function(...aArgs) {
+		Plugin.prototype.exit.apply(this, aArgs);
 
 		this.setBusy(false);
 		RenameHandler._exit.call(this);
@@ -150,10 +148,11 @@ sap.ui.define([
 	/**
 	 * @override
 	 */
-	Rename.prototype.registerElementOverlay = function(oOverlay) {
+	Rename.prototype.registerElementOverlay = function(...aArgs) {
+		const [oOverlay] = aArgs;
 		oOverlay.attachEvent("editableChange", RenameHandler._manageClickEvent, this);
 
-		Plugin.prototype.registerElementOverlay.apply(this, arguments);
+		Plugin.prototype.registerElementOverlay.apply(this, aArgs);
 	};
 
 	/**
@@ -168,11 +167,12 @@ sap.ui.define([
 	/**
 	 * @override
 	 */
-	Rename.prototype.deregisterElementOverlay = function(oOverlay) {
+	Rename.prototype.deregisterElementOverlay = function(...aArgs) {
+		const [oOverlay] = aArgs;
 		oOverlay.detachEvent("editableChange", RenameHandler._manageClickEvent, this);
 		oOverlay.detachBrowserEvent("click", RenameHandler._onClick, this);
 
-		Plugin.prototype.deregisterElementOverlay.apply(this, arguments);
+		Plugin.prototype.deregisterElementOverlay.apply(this, aArgs);
 	};
 
 	Rename.prototype.createRenameCommand = function(oElementOverlay, sNewText) {

package/src/sap/ui/rta/plugin/RenameHandler.js

@@ -39,14 +39,12 @@ sap.ui.define([
 	 * Provides Rename handling functionality
 	 *
 	 * @author SAP SE
-	 * @version 1.117.1
+	 * @version 1.118.0
 	 *
 	 * @constructor
 	 * @private
 	 * @since 1.52
 	 * @alias sap.ui.rta.plugin.RenameHandler
-	 * @experimental Since 1.52. This class is experimental and provides only limited functionality. Also the API might be
-	 * changed in future.
 	 */
 	var RenameHandler = {
 
@@ -55,7 +53,7 @@ sap.ui.define([
 		/**
 		 * @override
 		 */
-		_manageClickEvent: function(vEventOrElement) {
+		_manageClickEvent(vEventOrElement) {
 			var oOverlay = vEventOrElement.getSource ? vEventOrElement.getSource() : vEventOrElement;
 			if (oOverlay.isSelected() && this.isRenameAvailable(oOverlay) && this.isRenameEnabled([oOverlay])) {
 				oOverlay.attachBrowserEvent("click", RenameHandler._onClick, this);
@@ -64,7 +62,7 @@ sap.ui.define([
 			}
 		},
 
-		_setEditableFieldPosition: function() {
+		_setEditableFieldPosition() {
 			if (this._oEditableField) {
 				jQuery(this._oEditableField).offset({left: DOMUtil.getOffset(this._oEditableControlDomRef).left});
 				jQuery(this._oEditableField).offset({top: DOMUtil.getOffset(this._oEditableControlDomRef).top});
@@ -77,7 +75,7 @@ sap.ui.define([
 		 * @param {map} mPropertyBag - (required) contains required properties
 		 * @public
 		 */
-		startEdit: function(mPropertyBag) {
+		startEdit(mPropertyBag) {
 			this.setBusy(true);
 			this._oEditedOverlay = mPropertyBag.overlay;
 
@@ -150,7 +148,7 @@ sap.ui.define([
 			_oWrapperDomRef.classList.add("sapUiRtaEditableField");
 			_oWrapperDomRef.style.whiteSpace = "nowrap";
 			_oWrapperDomRef.style.overflow = "hidden";
-			_oWrapperDomRef.style.width = "calc(100% - (" + iWidthDifference + "px))";
+			_oWrapperDomRef.style.width = `calc(100% - (${iWidthDifference}px))`;
 			oOverlayForWrapper.getDomRef().append(_oWrapperDomRef);
 			var _oEditableFieldDomRef = document.createElement("div");
 			_oEditableFieldDomRef.setAttribute("contentEditable", "true");
@@ -230,14 +228,15 @@ sap.ui.define([
 			});
 		},
 
-		_setDesignTime: function(oDesignTime) {
+		_setDesignTime(...aArgs) {
+			const [oDesignTime] = aArgs;
 			this._aSelection = [];
 			var oOldDesignTime = this.getDesignTime();
 
 			if (oOldDesignTime) {
 				oOldDesignTime.getSelectionManager().detachChange(RenameHandler._onDesignTimeSelectionChange, this);
 			}
-			Plugin.prototype.setDesignTime.apply(this, arguments);
+			Plugin.prototype.setDesignTime.apply(this, aArgs);
 
 			if (oDesignTime) {
 				oDesignTime.getSelectionManager().attachChange(RenameHandler._onDesignTimeSelectionChange, this);
@@ -248,7 +247,7 @@ sap.ui.define([
 		/**
 		 * @override
 		 */
-		_onDesignTimeSelectionChange: function(oEvent) {
+		_onDesignTimeSelectionChange(oEvent) {
 			var aSelection = oEvent.getParameter("selection");
 
 			// detach events from previous selection
@@ -263,7 +262,7 @@ sap.ui.define([
 		 * @param {sap.ui.base.Event} oEvent - event object
 		 * @private
 		 */
-		_stopPropagation: function(oEvent) {
+		_stopPropagation(oEvent) {
 			oEvent.stopPropagation();
 		},
 
@@ -271,7 +270,7 @@ sap.ui.define([
 		 * @param {sap.ui.base.Event} oEvent - event object
 		 * @private
 		 */
-		_preventDefault: function(oEvent) {
+		_preventDefault(oEvent) {
 			oEvent.preventDefault();
 		},
 
@@ -279,7 +278,7 @@ sap.ui.define([
 		 * @param {sap.ui.base.Event} oEvent - event object
 		 * @private
 		 */
-		_onEditableFieldFocus: function(oEvent) {
+		_onEditableFieldFocus(oEvent) {
 			var el = oEvent.target;
 			var range = document.createRange();
 			range.selectNodeContents(el);
@@ -293,7 +292,7 @@ sap.ui.define([
 		 * @param {string} sPluginMethodName - method name of the plugin
 		 * @private
 		 */
-		_stopEdit: function(bRestoreFocus, sPluginMethodName) {
+		_stopEdit(bRestoreFocus, sPluginMethodName) {
 			var oOverlay;
 			this.setBusy(false);
 			this._oEditableField.removeEventListener("blur", this._oBlurHandler);
@@ -340,11 +339,11 @@ sap.ui.define([
 			});
 		},
 
-		_onEditableFieldBlur: function(oEvent) {
+		_onEditableFieldBlur(oEvent) {
 			return RenameHandler._handlePostRename.call(this, false, oEvent);
 		},
 
-		_handlePostRename: function(bRestoreFocus, oEvent) {
+		_handlePostRename(bRestoreFocus, oEvent) {
 			if (!this._bBlurOrKeyDownStarted) {
 				this._oEditedOverlay.removeStyleClass(RenameHandler.errorStyleClass);
 				this._bBlurOrKeyDownStarted = true;
@@ -375,7 +374,7 @@ sap.ui.define([
 			return Promise.resolve();
 		},
 
-		_handleInvalidRename: function(sErrorMessage, bRestoreFocus) {
+		_handleInvalidRename(sErrorMessage, bRestoreFocus) {
 			return Utils.showMessageBox("error", sErrorMessage, {
 				titleKey: "RENAME_ERROR_TITLE"
 			})
@@ -388,7 +387,7 @@ sap.ui.define([
 			}.bind(this));
 		},
 
-		_validateNewText: function() {
+		_validateNewText() {
 			var oResponsibleOverlay = this.getResponsibleElementOverlay(this._oEditedOverlay);
 			var oRenameAction = this.getAction(oResponsibleOverlay);
 			var sNewText = RenameHandler._getCurrentEditableFieldText.call(this);
@@ -396,7 +395,7 @@ sap.ui.define([
 			validateText(sNewText, this.getOldValue(), oRenameAction);
 		},
 
-		_onEditableFieldKeydown: function(oEvent) {
+		_onEditableFieldKeydown(oEvent) {
 			switch (oEvent.keyCode) {
 				case KeyCodes.ENTER:
 					// to prevent context menu from opening when rename is finished
@@ -421,7 +420,7 @@ sap.ui.define([
 		 * @returns {string} current editable field text
 		 * @private
 		 */
-		_getCurrentEditableFieldText: function() {
+		_getCurrentEditableFieldText() {
 			// Rename to empty string should not be possible
 			// to prevent issues with disappearing elements
 			var sText = this._oEditableField ? this._oEditableField.textContent.trim() : "";
@@ -432,7 +431,7 @@ sap.ui.define([
 		 * @param {sap.ui.base.Event} oEvent - event object
 		 * @private
 		 */
-		_onClick: function(oEvent) {
+		_onClick(oEvent) {
 			var oOverlay = sap.ui.getCore().byId(oEvent.currentTarget.id);
 			if (this.isRenameEnabled([oOverlay]) && !oEvent.metaKey && !oEvent.ctrlKey && !oEvent.shiftKey) {
 				this.startEdit(oOverlay);
@@ -440,7 +439,7 @@ sap.ui.define([
 			}
 		},
 
-		_exit: function() {
+		_exit() {
 			if (this._oEditableControlDomRef) {
 				this.stopEdit(false);
 			}

package/src/sap/ui/rta/plugin/Resize.js

@@ -27,12 +27,11 @@ sap.ui.define([
 	 * @class
 	 * @extends sap.ui.rta.plugin.Plugin
 	 * @author SAP SE
-	 * @version 1.117.1
+	 * @version 1.118.0
 	 * @constructor
 	 * @private
 	 * @since 1.101
 	 * @alias sap.ui.rta.plugin.Resize
-	 * @experimental Since 1.101. This class is experimental and provides only limited functionality. Also the API might be changed in future.
 	 */
 	var Resize = Plugin.extend("sap.ui.rta.plugin.Resize", /** @lends sap.ui.rta.plugin.Resize.prototype */ {
 		metadata: {
@@ -189,7 +188,7 @@ sap.ui.define([
 		// Initially set the current size of the element
 		var iNewWidth = getWidth(oOverlay);
 		// Place the middle of the handle on the mouse position
-		oHandle.style[sBeginDirection] = (iMousePosition - iOverlayBoundary) * iDirectionFactor - iHalfOffsetWidth + "px";
+		oHandle.style[sBeginDirection] = `${(iMousePosition - iOverlayBoundary) * iDirectionFactor - iHalfOffsetWidth}px`;
 
 		this.setDragging(true);
 		oOverlay.focus();
@@ -202,7 +201,7 @@ sap.ui.define([
 			var iHandleExtensionHeight = oAction.getHandleExtensionHeight(oElement);
 			oExtension = document.createElement("div");
 			oExtension.className = HANDLE_EXTENSION_CLASS_NAME;
-			oExtension.style.height = iHandleExtensionHeight + "px";
+			oExtension.style.height = `${iHandleExtensionHeight}px`;
 			oExtension.style["pointer-events"] = "none";
 		}
 
@@ -218,7 +217,7 @@ sap.ui.define([
 			iNewWidth = this._limitNewWidth(oOverlay, iNewWidth);
 
 			// The middle of the handle is on the mouse cursor
-			oHandle.style[sBeginDirection] = iNewWidth - oHandle.offsetWidth + "px";
+			oHandle.style[sBeginDirection] = `${iNewWidth - oHandle.offsetWidth}px`;
 		}
 
 		function onMouseUp() {
@@ -305,7 +304,7 @@ sap.ui.define([
 			var oNewHandle = document.createElement("div");
 			oNewHandle.className = HANDLE_CLASS_NAME;
 			oOverlayDomElement.append(oNewHandle);
-			oNewHandle.style[sBeginDirection] = oOverlayDomElement.clientWidth - oNewHandle.clientWidth + "px";
+			oNewHandle.style[sBeginDirection] = `${oOverlayDomElement.clientWidth - oNewHandle.clientWidth}px`;
 			oNewHandle.style["z-index"] = ZIndexManager.getNextZIndex();
 			oNewHandle.addEventListener("mousedown", this._onHandleMouseDown.bind(this, oOverlay));
 			this.setHandle(oNewHandle);
@@ -392,7 +391,8 @@ sap.ui.define([
 	 *
 	 * @override
 	 */
-	Resize.prototype.registerElementOverlay = function(oOverlay) {
+	Resize.prototype.registerElementOverlay = function(...aArgs) {
+		const [oOverlay] = aArgs;
 		if (this.isEnabled([oOverlay])) {
 			oOverlay.attachBrowserEvent("mousemove", this._onOverlayMouseMove, this);
 			oOverlay.attachBrowserEvent("mouseleave", this._onOverlayMouseLeave, this);
@@ -401,7 +401,7 @@ sap.ui.define([
 			oOverlay.attachEvent("selectionChange", this._onOverlaySelectionChange, this);
 			oOverlay.attachEvent("geometryChanged", this._onOverlayGeometryChanged, this);
 		}
-		Plugin.prototype.registerElementOverlay.apply(this, arguments);
+		Plugin.prototype.registerElementOverlay.apply(this, aArgs);
 	};
 
 	/**
@@ -410,14 +410,15 @@ sap.ui.define([
 	 *
 	 * @override
 	 */
-	Resize.prototype.deregisterElementOverlay = function(oOverlay) {
+	Resize.prototype.deregisterElementOverlay = function(...aArgs) {
+		const [oOverlay] = aArgs;
 		oOverlay.detachBrowserEvent("mousemove", this._onOverlayMouseMove, this);
 		oOverlay.detachBrowserEvent("mouseleave", this._onOverlayMouseLeave, this);
 		oOverlay.detachBrowserEvent("keydown", this._onOverlayKeyDown, this);
 		oOverlay.detachBrowserEvent("focus", this._onOverlayFocus, this);
 		oOverlay.detachEvent("selectionChange", this._onOverlaySelectionChange, this);
 		oOverlay.detachEvent("geometryChanged", this._onOverlayGeometryChanged, this);
-		Plugin.prototype.deregisterElementOverlay.apply(this, arguments);
+		Plugin.prototype.deregisterElementOverlay.apply(this, aArgs);
 	};
 
 	/**

package/src/sap/ui/rta/plugin/Selection.js

@@ -5,20 +5,24 @@
  */
 
 sap.ui.define([
-	"sap/ui/rta/plugin/Plugin",
-	"sap/ui/rta/Utils",
+	"sap/base/util/restricted/_intersection",
+	"sap/m/InstanceManager",
+	"sap/ui/dt/DOMUtil",
 	"sap/ui/dt/OverlayRegistry",
+	"sap/ui/dt/OverlayUtil",
 	"sap/ui/events/KeyCodes",
-	"sap/base/util/restricted/_intersection",
-	"sap/m/InstanceManager"
+	"sap/ui/rta/plugin/Plugin",
+	"sap/ui/rta/Utils"
 ],
 function(
-	Plugin,
-	Utils,
+	_intersection,
+	InstanceManager,
+	DOMUtil,
 	OverlayRegistry,
+	OverlayUtil,
 	KeyCodes,
-	_intersection,
-	InstanceManager
+	Plugin,
+	Utils
 ) {
 	"use strict";
 
@@ -30,12 +34,11 @@ function(
 	 * @class The Selection plugin allows you to select or focus overlays with mouse or keyboard and navigate to others.
 	 * @extends sap.ui.rta.plugin.Plugin
 	 * @author SAP SE
-	 * @version 1.117.1
+	 * @version 1.118.0
 	 * @constructor
 	 * @private
 	 * @since 1.34
 	 * @alias sap.ui.rta.plugin.Selection
-	 * @experimental Since 1.34. This class is experimental and provides only limited functionality. Also the API might be changed in future.
 	 */
 	var Selection = Plugin.extend("sap.ui.rta.plugin.Selection", {
 		metadata: {
@@ -95,9 +98,23 @@ function(
 		});
 	}
 
-	Selection.prototype.init = function() {
+	// If a parent overlay is movable it should not be draggable by a non-movable child
+	function setOrResetFirstParentMovable(oOverlay, bSet) {
+		if (bSet) {
+			const oFirstMovableParentOverlay = OverlayUtil.getFirstMovableParentOverlay(oOverlay);
+			if (oFirstMovableParentOverlay) {
+				oOverlay._firstMovableParentOverlay = oFirstMovableParentOverlay;
+				oFirstMovableParentOverlay.setMovable(false);
+			}
+		} else if (oOverlay._firstMovableParentOverlay) {
+			oOverlay._firstMovableParentOverlay.setMovable(true);
+			delete oOverlay._firstMovableParentOverlay;
+		}
+	}
+
+	Selection.prototype.init = function(...aArgs) {
 		this._multiSelectionValidator = this._multiSelectionValidator.bind(this);
-		Plugin.prototype.init.apply(this, arguments);
+		Plugin.prototype.init.apply(this, aArgs);
 	};
 
 	/**
@@ -325,6 +342,7 @@ function(
 			return;
 		}
 		if (oOverlay.isSelectable()) {
+			setOrResetFirstParentMovable(oOverlay, true);
 			if (oOverlay !== this._oHoverTarget) {
 				this._removePreviousHover();
 				this._oHoverTarget = oOverlay;
@@ -349,6 +367,7 @@ function(
 			return;
 		}
 		if (oOverlay.isSelectable()) {
+			setOrResetFirstParentMovable(oOverlay);
 			this._removePreviousHover();
 			preventEventDefaultAndPropagation(oEvent);
 		}
@@ -368,14 +387,14 @@ function(
 	/**
 	 * @override
 	 */
-	Selection.prototype.setDesignTime = function() {
+	Selection.prototype.setDesignTime = function(...aArgs) {
 		// detach from listener from old DesignTime instance
 		if (this.getDesignTime()) {
 			this.getDesignTime().getSelectionManager().removeValidator(this._multiSelectionValidator);
 		}
 
 		// set new DesignTime instance in parent class
-		Plugin.prototype.setDesignTime.apply(this, arguments);
+		Plugin.prototype.setDesignTime.apply(this, aArgs);
 
 		// attach listener back to the new DesignTime instance
 		if (this.getDesignTime()) {

package/src/sap/ui/rta/plugin/Settings.js

@@ -25,12 +25,11 @@ sap.ui.define([
 	 * @class The Settings allows trigger change of settings operations on the overlay
 	 * @extends sap.ui.rta.plugin.Plugin
 	 * @author SAP SE
-	 * @version 1.117.1
+	 * @version 1.118.0
 	 * @constructor
 	 * @private
 	 * @since 1.44
 	 * @alias sap.ui.rta.plugin.Settings
-	 * @experimental Since 1.44. This class is experimental and provides only limited functionality. Also the API might be changed in future.
 	 */
 	var Settings = Plugin.extend("sap.ui.rta.plugin.Settings", /** @lends sap.ui.rta.plugin.Settings.prototype */ {
 		metadata: {
@@ -185,6 +184,7 @@ sap.ui.define([
 				} else if (mChangeSpecificData.appDescriptorChangeType) {
 					return this._handleAppDescriptorChangeCommand(mChange, oElement, oCompositeCommand);
 				}
+				return undefined;
 			}, this);
 		}.bind(this))
 
@@ -211,15 +211,13 @@ sap.ui.define([
 	 * @return {Promise} Returns promise resolving with the creation of the commands
 	 */
 	Settings.prototype.handler = function(aElementOverlays, mPropertyBag, oSettingsAction) {
-		mPropertyBag = mPropertyBag || {};
+		mPropertyBag ||= {};
 		var oElement = aElementOverlays[0].getElement();
-		var fnHandler = mPropertyBag.fnHandler;
+		var {fnHandler} = mPropertyBag;
 
+		fnHandler ||= aElementOverlays[0].getDesignTimeMetadata().getAction("settings").handler;
 		if (!fnHandler) {
-			fnHandler = aElementOverlays[0].getDesignTimeMetadata().getAction("settings").handler;
-			if (!fnHandler) {
-				throw new Error("Handler not found for settings action");
-			}
+			throw new Error("Handler not found for settings action");
 		}
 		mPropertyBag.getUnsavedChanges = this._getUnsavedChanges.bind(this);
 		mPropertyBag.styleClass = Utils.getRtaStyleClassName();
@@ -230,6 +228,7 @@ sap.ui.define([
 			if (aChanges.length > 0) {
 				return this._handleCompositeCommand(aElementOverlays, oElement, aChanges, oSettingsAction);
 			}
+			return undefined;
 		}.bind(this))
 
 		.catch(function(vError) {
@@ -285,14 +284,14 @@ sap.ui.define([
 							|| this.isEnabled([oElementOverlay])
 						),
 						handler: function(fnHandler, aElementOverlays, mPropertyBag) {
-							mPropertyBag = mPropertyBag || {};
+							mPropertyBag ||= {};
 							mPropertyBag.fnHandler = fnHandler;
 							return this.handler(aElementOverlays, mPropertyBag, oSettingsAction);
 						}.bind(this, oSettingsAction.handler),
 						submenu: formatSubMenuItems(oSettingsAction.submenu)
 					});
 				} else {
-					BaseLog.warning("Handler not found for settings action '" + sSettingsAction + "' or relevant container has no stable id");
+					BaseLog.warning(`Handler not found for settings action '${sSettingsAction}' or relevant container has no stable id`);
 				}
 			}, this);
 		}
@@ -304,13 +303,14 @@ sap.ui.define([
 		if (aSubMenu) {
 			return aSubMenu.map(function(oSubMenu, iIndex) {
 				return {
-					id: oSubMenu.key || sPluginId + "_SUB_" + iIndex,
+					id: oSubMenu.key || `${sPluginId}_SUB_${iIndex}`,
 					icon: oSubMenu.icon || "blank",
 					text: oSubMenu.name || "",
 					enabled: oSubMenu.hasOwnProperty("enabled") ? oSubMenu.enabled : true
 				};
 			});
 		}
+		return undefined;
 	}
 
 	function getActionIcon(oSettingsAction) {

package/src/sap/ui/rta/plugin/Split.js

@@ -23,12 +23,11 @@ sap.ui.define([
 	 * @class
 	 * @extends sap.ui.rta.plugin.Plugin
 	 * @author SAP SE
-	 * @version 1.117.1
+	 * @version 1.118.0
 	 * @constructor
 	 * @private
 	 * @since 1.46
 	 * @alias sap.ui.rta.plugin.Split
-	 * @experimental Since 1.46. This class is experimental and provides only limited functionality. Also the API might be changed in future.
 	 */
 	var Split = Plugin.extend("sap.ui.rta.plugin.Split", /** @lends sap.ui.rta.plugin.Split.prototype */ {
 		metadata: {