@openui5/sap.ui.rta 1.117.1 → 1.118.0

package/src/sap/ui/rta/toolbar/translation/Translation.js

@@ -35,8 +35,8 @@ sap.ui.define([
 		var sErrorMessage = vError.userMessage || vError.stack || vError.message || vError.status || vError;
 		var oTextResources = sap.ui.getCore().getLibraryResourceBundle("sap.ui.rta");
 		Log.error(sErrorMessage);
-		var sMsg = oTextResources.getText("MSG_LREP_TRANSFER_ERROR") + "\n"
-			+ oTextResources.getText("MSG_ERROR_REASON", sErrorMessage);
+		var sMsg = `${oTextResources.getText("MSG_LREP_TRANSFER_ERROR")}\n${
+			 oTextResources.getText("MSG_ERROR_REASON", sErrorMessage)}`;
 		MessageBox.error(sMsg, {
 			styleClass: Utils.getRtaStyleClassName()
 		});
@@ -49,7 +49,7 @@ sap.ui.define([
 	 * @class
 	 *
 	 * @author SAP SE
-	 * @version 1.117.1
+	 * @version 1.118.0
 	 *
 	 * @constructor
 	 * @private
@@ -64,8 +64,9 @@ sap.ui.define([
 				}
 			}
 		},
-		constructor: function() {
-			ManagedObject.prototype.constructor.apply(this, arguments);
+		// eslint-disable-next-line object-shorthand
+		constructor: function(...aArgs) {
+			ManagedObject.prototype.constructor.apply(this, aArgs);
 			this._oTranslationModel = new JSONModel(getInitialTranslationModelData());
 		}
 	});
@@ -74,7 +75,7 @@ sap.ui.define([
 		var oModel = oEvent.getSource().getModel("translation");
 		var sSourceLanguage = oModel.getProperty("/sourceLanguage");
 		var sTargetLanguage = oModel.getProperty("/targetLanguage");
-		var sFileName = sSourceLanguage + "_" + sTargetLanguage + "_" + "TranslationXLIFF";
+		var sFileName = `${sSourceLanguage}_${sTargetLanguage}_` + `TranslationXLIFF`;
 
 		var mPropertyBag = {
 			layer: Layer.CUSTOMER,
@@ -106,7 +107,7 @@ sap.ui.define([
 	Translation.prototype._createDownloadTranslationDialog = function() {
 		return Fragment.load({
 			name: "sap.ui.rta.toolbar.translation.DownloadTranslationDialog",
-			id: this.getToolbar().getId() + "_download_translation_fragment",
+			id: `${this.getToolbar().getId()}_download_translation_fragment`,
 			controller: {
 				onDownloadFile: downloadFile.bind(this),
 				onCancelDownloadDialog: function() {
@@ -122,7 +123,7 @@ sap.ui.define([
 	};
 
 	Translation.prototype._createUploadTranslationDialog = function() {
-		var sUploadId = this.getToolbar().getId() + "_upload_translation_fragment";
+		var sUploadId = `${this.getToolbar().getId()}_upload_translation_fragment`;
 		return Fragment.load({
 			name: "sap.ui.rta.toolbar.translation.UploadTranslationDialog",
 			id: sUploadId,
@@ -130,8 +131,8 @@ sap.ui.define([
 				onCancelUploadDialog: function() {
 					this._oUploadDialog.close();
 				}.bind(this),
-				formatUploadEnabled: function() {
-					var oFileUploader = sap.ui.getCore().byId(sUploadId + "--fileUploader");
+				formatUploadEnabled() {
+					var oFileUploader = sap.ui.getCore().byId(`${sUploadId}--fileUploader`);
 					return oFileUploader.checkFileReadable();
 				},
 				saveFiles: function(oEvent) {
@@ -148,7 +149,7 @@ sap.ui.define([
 	};
 
 	function handleUploadPress(sUploadId) {
-		var oFileUploader = sap.ui.getCore().byId(sUploadId + "--fileUploader");
+		var oFileUploader = sap.ui.getCore().byId(`${sUploadId}--fileUploader`);
 		oFileUploader.checkFileReadable().then(function() {
 			if (this._oTranslationModel.getProperty("/file")) {
 				var mPropertyBag = {
@@ -207,9 +208,7 @@ sap.ui.define([
 	};
 
 	Translation.prototype.openUploadTranslationDialog = function() {
-		if (!this._oUploadDialogPromise) {
-			this._oUploadDialogPromise = this._createUploadTranslationDialog();
-		}
+		this._oUploadDialogPromise ||= this._createUploadTranslationDialog();
 		return this._oUploadDialogPromise.then(function(oUploadDialog) {
 			this.getToolbar().addDependent(oUploadDialog);
 			return oUploadDialog.open();

package/src/sap/ui/rta/toolbar/versioning/Versioning.js

@@ -25,7 +25,7 @@ sap.ui.define([
 ) {
 	"use strict";
 
-	var MessageType = coreLibrary.MessageType;
+	var {MessageType} = coreLibrary;
 	var DRAFT_ACCENT_COLOR = "sapUiRtaDraftVersionAccent";
 	var ACTIVE_ACCENT_COLOR = "sapUiRtaActiveVersionAccent";
 
@@ -36,7 +36,7 @@ sap.ui.define([
 	 * @class
 	 *
 	 * @author SAP SE
-	 * @version 1.117.1
+	 * @version 1.118.0
 	 *
 	 * @constructor
 	 * @private
@@ -51,8 +51,9 @@ sap.ui.define([
 				}
 			}
 		},
-		constructor: function() {
-			ManagedObject.prototype.constructor.apply(this, arguments);
+		// eslint-disable-next-line object-shorthand
+		constructor: function(...aArgs) {
+			ManagedObject.prototype.constructor.apply(this, aArgs);
 			this.oTextResources = this.getToolbar().getTextResources();
 		}
 	});
@@ -121,15 +122,19 @@ sap.ui.define([
 			// in case of "Original App" and "Draft" no timestamp is set
 			return "";
 		}
-
+		if (sTimeStamp.indexOf("Z") === -1) {
+			sTimeStamp = `${sTimeStamp}Z`;
+		}
 		return DateFormat.getInstance({
 			format: "yMMMdjm"
-		}).format(new Date(sTimeStamp + "Z"));
+		}).format(new Date(sTimeStamp));
 	}
 
 	function getGroupHeaderFactory(oGroup) {
 		return new GroupHeaderListItem({
-			title: oGroup.key ? this.oTextResources.getText("TIT_VERSION_HISTORY_PUBLISHED") : this.oTextResources.getText("TIT_VERSION_HISTORY_UNPUBLISHED"),
+			title: oGroup.key
+				? this.oTextResources.getText("TIT_VERSION_HISTORY_PUBLISHED")
+				: this.oTextResources.getText("TIT_VERSION_HISTORY_UNPUBLISHED"),
 			upperCase: false,
 			visible: this.getToolbar().getModel("versions").getProperty("/publishVersionVisible")
 		}).addStyleClass("sapUiRtaVersionHistoryGrouping").addStyleClass("sapUiRtaVersionHistory");
@@ -154,7 +159,7 @@ sap.ui.define([
 	Versioning.prototype.formatVersionButtonText = function(aVersions, sDisplayedVersion) {
 		var sText = "";
 		var sType = "Active";
-		aVersions = aVersions || [];
+		aVersions ||= [];
 
 		if (sDisplayedVersion === undefined || sDisplayedVersion === Version.Number.Original) {
 			sText = this.oTextResources.getText("TIT_ORIGINAL_APP");
@@ -191,25 +196,23 @@ sap.ui.define([
 	Versioning.prototype.showVersionHistory = function(oEvent) {
 		var oVersionButton = oEvent.getSource();
 
-		if (!this._oVersionHistoryDialogPromise) {
-			this._oVersionHistoryDialogPromise = Fragment.load({
-				name: "sap.ui.rta.toolbar.versioning.VersionHistory",
-				id: this.getToolbar().getId() + "_fragment--sapUiRta_versionHistoryDialog",
-				controller: {
-					formatVersionTitle: formatVersionTitle.bind(this),
-					formatVersionTimeStamp: formatVersionTimeStamp,
-					formatHighlight: formatHighlight,
-					formatHighlightText: formatHighlightText.bind(this),
-					formatOriginalAppHighlight: formatOriginalAppHighlight,
-					formatOriginalAppHighlightText: formatOriginalAppHighlightText.bind(this),
-					versionSelected: versionSelected.bind(this),
-					getGroupHeaderFactory: getGroupHeaderFactory.bind(this)
-				}
-			}).then(function(oDialog) {
-				this.getToolbar().addDependent(oDialog);
-				return oDialog;
-			}.bind(this));
-		}
+		this._oVersionHistoryDialogPromise ||= Fragment.load({
+			name: "sap.ui.rta.toolbar.versioning.VersionHistory",
+			id: `${this.getToolbar().getId()}_fragment--sapUiRta_versionHistoryDialog`,
+			controller: {
+				formatVersionTitle: formatVersionTitle.bind(this),
+				formatVersionTimeStamp,
+				formatHighlight,
+				formatHighlightText: formatHighlightText.bind(this),
+				formatOriginalAppHighlight,
+				formatOriginalAppHighlightText: formatOriginalAppHighlightText.bind(this),
+				versionSelected: versionSelected.bind(this),
+				getGroupHeaderFactory: getGroupHeaderFactory.bind(this)
+			}
+		}).then(function(oDialog) {
+			this.getToolbar().addDependent(oDialog);
+			return oDialog;
+		}.bind(this));
 
 		return this._oVersionHistoryDialogPromise.then(function(oVersionsDialog) {
 			if (!oVersionsDialog.isOpen()) {
@@ -232,7 +235,7 @@ sap.ui.define([
 		if (!this._oActivateVersionDialogPromise) {
 			this._oActivateVersionDialogPromise = Fragment.load({
 				name: "sap.ui.rta.toolbar.versioning.VersionTitleDialog",
-				id: this.getToolbar().getId() + "_fragment--sapUiRta_activateVersionDialog",
+				id: `${this.getToolbar().getId()}_fragment--sapUiRta_activateVersionDialog`,
 				controller: {
 					onConfirmVersioningDialog: function() {
 						var sVersionTitle = this.getToolbar().getControl("activateVersionDialog--versionTitleInput").getValue();

package/src/sap/ui/rta/util/Animation.js

@@ -28,9 +28,7 @@ function() {
 			// perform animation in the next animation frame, normally 16-17ms later.
 			var iTimestampInitial;
 			var fnAnimCallback = function(iTimestamp) {
-				if (!iTimestampInitial) {
-					iTimestampInitial = iTimestamp;
-				}
+				iTimestampInitial ||= iTimestamp;
 				if (iTimestamp !== iTimestampInitial) {
 					fnCallback();
 				} else {

package/src/sap/ui/rta/util/PluginManager.js

@@ -68,13 +68,11 @@ sap.ui.define([
 	 * Constructor for a new sap.ui.rta.util.PluginManager
 	 * @extends sap.ui.base.ManagedObject
 	 * @author SAP SE
-	 * @version 1.117.1
+	 * @version 1.118.0
 	 * @constructor
 	 * @private
 	 * @since 1.86
 	 * @alias sap.ui.rta.util.PluginManager
-	 * @experimental Since 1.86. This class is experimental and provides only limited functionality. Also the API might
-	 *               be changed in future.
 	 */
 	var PluginManager = ManagedObject.extend("sap.ui.rta.util.PluginManager", {
 		metadata: {

package/src/sap/ui/rta/util/PopupManager.js

@@ -42,13 +42,11 @@ sap.ui.define([
 	 * Constructor for a new sap.ui.rta.util.PopupManager
 	 * @extends sap.ui.base.ManagedObject
 	 * @author SAP SE
-	 * @version 1.117.1
+	 * @version 1.118.0
 	 * @constructor
 	 * @private
 	 * @since 1.48
 	 * @alias sap.ui.rta.util.PopupManager
-	 * @experimental Since 1.48. This class is experimental and provides only limited functionality. Also the API might
-	 *               be changed in future.
 	 */
 	var PopupManager = ManagedObject.extend("sap.ui.rta.util.PopupManager", {
 		metadata: {
@@ -144,7 +142,8 @@ sap.ui.define([
 	};
 
 	/**
-	 * Filters the passed array and returns an object containing list of adaptable popups and all supported popup controls (also includes non-adaptable popups).
+	 * Filters the passed array and returns an object containing list of adaptable popups and all supported
+	 * popup controls (also includes non-adaptable popups).
 	 *
 	 * @param {sap.ui.core.Popup[]} aOpenPopups Specifies open popups
 	 * @returns {object} Returns an object containing all adaptation relevant popups and all supported popup controls
@@ -160,6 +159,7 @@ sap.ui.define([
 				// all modal type popups are supported for which modal property is later turned true, when in Adaptation mode
 				aAllSupportedPopups.push(oPopupElement);
 			}
+			return undefined;
 		}.bind(this));
 
 		return {
@@ -183,6 +183,7 @@ sap.ui.define([
 					if (oContent instanceof ComponentContainer) {
 						return this.oRtaRootAppComponent === this._getAppComponentForControl(Component.get(oContent.getComponent()));
 					}
+					return undefined;
 				}.bind(this))
 			: false;
 	};
@@ -250,9 +251,11 @@ sap.ui.define([
 			}
 		};
 
-		sNewMode === "navigation"
-			? this._applyPatchesToOpenPopups(_curry(fnApplyFocusAndSetModal)(sNewMode))
-			: this._removePatchesToOpenPopups(_curry(fnApplyFocusAndSetModal)(sNewMode));
+		if (sNewMode === "navigation") {
+			this._applyPatchesToOpenPopups(_curry(fnApplyFocusAndSetModal)(sNewMode));
+		} else {
+			this._removePatchesToOpenPopups(_curry(fnApplyFocusAndSetModal)(sNewMode));
+		}
 	};
 
 	/**
@@ -314,8 +317,9 @@ sap.ui.define([
 	 * @private
 	 */
 	PopupManager.prototype._overrideAddFunctions = function(fnOriginalFunction) {
-		return function(oPopupElement) {
-			var vOriginalReturn = fnOriginalFunction.apply(InstanceManager, arguments);
+		return function(...aArgs) {
+			const [oPopupElement] = aArgs;
+			var vOriginalReturn = fnOriginalFunction.apply(InstanceManager, aArgs);
 			if (this._isSupportedPopup(oPopupElement)) {
 				if (this._isPopupAdaptable(oPopupElement)
 					&& this.getRta()._oDesignTime) {
@@ -389,7 +393,7 @@ sap.ui.define([
 	 */
 	PopupManager.prototype._applyPopupPatch = function(oPopupElement) {
 		var oOverlayContainer = Overlay.getOverlayContainer();
-		var oPopup = oPopupElement.oPopup;
+		var {oPopup} = oPopupElement;
 		var aAutoCloseAreas = [
 			oPopup.oContent.getDomRef(),
 			oOverlayContainer.get(0)
@@ -413,11 +417,9 @@ sap.ui.define([
 		oPopup.setExtraContent(aAutoCloseAreas);
 
 		// cases when onAfterRendering is called after this function - app inside popup
-		if (!this.fnOriginalPopupOnAfterRendering) {
-			this.fnOriginalPopupOnAfterRendering = oPopup.onAfterRendering;
-		}
-		oPopup.onAfterRendering = function() {
-			var vOriginalReturn = this.fnOriginalPopupOnAfterRendering.apply(oPopup, arguments);
+		this.fnOriginalPopupOnAfterRendering ||= oPopup.onAfterRendering;
+		oPopup.onAfterRendering = function(...aArgs) {
+			var vOriginalReturn = this.fnOriginalPopupOnAfterRendering.apply(oPopup, aArgs);
 			oPopup[this._getFocusEventName("remove")]();
 			return vOriginalReturn;
 		}.bind(this);
@@ -451,8 +453,9 @@ sap.ui.define([
 	 * @private
 	 */
 	PopupManager.prototype._overrideRemoveFunctions = function(fnOriginalFunction) {
-		return function(oPopupElement) {
-			var vOriginalReturn = fnOriginalFunction.apply(InstanceManager, arguments);
+		return function(...aArgs) {
+			const [oPopupElement] = aArgs;
+			var vOriginalReturn = fnOriginalFunction.apply(InstanceManager, aArgs);
 			if (this._isSupportedPopup(oPopupElement)) {
 				if (this._isPopupAdaptable(oPopupElement)
 					&& this.getRta()._oDesignTime) {
@@ -548,7 +551,8 @@ sap.ui.define([
 	};
 
 	/**
-	 * Restores the Instance Manager AddDialogInstance/AddPopoverInstance, RemoveDialogInstance/RemovePopoverInstance methods and default blur event for popups
+	 * Restores the Instance Manager AddDialogInstance/AddPopoverInstance, RemoveDialogInstance/RemovePopoverInstance
+	 * methods and default blur event for popups
 	 *
 	 * @private
 	 */
@@ -579,7 +583,7 @@ sap.ui.define([
 	 * @private
 	 */
 	PopupManager.prototype._removePopupPatch = function(oPopupElement) {
-		var oPopup = oPopupElement.oPopup;
+		var {oPopup} = oPopupElement;
 		oPopup[this._getFocusEventName("add")]();
 		if (this.fnOriginalPopupOnAfterRendering) {
 			oPopup.onAfterRendering = this.fnOriginalPopupOnAfterRendering;

package/src/sap/ui/rta/util/ReloadManager.js

@@ -30,7 +30,7 @@ sap.ui.define([
 	 * @namespace sap.ui.rta.util.ReloadManager
 	 * @alias sap.ui.rta.util.ReloadManager
 	 * @since 1.104
-	 * @version 1.117.1
+	 * @version 1.118.0
 	 * @private
 	 * @ui5-restricted
 	 */
@@ -211,7 +211,7 @@ sap.ui.define([
 	ReloadManager.enableAutomaticStart = function(sLayer, oRootControl) {
 		var sFlexReference = FlexRuntimeInfoAPI.getFlexReference({element: oRootControl});
 		var vParameter = sFlexReference || true;
-		window.sessionStorage.setItem("sap.ui.rta.restart." + sLayer, vParameter);
+		window.sessionStorage.setItem(`sap.ui.rta.restart.${sLayer}`, vParameter);
 	};
 
 	/**
@@ -220,7 +220,7 @@ sap.ui.define([
 	 * @param {sap.ui.fl.Layer} sLayer - Active layer
 	 */
 	ReloadManager.disableAutomaticStart = function(sLayer) {
-		window.sessionStorage.removeItem("sap.ui.rta.restart." + sLayer);
+		window.sessionStorage.removeItem(`sap.ui.rta.restart.${sLayer}`);
 	};
 
 	/**
@@ -230,7 +230,7 @@ sap.ui.define([
 	 * @returns {boolean} <code>true</code> if restart is needed
 	 */
 	ReloadManager.needsAutomaticStart = function(sLayer) {
-		return !!window.sessionStorage.getItem("sap.ui.rta.restart." + sLayer);
+		return !!window.sessionStorage.getItem(`sap.ui.rta.restart.${sLayer}`);
 	};
 
 	/**

package/src/sap/ui/rta/util/ServiceEventBus.js

@@ -19,7 +19,7 @@ function(
 	 *
 	 * @extends sap.ui.core.EventBus
 	 * @author SAP SE
-	 * @version 1.117.1
+	 * @version 1.118.0
 	 * @private
 	 * @since 1.56.0
 	 * @alias sap.ui.rta.util.ServiceEventBus

package/src/sap/ui/rta/util/changeVisualization/ChangeIndicator.js

@@ -42,7 +42,7 @@ sap.ui.define([
 	 * @alias sap.ui.rta.util.changeVisualization.ChangeIndicator
 	 * @author SAP SE
 	 * @since 1.84.0
-	 * @version 1.117.1
+	 * @version 1.118.0
 	 * @private
 	 */
 	var ChangeIndicator = Control.extend("sap.ui.rta.util.changeVisualization.ChangeIndicator", {
@@ -115,7 +115,7 @@ sap.ui.define([
 		},
 		renderer: {
 			apiVersion: 2,
-			render: function(oRm, oControl) {
+			render(oRm, oControl) {
 				oRm.openStart("div", oControl);
 				oRm.class("sapUiRtaChangeIndicator");
 				oRm.class("sapUiRtaChangeIndicatorChange");
@@ -132,7 +132,7 @@ sap.ui.define([
 				}
 				oRm.openEnd();
 				if (sTooltip) {
-					oRm.openStart("span", oControl.getId() + "-tooltip");
+					oRm.openStart("span", `${oControl.getId()}-tooltip`);
 					oRm.class("sapUiInvisibleText");
 					oRm.openEnd();
 					oRm.text(sTooltip);
@@ -141,12 +141,13 @@ sap.ui.define([
 				oRm.close("div");
 			}
 		},
-		constructor: function() {
+		// eslint-disable-next-line object-shorthand
+		constructor: function(...aArgs) {
 			this._oDetailModel = new JSONModel();
 			this._oDetailModel.setDefaultBindingMode("OneWay");
 			this._fnHoverTrue = this._setHoverStyleClasses.bind(this, true);
 			this._fnHoverFalse = this._setHoverStyleClasses.bind(this, false);
-			Control.prototype.constructor.apply(this, arguments);
+			Control.prototype.constructor.apply(this, aArgs);
 			// is needed to prevent that multiple events listeners are attached
 			// to the same overlay because setVisible is called multiple times
 			this._bEventAttachedToElement = false;
@@ -216,17 +217,17 @@ sap.ui.define([
 		} else {
 			var sShortenedElementLabel = ChangeVisualizationUtils.shortenString(sElementLabel);
 			var sChangeTextKey = (
-				"TXT_CHANGEVISUALIZATION_CHANGE_"
-				+ sCommandName.toUpperCase()
+				`TXT_CHANGEVISUALIZATION_CHANGE_${
+				 sCommandName.toUpperCase()}`
 			);
-			sDescriptionText = oRtaResourceBundle.getText(sChangeTextKey, sShortenedElementLabel);
-			sDescriptionTooltip = oRtaResourceBundle.getText(sChangeTextKey, sElementLabel);
+			sDescriptionText = oRtaResourceBundle.getText(sChangeTextKey, [sShortenedElementLabel]);
+			sDescriptionTooltip = oRtaResourceBundle.getText(sChangeTextKey, [sElementLabel]);
 		}
 		sDescriptionTooltip = sDescriptionText.length < sDescriptionTooltip.length ? sDescriptionTooltip : null;
 		var sDetailButtonText = oDescription && oDescription.buttonText;
 		var sIconTooltip = oRtaResourceBundle.getText(
-			"TXT_CHANGEVISUALIZATION_OVERVIEW_"
-			+ mChangeInformation.changeCategory.toUpperCase()
+			`TXT_CHANGEVISUALIZATION_OVERVIEW_${
+			 mChangeInformation.changeCategory.toUpperCase()}`
 		);
 
 		return {
@@ -271,8 +272,9 @@ sap.ui.define([
 		handleBrowserEventsOnIndicator.call(this, this, "attachBrowserEvent");
 	};
 
-	ChangeIndicator.prototype.setVisible = function(bVisible) {
-		Control.prototype.setVisible.apply(this, arguments);
+	ChangeIndicator.prototype.setVisible = function(...aArgs) {
+		const [bVisible] = aArgs;
+		Control.prototype.setVisible.apply(this, aArgs);
 		var oOverlay = Core.byId(this.getOverlayId());
 		// needed because the change indicator cleanup is only triggered on save and exit
 		if (oOverlay) {
@@ -291,10 +293,10 @@ sap.ui.define([
 		return this;
 	};
 
-	ChangeIndicator.prototype.focus = function() {
+	ChangeIndicator.prototype.focus = function(...aArgs) {
 		if (this.getDomRef()) {
 			// Element is rendered, focus immediately
-			Control.prototype.focus.apply(this, arguments);
+			Control.prototype.focus.apply(this, aArgs);
 			this._bScheduledForFocus = false;
 			return;
 		}
@@ -405,7 +407,7 @@ sap.ui.define([
 			this._iOldTabIndex = this.getDomRef().getAttribute("tabindex");
 			Fragment.load({
 				name: "sap.ui.rta.util.changeVisualization.ChangeIndicatorPopover",
-				id: this.sId + "Info",
+				id: `${this.sId}Info`,
 				controller: this
 			}).then(function(oPopover) {
 				oPopover._bOpenedByChangeIndicator = true;

package/src/sap/ui/rta/util/changeVisualization/ChangeIndicatorRegistry.js

@@ -39,7 +39,7 @@ sap.ui.define([
 	 * @alias sap.ui.rta.util.changeVisualization.ChangeIndicatorRegistry
 	 * @author SAP SE
 	 * @since 1.86.0
-	 * @version 1.117.1
+	 * @version 1.118.0
 	 * @private
 	 */
 	var ChangeIndicatorRegistry = ManagedObject.extend("sap.ui.rta.util.changeVisualization.ChangeIndicatorRegistry", {
@@ -60,8 +60,9 @@ sap.ui.define([
 				}
 			}
 		},
-		constructor: function() {
-			ManagedObject.prototype.constructor.apply(this, arguments);
+		// eslint-disable-next-line object-shorthand
+		constructor: function(...aArgs) {
+			ManagedObject.prototype.constructor.apply(this, aArgs);
 
 			// List of entries with indicator data, grouped by Change ID
 			this._oRegisteredChanges = {};
@@ -194,9 +195,7 @@ sap.ui.define([
 				sChangeCategory = Object.keys(aCategories).find(function(sChangeCategoryName) {
 					return includes(aCategories[sChangeCategoryName], sCommandName);
 				});
-				if (!sChangeCategory) {
-					sChangeCategory = ChangeCategories.OTHER;
-				}
+				sChangeCategory ||= ChangeCategories.OTHER;
 			}
 			var aChangeStates;
 			var aDraftChangesList = [];
@@ -259,9 +258,7 @@ sap.ui.define([
 
 	function getInfoFromChangeHandler(oAppComponent, oChange) {
 		var oSelector = oChange.getOriginalSelector && oChange.getOriginalSelector();
-		if (!oSelector) {
-			oSelector = oChange.getSelector && oChange.getSelector();
-		}
+		oSelector ||= oChange.getSelector && oChange.getSelector();
 		var oControl = JsControlTreeModifier.bySelector(oSelector, oAppComponent);
 		if (oControl) {
 			return ChangesWriteAPI.getChangeHandler({

package/src/sap/ui/rta/util/changeVisualization/ChangeVisualization.js

@@ -82,7 +82,7 @@ sap.ui.define([
 	 * @alias sap.ui.rta.util.changeVisualization.ChangeVisualization
 	 * @author SAP SE
 	 * @since 1.84.0
-	 * @version 1.117.1
+	 * @version 1.118.0
 	 * @private
 	 */
 	var ChangeVisualization = Control.extend("sap.ui.rta.util.changeVisualization.ChangeVisualization", {
@@ -110,12 +110,13 @@ sap.ui.define([
 				}
 			}
 		},
-		constructor: function() {
+		// eslint-disable-next-line object-shorthand
+		constructor: function(...aArgs) {
 			this._oChangeIndicatorRegistry = new ChangeIndicatorRegistry({
 				changeCategories: ChangeCategories.getCategories()
 			});
 
-			Control.prototype.constructor.apply(this, arguments);
+			Control.prototype.constructor.apply(this, aArgs);
 
 			this._oTextBundle = Core.getLibraryResourceBundle("sap.ui.rta");
 			this.setModel(new ResourceModel({
@@ -316,20 +317,18 @@ sap.ui.define([
 	};
 
 	ChangeVisualization.prototype._getChangeCategoryLabel = function(sChangeCategoryName, iChangesCount) {
-		var sLabelKey = "TXT_CHANGEVISUALIZATION_OVERVIEW_" + sChangeCategoryName.toUpperCase();
+		var sLabelKey = `TXT_CHANGEVISUALIZATION_OVERVIEW_${sChangeCategoryName.toUpperCase()}`;
 		return this._oTextBundle.getText(sLabelKey, [iChangesCount]);
 	};
 
 	ChangeVisualization.prototype._getChangeCategoryButton = function(sChangeCategoryName) {
-		var sButtonKey = "BTN_CHANGEVISUALIZATION_OVERVIEW_" + sChangeCategoryName.toUpperCase();
+		var sButtonKey = `BTN_CHANGEVISUALIZATION_OVERVIEW_${sChangeCategoryName.toUpperCase()}`;
 		return this._oTextBundle.getText(sButtonKey);
 	};
 
 	ChangeVisualization.prototype.openChangeCategorySelectionPopover = function(oEvent) {
-		if (!this._oToolbarButton) {
-			// Event bubbled through the toolbar, get original source
-			this._oToolbarButton = Core.byId(oEvent.getParameter("id"));
-		}
+		// Event bubbled through the toolbar, get original source
+		this._oToolbarButton ||= Core.byId(oEvent.getParameter("id"));
 		var oPopover = this.getPopover();
 
 		if (!oPopover) {
@@ -648,7 +647,7 @@ sap.ui.define([
 			selectChange: this.selectChange.bind(this)
 		});
 		oChangeIndicator.setModel(this._oChangeVisualizationModel);
-		oChangeIndicator.bindElement("/content/" + sSelectorId);
+		oChangeIndicator.bindElement(`/content/${sSelectorId}`);
 		oChangeIndicator.setModel(this.getModel("i18n"), "i18n");
 		this._oChangeIndicatorRegistry.registerChangeIndicator(sSelectorId, oChangeIndicator);
 	};

package/src/sap/ui/rta/util/changeVisualization/ChangeVisualizationUtils.js

@@ -28,7 +28,7 @@ sap.ui.define([
 		if (iStringLength > 60) {
 			var sFirstPart = sString.substring(0, 27);
 			var sLastPart = sString.substring(iStringLength - 27);
-			sString = sFirstPart + "(...)" + sLastPart;
+			sString = `${sFirstPart}(...)${sLastPart}`;
 		}
 		return sString;
 	};

package/src/sap/ui/rta/util/changeVisualization/commands/CombineVisualization.js

@@ -77,7 +77,7 @@ sap.ui.define([
 			),
 			descriptionTooltip: aLabels
 			.map(function(sLabel) {
-				return "\"" + sLabel + "\"";
+				return `"${sLabel}"`;
 			})
 			.join(",\n")
 		};

package/src/sap/ui/rta/util/changeVisualization/commands/CreateContainerVisualization.js

@@ -30,8 +30,8 @@ sap.ui.define([
 		var sShortenedElementLabel = ChangeVisualizationUtils.shortenString(sElementLabel);
 		var sTextKey = "TXT_CHANGEVISUALIZATION_CHANGE_CREATECONTAINER";
 		return {
-			descriptionText: oRtaResourceBundle.getText(sTextKey, sShortenedElementLabel),
-			descriptionTooltip: oRtaResourceBundle.getText(sTextKey, sElementLabel)
+			descriptionText: oRtaResourceBundle.getText(sTextKey, [sShortenedElementLabel]),
+			descriptionTooltip: oRtaResourceBundle.getText(sTextKey, [sElementLabel])
 		};
 	};
 

package/src/sap/ui/rta/util/hasStableId.js

@@ -16,7 +16,7 @@ sap.ui.define([
 	"use strict";
 
 	function isCloneFromAggregationBinding(oControl) {
-		var sParentAggregationName = oControl.sParentAggregationName;
+		var {sParentAggregationName} = oControl;
 		var oParent = oControl.getParent();
 
 		if (oParent && sParentAggregationName) {

package/src/sap/ui/rta/util/showMessageBox.js

@@ -25,7 +25,7 @@ sap.ui.define([
 	}
 
 	function isLink(sText) {
-		var oRegex = new RegExp("^" + sLinkRegex + "$");
+		var oRegex = new RegExp(`^${sLinkRegex}$`);
 		return Array.isArray(oRegex.exec(sText));
 	}
 
@@ -90,6 +90,7 @@ sap.ui.define([
 						}
 					});
 
+					// eslint-disable-next-line prefer-spread
 					aSymbols.splice.apply(aSymbols, [i, 1].concat(aInsert));
 					i += aInsert.length;
 				}

package/src/sap/ui/rta/util/validateText.js

@@ -15,7 +15,7 @@ sap.ui.define([
 	var sEmptyTextKey = "\xa0";
 	var oValidators = {
 		noEmptyText: {
-			validatorFunction: function(sNewText) {
+			validatorFunction(sNewText) {
 				return sNewText !== sEmptyTextKey;
 			},
 			errorMessage: Core.getLibraryResourceBundle("sap.ui.rta").getText("RENAME_EMPTY_ERROR_TEXT")