@openui5/sap.ui.rta 1.108.2 → 1.110.0

package/src/sap/ui/rta/RuntimeAuthoring.js

@@ -1,6 +1,6 @@
 /*!
  * OpenUI5
- * (c) Copyright 2009-2022 SAP SE or an SAP affiliate company.
+ * (c) Copyright 2009-2023 SAP SE or an SAP affiliate company.
  * Licensed under the Apache License, Version 2.0 - see LICENSE.txt.
  */
 
@@ -23,7 +23,6 @@ sap.ui.define([
 	"sap/ui/dt/Util",
 	"sap/ui/events/KeyCodes",
 	"sap/ui/fl/write/api/Version",
-	"sap/ui/fl/apply/api/SmartVariantManagementApplyAPI",
 	"sap/ui/fl/write/api/ContextBasedAdaptationsAPI",
 	"sap/ui/fl/write/api/ControlPersonalizationWriteAPI",
 	"sap/ui/fl/write/api/FeaturesAPI",
@@ -71,7 +70,6 @@ sap.ui.define([
 	DtUtil,
 	KeyCodes,
 	Version,
-	SmartVariantManagementApplyAPI,
 	ContextBasedAdaptationsAPI,
 	ControlPersonalizationWriteAPI,
 	FeaturesAPI,
@@ -118,7 +116,7 @@ sap.ui.define([
 	 * @class The runtime authoring allows to adapt the fields of a running application.
 	 * @extends sap.ui.base.ManagedObject
 	 * @author SAP SE
-	 * @version 1.108.2
+	 * @version 1.110.0
 	 * @constructor
 	 * @private
 	 * @since 1.30
@@ -299,6 +297,19 @@ sap.ui.define([
 		ReloadManager.disableAutomaticStart(sLayer);
 	};
 
+	/**
+	 * Check if RTA is about to start or starting after a reload
+	 * e.g. when reloading without personalization changes
+	 *
+	 * @public
+	 * @static
+	 * @param {sap.ui.fl.Layer} [sLayer] - Active layer, CUSTOMER by default
+	 * @returns {boolean} Returns true if RTA is about to start or starting
+	 */
+	RuntimeAuthoring.willRTAStartAfterReload = function(sLayer) {
+		return ReloadManager.needsAutomaticStart(sLayer || Layer.CUSTOMER);
+	};
+
 	RuntimeAuthoring.prototype.addDependent = function(oObject, sName, bCreateGetter) {
 		bCreateGetter = typeof bCreateGetter === "undefined" ? true : !!bCreateGetter;
 		if (!(sName in this._dependents)) {
@@ -382,7 +393,7 @@ sap.ui.define([
 		var oUriParams = UriParameters.fromQuery(window.location.search);
 		var sUriLayer = oUriParams.get("sap-ui-layer");
 
-		mFlexSettings = jQuery.extend({}, this.getFlexSettings(), mFlexSettings);
+		mFlexSettings = Object.assign({}, this.getFlexSettings(), mFlexSettings);
 		if (sUriLayer) {
 			mFlexSettings.layer = sUriLayer.toUpperCase();
 		}
@@ -459,7 +470,6 @@ sap.ui.define([
 				}
 				var oFlexInfoSession = PersistenceWriteAPI.getResetAndPublishInfoFromSession(this.getRootControlInstance());
 				this.bInitialResetEnabled = !!oFlexInfoSession.isResetEnabled;
-				this.bInitialPublishEnabled = !!oFlexInfoSession.isPublishEnabled;
 
 				this._oSerializer = new LREPSerializer({commandStack: this.getCommandStack(), rootControl: this.getRootControl()});
 
@@ -483,12 +493,13 @@ sap.ui.define([
 					//add root control is triggering overlay creation, so we need to wait for the scope to be set.
 					this._oDesignTime.addRootElement(this._oRootControl);
 
-					jQuery(Overlay.getOverlayContainer()).addClass("sapUiRta");
+					//TODO: remove when Overlay.getOverlayContainer() does not return jQuery any more
+					Overlay.getOverlayContainer().get(0).classList.add("sapUiRta");
 					if (this.getLayer() === Layer.USER) {
-						jQuery(Overlay.getOverlayContainer()).addClass("sapUiRtaPersonalize");
+						Overlay.getOverlayContainer().get(0).classList.add("sapUiRtaPersonalize");
 					} else {
 						// RTA Visual Improvements
-						jQuery("body").addClass("sapUiRtaMode");
+						document.body.classList.add("sapUiRtaMode");
 					}
 					this._oDesignTime.getSelectionManager().attachChange(function(oEvent) {
 						this.fireSelectionChange({selection: oEvent.getParameter("selection")});
@@ -558,6 +569,7 @@ sap.ui.define([
 					validateFlexEnabled(this);
 				}
 				this._sStatus = STARTED;
+				RuntimeAuthoring.disableRestart(Layer.CUSTOMER);
 				this.fireStart({
 					editablePluginsCount: this.getPluginManager().getEditableOverlaysCount()
 				});
@@ -576,6 +588,18 @@ sap.ui.define([
 		return Promise.reject("RuntimeAuthoring is already started");
 	};
 
+	function showSaveConfirmation() {
+		return Utils.showMessageBox("warning", "MSG_UNSAVED_CHANGES_ON_CLOSE", {
+			titleKey: "TIT_UNSAVED_CHANGES_ON_CLOSE",
+			actionKeys: [
+				"BTN_UNSAVED_CHANGES_ON_CLOSE_SAVE",
+				"BTN_UNSAVED_CHANGES_ON_CLOSE_DONT_SAVE"
+			],
+			emphasizedActionKey: "BTN_UNSAVED_CHANGES_ON_CLOSE_SAVE",
+			showCancel: true
+		});
+	}
+
 	/**
 	 * Stops Runtime Authoring
 	 *
@@ -585,13 +609,33 @@ sap.ui.define([
 	 * @returns {Promise} Resolves with undefined
 	 */
 	RuntimeAuthoring.prototype.stop = function(bSkipSave, bSkipRestart) {
-		checkToolbarAndExecuteFunction.call(this, "setBusy", true);
+		var bUserCancelled;
 		var oReloadInfo;
+		checkToolbarAndExecuteFunction.call(this, "setBusy", true);
 		return waitForPendingActions.call(this)
+			.then(function() {
+				var oCommandStack = this.getCommandStack();
+				var sLayer = this.getLayer();
+				if (sLayer !== Layer.USER && !bSkipSave && oCommandStack.canUndo()) {
+					return showSaveConfirmation()
+					.then(function (sAction) {
+						if (sAction === MessageBox.Action.CANCEL) {
+							bUserCancelled = true;
+							return Promise.reject();
+						}
+						if (sAction === this._getTextResources().getText("BTN_UNSAVED_CHANGES_ON_CLOSE_DONT_SAVE")) {
+							return this._oSerializer.clearCommandStack(/*bRemoveChanges = */true);
+						}
+						return undefined;
+					}.bind(this));
+				}
+				return undefined;
+			}.bind(this))
 			.then(function() {
 				if (bSkipRestart) {
 					return {};
 				}
+				//Reload check must happen before _serializeToLrep is called
 				return ReloadManager.checkReloadOnExit({
 					layer: this.getLayer(),
 					selector: this.getRootControlInstance(),
@@ -603,20 +647,31 @@ sap.ui.define([
 			}.bind(this))
 			.then(function(oReturn) {
 				oReloadInfo = oReturn;
-				return bSkipSave ? Promise.resolve() : this._serializeToLrep();
+				if (!bSkipSave) {
+					// serializeToLrep has to be called even when no changes were made -> to invalidate cache
+					return this._serializeToLrep();
+				}
+				return undefined;
 			}.bind(this))
-			.then(checkToolbarAndExecuteFunction.bind(this, "hide", bSkipSave))
 			.then(function() {
+				checkToolbarAndExecuteFunction.call(this, "hide", bSkipSave);
 				this.fireStop();
 				if (!bSkipRestart) {
 					ReloadManager.handleUrlParametersOnExit(oReloadInfo);
 				}
 			}.bind(this))
-			.catch(showTechnicalError)
+			.catch(function(vError) {
+				if (!bUserCancelled) {
+					return showTechnicalError(vError);
+				}
+				return undefined;
+			})
 			.then(function() {
 				checkToolbarAndExecuteFunction.call(this, "setBusy", false);
-				this._sStatus = STOPPED;
-				jQuery("body").removeClass("sapUiRtaMode");
+				if (!bUserCancelled) {
+					this._sStatus = STOPPED;
+					document.body.classList.remove("sapUiRtaMode");
+				}
 			}.bind(this));
 	};
 
@@ -693,9 +748,13 @@ sap.ui.define([
 
 			Overlay.getOverlayContainer().toggleClass("sapUiRtaVisualizationMode", (sNewMode === "visualization"));
 			if (sNewMode === "visualization") {
-				jQuery(".sapUiDtOverlayMovable").css("cursor", "default");
+				document.querySelectorAll(".sapUiDtOverlayMovable").forEach(function(oNode) {
+					oNode.style.cursor = "default";
+				});
 			} else {
-				jQuery(".sapUiDtOverlayMovable").css("cursor", "move");
+				document.querySelectorAll(".sapUiDtOverlayMovable").forEach(function(oNode) {
+					oNode.style.cursor = "move";
+				});
 			}
 
 			this._oToolbarControlsModel.setProperty("/modeSwitcher", sNewMode);
@@ -813,51 +872,6 @@ sap.ui.define([
 		}.bind(this));
 	};
 
-	/**
-	 * Function to handle ABAP transport of the changes
-	 *
-	 * @returns {Promise} Returns a Promise processing the transport of changes
-	 */
-	RuntimeAuthoring.prototype.transport = function() {
-		this.getPluginManager().handleStopCutPaste();
-
-		BusyIndicator.show(500);
-		return this._serializeToLrep().then(function() {
-			BusyIndicator.hide();
-			var bVariantByStartupParameter = FlexUtils.isVariantByStartupParameter(this._oRootControl);
-			var bAppVariantRunning = SmartVariantManagementApplyAPI.isApplicationVariant({control: this._oRootControl}) && !bVariantByStartupParameter;
-			return (bAppVariantRunning ? RtaAppVariantFeature.getAppVariantDescriptor(this._oRootControl) : Promise.resolve())
-				.then(function(oAppVariantDescriptor) {
-					var aAppVariantDescriptor = [];
-					if (oAppVariantDescriptor) {
-						aAppVariantDescriptor.push(oAppVariantDescriptor);
-					}
-					return PersistenceWriteAPI.publish({
-						selector: this.getRootControlInstance(),
-						styleClass: Utils.getRtaStyleClassName(),
-						layer: this.getLayer(),
-						appVariantDescriptors: aAppVariantDescriptor
-					})
-					.then(function(sMessage) {
-						if (sMessage !== "Error" && sMessage !== "Cancel") {
-							MessageToast.show(sMessage);
-							if (this.getShowToolbars()) {
-								PersistenceWriteAPI.getResetAndPublishInfo({
-									selector: this.getRootControlInstance(),
-									layer: this.getLayer()
-								})
-								.then(function(oPublishAndResetInfo) {
-									this._oToolbarControlsModel.setProperty("/publishEnabled", oPublishAndResetInfo.isPublishEnabled);
-									this._oToolbarControlsModel.setProperty("/restoreEnabled", oPublishAndResetInfo.isResetEnabled);
-								}.bind(this));
-							}
-						}
-					}.bind(this));
-				}.bind(this));
-		}.bind(this))
-		.catch(showTechnicalError);
-	};
-
 	RuntimeAuthoring.prototype.undo = function() {
 		this.getPluginManager().handleStopCutPaste();
 		return this.getCommandStack().undo();
@@ -896,6 +910,20 @@ sap.ui.define([
 		return serializeAndSave.call(this, undefined, bCondenseAnyLayer);
 	};
 
+	/**
+	 * Condenses the given changes and saves the result.
+	 * For the function to do anything at least two changes have to be passed.
+	 *
+	 * @param {object[]} aChanges - Array of flex object instances
+	 * @returns {Promise} Resolves when the save and condense is done
+	 * @private
+	 * @ui5-restricted Visual Editor
+	 */
+	RuntimeAuthoring.prototype.condenseAndSaveChanges = function(/* aChanges */) {
+		// for now there is no functionality to only consider passed changes during condensing, so the standard save functionality is triggered
+		return this._serializeToLrep.apply(this, arguments);
+	};
+
 	/**
 	 * Check for unsaved changes before leaving UI adaptation at runtime
 	 *
@@ -905,8 +933,7 @@ sap.ui.define([
 	RuntimeAuthoring.prototype._onUnload = function() {
 		// this function is still in the prototype scope for easier testing
 		var oCommandStack = this.getCommandStack();
-		var bUnsaved = oCommandStack.canUndo();
-		if (bUnsaved && this.getShowWindowUnloadDialog()) {
+		if (oCommandStack.canUndo() && this.getShowWindowUnloadDialog()) {
 			return this._getTextResources().getText("MSG_UNSAVED_CHANGES");
 		}
 		window.onbeforeunload = this._oldUnloadHandler;
@@ -1016,7 +1043,7 @@ sap.ui.define([
 	}
 
 	/**
-	 * Adapt the enablement of undo/redo/reset/transport button
+	 * Adapt the enablement of undo/redo/reset button
 	 *
 	 * @returns {Promise} Resolves as soon as the MessageBox is closed
 	 */
@@ -1056,16 +1083,17 @@ sap.ui.define([
 			var oCommandStack = this.getCommandStack();
 			var bCanUndo = oCommandStack.canUndo();
 			var bCanRedo = oCommandStack.canRedo();
-			var bTranslationRelevantDirtyChange = this._oToolbarControlsModel.getProperty("/translationVisible") &&
+			var bWasSaved = oCommandStack.getSaved();
+			var bTranslationRelevantDirtyChange = this._oToolbarControlsModel.getProperty("/translation/visible") &&
 				TranslationAPI.hasTranslationRelevantDirtyChanges({layer: Layer.CUSTOMER, selector: this.getRootControlInstance()});
 
 			// TODO: move to the setter to the ChangesState
 			this._oVersionsModel.setDirtyChanges(PersistenceWriteAPI.hasDirtyChanges({selector: this.getRootControlInstance()}));
-			this._oToolbarControlsModel.setProperty("/undoEnabled", bCanUndo);
-			this._oToolbarControlsModel.setProperty("/redoEnabled", bCanRedo);
-			this._oToolbarControlsModel.setProperty("/publishEnabled", this.bInitialPublishEnabled || bCanUndo);
-			this._oToolbarControlsModel.setProperty("/restoreEnabled", this.bInitialResetEnabled || bCanUndo);
-			this._oToolbarControlsModel.setProperty("/translationEnabled", this.bPersistedDataTranslatable || bTranslationRelevantDirtyChange);
+			this._oToolbarControlsModel.setProperty("/undo/enabled", bCanUndo);
+			this._oToolbarControlsModel.setProperty("/redo/enabled", bCanRedo);
+			this._oToolbarControlsModel.setProperty("/save/enabled", bCanUndo);
+			this._oToolbarControlsModel.setProperty("/restore/enabled", this.bInitialResetEnabled || bCanUndo || bWasSaved);
+			this._oToolbarControlsModel.setProperty("/translation/enabled", this.bPersistedDataTranslatable || bTranslationRelevantDirtyChange);
 		}
 		this.fireUndoRedoStackModified();
 	}
@@ -1085,19 +1113,19 @@ sap.ui.define([
 	}
 
 	function onKeyDown(oEvent) {
-		// if for example the addField Dialog/transport/reset Popup is open, we don't want the user to be able to undo/redo
+		// if for example the addField Dialog/reset Popup is open, we don't want the user to be able to undo/redo
 		var bMacintosh = Device.os.macintosh;
 		var bFocusInsideOverlayContainer = Overlay.getOverlayContainer().get(0).contains(document.activeElement);
 		var bFocusInsideRtaToolbar = this.getShowToolbars() && this.getToolbar().getDomRef().contains(document.activeElement);
 		var bFocusOnContextMenu = false;
 		// there might be two divs with that style-class (compact and expanded context menu)
-		jQuery(".sapUiDtContextMenu").each(function(iIndex, oDomRef) {
-			if (oDomRef.contains(document.activeElement)) {
+		document.querySelectorAll(".sapUiDtContextMenu").forEach(function(oNode) {
+			if (oNode.contains(document.activeElement)) {
 				bFocusOnContextMenu = true;
 			}
 		});
 		var bFocusOnBody = document.body === document.activeElement;
-		var bFocusInsideRenameField = jQuery(document.activeElement).parents(".sapUiRtaEditableField").length > 0;
+		var bFocusInsideRenameField = DOMUtil.getParents(document.activeElement, ".sapUiRtaEditableField").length > 0;
 
 		if ((bFocusInsideOverlayContainer || bFocusInsideRtaToolbar || bFocusOnContextMenu || bFocusOnBody) && !bFocusInsideRenameField) {
 			// OSX: replace CTRL with CMD
@@ -1127,15 +1155,6 @@ sap.ui.define([
 		}
 	}
 
-	function onSaveAsContextBasedAdaptation(oEvent) {
-		var mPropertyBag = {
-			parameters: oEvent.mParameters,
-			control: this.getRootControlInstance(),
-			layer: this.getLayer()
-		};
-		return ContextBasedAdaptationsAPI.create(mPropertyBag);
-	}
-
 	function saveOnly(oEvent) {
 		var fnCallback = oEvent.getParameter("callback") || function() {};
 		return this.save()
@@ -1144,7 +1163,7 @@ sap.ui.define([
 
 	function serializeAndSave(bActivateVersion, bCondenseAnyLayer) {
 		if (this.getShowToolbars()) {
-			this.bPersistedDataTranslatable = this._oToolbarControlsModel.getProperty("/translationEnabled");
+			this.bPersistedDataTranslatable = this._oToolbarControlsModel.getProperty("/translation/enabled");
 		}
 		var mPropertyBag = {
 			// Save changes on the current layer and discard dirty changes on other layers
@@ -1170,6 +1189,7 @@ sap.ui.define([
 				if (sAction === MessageBox.Action.OK) {
 					return activate.call(this, sVersionTitle);
 				}
+				return undefined;
 			}.bind(this));
 		}
 		return activate.call(this, sVersionTitle);
@@ -1190,7 +1210,7 @@ sap.ui.define([
 		}).then(function() {
 			showMessageToast.call(this, "MSG_DRAFT_ACTIVATION_SUCCESS");
 			this.bInitialResetEnabled = true;
-			this._oToolbarControlsModel.setProperty("/restoreEnabled", true);
+			this._oToolbarControlsModel.setProperty("/restore/enabled", true);
 			this.getCommandStack().removeAllCommands();
 		}.bind(this))
 		.catch(function(oError) {
@@ -1318,7 +1338,7 @@ sap.ui.define([
 		}.bind(this));
 	}
 
-	function createToolsMenu(aButtonsVisibility) {
+	function createToolsMenu(mButtonsAvailability) {
 		if (!this.getDependent("toolbar")) {
 			var bUserLayer = this.getLayer() === Layer.USER;
 			var oProperties = {
@@ -1333,7 +1353,6 @@ sap.ui.define([
 			};
 
 			if (!bUserLayer) {
-				oProperties.transport = this.transport.bind(this);
 				oProperties.publishVersion = onPublishVersion.bind(this);
 				oProperties.undo = this.undo.bind(this);
 				oProperties.redo = this.redo.bind(this);
@@ -1341,7 +1360,6 @@ sap.ui.define([
 				oProperties.activate = onActivate.bind(this);
 				oProperties.discardDraft = onDiscardDraft.bind(this);
 				oProperties.switchVersion = onSwitchVersion.bind(this);
-				oProperties.saveAsContextBasedAdaptation = onSaveAsContextBasedAdaptation.bind(this);
 				oProperties.openChangeCategorySelectionPopover = this.getChangeVisualization
 					? this.getChangeVisualization().openChangeCategorySelectionPopover.bind(this.getChangeVisualization())
 					: function() {};
@@ -1363,8 +1381,8 @@ sap.ui.define([
 			return Promise.all([oToolbar.onFragmentLoaded(), FeaturesAPI.isKeyUserTranslationEnabled(this.getLayer())])
 				.then(function(aArguments) {
 					var bTranslationAvailable = aArguments[1];
-					var bSaveAsAvailable = aButtonsVisibility.saveAsAvailable;
-					var bExtendedOverview = bSaveAsAvailable && RtaAppVariantFeature.isOverviewExtended();
+					var bAppVariantsAvailable = mButtonsAvailability.saveAsAvailable;
+					var bExtendedOverview = bAppVariantsAvailable && RtaAppVariantFeature.isOverviewExtended();
 					var oUriParameters = UriParameters.fromURL(window.location.href);
 					// the "Visualization" tab should not be visible if the "fiori-tools-rta-mode" URL-parameter is set to any value but "false"
 					var bVisualizationButtonVisible;
@@ -1372,24 +1390,55 @@ sap.ui.define([
 					this.bPersistedDataTranslatable = false;
 
 					this._oToolbarControlsModel = new JSONModel({
-						undoEnabled: false,
-						redoEnabled: false,
-						translationVisible: bTranslationAvailable,
-						translationEnabled: this.bPersistedDataTranslatable,
-						publishVisible: aButtonsVisibility.publishAvailable,
-						publishEnabled: this.bInitialPublishEnabled,
-						restoreEnabled: this.bInitialResetEnabled,
-						appVariantsOverviewVisible: bSaveAsAvailable && bExtendedOverview,
-						appVariantsOverviewEnabled: bSaveAsAvailable && bExtendedOverview,
-						saveAsVisible: bSaveAsAvailable,
-						contextBasedAdaptationVisible: aButtonsVisibility.contextBasedAdaptationAvailable,
-						saveAsEnabled: false,
-						manageAppsVisible: bSaveAsAvailable && !bExtendedOverview,
-						manageAppsEnabled: bSaveAsAvailable && !bExtendedOverview,
 						modeSwitcher: this.getMode(),
-						visualizationButtonVisible: bVisualizationButtonVisible
+						undo: {
+							enabled: false
+						},
+						redo: {
+							enabled: false
+						},
+						save: {
+							enabled: false
+						},
+						translation: {
+							visible: bTranslationAvailable,
+							enabled: this.bPersistedDataTranslatable
+						},
+						appVariantMenu: {
+							visible: bAppVariantsAvailable,
+							enabled: bAppVariantsAvailable,
+							overview: {
+								visible: bAppVariantsAvailable && bExtendedOverview,
+								enabled: bAppVariantsAvailable && bExtendedOverview
+							},
+							manageApps: {
+								visible: bAppVariantsAvailable && !bExtendedOverview,
+								enabled: bAppVariantsAvailable && !bExtendedOverview
+							},
+							saveAs: {
+								visible: bAppVariantsAvailable,
+								enabled: bAppVariantsAvailable
+							}
+						},
+						restore: {
+							visible: !this._oVersionsModel.getProperty("/versioningEnabled"),
+							enabled: this.bInitialResetEnabled
+						},
+						contextBasedAdaptation: {
+							visible: mButtonsAvailability.contextBasedAdaptationAvailable,
+							enabled: mButtonsAvailability.contextBasedAdaptationAvailable
+						},
+						actionsMenuButton: {
+							enabled: true
+						},
+						visualizationButton: {
+							visible: bVisualizationButtonVisible,
+							enabled: bVisualizationButtonVisible
+						}
 					});
 
+					this._oVersionsModel.setProperty("/publishVersionVisible", mButtonsAvailability.publishAvailable);
+
 					var oTranslationPromise = new Promise(function(resolve) {
 						if (!bTranslationAvailable) {
 							resolve();
@@ -1399,20 +1448,20 @@ sap.ui.define([
 						TranslationAPI.getSourceLanguages({selector: this.getRootControlInstance(), layer: this.getLayer()})
 							.then(function(aSourceLanguages) {
 								this.bPersistedDataTranslatable = aSourceLanguages.length > 0;
-								this._oToolbarControlsModel.setProperty("/translationEnabled", this.bPersistedDataTranslatable);
+								this._oToolbarControlsModel.setProperty("/translation/enabled", this.bPersistedDataTranslatable);
 							}.bind(this)).finally(resolve);
 					}.bind(this));
 
 					var oSaveAsPromise = new Promise(function(resolve) {
-						if (!bSaveAsAvailable) {
+						if (!bAppVariantsAvailable) {
 							resolve();
 							return;
 						}
 
 						RtaAppVariantFeature.isManifestSupported().then(function(bResult) {
-							this._oToolbarControlsModel.setProperty("/saveAsEnabled", bResult);
-							this._oToolbarControlsModel.setProperty("/appVariantsOverviewEnabled", bResult);
-							this._oToolbarControlsModel.setProperty("/manageAppsEnabled", bResult);
+							this._oToolbarControlsModel.setProperty("/appVariantMenu/saveAs/enabled", bResult);
+							this._oToolbarControlsModel.setProperty("/appVariantMenu/overview/enabled", bResult);
+							this._oToolbarControlsModel.setProperty("/appVariantMenu/manageApps/enabled", bResult);
 						}.bind(this)).finally(resolve);
 					}.bind(this));
 
@@ -1572,6 +1621,7 @@ sap.ui.define([
 						Log.error("sap.ui.rta: " + oError.message);
 					});
 			}
+			return undefined;
 		}.bind(this));
 		return this._pElementModified;
 	}
@@ -1650,94 +1700,93 @@ sap.ui.define([
 				}
 			}
 		} else {
-			this._mServices[sName] = mService = {
-				status: SERVICE_STARTING,
-				location: sServiceLocation,
-				initPromise: new Promise(function(fnResolve, fnReject) {
-					sap.ui.require(
-						[sServiceLocation],
-						function(fnServiceFactory) {
-							mService.factory = fnServiceFactory;
-
-							if (!this._oServiceEventBus) {
-								this._oServiceEventBus = new ServiceEventBus();
-							}
+			this._mServices[sName] = mService = {};
+			mService.status = SERVICE_STARTING;
+			mService.location = sServiceLocation;
+			mService.initPromise = new Promise(function(fnResolve, fnReject) {
+				sap.ui.require(
+					[sServiceLocation],
+					function(fnServiceFactory) {
+						mService.factory = fnServiceFactory;
+
+						if (!this._oServiceEventBus) {
+							this._oServiceEventBus = new ServiceEventBus();
+						}
 
-							DtUtil.wrapIntoPromise(fnServiceFactory)(
-								this,
-								this._oServiceEventBus.publish.bind(this._oServiceEventBus, sName)
-							)
-								.then(function(oService) {
-									if (this.bIsDestroyed) {
-										throw DtUtil.createError(
-											"RuntimeAuthoring#startService",
-											DtUtil.printf("RuntimeAuthoring instance is destroyed while initializing the service '{0}'", sName),
-											"sap.ui.rta"
-										);
-									}
-									if (!isPlainObject(oService)) {
-										throw DtUtil.createError(
-											"RuntimeAuthoring#startService",
-											DtUtil.printf("Invalid service format. Service should return simple javascript object after initialization. Service name = '{0}'", sName),
-											"sap.ui.rta"
-										);
-									}
-
-									mService.service = oService;
-									mService.exports = {};
-
-									// Expose events API if there is at least one event
-									if (Array.isArray(oService.events) && oService.events.length > 0) {
-										jQuery.extend(mService.exports, {
-											attachEvent: this._oServiceEventBus.subscribe.bind(this._oServiceEventBus, sName),
-											detachEvent: this._oServiceEventBus.unsubscribe.bind(this._oServiceEventBus, sName),
-											attachEventOnce: this._oServiceEventBus.subscribeOnce.bind(this._oServiceEventBus, sName)
-										});
-									}
-
-									// Expose methods/properties from exports object if any
-									var mExports = oService.exports || {};
-									jQuery.extend(
-										mService.exports,
-										Object.keys(mExports).reduce(function(mResult, sKey) {
-											var vValue = mExports[sKey];
-											mResult[sKey] = typeof vValue === "function"
-												? DtUtil.waitForSynced(this._oDesignTime, vValue)
-												: vValue;
-											return mResult;
-										}.bind(this), {})
+						DtUtil.wrapIntoPromise(fnServiceFactory)(
+							this,
+							this._oServiceEventBus.publish.bind(this._oServiceEventBus, sName)
+						)
+							.then(function(oService) {
+								if (this.bIsDestroyed) {
+									throw DtUtil.createError(
+										"RuntimeAuthoring#startService",
+										DtUtil.printf("RuntimeAuthoring instance is destroyed while initializing the service '{0}'", sName),
+										"sap.ui.rta"
 									);
-
-									mService.status = SERVICE_STARTED;
-									fnResolve(Object.freeze(mService.exports));
-								}.bind(this))
-								.catch(fnReject);
-						}.bind(this),
-						function(vError) {
-							mService.status = SERVICE_FAILED;
-							fnReject(
-								DtUtil.propagateError(
-									vError,
-									"RuntimeAuthoring#startService",
-									DtUtil.printf("Can't load service '{0}' by its name: {1}", sName, sServiceLocation),
-									"sap.ui.rta"
-								)
-							);
-						}
-					);
-				}.bind(this))
-					.catch(function(vError) {
+								}
+								if (!isPlainObject(oService)) {
+									throw DtUtil.createError(
+										"RuntimeAuthoring#startService",
+										DtUtil.printf("Invalid service format. Service should return simple javascript object after initialization. Service name = '{0}'", sName),
+										"sap.ui.rta"
+									);
+								}
+
+								mService.service = oService;
+								mService.exports = {};
+
+								// Expose events API if there is at least one event
+								if (Array.isArray(oService.events) && oService.events.length > 0) {
+									Object.assign(mService.exports, {
+										attachEvent: this._oServiceEventBus.subscribe.bind(this._oServiceEventBus, sName),
+										detachEvent: this._oServiceEventBus.unsubscribe.bind(this._oServiceEventBus, sName),
+										attachEventOnce: this._oServiceEventBus.subscribeOnce.bind(this._oServiceEventBus, sName)
+									});
+								}
+
+								// Expose methods/properties from exports object if any
+								var mExports = oService.exports || {};
+								Object.assign(
+									mService.exports,
+									Object.keys(mExports).reduce(function(mResult, sKey) {
+										var vValue = mExports[sKey];
+										mResult[sKey] = typeof vValue === "function"
+											? DtUtil.waitForSynced(this._oDesignTime, vValue)
+											: vValue;
+										return mResult;
+									}.bind(this), {})
+								);
+
+								mService.status = SERVICE_STARTED;
+								fnResolve(Object.freeze(mService.exports));
+							}.bind(this))
+							.catch(fnReject);
+					}.bind(this),
+					function(vError) {
 						mService.status = SERVICE_FAILED;
-						return Promise.reject(
+						fnReject(
 							DtUtil.propagateError(
 								vError,
 								"RuntimeAuthoring#startService",
-								DtUtil.printf("Error during service '{0}' initialization.", sName),
+								DtUtil.printf("Can't load service '{0}' by its name: {1}", sName, sServiceLocation),
 								"sap.ui.rta"
 							)
 						);
-					})
-			};
+					}
+				);
+			}.bind(this))
+			.catch(function(vError) {
+				mService.status = SERVICE_FAILED;
+				return Promise.reject(
+					DtUtil.propagateError(
+						vError,
+						"RuntimeAuthoring#startService",
+						DtUtil.printf("Error during service '{0}' initialization.", sName),
+						"sap.ui.rta"
+					)
+				);
+			});
 
 			return mService.initPromise;
 		}
@@ -1776,4 +1825,4 @@ sap.ui.define([
 	};
 
 	return RuntimeAuthoring;
-});
+});