@mmerterden/multi-agent-pipeline 8.6.0

package/pipeline/scripts/smoke-run-aggregator.sh

@@ -0,0 +1,216 @@
+#!/usr/bin/env bash
+# smoke-run-aggregator.sh — v7.8.0 Paket C: unified telemetry aggregator.
+#
+# Validates run-aggregator.mjs reads phase-tracker + otel-spans + cost table
+# and emits a normalized pipeline-run.jsonl with:
+#   1. Time-sorted events
+#   2. Correct cost computation per cost-table.json
+#   3. Span passthrough with task_id stamping
+#   4. Summary as last event with totals
+#   5. Unknown model graceful degradation
+#   6. --summary-only mode
+#   7. Read-only contract (no writes to source files)
+#   8. Missing inputs handled with clear errors
+#   9. Idempotent (running twice produces identical output)
+
+set -uo pipefail
+
+REPO_ROOT="$(cd "$(dirname "$0")/../.." && pwd)"
+SCRIPT="$REPO_ROOT/pipeline/scripts/run-aggregator.mjs"
+
+PASS=0
+FAIL=0
+pass() { PASS=$((PASS + 1)); echo "  ✓ $1"; }
+fail() { FAIL=$((FAIL + 1)); echo "  ✗ $1"; }
+
+cleanup() { [ -n "${TMP:-}" ] && rm -rf "$TMP"; }
+trap cleanup EXIT
+TMP=$(mktemp -d)
+
+# ──────────────────────────────────────────────────────────────────────────
+echo "→ 1. Setup synthetic task dir + tracker + spans"
+cat > "$TMP/phase-tracker.json" <<'EOF'
+{
+  "task_id": "PROJ-100",
+  "started_at": "2026-04-27T10:00:00Z",
+  "phases": [
+    {"id":"0","name":"Init","status":"completed","started_at":"2026-04-27T10:00:00Z","completed_at":"2026-04-27T10:00:30Z","tokens_in":1000,"tokens_out":200,"model":"sonnet","subs":[]},
+    {"id":"1","name":"Analysis","status":"completed","started_at":"2026-04-27T10:00:30Z","completed_at":"2026-04-27T10:05:00Z","tokens_in":50000,"tokens_out":3000,"model":"opus","subs":[{"id":"1.0","name":"Explore","status":"completed"}]},
+    {"id":"3","name":"Dev","status":"failed","started_at":"2026-04-27T10:10:00Z","completed_at":"2026-04-27T10:30:00Z","tokens_in":10000,"tokens_out":2000,"model":"sonnet","subs":[]}
+  ]
+}
+EOF
+cat > "$TMP/otel-spans.jsonl" <<'EOF'
+{"name":"phase.update","ts":"2026-04-27T10:00:30Z","attributes":{"multi_agent.status":"completed"}}
+{"name":"phase.tokens","ts":"2026-04-27T10:25:00Z","attributes":{"multi_agent.tokens_in_delta":10000}}
+EOF
+[ -f "$TMP/phase-tracker.json" ] && pass "synthetic phase-tracker.json written"
+[ -f "$TMP/otel-spans.jsonl" ] && pass "synthetic otel-spans.jsonl written"
+
+# Compute hash of source files BEFORE running aggregator
+HASH_BEFORE=$(md5 -q "$TMP/phase-tracker.json" "$TMP/otel-spans.jsonl" 2>/dev/null || \
+              md5sum "$TMP/phase-tracker.json" "$TMP/otel-spans.jsonl" 2>/dev/null | awk '{print $1}' | tr -d '\n')
+
+# ──────────────────────────────────────────────────────────────────────────
+echo "→ 2. Run aggregator → pipeline-run.jsonl produced"
+node "$SCRIPT" --task-dir "$TMP" 2>/dev/null
+if [ -f "$TMP/pipeline-run.jsonl" ]; then
+  pass "pipeline-run.jsonl created"
+else
+  fail "pipeline-run.jsonl not created"
+fi
+
+LINE_COUNT=$(wc -l < "$TMP/pipeline-run.jsonl" | tr -d ' ')
+if [ "$LINE_COUNT" -ge 8 ]; then
+  pass "output has $LINE_COUNT events (≥ 8 expected)"
+else
+  fail "too few events: $LINE_COUNT"
+fi
+
+# ──────────────────────────────────────────────────────────────────────────
+echo "→ 3. Read-only contract — source files untouched"
+HASH_AFTER=$(md5 -q "$TMP/phase-tracker.json" "$TMP/otel-spans.jsonl" 2>/dev/null || \
+             md5sum "$TMP/phase-tracker.json" "$TMP/otel-spans.jsonl" 2>/dev/null | awk '{print $1}' | tr -d '\n')
+if [ "$HASH_BEFORE" = "$HASH_AFTER" ]; then
+  pass "source files unchanged after aggregation"
+else
+  fail "source files were modified (hash drift)"
+fi
+
+# Static check: aggregator script does not write to phase-tracker or otel-spans
+if grep -qE "writeFileSync.*phase-tracker|writeFileSync.*otel-spans" "$SCRIPT"; then
+  fail "run-aggregator.mjs writes to source telemetry files (read-only contract violated)"
+else
+  pass "no writes to source telemetry files in aggregator"
+fi
+
+# ──────────────────────────────────────────────────────────────────────────
+echo "→ 4. Time-sorted events"
+# Extract ts values and verify sorted (lexicographic = time-sorted for ISO 8601)
+TSS=$(grep -oE '"ts":"[^"]*"' "$TMP/pipeline-run.jsonl" | sed 's/"ts":"//;s/"//')
+if [ "$TSS" = "$(echo "$TSS" | sort)" ]; then
+  pass "events time-sorted (ISO ts ascending)"
+else
+  fail "events out of time order"
+fi
+
+# ──────────────────────────────────────────────────────────────────────────
+echo "→ 5. Cost computation correct"
+# sonnet 1000+200 = 0.001*3 + 0.0002*15 = 0.003 + 0.003 = 0.006
+# opus 50000+3000 = 0.05*15 + 0.003*75 = 0.75 + 0.225 = 0.975
+# sonnet 10000+2000 = 0.01*3 + 0.002*15 = 0.03 + 0.03 = 0.060
+# total = 0.006 + 0.975 + 0.060 = 1.041
+SUMMARY=$(tail -1 "$TMP/pipeline-run.jsonl")
+TOTAL=$(echo "$SUMMARY" | grep -oE '"total_cost_usd":[^,}]*' | sed 's/"total_cost_usd"://')
+if [ "$TOTAL" = "1.041" ]; then
+  pass "total_cost_usd = $TOTAL (matches expected)"
+else
+  fail "total_cost_usd = $TOTAL (expected 1.041)"
+fi
+
+# ──────────────────────────────────────────────────────────────────────────
+echo "→ 6. Summary as last event"
+LAST_KIND=$(tail -1 "$TMP/pipeline-run.jsonl" | grep -oE '"kind":"[^"]*"' | head -1)
+if [ "$LAST_KIND" = '"kind":"summary"' ]; then
+  pass "summary is the final event"
+else
+  fail "last event is not summary: $LAST_KIND"
+fi
+
+# ──────────────────────────────────────────────────────────────────────────
+echo "→ 7. Phase status counted correctly"
+COMPLETED=$(echo "$SUMMARY" | grep -oE '"phases_completed":[0-9]+' | grep -oE '[0-9]+')
+FAILED=$(echo "$SUMMARY" | grep -oE '"phases_failed":[0-9]+' | grep -oE '[0-9]+')
+if [ "$COMPLETED" = "2" ] && [ "$FAILED" = "1" ]; then
+  pass "phases_completed=$COMPLETED phases_failed=$FAILED (matches fixture)"
+else
+  fail "phase counts wrong: completed=$COMPLETED failed=$FAILED (expected 2/1)"
+fi
+
+# ──────────────────────────────────────────────────────────────────────────
+echo "→ 8. Span passthrough with task_id stamping"
+SPAN_COUNT=$(grep -c '"kind":"span"' "$TMP/pipeline-run.jsonl" || true)
+if [ "$SPAN_COUNT" = "2" ]; then
+  pass "all 2 spans passed through"
+else
+  fail "span passthrough count wrong: $SPAN_COUNT (expected 2)"
+fi
+if grep -q '"kind":"span".*"task_id":"PROJ-100"' "$TMP/pipeline-run.jsonl"; then
+  pass "spans stamped with task_id"
+else
+  fail "spans missing task_id stamp"
+fi
+
+# ──────────────────────────────────────────────────────────────────────────
+echo "→ 9. --summary-only mode"
+SUMMARY_OUT=$(node "$SCRIPT" --task-dir "$TMP" --stdout --summary-only 2>/dev/null)
+SUMMARY_LINES=$(echo "$SUMMARY_OUT" | grep -c "^{" || true)
+if [ "$SUMMARY_LINES" = "1" ]; then
+  pass "--summary-only emits exactly 1 line"
+else
+  fail "--summary-only emitted $SUMMARY_LINES lines"
+fi
+
+# ──────────────────────────────────────────────────────────────────────────
+echo "→ 10. Unknown model graceful degradation"
+cat > "$TMP/phase-tracker.json" <<'EOF'
+{
+  "task_id": "PROJ-200",
+  "started_at": "2026-04-27T11:00:00Z",
+  "phases": [
+    {"id":"0","name":"Init","status":"completed","started_at":"2026-04-27T11:00:00Z","completed_at":"2026-04-27T11:00:10Z","tokens_in":500,"tokens_out":50,"model":"made-up-model","subs":[]}
+  ]
+}
+EOF
+rm -f "$TMP/otel-spans.jsonl"
+node "$SCRIPT" --task-dir "$TMP" --stdout 2>/dev/null > "$TMP/run.jsonl"
+if grep -q '"cost_unknown_model":true' "$TMP/run.jsonl"; then
+  pass "unknown model marked with cost_unknown_model flag"
+else
+  fail "unknown model not flagged"
+fi
+SUMMARY=$(tail -1 "$TMP/run.jsonl")
+if echo "$SUMMARY" | grep -q '"unknown_model_phases":1'; then
+  pass "summary records unknown_model_phases count"
+else
+  fail "summary missing unknown_model_phases counter"
+fi
+
+# ──────────────────────────────────────────────────────────────────────────
+echo "→ 11. Missing task-dir errors clearly"
+set +e
+node "$SCRIPT" --task-dir /nonexistent/path 2>"$TMP/err.txt"
+EC=$?
+set -e
+if [ "$EC" -ne 0 ] && grep -qE "not found" "$TMP/err.txt"; then
+  pass "missing task-dir exits $EC with 'not found' error"
+else
+  fail "missing task-dir error handling weak (exit=$EC)"
+fi
+
+# ──────────────────────────────────────────────────────────────────────────
+echo "→ 12. Idempotent — second run produces identical content"
+# Restore the first fixture
+cat > "$TMP/phase-tracker.json" <<'EOF'
+{
+  "task_id": "PROJ-100",
+  "started_at": "2026-04-27T10:00:00Z",
+  "phases": [
+    {"id":"0","name":"Init","status":"completed","started_at":"2026-04-27T10:00:00Z","completed_at":"2026-04-27T10:00:30Z","tokens_in":1000,"tokens_out":200,"model":"sonnet","subs":[]}
+  ]
+}
+EOF
+node "$SCRIPT" --task-dir "$TMP" 2>/dev/null
+H1=$(md5 -q "$TMP/pipeline-run.jsonl" 2>/dev/null || md5sum "$TMP/pipeline-run.jsonl" | awk '{print $1}')
+node "$SCRIPT" --task-dir "$TMP" 2>/dev/null
+H2=$(md5 -q "$TMP/pipeline-run.jsonl" 2>/dev/null || md5sum "$TMP/pipeline-run.jsonl" | awk '{print $1}')
+if [ "$H1" = "$H2" ]; then
+  pass "two consecutive runs produce identical output"
+else
+  fail "output drift between runs ($H1 vs $H2)"
+fi
+
+# ──────────────────────────────────────────────────────────────────────────
+echo ""
+echo "══ run-aggregator smoke: $PASS passed, $FAIL failed ══"
+[ "$FAIL" -eq 0 ]

package/pipeline/scripts/smoke-schema-validation.sh

@@ -0,0 +1,173 @@
+#!/usr/bin/env bash
+# smoke-schema-validation.sh — verifies schema files are well-formed and
+# self-consistent, and that their immediate artifacts (preferences template,
+# live preferences after migration) match the expected shape.
+#
+# This is a lightweight structural check. Deep JSONSchema validation using
+# ajv/jsonschema is deferred to CI (where package deps are installed).
+
+set -uo pipefail
+
+PASS=0
+FAIL=0
+pass() { PASS=$((PASS + 1)); echo "  ✓ $1"; }
+fail() { FAIL=$((FAIL + 1)); echo "  ✗ $1"; }
+
+SCHEMAS_DIR="$HOME/.claude/schemas"
+PREFS_SCHEMA="$SCHEMAS_DIR/prefs.schema.json"
+STATE_SCHEMA="$SCHEMAS_DIR/agent-state.schema.json"
+TEMPLATE="$HOME/multi-agent-pipeline/pipeline/preferences-template.json"
+LIVE_PREFS="$HOME/.claude/multi-agent-preferences.json"
+
+# ──────────────────────────────────────────────────────────────────────────
+echo "→ 1. Schema files parse as JSON"
+for f in "$PREFS_SCHEMA" "$STATE_SCHEMA"; do
+  if [ ! -f "$f" ]; then
+    fail "missing: $f"
+    continue
+  fi
+  if node -e "JSON.parse(require('fs').readFileSync('$f', 'utf8'))" 2>/dev/null; then
+    pass "$(basename "$f") parses as JSON"
+  else
+    fail "$(basename "$f") JSON parse error"
+  fi
+done
+
+# ──────────────────────────────────────────────────────────────────────────
+echo ""
+echo "→ 2. Required schema metadata present"
+check_meta() {
+  local f="$1"
+  local k="$2"
+  local v
+  v=$(node -e "const s=JSON.parse(require('fs').readFileSync('$f','utf8')); console.log(s['$k'] || '')" 2>/dev/null)
+  if [ -n "$v" ]; then
+    pass "$(basename "$f"): $k present"
+  else
+    fail "$(basename "$f"): $k missing"
+  fi
+}
+for f in "$PREFS_SCHEMA" "$STATE_SCHEMA"; do
+  [ -f "$f" ] || continue
+  check_meta "$f" "\$schema"
+  check_meta "$f" "\$id"
+  check_meta "$f" "title"
+done
+
+# ──────────────────────────────────────────────────────────────────────────
+echo ""
+echo "→ 3. prefs.schema.json — v2.1.0 required fields present"
+REQUIRED_V21=(
+  "global.properties.identities"
+  "global.properties.keychainMapping"
+  "global.properties.platformIdentityRouting"
+  "global.properties.recentGroups"
+  "global.properties.recentBranches"
+  "global.properties.serviceStatus"
+  "global.properties.settings"
+)
+for p in "${REQUIRED_V21[@]}"; do
+  EXISTS=$(node -e "
+    const s = JSON.parse(require('fs').readFileSync('$PREFS_SCHEMA', 'utf8'));
+    const parts = 'properties.$p'.split('.');
+    let cur = s; for (const k of parts) cur = cur?.[k];
+    console.log(cur ? 'yes' : 'no');
+  " 2>/dev/null)
+  if [ "$EXISTS" = "yes" ]; then
+    pass "schema has $p"
+  else
+    fail "schema missing $p"
+  fi
+done
+
+# ──────────────────────────────────────────────────────────────────────────
+echo ""
+echo "→ 4. prefs.schema.json — keychainMapping has 12 services"
+KM_COUNT=$(node -e "
+  const s = JSON.parse(require('fs').readFileSync('$PREFS_SCHEMA', 'utf8'));
+  const km = s.properties.global.properties.keychainMapping.properties;
+  console.log(Object.keys(km).length);
+" 2>/dev/null)
+EXPECTED_SERVICES=13  # 12 + legacy "bitbucket" alias
+if [ "$KM_COUNT" = "$EXPECTED_SERVICES" ] || [ "$KM_COUNT" = "12" ]; then
+  pass "keychainMapping has $KM_COUNT services (≥12 expected)"
+else
+  fail "keychainMapping has $KM_COUNT services, expected ≥12"
+fi
+
+# ──────────────────────────────────────────────────────────────────────────
+echo ""
+echo "→ 5. agent-state.schema.json — v2.1.0 multi-repo projects[] present"
+HAS_PROJECTS=$(node -e "
+  const s = JSON.parse(require('fs').readFileSync('$STATE_SCHEMA', 'utf8'));
+  console.log(s.properties.projects ? 'yes' : 'no');
+" 2>/dev/null)
+if [ "$HAS_PROJECTS" = "yes" ]; then
+  pass "agent-state schema has projects[] (multi-repo support)"
+else
+  fail "agent-state schema missing projects[] — multi-repo not supported"
+fi
+
+# ──────────────────────────────────────────────────────────────────────────
+echo ""
+echo "→ 6. preferences-template.json — matches v2.1.0 expected shape"
+if [ -f "$TEMPLATE" ]; then
+  TVER=$(node -e "console.log(JSON.parse(require('fs').readFileSync('$TEMPLATE','utf8')).schemaVersion || 'none')" 2>/dev/null)
+  if [ "$TVER" = "2.1.0" ]; then
+    pass "template schemaVersion: $TVER"
+  else
+    fail "template schemaVersion: $TVER (expected 2.1.0)"
+  fi
+
+  # Check template has all new v2.1.0 fields
+  for field in "platformIdentityRouting" "recentGroups" "recentBranches" "serviceStatus" "settings"; do
+    EXISTS=$(node -e "
+      const t = JSON.parse(require('fs').readFileSync('$TEMPLATE','utf8'));
+      console.log(t.global && ('$field' in t.global) ? 'yes' : 'no');
+    " 2>/dev/null)
+    if [ "$EXISTS" = "yes" ]; then
+      pass "template has global.$field"
+    else
+      fail "template missing global.$field"
+    fi
+  done
+
+  # Ensure deprecated fields are not in template
+  for obsolete in "defaultPriority" "defaultIssueType" "gitIdentities"; do
+    EXISTS=$(node -e "
+      const t = JSON.parse(require('fs').readFileSync('$TEMPLATE','utf8'));
+      console.log(t.global && ('$obsolete' in t.global) ? 'yes' : 'no');
+    " 2>/dev/null)
+    if [ "$EXISTS" = "no" ]; then
+      pass "template clean of obsolete '$obsolete'"
+    else
+      fail "template still has obsolete '$obsolete'"
+    fi
+  done
+else
+  fail "template not found: $TEMPLATE"
+fi
+
+# ──────────────────────────────────────────────────────────────────────────
+echo ""
+echo "→ 7. Live preferences (if exists) — post-migration check"
+if [ -f "$LIVE_PREFS" ]; then
+  LVER=$(node -e "console.log(JSON.parse(require('fs').readFileSync('$LIVE_PREFS','utf8')).schemaVersion || 'none')" 2>/dev/null)
+  if [ "$LVER" = "2.1.0" ]; then
+    pass "live prefs already v2.1.0"
+  elif [ "$LVER" = "2.0.0" ] || [ "$LVER" = "none" ]; then
+    echo "  ⓘ live prefs still $LVER — migration pending (Aşama 1.6)"
+    # Not a fail; migration is its own step
+    pass "live prefs present, needs migration (schemaVersion: $LVER)"
+  else
+    fail "live prefs has unknown schemaVersion: $LVER"
+  fi
+else
+  echo "  ⓘ no live prefs at $LIVE_PREFS — ok for fresh install"
+  pass "no live prefs (clean setup state)"
+fi
+
+# ──────────────────────────────────────────────────────────────────────────
+echo ""
+echo "══ schema-validation smoke: $PASS passed, $FAIL failed ══"
+[ "$FAIL" -eq 0 ]

package/pipeline/scripts/smoke-search.sh

@@ -0,0 +1,187 @@
+#!/usr/bin/env bash
+# smoke-search.sh — WS v5.1.0 log-search self-verification.
+#
+# Verifies (on synthetic fixture tree, never touches real ~/.claude/logs/):
+#   1. Script executable, --help shows banner.
+#   2. Plain query returns matching tasks.
+#   3. --project filter narrows results.
+#   4. --since 7d drops old files.
+#   5. --phase N limits search to phase section.
+#   6. --limit caps results.
+#   7. JSON output is valid JSON with matched_tasks count.
+#   8. TSV output has header + one row per task.
+#   9. No-match returns exit 1 + friendly message.
+#  10. Ranking: recent matches score higher than old ones.
+
+set -uo pipefail
+
+HERE="$(cd "$(dirname "$0")" && pwd)"
+ROOT="$(cd "$HERE/../.." && pwd)"
+SEARCH="$ROOT/pipeline/scripts/search-logs.sh"
+
+PASS=0
+FAIL=0
+pass() { PASS=$((PASS+1)); echo "  ✓ $1"; }
+fail() { FAIL=$((FAIL+1)); echo "  ✗ $1"; }
+
+need() { command -v "$1" >/dev/null 2>&1 || { echo "error: $1 required" >&2; exit 127; }; }
+need jq
+
+FIX=$(mktemp -d)
+trap 'rm -rf "$FIX"' EXIT
+
+# --- Fixture tree --------------------------------------------------------
+
+# Shape: $FIX/<project>/<task_id>/agent-log.md
+
+mkdir -p "$FIX/app/PROJ-1234" "$FIX/app/PROJ-1337" "$FIX/api/API-42" "$FIX/app/PROJ-OLD"
+
+cat > "$FIX/app/PROJ-1234/agent-log.md" <<'EOF'
+# PROJ-1234 — Add flight price filter
+
+**Branch**: feature/PROJ-1234-flight-filter | **Project**: app
+
+## Phase 1: Analysis
+Explored the flight booking module.
+
+## Phase 3: Dev
+Wrote FlightFilterView. Null check added for optional price range.
+
+## Phase 4: Review
+0 blocking, 2 important, 5 suggestion.
+EOF
+
+cat > "$FIX/app/PROJ-1337/agent-log.md" <<'EOF'
+# PROJ-1337 — Guard null in BookingViewModel
+
+**Branch**: bugfix/PROJ-1337-null-deref | **Project**: app
+
+## Phase 3: Dev
+Null-deref fixed at BookingViewModel.swift:142 via guard let.
+Added regression test.
+
+## Phase 4: Review
+Reviewer flagged the null check as important. Blocking.
+EOF
+
+cat > "$FIX/api/API-42/agent-log.md" <<'EOF'
+# API-42 — Rate limit header mismatch
+
+**Branch**: bugfix/API-42-rate-limit | **Project**: api
+
+## Phase 3: Dev
+Fixed X-RateLimit-Remaining header emission.
+EOF
+
+cat > "$FIX/app/PROJ-OLD/agent-log.md" <<'EOF'
+# PROJ-OLD — Old task
+
+**Branch**: feature/PROJ-OLD-archive | **Project**: app
+
+## Phase 3: Dev
+Contains the word null but from long ago.
+EOF
+# make PROJ-OLD old: 60 days ago
+OLD_EPOCH=$(date -v-60d +%s 2>/dev/null || date -d "-60 days" +%s)
+touch -t "$(date -r "$OLD_EPOCH" +%Y%m%d%H%M 2>/dev/null || date -d "@$OLD_EPOCH" +%Y%m%d%H%M)" "$FIX/app/PROJ-OLD/agent-log.md"
+
+# --- 1. Executable + help -----------------------------------------------
+
+echo "→ 1. search-logs.sh executable + help"
+[ -x "$SEARCH" ] && pass "search-logs.sh is executable" || fail "search-logs.sh not executable"
+bash "$SEARCH" --help 2>&1 | head -1 | grep -q "search-logs" && pass "--help banner present" || fail "--help banner missing"
+
+# --- 2. Plain query -----------------------------------------------------
+
+echo ""
+echo "→ 2. plain query returns matching tasks"
+OUT=$(bash "$SEARCH" --root "$FIX" "null" 2>&1)
+echo "$OUT" | grep -q "PROJ-1337" && pass "PROJ-1337 (high match count) returned" || fail "PROJ-1337 missing"
+echo "$OUT" | grep -q "PROJ-1234" && pass "PROJ-1234 (single match) returned" || fail "PROJ-1234 missing"
+echo "$OUT" | grep -q "API-42" && fail "API-42 wrongly returned (no 'null')" || pass "API-42 correctly excluded (no 'null')"
+
+# --- 3. --project filter ------------------------------------------------
+
+echo ""
+echo "→ 3. --project filter narrows results"
+OUT=$(bash "$SEARCH" --root "$FIX" --project api "null" 2>&1)
+echo "$OUT" | grep -q "no matches" && pass "api project has no 'null' → correctly empty" || fail "api project filter leaked"
+OUT=$(bash "$SEARCH" --root "$FIX" --project app "null" 2>&1)
+echo "$OUT" | grep -q "PROJ-1234" && pass "app project filter includes PROJ-1234" || fail "app project filter broken"
+
+# --- 4. --since filter --------------------------------------------------
+
+echo ""
+echo "→ 4. --since 7d drops old tasks"
+OUT=$(bash "$SEARCH" --root "$FIX" --since 7d "null" 2>&1)
+echo "$OUT" | grep -q "PROJ-OLD" && fail "PROJ-OLD (60d) wrongly included with --since 7d" || pass "PROJ-OLD correctly dropped with --since 7d"
+echo "$OUT" | grep -q "PROJ-1337" && pass "recent PROJ-1337 still included with --since 7d" || fail "recent task lost with --since 7d"
+
+# --- 5. --phase filter --------------------------------------------------
+
+echo ""
+echo "→ 5. --phase 4 limits to phase section"
+OUT=$(bash "$SEARCH" --root "$FIX" --phase 4 "blocking" 2>&1)
+echo "$OUT" | grep -q "PROJ-1337" && pass "--phase 4 matches Phase 4 content" || fail "--phase 4 broke"
+
+# --- 6. --limit -----------------------------------------------------
+
+echo ""
+echo "→ 6. --limit caps results"
+OUT=$(bash "$SEARCH" --root "$FIX" --limit 1 "null" 2>&1)
+count=$(echo "$OUT" | grep -c "^PROJ-\|^API-\|^FIX-")
+# just verify command runs and limits in JSON (safer check)
+OUT=$(bash "$SEARCH" --root "$FIX" --limit 1 "null" --json 2>&1)
+count=$(echo "$OUT" | jq -r '.tasks | length')
+[ "$count" -eq 1 ] && pass "--limit 1 returns exactly 1 task" || fail "--limit 1 returned $count tasks"
+
+# --- 7. JSON output -----------------------------------------------------
+
+echo ""
+echo "→ 7. JSON output valid"
+OUT=$(bash "$SEARCH" --root "$FIX" "null" --json 2>&1)
+if echo "$OUT" | jq . >/dev/null 2>&1; then
+  pass "JSON is valid"
+else
+  fail "JSON invalid"
+fi
+MATCHED=$(echo "$OUT" | jq -r '.matched_tasks')
+[ "$MATCHED" -ge 2 ] && pass "JSON matched_tasks ≥ 2 (got $MATCHED)" || fail "JSON matched_tasks = $MATCHED"
+
+# --- 8. TSV output ------------------------------------------------------
+
+echo ""
+echo "→ 8. TSV output has header + rows"
+OUT=$(bash "$SEARCH" --root "$FIX" "null" --tsv 2>&1)
+echo "$OUT" | head -1 | grep -q "^score" && pass "TSV has header row" || fail "TSV missing header"
+BODY_LINES=$(echo "$OUT" | tail -n +2 | wc -l | tr -d ' ')
+[ "$BODY_LINES" -ge 2 ] && pass "TSV has ≥ 2 body rows" || fail "TSV body rows = $BODY_LINES"
+
+# --- 9. No-match path ---------------------------------------------------
+
+echo ""
+echo "→ 9. no-match → exit 1 + friendly message"
+set +e
+bash "$SEARCH" --root "$FIX" "nonexistent-string-xyz" > /tmp/search-out 2>&1
+RC=$?
+set -e
+[ "$RC" -eq 1 ] && pass "no-match exit code = 1" || fail "expected 1, got $RC"
+grep -q "no matches" /tmp/search-out && pass "no-match message shown" || fail "no-match message missing"
+
+# --- 10. Ranking: recent > old ------------------------------------------
+
+echo ""
+echo "→ 10. ranking prefers recent matches (score = matches × recency)"
+# PROJ-1234: 1 match, recent → score=100 (100% weight)
+# PROJ-1337: multiple matches, recent → score>100
+# PROJ-OLD: 1 match, 60d old → score=20 (20% weight)
+OUT=$(bash "$SEARCH" --root "$FIX" "null" --json 2>&1)
+FIRST_ID=$(echo "$OUT" | jq -r '.tasks[0].task_id')
+FIRST_SCORE=$(echo "$OUT" | jq -r '.tasks[0].score')
+[ "$FIRST_ID" = "PROJ-1337" ] && pass "highest score is PROJ-1337 ($FIRST_SCORE)" || fail "expected PROJ-1337 on top, got $FIRST_ID"
+
+# --- Summary ------------------------------------------------------------
+
+echo ""
+echo "══ search smoke: $PASS passed, $FAIL failed ══"
+[ "$FAIL" -eq 0 ]