@mmerterden/multi-agent-pipeline 8.6.0

package/pipeline/skills/figma-ios/figma-to-component/scripts/validate-phase4.sh

@@ -0,0 +1,176 @@
+#!/bin/bash
+# validate-phase4.sh — Post-Phase 4 validation for Figma-to-SwiftUI components
+# Runs after Phase 4 COLLECT_RESULTS, before UPDATE_IMPLEMENTATION_HISTORY.
+#
+# Usage: validate-phase4.sh <component-location> <component-name> [coverage-json-path]
+#
+# Arguments:
+#   component-location  Path to component directory (e.g., Sources/UIComponents/.../LabelBadge/)
+#   component-name      PascalCase component name (e.g., LabelBadge)
+#   coverage-json-path  Optional path to pass3/00_property_coverage.json
+#
+# Exit codes:
+#   0 — All checks passed
+#   1 — One or more violations found
+
+set -euo pipefail
+
+COMPONENT_LOCATION="${1:?Usage: validate-phase4.sh <component-location> <component-name> [coverage-json-path]}"
+COMPONENT_NAME="${2:?Usage: validate-phase4.sh <component-location> <component-name> [coverage-json-path]}"
+COVERAGE_JSON="${3:-}"
+
+VIEW_FILE="${COMPONENT_LOCATION}/${COMPONENT_NAME}.swift"
+VIOLATIONS=()
+
+# --- Helper ---
+add_violation() {
+    VIOLATIONS+=("$1")
+    echo "FAIL: $1"
+}
+
+# --- Check 0: File exists ---
+if [[ ! -f "$VIEW_FILE" ]]; then
+    echo "FAIL: View file not found: $VIEW_FILE"
+    exit 1
+fi
+
+echo "Validating: $VIEW_FILE"
+echo "---"
+
+# --- Check 1: No top-level enums ---
+# Top-level enums are at zero indentation (no leading whitespace).
+# Allowed: extensions on nested types (extension ComponentName.TypeName)
+if grep -nE '^(public |internal |private |fileprivate )?enum ' "$VIEW_FILE" | grep -v '^ ' | head -20 > /tmp/validate_toplevel_enums.txt 2>/dev/null; then
+    while IFS= read -r line; do
+        # Skip if it's inside a struct (check indentation — truly zero-indent lines only)
+        linenum=$(echo "$line" | cut -d: -f1)
+        content=$(sed -n "${linenum}p" "$VIEW_FILE")
+        # Check if line starts with no whitespace
+        if [[ "$content" =~ ^[[:space:]] ]]; then
+            continue  # indented = inside struct, OK
+        fi
+        add_violation "Top-level enum at line $linenum: $content"
+    done < /tmp/validate_toplevel_enums.txt
+fi
+
+# --- Check 2: No hardcoded accessibility strings ---
+# .accessibilityLabel("...") with literal English strings is forbidden.
+# Allowed: .accessibilityLabel(variable) or .accessibilityLabel(.Key.something)
+if grep -nE '\.accessibilityLabel\("[^"]+"\)' "$VIEW_FILE" > /tmp/validate_a11y.txt 2>/dev/null; then
+    while IFS= read -r line; do
+        add_violation "Hardcoded accessibility string at $line"
+    done < /tmp/validate_a11y.txt
+fi
+
+# --- Check 3: No magic numbers in body ---
+# Scan the body section for bare numeric literals not inside Constants., .Spacing., .Radius., .Size., .Font.
+# We look for patterns like: width: 24, height: 16, spacing: 8, cornerRadius: 12
+# Excluding: line numbers, array indices, opacity values (0...1), and enum raw values
+BODY_START=$(grep -n 'var body: some View' "$VIEW_FILE" | head -1 | cut -d: -f1)
+if [[ -n "$BODY_START" ]]; then
+    BODY_CONTENT=$(tail -n +"$BODY_START" "$VIEW_FILE")
+    # Look for numeric CGFloat/dimension patterns in body
+    echo "$BODY_CONTENT" | grep -nE '(width|height|spacing|cornerRadius|padding|size|offset|radius).*: [0-9]+(\.[0-9]+)?' | \
+        grep -v 'Constants\.' | \
+        grep -v '\.Spacing\.' | \
+        grep -v '\.Radius\.' | \
+        grep -v '\.Size\.' | \
+        grep -v '\.Font\.' | \
+        grep -v '//' > /tmp/validate_magic.txt 2>/dev/null || true
+    while IFS= read -r line; do
+        [[ -z "$line" ]] && continue
+        adjusted_linenum=$((BODY_START + $(echo "$line" | cut -d: -f1) - 1))
+        content=$(echo "$line" | cut -d: -f2-)
+        add_violation "Possible magic number in body at line $adjusted_linenum:$content"
+    done < /tmp/validate_magic.txt
+fi
+
+# --- Check 4: Constants placement ---
+# If enum Constants exists, it must be indented (inside the struct), not at file scope.
+if grep -n 'enum Constants' "$VIEW_FILE" > /dev/null 2>&1; then
+    CONSTANTS_LINE=$(grep -n 'enum Constants' "$VIEW_FILE" | head -1)
+    LINENUM=$(echo "$CONSTANTS_LINE" | cut -d: -f1)
+    CONTENT=$(sed -n "${LINENUM}p" "$VIEW_FILE")
+    # Check that it has leading whitespace (is indented = inside struct)
+    if [[ ! "$CONTENT" =~ ^[[:space:]]+ ]]; then
+        add_violation "Constants enum at file scope (line $LINENUM) — must be nested inside View struct"
+    fi
+    # Check it's private
+    if ! echo "$CONTENT" | grep -q 'private'; then
+        add_violation "Constants enum is not private (line $LINENUM) — must be 'private enum Constants'"
+    fi
+fi
+
+# --- Check 5: Property coverage ---
+# If coverage JSON is provided, check each IMPLEMENT property has a corresponding Swift parameter.
+if [[ -n "$COVERAGE_JSON" && -f "$COVERAGE_JSON" ]]; then
+    echo "Checking property coverage against: $COVERAGE_JSON"
+    # Extract IMPLEMENT property names using python (available on macOS)
+    IMPLEMENT_PROPS=$(python3 -c "
+import json, sys
+with open('$COVERAGE_JSON') as f:
+    data = json.load(f)
+for p in data.get('properties', []):
+    if p.get('status') == 'IMPLEMENT':
+        # Convert display name to likely Swift parameter name (camelCase)
+        name = p['name'].lstrip('\u21aa ').strip()
+        # Simple conversion: lowercase first char, remove spaces
+        words = name.split()
+        if len(words) > 1:
+            swift_name = words[0].lower() + ''.join(w.capitalize() for w in words[1:])
+        else:
+            swift_name = name[0].lower() + name[1:]
+        print(f'{name}|{swift_name}|{p.get(\"swiftType\", \"unknown\")}')
+" 2>/dev/null || true)
+
+    if [[ -n "$IMPLEMENT_PROPS" ]]; then
+        while IFS='|' read -r display_name swift_name swift_type; do
+            # Check if the swift name appears in the file (as parameter or property)
+            if ! grep -qi "$swift_name" "$VIEW_FILE" 2>/dev/null; then
+                # Also try the display name lowercased
+                lower_display=$(echo "$display_name" | tr '[:upper:]' '[:lower:]')
+                if ! grep -qi "$lower_display" "$VIEW_FILE" 2>/dev/null; then
+                    # Also try the enum/type name from swiftType (e.g., "enum IconPosition" -> "IconPosition")
+                    type_name=$(echo "$swift_type" | sed 's/^enum //' | sed 's/\?$//')
+                    if [[ -n "$type_name" ]] && grep -qi "$type_name" "$VIEW_FILE" 2>/dev/null; then
+                        : # Found via type name — property exists with a renamed parameter
+                    else
+                        add_violation "IMPLEMENT property '$display_name' (expected: $swift_name: $swift_type) not found in view"
+                    fi
+                fi
+            fi
+        done <<< "$IMPLEMENT_PROPS"
+    fi
+fi
+
+# --- Check 6: Preview struct pattern ---
+# Verify {ComponentName}Preview struct exists and dual #Preview blocks (LTR + RTL)
+PREVIEW_STRUCT="${COMPONENT_NAME}Preview"
+if ! grep -q "struct ${PREVIEW_STRUCT}" "$VIEW_FILE" 2>/dev/null; then
+    add_violation "Preview struct '${PREVIEW_STRUCT}' not found in $VIEW_FILE"
+fi
+
+RTL_PREVIEW_STRUCT="${COMPONENT_NAME}RTLPreview"
+if ! grep -q "struct ${RTL_PREVIEW_STRUCT}" "$VIEW_FILE" 2>/dev/null; then
+    add_violation "RTL Preview struct '${RTL_PREVIEW_STRUCT}' not found in $VIEW_FILE"
+fi
+
+PREVIEW_COUNT=$(grep -c '#Preview' "$VIEW_FILE" 2>/dev/null | tr -d '[:space:]' || echo "0")
+if [[ "$PREVIEW_COUNT" -eq 0 ]]; then
+    add_violation "No #Preview block found in $VIEW_FILE"
+elif [[ "$PREVIEW_COUNT" -gt 2 ]]; then
+    add_violation "Too many #Preview blocks found ($PREVIEW_COUNT) — expected 2 (LTR + RTL)"
+fi
+
+# --- Summary ---
+echo "---"
+if [[ ${#VIOLATIONS[@]} -eq 0 ]]; then
+    echo "PASS: All Phase 4 validation checks passed."
+    exit 0
+else
+    echo "VIOLATIONS: ${#VIOLATIONS[@]} found"
+    for v in "${VIOLATIONS[@]}"; do
+        echo "  - $v"
+    done
+    exit 1
+fi

package/pipeline/skills/figma-ios/figma-to-component/scripts/validate-phase6.sh

@@ -0,0 +1,147 @@
+#!/bin/bash
+# validate-phase6.sh — Post-Phase 6 validation for Code Connect files
+# Runs after Phase 6 CREATE_FIGMA_SWIFT, before VALIDATE (figma connect parse).
+#
+# Usage: validate-phase6.sh <figma-swift-path> <component-name> [component-properties-json]
+#
+# Arguments:
+#   figma-swift-path         Path to .figma.swift file
+#   component-name           PascalCase component name (e.g., LabelBadge)
+#   component-properties-json  Optional path to pass1/component_properties.json
+#
+# Exit codes:
+#   0 — All checks passed
+#   1 — One or more violations found
+
+set -euo pipefail
+
+FIGMA_SWIFT="${1:?Usage: validate-phase6.sh <figma-swift-path> <component-name> [component-properties-json]}"
+COMPONENT_NAME="${2:?Usage: validate-phase6.sh <figma-swift-path> <component-name> [component-properties-json]}"
+PROPERTIES_JSON="${3:-}"
+
+VIOLATIONS=()
+
+# --- Helper ---
+add_violation() {
+    VIOLATIONS+=("$1")
+    echo "FAIL: $1"
+}
+
+# --- Check 0: File exists ---
+if [[ ! -f "$FIGMA_SWIFT" ]]; then
+    echo "FAIL: Figma Swift file not found: $FIGMA_SWIFT"
+    exit 1
+fi
+
+echo "Validating: $FIGMA_SWIFT"
+echo "---"
+
+# --- Check 1: Implicit enum shorthand ---
+# Code Connect MUST use implicit shorthand (.case) not fully-qualified (ComponentName.EnumType.case)
+# Look for patterns like: ComponentName.SomeType.someCase
+if grep -nE "${COMPONENT_NAME}\.[A-Z][a-zA-Z]+\.[a-z]" "$FIGMA_SWIFT" > /tmp/validate_enum_qualified.txt 2>/dev/null; then
+    while IFS= read -r line; do
+        # Exclude comments
+        content=$(echo "$line" | cut -d: -f2-)
+        if [[ "$content" =~ ^[[:space:]]*//.* ]]; then
+            continue
+        fi
+        add_violation "Fully-qualified enum path at $line — use implicit shorthand (.case) instead"
+    done < /tmp/validate_enum_qualified.txt
+fi
+
+# Also check for Configuration. prefix in enum values (another common pattern)
+if grep -nE 'Configuration\.[A-Z][a-zA-Z]+\.[a-z]' "$FIGMA_SWIFT" > /tmp/validate_config_qualified.txt 2>/dev/null; then
+    while IFS= read -r line; do
+        content=$(echo "$line" | cut -d: -f2-)
+        if [[ "$content" =~ ^[[:space:]]*//.* ]]; then
+            continue
+        fi
+        add_violation "Fully-qualified Configuration enum path at $line — use implicit shorthand (.case)"
+    done < /tmp/validate_config_qualified.txt
+fi
+
+# --- Check 2: Property coverage ---
+# If component_properties.json is provided, verify @Figma annotations cover the properties.
+if [[ -n "$PROPERTIES_JSON" && -f "$PROPERTIES_JSON" ]]; then
+    echo "Checking property coverage against: $PROPERTIES_JSON"
+
+    # Extract property names from component_properties.json
+    FIGMA_PROPS=$(python3 -c "
+import json, sys
+with open('$PROPERTIES_JSON') as f:
+    data = json.load(f)
+
+# Navigate to componentPropertyDefinitions
+comp_defs = None
+if 'componentPropertyDefinitions' in data:
+    comp_defs = data['componentPropertyDefinitions']
+elif 'nodes' in data:
+    for node_id, node_data in data['nodes'].items():
+        doc = node_data.get('document', {})
+        if 'componentPropertyDefinitions' in doc:
+            comp_defs = doc['componentPropertyDefinitions']
+            break
+
+if comp_defs:
+    for key, prop in comp_defs.items():
+        prop_type = prop.get('type', 'UNKNOWN')
+        # Extract display name (before #)
+        name = key.split('#')[0]
+        print(f'{name}|{prop_type}')
+" 2>/dev/null || true)
+
+    if [[ -n "$FIGMA_PROPS" ]]; then
+        TOTAL=0
+        MAPPED=0
+        UNMAPPED_LIST=""
+
+        while IFS='|' read -r prop_name prop_type; do
+            TOTAL=$((TOTAL + 1))
+            # Check if this property is referenced in .figma.swift
+            # Look for @FigmaEnum, @FigmaBoolean, @FigmaString, @FigmaInstance annotations
+            # or the property name in mapping closures
+            if grep -qi "$prop_name" "$FIGMA_SWIFT" 2>/dev/null; then
+                MAPPED=$((MAPPED + 1))
+            else
+                UNMAPPED_LIST="${UNMAPPED_LIST}  - $prop_name ($prop_type)\n"
+            fi
+        done <<< "$FIGMA_PROPS"
+
+        if [[ -n "$UNMAPPED_LIST" ]]; then
+            echo "WARNING: $((TOTAL - MAPPED))/$TOTAL properties not found in .figma.swift:"
+            echo -e "$UNMAPPED_LIST"
+            # This is a warning, not a hard failure — some properties may be intentionally skipped
+            # Only fail if more than half are missing
+            if [[ $((TOTAL - MAPPED)) -gt $((TOTAL / 2)) ]]; then
+                add_violation "More than half of Figma properties ($((TOTAL - MAPPED))/$TOTAL) not mapped in Code Connect"
+            fi
+        else
+            echo "OK: All $TOTAL Figma properties found in .figma.swift"
+        fi
+    fi
+fi
+
+# --- Check 3: Basic structure ---
+# Verify the file conforms to FigmaConnect protocol (": FigmaConnect")
+if ! grep -q ': FigmaConnect' "$FIGMA_SWIFT" 2>/dev/null; then
+    add_violation "No FigmaConnect protocol conformance found (': FigmaConnect') — not a valid Code Connect file"
+fi
+
+# Verify the file references the component name
+if ! grep -q "$COMPONENT_NAME" "$FIGMA_SWIFT" 2>/dev/null; then
+    add_violation "Component name '$COMPONENT_NAME' not found in .figma.swift"
+fi
+
+# --- Summary ---
+echo "---"
+if [[ ${#VIOLATIONS[@]} -eq 0 ]]; then
+    echo "PASS: All Phase 6 validation checks passed."
+    exit 0
+else
+    echo "VIOLATIONS: ${#VIOLATIONS[@]} found"
+    for v in "${VIOLATIONS[@]}"; do
+        echo "  - $v"
+    done
+    exit 1
+fi