@mmerterden/multi-agent-pipeline 8.6.0

package/pipeline/skills/shared/external/app-store-review/references/privacy-manifest.md

@@ -0,0 +1,90 @@
+# Privacy Manifest Reference
+
+## Contents
+- When a Privacy Manifest Is Required
+- Privacy Manifest Structure
+- Required API Reason Codes
+- Privacy Manifest Keys Reference
+- Third-Party SDK Manifests
+- Collected Data Types Declaration
+
+## When a Privacy Manifest Is Required
+
+A `PrivacyInfo.xcprivacy` file is required if your app or any dependency uses these API categories:
+
+- File timestamp APIs (`NSPrivacyAccessedAPICategoryFileTimestamp`)
+- System boot time APIs (`NSPrivacyAccessedAPICategorySystemBootTime`)
+- Disk space APIs (`NSPrivacyAccessedAPICategoryDiskSpace`)
+- User defaults (`NSPrivacyAccessedAPICategoryUserDefaults`) when storing user-identifiable data
+- Active keyboard APIs (`NSPrivacyAccessedAPICategoryActiveKeyboards`)
+
+## Privacy Manifest Structure
+
+```xml
+<!-- PrivacyInfo.xcprivacy -->
+<?xml version="1.0" encoding="UTF-8"?>
+<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN"
+  "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
+<plist version="1.0">
+<dict>
+    <key>NSPrivacyTracking</key>
+    <false/>
+    <key>NSPrivacyTrackingDomains</key>
+    <array/>
+    <key>NSPrivacyCollectedDataTypes</key>
+    <array>
+        <!-- Declare every data type you collect -->
+    </array>
+    <key>NSPrivacyAccessedAPITypes</key>
+    <array>
+        <dict>
+            <key>NSPrivacyAccessedAPIType</key>
+            <string>NSPrivacyAccessedAPICategoryUserDefaults</string>
+            <key>NSPrivacyAccessedAPITypeReasons</key>
+            <array>
+                <string>CA92.1</string>
+            </array>
+        </dict>
+    </array>
+</dict>
+</plist>
+```
+
+## Required API Reason Codes
+
+| API Category | Code | Reason |
+|---|---|---|
+| FileTimestamp | `C617.1` | Access files inside app container |
+| FileTimestamp | `3B52.1` | Access user-selected files |
+| FileTimestamp | `0A2A.1` | Third-party SDK accessed on behalf of user |
+| SystemBootTime | `35F9.1` | Measure elapsed time between events |
+| DiskSpace | `E174.1` | Check available space before writes |
+| UserDefaults | `CA92.1` | Access within your own app |
+| UserDefaults | `1C8F.1` | Access within same app group |
+| ActiveKeyboards | `3EC4.1` | Customize UI based on active keyboards |
+
+## Privacy Manifest Keys Reference
+
+| Key | Type | Purpose |
+|---|---|---|
+| `NSPrivacyTracking` | Boolean | Whether the app tracks users (triggers ATT requirement) |
+| `NSPrivacyTrackingDomains` | Array of strings | Domains used for tracking (connected only after ATT consent) |
+| `NSPrivacyCollectedDataTypes` | Array of dicts | Each data type collected, its purpose, and whether it is linked to identity |
+| `NSPrivacyAccessedAPITypes` | Array of dicts | Each required-reason API used and the justification codes |
+
+## Third-Party SDK Manifests
+
+- Verify each SDK contains `PrivacyInfo.xcprivacy` in its bundle
+- Ensure SDK reason codes match actual usage
+- Update SDK versions when manifests are missing
+
+## Collected Data Types Declaration
+
+Each `NSPrivacyCollectedDataTypes` entry must specify:
+
+- `NSPrivacyCollectedDataType` (category)
+- `NSPrivacyCollectedDataTypeLinked` (linked to identity)
+- `NSPrivacyCollectedDataTypeTracking` (used for tracking)
+- `NSPrivacyCollectedDataTypePurposes` (purposes array)
+
+Apple cross-references manifests with privacy nutrition labels and network traffic. Mismatches cause rejection.

package/pipeline/skills/shared/external/app-store-review/references/rejection-patterns.md

@@ -0,0 +1,152 @@
+# High-Risk Rejection Patterns
+
+Source: Apple App Store Review Guidelines + common rejection patterns from community data.
+
+## Contents
+- Critical Risk (Instant Rejection)
+- High Risk
+- Medium Risk
+- SDK Signature Requirements (ITMS-91065)
+
+## Critical Risk (Instant Rejection)
+
+### Private API Usage (2.5.1)
+Apple scans binaries for private API selectors. Any match = instant rejection.
+- Do not use `_` prefixed selectors
+- Do not call methods via `performSelector` to bypass detection
+- Third-party SDKs may contain private API calls — audit them
+
+### Dynamic Code Execution (2.5.2)
+- No downloading and executing code (except JavaScript in WKWebView)
+- No JSPatch, Rollout, or similar hot-patching frameworks
+- CodePush / OTA updates for JavaScript-only changes in React Native are allowed with restrictions
+
+### Hidden Features / Kill Switches (2.3.1)
+- No time-based feature reveals
+- No remote config that changes core functionality after review
+- No A/B tests that show reviewer different UI than users
+
+### Malware / Privacy Violations (5.1.1)
+- No accessing clipboard without user action
+- No scanning contacts/photos silently
+- No fingerprinting (device ID, ad ID without ATT)
+
+## High Risk
+
+### Missing SDK Signatures (ITMS-91065)
+Apple requires commonly used third-party SDKs to include a code signature. This applies to:
+- Binary frameworks (.framework, .xcframework) distributed via CocoaPods, Carthage, or manual embedding
+- SDKs on Apple's "commonly used" list
+
+**Fixes:**
+1. **Update SDK** to a version that includes a signature (preferred)
+2. **Sign the framework yourself** if the vendor hasn't updated:
+   ```bash
+   codesign --force --sign "Apple Distribution: Your Company (TEAM_ID)" \
+     --preserve-metadata=identifier,entitlements \
+     Frameworks/SDKName.framework
+   ```
+3. **Replace binary framework with source** — add the SDK's source files directly to your project instead of embedding the pre-built binary. This eliminates the signature requirement entirely.
+4. **Switch to XCFramework** — if the vendor provides an `.xcframework` with a signature, use that instead of the legacy `.framework`
+
+**Verification:**
+```bash
+# Check if a framework is signed
+codesign -dv --verbose=2 Frameworks/SDKName.framework
+
+# Verify signature validity
+codesign --verify --deep --strict Frameworks/SDKName.framework
+```
+
+### Push Notification Entitlement Mismatch (2.5)
+- `aps-environment` must be `production` in App Store builds
+- Profile must include Push Notification capability
+- If push not used, remove entitlement entirely
+
+### Background Mode Abuse (2.5.4)
+Apple audits background mode claims:
+- `audio` — must actually play audio, not just keep app alive
+- `location` — must have visible user-facing location feature
+- `voip` — must be an actual VoIP app
+- `fetch` — must fetch meaningful content
+- `processing` — must perform legitimate background processing
+
+Claiming unused background modes = rejection.
+
+### Incomplete App (2.1)
+- Broken features, placeholder content
+- Features requiring hardware reviewer lacks
+- Missing demo credentials
+- Server-dependent features that are down during review
+
+### WebView-Only Apps (4.2)
+- WKWebView wrapper without native features = rejected
+- Must add meaningful native functionality (push, offline, haptics, etc.)
+
+## Medium Risk
+
+### Missing Restore Purchases (3.1.1)
+- Every app with IAP must have a "Restore Purchases" button
+- It must work and actually restore prior purchases
+
+### Inaccurate Screenshots (2.3.1)
+- Screenshots must match actual app UI
+- No features shown that don't exist
+- No misleading marketing renders
+
+### Missing Privacy Policy (5.1.1)
+- Privacy policy URL required in App Store Connect
+- Must be accessible within the app
+- Must describe data collection accurately
+
+### Usage Description Too Vague (5.1.1)
+- "This app needs your camera" → REJECTED
+- "The camera scans boarding pass barcodes for check-in" → APPROVED
+- Must explain specific feature, not generic need
+
+### iPad Support Issues (4.1)
+- Universal apps must look proper on iPad
+- No letterboxed iPhone UI on iPad
+- Must support multitasking (Slide Over, Split View)
+
+### App Name Issues (2.3.7)
+- No generic descriptive names ("Photo Editor")
+- No competitor names or trademarked terms
+- Max 30 characters
+
+## SDK Signature Requirements (ITMS-91065) — Deep Dive
+
+Starting 2024, Apple requires third-party SDK binaries to be signed. This is one of the most common new rejection reasons.
+
+### Which SDKs Are Affected
+Apple maintains a list of "commonly used third-party SDKs." Known affected SDKs include (but are not limited to):
+- Firebase / Google Analytics
+- Facebook SDK
+- Alamofire (when embedded as binary)
+- Lottie (when embedded as binary)
+- SDWebImage (when embedded as binary)
+- Toast-Swift / Toast (when embedded as binary)
+- Kingfisher (when embedded as binary)
+- Any SDK on Apple's privacy-impacting SDK list
+
+### Resolution Priority
+1. **Best:** Use SPM or CocoaPods source integration (no binary = no signature needed)
+2. **Good:** Update to SDK version with included signature
+3. **Acceptable:** Replace binary framework with source files in project
+4. **Last resort:** Manually sign the binary framework
+
+### How to Check if Your Build Has Unsigned SDKs
+```bash
+# After archiving, inspect all frameworks
+find YourApp.xcarchive -name "*.framework" -exec codesign -dv {} \; 2>&1
+
+# Any framework showing "code object is not signed at all" needs attention
+```
+
+### Preventing Future Issues
+- Prefer SPM or source-based CocoaPods over binary frameworks
+- When adding new binary dependencies, verify signature:
+  ```bash
+  codesign --verify --deep --strict NewSDK.framework
+  ```
+- Add framework signature verification to CI/CD pipeline

package/pipeline/skills/shared/external/app-store-review/references/review-checklists.md

@@ -0,0 +1,118 @@
+# App Store Review Checklists
+
+## Contents
+- App Review Information Checklist
+- Privacy Manifest Checklist
+- In-App Purchase Checklist
+- HIG Compliance Checklist
+- Pre-Submission Checklist
+
+## App Review Information Checklist
+
+Use this to avoid Guideline 2.1 rejections:
+
+- [ ] Demo credentials provided in App Review Information notes (if login required)
+- [ ] Demo account works and has access to all features
+- [ ] All screens have real content (no placeholders or Lorem Ipsum)
+- [ ] No broken links or dead-end flows
+- [ ] All hardware-required features have fallback or reviewer instructions
+
+## Privacy Manifest Checklist
+
+Verify PrivacyInfo.xcprivacy completeness:
+
+- [ ] `PrivacyInfo.xcprivacy` exists in app bundle
+- [ ] All required API categories are declared with reason codes
+- [ ] `NSPrivacyTracking` is true only if tracking occurs
+- [ ] Third-party SDK manifests present and up to date
+- [ ] Privacy nutrition labels match actual data collection
+
+## In-App Purchase Checklist
+
+- [ ] All digital goods use StoreKit IAP
+- [ ] Subscription pricing and auto-renewal terms shown before purchase
+- [ ] Restore purchases button present and functional
+- [ ] Ask-to-buy and interrupted purchases handled
+- [ ] Transaction verification uses StoreKit 2 or server-side verification
+
+## HIG Compliance Checklist
+
+### Navigation
+- [ ] `NavigationStack` used (not `NavigationView`)
+- [ ] System back chevron used; no custom back icons
+- [ ] Tab bar uses <= 5 tabs; use More tab if needed
+- [ ] Avoid hamburger menus
+
+### Modals and Sheets
+- [ ] Sheets have a visible dismiss control
+- [ ] Full-screen modals have close/done button
+- [ ] Alerts use system alert styles
+
+### System Feature Support
+- [ ] Dark Mode renders correctly
+- [ ] Dynamic Type supported throughout
+- [ ] iPad multitasking supported (Slide Over, Split View)
+- [ ] Dynamic Island / Live Activities render correctly when used
+- [ ] System gestures not disabled
+
+### Widgets and Live Activities
+- [ ] Widgets show real content (not placeholders)
+- [ ] Timelines update meaningfully
+- [ ] Live Activities show time-sensitive info
+- [ ] Lock Screen widgets are legible at small sizes
+
+## Pre-Submission Checklist
+
+### Completeness
+- [ ] No placeholder or test content
+- [ ] All features functional without special hardware
+- [ ] Demo credentials provided
+- [ ] No dead-end screens
+
+### Metadata
+- [ ] App name matches functionality
+- [ ] Screenshots are real app screenshots
+- [ ] Description contains no prices or competitor mentions
+- [ ] Category is correct
+
+### Privacy
+- [ ] Privacy manifest present with required reason codes
+- [ ] Third-party SDK manifests verified
+- [ ] Privacy policy URL present and accessible
+- [ ] Nutrition labels match actual data collection
+- [ ] ATT prompt only if tracking occurs
+
+### Payments
+- [ ] Digital content uses IAP
+- [ ] Subscription terms visible before purchase
+- [ ] No external payment links
+- [ ] Free trial terms clear
+- [ ] Restore purchases implemented
+
+### Design
+- [ ] Standard navigation patterns used
+- [ ] Dark Mode supported
+- [ ] Dynamic Type supported
+- [ ] No custom alerts mimicking system alerts
+- [ ] Launch screen not an ad
+- [ ] Empty states provide guidance
+
+### Technical
+- [ ] Built with current Xcode GM
+- [ ] No private API usage
+- [ ] No dynamic code execution
+- [ ] Entitlements justified with usage descriptions
+- [ ] Background modes justified and used
+- [ ] Minimum deployment target covers latest two major iOS versions
+
+### Code Signing
+- [ ] Archive uses Apple Distribution certificate (not Development)
+- [ ] All provisioning profiles are App Store type and not expired
+- [ ] All targets use same team ID
+- [ ] Binary entitlements match provisioning profile capabilities
+- [ ] No `get-task-allow` entitlement in Release build
+- [ ] All embedded frameworks signed with distribution identity
+- [ ] No simulator architectures in embedded frameworks
+- [ ] Push environment is `production` in Release
+- [ ] Third-party binary SDKs are signed (ITMS-91065)
+- [ ] `codesign --verify --deep --strict` passes on app bundle