@cregis-dev/cckit 0.4.1 → 0.6.1

package/templates/bmad/tea/workflows/testarch/test-review/steps-c/step-03c-subagent-maintainability.md

@@ -1,102 +0,0 @@
----
-name: 'step-03c-subagent-maintainability'
-description: 'Subagent: Check test maintainability (readability, structure, DRY)'
-subagent: true
-outputFile: '/tmp/tea-test-review-maintainability-{{timestamp}}.json'
----
-
-# Subagent 3C: Maintainability Quality Check
-
-## SUBAGENT CONTEXT
-
-This is an **isolated subagent** running in parallel with other quality dimension checks.
-
-**Your task:** Analyze test files for MAINTAINABILITY violations only.
-
----
-
-## MANDATORY EXECUTION RULES
-
-- ✅ Check MAINTAINABILITY only (not other quality dimensions)
-- ✅ Output structured JSON to temp file
-- ❌ Do NOT check determinism, isolation, coverage, or performance
-
----
-
-## SUBAGENT TASK
-
-### 1. Identify Maintainability Violations
-
-**HIGH SEVERITY Violations**:
-
-- Tests >100 lines (too complex)
-- No test.describe grouping
-- Duplicate test logic (copy-paste)
-- Unclear test names (no Given/When/Then structure)
-- Magic numbers/strings without constants
-
-**MEDIUM SEVERITY Violations**:
-
-- Tests missing comments for complex logic
-- Inconsistent naming conventions
-- Excessive nesting (>3 levels)
-- Large setup/teardown blocks
-
-**LOW SEVERITY Violations**:
-
-- Minor code style issues
-- Could benefit from helper functions
-- Inconsistent assertion styles
-
-### 2. Calculate Maintainability Score
-
-```javascript
-const severityWeights = { HIGH: 10, MEDIUM: 5, LOW: 2 };
-const totalPenalty = violations.reduce((sum, v) => sum + severityWeights[v.severity], 0);
-const score = Math.max(0, 100 - totalPenalty);
-```
-
----
-
-## OUTPUT FORMAT
-
-```json
-{
-  "dimension": "maintainability",
-  "score": 75,
-  "max_score": 100,
-  "grade": "C",
-  "violations": [
-    {
-      "file": "tests/e2e/complex-flow.spec.ts",
-      "line": 1,
-      "severity": "HIGH",
-      "category": "test-too-long",
-      "description": "Test file is 250 lines - too complex to maintain",
-      "suggestion": "Split into multiple smaller test files by feature area",
-      "code_snippet": "test.describe('Complex flow', () => { /* 250 lines */ });"
-    }
-  ],
-  "passed_checks": 10,
-  "failed_checks": 5,
-  "violation_summary": {
-    "HIGH": 2,
-    "MEDIUM": 2,
-    "LOW": 1
-  },
-  "recommendations": [
-    "Split large test files into smaller, focused files (<100 lines each)",
-    "Add test.describe grouping for related tests",
-    "Extract duplicate logic into helper functions"
-  ],
-  "summary": "Tests have maintainability issues - 5 violations (2 HIGH)"
-}
-```
-
----
-
-## EXIT CONDITION
-
-Subagent completes when JSON output written to temp file.
-
-**Subagent terminates here.**

package/templates/bmad/tea/workflows/testarch/test-review/steps-c/step-03c-subprocess-maintainability.md

@@ -1,102 +0,0 @@
----
-name: 'step-03c-subprocess-maintainability'
-description: 'Subprocess: Check test maintainability (readability, structure, DRY)'
-subprocess: true
-outputFile: '/tmp/tea-test-review-maintainability-{{timestamp}}.json'
----
-
-# Subprocess 3C: Maintainability Quality Check
-
-## SUBPROCESS CONTEXT
-
-This is an **isolated subprocess** running in parallel with other quality dimension checks.
-
-**Your task:** Analyze test files for MAINTAINABILITY violations only.
-
----
-
-## MANDATORY EXECUTION RULES
-
-- ✅ Check MAINTAINABILITY only (not other quality dimensions)
-- ✅ Output structured JSON to temp file
-- ❌ Do NOT check determinism, isolation, coverage, or performance
-
----
-
-## SUBPROCESS TASK
-
-### 1. Identify Maintainability Violations
-
-**HIGH SEVERITY Violations**:
-
-- Tests >100 lines (too complex)
-- No test.describe grouping
-- Duplicate test logic (copy-paste)
-- Unclear test names (no Given/When/Then structure)
-- Magic numbers/strings without constants
-
-**MEDIUM SEVERITY Violations**:
-
-- Tests missing comments for complex logic
-- Inconsistent naming conventions
-- Excessive nesting (>3 levels)
-- Large setup/teardown blocks
-
-**LOW SEVERITY Violations**:
-
-- Minor code style issues
-- Could benefit from helper functions
-- Inconsistent assertion styles
-
-### 2. Calculate Maintainability Score
-
-```javascript
-const severityWeights = { HIGH: 10, MEDIUM: 5, LOW: 2 };
-const totalPenalty = violations.reduce((sum, v) => sum + severityWeights[v.severity], 0);
-const score = Math.max(0, 100 - totalPenalty);
-```
-
----
-
-## OUTPUT FORMAT
-
-```json
-{
-  "dimension": "maintainability",
-  "score": 75,
-  "max_score": 100,
-  "grade": "C",
-  "violations": [
-    {
-      "file": "tests/e2e/complex-flow.spec.ts",
-      "line": 1,
-      "severity": "HIGH",
-      "category": "test-too-long",
-      "description": "Test file is 250 lines - too complex to maintain",
-      "suggestion": "Split into multiple smaller test files by feature area",
-      "code_snippet": "test.describe('Complex flow', () => { /* 250 lines */ });"
-    }
-  ],
-  "passed_checks": 10,
-  "failed_checks": 5,
-  "violation_summary": {
-    "HIGH": 2,
-    "MEDIUM": 2,
-    "LOW": 1
-  },
-  "recommendations": [
-    "Split large test files into smaller, focused files (<100 lines each)",
-    "Add test.describe grouping for related tests",
-    "Extract duplicate logic into helper functions"
-  ],
-  "summary": "Tests have maintainability issues - 5 violations (2 HIGH)"
-}
-```
-
----
-
-## EXIT CONDITION
-
-Subprocess completes when JSON output written to temp file.
-
-**Subprocess terminates here.**

package/templates/bmad/tea/workflows/testarch/test-review/steps-c/step-03d-subprocess-coverage.md

@@ -1,111 +0,0 @@
----
-name: 'step-03d-subprocess-coverage'
-description: 'Subprocess: Check test coverage (completeness, edge cases)'
-subprocess: true
-outputFile: '/tmp/tea-test-review-coverage-{{timestamp}}.json'
----
-
-# Subprocess 3D: Coverage Quality Check
-
-## SUBPROCESS CONTEXT
-
-This is an **isolated subprocess** running in parallel with other quality dimension checks.
-
-**Your task:** Analyze test files for COVERAGE violations only.
-
----
-
-## MANDATORY EXECUTION RULES
-
-- ✅ Check COVERAGE only (not other quality dimensions)
-- ✅ Output structured JSON to temp file
-- ❌ Do NOT check determinism, isolation, maintainability, or performance
-
----
-
-## SUBPROCESS TASK
-
-### 1. Identify Coverage Violations
-
-**HIGH SEVERITY Violations**:
-
-- Critical user paths not tested (P0 functionality missing)
-- API endpoints without tests
-- Error handling not tested (no negative test cases)
-- Missing authentication/authorization tests
-
-**MEDIUM SEVERITY Violations**:
-
-- Edge cases not covered (boundary values, null/empty inputs)
-- Only happy path tested (no error scenarios)
-- Missing integration tests (only unit or only E2E)
-- Insufficient assertion coverage (tests don't verify important outcomes)
-
-**LOW SEVERITY Violations**:
-
-- Could benefit from additional test cases
-- Minor edge cases not covered
-- Documentation incomplete
-
-### 2. Calculate Coverage Score
-
-```javascript
-const criticalGaps = violations.filter((v) => v.severity === 'HIGH').length;
-const score = criticalGaps === 0 ? Math.max(0, 100 - violations.length * 5) : Math.max(0, 50 - criticalGaps * 10); // Heavy penalty for critical gaps
-```
-
----
-
-## OUTPUT FORMAT
-
-```json
-{
-  "dimension": "coverage",
-  "score": 70,
-  "max_score": 100,
-  "grade": "C",
-  "violations": [
-    {
-      "file": "tests/api/",
-      "severity": "HIGH",
-      "category": "missing-endpoint-tests",
-      "description": "API endpoint /api/users/delete not tested",
-      "suggestion": "Add tests for user deletion including error scenarios"
-    },
-    {
-      "file": "tests/e2e/checkout.spec.ts",
-      "line": 25,
-      "severity": "MEDIUM",
-      "category": "missing-error-case",
-      "description": "Only happy path tested - no error handling tests",
-      "suggestion": "Add tests for payment failure, network errors, validation failures"
-    }
-  ],
-  "passed_checks": 8,
-  "failed_checks": 4,
-  "violation_summary": {
-    "HIGH": 1,
-    "MEDIUM": 2,
-    "LOW": 1
-  },
-  "coverage_gaps": {
-    "untested_endpoints": ["/api/users/delete", "/api/orders/cancel"],
-    "untested_user_paths": ["Password reset flow"],
-    "missing_error_scenarios": ["Payment failures", "Network timeouts"]
-  },
-  "recommendations": [
-    "Add tests for all CRUD operations (especially DELETE)",
-    "Test error scenarios for each user path",
-    "Add integration tests between API and E2E layers"
-  ],
-  "summary": "Coverage has critical gaps - 4 violations (1 HIGH critical endpoint missing)"
-}
-```
-
----
-
-## EXIT CONDITION
-
-Subprocess completes when JSON output written to temp file.
-
-**Subprocess terminates here.**

package/templates/bmad/tea/workflows/testarch/test-review/steps-c/step-03e-subagent-performance.md

@@ -1,117 +0,0 @@
----
-name: 'step-03e-subagent-performance'
-description: 'Subagent: Check test performance (speed, efficiency, parallelization)'
-subagent: true
-outputFile: '/tmp/tea-test-review-performance-{{timestamp}}.json'
----
-
-# Subagent 3E: Performance Quality Check
-
-## SUBAGENT CONTEXT
-
-This is an **isolated subagent** running in parallel with other quality dimension checks.
-
-**Your task:** Analyze test files for PERFORMANCE violations only.
-
----
-
-## MANDATORY EXECUTION RULES
-
-- ✅ Check PERFORMANCE only (not other quality dimensions)
-- ✅ Output structured JSON to temp file
-- ❌ Do NOT check determinism, isolation, maintainability, or coverage
-
----
-
-## SUBAGENT TASK
-
-### 1. Identify Performance Violations
-
-**HIGH SEVERITY Violations**:
-
-- Tests not parallelizable (using test.describe.serial unnecessarily)
-- Slow setup/teardown (creating fresh DB for every test)
-- Excessive navigation (reloading pages unnecessarily)
-- No fixture reuse (repeating expensive operations)
-
-**MEDIUM SEVERITY Violations**:
-
-- Hard waits >2 seconds (waitForTimeout(5000))
-- Inefficient selectors (page.$$ instead of locators)
-- Large data sets in tests without pagination
-- Missing performance optimizations
-
-**LOW SEVERITY Violations**:
-
-- Could use parallelization (test.describe.configure({ mode: 'parallel' }))
-- Minor inefficiencies
-- Excessive logging
-
-### 2. Calculate Performance Score
-
-```javascript
-const severityWeights = { HIGH: 10, MEDIUM: 5, LOW: 2 };
-const totalPenalty = violations.reduce((sum, v) => sum + severityWeights[v.severity], 0);
-const score = Math.max(0, 100 - totalPenalty);
-```
-
----
-
-## OUTPUT FORMAT
-
-```json
-{
-  "dimension": "performance",
-  "score": 80,
-  "max_score": 100,
-  "grade": "B",
-  "violations": [
-    {
-      "file": "tests/e2e/search.spec.ts",
-      "line": 10,
-      "severity": "HIGH",
-      "category": "not-parallelizable",
-      "description": "Tests use test.describe.serial unnecessarily - reduces parallel execution",
-      "suggestion": "Remove .serial unless tests truly share state",
-      "code_snippet": "test.describe.serial('Search tests', () => { ... });"
-    },
-    {
-      "file": "tests/api/bulk-operations.spec.ts",
-      "line": 35,
-      "severity": "MEDIUM",
-      "category": "slow-setup",
-      "description": "Test creates 1000 records in setup - very slow",
-      "suggestion": "Use smaller data sets or fixture factories",
-      "code_snippet": "beforeEach(async () => { for (let i=0; i<1000; i++) { ... } });"
-    }
-  ],
-  "passed_checks": 13,
-  "failed_checks": 2,
-  "violation_summary": {
-    "HIGH": 1,
-    "MEDIUM": 1,
-    "LOW": 0
-  },
-  "performance_metrics": {
-    "parallelizable_tests": 80,
-    "serial_tests": 20,
-    "avg_test_duration_estimate": "~2 seconds",
-    "slow_tests": ["bulk-operations.spec.ts (>30s)"]
-  },
-  "recommendations": [
-    "Enable parallel mode where possible",
-    "Reduce setup data to minimum needed",
-    "Use fixtures to share expensive setup across tests",
-    "Remove unnecessary .serial constraints"
-  ],
-  "summary": "Good performance with 2 violations - 80% tests can run in parallel"
-}
-```
-
----
-
-## EXIT CONDITION
-
-Subagent completes when JSON output written to temp file.
-
-**Subagent terminates here.**

package/templates/bmad/tea/workflows/testarch/test-review/steps-c/step-03e-subprocess-performance.md

@@ -1,117 +0,0 @@
----
-name: 'step-03e-subprocess-performance'
-description: 'Subprocess: Check test performance (speed, efficiency, parallelization)'
-subprocess: true
-outputFile: '/tmp/tea-test-review-performance-{{timestamp}}.json'
----
-
-# Subprocess 3E: Performance Quality Check
-
-## SUBPROCESS CONTEXT
-
-This is an **isolated subprocess** running in parallel with other quality dimension checks.
-
-**Your task:** Analyze test files for PERFORMANCE violations only.
-
----
-
-## MANDATORY EXECUTION RULES
-
-- ✅ Check PERFORMANCE only (not other quality dimensions)
-- ✅ Output structured JSON to temp file
-- ❌ Do NOT check determinism, isolation, maintainability, or coverage
-
----
-
-## SUBPROCESS TASK
-
-### 1. Identify Performance Violations
-
-**HIGH SEVERITY Violations**:
-
-- Tests not parallelizable (using test.describe.serial unnecessarily)
-- Slow setup/teardown (creating fresh DB for every test)
-- Excessive navigation (reloading pages unnecessarily)
-- No fixture reuse (repeating expensive operations)
-
-**MEDIUM SEVERITY Violations**:
-
-- Hard waits >2 seconds (waitForTimeout(5000))
-- Inefficient selectors (page.$$ instead of locators)
-- Large data sets in tests without pagination
-- Missing performance optimizations
-
-**LOW SEVERITY Violations**:
-
-- Could use parallelization (test.describe.configure({ mode: 'parallel' }))
-- Minor inefficiencies
-- Excessive logging
-
-### 2. Calculate Performance Score
-
-```javascript
-const severityWeights = { HIGH: 10, MEDIUM: 5, LOW: 2 };
-const totalPenalty = violations.reduce((sum, v) => sum + severityWeights[v.severity], 0);
-const score = Math.max(0, 100 - totalPenalty);
-```
-
----
-
-## OUTPUT FORMAT
-
-```json
-{
-  "dimension": "performance",
-  "score": 80,
-  "max_score": 100,
-  "grade": "B",
-  "violations": [
-    {
-      "file": "tests/e2e/search.spec.ts",
-      "line": 10,
-      "severity": "HIGH",
-      "category": "not-parallelizable",
-      "description": "Tests use test.describe.serial unnecessarily - reduces parallel execution",
-      "suggestion": "Remove .serial unless tests truly share state",
-      "code_snippet": "test.describe.serial('Search tests', () => { ... });"
-    },
-    {
-      "file": "tests/api/bulk-operations.spec.ts",
-      "line": 35,
-      "severity": "MEDIUM",
-      "category": "slow-setup",
-      "description": "Test creates 1000 records in setup - very slow",
-      "suggestion": "Use smaller data sets or fixture factories",
-      "code_snippet": "beforeEach(async () => { for (let i=0; i<1000; i++) { ... } });"
-    }
-  ],
-  "passed_checks": 13,
-  "failed_checks": 2,
-  "violation_summary": {
-    "HIGH": 1,
-    "MEDIUM": 1,
-    "LOW": 0
-  },
-  "performance_metrics": {
-    "parallelizable_tests": 80,
-    "serial_tests": 20,
-    "avg_test_duration_estimate": "~2 seconds",
-    "slow_tests": ["bulk-operations.spec.ts (>30s)"]
-  },
-  "recommendations": [
-    "Enable parallel mode where possible",
-    "Reduce setup data to minimum needed",
-    "Use fixtures to share expensive setup across tests",
-    "Remove unnecessary .serial constraints"
-  ],
-  "summary": "Good performance with 2 violations - 80% tests can run in parallel"
-}
-```
-
----
-
-## EXIT CONDITION
-
-Subprocess completes when JSON output written to temp file.
-
-**Subprocess terminates here.**