@cesium/engine 23.0.1 → 25.0.0

package/Source/Scene/VoxelEllipsoidShape.js

@@ -67,6 +67,14 @@ function VoxelEllipsoidShape() {
    */
   this._rotation = new Matrix3();
 
+  /**
+   * UV space transformation translations (JS-only, not shader uniforms)
+   * Components: [longitude, latitude, height] translation
+   * @type {Cartesian3}
+   * @private
+   */
+  this._localToShapeUvTranslate = new Cartesian3();
+
   this._shaderUniforms = {
     cameraPositionCartographic: new Cartesian3(),
     ellipsoidEcToEastNorthUp: new Matrix3(),
@@ -78,10 +86,8 @@ function VoxelEllipsoidShape() {
     ellipsoidRenderLongitudeMinMax: new Cartesian2(),
     ellipsoidShapeUvLongitudeRangeOrigin: 0.0,
     ellipsoidShapeUvLongitudeMinMaxMid: new Cartesian3(),
-    ellipsoidLocalToShapeUvLongitude: new Cartesian2(),
-    ellipsoidLocalToShapeUvLatitude: new Cartesian2(),
+    ellipsoidLocalToShapeUvScale: new Cartesian3(),
     ellipsoidRenderLatitudeSinMinMax: new Cartesian2(),
-    ellipsoidInverseHeightDifference: 0.0,
     clipMinMaxHeight: new Cartesian2(),
   };
 
@@ -90,10 +96,7 @@ function VoxelEllipsoidShape() {
     ELLIPSOID_HAS_RENDER_BOUNDS_LONGITUDE_RANGE_EQUAL_ZERO: undefined,
     ELLIPSOID_HAS_RENDER_BOUNDS_LONGITUDE_RANGE_UNDER_HALF: undefined,
     ELLIPSOID_HAS_RENDER_BOUNDS_LONGITUDE_RANGE_OVER_HALF: undefined,
-    ELLIPSOID_HAS_RENDER_BOUNDS_LONGITUDE_MIN_DISCONTINUITY: undefined,
-    ELLIPSOID_HAS_RENDER_BOUNDS_LONGITUDE_MAX_DISCONTINUITY: undefined,
     ELLIPSOID_HAS_SHAPE_BOUNDS_LONGITUDE: undefined,
-    ELLIPSOID_HAS_SHAPE_BOUNDS_LONGITUDE_MIN_MAX_REVERSED: undefined,
     ELLIPSOID_HAS_RENDER_BOUNDS_LATITUDE_MAX_UNDER_HALF: undefined,
     ELLIPSOID_HAS_RENDER_BOUNDS_LATITUDE_MAX_EQUAL_HALF: undefined,
     ELLIPSOID_HAS_RENDER_BOUNDS_LATITUDE_MAX_OVER_HALF: undefined,
@@ -245,7 +248,6 @@ VoxelEllipsoidShape.prototype.update = function (
   //>>includeEnd('debug');
 
   const epsilonZeroScale = CesiumMath.EPSILON10;
-  const epsilonLongitudeDiscontinuity = CesiumMath.EPSILON3; // 0.001 radians = 0.05729578 degrees
   const epsilonLongitude = CesiumMath.EPSILON10;
   const epsilonLatitude = CesiumMath.EPSILON10;
   const epsilonLatitudeFlat = CesiumMath.EPSILON3; // 0.001 radians = 0.05729578 degrees
@@ -519,10 +521,7 @@ VoxelEllipsoidShape.prototype.update = function (
 
   // The percent of space that is between the inner and outer ellipsoid.
   const thickness = shapeMaxBounds.z - shapeMinBounds.z;
-  shaderUniforms.ellipsoidInverseHeightDifference = 1.0 / thickness;
-  if (shapeMinBounds.z === shapeMaxBounds.z) {
-    shaderUniforms.ellipsoidInverseHeightDifference = 0.0;
-  }
+  const heightScale = thickness === 0.0 ? 0.0 : 1.0 / thickness;
 
   // Intersects a wedge for the min and max longitude.
   if (renderHasLongitude) {
@@ -550,6 +549,10 @@ VoxelEllipsoidShape.prototype.update = function (
     );
   }
 
+  // Defaults are for the case where shapeLongitudeRange is zero, to avoid division by zero.
+  let longitudeScale = 0.0;
+  let longitudeOffset = 1.0;
+
   if (shapeHasLongitude) {
     shaderDefines["ELLIPSOID_HAS_SHAPE_BOUNDS_LONGITUDE"] = true;
 
@@ -565,73 +568,15 @@ VoxelEllipsoidShape.prototype.update = function (
     shaderUniforms.ellipsoidShapeUvLongitudeRangeOrigin =
       uvLongitudeRangeOrigin;
 
-    const shapeIsLongitudeReversed = shapeMaxBounds.x < shapeMinBounds.x;
-    if (shapeIsLongitudeReversed) {
-      shaderDefines["ELLIPSOID_HAS_SHAPE_BOUNDS_LONGITUDE_MIN_MAX_REVERSED"] =
-        true;
-    }
-
-    if (shapeLongitudeRange <= epsilonLongitude) {
-      shaderUniforms.ellipsoidLocalToShapeUvLongitude = Cartesian2.fromElements(
-        0.0,
-        1.0,
-        shaderUniforms.ellipsoidLocalToShapeUvLongitude,
-      );
-    } else {
-      const scale = defaultLongitudeRange / shapeLongitudeRange;
+    if (shapeLongitudeRange > epsilonLongitude) {
+      longitudeScale = defaultLongitudeRange / shapeLongitudeRange;
       const shiftedMinLongitude = uvShapeMinLongitude - uvLongitudeRangeOrigin;
-      const offset =
-        -scale * (shiftedMinLongitude - Math.floor(shiftedMinLongitude));
-      shaderUniforms.ellipsoidLocalToShapeUvLongitude = Cartesian2.fromElements(
-        scale,
-        offset,
-        shaderUniforms.ellipsoidLocalToShapeUvLongitude,
-      );
+      longitudeOffset =
+        -longitudeScale *
+        (shiftedMinLongitude - Math.floor(shiftedMinLongitude));
     }
   }
 
-  if (renderHasLongitude) {
-    const renderIsMinLongitudeDiscontinuity = CesiumMath.equalsEpsilon(
-      renderMinBounds.x,
-      DefaultMinBounds.x,
-      undefined,
-      epsilonLongitudeDiscontinuity,
-    );
-    const renderIsMaxLongitudeDiscontinuity = CesiumMath.equalsEpsilon(
-      renderMaxBounds.x,
-      DefaultMaxBounds.x,
-      undefined,
-      epsilonLongitudeDiscontinuity,
-    );
-
-    if (renderIsMinLongitudeDiscontinuity) {
-      shaderDefines["ELLIPSOID_HAS_RENDER_BOUNDS_LONGITUDE_MIN_DISCONTINUITY"] =
-        true;
-    }
-    if (renderIsMaxLongitudeDiscontinuity) {
-      shaderDefines["ELLIPSOID_HAS_RENDER_BOUNDS_LONGITUDE_MAX_DISCONTINUITY"] =
-        true;
-    }
-    const uvShapeMinLongitude =
-      (shapeMinBounds.x - DefaultMinBounds.x) / defaultLongitudeRange;
-    const uvShapeMaxLongitude =
-      (shapeMaxBounds.x - DefaultMinBounds.x) / defaultLongitudeRange;
-
-    const uvRenderMaxLongitude =
-      (renderMaxBounds.x - DefaultMinBounds.x) / defaultLongitudeRange;
-    const uvRenderLongitudeRangeZero =
-      1.0 - renderLongitudeRange / defaultLongitudeRange;
-    const uvRenderLongitudeRangeZeroMid =
-      (uvRenderMaxLongitude + 0.5 * uvRenderLongitudeRangeZero) % 1.0;
-
-    shaderUniforms.ellipsoidShapeUvLongitudeMinMaxMid = Cartesian3.fromElements(
-      uvShapeMinLongitude,
-      uvShapeMaxLongitude,
-      uvRenderLongitudeRangeZeroMid,
-      shaderUniforms.ellipsoidShapeUvLongitudeMinMaxMid,
-    );
-  }
-
   if (renderHasLatitude) {
     // Intersects a cone for min latitude
     if (renderHasLatitudeMin) {
@@ -682,28 +627,36 @@ VoxelEllipsoidShape.prototype.update = function (
     );
   }
 
+  // Defaults are for the case where shapeLatitudeRange is zero, to avoid division by zero.
+  let latitudeScale = 0.0;
+  let latitudeOffset = 1.0;
+
   if (shapeHasLatitude) {
     shaderDefines["ELLIPSOID_HAS_SHAPE_BOUNDS_LATITUDE"] = true;
 
-    if (shapeLatitudeRange < epsilonLatitude) {
-      shaderUniforms.ellipsoidLocalToShapeUvLatitude = Cartesian2.fromElements(
-        0.0,
-        1.0,
-        shaderUniforms.ellipsoidLocalToShapeUvLatitude,
-      );
-    } else {
+    if (shapeLatitudeRange > epsilonLatitude) {
       const defaultLatitudeRange = DefaultMaxBounds.y - DefaultMinBounds.y;
-      const scale = defaultLatitudeRange / shapeLatitudeRange;
-      const offset =
+      latitudeScale = defaultLatitudeRange / shapeLatitudeRange;
+      latitudeOffset =
         (DefaultMinBounds.y - shapeMinBounds.y) / shapeLatitudeRange;
-      shaderUniforms.ellipsoidLocalToShapeUvLatitude = Cartesian2.fromElements(
-        scale,
-        offset,
-        shaderUniforms.ellipsoidLocalToShapeUvLatitude,
-      );
     }
   }
 
+  // Store scales in shader uniforms (GPU) and translates in private property (JS-only)
+  shaderUniforms.ellipsoidLocalToShapeUvScale = Cartesian3.fromElements(
+    longitudeScale,
+    latitudeScale,
+    heightScale,
+    shaderUniforms.ellipsoidLocalToShapeUvScale,
+  );
+
+  this._localToShapeUvTranslate = Cartesian3.fromElements(
+    longitudeOffset,
+    latitudeOffset,
+    0.0, // Height translate not used (always 1.0 + height * scale)
+    this._localToShapeUvTranslate,
+  );
+
   this._shaderMaximumIntersectionsLength = intersectionCount;
 
   return true;
@@ -943,11 +896,10 @@ VoxelEllipsoidShape.prototype.convertLocalToShapeUvSpace = function (
     ellipsoidRadii,
     evoluteScale,
     ellipsoidInverseRadiiSquared,
-    ellipsoidInverseHeightDifference,
     ellipsoidShapeUvLongitudeRangeOrigin,
-    ellipsoidLocalToShapeUvLongitude,
-    ellipsoidLocalToShapeUvLatitude,
+    ellipsoidLocalToShapeUvScale,
   } = this._shaderUniforms;
+  const localToShapeUvTranslate = this._localToShapeUvTranslate;
 
   const distanceFromZAxis = Math.hypot(positionLocal.x, positionLocal.y);
   const posEllipse = Cartesian2.fromElements(
@@ -999,19 +951,17 @@ VoxelEllipsoidShape.prototype.convertLocalToShapeUvSpace = function (
     longitude = longitude - Math.floor(longitude);
     // Scale and shift so [0, 1] covers the occupied space.
     longitude =
-      longitude * ellipsoidLocalToShapeUvLongitude.x +
-      ellipsoidLocalToShapeUvLongitude.y;
+      longitude * ellipsoidLocalToShapeUvScale.x + localToShapeUvTranslate.x;
   }
 
   latitude = (latitude + Math.PI / 2.0) / Math.PI;
   if (defined(ELLIPSOID_HAS_SHAPE_BOUNDS_LATITUDE)) {
     // Scale and shift so [0, 1] covers the occupied space.
     latitude =
-      latitude * ellipsoidLocalToShapeUvLatitude.x +
-      ellipsoidLocalToShapeUvLatitude.y;
+      latitude * ellipsoidLocalToShapeUvScale.y + localToShapeUvTranslate.y;
   }
 
-  height = 1.0 + height * ellipsoidInverseHeightDifference;
+  height = 1.0 + height * ellipsoidLocalToShapeUvScale.z;
 
   return Cartesian3.fromElements(longitude, latitude, height, result);
 };

package/Source/Scene/VoxelMetadataOrder.js

@@ -1,3 +1,5 @@
+// @ts-check
+
 /**
  * Metadata ordering for voxel content.
  * In all cases, x data is contiguous in strides along the y axis,
@@ -21,4 +23,7 @@ const VoxelMetadataOrder = {
    */
   Y_UP: 1,
 };
-export default Object.freeze(VoxelMetadataOrder);
+
+Object.freeze(VoxelMetadataOrder);
+
+export default VoxelMetadataOrder;

package/Source/Scene/VoxelProvider.js

@@ -183,6 +183,7 @@ Object.defineProperties(VoxelProvider.prototype, {
   /**
    * The number of levels of detail containing available tiles in the tileset.
    *
+   * @memberof VoxelProvider.prototype
    * @type {number|undefined}
    * @readonly
    */

package/Source/Scene/VoxelShapeType.js

@@ -102,4 +102,6 @@ VoxelShapeType.getShapeConstructor = function (shapeType) {
   }
 };
 
-export default Object.freeze(VoxelShapeType);
+Object.freeze(VoxelShapeType);
+
+export default VoxelShapeType;

package/Source/Scene/WebMapServiceImageryProvider.js

@@ -39,13 +39,14 @@ const excludesReverseAxis = [
  * @property {Resource|string} url The URL of the WMS service. The URL supports the same keywords as the {@link UrlTemplateImageryProvider}.
  * @property {string} layers The layers to include, separated by commas.
  * @property {object} [parameters=WebMapServiceImageryProvider.DefaultParameters] Additional parameters to pass to the WMS server in the GetMap URL.
- * @property {object} [getFeatureInfoParameters=WebMapServiceImageryProvider.GetFeatureInfoDefaultParameters] Additional parameters to pass to the WMS server in the GetFeatureInfo URL.
  * @property {boolean} [enablePickFeatures=true] If true, {@link WebMapServiceImageryProvider#pickFeatures} will invoke
  *        the GetFeatureInfo operation on the WMS server and return the features included in the response.  If false,
  *        {@link WebMapServiceImageryProvider#pickFeatures} will immediately return undefined (indicating no pickable features)
  *        without communicating with the server.  Set this property to false if you know your WMS server does not support
  *        GetFeatureInfo or if you don't want this provider's features to be pickable. Note that this can be dynamically
  *        overridden by modifying the WebMapServiceImageryProvider#enablePickFeatures property.
+ * @property {object} [getFeatureInfoParameters=WebMapServiceImageryProvider.GetFeatureInfoDefaultParameters] Additional parameters to pass to the WMS server in the GetFeatureInfo URL.
+ * @property {Resource|string} [getFeatureInfoUrl] The getFeatureInfo URL of the WMS service. If the property is not defined then we use the property value of url.
  * @property {GetFeatureInfoFormat[]} [getFeatureInfoFormats=WebMapServiceImageryProvider.DefaultGetFeatureInfoFormats] The formats
  *        in which to try WMS GetFeatureInfo requests.
  * @property {Rectangle} [rectangle=Rectangle.MAX_VALUE] The rectangle of the layer.
@@ -68,7 +69,6 @@ const excludesReverseAxis = [
  *                          an array, each element in the array is a subdomain.
  * @property {Clock} [clock] A Clock instance that is used when determining the value for the time dimension. Required when `times` is specified.
  * @property {TimeIntervalCollection} [times] TimeIntervalCollection with its data property being an object containing time dynamic dimension and their values.
- * @property {Resource|string} [getFeatureInfoUrl] The getFeatureInfo URL of the WMS service. If the property is not defined then we use the property value of url.
  */
 
 /**