@atlashub/smartstack-cli 3.39.0 → 3.40.0

package/templates/skills/apex/steps/step-08-run-tests.md

@@ -1,125 +1,125 @@
----
-name: step-08-run-tests
-description: Run tests until 100% pass — fix CODE not tests
-model: opus
-prev_step: steps/step-07-tests.md
-next_step: COMPLETE
----
-
-# Step 8: Run Tests
-
-**CRITICAL:** Fix the CODE, not the tests. Tests represent expected behavior.
-100% pass required for Sonar quality gate.
-
----
-
-## 1. Build
-
-```bash
-dotnet build --no-restore
-# Note: WSL bin\Debug cleanup handled by PostToolUse hook (wsl-dotnet-cleanup.sh)
-```
-
-**MUST PASS before running tests.**
-
----
-
-## 2. Run Full Test Suite
-
-```bash
-dotnet test --no-build --verbosity normal
-```
-
----
-
-## 3. Analyze Results
-
-**If ALL PASS:** Skip to step 5 (Summary).
-
-**If FAILURES:** For each failing test:
-
-```markdown
-### Failing Test: {test_name}
-**File:** {test_file}:{line}
-**Error:** {error_message}
-
-**Root Cause Analysis:**
-- [ ] Code bug: implementation doesn't match expected behavior
-- [ ] Missing dependency: service/mock not configured
-- [ ] Data issue: test data setup incomplete
-```
-
----
-
-## 4. Fix Loop (max 5 iterations)
-
-```
-WHILE tests failing AND iteration < 5:
-  1. Identify root cause (ALWAYS code bug, not test bug)
-  2. Fix the production CODE via appropriate skill/MCP
-  3. dotnet build --no-restore
-  4. dotnet test --no-build
-  5. Log result
-```
-
-**Rules:**
-- Fix CODE, never modify test assertions
-- Use the same skill/MCP that created the original code
-- After fix, rebuild before retesting
-- If stuck after 3 iterations on same test, ask user
-
-**If stuck (auto_mode = false):**
-
-```yaml
-questions:
-  - header: "Test Fix"
-    question: "Test is still failing after multiple attempts. How should we proceed?"
-    options:
-      - label: "Try alternative fix (Recommended)"
-        description: "Attempt a different approach to fix the code"
-      - label: "Skip this test"
-        description: "Mark as skipped with TODO comment"
-      - label: "Discuss the issue"
-        description: "Need help understanding the failure"
-    multiSelect: false
-```
-
----
-
-## 5. Frontend Tests + Typecheck (if applicable)
-
-```bash
-# Run frontend tests first
-WEB_DIR=$(find . -name "vitest.config.ts" -not -path "*/node_modules/*" -exec dirname {} \; 2>/dev/null | head -1)
-if [ -n "$WEB_DIR" ]; then
-  cd "$WEB_DIR"
-  npm run test
-  cd -
-fi
-
-# Then typecheck
-npm run typecheck
-```
-
-**BOTH MUST PASS.** If frontend tests fail, apply the same fix loop as backend (fix CODE, not tests, max 5 iterations).
-
----
-
-## 6. Commit Tests
-
-```
-test({module}): add unit and integration tests
-```
-
----
-
-## 7. Save + Summary
-
-If save_mode: write to `{output_dir}/08-run-tests.md`.
-
-Display: total tests, passing count, iterations to green, fixes applied, coverage %.
-
-## 8. Route to Next Step
-
-If pr_mode: create PR via `gh pr create`, show URL.
-Otherwise: show final summary (task, context, files, quality checks, commits, next steps).
+---
+name: step-08-run-tests
+description: Run tests until 100% pass — fix CODE not tests
+model: opus
+prev_step: steps/step-07-tests.md
+next_step: COMPLETE
+---
+
+# Step 8: Run Tests
+
+**CRITICAL:** Fix the CODE, not the tests. Tests represent expected behavior.
+100% pass required for Sonar quality gate.
+
+---
+
+## 1. Build
+
+```bash
+dotnet build --no-restore
+# Note: WSL bin\Debug cleanup handled by PostToolUse hook (wsl-dotnet-cleanup.sh)
+```
+
+**MUST PASS before running tests.**
+
+---
+
+## 2. Run Full Test Suite
+
+```bash
+dotnet test --no-build --verbosity normal
+```
+
+---
+
+## 3. Analyze Results
+
+**If ALL PASS:** Skip to step 5 (Summary).
+
+**If FAILURES:** For each failing test:
+
+```markdown
+### Failing Test: {test_name}
+**File:** {test_file}:{line}
+**Error:** {error_message}
+
+**Root Cause Analysis:**
+- [ ] Code bug: implementation doesn't match expected behavior
+- [ ] Missing dependency: service/mock not configured
+- [ ] Data issue: test data setup incomplete
+```
+
+---
+
+## 4. Fix Loop (max 5 iterations)
+
+```
+WHILE tests failing AND iteration < 5:
+  1. Identify root cause (ALWAYS code bug, not test bug)
+  2. Fix the production CODE via appropriate skill/MCP
+  3. dotnet build --no-restore
+  4. dotnet test --no-build
+  5. Log result
+```
+
+**Rules:**
+- Fix CODE, never modify test assertions
+- Use the same skill/MCP that created the original code
+- After fix, rebuild before retesting
+- If stuck after 3 iterations on same test, ask user
+
+**If stuck (auto_mode = false):**
+
+```yaml
+questions:
+  - header: "Test Fix"
+    question: "Test is still failing after multiple attempts. How should we proceed?"
+    options:
+      - label: "Try alternative fix (Recommended)"
+        description: "Attempt a different approach to fix the code"
+      - label: "Skip this test"
+        description: "Mark as skipped with TODO comment"
+      - label: "Discuss the issue"
+        description: "Need help understanding the failure"
+    multiSelect: false
+```
+
+---
+
+## 5. Frontend Tests + Typecheck (if applicable)
+
+```bash
+# Run frontend tests first
+WEB_DIR=$(find . -name "vitest.config.ts" -not -path "*/node_modules/*" -exec dirname {} \; 2>/dev/null | head -1)
+if [ -n "$WEB_DIR" ]; then
+  cd "$WEB_DIR"
+  npm run test
+  cd -
+fi
+
+# Then typecheck
+npm run typecheck
+```
+
+**BOTH MUST PASS.** If frontend tests fail, apply the same fix loop as backend (fix CODE, not tests, max 5 iterations).
+
+---
+
+## 6. Commit Tests
+
+```
+test({module}): add unit and integration tests
+```
+
+---
+
+## 7. Save + Summary
+
+If save_mode: write to `{output_dir}/08-run-tests.md`.
+
+Display: total tests, passing count, iterations to green, fixes applied, coverage %.
+
+## 8. Route to Next Step
+
+If pr_mode: create PR via `gh pr create`, show URL.
+Otherwise: show final summary (task, context, files, quality checks, commits, next steps).

package/templates/skills/application/SKILL.md

@@ -89,14 +89,14 @@ WEB (React) → API (.NET) → Application → Infrastructure → Database
 2. PERMISSIONS (Permissions.cs + PermissionConfiguration.cs) ← 2 files!
 3. ROLES (RolePermission mappings)
 3b. CLIENT SEED PROVIDER (client projects only - IClientSeedDataProvider)
-4. API (Controller + DTOs via /controller:create)
+4. API (Controller + DTOs via /controller create)
    4b. VALIDATE (/validate - convention check on generated backend)
 5. SERVICES (Interface + Implementation)
 6. FRONTEND (Page + Components + Hooks)
 7. I18N (fr, en, it, de)
 8. ROUTES (nested routes mandatory)
 9. PREFERENCES (Hook pattern)
-10. MIGRATION (/efcore:migration)
+10. MIGRATION (/efcore migration)
 11. TESTS - Backend (scaffold_tests - 7 categories including real integration)
 12. TESTS - Frontend (scaffold_frontend_tests - Vitest + Testing Library + MSW)
 13. REVIEW (/review-code - security + architecture + quality audit)
@@ -109,8 +109,8 @@ into the SmartStack Core seeding pipeline. Only runs when `{seeding_strategy}` =
 Core projects skip this step entirely.
 
 ### 4. Automatic Chaining
-- `/controller:create` → API Controllers
-- `/efcore:migration` → DB Migrations
+- `/controller create` → API Controllers
+- `/efcore migration` → DB Migrations
 - `/ui-components` → EntityCard, DataTable
 
 ## USER PREFERENCES