@atlashub/smartstack-cli 3.39.0 → 3.40.0

package/templates/skills/review-code/steps/step-02-detailed-review.md

@@ -1,80 +1,80 @@
-# Detailed Review Categories & Metrics
-
-## Review Categories
-
-### Security (Critical Priority)
-**Must check in every review:**
-- No hardcoded credentials (search: `password.*=.*['"]`, `api[_-]?key.*=`)
-- Input validation on all user data
-- Parameterized queries (no string concatenation for SQL)
-- Authorization checks on every endpoint
-- No `eval()`, `exec()`, dangerous functions
-
-See [references/security-checklist.md](../references/security-checklist.md) for OWASP Top 10 patterns.
-See [references/owasp-api-top10.md](../references/owasp-api-top10.md) for OWASP API Security Top 10.
-
-### Logic (Critical Priority)
-**Verify correctness:**
-- Business logic matches requirements
-- Edge cases handled (null, empty, boundary values)
-- Error handling present and appropriate
-- Race conditions in async code
-- Resource cleanup (connections, file handles)
-
-### Clean Code (High Priority)
-**Check for code smells:**
-- Large functions (>50 lines) - violate Single Responsibility
-- Deep nesting (>3 levels) - extract to functions
-- Long parameter lists (>3 params) - use objects
-- Duplicated code - extract to shared functions
-- Magic numbers/strings - use named constants
-
-See [references/clean-code-principles.md](../references/clean-code-principles.md) for SOLID principles.
-
-### Maintainability (Medium Priority)
-**Assess long-term health:**
-- Cognitive complexity <15 per function
-- Clear naming that reveals intent
-- Appropriate abstractions (not over-engineered)
-- Test coverage for critical paths
-
-## Code Quality Metrics
-
-### Cognitive Complexity
-- Target: <15 per function, <50 per module
-- Each nesting level adds complexity
-- Prefer early returns over deep nesting
-
-### Function Size
-- Target: <50 lines, ideally <20
-- Should fit on one screen
-- One function = one responsibility
-
-### Cyclomatic Complexity
-- Target: <10 per function
-- Count: 1 + (if + while + for + case + catch + && + ||)
-- High complexity = hard to test
-
-See [references/code-quality-metrics.md](../references/code-quality-metrics.md) for detailed calculations.
-
-## Anti-Patterns to Flag
-
-### Nitpicking
-**Problem**: Excessive minor comments bury critical issues
-**Impact**: Developers become defensive, stop reading feedback
-**Solution**: Automate style with linters; focus humans on logic/security
-
-### Vague Criticism
-**Problem**: "This is wrong" without explanation
-**Impact**: Developer doesn't know how to fix; creates friction
-**Solution**: Always include What + Why + How
-
-### Blocking on Preferences
-**Problem**: Blocking merge for subjective style preferences
-**Impact**: Delays delivery; damages team trust
-**Solution**: Reserve blocking for security/correctness only
-
-### Reviewing Unchanged Code
-**Problem**: Commenting on code outside the PR diff
-**Impact**: Scope creep; unfair to author
-**Solution**: Focus only on changed lines; file separate issues for existing problems
+# Detailed Review Categories & Metrics
+
+## Review Categories
+
+### Security (Critical Priority)
+**Must check in every review:**
+- No hardcoded credentials (search: `password.*=.*['"]`, `api[_-]?key.*=`)
+- Input validation on all user data
+- Parameterized queries (no string concatenation for SQL)
+- Authorization checks on every endpoint
+- No `eval()`, `exec()`, dangerous functions
+
+See [references/security-checklist.md](../references/security-checklist.md) for OWASP Top 10 patterns.
+See [references/owasp-api-top10.md](../references/owasp-api-top10.md) for OWASP API Security Top 10.
+
+### Logic (Critical Priority)
+**Verify correctness:**
+- Business logic matches requirements
+- Edge cases handled (null, empty, boundary values)
+- Error handling present and appropriate
+- Race conditions in async code
+- Resource cleanup (connections, file handles)
+
+### Clean Code (High Priority)
+**Check for code smells:**
+- Large functions (>50 lines) - violate Single Responsibility
+- Deep nesting (>3 levels) - extract to functions
+- Long parameter lists (>3 params) - use objects
+- Duplicated code - extract to shared functions
+- Magic numbers/strings - use named constants
+
+See [references/clean-code-principles.md](../references/clean-code-principles.md) for SOLID principles.
+
+### Maintainability (Medium Priority)
+**Assess long-term health:**
+- Cognitive complexity <15 per function
+- Clear naming that reveals intent
+- Appropriate abstractions (not over-engineered)
+- Test coverage for critical paths
+
+## Code Quality Metrics
+
+### Cognitive Complexity
+- Target: <15 per function, <50 per module
+- Each nesting level adds complexity
+- Prefer early returns over deep nesting
+
+### Function Size
+- Target: <50 lines, ideally <20
+- Should fit on one screen
+- One function = one responsibility
+
+### Cyclomatic Complexity
+- Target: <10 per function
+- Count: 1 + (if + while + for + case + catch + && + ||)
+- High complexity = hard to test
+
+See [references/code-quality-metrics.md](../references/code-quality-metrics.md) for detailed calculations.
+
+## Anti-Patterns to Flag
+
+### Nitpicking
+**Problem**: Excessive minor comments bury critical issues
+**Impact**: Developers become defensive, stop reading feedback
+**Solution**: Automate style with linters; focus humans on logic/security
+
+### Vague Criticism
+**Problem**: "This is wrong" without explanation
+**Impact**: Developer doesn't know how to fix; creates friction
+**Solution**: Always include What + Why + How
+
+### Blocking on Preferences
+**Problem**: Blocking merge for subjective style preferences
+**Impact**: Delays delivery; damages team trust
+**Solution**: Reserve blocking for security/correctness only
+
+### Reviewing Unchanged Code
+**Problem**: Commenting on code outside the PR diff
+**Impact**: Scope creep; unfair to author
+**Solution**: Focus only on changed lines; file separate issues for existing problems

package/templates/skills/review-code/steps/step-03-react.md

@@ -1,44 +1,44 @@
-# React/Next.js Review
-
-## Codebase Detection
-
-**When reviewing a React or Next.js project**, launch an additional parallel agent for Vercel React best practices.
-
-**Detect React/Next.js codebase by checking:**
-- `package.json` contains `"next"` or `"react"` dependencies
-- Files with `.tsx`, `.jsx` extensions in changes
-- `next.config.js` or `next.config.ts` exists
-- `app/` or `pages/` directory structure (Next.js)
-
-## Parallel Agent
-
-**If React/Next.js detected, launch parallel agent:**
-
-```yaml
-agent:
-  type: code-reviewer
-  focus: "vercel-react-best-practices"
-  task: |
-    Review the recent code changes using Vercel React best practices.
-    Focus on:
-    - Eliminating waterfalls (async patterns, Promise.all)
-    - Bundle size optimization (dynamic imports, barrel files)
-    - Server-side performance (caching, serialization)
-    - Re-render optimization (memoization, state management)
-    - Rendering performance patterns
-
-    Use the /vercel-react-best-practices skill as reference.
-    Report findings with [BLOCKING], [SUGGESTION], or [NIT] labels.
-```
-
-**Execution:**
-1. Check for React/Next.js in `package.json`
-2. If detected, use Task tool to launch parallel agent:
-   ```
-   Task tool with subagent_type="code-reviewer":
-   "Review recent changes against Vercel React best practices from /vercel-react-best-practices skill.
-   Focus on: async patterns, bundle optimization, server performance, re-renders.
-   Check changed files for violations of rules like async-parallel, bundle-barrel-imports,
-   server-cache-react, rerender-memo. Report with priority labels."
-   ```
-3. Merge findings into main review output
+# React/Next.js Review
+
+## Codebase Detection
+
+**When reviewing a React or Next.js project**, launch an additional parallel agent for Vercel React best practices.
+
+**Detect React/Next.js codebase by checking:**
+- `package.json` contains `"next"` or `"react"` dependencies
+- Files with `.tsx`, `.jsx` extensions in changes
+- `next.config.js` or `next.config.ts` exists
+- `app/` or `pages/` directory structure (Next.js)
+
+## Parallel Agent
+
+**If React/Next.js detected, launch parallel agent:**
+
+```yaml
+agent:
+  type: code-reviewer
+  focus: "vercel-react-best-practices"
+  task: |
+    Review the recent code changes using Vercel React best practices.
+    Focus on:
+    - Eliminating waterfalls (async patterns, Promise.all)
+    - Bundle size optimization (dynamic imports, barrel files)
+    - Server-side performance (caching, serialization)
+    - Re-render optimization (memoization, state management)
+    - Rendering performance patterns
+
+    Use the /vercel-react-best-practices skill as reference.
+    Report findings with [BLOCKING], [SUGGESTION], or [NIT] labels.
+```
+
+**Execution:**
+1. Check for React/Next.js in `package.json`
+2. If detected, use Task tool to launch parallel agent:
+   ```
+   Task tool with subagent_type="code-reviewer":
+   "Review recent changes against Vercel React best practices from /vercel-react-best-practices skill.
+   Focus on: async patterns, bundle optimization, server performance, re-renders.
+   Check changed files for violations of rules like async-parallel, bundle-barrel-imports,
+   server-cache-react, rerender-memo. Report with priority labels."
+   ```
+3. Merge findings into main review output

package/templates/skills/ui-components/SKILL.md

@@ -1,137 +1,137 @@
----
-name: ui-components
-description: |
-  Generates standardized SmartStack UI components.
-  Use this skill when:
-  - Creating React page (.tsx) in src/pages/
-  - Creating React component in src/components/
-  - User asks to create cards, grids, tables, or Kanban
-  - Claude detects creation of an entity list with display
-  - User mentions "card", "grid", "table", "list", "kanban"
-  - User asks for tooltips or infobubbles
-  - Creating a page with entity display
-  - Managing disabled states with explanatory messages
-  - User mentions "dashboard", "chart", "kpi", "analytics", "graph"
-  - Creating a dashboard with KPI cards or charts
-  Scope: Pages, Components, Cards, Tables, Grids, Kanban boards, Tooltips, Dashboards, Charts
----
-
-# Skill UI Components SmartStack
-
-**Reference:** [_shared.md](../_shared.md) for architecture, i18n
-
-## WHEN THIS SKILL ACTIVATES
-
-| Trigger | Example |
-|---------|---------|
-| React page/component creation | File in `src/pages/**/*.tsx` or `src/components/**/*.tsx` |
-| List creation | "Display products in cards" |
-| Keywords | "card", "grid", "table", "kanban", "tooltip" |
-| Disabled states | "Disable button with explanatory message" |
-| Dashboard/Chart creation | "dashboard", "chart", "kpi", "analytics", "graph", "metrics" |
-
-## Detailed patterns
-
-- For EntityCard (mandatory): [patterns/entity-card.md](patterns/entity-card.md)
-- For DataTable: [patterns/data-table.md](patterns/data-table.md)
-- For Grid layouts: [patterns/grid-layout.md](patterns/grid-layout.md)
-- For Kanban boards: [patterns/kanban.md](patterns/kanban.md)
-- For Dashboard & Charts: [patterns/dashboard-chart.md](patterns/dashboard-chart.md)
-- For styling rules: [style-guide.md](style-guide.md)
-- For accessibility: [accessibility.md](accessibility.md)
-
-## CORE RULES (always apply)
-
-### EntityCard is Mandatory
-**ALWAYS use `EntityCard` for entity cards. NEVER use custom cards with divs.**
-```typescript
-import { EntityCard, ProviderCard, TemplateCard } from '@/components/ui/EntityCard';
-```
-
-### CSS Variables (NEVER hardcode colors)
-**NEVER use hardcoded Tailwind colors.** ALWAYS use CSS variables for theme compliance.
-```tsx
-// CORRECT
-<span className="bg-[var(--info-bg)] text-[var(--info-text)]">Badge</span>
-
-// WRONG
-<span className="bg-blue-500/10 text-blue-500">Badge</span>
-```
-
-### Responsive Grid
-```tsx
-<div className="grid grid-cols-1 md:grid-cols-2 lg:grid-cols-3 xl:grid-cols-4 gap-6">
-  {items.map(item => <EntityCard key={item.id} {...mapToCardProps(item)} />)}
-</div>
-```
-
-### Ghost Buttons: NO BORDER
-```tsx
-// Ghost action (NO BORDER!)
-<button className="px-4 py-2 rounded-[var(--radius-button)] text-[var(--text-secondary)] hover:bg-[var(--bg-hover)]">
-  Action
-</button>
-```
-
-### TypeScript Interfaces
-**ALWAYS define explicit TypeScript interfaces for component props.** Never use `any`.
-
-### Semantic HTML
-**ALWAYS use `<button>` for click actions, `<a>` or `<Link>` for navigation.** Never use `<div role="button">`.
-
-### Performance
-- `memo()` for list item components
-- `useCallback` for event handlers passed as props
-- `useMemo` for expensive computations
-- Unique `id` for list keys (NEVER array index)
-
-## ABSOLUTE RULES
-
-| DO | DON'T |
-|----|-------|
-| CSS variables for ALL colors | Hardcoded Tailwind colors (`bg-blue-500`) |
-| `--success-dot`, `--warning-dot`, `--error-dot` for action buttons | `bg-emerald-500`, `bg-amber-500`, `bg-red-500` |
-| Ghost buttons WITHOUT border | `border border-[var(--border-color)]` on ghost |
-| EntityCard for entities | Custom cards with manual divs |
-| Responsive grid 1->2->3->4 | Fixed non-responsive grid |
-| h-full + flex-1 + mt-auto | Unaligned buttons in grid |
-| Empty, loading, and error states | Native HTML tooltip |
-| Explicit TypeScript interfaces | `any` or implicit types |
-| `<button>` for click actions | `<div role="button">` |
-| `memo()` for list item components | Unmemoized components in loops |
-| `useCallback` for event handlers | Inline arrow functions in JSX |
-| Unique `id` for list keys | Array index as key |
-
-### Error States with Retry
-
-**ALWAYS provide user-friendly error states with retry capability.**
-
-```tsx
-{error && (
-  <div className="p-4 bg-[var(--error-bg)] border border-[var(--error-border)] rounded-[var(--radius-card)]">
-    <div className="flex items-center">
-      <AlertCircle className="h-5 w-5 text-[var(--error-text)]" />
-      <span className="ml-2 text-[var(--error-text)]">{error}</span>
-    </div>
-    <button
-      onClick={() => refetch()}
-      className="mt-2 text-sm text-[var(--error-text)] hover:opacity-80 underline"
-    >
-      {t('common:actions.retry')}
-    </button>
-  </div>
-)}
-```
-
-**Rules:**
-- Use semantic error CSS variables (`--error-bg`, `--error-border`, `--error-text`)
-- Always provide retry button for recoverable errors
-- Use Lucide `AlertCircle` icon (not inline SVG)
-- Keep error messages user-friendly (not technical stack traces)
-
-<success_criteria>
-- Component created following SmartStack UI patterns (CSS variables, Lucide icons, i18n)
-- Correct file placement in src/pages/ or src/components/
-- Loading, error, and empty states handled
-- Responsive layout with SmartStack grid system
-</success_criteria>
+---
+name: ui-components
+description: |
+  Generates standardized SmartStack UI components.
+  Use this skill when:
+  - Creating React page (.tsx) in src/pages/
+  - Creating React component in src/components/
+  - User asks to create cards, grids, tables, or Kanban
+  - Claude detects creation of an entity list with display
+  - User mentions "card", "grid", "table", "list", "kanban"
+  - User asks for tooltips or infobubbles
+  - Creating a page with entity display
+  - Managing disabled states with explanatory messages
+  - User mentions "dashboard", "chart", "kpi", "analytics", "graph"
+  - Creating a dashboard with KPI cards or charts
+  Scope: Pages, Components, Cards, Tables, Grids, Kanban boards, Tooltips, Dashboards, Charts
+---
+
+# Skill UI Components SmartStack
+
+**Reference:** [_shared.md](../_shared.md) for architecture, i18n
+
+## WHEN THIS SKILL ACTIVATES
+
+| Trigger | Example |
+|---------|---------|
+| React page/component creation | File in `src/pages/**/*.tsx` or `src/components/**/*.tsx` |
+| List creation | "Display products in cards" |
+| Keywords | "card", "grid", "table", "kanban", "tooltip" |
+| Disabled states | "Disable button with explanatory message" |
+| Dashboard/Chart creation | "dashboard", "chart", "kpi", "analytics", "graph", "metrics" |
+
+## Detailed patterns
+
+- For EntityCard (mandatory): [patterns/entity-card.md](patterns/entity-card.md)
+- For DataTable: [patterns/data-table.md](patterns/data-table.md)
+- For Grid layouts: [patterns/grid-layout.md](patterns/grid-layout.md)
+- For Kanban boards: [patterns/kanban.md](patterns/kanban.md)
+- For Dashboard & Charts: [patterns/dashboard-chart.md](patterns/dashboard-chart.md)
+- For styling rules: [style-guide.md](style-guide.md)
+- For accessibility: [accessibility.md](accessibility.md)
+
+## CORE RULES (always apply)
+
+### EntityCard is Mandatory
+**ALWAYS use `EntityCard` for entity cards. NEVER use custom cards with divs.**
+```typescript
+import { EntityCard, ProviderCard, TemplateCard } from '@/components/ui/EntityCard';
+```
+
+### CSS Variables (NEVER hardcode colors)
+**NEVER use hardcoded Tailwind colors.** ALWAYS use CSS variables for theme compliance.
+```tsx
+// CORRECT
+<span className="bg-[var(--info-bg)] text-[var(--info-text)]">Badge</span>
+
+// WRONG
+<span className="bg-blue-500/10 text-blue-500">Badge</span>
+```
+
+### Responsive Grid
+```tsx
+<div className="grid grid-cols-1 md:grid-cols-2 lg:grid-cols-3 xl:grid-cols-4 gap-6">
+  {items.map(item => <EntityCard key={item.id} {...mapToCardProps(item)} />)}
+</div>
+```
+
+### Ghost Buttons: NO BORDER
+```tsx
+// Ghost action (NO BORDER!)
+<button className="px-4 py-2 rounded-[var(--radius-button)] text-[var(--text-secondary)] hover:bg-[var(--bg-hover)]">
+  Action
+</button>
+```
+
+### TypeScript Interfaces
+**ALWAYS define explicit TypeScript interfaces for component props.** Never use `any`.
+
+### Semantic HTML
+**ALWAYS use `<button>` for click actions, `<a>` or `<Link>` for navigation.** Never use `<div role="button">`.
+
+### Performance
+- `memo()` for list item components
+- `useCallback` for event handlers passed as props
+- `useMemo` for expensive computations
+- Unique `id` for list keys (NEVER array index)
+
+## ABSOLUTE RULES
+
+| DO | DON'T |
+|----|-------|
+| CSS variables for ALL colors | Hardcoded Tailwind colors (`bg-blue-500`) |
+| `--success-dot`, `--warning-dot`, `--error-dot` for action buttons | `bg-emerald-500`, `bg-amber-500`, `bg-red-500` |
+| Ghost buttons WITHOUT border | `border border-[var(--border-color)]` on ghost |
+| EntityCard for entities | Custom cards with manual divs |
+| Responsive grid 1->2->3->4 | Fixed non-responsive grid |
+| h-full + flex-1 + mt-auto | Unaligned buttons in grid |
+| Empty, loading, and error states | Native HTML tooltip |
+| Explicit TypeScript interfaces | `any` or implicit types |
+| `<button>` for click actions | `<div role="button">` |
+| `memo()` for list item components | Unmemoized components in loops |
+| `useCallback` for event handlers | Inline arrow functions in JSX |
+| Unique `id` for list keys | Array index as key |
+
+### Error States with Retry
+
+**ALWAYS provide user-friendly error states with retry capability.**
+
+```tsx
+{error && (
+  <div className="p-4 bg-[var(--error-bg)] border border-[var(--error-border)] rounded-[var(--radius-card)]">
+    <div className="flex items-center">
+      <AlertCircle className="h-5 w-5 text-[var(--error-text)]" />
+      <span className="ml-2 text-[var(--error-text)]">{error}</span>
+    </div>
+    <button
+      onClick={() => refetch()}
+      className="mt-2 text-sm text-[var(--error-text)] hover:opacity-80 underline"
+    >
+      {t('common:actions.retry')}
+    </button>
+  </div>
+)}
+```
+
+**Rules:**
+- Use semantic error CSS variables (`--error-bg`, `--error-border`, `--error-text`)
+- Always provide retry button for recoverable errors
+- Use Lucide `AlertCircle` icon (not inline SVG)
+- Keep error messages user-friendly (not technical stack traces)
+
+<success_criteria>
+- Component created following SmartStack UI patterns (CSS variables, Lucide icons, i18n)
+- Correct file placement in src/pages/ or src/components/
+- Loading, error, and empty states handled
+- Responsive layout with SmartStack grid system
+</success_criteria>