spree_core 3.2.9 → 3.3.0.rc1

data/spec/models/spree/taxon_spec.rb

@@ -0,0 +1,93 @@
+# coding: UTF-8
+
+require 'spec_helper'
+
+describe Spree::Taxon, type: :model do
+  let(:taxon) { FactoryGirl.build(:taxon, name: "Ruby on Rails") }
+
+  describe '#to_param' do
+    subject { super().to_param }
+    it { is_expected.to eql taxon.permalink }
+  end
+
+  context "set_permalink" do
+
+    it "should set permalink correctly when no parent present" do
+      taxon.set_permalink
+      expect(taxon.permalink).to eql "ruby-on-rails"
+    end
+
+    it "should support Chinese characters" do
+      taxon.name = "你好"
+      taxon.set_permalink
+      expect(taxon.permalink).to eql 'ni-hao'
+    end
+
+    it "stores old slugs in FriendlyIds history" do
+      # Stub out unrelated methods that cannot handle a save without an id
+      allow(subject).to receive(:set_depth!)
+      expect(subject).to receive(:create_slug)
+      subject.permalink = "custom-slug"
+      subject.run_callbacks :save
+    end
+
+    context "with parent taxon" do
+      let(:parent) { FactoryGirl.build(:taxon, permalink: "brands") }
+      before       { allow(taxon).to receive_messages parent: parent }
+
+      it "should set permalink correctly when taxon has parent" do
+        taxon.set_permalink
+        expect(taxon.permalink).to eql "brands/ruby-on-rails"
+      end
+
+      it "should set permalink correctly with existing permalink present" do
+        taxon.permalink = "b/rubyonrails"
+        taxon.set_permalink
+        expect(taxon.permalink).to eql "brands/rubyonrails"
+      end
+
+      it "should support Chinese characters" do
+        taxon.name = "我"
+        taxon.set_permalink
+        expect(taxon.permalink).to eql "brands/wo"
+      end
+
+      # Regression test for #3390
+      context "setting a new node sibling position via :child_index=" do
+        let(:idx) { rand(0..100) }
+        before { allow(parent).to receive(:move_to_child_with_index) }
+
+        context "taxon is not new" do
+          before { allow(taxon).to receive(:new_record?).and_return(false) }
+
+          it "passes the desired index move_to_child_with_index of :parent " do
+            expect(taxon).to receive(:move_to_child_with_index).with(parent, idx)
+
+            taxon.child_index = idx
+          end
+        end
+      end
+
+    end
+  end
+
+  # Regression test for #2620
+  context "creating a child node using first_or_create" do
+    let(:taxonomy) { create(:taxonomy) }
+
+    it "does not error out" do
+      expect { taxonomy.root.children.unscoped.where(name: "Some name").first_or_create }.not_to raise_error
+    end
+  end
+
+  context 'ransackable_associations' do
+    it { expect(described_class.whitelisted_ransackable_associations).to include('taxonomy') }
+  end
+
+  it { expect(taxon).to callback(:set_permalink).before(:validation).on(:create).if(:name) }
+  describe 'validation' do
+    subject { taxon }
+    it { is_expected.to validate_presence_of(:name) }
+    it { is_expected.to validate_uniqueness_of(:name).scoped_to([:parent_id, :taxonomy_id]).allow_blank }
+  end
+end

data/spec/models/spree/taxonomy_spec.rb

@@ -0,0 +1,18 @@
+require 'spec_helper'
+
+describe Spree::Taxonomy, type: :model do
+  context "#destroy" do
+    before do
+       @taxonomy = create(:taxonomy)
+       @root_taxon = @taxonomy.root
+       @child_taxon = create(:taxon, taxonomy_id: @taxonomy.id, parent: @root_taxon)
+    end
+
+    it "should destroy all associated taxons" do
+      @taxonomy.destroy
+      expect{ Spree::Taxon.find(@root_taxon.id) }.to raise_error(ActiveRecord::RecordNotFound)
+      expect{ Spree::Taxon.find(@child_taxon.id) }.to raise_error(ActiveRecord::RecordNotFound)
+    end
+  end
+end
+

data/spec/models/spree/tracker_spec.rb

@@ -0,0 +1,21 @@
+require 'spec_helper'
+
+describe Spree::Tracker, type: :model do
+  describe "current" do
+    before(:each) { @tracker = create(:tracker) }
+
+    it "returns the first active tracker" do
+      expect(Spree::Tracker.current).to eq(@tracker)
+    end
+
+    it "does not return a tracker with a blank analytics_id" do
+      @tracker.update_attribute(:analytics_id, '')
+      expect(Spree::Tracker.current).to be_nil
+    end
+
+    it "does not return an inactive tracker" do
+      @tracker.update_attribute(:active, false)
+      expect(Spree::Tracker.current).to be_nil
+    end
+  end
+end

data/spec/models/spree/user_spec.rb

@@ -0,0 +1,203 @@
+require 'spec_helper'
+
+describe Spree::LegacyUser, type: :model do
+  # Regression test for #2844 + #3346
+  context '#last_incomplete_order' do
+    let!(:user) { create(:user) }
+    let!(:order) { create(:order, bill_address: create(:address), ship_address: create(:address)) }
+
+    let(:order_1) { create(:order, created_at: 1.day.ago, user: user, created_by: user) }
+    let(:order_2) { create(:order, user: user, created_by: user) }
+    let(:order_3) { create(:order, user: user, created_by: create(:user)) }
+
+    it 'returns correct order' do
+      Timecop.scale(3600) do
+        order_1
+        order_2
+        order_3
+
+        expect(user.last_incomplete_spree_order).to eq order_3
+      end
+    end
+
+    context 'persists order address' do
+      it 'copies over order addresses' do
+        expect do
+          user.persist_order_address(order)
+        end.to change { Spree::Address.count }.by(2)
+
+        expect(user.bill_address).to eq order.bill_address
+        expect(user.ship_address).to eq order.ship_address
+      end
+
+      it 'doesnt create new addresses if user has already' do
+        user.update_column(:bill_address_id, create(:address).id)
+        user.update_column(:ship_address_id, create(:address).id)
+        user.reload
+
+        expect do
+          user.persist_order_address(order)
+        end.not_to change { Spree::Address.count }
+      end
+
+      it 'set both bill and ship address id on subject' do
+        user.persist_order_address(order)
+
+        expect(user.bill_address_id).not_to be_blank
+        expect(user.ship_address_id).not_to be_blank
+      end
+    end
+
+    context 'payment source' do
+      let(:payment_method) { create(:credit_card_payment_method) }
+      let!(:cc) do
+        create(:credit_card, user_id: user.id, payment_method: payment_method, gateway_customer_profile_id: "2342343")
+      end
+
+      it 'has payment sources' do
+        expect(user.payment_sources.first.gateway_customer_profile_id).not_to be_empty
+      end
+
+      it 'drops payment source' do
+        user.drop_payment_source cc
+        expect(cc.gateway_customer_profile_id).to be_nil
+      end
+    end
+  end
+end
+
+describe Spree.user_class, type: :model do
+  context 'reporting' do
+    let(:order_value) { BigDecimal.new('80.94') }
+    let(:order_count) { 4 }
+    let(:orders) { Array.new(order_count, double(total: order_value)) }
+
+    before do
+      allow(orders).to receive(:sum).with(:total).and_return(orders.sum(&:total))
+      allow(orders).to receive(:count).and_return(orders.length)
+    end
+
+    def load_orders
+      allow(subject).to receive(:orders).and_return(double(complete: orders))
+    end
+
+    describe '#lifetime_value' do
+      context 'with orders' do
+        before { load_orders }
+        it "returns the total of completed orders for the user" do
+          expect(subject.lifetime_value).to eq (order_count * order_value)
+        end
+      end
+      context 'without orders' do
+        it 'returns 0.00' do
+          expect(subject.lifetime_value).to eq BigDecimal("0.00")
+        end
+      end
+    end
+
+    describe '#display_lifetime_value' do
+      it 'returns a Spree::Money version of lifetime_value' do
+        value = BigDecimal('500.05')
+        allow(subject).to receive(:lifetime_value).and_return(value)
+        expect(subject.display_lifetime_value).to eq Spree::Money.new(value)
+      end
+    end
+
+    describe '#order_count' do
+      before { load_orders }
+      it 'returns the count of completed orders for the user' do
+        expect(subject.order_count).to eq BigDecimal(order_count)
+      end
+    end
+
+    describe '#average_order_value' do
+      context 'with orders' do
+        before { load_orders }
+        it 'returns the average completed order price for the user' do
+          expect(subject.average_order_value).to eq order_value
+        end
+      end
+      context 'without orders' do
+        it 'returns 0.00' do
+          expect(subject.average_order_value).to eq BigDecimal('0.00')
+        end
+      end
+    end
+
+    describe "#display_average_order_value" do
+      before { load_orders }
+      it 'returns a Spree::Money version of average_order_value' do
+        value = BigDecimal('500.05')
+        allow(subject).to receive(:average_order_value).and_return(value)
+        expect(subject.display_average_order_value).to eq Spree::Money.new(value)
+      end
+    end
+  end
+
+  describe '#total_available_store_credit' do
+    context 'user does not have any associated store credits' do
+      subject { create(:user) }
+
+      it 'returns 0' do
+        expect(subject.total_available_store_credit).to be_zero
+      end
+    end
+
+    context 'user has several associated store credits' do
+      let(:user) { create(:user) }
+      let(:amount) { 120.25 }
+      let(:additional_amount) { 55.75 }
+      let(:store_credit) { create(:store_credit, user: user, amount: amount, amount_used: 0.0) }
+      let!(:additional_store_credit) { create(:store_credit, user: user, amount: additional_amount, amount_used: 0.0) }
+
+      subject { store_credit.user }
+
+      context 'part of the store credit has been used' do
+        let(:amount_used) { 35.00 }
+
+        before { store_credit.update_attributes(amount_used: amount_used) }
+
+        context 'part of the store credit has been authorized' do
+          let(:authorized_amount) { 10 }
+
+          before { additional_store_credit.update_attributes(amount_authorized: authorized_amount) }
+
+          it 'returns sum of amounts minus used amount and authorized amount' do
+            available_store_credit = amount + additional_amount - amount_used - authorized_amount
+            expect(subject.total_available_store_credit.to_f).to eq available_store_credit
+          end
+        end
+
+        context 'there are no authorized amounts on any of the store credits' do
+          it 'returns sum of amounts minus used amount' do
+            expect(subject.total_available_store_credit.to_f).to eq (amount + additional_amount - amount_used)
+          end
+        end
+      end
+
+      context 'store credits have never been used' do
+        context 'part of the store credit has been authorized' do
+          let(:authorized_amount) { 10 }
+
+          before { additional_store_credit.update_attributes(amount_authorized: authorized_amount) }
+
+          it 'returns sum of amounts minus authorized amount' do
+            expect(subject.total_available_store_credit.to_f).to eq (amount + additional_amount - authorized_amount)
+          end
+        end
+
+        context 'there are no authorized amounts on any of the store credits' do
+          it 'returns sum of amounts' do
+            expect(subject.total_available_store_credit.to_f).to eq (amount + additional_amount)
+          end
+        end
+      end
+
+      context 'all store credits have never been used or authorized' do
+        it 'returns sum of amounts' do
+          expect(subject.total_available_store_credit.to_f).to eq (amount + additional_amount)
+        end
+      end
+    end
+  end
+end

data/spec/models/spree/variant_spec.rb

@@ -0,0 +1,818 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Spree::Variant, type: :model do
+  let!(:variant) { create(:variant) }
+  let(:master_variant) { create(:master_variant) }
+
+  it_behaves_like 'default_price'
+
+  describe 'validations' do
+    it { expect(master_variant).to_not validate_presence_of(:option_values) }
+    it { expect(variant).to validate_presence_of(:option_values) }
+  end
+
+  context 'sorting' do
+    it 'responds to set_list_position' do
+      expect(variant.respond_to?(:set_list_position)).to eq(true)
+    end
+  end
+
+  context "validations" do
+    it "should validate price is greater than 0" do
+      variant.price = -1
+      expect(variant).to be_invalid
+    end
+
+    it "should validate price is 0" do
+      variant.price = 0
+      expect(variant).to be_valid
+    end
+  end
+
+  context "after create" do
+    let!(:product) { create(:product) }
+
+    it "propagate to stock items" do
+      expect_any_instance_of(Spree::StockLocation).to receive(:propagate_variant)
+      create(:variant, product: product)
+    end
+
+    context "stock location has disable propagate all variants" do
+      before { Spree::StockLocation.update_all propagate_all_variants: false }
+
+      it "propagate to stock items" do
+        expect_any_instance_of(Spree::StockLocation).not_to receive(:propagate_variant)
+        product.variants.create(name: "Foobar")
+      end
+    end
+
+    describe 'mark_master_out_of_stock' do
+      before do
+        product.master.stock_items.first.set_count_on_hand(5)
+      end
+      context 'when product is created without variants but with stock' do
+        it { expect(product.master).to be_in_stock }
+      end
+
+      context 'when a variant is created' do
+        let!(:new_variant) { create(:variant, product: product) }
+
+        it { expect(product.master).to_not be_in_stock }
+      end
+    end
+  end
+
+  describe 'scope' do
+    describe '.not_discontinued' do
+      context 'when discontinued' do
+        let!(:discontinued_variant) { create(:variant, discontinue_on: Time.current - 1.day) }
+
+        it { expect(Spree::Variant.not_discontinued).not_to include(discontinued_variant) }
+      end
+
+      context 'when not discontinued' do
+        let!(:variant_2) { create(:variant, discontinue_on: Time.current + 1.day) }
+
+        it { expect(Spree::Variant.not_discontinued).to include(variant_2) }
+      end
+
+      context 'when discontinue_on not present' do
+        let!(:variant_2) { create(:variant, discontinue_on: nil) }
+
+        it { expect(Spree::Variant.not_discontinued).to include(variant_2) }
+      end
+    end
+
+    describe '.not_deleted' do
+      context 'when deleted' do
+        let!(:deleted_variant) { create(:variant, deleted_at: Time.current) }
+
+        it { expect(Spree::Variant.not_deleted).not_to include(deleted_variant) }
+      end
+
+      context 'when not deleted' do
+        let!(:variant_2) { create(:variant, deleted_at: nil) }
+
+        it { expect(Spree::Variant.not_deleted).to include(variant_2) }
+      end
+    end
+
+    describe '.for_currency_and_available_price_amount' do
+      let(:currency) { 'EUR' }
+
+      context 'when price with currency present' do
+        context 'when price has amount' do
+          let!(:price_1) { create(:price, currency: currency, variant: variant, amount: 10) }
+
+          it { expect(Spree::Variant.for_currency_and_available_price_amount(currency)).to include(variant) }
+        end
+
+        context 'when price do not have amount' do
+          let!(:price_1) { create(:price, currency: currency, variant: variant, amount: nil) }
+
+          it { expect(Spree::Variant.for_currency_and_available_price_amount(currency)).not_to include(variant) }
+        end
+      end
+
+      context 'when price with currency not present' do
+        let!(:unavailable_currency) { 'INR' }
+        context 'when price has amount' do
+          let!(:price_1) { create(:price, currency: unavailable_currency, variant: variant, amount: 10) }
+
+          it { expect(Spree::Variant.for_currency_and_available_price_amount(currency)).not_to include(variant) }
+        end
+
+        context 'when price do not have amount' do
+          let!(:price_1) { create(:price, currency: unavailable_currency, variant: variant, amount: nil) }
+
+          it { expect(Spree::Variant.for_currency_and_available_price_amount(currency)).not_to include(variant) }
+        end
+      end
+
+      context 'when multiple prices for same currency present' do
+        let!(:price_1) { create(:price, currency: currency, variant: variant) }
+        let!(:price_2) { create(:price, currency: currency, variant: variant) }
+
+        it 'should not duplicate variant' do
+          expect(Spree::Variant.for_currency_and_available_price_amount(currency)).to eq([variant])
+        end
+      end
+    end
+
+    describe '.active' do
+      let!(:variants) { [variant] }
+      let!(:currency) { 'EUR' }
+
+      before(:each) do
+        allow(Spree::Variant).to receive(:not_discontinued).and_return(variants)
+        allow(variants).to receive(:not_deleted).and_return(variants)
+        allow(variants).to receive(:for_currency_and_available_price_amount).with(currency).and_return(variants)
+      end
+
+      it 'should find not_discontinued variants' do
+        expect(Spree::Variant).to receive(:not_discontinued).and_return(variants)
+        Spree::Variant.active(currency)
+      end
+
+      it 'should find not_deleted variants' do
+        expect(variants).to receive(:not_deleted).and_return(variants)
+        Spree::Variant.active(currency)
+      end
+
+      it 'should find variants for_currency_and_available_price_amount' do
+        expect(variants).to receive(:for_currency_and_available_price_amount).with(currency).and_return(variants)
+        Spree::Variant.active(currency)
+      end
+
+      it { expect(Spree::Variant.active(currency)).to eq(variants) }
+    end
+  end
+
+  context "product has other variants" do
+    describe "option value accessors" do
+      before {
+        @multi_variant = FactoryGirl.create :variant, product: variant.product
+        variant.product.reload
+      }
+
+      let(:multi_variant) { @multi_variant }
+
+      it "should set option value" do
+        expect(multi_variant.option_value('media_type')).to be_nil
+
+        multi_variant.set_option_value('media_type', 'DVD')
+        expect(multi_variant.option_value('media_type')).to eql 'DVD'
+
+        multi_variant.set_option_value('media_type', 'CD')
+        expect(multi_variant.option_value('media_type')).to eql 'CD'
+      end
+
+      it "should not duplicate associated option values when set multiple times" do
+        multi_variant.set_option_value('media_type', 'CD')
+
+        expect {
+         multi_variant.set_option_value('media_type', 'DVD')
+        }.to_not change(multi_variant.option_values, :count)
+
+        expect {
+          multi_variant.set_option_value('coolness_type', 'awesome')
+        }.to change(multi_variant.option_values, :count).by(1)
+      end
+    end
+
+    context "product has other variants" do
+      describe "option value accessors" do
+        before {
+          @multi_variant = create(:variant, product: variant.product)
+          variant.product.reload
+        }
+
+        let(:multi_variant) { @multi_variant }
+
+        it "should set option value" do
+          expect(multi_variant.option_value('media_type')).to be_nil
+
+          multi_variant.set_option_value('media_type', 'DVD')
+          expect(multi_variant.option_value('media_type')).to eql 'DVD'
+
+          multi_variant.set_option_value('media_type', 'CD')
+          expect(multi_variant.option_value('media_type')).to eql 'CD'
+        end
+
+        it "should not duplicate associated option values when set multiple times" do
+          multi_variant.set_option_value('media_type', 'CD')
+
+          expect {
+           multi_variant.set_option_value('media_type', 'DVD')
+          }.to_not change(multi_variant.option_values, :count)
+
+          expect {
+            multi_variant.set_option_value('coolness_type', 'awesome')
+          }.to change(multi_variant.option_values, :count).by(1)
+        end
+      end
+    end
+  end
+
+  context "#cost_price=" do
+    it "should use LocalizedNumber.parse" do
+      expect(Spree::LocalizedNumber).to receive(:parse).with('1,599.99')
+      subject.cost_price = '1,599.99'
+    end
+  end
+
+  context "#price=" do
+    it "should use LocalizedNumber.parse" do
+      expect(Spree::LocalizedNumber).to receive(:parse).with('1,599.99')
+      subject.price = '1,599.99'
+    end
+  end
+
+  context "#weight=" do
+    it "should use LocalizedNumber.parse" do
+      expect(Spree::LocalizedNumber).to receive(:parse).with('1,599.99')
+      subject.weight = '1,599.99'
+    end
+  end
+
+  context "#currency" do
+    it "returns the globally configured currency" do
+      expect(variant.currency).to eql "USD"
+    end
+  end
+
+  context "#display_amount" do
+    it "returns a Spree::Money" do
+      variant.price = 21.22
+      expect(variant.display_amount.to_s).to eql "$21.22"
+    end
+  end
+
+  context "#cost_currency" do
+    context "when cost currency is nil" do
+      before { variant.cost_currency = nil }
+      it "populates cost currency with the default value on save" do
+        variant.save!
+        expect(variant.cost_currency).to eql "USD"
+      end
+    end
+  end
+
+  describe '.price_in' do
+    before do
+      variant.prices << create(:price, variant: variant, currency: "EUR", amount: 33.33)
+    end
+    subject { variant.price_in(currency).display_amount }
+
+    context "when currency is not specified" do
+      let(:currency) { nil }
+
+      it "returns 0" do
+        expect(subject.to_s).to eql "$0.00"
+      end
+    end
+
+    context "when currency is EUR" do
+      let(:currency) { 'EUR' }
+
+      it "returns the value in the EUR" do
+        expect(subject.to_s).to eql "€33.33"
+      end
+    end
+
+    context "when currency is USD" do
+      let(:currency) { 'USD' }
+
+      it "returns the value in the USD" do
+        expect(subject.to_s).to eql "$19.99"
+      end
+    end
+  end
+
+  describe '.amount_in' do
+    before do
+      variant.prices << create(:price, variant: variant, currency: "EUR", amount: 33.33)
+    end
+
+    subject { variant.amount_in(currency) }
+
+    context "when currency is not specified" do
+      let(:currency) { nil }
+
+      it "returns nil" do
+        expect(subject).to be_nil
+      end
+    end
+
+    context "when currency is EUR" do
+      let(:currency) { 'EUR' }
+
+      it "returns the value in the EUR" do
+        expect(subject).to eql 33.33
+      end
+    end
+
+    context "when currency is USD" do
+      let(:currency) { 'USD' }
+
+      it "returns the value in the USD" do
+        expect(subject).to eql 19.99
+      end
+    end
+  end
+
+  # Regression test for #2432
+  describe 'options_text' do
+    let!(:variant) { build(:variant, option_values: []) }
+    let!(:master) { create(:master_variant) }
+
+    before do
+      # Order bar than foo
+      variant.option_values << create(:option_value, {name: 'Foo', presentation: 'Foo', option_type: create(:option_type, position: 2, name: 'Foo Type', presentation: 'Foo Type')})
+      variant.option_values << create(:option_value, {name: 'Bar', presentation: 'Bar', option_type: create(:option_type, position: 1, name: 'Bar Type', presentation: 'Bar Type')})
+      variant.save
+    end
+
+    it 'should order by bar than foo' do
+      expect(variant.options_text).to eql 'Bar Type: Bar, Foo Type: Foo'
+    end
+
+  end
+
+  describe 'exchange_name' do
+    let!(:variant) { build(:variant, option_values: []) }
+    let!(:master) { create(:master_variant) }
+
+    before do
+      variant.option_values << create(:option_value, {
+                                                     name: 'Foo',
+                                                     presentation: 'Foo',
+                                                     option_type: create(:option_type, position: 2, name: 'Foo Type', presentation: 'Foo Type')
+                                                   })
+      variant.save
+    end
+
+    context 'master variant' do
+      it 'should return name' do
+        expect(master.exchange_name).to eql master.name
+      end
+    end
+
+    context 'variant' do
+      it 'should return options text' do
+        expect(variant.exchange_name).to eql 'Foo Type: Foo'
+      end
+    end
+
+  end
+
+  describe 'exchange_name' do
+    let!(:variant) { build(:variant, option_values: []) }
+    let!(:master) { create(:master_variant) }
+
+    before do
+      variant.option_values << create(:option_value, {
+                                                     name: 'Foo',
+                                                     presentation: 'Foo',
+                                                     option_type: create(:option_type, position: 2, name: 'Foo Type', presentation: 'Foo Type')
+                                                   })
+      variant.save
+    end
+
+    context 'master variant' do
+      it 'should return name' do
+        expect(master.exchange_name).to eql master.name
+      end
+    end
+
+    context 'variant' do
+      it 'should return options text' do
+        expect(variant.exchange_name).to eql 'Foo Type: Foo'
+      end
+    end
+
+  end
+
+  describe 'descriptive_name' do
+    let!(:variant) { build(:variant, option_values: []) }
+    let!(:master) { create(:master_variant) }
+
+    before do
+      variant.option_values << create(:option_value, {
+                                                     name: 'Foo',
+                                                     presentation: 'Foo',
+                                                     option_type: create(:option_type, position: 2, name: 'Foo Type', presentation: 'Foo Type')
+                                                   })
+      variant.save
+    end
+
+    context 'master variant' do
+      it 'should return name with Master identifier' do
+        expect(master.descriptive_name).to eql master.name + ' - Master'
+      end
+    end
+
+    context 'variant' do
+      it 'should return options text with name' do
+        expect(variant.descriptive_name).to eql variant.name + ' - Foo Type: Foo'
+      end
+    end
+
+  end
+
+  # Regression test for #2744
+  describe "set_position" do
+    it "sets variant position after creation" do
+      variant = create(:variant)
+      expect(variant.position).to_not be_nil
+    end
+  end
+
+  describe '#in_stock?' do
+    before do
+      Spree::Config.track_inventory_levels = true
+    end
+
+    context 'when stock_items are not backorderable' do
+      before do
+        allow_any_instance_of(Spree::StockItem).to receive_messages(backorderable: false)
+      end
+
+      context 'when stock_items in stock' do
+        before do
+          variant.stock_items.first.update_column(:count_on_hand, 10)
+        end
+
+        it 'returns true if stock_items in stock' do
+          expect(variant.in_stock?).to be true
+        end
+      end
+
+      context 'when stock_items out of stock' do
+        before do
+          allow_any_instance_of(Spree::StockItem).to receive_messages(backorderable: false)
+          allow_any_instance_of(Spree::StockItem).to receive_messages(count_on_hand: 0)
+        end
+
+        it 'return false if stock_items out of stock' do
+          expect(variant.in_stock?).to be false
+        end
+      end
+    end
+
+    describe "#can_supply?" do
+      it "calls out to quantifier" do
+        expect(Spree::Stock::Quantifier).to receive(:new).and_return(quantifier = double)
+        expect(quantifier).to receive(:can_supply?).with(10)
+        variant.can_supply?(10)
+      end
+    end
+
+    context 'when stock_items are backorderable' do
+      before do
+        allow_any_instance_of(Spree::StockItem).to receive_messages(backorderable: true)
+      end
+
+      context 'when stock_items out of stock' do
+        before do
+          allow_any_instance_of(Spree::StockItem).to receive_messages(count_on_hand: 0)
+        end
+
+        it 'in_stock? returns false' do
+          expect(variant.in_stock?).to be false
+        end
+
+        it 'can_supply? return true' do
+          expect(variant.can_supply?).to be true
+        end
+      end
+    end
+  end
+
+  describe '#is_backorderable' do
+    let(:variant) { build(:variant) }
+    subject { variant.is_backorderable? }
+
+    it 'should invoke Spree::Stock::Quantifier' do
+      expect_any_instance_of(Spree::Stock::Quantifier).to receive(:backorderable?) { true }
+      subject
+    end
+  end
+
+  describe '#total_on_hand' do
+    it 'should be infinite if track_inventory_levels is false' do
+      Spree::Config[:track_inventory_levels] = false
+      expect(build(:variant).total_on_hand).to eql(Float::INFINITY)
+    end
+
+    it 'should match quantifier total_on_hand' do
+      variant = build(:variant)
+      expect(variant.total_on_hand).to eq(Spree::Stock::Quantifier.new(variant).total_on_hand)
+    end
+  end
+
+  describe '#tax_category' do
+    context 'when tax_category is nil' do
+      let(:product) { build(:product) }
+      let(:variant) { build(:variant, product: product, tax_category_id: nil) }
+      it 'returns the parent products tax_category' do
+        expect(variant.tax_category).to eq(product.tax_category)
+      end
+    end
+
+    context 'when tax_category is set' do
+      let(:tax_category) { create(:tax_category) }
+      let(:variant) { build(:variant, tax_category: tax_category) }
+      it 'returns the tax_category set on itself' do
+        expect(variant.tax_category).to eq(tax_category)
+      end
+    end
+  end
+
+  describe "touching" do
+    it "updates a product" do
+      variant.product.update_column(:updated_at, 1.day.ago)
+      variant.touch
+      expect(variant.product.reload.updated_at).to be_within(3.seconds).of(Time.current)
+    end
+
+    it "clears the in_stock cache key" do
+      expect(Rails.cache).to receive(:delete).with(variant.send(:in_stock_cache_key))
+      variant.touch
+    end
+  end
+
+  describe "#should_track_inventory?" do
+
+    it 'should not track inventory when global setting is off' do
+      Spree::Config[:track_inventory_levels] = false
+
+      expect(build(:variant).should_track_inventory?).to eq(false)
+    end
+
+    it 'should not track inventory when variant is turned off' do
+      Spree::Config[:track_inventory_levels] = true
+
+      expect(build(:on_demand_variant).should_track_inventory?).to eq(false)
+    end
+
+    it 'should track inventory when global and variant are on' do
+      Spree::Config[:track_inventory_levels] = true
+
+      expect(build(:variant).should_track_inventory?).to eq(true)
+    end
+  end
+
+  describe "deleted_at scope" do
+    before { variant.destroy && variant.reload }
+    it "should have a price if deleted" do
+      variant.price = 10
+      expect(variant.price).to eq(10)
+    end
+  end
+
+  describe "stock movements" do
+    let!(:movement) { create(:stock_movement, stock_item: variant.stock_items.first) }
+
+    it "builds out collection just fine through stock items" do
+      expect(variant.stock_movements.to_a).not_to be_empty
+    end
+  end
+
+  describe "in_stock scope" do
+    it "returns all in stock variants" do
+      in_stock_variant = create(:variant)
+      out_of_stock_variant = create(:variant)
+
+      in_stock_variant.stock_items.first.update_column(:count_on_hand, 10)
+
+      expect(Spree::Variant.in_stock).to eq [in_stock_variant]
+    end
+  end
+
+  context "#volume" do
+    let(:variant_zero_width) { create(:variant, width: 0) }
+    let(:variant) { create(:variant) }
+
+    it "it is zero if any dimension parameter is zero" do
+      expect(variant_zero_width.volume).to eq 0
+    end
+
+    it "return the volume if the dimension parameters are different of zero" do
+      volume_expected = variant.width * variant.depth * variant.height
+      expect(variant.volume).to eq (volume_expected)
+    end
+  end
+
+  context "#dimension" do
+    let(:variant) { create(:variant) }
+
+    it "return the dimension if the dimension parameters are different of zero" do
+      dimension_expected = variant.width + variant.depth + variant.height
+      expect(variant.dimension).to eq (dimension_expected)
+    end
+  end
+
+  context "#discontinue!" do
+    let(:variant) { create(:variant) }
+
+    it "sets the discontinued" do
+      variant.discontinue!
+      variant.reload
+      expect(variant.discontinued?).to be(true)
+    end
+
+    it "changes updated_at" do
+      Timecop.scale(1000) do
+        expect { variant.discontinue! }.to change { variant.updated_at }
+      end
+    end
+  end
+
+  context "#discontinued?" do
+    let(:variant_live) { build(:variant) }
+    it "should be false" do
+      expect(variant_live.discontinued?).to be(false)
+    end
+
+    let(:variant_discontinued) { build(:variant, discontinue_on: Time.now - 1.day) }
+    it "should be true" do
+      expect(variant_discontinued.discontinued?).to be(true)
+    end
+  end
+
+  describe "#available?" do
+    let(:variant) { create(:variant) }
+    context 'when discontinued' do
+      before(:each) do
+        variant.discontinue_on = Time.current - 1.day
+      end
+
+      context 'when product is available' do
+        before(:each) do
+          allow(variant.product).to receive(:available?) { true }
+        end
+
+        it { expect(variant.available?).to be(false) }
+      end
+
+      context 'when product is not available' do
+        before(:each) do
+          allow(variant.product).to receive(:available?) { false }
+        end
+
+        it { expect(variant.available?).to be(false) }
+      end
+    end
+
+    context 'when not discontinued' do
+      before(:each) do
+        variant.discontinue_on = Time.current + 1.day
+      end
+
+      context 'when product is available' do
+        before(:each) do
+          allow(variant.product).to receive(:available?) { true }
+        end
+
+        it { expect(variant.available?).to be(true) }
+      end
+
+      context 'when product is not available' do
+        before(:each) do
+          allow(variant.product).to receive(:available?) { false }
+        end
+
+        it { expect(variant.available?).to be(false) }
+      end
+    end
+  end
+
+  describe "#check_price" do
+    let(:variant) { create(:variant) }
+    let(:variant2) { create(:variant) }
+
+    context 'require_master_price set false' do
+      before { Spree::Config.set(require_master_price: false) }
+
+      context 'price present and currency present' do
+        it { expect(variant.send(:check_price)).to be(nil) }
+      end
+
+      context 'price present and currency nil' do
+        before { variant.currency = nil }
+
+        it { expect(variant.send(:check_price)).to be(Spree::Config[:currency]) }
+      end
+
+      context 'price nil and currency present' do
+        before { variant.price = nil }
+
+        it { expect(variant.send(:check_price)).to be(nil) }
+      end
+
+      context 'price nil and currency nil' do
+        before { variant.price = nil }
+
+        it { expect(variant.send(:check_price)).to be(nil) }
+      end
+    end
+
+    context 'require_master_price set true' do
+      before { Spree::Config.set(require_master_price: true) }
+
+      context 'price present and currency present' do
+        it { expect(variant.send(:check_price)).to be(nil) }
+      end
+
+      context 'price present and currency nil' do
+        before { variant.currency = nil }
+
+        it { expect(variant.send(:check_price)).to be(Spree::Config[:currency]) }
+      end
+
+      context 'product and master_variant present and equal' do
+        context 'price nil and currency present' do
+          before { variant.price = nil }
+          it { expect(variant.send(:check_price)).to be(nil) }
+
+          context 'check variant price' do
+            before { variant.send(:check_price) }
+            it { expect(variant.price).to eq(variant.product.master.price) }
+          end
+        end
+
+        context 'price nil and currency nil' do
+          before do
+            variant.price = nil
+            variant.send(:check_price)
+          end
+
+          it { expect(variant.price).to eq(variant.product.master.price) }
+          it { expect(variant.currency).to eq(Spree::Config[:currency]) }
+        end
+      end
+
+      context 'product not present' do
+        context 'product not present' do
+          before { variant.product = nil }
+
+          context 'price nil and currency present' do
+            before { variant.price = nil }
+
+            it { expect { variant.send(:check_price) }.to raise_error(RuntimeError, 'No master variant found to infer price') }
+          end
+
+          context 'price nil and currency nil' do
+            before { variant.price = nil }
+
+            it { expect { variant.send(:check_price) }.to raise_error(RuntimeError, 'No master variant found to infer price') }
+          end
+        end
+      end
+    end
+  end
+
+  describe '#created_at' do
+    it 'creates variant with created_at timestamp' do
+      expect(variant.created_at).to_not be_nil
+    end
+  end
+
+  describe '#updated_at' do
+    it 'creates variant with updated_at timestamp' do
+      expect(variant.updated_at).to_not be_nil
+    end
+  end
+
+  describe '#ensure_no_line_items' do
+    let!(:line_item) { create(:line_item, variant: variant) }
+
+    it 'should add error on product destroy' do
+      expect(variant.destroy).to eq false
+      expect(variant.errors[:base]).to include Spree.t(:cannot_destroy_if_attached_to_line_items)
+    end
+  end
+end