spree_core 3.2.9 → 3.3.0.rc1

data/spec/models/spree/calculator/flat_percent_item_total_spec.rb

@@ -0,0 +1,25 @@
+require 'spec_helper'
+
+describe Spree::Calculator::FlatPercentItemTotal, type: :model do
+  let(:calculator) { Spree::Calculator::FlatPercentItemTotal.new }
+  let(:line_item) { mock_model Spree::LineItem }
+
+  before { allow(calculator).to receive_messages preferred_flat_percent: 10 }
+
+  context "compute" do
+    it "should round result correctly" do
+      allow(line_item).to receive_messages amount: 31.08
+      expect(calculator.compute(line_item)).to eq 3.11
+
+      allow(line_item).to receive_messages amount: 31.00
+      expect(calculator.compute(line_item)).to eq 3.10
+    end
+
+    it 'returns object.amount if computed amount is greater' do
+      allow(calculator).to receive_messages preferred_flat_percent: 110
+      allow(line_item).to receive_messages amount: 30.00
+
+      expect(calculator.compute(line_item)).to eq 30.0
+    end
+  end
+end

data/spec/models/spree/calculator/flat_rate_spec.rb

@@ -0,0 +1,47 @@
+require 'spec_helper'
+
+describe Spree::Calculator::FlatRate, type: :model do
+  let(:calculator) { Spree::Calculator::FlatRate.new }
+
+  let(:order) do
+    mock_model(
+      Spree::Order, quantity: 10, currency: "USD"
+    )
+  end
+
+  context "compute" do
+    it "should compute the amount as the rate when currency matches the order's currency" do
+      calculator.preferred_amount = 25.0
+      calculator.preferred_currency = "GBP"
+      allow(order).to receive_messages currency: "GBP"
+      expect(calculator.compute(order).round(2)).to eq(25.0)
+    end
+
+    it "should compute the amount as 0 when currency does not match the order's currency" do
+      calculator.preferred_amount = 100.0
+      calculator.preferred_currency = "GBP"
+      allow(order).to receive_messages currency: "USD"
+      expect(calculator.compute(order).round(2)).to eq(0.0)
+    end
+
+    it "should compute the amount as 0 when currency is blank" do
+      calculator.preferred_amount = 100.0
+      calculator.preferred_currency = ""
+      allow(order).to receive_messages currency: "GBP"
+      expect(calculator.compute(order).round(2)).to eq(0.0)
+    end
+
+    it "should compute the amount as the rate when the currencies use different casing" do
+      calculator.preferred_amount = 100.0
+      calculator.preferred_currency = "gBp"
+      allow(order).to receive_messages currency: "GBP"
+      expect(calculator.compute(order).round(2)).to eq(100.0)
+    end
+
+    it "should compute the amount as 0 when there is no object" do
+      calculator.preferred_amount = 100.0
+      calculator.preferred_currency = "GBP"
+      expect(calculator.compute.round(2)).to eq(0.0)
+    end
+  end
+end

data/spec/models/spree/calculator/flexi_rate_spec.rb

@@ -0,0 +1,41 @@
+require 'spec_helper'
+
+describe Spree::Calculator::FlexiRate, type: :model do
+  let(:calculator) { Spree::Calculator::FlexiRate.new }
+
+  let(:order) do
+    mock_model(
+      Spree::Order, quantity: 10
+    )
+  end
+
+  context "compute" do
+    it "should compute amount correctly when all fees are 0" do
+      expect(calculator.compute(order).round(2)).to eq(0.0)
+    end
+
+    it "should compute amount correctly when first_item has a value" do
+      allow(calculator).to receive_messages preferred_first_item: 1.0
+      expect(calculator.compute(order).round(2)).to eq(1.0)
+    end
+
+    it "should compute amount correctly when additional_items has a value" do
+      allow(calculator).to receive_messages preferred_additional_item: 1.0
+      expect(calculator.compute(order).round(2)).to eq(9.0)
+    end
+
+    it "should compute amount correctly when additional_items and first_item have values" do
+      allow(calculator).to receive_messages preferred_first_item: 5.0, preferred_additional_item: 1.0
+      expect(calculator.compute(order).round(2)).to eq(14.0)
+    end
+
+    it "should compute amount correctly when additional_items and first_item have values AND max items has value" do
+      allow(calculator).to receive_messages preferred_first_item: 5.0, preferred_additional_item: 1.0, preferred_max_items: 3
+      expect(calculator.compute(order).round(2)).to eq(7.0)
+    end
+
+    it "should allow creation of new object with all the attributes" do
+      Spree::Calculator::FlexiRate.new(preferred_first_item: 1, preferred_additional_item: 1, preferred_max_items: 1)
+    end
+  end
+end

data/spec/models/spree/calculator/percent_on_line_item_spec.rb

@@ -0,0 +1,15 @@
+require 'spec_helper'
+
+module Spree
+  class Calculator
+    describe PercentOnLineItem, type: :model do
+      let(:line_item) { double("LineItem", amount: 100) }
+
+      before { subject.preferred_percent = 15 }
+
+      it "computes based on item price and quantity" do
+        expect(subject.compute(line_item)).to eq 15
+      end
+    end
+  end
+end

data/spec/models/spree/calculator/price_sack_spec.rb

@@ -0,0 +1,30 @@
+require 'spec_helper'
+
+describe Spree::Calculator::PriceSack, type: :model do
+  let(:calculator) do
+    calculator = Spree::Calculator::PriceSack.new
+    calculator.preferred_minimal_amount = 5
+    calculator.preferred_normal_amount = 10
+    calculator.preferred_discount_amount = 1
+    calculator
+  end
+
+  let(:order) { stub_model(Spree::Order) }
+  let(:shipment) { stub_model(Spree::Shipment, amount: 10) }
+
+  # Regression test for #714 and #739
+  it "computes with an order object" do
+    calculator.compute(order)
+  end
+
+  # Regression test for #1156
+  it "computes with a shipment object" do
+    calculator.compute(shipment)
+  end
+
+  # Regression test for #2055
+  it "computes the correct amount" do
+    expect(calculator.compute(2)).to eq(calculator.preferred_normal_amount)
+    expect(calculator.compute(6)).to eq(calculator.preferred_discount_amount)
+  end
+end

data/spec/models/spree/calculator/refunds/default_refund_amount_spec.rb

@@ -0,0 +1,47 @@
+require 'spec_helper'
+
+describe Spree::Calculator::Returns::DefaultRefundAmount, type: :model do
+  let(:order)           { create(:order) }
+  let(:line_item_quantity) { 2 }
+  let(:item_price)      { 100.0 }
+  let(:pre_tax_amount)  { line_item_quantity * item_price }
+  let(:line_item)       { create(:line_item, price: item_price, quantity: line_item_quantity) }
+  let(:inventory_unit)  { build(:inventory_unit, order: order, line_item: line_item, quantity: 1) }
+  let(:return_item)     { build(:return_item, inventory_unit: inventory_unit) }
+  let(:calculator)      { Spree::Calculator::Returns::DefaultRefundAmount.new }
+
+  before { order.line_items << line_item }
+
+  subject { calculator.compute(return_item) }
+
+  context "not an exchange" do
+    context "no promotions or taxes" do
+      it { is_expected.to eq pre_tax_amount / line_item_quantity }
+    end
+
+    context "order adjustments" do
+      let(:adjustment_amount) { -10.0 }
+
+      before do
+        order.adjustments << create(:adjustment, order: order, amount: adjustment_amount, eligible: true, label: 'Adjustment', source_type: 'Spree::Order')
+        order.adjustments.first.update_attributes(amount: adjustment_amount)
+      end
+
+      it { is_expected.to eq (pre_tax_amount - adjustment_amount.abs) / line_item_quantity }
+    end
+
+    context "shipping adjustments" do
+      let(:adjustment_total) { -50.0 }
+
+      before { order.shipments << Spree::Shipment.new(adjustment_total: adjustment_total) }
+
+      it { is_expected.to eq pre_tax_amount / line_item_quantity }
+    end
+  end
+
+  context "an exchange" do
+    let(:return_item) { build(:exchange_return_item) }
+
+    it { is_expected.to eq 0.0 }
+  end
+end

data/spec/models/spree/calculator/shipping.rb

@@ -0,0 +1,8 @@
+require_dependency 'spree/calculator'
+
+module Spree
+  class Calculator::Shipping < Calculator
+    def compute(content_items)
+    end
+  end
+end

data/spec/models/spree/calculator/shipping/flat_percent_item_total_spec.rb

@@ -0,0 +1,23 @@
+require 'spec_helper'
+
+module Spree
+  module Calculator::Shipping
+    describe FlatPercentItemTotal, type: :model do
+      let(:variant1) { build(:variant, price: 10.11) }
+      let(:variant2) { build(:variant, price: 20.2222) }
+
+      let(:line_item1) { build(:line_item, variant: variant1) }
+      let(:line_item2) { build(:line_item, variant: variant2) }
+
+      let(:package) do
+        build(:stock_package, variants_contents: { variant1 => 2, variant2 => 1 })
+      end
+
+      subject { FlatPercentItemTotal.new(preferred_flat_percent: 10) }
+
+      it "should round result correctly" do
+        expect(subject.compute(package)).to eq(4.04)
+      end
+    end
+  end
+end

data/spec/models/spree/calculator/shipping/flat_rate_spec.rb

@@ -0,0 +1,13 @@
+require 'spec_helper'
+
+module Spree
+  module Calculator::Shipping
+    describe FlatRate, type: :model do
+      subject { Calculator::Shipping::FlatRate.new(preferred_amount: 4.00) }
+
+      it 'always returns the same rate' do
+        expect(subject.compute(build(:stock_package_fulfilled))).to eql 4.00
+      end
+    end
+  end
+end

data/spec/models/spree/calculator/shipping/flexi_rate_spec.rb

@@ -0,0 +1,52 @@
+require 'spec_helper'
+
+module Spree
+  module Calculator::Shipping
+    describe FlexiRate, type: :model do
+      let(:variant1) { build(:variant, price: 10) }
+      let(:variant2) { build(:variant, price: 20) }
+
+      let(:package) do
+        build(:stock_package, variants_contents: { variant1 => 4, variant2 => 6 })
+      end
+
+      let(:subject) { FlexiRate.new }
+
+      context "compute" do
+        it "should compute amount correctly when all fees are 0" do
+          expect(subject.compute(package).round(2)).to eq(0.0)
+        end
+
+        it "should compute amount correctly when first_item has a value" do
+          subject.preferred_first_item = 1.0
+          expect(subject.compute(package).round(2)).to eq(1.0)
+        end
+
+        it "should compute amount correctly when additional_items has a value" do
+          subject.preferred_additional_item = 1.0
+          expect(subject.compute(package).round(2)).to eq(9.0)
+        end
+
+        it "should compute amount correctly when additional_items and first_item have values" do
+          subject.preferred_first_item = 5.0
+          subject.preferred_additional_item = 1.0
+          expect(subject.compute(package).round(2)).to eq(14.0)
+        end
+
+        it "should compute amount correctly when additional_items and first_item have values AND max items has value" do
+          subject.preferred_first_item = 5.0
+          subject.preferred_additional_item = 1.0
+          subject.preferred_max_items = 3
+          expect(subject.compute(package).round(2)).to eq(26.0)
+        end
+
+        it "should allow creation of new object with all the attributes" do
+          FlexiRate.new(preferred_first_item: 1,
+                        preferred_additional_item: 1,
+                        preferred_max_items: 1)
+        end
+      end
+    end
+  end
+end
+

data/spec/models/spree/calculator/shipping/per_item_spec.rb

@@ -0,0 +1,20 @@
+require 'spec_helper'
+
+module Spree
+  module Calculator::Shipping
+    describe PerItem, type: :model do
+      let(:variant1) { build(:variant) }
+      let(:variant2) { build(:variant) }
+
+      let(:package) do
+        build(:stock_package, variants_contents: { variant1 => 5, variant2 => 3 })
+      end
+
+      subject { PerItem.new(preferred_amount: 10) }
+
+      it "correctly calculates per item shipping" do
+        expect(subject.compute(package).to_f).to eq(80) # 5 x 10 + 3 x 10
+      end
+    end
+  end
+end

data/spec/models/spree/calculator/shipping/price_sack_spec.rb

@@ -0,0 +1,29 @@
+require 'spec_helper'
+
+module Spree
+  module Calculator::Shipping
+    describe PriceSack do
+      let(:variant) { build(:variant, price: 2) }
+      subject(:calculator) do
+        calculator = PriceSack.new
+        calculator.preferred_minimal_amount = 5
+        calculator.preferred_normal_amount = 10
+        calculator.preferred_discount_amount = 1
+        calculator
+      end
+
+      let(:normal_package) do
+        build(:stock_package, variants_contents: { variant => 2 })
+      end
+
+      let(:discount_package) do
+        build(:stock_package, variants_contents: { variant => 4 })
+      end
+
+      it 'computes the correct amount' do
+        expect(calculator.compute(normal_package)).to eq(calculator.preferred_normal_amount)
+        expect(calculator.compute(discount_package)).to eq(calculator.preferred_discount_amount)
+      end
+    end
+  end
+end

data/spec/models/spree/calculator/tiered_flat_rate_spec.rb

@@ -0,0 +1,40 @@
+require 'spec_helper'
+
+describe Spree::Calculator::TieredFlatRate, type: :model do
+  let(:calculator) { Spree::Calculator::TieredFlatRate.new }
+
+  describe "#valid?" do
+    subject { calculator.valid? }
+    context "when tiers is not a hash" do
+      before { calculator.preferred_tiers = ["nope", 0] }
+      it { is_expected.to be false }
+    end
+    context "when tiers is a hash" do
+      context "and one of the keys is not a positive number" do
+        before { calculator.preferred_tiers = { "nope" => 20 } }
+        it { is_expected.to be false }
+      end
+    end
+  end
+
+  describe "#compute" do
+    let(:line_item) { mock_model Spree::LineItem, amount: amount }
+    before do
+      calculator.preferred_base_amount = 10
+      calculator.preferred_tiers = {
+        100 => 15,
+        200 => 20
+      }
+    end
+    subject { calculator.compute(line_item) }
+    context "when amount falls within the first tier" do
+      let(:amount) { 50 }
+      it { is_expected.to eq 10 }
+    end
+    context "when amount falls within the second tier" do
+      let(:amount) { 150 }
+      it { is_expected.to eq 15 }
+    end
+  end
+end
+

data/spec/models/spree/calculator/tiered_percent_spec.rb

@@ -0,0 +1,51 @@
+require 'spec_helper'
+
+describe Spree::Calculator::TieredPercent, type: :model do
+  let(:calculator) { Spree::Calculator::TieredPercent.new }
+
+  describe "#valid?" do
+    subject { calculator.valid? }
+    context "when base percent is less than zero" do
+      before { calculator.preferred_base_percent = -1 }
+      it { is_expected.to be false }
+    end
+    context "when base percent is greater than 100" do
+      before { calculator.preferred_base_percent = 110 }
+      it { is_expected.to be false }
+    end
+    context "when tiers is not a hash" do
+      before { calculator.preferred_tiers = ["nope", 0] }
+      it { is_expected.to be false }
+    end
+    context "when tiers is a hash" do
+      context "and one of the keys is not a positive number" do
+        before { calculator.preferred_tiers = { "nope" => 20 } }
+        it { is_expected.to be false }
+      end
+      context "and one of the values is not a percent" do
+        before { calculator.preferred_tiers = { 10 => 110 } }
+        it { is_expected.to be false }
+      end
+    end
+  end
+
+  describe "#compute" do
+    let(:line_item) { mock_model Spree::LineItem, amount: amount }
+    before do
+      calculator.preferred_base_percent = 10
+      calculator.preferred_tiers = {
+        100 => 15,
+        200 => 20
+      }
+    end
+    subject { calculator.compute(line_item) }
+    context "when amount falls within the first tier" do
+      let(:amount) { 50 }
+      it { is_expected.to eq 5 }
+    end
+    context "when amount falls within the second tier" do
+      let(:amount) { 150 }
+      it { is_expected.to eq 22 }
+    end
+  end
+end