spree_core 3.2.9 → 3.3.0.rc1

data/spec/lib/spree/core/number_generator_spec.rb

@@ -0,0 +1,139 @@
+require 'spec_helper'
+
+describe Spree::Core::NumberGenerator do
+  let(:number_generator) { described_class.new(options) }
+
+  let(:model) do
+    mod = number_generator
+
+    Class.new(ApplicationRecord) do
+      self.table_name = 'spree_orders'
+      include mod
+    end
+  end
+
+  let(:options) { { prefix: 'R' } }
+
+  %i[prefix length].each do |name|
+    describe "##{name}" do
+      let(:value) { double('Generic Value') }
+
+      it 'returns attribute value from options' do
+        expect(described_class.new(options.merge(name => value)).public_send(name)).to be(value)
+      end
+    end
+
+    describe "##{name}=" do
+      let(:value_a) { double('Generic Value A') }
+      let(:value_b) { double('Generic Value B') }
+
+      it 'writes attribute value' do
+        object = described_class.new(options.merge(name => value_a))
+        expect { object.public_send(:"#{name}=", value_b) }
+          .to change { object.public_send(name) }
+          .from(value_a)
+          .to(value_b)
+      end
+    end
+  end
+
+  shared_examples_for 'duplicate without length increment' do
+
+    it 'sets permalink field' do
+      expect { subject }.to change(resource, :number).from(nil).to(String)
+      expect(resource.number).to match(regex)
+    end
+  end
+
+  shared_examples_for 'generating permalink'do
+    let(:resource) { model.new }
+
+    context 'and generated candidate is unique' do
+      before do
+        expect(model).to receive(:exists?).and_return(false)
+      end
+
+      it 'sets permalink field' do
+        expect { subject }.to change(resource, :number).from(nil).to(String)
+        expect(resource.number).to match(regex)
+      end
+    end
+
+    context 'and generated candidate is NOT unique' do
+      before do
+        expect(model).to receive(:exists?).and_return(true).ordered
+        expect(model).to receive(:count).and_return(record_count).ordered
+        expect(model).to receive(:exists?).and_return(false)
+      end
+
+      context 'and less than half of the value space taken' do
+        let(:record_count)   { 10 ** expected_length / 2 - 1 }
+
+        include_examples 'duplicate without length increment'
+      end
+
+      context 'and exactly half of the value space taken' do
+        let(:record_count)   { 10 ** expected_length / 2 }
+
+        include_examples 'duplicate without length increment'
+      end
+
+      context 'and more than half of the value space is taken' do
+        let(:record_count)   { 10 ** expected_length / 2 + 1 }
+
+        it 'sets permalink field' do
+          expect { subject }.to change(resource, :number).from(nil).to(String)
+          expect(resource.number).to match(regex_more_than_half)
+        end
+      end
+    end
+  end
+
+  describe '#included' do
+    context 'generates .number_generator on host' do
+      it 'returns number generator' do
+        expect(model.number_generator).to be(number_generator)
+      end
+    end
+
+    context 'generates validation hooks on host' do
+      subject { resource.valid? }
+
+      let(:expected_length)      { 9 }
+      let(:regex)                { /R[0-9]{9}$/  }
+      let(:regex_more_than_half) { /R[0-9]{10}$/ }
+
+      context 'when permalink field value is nil' do
+        context 'on defaults' do
+
+          include_examples 'generating permalink'
+        end
+
+        context 'with length: option' do
+          let(:options)              { super().merge(length: 10) }
+          let(:expected_length)      { 10 }
+          let(:regex)                { /R[0-9]{10}$/ }
+          let(:regex_more_than_half) { /R[0-9]{11}$/ }
+
+          include_examples 'generating permalink'
+        end
+
+        context 'with letters option' do
+          let(:options)              { super().merge(letters: true) }
+          let(:regex)                { /R[0-9A-Z]{9}$/  }
+          let(:regex_more_than_half) { /R[0-9A-Z]{10}$/ }
+
+          include_examples 'generating permalink'
+        end
+      end
+
+      context 'when permalink field value is present' do
+        let(:resource) { model.new(number: 'Test') }
+
+        it 'does not touch field' do
+          expect { subject }.not_to change(resource, :number)
+        end
+      end
+    end
+  end
+end

data/spec/lib/spree/core/token_generator_spec.rb

@@ -0,0 +1,24 @@
+require 'spec_helper'
+
+describe Spree::Core::TokenGenerator do
+  class DummyClass
+    include Spree::Core::TokenGenerator
+
+    attr_reader :created_at
+
+    def initialize
+      @created_at = Time.now.to_i
+    end
+  end
+
+  let(:dummy_class_instance) { DummyClass.new }
+
+  describe 'generate_guest_token' do
+    let(:generated_token) { dummy_class_instance.generate_guest_token }
+
+    it 'generates random token with timestamp' do
+      expect(generated_token.size).to eq 35
+      expect(generated_token).to include dummy_class_instance.created_at.to_s
+    end
+  end
+end

data/spec/lib/spree/core/validators/email_spec.rb

@@ -0,0 +1,54 @@
+require 'spec_helper'
+
+describe EmailValidator do
+
+  class Tester
+    include ActiveModel::Validations
+    attr_accessor :email_address
+    validates :email_address, email: true
+  end
+
+  let(:valid_emails) {[
+    'valid@email.com',
+    'valid@email.com.uk',
+    'e@email.com',
+    'valid+email@email.com',
+    'valid-email@email.com',
+    'valid_email@email.com',
+    'validemail_@email.com',
+    'valid.email@email.com',
+    'valid.email@email.photography'
+  ]}
+  let(:invalid_emails) {[
+    '',
+    ' ',
+    'invalid email@email.com',
+    'invalidemail @email.com',
+    'invalidemail@email..com',
+    '.invalid.email@email.com',
+    'invalid.email.@email.com',
+    '@email.com',
+    '.@email.com',
+    'invalidemailemail.com',
+    '@invalid.email@email.com',
+    'invalid@email@email.com',
+    'invalid.email@@email.com'
+  ]}
+
+  it 'validates valid email addresses' do
+    tester = Tester.new
+    valid_emails.each do |email|
+      tester.email_address = email
+      expect(tester.valid?).to be true
+    end
+  end
+
+  it 'validates invalid email addresses' do
+    tester = Tester.new
+    invalid_emails.each do |email|
+      tester.email_address = email
+      expect(tester.valid?).to be false
+    end
+  end
+
+end

data/spec/lib/spree/core_spec.rb

@@ -0,0 +1,23 @@
+require 'spec_helper'
+
+describe Spree do
+  describe '.admin_path' do
+    it { expect(Spree.admin_path).to eq(Spree::Config[:admin_path]) }
+  end
+
+  describe '.admin_path=' do
+    let!(:original_admin_path) { Spree.admin_path }
+    let(:new_admin_path) { '/admin-secret-path' }
+
+    before do
+      Spree.admin_path = new_admin_path
+    end
+
+    it { expect(Spree.admin_path).to eq(new_admin_path) }
+    it { expect(Spree::Config[:admin_path]).to eq(new_admin_path) }
+
+    after do
+      Spree.admin_path = original_admin_path
+    end
+  end
+end

data/spec/lib/spree/localized_number_spec.rb

@@ -0,0 +1,54 @@
+require 'spec_helper'
+
+describe Spree::LocalizedNumber do
+
+  context ".parse" do
+    before do
+      I18n.enforce_available_locales = false
+      I18n.locale = I18n.default_locale
+      I18n.backend.store_translations(:de, { number: { currency: { format: { delimiter: '.', separator: ',' } } } })
+    end
+
+    after do
+      I18n.locale = I18n.default_locale
+      I18n.enforce_available_locales = true
+    end
+
+    context "with decimal point" do
+      it "captures the proper amount for a formatted price" do
+        expect(subject.class.parse('1,599.99')).to eql 1599.99
+      end
+    end
+
+    context "with decimal comma" do
+      it "captures the proper amount for a formatted price" do
+        I18n.locale = :de
+        expect(subject.class.parse('1.599,99')).to eql 1599.99
+      end
+    end
+
+    context "with a numeric price" do
+      it "uses the price as is" do
+        I18n.locale = :de
+        expect(subject.class.parse(1599.99)).to eql 1599.99
+      end
+    end
+
+    context "string argument" do
+      it "should not be modified" do
+        I18n.locale = :de
+        number = '1.599,99'
+        number_bak = number.dup
+        subject.class.parse(number)
+        expect(number).to eql(number_bak)
+      end
+    end
+
+    context "with empty string" do
+      it "should return 0" do
+        expect(subject.class.parse('')).to eql 0
+      end
+    end
+  end
+
+end

data/spec/lib/spree/migrations_spec.rb

@@ -0,0 +1,36 @@
+require 'spec_helper'
+
+module Spree
+  describe Migrations do
+    let(:app_migrations) { [".", "34_add_title.rb", "52_add_text.rb"] }
+    let(:engine_migrations) { [".", "334_create_orders.spree.rb", "777_create_products.spree.rb"] }
+
+    let(:config) { double("Config", root: "dir") }
+
+    let(:engine_dir) { "dir/db/migrate" }
+    let(:app_dir) { "#{Rails.root}/db/migrate" }
+
+    subject { described_class.new(config, "spree") }
+
+    before do
+      expect(File).to receive(:directory?).with(app_dir).and_return true
+    end
+
+    it "warns about missing migrations" do
+      expect(Dir).to receive(:entries).with(app_dir).and_return app_migrations
+      expect(Dir).to receive(:entries).with(engine_dir).and_return engine_migrations
+
+      silence_stream(STDOUT) {
+        expect(subject.check).to eq true
+      }
+    end
+
+    context "no missing migrations" do
+      it "says nothing" do
+        expect(Dir).to receive(:entries).with(engine_dir).and_return engine_migrations
+        expect(Dir).to receive(:entries).with(app_dir).and_return(app_migrations + engine_migrations)
+        expect(subject.check).to eq nil
+      end
+    end
+  end
+end

data/spec/lib/spree/money_spec.rb

@@ -0,0 +1,122 @@
+# coding: utf-8
+require 'spec_helper'
+
+describe Spree::Money do
+  before do
+    configure_spree_preferences do |config|
+      config.currency = "USD"
+    end
+  end
+
+  it "formats correctly" do
+    money = Spree::Money.new(10)
+    expect(money.to_s).to eq("$10.00")
+  end
+
+  it "can get cents" do
+    money = Spree::Money.new(10)
+    expect(money.cents).to eq(1000)
+  end
+
+  context "with currency" do
+    it "passed in option" do
+      money = Spree::Money.new(10, with_currency: true, html: false)
+      expect(money.to_s).to eq("$10.00 USD")
+    end
+  end
+
+  context "hide cents" do
+    it "hides cents suffix" do
+      money = Spree::Money.new(10, no_cents: true)
+      expect(money.to_s).to eq("$10")
+    end
+
+    it "shows cents suffix" do
+      money = Spree::Money.new(10)
+      expect(money.to_s).to eq("$10.00")
+    end
+  end
+
+  context "currency parameter" do
+    context "when currency is specified in Canadian Dollars" do
+      it "uses the currency param over the global configuration" do
+        money = Spree::Money.new(10, currency: 'CAD', with_currency: true, html: false)
+        expect(money.to_s).to eq("$10.00 CAD")
+      end
+    end
+
+    context "when currency is specified in Japanese Yen" do
+      it "uses the currency param over the global configuration" do
+        money = Spree::Money.new(100, currency: 'JPY', html: false)
+        expect(money.to_s).to eq("¥100")
+      end
+    end
+  end
+
+  context "symbol positioning" do
+    it "passed in option" do
+      money = Spree::Money.new(10, symbol_position: :after, html: false)
+      expect(money.to_s).to eq("10.00 $")
+    end
+  end
+
+  context "sign before symbol" do
+    it "defaults to -$10.00" do
+      money = Spree::Money.new(-10)
+      expect(money.to_s).to eq("-$10.00")
+    end
+
+    it "passed in option" do
+      money = Spree::Money.new(-10, sign_before_symbol: false)
+      expect(money.to_s).to eq("$-10.00")
+    end
+  end
+
+  context "JPY" do
+    before do
+      configure_spree_preferences do |config|
+        config.currency = "JPY"
+      end
+    end
+
+    it "formats correctly" do
+      money = Spree::Money.new(1000, html: false)
+      expect(money.to_s).to eq("¥1,000")
+    end
+  end
+
+  context "EUR" do
+    before do
+      configure_spree_preferences do |config|
+        config.currency = "EUR"
+      end
+    end
+
+    # Regression test for #2634
+    it "formats as plain by default" do
+      money = Spree::Money.new(10, symbol_position: :after)
+      expect(money.to_s).to eq("10.00 €")
+    end
+
+    it "formats as HTML if asked (nicely) to" do
+      money = Spree::Money.new(10, symbol_position: :after)
+      # The HTML'ified version of "10.00 €"
+      expect(money.to_html).to eq("10.00 €")
+    end
+
+    it "formats as HTML with currency" do
+      money = Spree::Money.new(10, symbol_position: :after, with_currency: true)
+      # The HTML'ified version of "10.00 €"
+      expect(money.to_html).to eq("10.00&nbsp;&#x20AC; <span class=\"currency\">EUR</span>")
+    end
+  end
+
+  describe "#as_json" do
+    let(:options) { double('options') }
+
+    it "returns the expected string" do
+      money = Spree::Money.new(10)
+      expect(money.as_json(options)).to eq("$10.00")
+    end
+  end
+end