spree_core 3.2.9 → 3.3.0.rc1

data/spec/models/spree/calculator_spec.rb

@@ -0,0 +1,69 @@
+require 'spec_helper'
+
+describe Spree::Calculator, type: :model do
+
+  let(:order) { create(:order) }
+  let!(:line_item) { create(:line_item, order: order) }
+  let(:shipment) { create(:shipment, order: order, stock_location: create(:stock_location_with_items)) }
+
+  context "with computable" do
+    context "and compute methods stubbed out" do
+      context "with a Spree::LineItem" do
+        it "calls compute_line_item" do
+          expect(subject).to receive(:compute_line_item).with(line_item)
+          subject.compute(line_item)
+        end
+      end
+
+      context "with a Spree::Order" do
+        it "calls compute_order" do
+          expect(subject).to receive(:compute_order).with(order)
+          subject.compute(order)
+        end
+      end
+
+      context "with a Spree::Shipment" do
+        it "calls compute_shipment" do
+          expect(subject).to receive(:compute_shipment).with(shipment)
+          subject.compute(shipment)
+        end
+      end
+
+      context "with a arbitray object" do
+        it "calls the correct compute" do
+          s = "Calculator can all"
+          expect(subject).to receive(:compute_string).with(s)
+          subject.compute(s)
+        end
+      end
+    end
+
+  context "with no stubbing" do
+    context "with a Spree::LineItem" do
+        it "raises NotImplementedError" do
+          expect{subject.compute(line_item)}.to raise_error NotImplementedError, /Please implement \'compute_line_item\(line_item\)\' in your calculator/
+        end
+      end
+
+      context "with a Spree::Order" do
+        it "raises NotImplementedError" do
+          expect{subject.compute(order)}.to raise_error NotImplementedError, /Please implement \'compute_order\(order\)\' in your calculator/
+        end
+      end
+
+      context "with a Spree::Shipment" do
+        it "raises NotImplementedError" do
+          expect{subject.compute(shipment)}.to raise_error NotImplementedError, /Please implement \'compute_shipment\(shipment\)\' in your calculator/
+        end
+      end
+
+      context "with a arbitray object" do
+        it "raises NotImplementedError" do
+          s = "Calculator can all"
+          expect{subject.compute(s)}.to raise_error NotImplementedError, /Please implement \'compute_string\(string\)\' in your calculator/
+        end
+      end
+    end
+  end
+
+end

data/spec/models/spree/classification_spec.rb

@@ -0,0 +1,93 @@
+require 'spec_helper'
+
+module Spree
+  describe Classification, type: :model do
+    # Regression test for #3494
+    it "cannot link the same taxon to the same product more than once" do
+      product = create(:product)
+      taxon = create(:taxon)
+      add_taxon = lambda { product.taxons << taxon }
+      expect(add_taxon).not_to raise_error
+      expect(add_taxon).to raise_error(ActiveRecord::RecordInvalid)
+    end
+
+    let(:taxon_with_5_products) do
+      products = []
+      5.times do
+        products << create(:base_product)
+      end
+
+      create(:taxon, products: products)
+    end
+
+    def positions_to_be_valid(taxon)
+      positions = taxon.reload.classifications.map(&:position)
+      expect(positions).to eq((1..taxon.classifications.count).to_a)
+    end
+
+    it "has a valid fixtures" do
+      expect positions_to_be_valid(taxon_with_5_products)
+      expect(Spree::Classification.count).to eq 5
+    end
+
+    context "removing product from taxon" do
+      before :each do
+        p = taxon_with_5_products.products[1]
+        expect(p.classifications.first.position).to eq(2)
+        taxon_with_5_products.products.destroy(p)
+      end
+
+      it "resets positions" do
+        expect positions_to_be_valid(taxon_with_5_products)
+      end
+    end
+
+    context "replacing taxon's products" do
+      before :each do
+        products = taxon_with_5_products.products.to_a
+        products.pop(1)
+        taxon_with_5_products.products = products
+        taxon_with_5_products.save!
+      end
+
+      it "resets positions" do
+        expect positions_to_be_valid(taxon_with_5_products)
+      end
+    end
+
+    context "removing taxon from product" do
+      before :each do
+        p = taxon_with_5_products.products[1]
+        p.taxons.destroy(taxon_with_5_products)
+        p.save!
+      end
+
+      it "resets positions" do
+        expect positions_to_be_valid(taxon_with_5_products)
+      end
+    end
+
+    context "replacing product's taxons" do
+      before :each do
+        p = taxon_with_5_products.products[1]
+        p.taxons = []
+        p.save!
+      end
+
+      it "resets positions" do
+        expect positions_to_be_valid(taxon_with_5_products)
+      end
+    end
+
+    context "destroying classification" do
+      before :each do
+        classification = taxon_with_5_products.classifications[1]
+        classification.destroy
+      end
+
+      it "resets positions" do
+        expect positions_to_be_valid(taxon_with_5_products)
+      end
+    end
+  end
+end

data/spec/models/spree/concerns/display_money_spec.rb

@@ -0,0 +1,43 @@
+require 'spec_helper'
+
+module Spree
+
+  describe DisplayMoney do
+    let(:test_class) do
+      Class.new do
+        extend DisplayMoney
+        def total; 10.0; end
+      end
+    end
+
+    describe ".money_methods" do
+      before { test_class.money_methods :total }
+
+      context "currency is not defined" do
+        it "generates a display_method that builds a Spree::Money without options" do
+          expect(test_class.new.display_total).to eq Spree::Money.new(10.0)
+        end
+      end
+
+      context "currency is defined" do
+        before { test_class.class_eval { def currency; "USD"; end } }
+
+        it "generates a display_* method that builds a Spree::Money with currency" do
+          expect(test_class.new.display_total).to eq Spree::Money.new(10.0, currency: "USD")
+        end
+      end
+
+      context "with multiple + options" do
+        before do
+          test_class.class_eval { def amount; 20.0; end }
+          test_class.money_methods :total, amount: { no_cents: true }
+        end
+
+        it "generates a display_* method that builds a Spree::Money with the specified options" do
+          expect(test_class.new.display_total).to eq Spree::Money.new(10.0)
+          expect(test_class.new.display_amount).to eq Spree::Money.new(20.0, no_cents: true)
+        end
+      end
+    end
+  end
+end

data/spec/models/spree/concerns/user_methods_spec.rb

@@ -0,0 +1,82 @@
+require 'spec_helper'
+
+describe Spree::UserMethods do
+  let(:test_user) { create :user }
+
+  describe 'Associations' do
+    subject { test_user }
+
+    it 'should have many promotion_rule_users' do
+      is_expected.to have_many(:promotion_rule_users).with_foreign_key(:user_id).
+        class_name('Spree::PromotionRuleUser').dependent(:destroy)
+    end
+
+    it 'should have many role_users' do
+      is_expected.to have_many(:role_users).class_name('Spree::RoleUser').
+        with_foreign_key(:user_id).dependent(:destroy)
+    end
+  end
+
+  describe '#has_spree_role?' do
+    subject { test_user.has_spree_role? name }
+
+    let(:role) { Spree::Role.create(name: name) }
+    let(:name) { 'test' }
+
+    context 'with a role' do
+      before { test_user.spree_roles << role }
+      it { is_expected.to be_truthy }
+    end
+
+    context 'without a role' do
+      it { is_expected.to be_falsy }
+    end
+  end
+
+  describe '#last_incomplete_spree_order' do
+    subject { test_user.last_incomplete_spree_order }
+
+    context 'with an incomplete order' do
+      let(:last_incomplete_order) { create :order, user: test_user }
+
+      before do
+        create(:order, user: test_user, created_at: 1.day.ago)
+        create(:order, user: create(:user))
+        last_incomplete_order
+      end
+
+      it { is_expected.to eq last_incomplete_order }
+    end
+
+    context 'without an incomplete order' do
+      it { is_expected.to be_nil }
+    end
+  end
+
+  context '#check_completed_orders' do
+    let(:possible_promotion) { create(:promotion, advertise: true, starts_at: 1.day.ago) }
+    context 'rstrict t delete dependent destroyed' do
+      before do
+        test_user.promotion_rules.create!(promotion: possible_promotion)
+        create(:order, user: test_user, completed_at: Time.current)
+      end
+
+      it 'should not destroy dependent destroy items' do
+        expect { test_user.destroy }.to raise_error(Spree::Core::DestroyWithOrdersError)
+        expect(test_user.promotion_rule_users.any?).to be(true)
+      end
+    end
+
+    context 'allow to destroy dependent destroy' do
+      before do
+        test_user.promotion_rules.create!(promotion: possible_promotion)
+        create(:order, user: test_user, created_at: 1.day.ago)
+        test_user.destroy
+      end
+
+      it 'should not destroy dependent destroy items' do
+        expect(test_user.promotion_rule_users.any?).to be(false)
+      end
+    end
+  end
+end

data/spec/models/spree/concerns/vat_price_calculation_spec.rb

@@ -0,0 +1,66 @@
+require "spec_helper"
+
+module Spree
+  describe VatPriceCalculation do
+    let(:test_class) do
+      Class.new do
+        include VatPriceCalculation
+        def total; 10.0; end
+      end
+    end
+
+    describe "#gross_amount" do
+      let(:zone) { Zone.new }
+      let(:tax_category) { TaxCategory.new }
+      let(:price_options) do
+        {
+          tax_zone: zone,
+          tax_category: tax_category
+        }
+      end
+      let(:amount) { 100 }
+
+      subject(:gross_amount) { test_class.new.gross_amount(amount, price_options) }
+
+      context "with no default zone set" do
+        it "does not call TaxRate.included_tax_amount_for" do
+          expect(TaxRate).not_to receive(:included_tax_amount_for)
+          gross_amount
+        end
+      end
+
+      context "with no zone given" do
+        let(:zone) { nil }
+        it "does not call TaxRate.included_tax_amount_for" do
+          expect(TaxRate).not_to receive(:included_tax_amount_for)
+          gross_amount
+        end
+      end
+
+      context "with a default zone set" do
+        let(:default_zone) { Spree::Zone.new }
+        before do
+          allow(Spree::Zone).to receive(:default_tax).and_return(default_zone)
+        end
+
+        context "and zone equal to the default zone" do
+          let(:zone) { default_zone }
+
+          it "does not call 'TaxRate.included_tax_amount_for'" do
+            expect(TaxRate).not_to receive(:included_tax_amount_for)
+            gross_amount
+          end
+        end
+
+        context "and zone not equal to default zone" do
+          let(:zone) { Spree::Zone.new }
+
+          it "calls TaxRate.included_tax_amount_for two times" do
+            expect(TaxRate).to receive(:included_tax_amount_for).twice
+            gross_amount
+          end
+        end
+      end
+    end
+  end
+end

data/spec/models/spree/country_spec.rb

@@ -0,0 +1,55 @@
+require 'spec_helper'
+
+describe Spree::Country, type: :model do
+  let(:america) { create :country }
+  let(:canada)  { create :country, name: 'Canada', iso_name: 'CANADA', numcode: '124' }
+
+  describe 'Callbacks' do
+    it { is_expected.to callback(:ensure_not_default).before(:destroy) }
+  end
+
+  describe 'Associations' do
+    it { is_expected.to have_many(:addresses).dependent(:restrict_with_error) }
+  end
+
+  describe 'Validations' do
+    it { is_expected.to validate_presence_of(:name) }
+    it { is_expected.to validate_presence_of(:iso_name) }
+    it { is_expected.to validate_uniqueness_of(:iso_name).case_insensitive }
+    it { is_expected.to validate_uniqueness_of(:name).case_insensitive }
+  end
+
+  describe '.default' do
+    context 'when default_country_id config is set' do
+      before { Spree::Config[:default_country_id] = canada.id }
+      it 'will return the country from the config' do
+        expect(described_class.default.id).to eql canada.id
+      end
+    end
+
+    context 'config is not set though record for america exists' do
+      before { america.touch }
+      it 'will return the US' do
+        expect(described_class.default.id).to eql america.id
+      end
+    end
+  end
+
+  describe 'ensure default country in not deleted' do
+    before { Spree::Config[:default_country_id] = america.id }
+
+    context 'will not destroy country if it is default' do
+      subject { america.destroy }
+      it { is_expected.to be_falsy }
+
+      context 'error should be default country cannot be deleted' do
+        before { subject }
+        it { expect(america.errors[:base]).to include(Spree.t(:default_country_cannot_be_deleted)) }
+      end
+    end
+
+    context 'will destroy if it is not a default' do
+      it { expect(canada.destroy).to be_truthy }
+    end
+  end
+end

data/spec/models/spree/credit_card_spec.rb

@@ -0,0 +1,328 @@
+require 'spec_helper'
+
+describe Spree::CreditCard, type: :model do
+  let(:valid_credit_card_attributes) do
+    {
+      number: '4111111111111111',
+      verification_value: '123',
+      expiry: "12 / #{(Time.current.year + 1).to_s.last(2)}",
+      name: 'Spree Commerce'
+    }
+  end
+
+  def self.payment_states
+    Spree::Payment.state_machine.states.keys
+  end
+
+  let(:credit_card) { Spree::CreditCard.new }
+
+  before(:each) do
+
+    @order = create(:order)
+    @payment = Spree::Payment.create(amount: 100, order: @order)
+
+    @success_response = double('gateway_response', success?: true, authorization: '123', avs_result: { 'code' => 'avs-code' })
+    @fail_response = double('gateway_response', success?: false)
+
+    @payment_gateway = mock_model(Spree::PaymentMethod,
+      payment_profiles_supported?: true,
+      authorize: @success_response,
+      purchase: @success_response,
+      capture: @success_response,
+      void: @success_response,
+      credit: @success_response,
+    )
+
+    allow(@payment).to receive_messages payment_method: @payment_gateway
+  end
+
+  it 'should respond to track_data' do
+    expect(credit_card.respond_to?(:track_data)).to be true
+  end
+
+  context "#can_capture?" do
+    it "should be true if payment is pending" do
+      payment = mock_model(Spree::Payment, pending?: true, created_at: Time.current)
+      expect(credit_card.can_capture?(payment)).to be true
+    end
+
+    it "should be true if payment is checkout" do
+      payment = mock_model(Spree::Payment, pending?: false, checkout?: true, created_at: Time.current)
+      expect(credit_card.can_capture?(payment)).to be true
+    end
+  end
+
+  context "#can_void?" do
+    it "should be true if payment is not void" do
+      payment = mock_model(Spree::Payment, failed?: false, void?: false)
+      expect(credit_card.can_void?(payment)).to be true
+    end
+  end
+
+  context "#can_credit?" do
+    it "should be false if payment is not completed" do
+      payment = mock_model(Spree::Payment, completed?: false)
+      expect(credit_card.can_credit?(payment)).to be false
+    end
+
+    it "should be false when credit_allowed is zero" do
+      payment = mock_model(Spree::Payment, completed?: true, credit_allowed: 0, order: mock_model(Spree::Order, payment_state: 'credit_owed'))
+      expect(credit_card.can_credit?(payment)).to be false
+    end
+  end
+
+  context "#valid?" do
+    it "should validate presence of number" do
+      credit_card.attributes = valid_credit_card_attributes.except(:number)
+      expect(credit_card).not_to be_valid
+      expect(credit_card.errors[:number]).to eq(["can't be blank"])
+    end
+
+    it "should validate presence of security code" do
+      credit_card.attributes = valid_credit_card_attributes.except(:verification_value)
+      expect(credit_card).not_to be_valid
+      expect(credit_card.errors[:verification_value]).to eq(["can't be blank"])
+    end
+
+    it "validates name presence" do
+      credit_card.valid?
+      expect(credit_card.error_on(:name).size).to eq(1)
+    end
+
+    it "should only validate on create" do
+      credit_card.attributes = valid_credit_card_attributes
+      credit_card.save
+      expect(credit_card).to be_valid
+    end
+
+    context "encrypted data is present" do
+      it "does not validate presence of number or cvv" do
+        credit_card.encrypted_data = "$fdgsfgdgfgfdg&gfdgfdgsf-"
+        credit_card.valid?
+        expect(credit_card.errors[:number]).to be_empty
+        expect(credit_card.errors[:verification_value]).to be_empty
+      end
+    end
+
+    context "imported is true" do
+      it "does not validate presence of number or cvv" do
+        credit_card.imported = true
+        credit_card.valid?
+        expect(credit_card.errors[:number]).to be_empty
+        expect(credit_card.errors[:verification_value]).to be_empty
+      end
+    end
+  end
+
+  context "#save" do
+    before do
+      credit_card.attributes = valid_credit_card_attributes
+      credit_card.save!
+    end
+
+    let!(:persisted_card) { Spree::CreditCard.find(credit_card.id) }
+
+    it "should not actually store the number" do
+      expect(persisted_card.number).to be_blank
+    end
+
+    it "should not actually store the security code" do
+      expect(persisted_card.verification_value).to be_blank
+    end
+  end
+
+  context "#number=" do
+    it "should strip non-numeric characters from card input" do
+      credit_card.number = "6011000990139424"
+      expect(credit_card.number).to eq("6011000990139424")
+
+      credit_card.number = "  6011-0009-9013-9424  "
+      expect(credit_card.number).to eq("6011000990139424")
+    end
+
+    it "should not raise an exception on non-string input" do
+      credit_card.number = Hash.new
+      expect(credit_card.number).to be_nil
+    end
+  end
+
+  # Regression test for #3847 & #3896
+  context "#expiry=" do
+    it "can set with a 2-digit month and year" do
+      credit_card.expiry = '04 / 14'
+      expect(credit_card.month).to eq(4)
+      expect(credit_card.year).to eq(2014)
+    end
+
+    it "can set with a 2-digit month and 4-digit year" do
+      credit_card.expiry = '04 / 2014'
+      expect(credit_card.month).to eq(4)
+      expect(credit_card.year).to eq(2014)
+    end
+
+    it "can set with a 2-digit month and 4-digit year without whitespace" do
+      credit_card.expiry = '04/14'
+      expect(credit_card.month).to eq(4)
+      expect(credit_card.year).to eq(2014)
+    end
+
+    it "can set with a 2-digit month and 4-digit year without whitespace" do
+      credit_card.expiry = '04/2014'
+      expect(credit_card.month).to eq(4)
+      expect(credit_card.year).to eq(2014)
+    end
+
+    it "can set with a 2-digit month and 4-digit year without whitespace and slash" do
+      credit_card.expiry = '042014'
+      expect(credit_card.month).to eq(4)
+      expect(credit_card.year).to eq(2014)
+    end
+
+    it "can set with a 2-digit month and 2-digit year without whitespace and slash" do
+      credit_card.expiry = '0414'
+      expect(credit_card.month).to eq(4)
+      expect(credit_card.year).to eq(2014)
+    end
+
+    it "does not blow up when passed an empty string" do
+      expect { credit_card.expiry = '' }.not_to raise_error
+    end
+
+    # Regression test for #4725
+    it "does not blow up when passed one number" do
+      expect { credit_card.expiry = '12' }.not_to raise_error
+    end
+
+  end
+
+  context "#cc_type=" do
+    it "converts between the different types" do
+      credit_card.cc_type = 'mastercard'
+      expect(credit_card.cc_type).to eq('master')
+
+      credit_card.cc_type = 'maestro'
+      expect(credit_card.cc_type).to eq('master')
+
+      credit_card.cc_type = 'amex'
+      expect(credit_card.cc_type).to eq('american_express')
+
+      credit_card.cc_type = 'dinersclub'
+      expect(credit_card.cc_type).to eq('diners_club')
+
+      credit_card.cc_type = 'some_outlandish_cc_type'
+      expect(credit_card.cc_type).to eq('some_outlandish_cc_type')
+    end
+
+    it "assigns the type based on card number in the event of js failure" do
+      credit_card.number = '4242424242424242'
+      credit_card.cc_type = ''
+      expect(credit_card.cc_type).to eq('visa')
+
+      credit_card.number = '5555555555554444'
+      credit_card.cc_type = ''
+      expect(credit_card.cc_type).to eq('master')
+
+      credit_card.number = '2223000010309703'
+      credit_card.cc_type = ''
+      expect(credit_card.cc_type).to eq('master')
+
+      credit_card.number = '378282246310005'
+      credit_card.cc_type = ''
+      expect(credit_card.cc_type).to eq('american_express')
+
+      credit_card.number = '30569309025904'
+      credit_card.cc_type = ''
+      expect(credit_card.cc_type).to eq('diners_club')
+
+      credit_card.number = '3530111333300000'
+      credit_card.cc_type = ''
+      expect(credit_card.cc_type).to eq('jcb')
+
+      credit_card.number = ''
+      credit_card.cc_type = ''
+      expect(credit_card.cc_type).to eq('')
+
+      credit_card.number = nil
+      credit_card.cc_type = ''
+      expect(credit_card.cc_type).to eq('')
+    end
+  end
+
+  context "#associations" do
+    it "should be able to access its payments" do
+      expect { credit_card.payments.to_a }.not_to raise_error
+    end
+  end
+
+  context "#first_name" do
+    before do
+      credit_card.name = "Ludwig van Beethoven"
+    end
+
+    it "extracts the first name" do
+      expect(credit_card.first_name).to eq "Ludwig"
+    end
+  end
+
+  context "#last_name" do
+    before do
+      credit_card.name = "Ludwig van Beethoven"
+    end
+
+    it "extracts the last name" do
+      expect(credit_card.last_name).to eq "van Beethoven"
+    end
+  end
+
+  context "#to_active_merchant" do
+    before do
+      credit_card.number = "4111111111111111"
+      credit_card.year = Time.current.year
+      credit_card.month = Time.current.month
+      credit_card.name = "Ludwig van Beethoven"
+      credit_card.verification_value = 123
+    end
+
+    it "converts to an ActiveMerchant::Billing::CreditCard object" do
+      am_card = credit_card.to_active_merchant
+      expect(am_card.number).to eq("4111111111111111")
+      expect(am_card.year).to eq(Time.current.year)
+      expect(am_card.month).to eq(Time.current.month)
+      expect(am_card.first_name).to eq("Ludwig")
+      expect(am_card.last_name).to eq("van Beethoven")
+      expect(am_card.verification_value).to eq(123)
+    end
+  end
+
+  it 'ensures only one credit card per user is default at a time' do
+    user = FactoryGirl.create(:user)
+    first = FactoryGirl.create(:credit_card, user: user, default: true)
+    second = FactoryGirl.create(:credit_card, user: user, default: true)
+
+    expect(first.reload.default).to eq false
+    expect(second.reload.default).to eq true
+
+    first.default = true
+    first.save!
+
+    expect(first.reload.default).to eq true
+    expect(second.reload.default).to eq false
+  end
+
+  it 'allows default credit cards for different users' do
+    first = FactoryGirl.create(:credit_card, user: FactoryGirl.create(:user), default: true)
+    second = FactoryGirl.create(:credit_card, user: FactoryGirl.create(:user), default: true)
+
+    expect(first.reload.default).to eq true
+    expect(second.reload.default).to eq true
+  end
+
+  it 'allows this card to save even if the previously default card has expired' do
+    user = FactoryGirl.create(:user)
+    first = FactoryGirl.create(:credit_card, user: user, default: true)
+    second = FactoryGirl.create(:credit_card, user: user, default: false)
+    first.update_columns(year: DateTime.current.year, month: 1.month.ago.month)
+
+    expect { second.update_attributes!(default: true) }.not_to raise_error
+  end
+end