spree_core 3.2.9 → 3.3.0.rc1

data/spec/models/spree/store_spec.rb

@@ -0,0 +1,78 @@
+require 'spec_helper'
+
+describe Spree::Store, type: :model do
+
+  describe ".by_url" do
+    let!(:store)    { create(:store, url: "website1.com\nwww.subdomain.com") }
+    let!(:store_2)  { create(:store, url: 'freethewhales.com') }
+
+    it "should find stores by url" do
+      by_domain = Spree::Store.by_url('www.subdomain.com')
+
+      expect(by_domain).to include(store)
+      expect(by_domain).not_to include(store_2)
+    end
+  end
+
+  describe '.current' do
+    # there is a default store created with the test_app rake task.
+    let!(:store_1) { Spree::Store.first || create(:store) }
+
+    let!(:store_2) { create(:store, default: false, url: 'www.subdomain.com') }
+
+    it 'should return default when no domain' do
+      expect(subject.class.current).to eql(store_1)
+    end
+
+    it 'should return store for domain' do
+      expect(subject.class.current('spreecommerce.com')).to eql(store_1)
+      expect(subject.class.current('www.subdomain.com')).to eql(store_2)
+    end
+  end
+
+  describe '.default' do
+    context 'when a default store is already present' do
+      let!(:store)    { create(:store) }
+      let!(:store_2)  { create(:store, default: true) }
+
+      it 'should return the already existing default store' do
+        expect(Spree::Store.default).to eq(store_2)
+      end
+
+      it "should ensure there is a default if one doesn't exist yet" do
+        expect(store_2.default).to be true
+      end
+
+      it 'should ensure there is only one default' do
+        [store, store_2].each(&:reload)
+
+        expect(Spree::Store.where(default: true).count).to eq(1)
+        expect(store_2.default).to be true
+        expect(store.default).not_to be true
+      end
+
+      context 'when store is not saved' do
+        before do
+          store.default = true
+          store.code = nil
+          store.save
+        end
+
+        it 'ensure old default location still default' do
+          [store, store_2].each(&:reload)
+          expect(store.default).to be false
+          expect(store_2.default).to be true
+        end
+      end
+    end
+
+    context 'when a default store is not present' do
+      it 'should build a new default store' do
+        expect(Spree::Store.default.class).to eq(Spree::Store)
+        expect(Spree::Store.default.persisted?).to eq(false)
+        expect(Spree::Store.default.default).to be(true)
+      end
+    end
+  end
+
+end

data/spec/models/spree/tax_category_spec.rb

@@ -0,0 +1,32 @@
+require 'spec_helper'
+
+describe Spree::TaxCategory, type: :model do
+  describe 'Validations' do
+    it { is_expected.to validate_presence_of(:name) }
+    it { is_expected.to validate_uniqueness_of(:name).scoped_to(:deleted_at).case_insensitive }
+  end
+
+  context 'default tax category' do
+    let(:tax_category) { create(:tax_category) }
+    let(:new_tax_category) { create(:tax_category) }
+
+    before do
+      tax_category.update_column(:is_default, true)
+    end
+
+    it "should undefault the previous default tax category" do
+      new_tax_category.update_attributes({is_default: true})
+      expect(new_tax_category.is_default).to be true
+
+      tax_category.reload
+      expect(tax_category.is_default).to be false
+    end
+
+    it "should undefault the previous default tax category except when updating the existing default tax category" do
+      tax_category.update_column(:description, "Updated description")
+
+      tax_category.reload
+      expect(tax_category.is_default).to be true
+    end
+  end
+end

data/spec/models/spree/tax_rate_spec.rb

@@ -0,0 +1,561 @@
+require 'spec_helper'
+
+describe Spree::TaxRate, type: :model do
+  context "match" do
+    let(:order) { create(:order) }
+    let(:country) { create(:country) }
+    let(:tax_category) { create(:tax_category) }
+    let(:calculator) { Spree::Calculator::FlatRate.new }
+
+    it "should return an empty array when tax_zone is nil" do
+      allow(order).to receive_messages tax_zone: nil
+      expect(Spree::TaxRate.match(order.tax_zone)).to eq([])
+    end
+
+    context "when no rate zones match the tax zone" do
+      before do
+        Spree::TaxRate.create(amount: 1, zone: create(:zone))
+      end
+
+      context "when there is no default tax zone" do
+        before do
+          @zone = create(:zone, name: "Country Zone", default_tax: false, zone_members: [])
+          @zone.zone_members.create(zoneable: country)
+        end
+
+        it "should return an empty array" do
+          allow(order).to receive_messages tax_zone: @zone
+          expect(Spree::TaxRate.match(order.tax_zone)).to eq([])
+        end
+
+        it "should return the rate that matches the rate zone" do
+          rate = Spree::TaxRate.create(
+            amount: 1,
+            zone: @zone,
+            tax_category: tax_category,
+            calculator: calculator
+          )
+
+          allow(order).to receive_messages tax_zone: @zone
+          expect(Spree::TaxRate.match(order.tax_zone)).to eq([rate])
+        end
+
+        it "should return all rates that match the rate zone" do
+          rate1 = Spree::TaxRate.create(
+            amount: 1,
+            zone: @zone,
+            tax_category: tax_category,
+            calculator: calculator
+          )
+
+          rate2 = Spree::TaxRate.create(
+            amount: 2,
+            zone: @zone,
+            tax_category: tax_category,
+            calculator: Spree::Calculator::FlatRate.new
+          )
+
+          allow(order).to receive_messages tax_zone: @zone
+          expect(Spree::TaxRate.match(order.tax_zone)).to match_array([rate1, rate2])
+        end
+
+        context "when the tax_zone is contained within a rate zone" do
+          before do
+            sub_zone = create(:zone, name: "State Zone", zone_members: [])
+            sub_zone.zone_members.create(zoneable: create(:state, country: country))
+            allow(order).to receive_messages tax_zone: sub_zone
+            @rate = Spree::TaxRate.create(
+              amount: 1,
+              zone: @zone,
+              tax_category: tax_category,
+              calculator: calculator
+            )
+          end
+
+          it "should return the rate zone" do
+            expect(Spree::TaxRate.match(order.tax_zone)).to eq([@rate])
+          end
+        end
+      end
+
+      context "when there is a default tax zone" do
+        before do
+          @zone = create(:zone, name: "Country Zone", default_tax: true, zone_members: [])
+          @zone.zone_members.create(zoneable: country)
+        end
+
+        let(:included_in_price) { false }
+        let!(:rate) do
+          Spree::TaxRate.create(amount: 1,
+                                zone: @zone,
+                                tax_category: tax_category,
+                                calculator: calculator,
+                                included_in_price: included_in_price)
+        end
+
+        subject { Spree::TaxRate.match(order.tax_zone) }
+
+        context "when the order has the same tax zone" do
+          before do
+            allow(order).to receive_messages tax_zone: @zone
+          end
+
+          context "when the tax is not a VAT" do
+            it { is_expected.to eq([rate]) }
+          end
+
+          context "when the tax is a VAT" do
+            let(:included_in_price) { true }
+            it { is_expected.to eq([rate]) }
+          end
+        end
+
+        context "when the order has a different tax zone" do
+          before do
+            allow(order).to receive_messages tax_zone: create(:zone, name: "Other Zone")
+          end
+
+          context "when the tax is a VAT" do
+            let(:included_in_price) { true }
+            # The rate should NOT match in this instance because:
+            # The order has a different tax zone, and the price is
+            # henceforth a net price and will not change.
+            it 'return no tax rate' do
+              expect(subject).to be_empty
+            end
+          end
+
+          context "when the tax is not VAT" do
+            it "returns no tax rate" do
+              expect(subject).to be_empty
+            end
+          end
+        end
+      end
+    end
+  end
+
+  describe ".adjust" do
+    let(:order) { stub_model(Spree::Order) }
+    let(:tax_category_1) { stub_model(Spree::TaxCategory) }
+    let(:tax_category_2) { stub_model(Spree::TaxCategory) }
+    let(:rate_1) { stub_model(Spree::TaxRate, tax_category: tax_category_1) }
+    let(:rate_2) { stub_model(Spree::TaxRate, tax_category: tax_category_2) }
+
+    context "with line items" do
+      let(:line_item) do
+        stub_model(Spree::LineItem,
+          price: 10.0,
+          quantity: 1,
+          tax_category: tax_category_1,
+          variant: stub_model(Spree::Variant)
+        )
+      end
+
+      let(:line_items) { [line_item] }
+
+      before do
+        allow(Spree::TaxRate).to receive_messages match: [rate_1, rate_2]
+      end
+
+      it "should apply adjustments for two tax rates to the order" do
+        expect(rate_1).to receive(:adjust)
+        expect(rate_2).not_to receive(:adjust)
+        Spree::TaxRate.adjust(order, line_items)
+      end
+    end
+
+    context "without tax rates" do
+      let(:line_item) do
+        stub_model(Spree::LineItem,
+          :price => 10.0,
+          :quantity => 2,
+          :tax_category => nil,
+          :variant => stub_model(Spree::Variant)
+        )
+      end
+
+      let(:line_items) { [line_item] }
+
+      it "should update pre_tax_total to match line item cost if no taxes" do
+        line_item.tax_category = nil
+        Spree::TaxRate.adjust(order, line_items)
+        expect(line_item.pre_tax_amount).to eq line_item.price * line_item.quantity
+      end
+    end
+
+    context "with shipments" do
+      let(:shipments) { [stub_model(Spree::Shipment, cost: 10.0, tax_category: tax_category_1)] }
+
+      before do
+        allow(Spree::TaxRate).to receive_messages match: [rate_1, rate_2]
+      end
+
+      it "should apply adjustments for two tax rates to the order" do
+        expect(rate_1).to receive(:adjust)
+        expect(rate_2).not_to receive(:adjust)
+        Spree::TaxRate.adjust(order, shipments)
+      end
+    end
+
+    context "for MOSS taxation in Europe" do
+      let(:germany) { create :country, name: "Germany" }
+      let(:india) { create :country, name: "India" }
+      let(:france) { create :country, name: "France" }
+      let(:france_zone) { create :zone_with_country, name: "France Zone" }
+      let(:germany_zone) { create :zone_with_country, name: "Germany Zone", default_tax: true }
+      let(:india_zone) { create :zone_with_country, name: "India" }
+      let(:moss_category) { Spree::TaxCategory.create(name: "Digital Goods") }
+      let(:normal_category) { Spree::TaxCategory.create(name: "Analogue Goods") }
+      let(:eu_zone) { create(:zone, name: "EU") }
+
+      let!(:german_vat) do
+        Spree::TaxRate.create(
+          name: "German VAT",
+          amount: 0.19,
+          calculator: Spree::Calculator::DefaultTax.create,
+          tax_category: moss_category,
+          zone: germany_zone,
+          included_in_price: true
+        )
+      end
+      let!(:french_vat) do
+        Spree::TaxRate.create(
+          name: "French VAT",
+          amount: 0.25,
+          calculator: Spree::Calculator::DefaultTax.create,
+          tax_category: moss_category,
+          zone: france_zone,
+          included_in_price: true
+        )
+      end
+      let!(:eu_vat) do
+        Spree::TaxRate.create(
+          name: "EU_VAT",
+          amount: 0.19,
+          calculator: Spree::Calculator::DefaultTax.create,
+          tax_category: normal_category,
+          zone: eu_zone,
+          included_in_price: true
+        )
+      end
+
+      let(:download) { create(:product, tax_category: moss_category, price: 100) }
+      let(:tshirt) { create(:product, tax_category: normal_category, price: 100) }
+      let(:order) { Spree::Order.create }
+
+      before do
+        germany_zone.zone_members.create(zoneable: germany)
+        france_zone.zone_members.create(zoneable: france)
+        india_zone.zone_members.create(zoneable: india)
+        eu_zone.zone_members.create(zoneable: germany)
+        eu_zone.zone_members.create(zoneable: france)
+      end
+
+      context "a download" do
+        before do
+          order.contents.add(download.master, 1)
+        end
+
+        it "without an adress costs 100 euros including tax" do
+          Spree::TaxRate.adjust(order, order.line_items)
+          order.update_with_updater!
+          expect(order.display_total).to eq(Spree::Money.new(100))
+          expect(order.included_tax_total).to eq(15.97)
+        end
+
+        it "to germany costs 100 euros including tax" do
+          allow(order).to receive(:tax_zone).and_return(germany_zone)
+          Spree::TaxRate.adjust(order, order.line_items)
+          order.update_with_updater!
+          expect(order.display_total).to eq(Spree::Money.new(100))
+          expect(order.included_tax_total).to eq(15.97)
+        end
+
+        it "to france costs more including tax" do
+          allow(order).to receive(:tax_zone).and_return(france_zone)
+          order.update_line_item_prices!
+          Spree::TaxRate.adjust(order, order.line_items)
+          order.update_with_updater!
+          expect(order.display_total).to eq(Spree::Money.new(105.04))
+          expect(order.included_tax_total).to eq(21.01)
+          expect(order.additional_tax_total).to eq(0)
+        end
+
+        it "to somewhere else costs the net amount" do
+          allow(order).to receive(:tax_zone).and_return(india_zone)
+          order.update_line_item_prices!
+          Spree::TaxRate.adjust(order, order.line_items)
+          order.update_with_updater!
+          expect(order.included_tax_total).to eq(0)
+          expect(order.included_tax_total).to eq(0)
+          expect(order.display_total).to eq(Spree::Money.new(84.03))
+        end
+      end
+
+      context "a t-shirt" do
+        before do
+          order.contents.add(tshirt.master, 1)
+        end
+
+        it "to germany costs 100 euros including tax" do
+          allow(order).to receive(:tax_zone).and_return(germany_zone)
+          Spree::TaxRate.adjust(order, order.line_items)
+          order.update_with_updater!
+          expect(order.display_total).to eq(Spree::Money.new(100))
+          expect(order.included_tax_total).to eq(15.97)
+        end
+
+        it "to france costs 100 euros including tax" do
+          allow(order).to receive(:tax_zone).and_return(france_zone)
+          order.update_line_item_prices!
+          Spree::TaxRate.adjust(order, order.line_items)
+          order.update_with_updater!
+          expect(order.display_total).to eq(Spree::Money.new(100.00))
+          expect(order.included_tax_total).to eq(15.97)
+          expect(order.additional_tax_total).to eq(0)
+        end
+
+        it "to somewhere else costs the net amount" do
+          allow(order).to receive(:tax_zone).and_return(india_zone)
+          order.update_line_item_prices!
+          Spree::TaxRate.adjust(order, order.line_items)
+          order.update_with_updater!
+          expect(order.included_tax_total).to eq(0)
+          expect(order.display_total).to eq(Spree::Money.new(84.03))
+        end
+      end
+    end
+  end
+
+  describe ".included_tax_amount_for" do
+    let!(:order) { create :order_with_line_items }
+    let!(:included_tax_rate) do
+      create :tax_rate,
+             included_in_price: true,
+             tax_category: order.line_items.first.tax_category,
+             zone: order.tax_zone,
+             amount: 0.4
+    end
+
+    let!(:other_included_tax_rate) do
+      create :tax_rate,
+             included_in_price: true,
+             tax_category: order.line_items.first.tax_category,
+             zone: order.tax_zone,
+             amount: 0.05
+    end
+
+    let!(:additional_tax_rate) do
+      create :tax_rate,
+             included_in_price: false,
+             tax_category: order.line_items.first.tax_category,
+             zone: order.tax_zone,
+             amount: 0.2
+    end
+
+    let!(:included_tax_rate_from_somewhere_else) do
+      create :tax_rate,
+             included_in_price: true,
+             tax_category: order.line_items.first.tax_category,
+             zone: create(:zone_with_country),
+             amount: 0.1
+    end
+    let(:price_options) do
+      {
+        tax_zone: order.tax_zone,
+        tax_category: line_item.tax_category
+      }
+    end
+
+
+    let(:line_item) { order.line_items.first }
+    subject(:included_tax_amount) { Spree::TaxRate.included_tax_amount_for(price_options) }
+
+    it 'will only get me tax amounts from tax_rates that match' do
+      expect(subject).to eq(included_tax_rate.amount + other_included_tax_rate.amount)
+    end
+  end
+
+  describe "#adjust" do
+    before do
+      @country = create(:country)
+      @zone = create(:zone, name: "Country Zone", default_tax: true, zone_members: [])
+      @zone.zone_members.create(zoneable: @country)
+      @category    = Spree::TaxCategory.create name: "Taxable Foo"
+      @category2   = Spree::TaxCategory.create(name: "Non Taxable")
+      @rate1        = Spree::TaxRate.create(
+        amount: 0.10,
+        calculator: Spree::Calculator::DefaultTax.create,
+        tax_category: @category,
+        zone: @zone
+      )
+      @rate2       = Spree::TaxRate.create(
+        amount: 0.05,
+        calculator: Spree::Calculator::DefaultTax.create,
+        tax_category: @category,
+        zone: @zone
+      )
+      @order       = Spree::Order.create!
+      @taxable     = create(:product, tax_category: @category)
+      @nontaxable  = create(:product, tax_category: @category2)
+    end
+
+    context "not taxable line item " do
+      let!(:line_item) { @order.contents.add(@nontaxable.master, 1) }
+
+      it "should not create a tax adjustment" do
+        Spree::TaxRate.adjust(@order, @order.line_items)
+        expect(line_item.adjustments.tax.charge.count).to eq(0)
+      end
+
+      it "should not create a refund" do
+        Spree::TaxRate.adjust(@order, @order.line_items)
+        expect(line_item.adjustments.credit.count).to eq(0)
+      end
+    end
+
+    context "taxable line item" do
+      let!(:line_item) { @order.contents.add(@taxable.master, 1) }
+
+      context "when price includes tax" do
+        before do
+          @rate1.update_column(:included_in_price, true)
+          @rate2.update_column(:included_in_price, true)
+          Spree::TaxRate.store_pre_tax_amount(line_item, [@rate1, @rate2])
+        end
+
+        context "when zone is contained by default tax zone" do
+          it "should create two adjustments, one for each tax rate" do
+            Spree::TaxRate.adjust(@order, @order.line_items)
+            expect(line_item.adjustments.count).to eq(2)
+          end
+
+          it "should not create a tax refund" do
+            Spree::TaxRate.adjust(@order, @order.line_items)
+            expect(line_item.adjustments.credit.count).to eq(0)
+          end
+        end
+
+        context "when order's zone is neither the default zone, or included in the default zone, but matches the rate's zone" do
+          before do
+            new_rate = Spree::TaxRate.create(
+              amount: 0.2,
+              included_in_price: true,
+              calculator: Spree::Calculator::DefaultTax.create,
+              tax_category: @category,
+              zone: create(:zone_with_country)
+            )
+            allow(@order).to receive(:tax_zone).and_return(new_rate.zone)
+          end
+
+          it "should create an adjustment" do
+            Spree::TaxRate.adjust(@order, @order.line_items)
+            expect(line_item.adjustments.charge.count).to eq(1)
+          end
+
+          it "should not create a tax refund for each tax rate" do
+            Spree::TaxRate.adjust(@order, @order.line_items)
+            expect(line_item.adjustments.credit.count).to eq(0)
+          end
+        end
+
+        context "when order's zone does not match default zone, is not included in the default zone, AND does not match the rate's zone" do
+          before do
+            @new_zone = create(:zone, name: "New Zone", default_tax: false)
+            @new_country = create(:country, name: "New Country")
+            @new_zone.zone_members.create(zoneable: @new_country)
+            @order.ship_address = create(:address, country: @new_country)
+            @order.save
+            @order.reload
+          end
+
+          it "should not create positive adjustments" do
+            Spree::TaxRate.adjust(@order, @order.line_items)
+            expect(line_item.adjustments.charge.count).to eq(0)
+          end
+
+          it "should not create a tax refund for each tax rate" do
+            Spree::TaxRate.adjust(@order, @order.line_items)
+            expect(line_item.adjustments.credit.count).to eq(0)
+          end
+        end
+
+        context "when price does not include tax" do
+          before do
+            allow(@order).to receive_messages tax_zone: @zone
+            [@rate1, @rate2].each do |rate|
+              rate.included_in_price = false
+              rate.zone = @zone
+              rate.save
+            end
+            Spree::TaxRate.adjust(@order, @order.line_items)
+          end
+
+          it "should delete adjustments for open order when taxrate is deleted" do
+            @rate1.destroy!
+            @rate2.destroy!
+            expect(line_item.adjustments.count).to eq(0)
+          end
+
+          it "should not delete adjustments for complete order when taxrate is deleted" do
+            @order.update_column :completed_at, Time.current
+            @rate1.destroy!
+            @rate2.destroy!
+            expect(line_item.adjustments.count).to eq(2)
+          end
+
+          it "should create an adjustment" do
+            expect(line_item.adjustments.count).to eq(2)
+          end
+
+          it "should not create a tax refund" do
+            expect(line_item.adjustments.credit.count).to eq(0)
+          end
+
+          describe 'tax adjustments' do
+            before { Spree::TaxRate.adjust(@order, @order.line_items) }
+
+            it "should apply adjustments when a tax zone is present" do
+              expect(line_item.adjustments.count).to eq(2)
+              line_item.adjustments.each do |adjustment|
+                expect(adjustment.label).to eq("#{adjustment.source.tax_category.name} #{adjustment.source.amount * 100}%")
+              end
+            end
+
+            describe 'when the tax zone is removed' do
+              before { allow(@order).to receive_messages tax_zone: nil }
+
+              it 'does not apply any adjustments' do
+                Spree::TaxRate.adjust(@order, @order.line_items)
+                expect(line_item.adjustments.count).to eq(0)
+              end
+            end
+          end
+        end
+
+        context "when two rates apply" do
+          before do
+            @price_before_taxes = line_item.price / (1 + @rate1.amount + @rate2.amount)
+            # Use the same rounding method as in DefaultTax calculator
+            @price_before_taxes = BigDecimal.new(@price_before_taxes).round(2, BigDecimal::ROUND_HALF_UP)
+            line_item.update_column(:pre_tax_amount, @price_before_taxes)
+            # Clear out any previously automatically-applied adjustments
+            @order.all_adjustments.delete_all
+            @rate1.adjust(@order, line_item)
+            @rate2.adjust(@order, line_item)
+          end
+
+          it "should create two price adjustments" do
+            expect(@order.line_item_adjustments.count).to eq(2)
+          end
+
+          it "price adjustments should be accurate" do
+            included_tax = @order.line_item_adjustments.sum(:amount)
+            expect(@price_before_taxes + included_tax).to eq(line_item.total)
+          end
+        end
+      end
+    end
+  end
+end