solidus_core 1.1.0 → 1.1.1

data/spec/models/spree/calculator/shipping/per_item_spec.rb

@@ -0,0 +1,20 @@
+require 'spec_helper'
+
+module Spree
+  module Calculator::Shipping
+    describe PerItem, :type => :model do
+      let(:variant1) { build(:variant) }
+      let(:variant2) { build(:variant) }
+
+      let(:package) do
+        build(:stock_package, variants_contents: { variant1 => 5, variant2 => 3 })
+      end
+
+      subject { PerItem.new(:preferred_amount => 10) }
+
+      it "correctly calculates per item shipping" do
+        expect(subject.compute(package).to_f).to eq(80) # 5 x 10 + 3 x 10
+      end
+    end
+  end
+end

data/spec/models/spree/calculator/shipping/price_sack_spec.rb

@@ -0,0 +1,30 @@
+require 'spec_helper'
+
+describe Spree::Calculator::PriceSack, :type => :model do
+  let(:calculator) do
+    calculator = Spree::Calculator::PriceSack.new
+    calculator.preferred_minimal_amount = 5
+    calculator.preferred_normal_amount = 10
+    calculator.preferred_discount_amount = 1
+    calculator
+  end
+
+  let(:order) { stub_model(Spree::Order) }
+  let(:shipment) { stub_model(Spree::Shipment, :amount => 10) }
+
+  # Regression test for #714 and #739
+  it "computes with an order object" do
+    calculator.compute(order)
+  end
+
+  # Regression test for #1156
+  it "computes with a shipment object" do
+    calculator.compute(shipment)
+  end
+
+  # Regression test for #2055
+  it "computes the correct amount" do
+    expect(calculator.compute(2)).to eq(calculator.preferred_normal_amount)
+    expect(calculator.compute(6)).to eq(calculator.preferred_discount_amount)
+  end
+end

data/spec/models/spree/calculator/tiered_flat_rate_spec.rb

@@ -0,0 +1,36 @@
+require 'spec_helper'
+
+describe Spree::Calculator::TieredFlatRate, :type => :model do
+  let(:calculator) { Spree::Calculator::TieredFlatRate.new }
+
+  describe "#valid?" do
+    subject { calculator.valid? }
+    context "when tiers is a hash" do
+      context "and one of the keys is not a positive number" do
+        before { calculator.preferred_tiers = { "nope" => 20 } }
+        it { is_expected.to be false }
+      end
+    end
+  end
+
+  describe "#compute" do
+    let(:line_item) { mock_model Spree::LineItem, amount: amount }
+    before do
+      calculator.preferred_base_amount = 10
+      calculator.preferred_tiers = {
+        100 => 15,
+        200 => 20
+      }
+    end
+    subject { calculator.compute(line_item) }
+    context "when amount falls within the first tier" do
+      let(:amount) { 50 }
+      it { is_expected.to eq 10 }
+    end
+    context "when amount falls within the second tier" do
+      let(:amount) { 150 }
+      it { is_expected.to eq 15 }
+    end
+  end
+end
+

data/spec/models/spree/calculator/tiered_percent_spec.rb

@@ -0,0 +1,47 @@
+require 'spec_helper'
+
+describe Spree::Calculator::TieredPercent, :type => :model do
+  let(:calculator) { Spree::Calculator::TieredPercent.new }
+
+  describe "#valid?" do
+    subject { calculator.valid? }
+    context "when base percent is less than zero" do
+      before { calculator.preferred_base_percent = -1 }
+      it { is_expected.to be false }
+    end
+    context "when base percent is greater than 100" do
+      before { calculator.preferred_base_percent = 110 }
+      it { is_expected.to be false }
+    end
+    context "when tiers is a hash" do
+      context "and one of the keys is not a positive number" do
+        before { calculator.preferred_tiers = { "nope" => 20 } }
+        it { is_expected.to be false }
+      end
+      context "and one of the values is not a percent" do
+        before { calculator.preferred_tiers = { 10 => 110 } }
+        it { is_expected.to be false }
+      end
+    end
+  end
+
+  describe "#compute" do
+    let(:line_item) { mock_model Spree::LineItem, amount: amount }
+    before do
+      calculator.preferred_base_percent = 10
+      calculator.preferred_tiers = {
+        100 => 15,
+        200 => 20
+      }
+    end
+    subject { calculator.compute(line_item) }
+    context "when amount falls within the first tier" do
+      let(:amount) { 50 }
+      it { is_expected.to eq 5 }
+    end
+    context "when amount falls within the second tier" do
+      let(:amount) { 150 }
+      it { is_expected.to eq 22 }
+    end
+  end
+end

data/spec/models/spree/calculator_spec.rb

@@ -0,0 +1,36 @@
+require 'spec_helper'
+
+
+describe Spree::Calculator, :type => :model do
+
+  class SimpleCalculator < Spree::Calculator
+    def compute_simple_computable line_item
+      'computed'
+    end
+  end
+
+  class SimpleComputable
+  end
+
+
+  context "with computable" do
+
+    let(:calculator) { SimpleCalculator.new }
+    let(:computable) { SimpleComputable.new }
+
+    subject { SimpleCalculator.new.compute computable }
+
+    it 'calls compute method of class type' do
+      expect(subject).to eq ( 'computed' )
+    end
+
+    context 'computable does not implement right function name' do
+      let(:computable) { Spree::LineItem.new }
+
+      it 'raises an error' do
+        expect { subject }.to raise_error NotImplementedError, /Please implement \'compute_line_item\(line_item\)\' in your calculator/
+      end
+    end
+
+  end
+end

data/spec/models/spree/carton_spec.rb

@@ -0,0 +1,133 @@
+require 'spec_helper'
+
+describe Spree::Carton do
+  let(:carton) { create(:carton) }
+
+  describe "#create" do
+    subject { carton }
+
+    it { expect { subject }.to_not raise_error }
+  end
+
+  describe "#tracking_url" do
+    subject do
+      carton.tracking_url
+    end
+
+    let(:carton) { create(:carton, shipping_method: shipping_method) }
+    let(:shipping_method) do
+      create(:shipping_method, tracking_url: "https://example.com/:tracking")
+    end
+
+    context "when tracking is not present" do
+      it { is_expected.to be_nil }
+    end
+
+    context "when tracking is present" do
+      let(:carton) do
+        create(:carton, shipping_method: shipping_method, tracking: "1Z12345")
+      end
+
+      it "uses shipping method to determine url" do
+        is_expected.to eq("https://example.com/1Z12345")
+      end
+    end
+  end
+
+  describe "#to_param" do
+    subject do
+      carton.to_param
+    end
+
+    it { is_expected.to eq carton.number }
+  end
+
+  describe "#order_numbers" do
+    subject { carton.order_numbers }
+    let(:order) { carton.orders.first }
+
+    it "returns a list of the order numbers it is associated to" do
+      expect(subject).to eq [order.number]
+    end
+  end
+
+  describe "#shipment_numbers" do
+    subject { carton.shipment_numbers }
+    let(:shipment) { carton.shipments.first }
+
+    it "returns a list of the order numbers it is associated to" do
+      expect(subject).to eq [shipment.number]
+    end
+  end
+
+  describe "#order_emails" do
+    subject { carton.order_emails }
+
+    let(:carton) { create(:carton, inventory_units: [first_order.inventory_units, second_order.inventory_units].flatten) }
+    let(:first_order) { create(:order_ready_to_ship, line_items_count: 1) }
+    let(:second_order) { create(:order_ready_to_ship, line_items_count: 1) }
+    let(:email) { 'something@something.com' }
+
+    before do
+      first_order.update_attributes!(email: email)
+      second_order.update_attributes!(email: email)
+    end
+
+    it "returns a unique list of the order emails it is associated to" do
+      expect(subject).to eq [email]
+    end
+  end
+
+  describe "#manifest" do
+    subject { carton.manifest }
+
+    let(:carton) { create(:carton, inventory_units: [first_order.inventory_units, second_order.inventory_units].flatten) }
+    let(:first_order) { create(:order_ready_to_ship, line_items_count: 1) }
+    let(:first_line_item) { first_order.line_items.first }
+    let(:second_order) { create(:order_ready_to_ship, line_items_count: 1) }
+    let(:second_line_item) { second_order.line_items.first }
+
+    it "contains only the items in both the carton and order" do
+      expect(subject.map(&:line_item)).to match_array([first_line_item, second_line_item])
+    end
+  end
+
+  describe "#manifest_for_order" do
+    subject { carton.manifest_for_order(first_order) }
+
+    let(:carton) { create(:carton, inventory_units: [first_order.inventory_units, second_order.inventory_units].flatten) }
+    let(:first_order) { create(:order_ready_to_ship, line_items_count: 1) }
+    let(:first_line_item) { first_order.line_items.first }
+    let(:second_order) { create(:order_ready_to_ship, line_items_count: 1) }
+
+    it "contains only the items in both the carton and order" do
+      expect(subject.map(&:line_item)).to eq [first_line_item]
+    end
+  end 
+
+  describe "#any_exchanges?" do
+    subject { carton.any_exchanges? }
+
+    let(:carton) { create(:carton, inventory_units: [first_order.inventory_units, second_order.inventory_units].flatten) }
+    let(:first_order) { create(:order_ready_to_ship, line_items_count: 1) }
+    let(:second_order) { create(:order_ready_to_ship, line_items_count: 1) }
+
+    context "when any of the inventory has an original return item" do
+      let(:return_item) { create(:return_item) }
+      before do
+        first_order.inventory_units.first.original_return_item = return_item
+        first_order.save
+      end
+
+      it "is true" do
+        expect(subject).to be_truthy
+      end
+    end
+
+    context "when none of the inventory has an original return item" do
+      it "is false" do
+        expect(subject).to be_falsey
+      end
+    end
+  end
+end

data/spec/models/spree/classification_spec.rb

@@ -0,0 +1,93 @@
+require 'spec_helper'
+
+module Spree
+  describe Classification, :type => :model do
+    # Regression test for #3494
+    it "cannot link the same taxon to the same product more than once" do
+      product = create(:product)
+      taxon = create(:taxon)
+      add_taxon = lambda { product.taxons << taxon }
+      expect(add_taxon).not_to raise_error
+      expect(add_taxon).to raise_error(ActiveRecord::RecordInvalid)
+    end
+
+    let(:taxon_with_5_products) do
+      products = []
+      5.times do
+        products << create(:base_product)
+      end
+
+      create(:taxon, products: products)
+    end
+
+    def positions_to_be_valid(taxon)
+      positions = taxon.reload.classifications.map(&:position)
+      expect(positions).to eq((1..taxon.classifications.count).to_a)
+    end
+
+    it "has a valid fixtures" do
+      expect positions_to_be_valid(taxon_with_5_products)
+      expect(Spree::Classification.count).to eq 5
+    end
+
+    context "removing product from taxon" do
+      before :each do
+        p = taxon_with_5_products.products[1]
+        expect(p.classifications.first.position).to eq(2)
+        taxon_with_5_products.products.destroy(p)
+      end
+
+      it "resets positions" do
+        expect positions_to_be_valid(taxon_with_5_products)
+      end
+    end
+
+    context "replacing taxon's products" do
+      before :each do
+        products = taxon_with_5_products.products.to_a
+        products.pop(1)
+        taxon_with_5_products.products = products
+        taxon_with_5_products.save!
+      end
+
+      it "resets positions" do
+        expect positions_to_be_valid(taxon_with_5_products)
+      end
+    end
+
+    context "removing taxon from product" do
+      before :each do
+        p = taxon_with_5_products.products[1]
+        p.taxons.destroy(taxon_with_5_products)
+        p.save!
+      end
+
+      it "resets positions" do
+        expect positions_to_be_valid(taxon_with_5_products)
+      end
+    end
+
+    context "replacing product's taxons" do
+      before :each do
+        p = taxon_with_5_products.products[1]
+        p.taxons = []
+        p.save!
+      end
+
+      it "resets positions" do
+        expect positions_to_be_valid(taxon_with_5_products)
+      end
+    end
+
+    context "destroying classification" do
+      before :each do
+        classification = taxon_with_5_products.classifications[1]
+        classification.destroy
+      end
+
+      it "resets positions" do
+        expect positions_to_be_valid(taxon_with_5_products)
+      end
+    end
+  end
+end

data/spec/models/spree/concerns/display_money_spec.rb

@@ -0,0 +1,43 @@
+require 'spec_helper'
+
+module Spree
+
+  describe DisplayMoney do
+    let(:test_class) do
+      Class.new do
+        extend DisplayMoney
+        def total; 10.0; end
+      end
+    end
+
+    describe ".money_methods" do
+      before { test_class.money_methods :total }
+
+      context "currency is not defined" do
+        it "generates a display_method that builds a Spree::Money without options" do
+          expect(test_class.new.display_total).to eq Spree::Money.new(10.0)
+        end
+      end
+
+      context "currency is defined" do
+        before { test_class.class_eval { def currency; "USD"; end } }
+
+        it "generates a display_* method that builds a Spree::Money with currency" do
+          expect(test_class.new.display_total).to eq Spree::Money.new(10.0, currency: "USD")
+        end
+      end
+
+      context "with multiple + options" do
+        before do
+          test_class.class_eval { def amount; 20.0; end }
+          test_class.money_methods :total, amount: { no_cents: true }
+        end
+
+        it "generates a display_* method that builds a Spree::Money with the specified options" do
+          expect(test_class.new.display_total).to eq Spree::Money.new(10.0)
+          expect(test_class.new.display_amount).to eq Spree::Money.new(20.0, no_cents: true)
+        end
+      end
+    end
+  end
+end