solidus_core 1.1.0 → 1.1.1

data/spec/models/spree/order_capturing_spec.rb

@@ -0,0 +1,150 @@
+require 'spec_helper'
+
+describe Spree::OrderCapturing do
+  describe '#capture_payments' do
+    subject { Spree::OrderCapturing.new(order, payment_methods).capture_payments }
+
+    # Regression for the order.update! in the ensure block.
+    # See the comment there.
+    context "updating the order" do
+      let(:order) { create :completed_order_with_totals }
+      let(:payment_methods) { [] }
+      let!(:payment) { create(:payment, order: order, amount: order.total) }
+      let(:changes_spy) { spy('changes_spy') }
+
+      before do
+        payment.pend!
+
+        allow_any_instance_of(Spree::Order).to receive(:thingamajig) do |order|
+          changes_spy.change_callback_occured if order.changes.any?
+        end
+
+        @update_hooks = Spree::Order.update_hooks.dup
+        Spree::Order.register_update_hook :thingamajig
+      end
+
+      after do
+        Spree::Order.update_hooks = @update_hooks
+      end
+
+      it "keeps the order up to date when updating and only changes it once" do
+        subject
+        expect(changes_spy).to have_received(:change_callback_occured).once
+      end
+    end
+
+    context "payment methods specified" do
+      let!(:order) { create(:order, ship_address: create(:address)) }
+
+      let!(:product) { create(:product, price: 10.00) }
+      let!(:variant) do
+        create(:variant, price: 10, product: product, track_inventory: false, tax_category: tax_rate.tax_category)
+      end
+      let!(:shipping_method) { create(:free_shipping_method) }
+      let(:tax_rate) { create(:tax_rate, amount: 0.1, zone: create(:global_zone, name: "Some Tax Zone")) }
+      let(:secondary_total) { 10.0 }
+      let(:bogus_total) { order.total - secondary_total }
+
+      before do
+        order.contents.add(variant, 3)
+        order.update!
+        @secondary_bogus_payment = create(:payment, order: order, amount: secondary_total, payment_method: secondary_payment_method.create!(name: 'So bogus'))
+        @bogus_payment = create(:payment, order: order, amount: bogus_total)
+        order.contents.advance
+        order.complete!
+        order.reload
+      end
+
+      context "payment method ordering" do
+        let(:secondary_payment_method) { SecondaryBogusPaymentMethod }
+
+        class SecondaryBogusPaymentMethod < Spree::Gateway::Bogus; end
+
+        context "SecondaryBogusPaymentMethod payments are prioritized" do
+          let(:payment_methods) { [SecondaryBogusPaymentMethod, Spree::Gateway::Bogus] }
+
+          it "captures SecondaryBogusPaymentMethod payments first" do
+            @bogus_payment.update!(amount: bogus_total + 100)
+            subject
+            expect(@secondary_bogus_payment.reload.capture_events.sum(:amount)).to eq(10.0)
+            expect(@bogus_payment.reload.capture_events.sum(:amount)).to eq(order.total - 10.0)
+          end
+        end
+
+        context "Bogus payments are prioritized" do
+          let(:payment_methods) { [Spree::Gateway::Bogus, SecondaryBogusPaymentMethod] }
+
+          it "captures Bogus payments first" do
+            @secondary_bogus_payment.update!(amount: secondary_total + 100)
+            subject
+            expect(@bogus_payment.reload.capture_events.sum(:amount)).to eq(order.total - 10.0)
+            expect(@secondary_bogus_payment.reload.capture_events.sum(:amount)).to eq(10.0)
+          end
+        end
+
+        context "when the payment method ordering is configured" do
+          subject { Spree::OrderCapturing.new(order, payment_methods).capture_payments }
+
+          let(:payment_methods) { nil }
+
+          before do
+            allow(Spree::OrderCapturing).to receive(:sorted_payment_method_classes).and_return(
+              [SecondaryBogusPaymentMethod, Spree::Gateway::Bogus]
+            )
+          end
+
+          it "captures in the order specified" do
+            subject
+            expect(@secondary_bogus_payment.reload.capture_events.sum(:amount)).to eq(10.0)
+            expect(@bogus_payment.reload.capture_events.sum(:amount)).to eq(order.total - 10.0)
+          end
+        end
+      end
+
+      context "when a payment is not needed to capture the entire order" do
+        let(:secondary_payment_method) { SecondaryBogusPaymentMethod }
+        let(:payment_methods) { [Spree::Gateway::Bogus, SecondaryBogusPaymentMethod] }
+
+        before do
+          @bogus_payment.update!(amount: order.total)
+        end
+
+        context "when void_unused_payments is true" do
+          before { allow(Spree::OrderCapturing).to receive(:void_unused_payments).and_return(true) }
+
+          it "captures for the order and voids the unused payment" do
+            subject
+            expect(order.reload.payment_state).to eq 'paid'
+            expect(@secondary_bogus_payment.reload.state).to eq 'void'
+          end
+        end
+
+        context "when void_unused_payments is false" do
+          it "captures for the order and leaves the unused payment in a pending state" do
+            subject
+            expect(order.reload.payment_state).to eq 'paid'
+            expect(@secondary_bogus_payment.reload.state).to eq 'pending'
+          end
+        end
+      end
+
+      context "when there is an error processing a payment" do
+        let(:secondary_payment_method) { ExceptionallyBogusPaymentMethod }
+        let(:bogus_total) { order.total - 1 }
+        let(:secondary_total) { 1 }
+        let(:payment_methods) { [Spree::Gateway::Bogus, ExceptionallyBogusPaymentMethod] }
+
+        class ExceptionallyBogusPaymentMethod < Spree::Gateway::Bogus
+          def capture(*args)
+            raise ActiveMerchant::ConnectionError.new("foo", nil)
+          end
+        end
+
+        it "raises an error and leaves the order in a reasonable state" do
+          expect { subject }.to raise_error(Spree::Core::GatewayError)
+          expect(order.payments.to_a.sum(&:uncaptured_amount)).to eq 1.0
+        end
+      end
+    end
+  end
+end

data/spec/models/spree/order_contents_spec.rb

@@ -0,0 +1,307 @@
+require 'spec_helper'
+
+describe Spree::OrderContents, :type => :model do
+  let(:order) { Spree::Order.create }
+  let(:variant) { create(:variant) }
+  let!(:stock_location) { variant.stock_locations.first }
+  let(:stock_location_2) { create(:stock_location) }
+
+  subject { described_class.new(order) }
+
+  context "#add" do
+    context 'given quantity is not explicitly provided' do
+      it 'should add one line item' do
+        line_item = subject.add(variant)
+        expect(line_item.quantity).to eq(1)
+        expect(order.line_items.size).to eq(1)
+      end
+    end
+
+    context 'given a shipment' do
+      it "ensure shipment calls update_amounts instead of order calling ensure_updated_shipments" do
+        shipment = create(:shipment)
+        expect(subject.order).to_not receive(:ensure_updated_shipments)
+        expect(shipment).to receive(:update_amounts)
+        subject.add(variant, 1, shipment: shipment)
+      end
+    end
+
+    context 'not given a shipment' do
+      it "ensures updated shipments" do
+        expect(subject.order).to receive(:ensure_updated_shipments)
+        subject.add(variant)
+      end
+    end
+
+    it 'should add line item if one does not exist' do
+      line_item = subject.add(variant, 1)
+      expect(line_item.quantity).to eq(1)
+      expect(order.line_items.size).to eq(1)
+    end
+
+    it 'should update line item if one exists' do
+      subject.add(variant, 1)
+      line_item = subject.add(variant, 1)
+      expect(line_item.quantity).to eq(2)
+      expect(order.line_items.size).to eq(1)
+    end
+
+    it "should update order totals" do
+      expect(order.item_total.to_f).to eq(0.00)
+      expect(order.total.to_f).to eq(0.00)
+
+      subject.add(variant, 1)
+
+      expect(order.item_total.to_f).to eq(19.99)
+      expect(order.total.to_f).to eq(19.99)
+    end
+
+    it "should create stock location associations if provided" do
+      line_item = subject.add(variant, 3, stock_location_quantities: {stock_location.id => 1, stock_location_2.id => 2})
+      order_stock_locations = line_item.order.order_stock_locations
+      expect(order_stock_locations.count).to eq(2)
+      expect(order_stock_locations.map(&:quantity)).to eq([1, 2])
+      expect(order_stock_locations.map(&:stock_location_id)).to eq([stock_location.id, stock_location_2.id])
+    end
+
+    context "running promotions" do
+      let(:promotion) { create(:promotion, apply_automatically: true) }
+      let(:calculator) { Spree::Calculator::FlatRate.new(:preferred_amount => 10) }
+
+      shared_context "discount changes order total" do
+        before { subject.add(variant, 1) }
+        it { expect(subject.order.total).not_to eq variant.price }
+      end
+
+      context "one active order promotion" do
+        let!(:action) { Spree::Promotion::Actions::CreateAdjustment.create(promotion: promotion, calculator: calculator) }
+
+        it "creates valid discount on order" do
+          subject.add(variant, 1)
+          expect(subject.order.adjustments.to_a.sum(&:amount)).not_to eq 0
+        end
+
+        include_context "discount changes order total"
+      end
+
+      context "one active line item promotion" do
+        let!(:action) { Spree::Promotion::Actions::CreateItemAdjustments.create(promotion: promotion, calculator: calculator) }
+
+        it "creates valid discount on order" do
+          subject.add(variant, 1)
+          expect(subject.order.line_item_adjustments.to_a.sum(&:amount)).not_to eq 0
+        end
+
+        include_context "discount changes order total"
+      end
+    end
+  end
+
+  context "#remove" do
+    context "given an invalid variant" do
+      it "raises an exception" do
+        expect {
+          subject.remove(variant, 1)
+        }.to raise_error(ActiveRecord::RecordNotFound)
+      end
+    end
+
+    context 'given quantity is not explicitly provided' do
+      it 'should remove one line item' do
+        line_item = subject.add(variant, 3)
+        subject.remove(variant)
+
+        expect(line_item.reload.quantity).to eq(2)
+      end
+    end
+
+    context 'given a shipment' do
+      it "ensure shipment calls update_amounts instead of order calling ensure_updated_shipments" do
+        line_item = subject.add(variant, 1)
+        shipment = create(:shipment)
+        expect(subject.order).to_not receive(:ensure_updated_shipments)
+        expect(shipment).to receive(:update_amounts)
+        subject.remove(variant, 1, shipment: shipment)
+      end
+    end
+
+    context 'not given a shipment' do
+      it "ensures updated shipments" do
+        line_item = subject.add(variant, 1)
+        expect(subject.order).to receive(:ensure_updated_shipments)
+        subject.remove(variant)
+      end
+    end
+
+    it 'should reduce line_item quantity if quantity is less the line_item quantity' do
+      line_item = subject.add(variant, 3)
+      subject.remove(variant, 1)
+
+      expect(line_item.reload.quantity).to eq(2)
+    end
+
+    it 'should remove line_item if quantity matches line_item quantity' do
+      subject.add(variant, 1)
+      subject.remove(variant, 1)
+
+      expect(order.reload.find_line_item_by_variant(variant)).to be_nil
+    end
+
+    it "should update order totals" do
+      expect(order.item_total.to_f).to eq(0.00)
+      expect(order.total.to_f).to eq(0.00)
+
+      subject.add(variant,2)
+
+      expect(order.item_total.to_f).to eq(39.98)
+      expect(order.total.to_f).to eq(39.98)
+
+      subject.remove(variant,1)
+      expect(order.item_total.to_f).to eq(19.99)
+      expect(order.total.to_f).to eq(19.99)
+    end
+  end
+
+  context "#remove_line_item" do
+    context 'given a shipment' do
+      it "ensure shipment calls update_amounts instead of order calling ensure_updated_shipments" do
+        line_item = subject.add(variant, 1)
+        shipment = create(:shipment)
+        expect(subject.order).to_not receive(:ensure_updated_shipments)
+        expect(shipment).to receive(:update_amounts)
+        subject.remove_line_item(line_item, shipment: shipment)
+      end
+    end
+
+    context 'not given a shipment' do
+      it "ensures updated shipments" do
+        line_item = subject.add(variant, 1)
+        expect(subject.order).to receive(:ensure_updated_shipments)
+        subject.remove_line_item(line_item)
+      end
+    end
+
+    it 'should remove line_item' do
+      line_item = subject.add(variant, 1)
+      subject.remove_line_item(line_item)
+
+      expect(order.reload.line_items).to_not include(line_item)
+    end
+
+    it "should update order totals" do
+      expect(order.item_total.to_f).to eq(0.00)
+      expect(order.total.to_f).to eq(0.00)
+
+      line_item = subject.add(variant,2)
+
+      expect(order.item_total.to_f).to eq(39.98)
+      expect(order.total.to_f).to eq(39.98)
+
+      subject.remove_line_item(line_item)
+      expect(order.item_total.to_f).to eq(0.00)
+      expect(order.total.to_f).to eq(0.00)
+    end
+  end
+
+
+  context "update cart" do
+    let!(:shirt) { subject.add variant, 1 }
+
+    let(:params) do
+      { line_items_attributes: {
+        "0" => { id: shirt.id, quantity: 3 }
+      } }
+    end
+
+    it "changes item quantity" do
+      subject.update_cart params
+      expect(shirt.reload.quantity).to eq 3
+    end
+
+    it "updates order totals" do
+      expect {
+        subject.update_cart params
+      }.to change { subject.order.total }
+    end
+
+    context "submits item quantity 0" do
+      let(:params) do
+        { line_items_attributes: {
+          "0" => { id: shirt.id, quantity: 0 },
+        } }
+      end
+
+      it "removes item from order" do
+        expect {
+          subject.update_cart params
+        }.to change { subject.order.line_items.count }
+      end
+    end
+
+    it "ensures updated shipments" do
+      expect(subject.order).to receive(:ensure_updated_shipments)
+      subject.update_cart params
+    end
+  end
+
+  context "completed order" do
+    let(:order) { Spree::Order.create! state: 'complete', completed_at: Time.now }
+
+    before { order.shipments.create! stock_location_id: variant.stock_location_ids.first }
+
+    it "updates order payment state" do
+      expect {
+        subject.add variant
+      }.to change { order.payment_state }
+
+      expect {
+        subject.remove variant
+      }.to change { order.payment_state }
+    end
+  end
+
+  describe "#approve" do
+    context 'when a name is supplied' do
+      it 'approves the order' do
+        order.contents.approve(name: 'Jordan')
+        expect(order.approver).to be_nil
+        expect(order.approver_name).to eq('Jordan')
+        expect(order.approved_at).to be_present
+        expect(order.approved?).to be_truthy
+      end
+    end
+
+    context 'when a user is supplied' do
+      let(:user) { create(:user) }
+
+      it 'approves the order' do
+        order.contents.approve(user: user)
+        expect(order.approver).to eq(user)
+        expect(order.approver_name).to be_nil
+        expect(order.approved_at).to be_present
+        expect(order.approved?).to be_truthy
+      end
+    end
+
+    context 'when a user and a name are supplied' do
+      let(:user) { create(:user) }
+
+      it 'approves the order' do
+        order.contents.approve(user: user, name: 'Jordan')
+        expect(order.approver).to eq(user)
+        expect(order.approver_name).to eq('Jordan')
+        expect(order.approved_at).to be_present
+        expect(order.approved?).to be_truthy
+      end
+    end
+
+    context 'when neither a user nor a name are supplied' do
+      it 'raises' do
+        expect {
+          order.contents.approve
+        }.to raise_error(ArgumentError, 'user or name must be specified')
+      end
+    end
+  end
+
+end