solidus_core 1.1.0 → 1.1.1

data/spec/models/spree/order/state_machine_spec.rb

@@ -0,0 +1,209 @@
+require 'spec_helper'
+
+describe Spree::Order, :type => :model do
+  let(:order) { Spree::Order.new }
+  before do
+    # Ensure state machine has been re-defined correctly
+    Spree::Order.define_state_machine!
+    # We don't care about this validation here
+    allow(order).to receive(:require_email)
+  end
+
+  context "#next!" do
+    context "when current state is confirm" do
+      before do
+        order.state = "confirm"
+        order.run_callbacks(:create)
+        allow(order).to receive_messages :payment_required? => true
+        allow(order).to receive_messages :process_payments! => true
+        allow(order).to receive_messages :ensure_available_shipping_rates => true
+      end
+
+      context "when payment processing succeeds" do
+        before do
+          order.payments << FactoryGirl.create(:payment, state: 'checkout', order: order)
+          allow(order).to receive_messages process_payments: true
+        end
+
+        it "should finalize order when transitioning to complete state" do
+          expect(order).to receive(:finalize!)
+          order.complete!
+        end
+
+        context "when credit card processing fails" do
+          before { allow(order).to receive_messages :process_payments! => false }
+
+          it "should not complete the order" do
+             order.next
+             expect(order.state).to eq("confirm")
+           end
+        end
+      end
+
+      context "when payment processing fails" do
+        before { allow(order).to receive_messages :process_payments! => false }
+
+        it "cannot transition to complete" do
+         order.next
+         expect(order.state).to eq("confirm")
+        end
+      end
+    end
+
+    context "when current state is delivery" do
+      before do
+        allow(order).to receive_messages :payment_required? => true
+        allow(order).to receive :apply_free_shipping_promotions
+        order.state = "delivery"
+      end
+
+      it "adjusts tax rates when transitioning to delivery" do
+        # Once for the line items
+        expect(Spree::TaxRate).to receive(:adjust).once
+        allow(order).to receive :set_shipments_cost
+        order.next!
+      end
+
+      it "adjusts tax rates twice if there are any shipments" do
+        # Once for the line items, once for the shipments
+        order.shipments.build
+        expect(Spree::TaxRate).to receive(:adjust).twice
+        allow(order).to receive :set_shipments_cost
+        order.next!
+      end
+    end
+  end
+
+  context "#can_cancel?" do
+    states = [:pending, :backorder, :ready]
+
+    states.each do |shipment_state|
+      it "should be true if shipment_state is #{shipment_state}" do
+        allow(order).to receive_messages :completed? => true
+        order.shipment_state = shipment_state
+        expect(order.can_cancel?).to be true
+      end
+    end
+
+    (Spree::Shipment.state_machine.states.keys - states).each do |shipment_state|
+      it "should be false if shipment_state is #{shipment_state}" do
+        allow(order).to receive_messages :completed? => true
+        order.shipment_state = shipment_state
+        expect(order.can_cancel?).to be false
+      end
+    end
+
+  end
+
+  context "#cancel" do
+    let!(:variant) { stub_model(Spree::Variant) }
+    let!(:inventory_units) { [stub_model(Spree::InventoryUnit, :variant => variant),
+                              stub_model(Spree::InventoryUnit, :variant => variant) ]}
+    let!(:shipment) do
+      shipment = stub_model(Spree::Shipment)
+      allow(shipment).to receive_messages :inventory_units => inventory_units, :order => order
+      allow(order).to receive_messages :shipments => [shipment]
+      shipment
+    end
+
+    before do
+
+      2.times do
+        create(:line_item, :order => order, price: 10)
+      end
+
+      allow(order.line_items).to receive_messages :find_by_variant_id => order.line_items.first
+
+      allow(order).to receive_messages :completed? => true
+      allow(order).to receive_messages :allow_cancel? => true
+
+      shipments = [shipment]
+      allow(order).to receive_messages :shipments => shipments
+      allow(shipments).to receive_messages :states => []
+      allow(shipments).to receive_messages :ready => []
+      allow(shipments).to receive_messages :pending => []
+      allow(shipments).to receive_messages :shipped => []
+
+      allow_any_instance_of(Spree::OrderUpdater).to receive(:update_adjustment_total) { 10 }
+    end
+
+    it "should send a cancel email" do
+
+      # Stub methods that cause side-effects in this test
+      allow(shipment).to receive(:cancel!)
+      allow(order).to receive :restock_items!
+      expect(Spree::OrderMailer).to receive(:cancel_email).with(order).and_return(mail_message = double)
+      expect(mail_message).to receive :deliver_later
+      order.cancel!
+    end
+
+    context "restocking inventory" do
+      before do
+        allow(shipment).to receive(:ensure_correct_adjustment)
+        allow(shipment).to receive(:update_order)
+        allow(Spree::OrderMailer).to receive(:cancel_email).and_return(mail_message = double)
+        allow(mail_message).to receive :deliver_later
+
+      end
+    end
+
+    context "resets payment state" do
+
+      let(:payment) { create(:payment, amount: order.total) }
+
+      before do
+        # TODO: This is ugly :(
+        # Stubs methods that cause unwanted side effects in this test
+        allow(Spree::OrderMailer).to receive(:cancel_email).and_return(mail_message = double)
+        allow(mail_message).to receive :deliver_later
+        allow(order).to receive :restock_items!
+        allow(shipment).to receive(:cancel!)
+        allow(payment).to receive(:cancel!)
+        allow(order).to receive_message_chain(:payments, :valid, :size).and_return(1)
+        allow(order).to receive_message_chain(:payments, :completed).and_return([payment])
+        allow(order).to receive_message_chain(:payments, :completed, :includes).and_return([payment])
+        allow(order).to receive_message_chain(:payments, :last).and_return(payment)
+        allow(order).to receive_message_chain(:payments, :store_credits, :pending).and_return([payment])
+        allow(order).to receive(:refund_total).and_return(0)
+      end
+
+      context "without shipped items" do
+        it "should set payment state to 'void'" do
+          expect { order.cancel! }.to change{ order.reload.payment_state }.to("void")
+        end
+      end
+
+      context "with shipped items" do
+        before do
+          allow(order).to receive_messages shipment_state: 'partial'
+          allow(order).to receive_messages outstanding_balance?: false
+          allow(order).to receive_messages payment_state: "paid"
+        end
+
+        it "should not alter the payment state" do
+          order.cancel!
+          expect(order.payment_state).to eql "paid"
+        end
+      end
+
+      context "with payments" do
+        let(:payment) { create(:payment) }
+
+        it "should automatically refund all payments" do
+          expect(payment).to receive(:cancel!)
+          order.cancel!
+        end
+      end
+    end
+  end
+
+
+  # Another regression test for #729
+  context "#resume" do
+    before do
+      allow(order).to receive_messages email: "user@spreecommerce.com"
+      allow(order).to receive_messages state: "canceled"
+      allow(order).to receive_messages allow_resume?: true
+    end
+  end
+end

data/spec/models/spree/order/tax_spec.rb

@@ -0,0 +1,84 @@
+require 'spec_helper'
+
+module Spree
+  describe Spree::Order, :type => :model do
+    let(:order) { stub_model(Spree::Order) }
+
+    context "#tax_zone" do
+      let(:bill_address) { create :address }
+      let(:ship_address) { create :address }
+      let(:order) { Spree::Order.create(:ship_address => ship_address, :bill_address => bill_address) }
+      let(:zone) { create :zone }
+
+      context "when no zones exist" do
+        it "should return nil" do
+          expect(order.tax_zone).to be_nil
+        end
+      end
+
+      context "when :tax_using_ship_address => true" do
+        before { Spree::Config.set(:tax_using_ship_address => true) }
+
+        it "should calculate using ship_address" do
+          expect(Spree::Zone).to receive(:match).at_least(:once).with(ship_address)
+          expect(Spree::Zone).not_to receive(:match).with(bill_address)
+          order.tax_zone
+        end
+      end
+
+      context "when :tax_using_ship_address => false" do
+        before { Spree::Config.set(:tax_using_ship_address => false) }
+
+        it "should calculate using bill_address" do
+          expect(Spree::Zone).to receive(:match).at_least(:once).with(bill_address)
+          expect(Spree::Zone).not_to receive(:match).with(ship_address)
+          order.tax_zone
+        end
+      end
+
+      context "when there is a default tax zone" do
+        before do
+          @default_zone = create(:zone, :name => "foo_zone")
+          allow(Spree::Zone).to receive_messages :default_tax => @default_zone
+        end
+
+        context "when there is a matching zone" do
+          before { allow(Spree::Zone).to receive_messages(:match => zone) }
+
+          it "should return the matching zone" do
+            expect(order.tax_zone).to eq(zone)
+          end
+        end
+
+        context "when there is no matching zone" do
+          before { allow(Spree::Zone).to receive_messages(:match => nil) }
+
+          it "should return the default tax zone" do
+            expect(order.tax_zone).to eq(@default_zone)
+          end
+        end
+      end
+
+      context "when no default tax zone" do
+        before { allow(Spree::Zone).to receive_messages :default_tax => nil }
+
+        context "when there is a matching zone" do
+          before { allow(Spree::Zone).to receive_messages(:match => zone) }
+
+          it "should return the matching zone" do
+            expect(order.tax_zone).to eq(zone)
+          end
+        end
+
+        context "when there is no matching zone" do
+          before { allow(Spree::Zone).to receive_messages(:match => nil) }
+
+          it "should return nil" do
+            expect(order.tax_zone).to be_nil
+          end
+        end
+      end
+    end
+
+  end
+end

data/spec/models/spree/order/totals_spec.rb

@@ -0,0 +1,24 @@
+require 'spec_helper'
+
+module Spree
+  describe Order, :type => :model do
+    let(:order) { Order.create }
+    let(:shirt) { create(:variant) }
+
+    context "adds item to cart and activates promo" do
+      let(:promotion) { Promotion.create name: 'Huhu', apply_automatically: true }
+      let(:calculator) { Calculator::FlatPercentItemTotal.new(:preferred_flat_percent => 10) }
+      let!(:action) { Promotion::Actions::CreateAdjustment.create(promotion: promotion, calculator: calculator) }
+
+      before { order.contents.add(shirt, 1) }
+
+      context "item quantity changes" do
+        it "recalculates order adjustments" do
+          expect {
+            order.contents.add(shirt, 3)
+          }.to change { order.adjustments.eligible.pluck(:amount) }
+        end
+      end
+    end
+  end
+end

data/spec/models/spree/order/updating_spec.rb

@@ -0,0 +1,18 @@
+require 'spec_helper'
+
+describe Spree::Order, :type => :model do
+  let(:order) { stub_model(Spree::Order) }
+
+  context "#update!" do
+    let(:line_items) { [mock_model(Spree::LineItem, :amount => 5) ]}
+
+    context "when there are update hooks" do
+      before { Spree::Order.register_update_hook :foo }
+      after { Spree::Order.update_hooks.clear }
+      it "should call each of the update hooks" do
+        expect(order).to receive :foo
+        order.update!
+      end
+    end
+  end
+end

data/spec/models/spree/order/validations_spec.rb

@@ -0,0 +1,15 @@
+require 'spec_helper'
+
+module Spree
+  describe Spree::Order, :type => :model do
+    context "validations" do
+      # Regression test for #2214
+      it "does not return two error messages when email is blank" do
+        order = Spree::Order.new
+        allow(order).to receive_messages(:require_email => true)
+        order.valid?
+        expect(order.errors[:email]).to eq(["can't be blank"])
+      end
+    end
+  end
+end

data/spec/models/spree/order_cancellations_spec.rb

@@ -0,0 +1,120 @@
+require 'spec_helper'
+
+describe Spree::OrderCancellations do
+  describe "#short_ship" do
+    subject { Spree::OrderCancellations.new(order).short_ship([inventory_unit]) }
+
+    let(:order) { create(:order_ready_to_ship, line_items_count: 1) }
+    let(:inventory_unit) { order.inventory_units.first }
+    let(:shipment) { inventory_unit.shipment }
+
+    it "creates a UnitCancel record" do
+      expect { subject }.to change { Spree::UnitCancel.count }.by(1)
+
+      unit_cancel = Spree::UnitCancel.last
+      expect(unit_cancel.inventory_unit).to eq inventory_unit
+      expect(unit_cancel.reason).to eq Spree::UnitCancel::SHORT_SHIP
+    end
+
+    it "cancels the inventory unit" do
+      expect { subject }.to change { inventory_unit.state }.to "canceled"
+    end
+
+    it "updates the shipment.state" do
+      expect { subject }.to change { shipment.reload.state }.from('ready').to('shipped')
+    end
+
+    it "updates the order.shipment_state" do
+      expect { subject }.to change { order.shipment_state }.from('ready').to('shipped')
+    end
+
+    it "adjusts the order" do
+      expect { subject }.to change { order.total }.by(-10.0)
+    end
+
+    it "sends a cancellation email" do
+      mail_double = double
+      expect(Spree::OrderMailer).to receive(:inventory_cancellation_email).with(order, [inventory_unit]).and_return(mail_double)
+      expect(mail_double).to receive(:deliver_later)
+      subject
+    end
+
+    context "when send_cancellation_mailer is false" do
+      subject { Spree::OrderCancellations.new(order).short_ship([inventory_unit]) }
+
+      before do
+        @original_send_boolean = Spree::OrderCancellations.send_cancellation_mailer
+        Spree::OrderCancellations.send_cancellation_mailer = false
+      end
+
+      after { Spree::OrderCancellations.send_cancellation_mailer = @original_send_boolean }
+
+      it "does not send a cancellation email" do
+        expect(Spree::OrderMailer).not_to receive(:inventory_cancellation_email)
+        subject
+      end
+    end
+
+    context "with a who" do
+      subject { order.cancellations.short_ship([inventory_unit], whodunnit: 'some automated system') }
+
+      let(:user) { order.user }
+
+      it "sets the user on the UnitCancel" do
+        expect { subject }.to change { Spree::UnitCancel.count }.by(1)
+        expect(Spree::UnitCancel.last.created_by).to eq("some automated system")
+      end
+    end
+
+    context "when rounding is required" do
+      let(:order) { create(:order_ready_to_ship, line_items_count: 1, line_items_price: 0.83) }
+      let(:line_item) { order.line_items.first }
+      let(:inventory_unit_1) { line_item.inventory_units[0] }
+      let(:inventory_unit_2) { line_item.inventory_units[1] }
+
+      before do
+        order.contents.add(line_item.variant)
+        line_item.reload
+
+        # make the total $1.67 so it divides unevenly
+        Spree::Adjustment.tax.create!(
+          order: order,
+          adjustable: line_item,
+          amount: 0.01,
+          label: 'some fake tax',
+          finalized: true
+        )
+        order.update!
+      end
+
+      it "generates the correct total amount" do
+        order.cancellations.short_ship([inventory_unit_1])
+        order.cancellations.short_ship([inventory_unit_2])
+        expect(line_item.adjustments.non_tax.sum(:amount)).to eq -1.67
+        expect(line_item.total).to eq 0
+      end
+    end
+
+    describe 'short_ship_tax_notifier' do
+      context 'when present' do
+        let(:short_ship_tax_notifier) { double }
+
+        before do
+          @old_notifier = Spree::OrderCancellations.short_ship_tax_notifier
+          Spree::OrderCancellations.short_ship_tax_notifier = short_ship_tax_notifier
+        end
+        after do
+          Spree::OrderCancellations.short_ship_tax_notifier = @old_notifier
+        end
+
+        it 'calls the short_ship_tax_notifier' do
+          expect(short_ship_tax_notifier).to receive(:call) do |unit_cancels|
+            expect(unit_cancels.map(&:inventory_unit)).to match_array([inventory_unit])
+          end
+
+          order.cancellations.short_ship([inventory_unit])
+        end
+      end
+    end
+  end
+end