solidus_core 1.1.0 → 1.1.1

data/spec/models/spree/promotion_handler/free_shipping_spec.rb

@@ -0,0 +1,47 @@
+require 'spec_helper'
+
+module Spree
+  module PromotionHandler
+    describe FreeShipping, type: :model do
+      let(:order) { create(:order) }
+      let(:shipment) { create(:shipment, order: order ) }
+
+      let(:promotion) { Promotion.create!(name: "Free Shipping") }
+      let(:calculator) { Calculator::FlatPercentItemTotal.new(preferred_flat_percent: 10) }
+      let!(:action) { Promotion::Actions::FreeShipping.create(promotion: promotion) }
+
+      subject { Spree::PromotionHandler::FreeShipping.new(order) }
+
+      context "activates in Shipment level" do
+        it "creates the adjustment" do
+          expect { subject.activate }.to change { shipment.adjustments.count }.by(1)
+        end
+      end
+
+      context "if promo has a code" do
+        let!(:promotion_code) { create(:promotion_code, promotion: promotion) }
+
+        it "does adjust the shipment when applied to order" do
+          pending "broken by 2-2-dev merge"
+          order.order_promotions.create!(promotion: promotion, promotion_code: promotion_code)
+
+          expect { subject.activate }.to change { shipment.adjustments.count }
+        end
+
+        it "does not adjust the shipment when not applied to order" do
+          expect { subject.activate }.to_not change { shipment.adjustments.count }
+        end
+      end
+
+      context "if promo has a path" do
+        before do
+          promotion.update_column(:path, "path")
+        end
+
+        it "does not adjust the shipment" do
+          expect { subject.activate }.to_not change { shipment.adjustments.count }
+        end
+      end
+    end
+  end
+end

data/spec/models/spree/promotion_handler/page_spec.rb

@@ -0,0 +1,44 @@
+require 'spec_helper'
+
+module Spree
+  module PromotionHandler
+    describe Page, :type => :model do
+      let(:order) { create(:order_with_line_items, :line_items_count => 1) }
+
+      let(:promotion) { Promotion.create(name: "10% off", :path => '10off') }
+      before do
+        calculator = Calculator::FlatPercentItemTotal.new(preferred_flat_percent: 10)
+        action = Promotion::Actions::CreateItemAdjustments.create(:calculator => calculator)
+        promotion.actions << action
+      end
+
+      it "activates at the right path" do
+        expect(order.line_item_adjustments.count).to eq(0)
+        Spree::PromotionHandler::Page.new(order, '10off').activate
+        expect(order.line_item_adjustments.count).to eq(1)
+      end
+
+      context "when promotion is expired" do
+        before do
+          promotion.update_columns(
+            :starts_at => 1.week.ago,
+            :expires_at => 1.day.ago
+          )
+        end
+
+        it "is not activated" do
+          expect(order.line_item_adjustments.count).to eq(0)
+          Spree::PromotionHandler::Page.new(order, '10off').activate
+          expect(order.line_item_adjustments.count).to eq(0)
+        end
+      end
+
+      it "does not activate at the wrong path" do
+        expect(order.line_item_adjustments.count).to eq(0)
+        Spree::PromotionHandler::Page.new(order, 'wrongpath').activate
+        expect(order.line_item_adjustments.count).to eq(0)
+      end
+    end
+  end
+end
+

data/spec/models/spree/promotion_rule_spec.rb

@@ -0,0 +1,28 @@
+require 'spec_helper'
+
+module Spree
+  describe Spree::PromotionRule, type: :model do
+
+    class BadTestRule < Spree::PromotionRule; end
+
+    class TestRule < Spree::PromotionRule
+      def eligible?(promotable, options = {})
+        true
+      end
+    end
+
+    it "forces developer to implement eligible? method" do
+      expect { BadTestRule.new.eligible?("promotable") }.to raise_error NotImplementedError
+    end
+
+    it "validates unique rules for a promotion" do
+      p1 = TestRule.new
+      p1.promotion_id = 1
+      p1.save
+
+      p2 = TestRule.new
+      p2.promotion_id = 1
+      expect(p2).not_to be_valid
+    end
+  end
+end

data/spec/models/spree/promotion_spec.rb

@@ -0,0 +1,776 @@
+require 'spec_helper'
+
+describe Spree::Promotion, :type => :model do
+  let(:promotion) { Spree::Promotion.new }
+
+  describe "validations" do
+    before :each do
+      @valid_promotion = Spree::Promotion.new :name => "A promotion"
+    end
+
+    it "valid_promotion is valid" do
+      expect(@valid_promotion).to be_valid
+    end
+
+    it "validates usage limit" do
+      @valid_promotion.usage_limit = -1
+      expect(@valid_promotion).not_to be_valid
+
+      @valid_promotion.usage_limit = 100
+      expect(@valid_promotion).to be_valid
+    end
+
+    it "validates name" do
+      @valid_promotion.name = nil
+      expect(@valid_promotion).not_to be_valid
+    end
+  end
+
+  describe ".applied" do
+    it "scopes promotions that have been applied to an order only" do
+      promotion = Spree::Promotion.create! name: "test"
+      expect(Spree::Promotion.applied).to be_empty
+
+      promotion.orders << create(:order)
+      expect(Spree::Promotion.applied.first).to eq promotion
+    end
+  end
+
+  describe ".advertised" do
+    let(:promotion) { create(:promotion) }
+    let(:advertised_promotion) { create(:promotion, :advertise => true) }
+
+    it "only shows advertised promotions" do
+      advertised = Spree::Promotion.advertised
+      expect(advertised).to include(advertised_promotion)
+      expect(advertised).not_to include(promotion)
+    end
+  end
+
+  describe "#apply_automatically" do
+    subject { build(:promotion) }
+
+    it "defaults to false" do
+      expect(subject.apply_automatically).to eq(false)
+    end
+
+    context "when set to true" do
+      before { subject.apply_automatically = true }
+
+      it "should remain valid" do
+        expect(subject).to be_valid
+      end
+
+      it "invalidates the promotion when it has a code" do
+        subject.codes.build(value: "foo")
+        expect(subject).to_not be_valid
+        expect(subject.errors).to include(:apply_automatically)
+      end
+
+      it "invalidates the promotion when it has a path" do
+        subject.path = "foo"
+        expect(subject).to_not be_valid
+        expect(subject.errors).to include(:apply_automatically)
+      end
+    end
+  end
+
+  describe "#save" do
+    let(:promotion) { Spree::Promotion.create(:name => "delete me") }
+
+    before(:each) do
+      promotion.actions << Spree::Promotion::Actions::CreateAdjustment.new
+      promotion.rules << Spree::Promotion::Rules::FirstOrder.new
+      promotion.save!
+    end
+
+    it "should deeply autosave records and preferences" do
+      promotion.actions[0].calculator.preferred_flat_percent = 10
+      promotion.save!
+      expect(Spree::Calculator.first.preferred_flat_percent).to eq(10)
+    end
+  end
+
+  describe "#activate" do
+    let(:promotion) { create(:promotion) }
+
+    before do
+      @action1 = Spree::Promotion::Actions::CreateAdjustment.create!
+      @action2 = Spree::Promotion::Actions::CreateAdjustment.create!
+      allow(@action1).to receive_messages perform: true
+      allow(@action2).to receive_messages perform: true
+
+      promotion.promotion_actions = [@action1, @action2]
+      promotion.created_at = 2.days.ago
+
+      @user = create(:user)
+      @order = create(:order, user: @user, created_at: DateTime.now)
+      @payload = { :order => @order, :user => @user }
+    end
+
+    it "should check path if present" do
+      promotion.path = 'content/cvv'
+      @payload[:path] = 'content/cvv'
+      expect(@action1).to receive(:perform).with(hash_including(@payload))
+      expect(@action2).to receive(:perform).with(hash_including(@payload))
+      promotion.activate(@payload)
+    end
+
+    it "does not perform actions against an order in a finalized state" do
+      expect(@action1).not_to receive(:perform)
+
+      @order.state = 'complete'
+      promotion.activate(@payload)
+
+      @order.state = 'awaiting_return'
+      promotion.activate(@payload)
+
+      @order.state = 'returned'
+      promotion.activate(@payload)
+    end
+
+    it "does activate if newer then order" do
+      expect(@action1).to receive(:perform).with(hash_including(@payload))
+      promotion.created_at = DateTime.now + 2
+      expect(promotion.activate(@payload)).to be true
+    end
+
+    context "keeps track of the orders" do
+      context "when activated" do
+        it "assigns the order" do
+          expect(promotion.orders).to be_empty
+          expect(promotion.activate(@payload)).to be true
+          expect(promotion.orders.first).to eql @order
+        end
+      end
+      context "when not activated" do
+        it "will not assign the order" do
+          @order.state = 'complete'
+          expect(promotion.orders).to be_empty
+          expect(promotion.activate(@payload)).to be_falsey
+          expect(promotion.orders).to be_empty
+        end
+      end
+      context "when the order is already associated" do
+        before do
+          expect(promotion.orders).to be_empty
+          expect(promotion.activate(@payload)).to be true
+          expect(promotion.orders.to_a).to eql [@order]
+        end
+
+        it "will not assign the order again" do
+          expect(promotion.activate(@payload)).to be true
+          expect(promotion.orders.reload.to_a).to eql [@order]
+        end
+      end
+
+    end
+
+    context "when there is a code" do
+      let(:promotion_code) { create(:promotion_code) }
+      let(:promotion) { promotion_code.promotion }
+
+      it "assigns the code" do
+        expect(promotion.activate(order: @order, promotion_code: promotion_code)).to be true
+        expect(promotion.order_promotions.map(&:promotion_code)).to eq [promotion_code]
+      end
+    end
+  end
+
+  describe "#usage_limit_exceeded?" do
+    subject { promotion.usage_limit_exceeded? }
+
+    shared_examples "it should" do
+      context "when there is a usage limit" do
+        context "and the limit is not exceeded" do
+          let(:usage_limit) { 10 }
+          it { is_expected.to be_falsy }
+        end
+        context "and the limit is exceeded" do
+          let(:usage_limit) { 1 }
+          context "on a different order" do
+            before do
+              FactoryGirl.create(
+                :completed_order_with_promotion,
+                promotion: promotion
+              )
+              promotion.actions.first.adjustments.update_all(eligible: true)
+            end
+            it { is_expected.to be_truthy }
+          end
+          context "on the same order" do
+            it { is_expected.to be_falsy }
+          end
+        end
+      end
+      context "when there is no usage limit" do
+        let(:usage_limit) { nil }
+        it { is_expected.to be_falsy }
+      end
+    end
+
+    context "with an order-level adjustment" do
+      let(:promotion) do
+        FactoryGirl.create(
+          :promotion,
+          :with_order_adjustment,
+          code: "discount",
+          usage_limit: usage_limit
+        )
+      end
+      let(:promotable) do
+        FactoryGirl.create(
+          :completed_order_with_promotion,
+          promotion: promotion
+        )
+      end
+      it_behaves_like "it should"
+    end
+
+    context "with an item-level adjustment" do
+      let(:promotion) do
+        FactoryGirl.create(
+          :promotion,
+          :with_line_item_adjustment,
+          code: "discount",
+          usage_limit: usage_limit
+        )
+      end
+      before do
+        promotion.actions.first.perform({
+          order: order,
+          promotion: promotion,
+          promotion_code: promotion.codes.first
+        })
+      end
+      context "when there are multiple line items" do
+        let(:order) { FactoryGirl.create(:order_with_line_items, line_items_count: 2) }
+        describe "the first item" do
+          let(:promotable) { order.line_items.first }
+          it_behaves_like "it should"
+        end
+        describe "the second item" do
+          let(:promotable) { order.line_items.last }
+          it_behaves_like "it should"
+        end
+      end
+      context "when there is a single line item" do
+        let(:order) { FactoryGirl.create(:order_with_line_items) }
+        let(:promotable) { order.line_items.first }
+        it_behaves_like "it should"
+      end
+    end
+  end
+
+  describe "#usage_count" do
+    let(:promotion) do
+      FactoryGirl.create(
+        :promotion,
+        :with_order_adjustment,
+        code: "discount"
+      )
+    end
+
+    subject { promotion.usage_count }
+
+    context "when the code is applied to a non-complete order" do
+      let(:order) { FactoryGirl.create(:order_with_line_items) }
+      before { promotion.activate(order: order, promotion_code: promotion.codes.first) }
+      it { is_expected.to eq 0 }
+    end
+    context "when the code is applied to a complete order" do
+      let!(:order) do
+        FactoryGirl.create(
+          :completed_order_with_promotion,
+          promotion: promotion
+        )
+      end
+      context "and the promo is eligible" do
+        it { is_expected.to eq 1 }
+      end
+      context "and the promo is ineligible" do
+        before { order.adjustments.promotion.update_all(eligible: false) }
+        it { is_expected.to eq 0 }
+      end
+    end
+  end
+
+  context "#expired" do
+    it "should not be exipired" do
+      expect(promotion).not_to be_expired
+    end
+
+    it "should be expired if it hasn't started yet" do
+      promotion.starts_at = Time.now + 1.day
+      expect(promotion).to be_expired
+    end
+
+    it "should be expired if it has already ended" do
+      promotion.expires_at = Time.now - 1.day
+      expect(promotion).to be_expired
+    end
+
+    it "should not be expired if it has started already" do
+      promotion.starts_at = Time.now - 1.day
+      expect(promotion).not_to be_expired
+    end
+
+    it "should not be expired if it has not ended yet" do
+      promotion.expires_at = Time.now + 1.day
+      expect(promotion).not_to be_expired
+    end
+
+    it "should not be expired if current time is within starts_at and expires_at range" do
+      promotion.starts_at = Time.now - 1.day
+      promotion.expires_at = Time.now + 1.day
+      expect(promotion).not_to be_expired
+    end
+  end
+
+  context "#active" do
+    it "should be active" do
+      expect(promotion.active?).to eq(true)
+    end
+
+    it "should not be active if it hasn't started yet" do
+      promotion.starts_at = Time.now + 1.day
+      expect(promotion.active?).to eq(false)
+    end
+
+    it "should not be active if it has already ended" do
+      promotion.expires_at = Time.now - 1.day
+      expect(promotion.active?).to eq(false)
+    end
+
+    it "should be active if it has started already" do
+      promotion.starts_at = Time.now - 1.day
+      expect(promotion.active?).to eq(true)
+    end
+
+    it "should be active if it has not ended yet" do
+      promotion.expires_at = Time.now + 1.day
+      expect(promotion.active?).to eq(true)
+    end
+
+    it "should be active if current time is within starts_at and expires_at range" do
+      promotion.starts_at = Time.now - 1.day
+      promotion.expires_at = Time.now + 1.day
+      expect(promotion.active?).to eq(true)
+    end
+
+    it "should be active if there are no start and end times set" do
+      promotion.starts_at = nil
+      promotion.expires_at = nil
+      expect(promotion.active?).to eq(true)
+    end
+  end
+
+  context "#usage_count" do
+    let!(:promotion) do
+      create(
+        :promotion,
+        name: "Foo",
+        code: "XXX",
+      )
+    end
+
+    let!(:action) do
+      calculator = Spree::Calculator::FlatRate.new
+      action_params = { :promotion => promotion, :calculator => calculator }
+      action = Spree::Promotion::Actions::CreateAdjustment.create(action_params)
+      promotion.actions << action
+      action
+    end
+
+    let!(:adjustment) do
+      order = create(:order)
+      Spree::Adjustment.create!(
+        order:      order,
+        adjustable: order,
+        source:     action,
+        promotion_code: promotion.codes.first,
+        amount:     10,
+        label:      'Promotional adjustment'
+      )
+    end
+
+    it "counts eligible adjustments" do
+      adjustment.update_column(:eligible, true)
+      expect(promotion.usage_count).to eq(0)
+    end
+
+    # Regression test for #4112
+    it "does not count ineligible adjustments" do
+      adjustment.update_column(:eligible, false)
+      expect(promotion.usage_count).to eq(0)
+    end
+  end
+
+  context "#products" do
+    let(:promotion) { create(:promotion) }
+
+    context "when it has product rules with products associated" do
+      let(:promotion_rule) { Spree::Promotion::Rules::Product.new }
+
+      before do
+        promotion_rule.promotion = promotion
+        promotion_rule.products << create(:product)
+        promotion_rule.save
+      end
+
+      it "should have products" do
+        expect(promotion.reload.products.size).to eq(1)
+      end
+    end
+
+    context "when there's no product rule associated" do
+      it "should not have products but still return an empty array" do
+        expect(promotion.products).to be_blank
+      end
+    end
+  end
+
+  context "#eligible?" do
+    subject do
+      promotion.eligible?(promotable)
+    end
+
+    let(:promotable) { create :order }
+
+    it { is_expected.to be true }
+
+    context "when promotion is expired" do
+      before { promotion.expires_at = Time.now - 10.days }
+      it { is_expected.to be false }
+    end
+
+    context "when the promotion's usage limit is exceeded" do
+      let(:order) { FactoryGirl.create(:completed_order_with_promotion, promotion: promotion) }
+      let(:promotion) { FactoryGirl.create(:promotion, :with_order_adjustment) }
+
+      before do
+        FactoryGirl.create(
+          :completed_order_with_promotion,
+          promotion: promotion
+        )
+        promotion.usage_limit = 1
+      end
+
+      it "returns false" do
+        expect(promotion.eligible?(promotable)).to eq(false)
+      end
+    end
+
+    context "when the promotion code's usage limit is exceeded" do
+      let(:order) { FactoryGirl.create(:completed_order_with_promotion, promotion: promotion) }
+      let(:promotion) { create(:promotion, :with_order_adjustment, code: 'abc123', per_code_usage_limit: 1) }
+      let(:promotion_code) { promotion.codes.first }
+
+      before do
+        FactoryGirl.create(
+          :completed_order_with_promotion,
+          promotion: promotion
+        )
+        promotion_code.adjustments.update_all(eligible: true)
+      end
+
+      it "returns false" do
+        expect(promotion.eligible?(promotable, promotion_code: promotion_code)).to eq(false)
+      end
+    end
+
+    context "when promotable is a Spree::LineItem" do
+      let(:promotable) { create :line_item }
+      let(:product) { promotable.product }
+
+      before do
+        product.promotionable = promotionable
+      end
+
+      context "and product is promotionable" do
+        let(:promotionable) { true }
+        it { is_expected.to be true }
+      end
+
+      context "and product is not promotionable" do
+        let(:promotionable) { false }
+        it { is_expected.to be false }
+      end
+    end
+
+    context "when promotable is a Spree::Order" do
+      let(:promotable) { create :order }
+
+      context "and it is empty" do
+        it { is_expected.to be true }
+      end
+
+      context "and it contains items" do
+        let!(:line_item) { create(:line_item, order: promotable) }
+        let!(:line_item2) { create(:line_item, order: promotable) }
+
+        context "and at least one item is non-promotionable" do
+          before do
+            line_item.product.update_column(:promotionable, false)
+          end
+          it { is_expected.to be false }
+        end
+
+        context "and the items are all non-promotionable" do
+          before do
+            line_item.product.update_column(:promotionable, false)
+            line_item2.product.update_column(:promotionable, false)
+          end
+          it { is_expected.to be false }
+        end
+
+        context "and at least one item is promotionable" do
+          it { is_expected.to be true }
+        end
+      end
+    end
+  end
+
+  context "#eligible_rules" do
+    let(:promotable) { double('Promotable') }
+    it "true if there are no rules" do
+      expect(promotion.eligible_rules(promotable)).to eq []
+    end
+
+    it "true if there are no applicable rules" do
+      promotion.promotion_rules = [stub_model(Spree::PromotionRule, :eligible? => true, :applicable? => false)]
+      allow(promotion.promotion_rules).to receive(:for).and_return([])
+      expect(promotion.eligible_rules(promotable)).to eq []
+    end
+
+    context "with 'all' match policy" do
+      let(:rule1) { Spree::PromotionRule.create!(promotion: promotion) }
+      let(:rule2) { Spree::PromotionRule.create!(promotion: promotion) }
+
+      before { promotion.match_policy = 'all' }
+
+      context "when all rules are eligible" do
+        before do
+          allow(rule1).to receive_messages(eligible?: true, applicable?: true)
+          allow(rule2).to receive_messages(eligible?: true, applicable?: true)
+
+          promotion.promotion_rules = [rule1, rule2]
+          allow(promotion.promotion_rules).to receive(:for).and_return(promotion.promotion_rules)
+        end
+        it "returns the eligible rules" do
+          expect(promotion.eligible_rules(promotable)).to eq [rule1, rule2]
+        end
+        it "does set anything to eligiblity errors" do
+          promotion.eligible_rules(promotable)
+          expect(promotion.eligibility_errors).to be_nil
+        end
+      end
+
+      context "when any of the rules is not eligible" do
+        let(:errors) { double ActiveModel::Errors, empty?: false }
+        before do
+          allow(rule1).to receive_messages(eligible?: true, applicable?: true, eligibility_errors: nil)
+          allow(rule2).to receive_messages(eligible?: false, applicable?: true, eligibility_errors: errors)
+
+          promotion.promotion_rules = [rule1, rule2]
+          allow(promotion.promotion_rules).to receive(:for).and_return(promotion.promotion_rules)
+        end
+        it "returns nil" do
+          expect(promotion.eligible_rules(promotable)).to be_nil
+        end
+        it "sets eligibility errors to the first non-nil one" do
+          promotion.eligible_rules(promotable)
+          expect(promotion.eligibility_errors).to eq errors
+        end
+      end
+    end
+
+    context "with 'any' match policy" do
+      let(:promotion) { Spree::Promotion.create(:name => "Promo", :match_policy => 'any') }
+      let(:promotable) { double('Promotable') }
+
+      it "should have eligible rules if any of the rules are eligible" do
+        allow_any_instance_of(Spree::PromotionRule).to receive_messages(:applicable? => true)
+        true_rule = Spree::PromotionRule.create(:promotion => promotion)
+        allow(true_rule).to receive_messages(:eligible? => true)
+        allow(promotion).to receive_messages(:rules => [true_rule])
+        allow(promotion).to receive_message_chain(:rules, :for).and_return([true_rule])
+        expect(promotion.eligible_rules(promotable)).to eq [true_rule]
+      end
+
+      context "when none of the rules are eligible" do
+        let(:rule) { Spree::PromotionRule.create!(promotion: promotion) }
+        let(:errors) { double ActiveModel::Errors, empty?: false }
+        before do
+          allow(rule).to receive_messages(eligible?: false, applicable?: true, eligibility_errors: errors)
+
+          promotion.promotion_rules = [rule]
+          allow(promotion.promotion_rules).to receive(:for).and_return(promotion.promotion_rules)
+        end
+        it "returns nil" do
+          expect(promotion.eligible_rules(promotable)).to be_nil
+        end
+        it "sets eligibility errors to the first non-nil one" do
+          promotion.eligible_rules(promotable)
+          expect(promotion.eligibility_errors).to eq errors
+        end
+      end
+    end
+  end
+
+  describe '#line_item_actionable?' do
+    let(:order) { double Spree::Order }
+    let(:line_item) { double Spree::LineItem}
+    let(:true_rule) { double Spree::PromotionRule, eligible?: true, applicable?: true, actionable?: true }
+    let(:false_rule) { double Spree::PromotionRule, eligible?: true, applicable?: true, actionable?: false }
+    let(:rules) { [] }
+
+    before do
+      allow(promotion).to receive(:rules) { rules }
+      allow(rules).to receive(:for) { rules }
+    end
+
+    subject { promotion.line_item_actionable? order, line_item }
+
+    context 'when the order is eligible for promotion' do
+      context 'when there are no rules' do
+        it { is_expected.to be }
+      end
+
+      context 'when there are rules' do
+        context 'when the match policy is all' do
+          before { promotion.match_policy = 'all' }
+
+          context 'when all rules allow action on the line item' do
+            let(:rules) { [true_rule] }
+            it { is_expected.to be}
+          end
+
+          context 'when at least one rule does not allow action on the line item' do
+            let(:rules) { [true_rule, false_rule] }
+            it { is_expected.not_to be}
+          end
+        end
+
+        context 'when the match policy is any' do
+          before { promotion.match_policy = 'any' }
+
+          context 'when at least one rule allows action on the line item' do
+            let(:rules) { [true_rule, false_rule] }
+            it { is_expected.to be }
+          end
+
+          context 'when no rules allow action on the line item' do
+            let(:rules) { [false_rule] }
+            it { is_expected.not_to be}
+          end
+        end
+      end
+    end
+
+    context 'when the order is not eligible for the promotion' do
+      context "due to promotion expiration" do
+        before { promotion.starts_at = Time.current + 2.days }
+        it { is_expected.not_to be }
+      end
+
+      context "due to promotion code not being eligible" do
+        let(:order) { create(:order) }
+        let(:promotion) { create(:promotion, per_code_usage_limit: 0) }
+        let(:promotion_code) { create(:promotion_code, promotion: promotion) }
+
+        subject { promotion.line_item_actionable? order, line_item, promotion_code: promotion_code }
+
+        it "returns false" do
+          expect(subject).to eq false
+        end
+      end
+    end
+  end
+
+  # regression for #4059
+  # admin form posts the code and path as empty string
+  describe "normalize blank values for path" do
+    it "will save blank value as nil value instead" do
+      promotion = Spree::Promotion.create(:name => "A promotion", :path => "")
+      expect(promotion.path).to be_nil
+    end
+  end
+
+  describe '#used_by?' do
+    subject { promotion.used_by? user, [excluded_order] }
+
+    let(:promotion) { create :promotion, :with_order_adjustment }
+    let(:user) { create :user }
+    let(:order) { create :order_with_line_items, user: user }
+    let(:excluded_order) { create :order_with_line_items, user: user }
+
+    before do
+      order.user_id = user.id
+      order.save!
+    end
+
+    context 'when the user has used this promo' do
+      before do
+        promotion.activate(order: order)
+        order.update!
+        order.completed_at = Time.now
+        order.save!
+      end
+
+      context 'when the order is complete' do
+        it { is_expected.to be true }
+
+        context 'when the promotion was not eligible' do
+          let(:adjustment) { order.adjustments.first }
+
+          before do
+            adjustment.eligible = false
+            adjustment.save!
+          end
+
+          it { is_expected.to be false }
+        end
+
+        context 'when the only matching order is the excluded order' do
+          let(:excluded_order) { order }
+          it { is_expected.to be false }
+        end
+      end
+
+      context 'when the order is not complete' do
+        let(:order) { create :order, user: user }
+        it { is_expected.to be false }
+      end
+    end
+
+    context 'when the user has not used this promo' do
+      it { is_expected.to be false }
+    end
+  end
+
+  describe "adding items to the cart" do
+    let(:order) { create :order }
+    let(:line_item) { create :line_item, order: order }
+    let(:promo) { create :promotion_with_item_adjustment, adjustment_rate: 5, code: 'promo' }
+    let(:promotion_code) { promo.codes.first }
+    let(:variant) { create :variant }
+
+    it "updates the promotions for new line items" do
+      expect(line_item.adjustments).to be_empty
+      expect(order.adjustment_total).to eq 0
+
+      promo.activate order: order, promotion_code: promotion_code
+      order.update!
+
+      expect(line_item.adjustments.size).to eq(1)
+      expect(order.adjustment_total).to eq -5
+
+      other_line_item = order.contents.add(variant, 1, currency: order.currency)
+
+      expect(other_line_item).not_to eq line_item
+      expect(other_line_item.adjustments.size).to eq(1)
+      expect(order.adjustment_total).to eq -10
+    end
+  end
+end