solidus_core 1.1.0 → 1.1.1

data/spec/lib/spree/core/role_configuration_spec.rb

@@ -0,0 +1,156 @@
+require 'spec_helper'
+
+describe Spree::RoleConfiguration do
+  class DummyPermissionSet < Spree::PermissionSets::Base
+    def activate!
+      can :manage, :things
+    end
+  end
+  class OtherDummyPermissionSet < Spree::PermissionSets::Base; end
+
+  let(:instance) { described_class.instance }
+
+  around do |example|
+    @original_roles = instance.roles.dup
+    instance.roles.clear
+    example.run
+    instance.roles = @original_roles
+  end
+
+  describe ".configure" do
+    it "yields with the instance" do
+      expect { |b| described_class.configure(&b) }.to yield_with_args(described_class.instance)
+    end
+
+    it "only yields once" do
+      expect { |b| described_class.configure(&b) }.to yield_control.once
+    end
+  end
+
+  describe "#assign_permissions" do
+    let(:name) { "thing" }
+    subject { instance.assign_permissions name, [DummyPermissionSet]}
+
+    context "when a role for the name exists" do
+      before do
+        instance.roles.merge!({ name => described_class::Role.new(name, Set.new(existing_roles)) })
+      end
+
+      context "when adding duplicate permission sets" do
+        let(:existing_roles) { [DummyPermissionSet] }
+
+        it "does not add another role" do
+          expect{subject}.to_not change{instance.roles.count}
+        end
+
+        it "does not add duplicate permission sets" do
+          subject
+          role = instance.roles.values.detect { |r| r.name == name }
+          expect(role.permission_sets).to match_array([DummyPermissionSet])
+        end
+      end
+
+      context "when adding new permission sets to an existing role" do
+        let(:existing_roles) { [OtherDummyPermissionSet] }
+
+        it "does not add another role" do
+          expect{subject}.to_not change{instance.roles.count}
+        end
+
+        it "appends the permission set to the existing role" do
+          subject
+          role = instance.roles.values.detect { |r| r.name == name }
+          expect(role.permission_sets).to match_array([OtherDummyPermissionSet, DummyPermissionSet])
+        end
+      end
+    end
+
+    context "when a role for the name does not yet exist" do
+      it "creates a new role" do
+        expect{subject}.to change{instance.roles.count}.from(0).to(1)
+      end
+
+      it "sets the roles name accordingly" do
+        subject
+        expect(instance.roles.values.first.name).to eql(name)
+      end
+
+      it "sets the permission sets accordingly" do
+        subject
+        expect(instance.roles.values.first.permission_sets).to match_array([DummyPermissionSet])
+      end
+    end
+  end
+
+  describe "#activate_permissions!" do
+    let(:user) { build :user }
+    let(:role_name) { "testrole" }
+    let(:ability) { DummyAbility.new }
+
+    before do
+      user.spree_roles = user_roles.map do |role|
+        Spree::Role.create!(name: role)
+      end
+    end
+
+    subject { described_class.instance.activate_permissions! ability, user }
+
+    context "when the configuration has roles" do
+      before do
+        instance.roles.merge!({ role_name => described_class::Role.new(role_name, [DummyPermissionSet])})
+      end
+
+      context "default_role" do
+        let(:role_name) { 'default' }
+
+        context "when the user has no roles" do
+          let(:user_roles) {[]}
+
+          it "activates the applicable permissions on the ability" do
+            expect{subject}.to change{ability.can? :manage, :things}.
+              from(false).
+              to(true)
+          end
+        end
+
+        context "when the user has a different role" do
+          let(:user_roles) {[]}
+
+          it "activates the applicable permissions on the ability" do
+            expect{subject}.to change{ability.can? :manage, :things}.
+              from(false).
+              to(true)
+          end
+        end
+      end
+
+      context "when the configuration has applicable roles" do
+        let(:user_roles) {[role_name, "someotherrandomrole"]}
+
+        it "activates the applicable permissions on the ability" do
+          expect{subject}.to change{ability.can? :manage, :things}.
+            from(false).
+            to(true)
+        end
+      end
+
+      context "when the configuration does not have applicable roles" do
+        let(:user_roles) {["somerandomrole"]}
+
+        it "doesn't activate non matching roles" do
+          subject
+          expect(ability.can? :manage, :things).to be false
+        end
+      end
+    end
+
+    context "when the configuration does not have roles" do
+      let(:user_roles) {["somerandomrole"]}
+
+      it "doesnt activate any new permissions" do
+        subject
+        expect(ability.can? :manage, :things).to be false
+      end
+    end
+  end
+end

data/spec/lib/spree/core/unreturned_item_charger_spec.rb

@@ -0,0 +1,130 @@
+require 'spec_helper'
+
+describe Spree::UnreturnedItemCharger do
+  let(:shipped_order) { create(:shipped_order, line_items_count: 1, with_cartons: false) }
+  let(:original_shipment) { shipped_order.shipments.first }
+  let(:original_stock_location) { original_shipment.stock_location }
+  let(:original_inventory_unit) { shipped_order.inventory_units.first }
+  let(:original_variant) { original_inventory_unit.variant }
+  let(:exchange_shipment) do
+    create(:shipment,
+           order: shipped_order,
+           state: 'shipped',
+           stock_location: original_stock_location,
+           created_at: 5.days.ago)
+  end
+  let(:exchange_inventory_unit) { exchange_shipment.inventory_units.first }
+  let(:return_item) do
+    create(:exchange_return_item,
+           inventory_unit: original_inventory_unit,
+           exchange_inventory_unit: exchange_inventory_unit)
+  end
+
+  let!(:unreturned_item_charger) { Spree::UnreturnedItemCharger.new(exchange_shipment, [return_item]) }
+
+  before do
+    exchange_shipment.finalize!
+    exchange_inventory_unit.ship!
+  end
+
+  shared_examples 'charge_for_items success' do
+    let(:new_order) do
+      subject
+      exchange_inventory_unit.shipment.order.reload
+    end
+
+    it "reuses the same inventory unit" do
+      expect { subject }.not_to change { Spree::InventoryUnit.count }
+    end
+
+    it "reuses the same shipment" do
+      expect { subject }.not_to change { Spree::Shipment.count }
+      expect(new_order.shipments.count).to eq 1
+    end
+
+    context 'in tax zone' do
+      let!(:tax_zone) { Spree::Zone.global }
+      let!(:tax_rate) { create(:tax_rate, zone: tax_zone, tax_category: original_variant.tax_category) }
+      before { tax_zone.update_attributes!(default_tax: true) }
+
+      it "applies tax" do
+        exchange_shipment.shipping_rates.update_all(tax_rate_id: tax_rate.id)
+        exchange_order = exchange_shipment.order
+        exchange_order.create_tax_charge!
+        exchange_order.update!
+        subject
+        expect(new_order.additional_tax_total).to be > 0
+        expect(new_order.line_items[0].additional_tax_total).to be > 0
+        expect(new_order.shipments[0].additional_tax_total).to be > 0
+      end
+    end
+
+    it "updates shipment cost" do
+      exchange_shipment.update_attributes!(cost: 0)
+      expect { subject }.to change { exchange_shipment.reload.cost }
+    end
+
+    it "creates a new completed order" do
+      expect { subject }.to change { Spree::Order.count }.by(1)
+      expect(new_order).to_not eq(shipped_order)
+      expect(new_order).to be_completed
+    end
+
+    it "authorizes payment" do
+      expect { subject }.to change { Spree::Payment.count }.by(1)
+      expect(new_order.payments.count).to eq 1
+      expect(new_order.payments.first).to be_pending
+      expect(new_order.payments.first.response_code).to be_present
+    end
+
+    it "delivers confirmation email" do
+      expect { subject }.to change { ActionMailer::Base.deliveries.count }.by(1)
+    end
+
+    context 'with auto_capture_exchanges' do
+      before { Spree::Config[:auto_capture_exchanges] = true }
+
+      it "captures payment" do
+        expect { subject }.to change { Spree::Payment.count }.by(1)
+        expect(new_order.payments.count).to eq 1
+        expect(new_order.payments.first).to be_completed
+        expect(new_order.payment_state).to eq "paid"
+      end
+    end
+  end
+
+  describe "#charge_for_items" do
+    before do
+      original_variant.update_attributes!(track_inventory: true)
+      original_variant.stock_items.update_all(backorderable: false)
+    end
+
+    subject { unreturned_item_charger.charge_for_items }
+
+    context "new order is not an unreturned exchange" do
+      before do
+        allow_any_instance_of(Spree::Shipment).to receive(:update_attributes!)
+      end
+
+      it "raises an error" do
+        expect { subject }.to raise_error(Spree::UnreturnedItemCharger::ChargeFailure, 'order is not an unreturned exchange')
+      end
+    end
+
+    context "item is in stock" do
+      before do
+        original_variant.stock_items.map { |si| si.set_count_on_hand(10) }
+      end
+
+      include_examples 'charge_for_items success'
+    end
+
+    context "item is now out of stock" do
+      before do
+        original_variant.stock_items.map { |si| si.set_count_on_hand(0) }
+      end
+
+      include_examples 'charge_for_items success'
+    end
+  end
+end

data/spec/lib/spree/core/validators/email_spec.rb

@@ -0,0 +1,48 @@
+require 'spec_helper'
+
+describe EmailValidator do
+
+  class Tester
+    include ActiveModel::Validations
+    attr_accessor :email_address
+    validates :email_address, email: true
+  end
+
+  let(:valid_emails) {[
+    'valid@email.com',
+    'valid@email.com.uk',
+    'e@email.com',
+    'valid+email@email.com',
+    'valid-email@email.com',
+    'valid_email@email.com',
+    'valid.email@email.com'
+  ]}
+  let(:invalid_emails) {[
+    'invalid email@email.com',
+    '.invalid.email@email.com',
+    'invalid.email.@email.com',
+    '@email.com',
+    '.@email.com',
+    'invalidemailemail.com',
+    '@invalid.email@email.com',
+    'invalid@email@email.com',
+    'invalid.email@@email.com'
+  ]}
+
+  it 'validates valid email addresses' do
+    tester = Tester.new
+    valid_emails.each do |email|
+      tester.email_address = email
+      expect(tester.valid?).to be true
+    end
+  end
+
+  it 'validates invalid email addresses' do
+    tester = Tester.new
+    invalid_emails.each do |email|
+      tester.email_address = email
+      expect(tester.valid?).to be false
+    end
+  end
+
+end

data/spec/lib/spree/localized_number_spec.rb

@@ -0,0 +1,38 @@
+require 'spec_helper'
+
+describe Spree::LocalizedNumber do
+
+  context ".parse" do
+    before do
+      I18n.enforce_available_locales = false
+      I18n.locale = I18n.default_locale
+      I18n.backend.store_translations(:de, { :number => { :currency => { :format => { :delimiter => '.', :separator => ',' } } } })
+    end
+
+    after do
+      I18n.locale = I18n.default_locale
+      I18n.enforce_available_locales = true
+    end
+
+    context "with decimal point" do
+      it "captures the proper amount for a formatted price" do
+        expect(subject.class.parse('1,599.99')).to eql 1599.99
+      end
+    end
+
+    context "with decimal comma" do
+      it "captures the proper amount for a formatted price" do
+        I18n.locale = :de
+        expect(subject.class.parse('1.599,99')).to eql 1599.99
+      end
+    end
+
+    context "with a numeric price" do
+      it "uses the price as is" do
+        I18n.locale = :de
+        expect(subject.class.parse(1599.99)).to eql 1599.99
+      end
+    end
+  end
+
+end

data/spec/lib/spree/migrations_spec.rb

@@ -0,0 +1,36 @@
+require 'spec_helper'
+
+module Spree
+  describe Migrations do
+    let(:app_migrations) { [".", "34_add_title.rb", "52_add_text.rb"] }
+    let(:engine_migrations) { [".", "334_create_orders.spree.rb", "777_create_products.spree.rb"] }
+
+    let(:config) { double("Config", root: "dir") }
+
+    let(:engine_dir) { "dir/db/migrate" }
+    let(:app_dir) { "#{Rails.root}/db/migrate" }
+
+    subject { described_class.new(config, "spree")  }
+
+    before do
+      expect(File).to receive(:directory?).with(app_dir).and_return true
+    end
+
+    it "warns about missing migrations" do
+      expect(Dir).to receive(:entries).with(app_dir).and_return app_migrations
+      expect(Dir).to receive(:entries).with(engine_dir).and_return engine_migrations
+
+      silence_stream(STDOUT) {
+        expect(subject.check).to eq true
+      }
+    end
+
+    context "no missing migrations" do
+      it "says nothing" do
+        expect(Dir).to receive(:entries).with(engine_dir).and_return engine_migrations
+        expect(Dir).to receive(:entries).with(app_dir).and_return (app_migrations + engine_migrations)
+        expect(subject.check).to eq nil
+      end
+    end
+  end
+end

data/spec/lib/spree/money_spec.rb

@@ -0,0 +1,127 @@
+# coding: utf-8
+require 'spec_helper'
+
+describe Spree::Money do
+  before do
+    configure_spree_preferences do |config|
+      config.currency = "USD"
+    end
+  end
+
+  it "formats correctly" do
+    money = Spree::Money.new(10)
+    expect(money.to_s).to eq("$10.00")
+  end
+
+  it "can get cents" do
+    money = Spree::Money.new(10)
+    expect(money.cents).to eq(1000)
+  end
+
+  context "with currency" do
+    it "passed in option" do
+      money = Spree::Money.new(10, :with_currency => true, :html => false)
+      expect(money.to_s).to eq("$10.00 USD")
+    end
+  end
+
+  context "hide cents" do
+    it "hides cents suffix" do
+      money = Spree::Money.new(10, no_cents: true)
+      expect(money.to_s).to eq("$10")
+    end
+
+    it "shows cents suffix" do
+      money = Spree::Money.new(10)
+      expect(money.to_s).to eq("$10.00")
+    end
+  end
+
+  context "currency parameter" do
+    context "when currency is specified in Canadian Dollars" do
+      it "uses the currency param over the global configuration" do
+        money = Spree::Money.new(10, :currency => 'CAD', :with_currency => true, :html => false)
+        expect(money.to_s).to eq("$10.00 CAD")
+      end
+    end
+
+    context "when currency is specified in Japanese Yen" do
+      it "uses the currency param over the global configuration" do
+        money = Spree::Money.new(100, :currency => 'JPY', :html => false)
+        expect(money.to_s).to eq("¥100")
+      end
+    end
+  end
+
+  context "symbol positioning" do
+    it "passed in option" do
+      money = Spree::Money.new(10, :symbol_position => :after, :html => false)
+      expect(money.to_s).to eq("10.00 $")
+    end
+
+    it "config option" do
+      money = Spree::Money.new(10, symbol_position: :after, html: false)
+      expect(money.to_s).to eq("10.00 $")
+    end
+  end
+
+  context "sign before symbol" do
+    it "defaults to -$10.00" do
+      money = Spree::Money.new(-10)
+      expect(money.to_s).to eq("-$10.00")
+    end
+
+    it "passed in option" do
+      money = Spree::Money.new(-10, :sign_before_symbol => false)
+      expect(money.to_s).to eq("$-10.00")
+    end
+  end
+
+  context "JPY" do
+    before do
+      configure_spree_preferences do |config|
+        config.currency = "JPY"
+      end
+    end
+
+    it "formats correctly" do
+      money = Spree::Money.new(1000, :html => false)
+      expect(money.to_s).to eq("¥1,000")
+    end
+  end
+
+  context "EUR" do
+    before do
+      configure_spree_preferences do |config|
+        config.currency = "EUR"
+      end
+    end
+
+    # Regression test for #2634
+    it "formats as plain by default" do
+      money = Spree::Money.new(10, symbol_position: :after)
+      expect(money.to_s).to eq("10.00 €")
+    end
+
+    it "formats as HTML if asked (nicely) to" do
+      money = Spree::Money.new(10, symbol_position: :after)
+      # The HTML'ified version of "10.00 €"
+      expect(money.to_html).to eq("10.00 €")
+    end
+
+    it "formats as HTML with currency" do
+      money = Spree::Money.new(10, symbol_position: :after, with_currency: true)
+      # The HTML'ified version of "10.00 €"
+      expect(money.to_html).to eq("10.00&nbsp;&#x20AC; <span class=\"currency\">EUR</span>")
+    end
+  end
+
+  describe "#as_json" do
+    let(:options) { double('options') }
+
+    it "returns the expected string" do
+      money = Spree::Money.new(10)
+      expect(money.as_json(options)).to eq("$10.00")
+    end
+  end
+end