solidus_core 1.0.2 → 1.0.3

data/spec/models/spree/address_spec.rb

@@ -0,0 +1,250 @@
+require 'spec_helper'
+
+describe Spree::Address, :type => :model do
+
+  subject { Spree::Address }
+
+  context "aliased attributes" do
+    let(:address) { Spree::Address.new firstname: 'Ryan', lastname: 'Bigg'}
+
+    it " first_name" do
+      expect(address.first_name).to eq("Ryan")
+    end
+
+    it "last_name" do
+      expect(address.last_name).to eq("Bigg")
+    end
+  end
+
+  context "validation" do
+
+    let(:country) { mock_model(Spree::Country, :states => [state], :states_required => true) }
+    let(:state) { stub_model(Spree::State, :name => 'maryland', :abbr => 'md') }
+    let(:address) { build(:address, :country => country) }
+
+    before do
+      allow(country.states).to receive_messages :find_all_by_name_or_abbr => [state]
+    end
+
+    context 'address does not require state' do
+      before do
+        Spree::Config.address_requires_state = false
+      end
+      it "address_requires_state preference is false" do
+        address.state = nil
+        address.state_name = nil
+        expect(address).to be_valid
+      end
+    end
+
+    context 'address requires state' do
+      before do
+        Spree::Config.address_requires_state = true
+      end
+
+      it "state_name is not nil and country does not have any states" do
+        address.state = nil
+        address.state_name = 'alabama'
+        expect(address).to be_valid
+      end
+
+      it "errors when state_name is nil" do
+        address.state_name = nil
+        address.state = nil
+        expect(address).not_to be_valid
+      end
+
+      it "full state name is in state_name and country does contain that state" do
+        address.state_name = 'alabama'
+        # called by state_validate to set up state_id.
+        # Perhaps this should be a before_validation instead?
+        expect(address).to be_valid
+        expect(address.state).not_to be_nil
+        expect(address.state_name).to be_nil
+      end
+
+      it "state abbr is in state_name and country does contain that state" do
+        address.state_name = state.abbr
+        expect(address).to be_valid
+        expect(address.state_id).not_to be_nil
+        expect(address.state_name).to be_nil
+      end
+
+      it "state is entered but country does not contain that state" do
+        address.state = state
+        address.country = stub_model(Spree::Country, :states_required => true)
+        address.valid?
+        expect(address.errors["state"]).to eq(['is invalid'])
+      end
+
+      it "both state and state_name are entered but country does not contain the state" do
+        address.state = state
+        address.state_name = 'maryland'
+        address.country = stub_model(Spree::Country, :states_required => true)
+        expect(address).to be_valid
+        expect(address.state_id).to be_nil
+      end
+
+      it "both state and state_name are entered and country does contain the state" do
+        address.state = state
+        address.state_name = 'maryland'
+        expect(address).to be_valid
+        expect(address.state_name).to be_nil
+      end
+    end
+
+    it "requires phone" do
+      address.phone = ""
+      address.valid?
+      expect(address.errors["phone"]).to eq(["can't be blank"])
+    end
+
+    it "requires zipcode" do
+      address.zipcode = ""
+      address.valid?
+      expect(address.errors['zipcode']).to include("can't be blank")
+    end
+
+    context "zipcode validation" do
+      it "validates the zipcode" do
+        allow(address.country).to receive(:iso).and_return('US')
+        address.zipcode = 'abc'
+        address.valid?
+        expect(address.errors['zipcode']).to include('is invalid')
+      end
+
+      context 'does not validate' do
+        it 'does not have a country' do
+          address.country = nil
+          address.valid?
+          expect(address.errors['zipcode']).not_to include('is invalid')
+        end
+
+        it 'does not have an iso' do
+          allow(address.country).to receive(:iso).and_return(nil)
+          address.valid?
+          expect(address.errors['zipcode']).not_to include('is invalid')
+        end
+
+        it 'does not have a zipcode' do
+          address.zipcode = ""
+          address.valid?
+          expect(address.errors['zipcode']).not_to include('is invalid')
+        end
+
+        it 'does not have a supported country iso' do
+          allow(address.country).to receive(:iso).and_return('BO')
+          address.valid?
+          expect(address.errors['zipcode']).not_to include('is invalid')
+        end
+      end
+    end
+
+    context "phone not required" do
+      before { allow(address).to receive_messages require_phone?: false }
+
+      it "shows no errors when phone is blank" do
+        address.phone = ""
+        address.valid?
+        expect(address.errors[:phone].size).to eq 0
+      end
+    end
+
+    context "zipcode not required" do
+      before { allow(address).to receive_messages require_zipcode?: false }
+
+      it "shows no errors when phone is blank" do
+        address.zipcode = ""
+        address.valid?
+        expect(address.errors[:zipcode].size).to eq 0
+      end
+    end
+  end
+
+  context ".default" do
+    context "no user given" do
+      let!(:default_country) { create(:country) }
+
+      context 'has a default country' do
+        before do
+          Spree::Config[:default_country_id] = default_country.id
+        end
+
+        it "sets up a new record with Spree::Config[:default_country_id]" do
+          expect(Spree::Address.default.country).to eq default_country
+        end
+      end
+
+      # Regression test for #1142
+      it "uses the first available country if :default_country_id is set to an invalid value" do
+        Spree::Config[:default_country_id] = "0"
+        expect(Spree::Address.default.country).to eq default_country
+      end
+    end
+
+    context "user given" do
+      let(:bill_address) { Spree::Address.new(phone: '123-456-7890') }
+      let(:user) { double("User", bill_address: bill_address) }
+
+      it "returns a copy of that user bill address" do
+        expect(described_class.default(user).phone).to eq '123-456-7890'
+      end
+
+      context 'has no address' do
+        let(:bill_address) { nil }
+
+        it "falls back to build default when user has no address" do
+          expect(described_class.default(user)).to eq described_class.build_default
+        end
+      end
+    end
+  end
+
+  context '#full_name' do
+    context 'both first and last names are present' do
+      let(:address) { stub_model(Spree::Address, :firstname => 'Michael', :lastname => 'Jackson') }
+      specify { expect(address.full_name).to eq('Michael Jackson') }
+    end
+
+    context 'first name is blank' do
+      let(:address) { stub_model(Spree::Address, :firstname => nil, :lastname => 'Jackson') }
+      specify { expect(address.full_name).to eq('Jackson') }
+    end
+
+    context 'last name is blank' do
+      let(:address) { stub_model(Spree::Address, :firstname => 'Michael', :lastname => nil) }
+      specify { expect(address.full_name).to eq('Michael') }
+    end
+
+    context 'both first and last names are blank' do
+      let(:address) { stub_model(Spree::Address, :firstname => nil, :lastname => nil) }
+      specify { expect(address.full_name).to eq('') }
+    end
+
+  end
+
+  context '#state_text' do
+    context 'state is blank' do
+      let(:address) { stub_model(Spree::Address, :state => nil, :state_name => 'virginia') }
+      specify { expect(address.state_text).to eq('virginia') }
+    end
+
+    context 'both name and abbr is present' do
+      let(:state) { stub_model(Spree::State, :name => 'virginia', :abbr => 'va') }
+      let(:address) { stub_model(Spree::Address, :state => state) }
+      specify { expect(address.state_text).to eq('va') }
+    end
+
+    context 'only name is present' do
+      let(:state) { stub_model(Spree::State, :name => 'virginia', :abbr => nil) }
+      let(:address) { stub_model(Spree::Address, :state => state) }
+      specify { expect(address.state_text).to eq('virginia') }
+    end
+  end
+
+  context '#requires_phone' do
+    subject { described_class.new }
+
+    it { is_expected.to be_require_phone  }
+  end
+end

data/spec/models/spree/adjustment_reason_spec.rb

@@ -0,0 +1,13 @@
+require 'spec_helper'
+
+describe Spree::AdjustmentReason do
+
+  describe 'creation' do
+    it 'is successful' do
+      expect {
+        create(:adjustment_reason)
+      }.to_not raise_error
+    end
+  end
+
+end

data/spec/models/spree/adjustment_spec.rb

@@ -0,0 +1,177 @@
+# encoding: utf-8
+#
+
+require 'spec_helper'
+
+describe Spree::Adjustment, :type => :model do
+
+  let(:order) { Spree::Order.new }
+  let(:line_item) { create :line_item, order: order }
+
+  let(:adjustment) { Spree::Adjustment.create!(label: 'Adjustment', adjustable: order, order: order, amount: 5) }
+
+  context '#create & #destroy' do
+    let(:adjustment) { Spree::Adjustment.new(label: "Adjustment", amount: 5, order: order, adjustable: line_item) }
+
+    it 'calls #update_adjustable_adjustment_total' do
+      expect(adjustment).to receive(:update_adjustable_adjustment_total).twice
+      adjustment.save
+      adjustment.destroy
+    end
+  end
+
+  context '#save' do
+    let(:adjustment) { Spree::Adjustment.create(label: "Adjustment", amount: 5, order: order, adjustable: line_item) }
+
+    it 'touches the adjustable' do
+      expect { adjustment.save }.to change { line_item.updated_at }
+    end
+  end
+
+  describe 'non_tax scope' do
+    subject do
+      Spree::Adjustment.non_tax.to_a
+    end
+
+    let!(:tax_adjustment) { create(:adjustment, order: order, source: create(:tax_rate))                   }
+    let!(:non_tax_adjustment_with_source) { create(:adjustment, order: order, source_type: 'Spree::Order', source_id: nil) }
+    let!(:non_tax_adjustment_without_source) { create(:adjustment, order: order, source: nil)                                 }
+
+    it 'select non-tax adjustments' do
+      expect(subject).to_not include tax_adjustment
+      expect(subject).to     include non_tax_adjustment_with_source
+      expect(subject).to     include non_tax_adjustment_without_source
+    end
+  end
+
+  context "adjustment state" do
+    subject { build(:adjustment, order: order, state: state) }
+
+    context "#closed?" do
+      context 'is closed' do
+        let(:state) { 'closed' }
+        it { is_expected.to be_closed }
+      end
+
+      context 'is open' do
+        let(:state) { 'open' }
+        it { is_expected.to_not be_closed }
+      end
+    end
+  end
+
+  context '#currency' do
+    let(:order) { Spree::Order.new currency: 'JPY' }
+
+    it 'returns the adjustables currency' do
+      expect(adjustment.currency).to eq 'JPY'
+    end
+
+    context 'adjustable is nil' do
+      before do
+        adjustment.adjustable = nil
+      end
+      it 'uses the global currency of USD' do
+        expect(adjustment.currency).to eq 'USD'
+      end
+    end
+  end
+
+  context "#display_amount" do
+    before { adjustment.amount = 10.55 }
+
+    it "shows the amount" do
+      expect(adjustment.display_amount.to_s).to eq "$10.55"
+    end
+
+    context "with currency set to JPY" do
+      let(:order) { Spree::Order.new currency: 'JPY' }
+
+      context "when adjustable is set to an order" do
+        it "displays in JPY" do
+          expect(adjustment.display_amount.to_s).to eq "¥11"
+        end
+      end
+    end
+  end
+
+  context '#update!' do
+    let(:adjustment) { Spree::Adjustment.create!(label: 'Adjustment', order: order, adjustable: order, amount: 5, state: state, source: source) }
+    let(:source) { mock_model(Spree::TaxRate, compute_amount: 10) }
+
+    subject { adjustment.update! }
+
+    context "when adjustment is closed" do
+      let(:state) { 'closed' }
+
+      it "does not update the adjustment" do
+        expect(adjustment).to_not receive(:update_column)
+        subject
+      end
+    end
+
+    context "when adjustment is open" do
+      let(:state) { 'open' }
+
+      it "updates the amount" do
+        expect { subject }.to change { adjustment.amount }.to(10)
+      end
+
+      context "it is a promotion adjustment" do
+        let(:promotion) { create(:promotion, :with_order_adjustment, starts_at: promo_start_date) }
+        let(:promo_start_date) { nil }
+        let(:promotion_code) { promotion.codes.first }
+        let(:order) { create(:order_with_line_items, line_items_count: 1) }
+
+        let!(:adjustment) do
+          promotion.activate(order: order, promotion_code: promotion_code)
+          order.adjustments.first
+        end
+
+        context "the promotion is eligible" do
+          it "sets the adjustment elgiible to true" do
+            subject
+            expect(adjustment.eligible).to eq true
+          end
+        end
+
+        context "the promotion is not eligible" do
+          let(:promo_start_date) { Date.tomorrow }
+
+          it "sets the adjustment elgiible to false" do
+            subject
+            expect(adjustment.eligible).to eq false
+          end
+        end
+      end
+    end
+  end
+
+  describe "promotion code presence error" do
+    subject do
+      adjustment.valid?
+      adjustment.errors[:promotion_code]
+    end
+
+    context "when the adjustment is not a promotion adjustment" do
+      let(:adjustment) { build(:adjustment) }
+
+      it { is_expected.to be_blank }
+    end
+
+    context "when the adjustment is a promotion adjustment" do
+      let(:adjustment) { build(:adjustment, source: promotion.actions.first) }
+      let(:promotion) { create(:promotion, :with_order_adjustment) }
+
+      context "when the promotion does not have a code" do
+        it { is_expected.to be_blank }
+      end
+
+      context "when the promotion has a code" do
+        let!(:promotion_code) { create(:promotion_code, promotion: promotion) }
+
+        it { is_expected.to include("can't be blank") }
+      end
+    end
+  end
+end

data/spec/models/spree/app_configuration_spec.rb

@@ -0,0 +1,20 @@
+require 'spec_helper'
+
+describe Spree::AppConfiguration, :type => :model do
+
+  let (:prefs) { Rails.application.config.spree.preferences }
+
+  it "should be available from the environment" do
+    prefs.layout = "my/layout"
+    expect(prefs.layout).to eq "my/layout"
+  end
+
+  it "should be available as Spree::Config for legacy access" do
+    expect(Spree::Config).to be_a Spree::AppConfiguration
+  end
+
+  it "uses base searcher class by default" do
+    expect(prefs.searcher_class).to eq Spree::Core::Search::Base
+  end
+
+end