solidus_core 1.0.2 → 1.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 58622e86f30cbe6913c6c9a25c6d0b57f0bbd931
-  data.tar.gz: 2012989f08503d9eba91851c712e2d7f474e2bb5
+  metadata.gz: 758c9e82e5fac008cdb87fad3414299c3b501ecd
+  data.tar.gz: a35ac3995de180db514a5d7605b5fe704718bf38
 SHA512:
-  metadata.gz: 96c333f769f84e564713f4b09cfe9eed79c0464b8f281f2a0dbe2fee5b4dd7a34cf84423d192cdd090a7da96a5e12d7fc458fc9dd306e0d5dc196b346cecd777
-  data.tar.gz: a77c48ed3977520ee302bf6e3eb696829ba338e3978e2619837a29d88d40795af2973345cfb9903cdab1e82cffa69fcb5d90d440d06e8a9da32b67aae03cd28a
+  metadata.gz: 6d8cde6da8e863a4b83eed56d4803ffc94121604a8c58c2d538854a7b532ee0f5f66e29aa1de7451c0c5f039f410f033ddfdb6c534e72ce7f9f32009272bb834
+  data.tar.gz: 5bd8d373ec78d1a0067c57644f1e27d6b798694d19a494dc8a278483201d01b0f94d9650404ce34f27883f0202ed45c80fc9efc51f298f945177deb3cba32ab4

data/CHANGELOG.md

@@ -0,0 +1 @@
+## Spree 2.4.0 (unreleased) ##

data/Gemfile

@@ -0,0 +1,3 @@
+eval(File.read(File.dirname(__FILE__) + '/../common_spree_dependencies.rb'))
+
+gemspec

data/Rakefile

@@ -0,0 +1,16 @@
+require 'rubygems'
+require 'rake'
+require 'rake/testtask'
+require 'rspec/core/rake_task'
+require 'spree/testing_support/common_rake'
+load 'lib/tasks/exchanges.rake'
+
+RSpec::Core::RakeTask.new
+
+task :default => :spec
+
+desc "Generates a dummy app for testing"
+task :test_app do
+  ENV['LIB_NAME'] = 'spree/core'
+  Rake::Task['common:test_app'].invoke
+end

data/script/rails

@@ -0,0 +1,9 @@
+#!/usr/bin/env ruby
+# This command will automatically be run when you run "rails" with Rails 3 gems installed from the root of your application.
+
+ENGINE_ROOT = File.expand_path('../..', __FILE__)
+ENGINE_PATH = File.expand_path('../../lib/spree/core/engine', __FILE__)
+
+require 'rails/all'
+require 'rails/engine/commands'
+

data/solidus_core.gemspec

@@ -0,0 +1,48 @@
+# encoding: UTF-8
+version = File.read(File.expand_path("../../SOLIDUS_VERSION", __FILE__)).strip
+
+Gem::Specification.new do |s|
+  s.platform    = Gem::Platform::RUBY
+  s.name        = 'solidus_core'
+  s.version     = version
+  s.summary     = 'Essential models, mailers, and classes for the Solidus e-commerce project.'
+  s.description = s.summary
+
+  s.required_ruby_version = '>= 2.1.0'
+  s.author      = 'Solidus Team'
+  s.email       = 'contact@solidus.io'
+  s.homepage    = 'http://solidus.io'
+  s.license     = %q{BSD-3}
+
+  s.files        = `git ls-files`.split("\n")
+  s.require_path = 'lib'
+
+  s.required_ruby_version = '>= 2.1.0'
+
+  s.add_dependency 'activemerchant', '~> 1.48.0'
+  s.add_dependency 'acts_as_list', '~> 0.3'
+  s.add_dependency 'awesome_nested_set', '~> 3.0.1'
+  s.add_dependency 'carmen', '~> 1.0.0'
+  s.add_dependency 'cancancan', '~> 1.10.0'
+  s.add_dependency 'deface', '~> 1.0.0'
+  s.add_dependency 'ffaker', '~> 1.16'
+  s.add_dependency 'font-awesome-rails', '~> 4.0'
+  s.add_dependency 'friendly_id', '~> 5.0.4'
+  s.add_dependency 'highline', '~> 1.6.18' # Necessary for the install generator
+  s.add_dependency 'json', '~> 1.7'
+  s.add_dependency 'kaminari', '~> 0.15', '>= 0.15.1'
+  s.add_dependency 'monetize', '~> 1.1'
+  s.add_dependency 'paperclip', '~> 4.2.0'
+  s.add_dependency 'paranoia', '~> 2.1.0'
+  s.add_dependency 'premailer-rails'
+  s.add_dependency 'rails', '~> 4.2.0'
+  s.add_dependency 'ransack', '~> 1.6.0'
+  s.add_dependency 'responders'
+  s.add_dependency 'state_machines-activerecord', '~> 0.2'
+  s.add_dependency 'stringex', '~> 1.5.1'
+  s.add_dependency 'truncate_html', '0.9.2'
+  s.add_dependency 'twitter_cldr', '~> 3.0'
+
+  s.add_development_dependency 'email_spec', '~> 1.6'
+  s.add_dependency 'sprockets-rails', '~> 2.0'
+end

data/spec/helpers/base_helper_spec.rb

@@ -0,0 +1,173 @@
+require 'spec_helper'
+
+describe Spree::BaseHelper, :type => :helper do
+  include Spree::BaseHelper
+
+  let(:current_store){ create :store }
+
+  context "available_countries" do
+    let(:country) { create(:country) }
+
+    before do
+      3.times { create(:country) }
+    end
+
+    context "with no checkout zone defined" do
+      before do
+        Spree::Config[:checkout_zone] = nil
+      end
+
+      it "return complete list of countries" do
+        expect(available_countries.count).to eq(Spree::Country.count)
+      end
+    end
+
+    context "with a checkout zone defined" do
+      context "checkout zone is of type country" do
+        before do
+          @country_zone = create(:zone, :name => "CountryZone")
+          @country_zone.members.create(:zoneable => country)
+          Spree::Config[:checkout_zone] = @country_zone.name
+        end
+
+        it "return only the countries defined by the checkout zone" do
+          expect(available_countries).to eq([country])
+        end
+      end
+
+      context "checkout zone is of type state" do
+        before do
+          state_zone = create(:zone, :name => "StateZone")
+          state = create(:state, :country => country)
+          state_zone.members.create(:zoneable => state)
+          Spree::Config[:checkout_zone] = state_zone.name
+        end
+
+        it "return complete list of countries" do
+          expect(available_countries.count).to eq(Spree::Country.count)
+        end
+      end
+    end
+  end
+
+  # Regression test for #1436
+  context "defining custom image helpers" do
+    let(:product) { mock_model(Spree::Product, :images => [], :variant_images => []) }
+    before do
+      Spree::Image.class_eval do
+        attachment_definitions[:attachment][:styles].merge!({:very_strange => '1x1'})
+      end
+    end
+
+    it "should not raise errors when style exists" do
+      ActiveSupport::Deprecation.silence do
+        expect { very_strange_image(product) }.not_to raise_error
+      end
+    end
+
+    it "should raise NoMethodError when style is not exists" do
+      expect { another_strange_image(product) }.to raise_error(NoMethodError)
+    end
+
+  end
+
+  # Regression test for #2034
+  context "flash_message" do
+    let(:flash) { {"notice" => "ok", "foo" => "foo", "bar" => "bar"} }
+
+    it "should output all flash content" do
+      flash_messages
+      html = Nokogiri::HTML(helper.output_buffer)
+      expect(html.css(".notice").text).to eq("ok")
+      expect(html.css(".foo").text).to eq("foo")
+      expect(html.css(".bar").text).to eq("bar")
+    end
+
+    it "should output flash content except one key" do
+      flash_messages(:ignore_types => :bar)
+      html = Nokogiri::HTML(helper.output_buffer)
+      expect(html.css(".notice").text).to eq("ok")
+      expect(html.css(".foo").text).to eq("foo")
+      expect(html.css(".bar").text).to be_empty
+    end
+
+    it "should output flash content except some keys" do
+      flash_messages(:ignore_types => [:foo, :bar])
+      html = Nokogiri::HTML(helper.output_buffer)
+      expect(html.css(".notice").text).to eq("ok")
+      expect(html.css(".foo").text).to be_empty
+      expect(html.css(".bar").text).to be_empty
+      expect(helper.output_buffer).to eq("<div class=\"flash notice\">ok</div>")
+    end
+  end
+
+  context "link_to_tracking" do
+    it "returns tracking link if available" do
+      a = link_to_tracking_html(shipping_method: true, tracking: '123', tracking_url: 'http://g.c/?t=123').css('a')
+
+      expect(a.text).to eq '123'
+      expect(a.attr('href').value).to eq 'http://g.c/?t=123'
+    end
+
+    it "returns tracking without link if link unavailable" do
+      html = link_to_tracking_html(shipping_method: true, tracking: '123', tracking_url: nil)
+      expect(html.css('span').text).to eq '123'
+    end
+
+    it "returns nothing when no shipping method" do
+      html = link_to_tracking_html(shipping_method: nil, tracking: '123')
+      expect(html.css('span').text).to eq ''
+    end
+
+    it "returns nothing when no tracking" do
+      html = link_to_tracking_html(tracking: nil)
+      expect(html.css('span').text).to eq ''
+    end
+
+    def link_to_tracking_html(options = {})
+      node = link_to_tracking(double(:shipment, options))
+      Nokogiri::HTML(node.to_s)
+    end
+  end
+
+  # Regression test for #2396
+  context "meta_data_tags" do
+    it "truncates a product description to 160 characters" do
+      # Because the controller_name method returns "test"
+      # controller_name is used by this method to infer what it is supposed
+      # to be generating meta_data_tags for
+      text = Faker::Lorem.paragraphs(2).join(" ")
+      @test = Spree::Product.new(:description => text)
+      tags = Nokogiri::HTML.parse(meta_data_tags)
+      content = tags.css("meta[name=description]").first["content"]
+      assert content.length <= 160, "content length is not truncated to 160 characters"
+    end
+  end
+
+  # Regression test for #5384
+  context "custom image helpers conflict with inproper statements" do
+    let(:product) { mock_model(Spree::Product, :images => [], :variant_images => []) }
+    before do
+      Spree::Image.class_eval do
+        attachment_definitions[:attachment][:styles].merge!({:foobar => '1x1'})
+      end
+    end
+
+    it "should not raise errors when helper method called" do
+      ActiveSupport::Deprecation.silence do
+        expect { foobar_image(product) }.not_to raise_error
+      end
+    end
+
+    it "should raise NoMethodError when statement with name equal to style name called" do
+      expect { foobar(product) }.to raise_error(NoMethodError)
+    end
+
+  end
+
+  context "pretty_time" do
+    it "prints in a format" do
+      expect(pretty_time(DateTime.new(2012, 5, 6, 13, 33))).to eq "May 06, 2012  1:33 PM"
+    end
+  end
+end

data/spec/helpers/order_helper_spec.rb

@@ -0,0 +1,12 @@
+require 'spec_helper'
+
+module Spree
+  describe Spree::OrdersHelper, :type => :helper do
+    # Regression test for #2518 + #2323
+    it "truncates HTML correctly in product description" do
+      product = double(:description => "<strong>" + ("a" * 95) + "</strong> This content is invisible.")
+      expected = "<strong>" + ("a" * 95) + "</strong>..."
+      expect(truncated_product_description(product)).to eq(expected)
+    end
+  end
+end

data/spec/helpers/products_helper_spec.rb

@@ -0,0 +1,220 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+module Spree
+  describe ProductsHelper, :type => :helper do
+    include ProductsHelper
+
+    let(:product) { create(:product) }
+    let(:currency) { 'USD' }
+
+    before do
+      allow(helper).to receive(:current_currency) { currency }
+    end
+
+    context "#variant_price_diff" do
+      let(:product_price) { 10 }
+      let(:variant_price) { 10 }
+
+      before do
+        @variant = create(:variant, :product => product)
+        product.price = 15
+        @variant.price = 10
+        allow(product).to receive(:amount_in) { product_price }
+        allow(@variant).to receive(:amount_in) { variant_price }
+      end
+
+      subject { helper.variant_price(@variant) }
+
+      context "when variant is same as master" do
+        it { is_expected.to be_nil }
+      end
+
+      context "when the master has no price" do
+        let(:product_price) { nil }
+
+        it { is_expected.to be_nil }
+      end
+
+      context "when currency is default" do
+        context "when variant is more than master" do
+          let(:variant_price) { 15 }
+
+          it { is_expected.to eq("(Add: $5.00)") }
+          # Regression test for #2737
+          it { is_expected.to be_html_safe }
+        end
+
+        context "when variant is less than master" do
+          let(:product_price) { 15 }
+
+          it { is_expected.to eq("(Subtract: $5.00)") }
+        end
+      end
+
+      context "when currency is JPY" do
+        let(:variant_price) { 100 }
+        let(:product_price) { 100 }
+        let(:currency) { 'JPY' }
+
+        context "when variant is more than master" do
+          let(:variant_price) { 150 }
+
+          it { is_expected.to eq("(Add: ¥50)") }
+        end
+
+        context "when variant is less than master" do
+          let(:product_price) { 150 }
+
+          it { is_expected.to eq("(Subtract: ¥50)") }
+        end
+      end
+    end
+
+    context "#variant_price_full" do
+      before do
+        Spree::Config[:show_variant_full_price] = true
+        @variant1 = create(:variant, :product => product)
+        @variant2 = create(:variant, :product => product)
+      end
+
+      context "when currency is default" do
+        it "should return the variant price if the price is different than master" do
+          product.price = 10
+          @variant1.price = 15
+          @variant2.price = 20
+          expect(helper.variant_price(@variant1)).to eq("$15.00")
+          expect(helper.variant_price(@variant2)).to eq("$20.00")
+        end
+      end
+
+      context "when currency is JPY" do
+        let(:currency) { 'JPY' }
+
+        before do
+          product.variants.active.each do |variant|
+            variant.prices.each do |price|
+              price.currency = currency
+              price.save!
+            end
+          end
+        end
+
+        it "should return the variant price if the price is different than master" do
+          product.price = 100
+          @variant1.price = 150
+          expect(helper.variant_price(@variant1)).to eq("¥150")
+        end
+      end
+
+      it "should be nil when all variant prices are equal" do
+        product.price = 10
+        @variant1.default_price.update_column(:amount, 10)
+        @variant2.default_price.update_column(:amount, 10)
+        expect(helper.variant_price(@variant1)).to be_nil
+        expect(helper.variant_price(@variant2)).to be_nil
+      end
+    end
+
+
+    context "#product_description" do
+      # Regression test for #1607
+      it "renders a product description without excessive paragraph breaks" do
+        product.description = %Q{
+<p>Lorem ipsum dolor sit amet, consectetur adipiscing elit. Vivamus a ligula leo. Proin eu arcu at ipsum dapibus ullamcorper. Pellentesque egestas orci nec magna condimentum luctus. Cum sociis natoque penatibus et magnis dis parturient montes, nascetur ridiculus mus. Ut ac ante et mauris bibendum ultricies non sed massa. Fusce facilisis dui eget lacus scelerisque eget aliquam urna ultricies. Duis et rhoncus quam. Praesent tellus nisi, ultrices sed iaculis quis, euismod interdum ipsum.</p>
+<ul>
+<li>Lorem ipsum dolor sit amet</li>
+<li>Lorem ipsum dolor sit amet</li>
+</ul>
+        }
+        description = product_description(product)
+        expect(description.strip).to eq(product.description.strip)
+      end
+
+      it "renders a product description with automatic paragraph breaks" do
+        product.description = %Q{
+THIS IS THE BEST PRODUCT EVER!
+
+"IT CHANGED MY LIFE" - Sue, MD}
+
+        description = product_description(product)
+        expect(description.strip).to eq(%Q{<p>\nTHIS IS THE BEST PRODUCT EVER!</p>"IT CHANGED MY LIFE" - Sue, MD})
+      end
+
+      it "renders a product description without any formatting based on configuration" do
+        initialDescription = %Q{
+            <p>hello world</p>
+
+            <p>tihs is completely awesome and it works</p>
+
+            <p>why so many spaces in the code. and why some more formatting afterwards?</p>
+        }
+
+        product.description = initialDescription
+
+        Spree::Config[:show_raw_product_description] = true
+        description = product_description(product)
+        expect(description).to eq(initialDescription)
+      end
+
+    end
+
+    shared_examples_for "line item descriptions" do
+      context 'variant has a blank description' do
+        let(:description) { nil }
+        it { is_expected.to eq(Spree.t(:product_has_no_description)) }
+      end
+      context 'variant has a description' do
+        let(:description) { 'test_desc' }
+        it { is_expected.to eq(description) }
+      end
+      context 'description has nonbreaking spaces' do
+        let(:description) { 'test&nbsp;desc' }
+        it { is_expected.to eq('test desc') }
+      end
+    end
+
+    context "#line_item_description" do
+      let(:variant) { create(:variant, :product => product, description: description) }
+      subject { line_item_description_text(variant.product.description) }
+
+      it_should_behave_like "line item descriptions"
+    end
+
+    context '#line_item_description_text' do
+      subject { line_item_description_text description }
+
+      it_should_behave_like "line item descriptions"
+    end
+
+    context '#cache_key_for_products' do
+      subject { helper.cache_key_for_products }
+      before(:each) do
+        @products = double('products collection')
+        allow(helper).to receive(:params) { {:page => 10} }
+      end
+
+      context 'when there is a maximum updated date' do
+        let(:updated_at) { Date.new(2011, 12, 13) }
+        before :each do
+          allow(@products).to receive(:count) { 5 }
+          allow(@products).to receive(:maximum).with(:updated_at) { updated_at }
+        end
+
+        it { is_expected.to eq('en/USD/spree/products/all-10-20111213-5') }
+      end
+
+      context 'when there is no considered maximum updated date' do
+        let(:today) { Date.new(2013, 12, 11) }
+        before :each do
+          allow(@products).to receive(:count) { 1234567 }
+          allow(@products).to receive(:maximum).with(:updated_at) { nil }
+          allow(Date).to receive(:today) { today }
+        end
+
+        it { is_expected.to eq('en/USD/spree/products/all-10-20131211-1234567') }
+      end
+    end
+  end
+end