solidus_core 1.0.2 → 1.0.3

data/spec/lib/tasks/migrations/copy_shipped_shipments_to_cartons_spec.rb

@@ -0,0 +1,115 @@
+require 'spec_helper'
+
+describe 'spree:migrations:copy_shipped_shipments_to_cartons' do
+  before do
+    Rails.application.load_tasks
+    task.reenable
+  end
+
+  describe 'up' do
+    let(:task) do
+      Rake::Task['spree:migrations:copy_shipped_shipments_to_cartons:up']
+    end
+
+    # should generate a carton
+    let!(:shipped_shipment) { shipped_order.shipments.first }
+    # should not generate a carton because it's not shipped
+    let!(:unshipped_shipment) { create(:shipment) }
+    # should not generate a carton because it has no inventory units
+    let!(:shipped_shipment_without_units) do
+      shipped_order_without_units.shipments.first
+    end
+    # should not generate a carton because it already has a carton
+    let!(:shipped_and_cartonized_shipment) do
+      shipped_and_cartonized_order.shipments.first
+    end
+
+    let(:shipped_order) { create(:shipped_order, line_items_count: 1, with_cartons: false) }
+
+    let(:shipped_order_without_units) do
+      create(:shipped_order, line_items_count: 1) do |order|
+        order.inventory_units.delete_all
+      end
+    end
+
+    let(:shipped_and_cartonized_order) do
+      create(:order_ready_to_ship, line_items_count: 1).tap do |order|
+        order.shipping.ship_shipment(order.shipments.first)
+      end
+    end
+
+    it 'creates the expected carton' do
+      expect {
+        task.invoke
+      }.to change { Spree::Carton.count }.by(1)
+
+      carton = Spree::Carton.last
+
+      expect(carton).to be_valid
+
+      expect(carton.imported_from_shipment_id).to eq shipped_shipment.id
+      expect(carton.orders).to eq [shipped_order]
+
+      expect(carton.number).to eq "C#{shipped_shipment.number}"
+      expect(carton.stock_location).to eq shipped_shipment.stock_location
+      expect(carton.address).to eq shipped_shipment.address
+      expect(carton.shipping_method).to eq shipped_shipment.shipping_method
+      expect(carton.tracking).to eq shipped_shipment.tracking
+      expect(carton.shipped_at).to eq shipped_shipment.shipped_at
+      expect(carton.created_at).to be_present
+      expect(carton.updated_at).to be_present
+
+      expect(carton.inventory_units).to match_array shipped_shipment.inventory_units
+    end
+
+    describe 'when run a second time' do
+      before do
+        task.invoke
+        task.reenable
+      end
+
+      let!(:second_shipped_shipment) { second_shipped_order.shipments.first }
+
+      let(:second_shipped_order) { create(:shipped_order, line_items_count: 1, with_cartons: false) }
+
+      it 'creates only a carton for the second shipment' do
+        expect {
+          task.invoke
+        }.to change { Spree::Carton.count }.by(1)
+
+        carton = Spree::Carton.last
+
+        expect(carton.imported_from_shipment_id).to eq second_shipped_shipment.id
+        expect(carton.orders).to eq [second_shipped_order]
+      end
+    end
+  end
+
+  describe 'down' do
+    let(:task) do
+      Rake::Task['spree:migrations:copy_shipped_shipments_to_cartons:down']
+    end
+
+    let!(:migrated_carton) { create(:carton) }
+    let!(:preexisting_carton) { create(:carton) }
+
+    let!(:migrated_carton_inventory_units) { migrated_carton.inventory_units.to_a }
+    let!(:preexisting_carton_inventory_units) { preexisting_carton.inventory_units.to_a }
+
+    before do
+      migrated_carton.update!(imported_from_shipment_id: migrated_carton.inventory_units.first.shipment_id)
+    end
+
+    it 'clears out the correct carton' do
+      expect {
+        task.invoke
+      }.to change { Spree::Carton.count }.by(-1)
+
+      expect(Spree::Carton.find_by(id: migrated_carton.id)).to be_nil
+
+      expect(migrated_carton_inventory_units.map(&:reload).map(&:carton_id)).to all(be_nil)
+      expect(preexisting_carton_inventory_units.map(&:reload).map(&:carton_id)).to all(eq preexisting_carton.id)
+    end
+  end
+
+end

data/spec/lib/tasks/order_capturing_spec.rb

@@ -0,0 +1,56 @@
+require 'spec_helper'
+
+describe "order_capturing:capture_payments" do
+  let(:task) do
+    Rake::Task['order_capturing:capture_payments']
+  end
+
+  before do
+    Rails.application.load_tasks
+    task.reenable
+  end
+
+  subject { task }
+
+  describe '#prerequisites' do
+    subject { super().prerequisites }
+    it { is_expected.to include("environment") }
+  end
+  let(:order) { create(:completed_order_with_pending_payment, line_items_count: 2) }
+  let(:payment) { order.payments.first }
+
+  context "with a mix of canceled and shipped inventory" do
+    before do
+      Spree::OrderCancellations.new(order).short_ship([order.inventory_units.first])
+      order.shipping.ship_shipment(order.shipments.first)
+      order.update_attributes!(payment_state: 'balance_due')
+    end
+
+    it "charges the order" do
+      expect(order.inventory_units.any?(&:on_hand?)).to eq false
+      expect(order.inventory_units.all? {|iu| iu.canceled? || iu.shipped? }).to eq true
+      expect {
+        expect { subject.invoke }.to change { payment.reload.state }.to('completed')
+      }.to change { order.reload.payment_state }.to('paid')
+    end
+
+    context "when there is an error capturing payment" do
+      before do
+        allow_any_instance_of(Spree::OrderCapturing).to receive(:capture_payments).and_raise(StateMachines::InvalidTransition)
+      end
+
+      it "raises a OrderCapturingFailures" do
+        expect { subject.invoke }.to raise_error(Spree::OrderCapturingFailures)
+      end
+    end
+  end
+
+  context "with any inventory not shipped or canceled" do
+    it "does not charge for the order" do
+      expect(order.inventory_units.any?(&:on_hand?)).to eq true
+      expect {
+        expect { subject.invoke }.not_to change { payment.reload }
+      }.not_to change { order.reload.payment_state }
+    end
+  end
+end

data/spec/mailers/carton_mailer_spec.rb

@@ -0,0 +1,43 @@
+require 'spec_helper'
+require 'email_spec'
+
+describe Spree::CartonMailer do
+  include EmailSpec::Helpers
+  include EmailSpec::Matchers
+
+  let(:carton) { create(:carton) }
+
+  # Regression test for #2196
+  it "doesn't include out of stock in the email body" do
+    shipment_email = Spree::CartonMailer.shipped_email(carton.id)
+    expect(shipment_email.body).not_to include(%Q{Out of Stock})
+  end
+
+  context "with resend option" do
+    subject do
+      Spree::CartonMailer.shipped_email(carton.id, resend: true).subject
+    end
+    it { is_expected.to match /^\[RESEND\] / }
+  end
+
+  context "emails must be translatable" do
+    context "shipped_email" do
+      context "pt-BR locale" do
+        before do
+          pt_br_shipped_email = { :spree => { :shipment_mailer => { :shipped_email => { :dear_customer => 'Caro Cliente,' } } } }
+          I18n.backend.store_translations :'pt-BR', pt_br_shipped_email
+          I18n.locale = :'pt-BR'
+        end
+
+        after do
+          I18n.locale = I18n.default_locale
+        end
+
+        specify do
+          shipped_email = Spree::CartonMailer.shipped_email(carton.id)
+          expect(shipped_email.body).to include("Caro Cliente,")
+        end
+      end
+    end
+  end
+end

data/spec/mailers/order_mailer_spec.rb

@@ -0,0 +1,122 @@
+require 'spec_helper'
+require 'email_spec'
+
+describe Spree::OrderMailer, :type => :mailer do
+  include EmailSpec::Helpers
+  include EmailSpec::Matchers
+
+  let(:order) do
+    order = stub_model(Spree::Order)
+    product = stub_model(Spree::Product, :name => %Q{The "BEST" product})
+    variant = stub_model(Spree::Variant, :product => product)
+    price = stub_model(Spree::Price, :variant => variant, :amount => 5.00)
+    store = FactoryGirl.build :store, mail_from_address: "store@example.com"
+    line_item = stub_model(Spree::LineItem, :variant => variant, :order => order, :quantity => 1, :price => 4.99)
+    allow(variant).to receive_messages(:default_price => price)
+    allow(order).to receive_messages(:line_items => [line_item])
+    allow(order).to receive(:store).and_return(store)
+    order
+  end
+
+  it "uses the order's store for the from address" do
+    message = Spree::OrderMailer.confirm_email(order)
+    expect(message.from).to eq ["store@example.com"]
+  end
+
+  it "doesn't aggressively escape double quotes in confirmation body" do
+    confirmation_email = Spree::OrderMailer.confirm_email(order)
+    expect(confirmation_email.body).not_to include(""")
+  end
+
+  it "confirm_email accepts an order id as an alternative to an Order object" do
+    expect(Spree::Order).to receive(:find).with(order.id).and_return(order)
+    expect {
+      Spree::OrderMailer.confirm_email(order.id).body
+    }.not_to raise_error
+  end
+
+  it "cancel_email accepts an order id as an alternative to an Order object" do
+    expect(Spree::Order).to receive(:find).with(order.id).and_return(order)
+    expect {
+      Spree::OrderMailer.cancel_email(order.id).body
+    }.not_to raise_error
+  end
+
+  context "only shows eligible adjustments in emails" do
+    before do
+      create(:adjustment, :order => order, :eligible => true, :label => "Eligible Adjustment")
+      create(:adjustment, :order => order, :eligible => false, :label => "Ineligible Adjustment")
+    end
+
+    let!(:confirmation_email) { Spree::OrderMailer.confirm_email(order) }
+    let!(:cancel_email) { Spree::OrderMailer.cancel_email(order) }
+
+    specify do
+      expect(confirmation_email.body).not_to include("Ineligible Adjustment")
+    end
+
+    specify do
+      expect(cancel_email.body).not_to include("Ineligible Adjustment")
+    end
+  end
+
+  context "displays unit costs from line item" do
+    # Regression test for #2772
+
+    # Tests mailer view spree/order_mailer/confirm_email.text.erb
+    specify do
+      confirmation_email = Spree::OrderMailer.confirm_email(order)
+      expect(confirmation_email).to have_body_text("4.99")
+      expect(confirmation_email).to_not have_body_text("5.00")
+    end
+
+    # Tests mailer view spree/order_mailer/cancel_email.text.erb
+    specify do
+      cancel_email = Spree::OrderMailer.cancel_email(order)
+      expect(cancel_email).to have_body_text("4.99")
+      expect(cancel_email).to_not have_body_text("5.00")
+    end
+  end
+
+  context "emails must be translatable" do
+
+    context "pt-BR locale" do
+      before do
+        I18n.enforce_available_locales = false
+        pt_br_confirm_mail = { :spree => { :order_mailer => { :confirm_email => { :dear_customer => 'Caro Cliente,' } } } }
+        pt_br_cancel_mail = { :spree => { :order_mailer => { :cancel_email => { :order_summary_canceled => 'Resumo da Pedido [CANCELADA]' } } } }
+        I18n.backend.store_translations :'pt-BR', pt_br_confirm_mail
+        I18n.backend.store_translations :'pt-BR', pt_br_cancel_mail
+        I18n.locale = :'pt-BR'
+      end
+
+      after do
+        I18n.locale = I18n.default_locale
+        I18n.enforce_available_locales = true
+      end
+
+      context "confirm_email" do
+        specify do
+          confirmation_email = Spree::OrderMailer.confirm_email(order)
+          expect(confirmation_email).to have_body_text("Caro Cliente,")
+        end
+      end
+
+      context "cancel_email" do
+        specify do
+          cancel_email = Spree::OrderMailer.cancel_email(order)
+          expect(cancel_email).to have_body_text("Resumo da Pedido [CANCELADA]")
+        end
+      end
+    end
+  end
+
+  context "with preference :send_core_emails set to false" do
+    it "sends no email" do
+      Spree::Config.send_core_emails = false
+      message = Spree::OrderMailer.confirm_email(order)
+      expect(message.body).to be_blank
+    end
+  end
+
+end

data/spec/mailers/reimbursement_mailer_spec.rb

@@ -0,0 +1,40 @@
+require 'spec_helper'
+require 'email_spec'
+
+describe Spree::ReimbursementMailer, :type => :mailer do
+  include EmailSpec::Helpers
+  include EmailSpec::Matchers
+
+  let(:reimbursement) { create(:reimbursement) }
+
+  it "accepts a reimbursement id as an alternative to a Reimbursement object" do
+    expect(Spree::Reimbursement).to receive(:find).with(reimbursement.id).and_return(reimbursement)
+
+    expect {
+      Spree::ReimbursementMailer.reimbursement_email(reimbursement.id).body
+    }.not_to raise_error
+  end
+
+  context "emails must be translatable" do
+    context "reimbursement_email" do
+      context "pt-BR locale" do
+        before do
+          I18n.enforce_available_locales = false
+          pt_br_shipped_email = { :spree => { :reimbursement_mailer => { :reimbursement_email => { :dear_customer => 'Caro Cliente,' } } } }
+          I18n.backend.store_translations :'pt-BR', pt_br_shipped_email
+          I18n.locale = :'pt-BR'
+        end
+
+        after do
+          I18n.locale = I18n.default_locale
+          I18n.enforce_available_locales = true
+        end
+
+        specify do
+          reimbursement_email = Spree::ReimbursementMailer.reimbursement_email(reimbursement)
+          expect(reimbursement_email.body).to include("Caro Cliente,")
+        end
+      end
+    end
+  end
+end

data/spec/mailers/test_mailer_spec.rb

@@ -0,0 +1,15 @@
+require 'spec_helper'
+require 'email_spec'
+
+describe Spree::TestMailer, :type => :mailer do
+  include EmailSpec::Helpers
+  include EmailSpec::Matchers
+
+  let(:user) { create(:user) }
+
+  it "confirm_email accepts a user id as an alternative to a User object" do
+    expect {
+      test_email = Spree::TestMailer.test_email('test@example.com')
+    }.not_to raise_error
+  end
+end

data/spec/models/spree/ability_spec.rb

@@ -0,0 +1,276 @@
+require 'spec_helper'
+require 'cancan/matchers'
+require 'spree/testing_support/ability_helpers'
+require 'spree/testing_support/bar_ability'
+
+# Fake ability for testing registration of additional abilities
+class FooAbility
+  include CanCan::Ability
+
+  def initialize(user)
+    # allow anyone to perform index on Order
+    can :index, Spree::Order
+    # allow anyone to update an Order with id of 1
+    can :update, Spree::Order do |order|
+      order.id == 1
+    end
+  end
+end
+
+describe Spree::Ability, :type => :model do
+  let(:user) { build(:user) }
+  let(:ability) { Spree::Ability.new(user) }
+  let(:token) { nil }
+
+  after(:each) {
+    Spree::Ability.abilities = Set.new
+  }
+
+  describe "#initialize" do
+    subject { Spree::Ability.new(user) }
+
+    it "activates permissions from the role configuration" do
+      expect(Spree::RoleConfiguration.instance).to receive(:activate_permissions!).
+        once
+
+      subject
+    end
+  end
+
+  context 'register_ability' do
+    it 'should add the ability to the list of abilties' do
+      Spree::Ability.register_ability(FooAbility)
+      expect(Spree::Ability.new(user).abilities).not_to be_empty
+    end
+
+    it 'should apply the registered abilities permissions' do
+      Spree::Ability.register_ability(FooAbility)
+      expect(Spree::Ability.new(user).can?(:update, mock_model(Spree::Order, :id => 1))).to be true
+    end
+  end
+
+  context 'for general resource' do
+    let(:resource) { Object.new }
+
+    context 'with admin user' do
+      before(:each) { allow(user).to receive(:has_spree_role?).and_return(true) }
+      it_should_behave_like 'access granted'
+      it_should_behave_like 'index allowed'
+    end
+
+    context 'with customer' do
+      it_should_behave_like 'access denied'
+      it_should_behave_like 'no index allowed'
+    end
+  end
+
+  context 'for admin protected resources' do
+    let(:resource) { Object.new }
+    let(:resource_shipment) { Spree::Shipment.new }
+    let(:resource_product) { Spree::Product.new }
+    let(:resource_user) { create :user }
+    let(:resource_order) { Spree::Order.new }
+    let(:fakedispatch_user) { Spree.user_class.create }
+    let(:fakedispatch_ability) { Spree::Ability.new(fakedispatch_user) }
+
+    context 'with admin user' do
+      it 'should be able to admin' do
+        user.spree_roles << Spree::Role.find_or_create_by(name: 'admin')
+        expect(ability).to be_able_to :admin, resource
+        expect(ability).to be_able_to :index, resource_order
+        expect(ability).to be_able_to :show, resource_product
+        expect(ability).to be_able_to :create, resource_user
+      end
+    end
+
+    context 'with fakedispatch user' do
+      it 'should be able to admin on the order and shipment pages' do
+        user.spree_roles << Spree::Role.find_or_create_by(name: 'bar')
+
+        Spree::Ability.register_ability(BarAbility)
+
+        expect(ability).not_to be_able_to :admin, resource
+
+        expect(ability).to be_able_to :admin, resource_order
+        expect(ability).to be_able_to :index, resource_order
+        expect(ability).not_to be_able_to :update, resource_order
+        # ability.should_not be_able_to :create, resource_order # Fails
+
+        expect(ability).to be_able_to :admin, resource_shipment
+        expect(ability).to be_able_to :index, resource_shipment
+        expect(ability).to be_able_to :create, resource_shipment
+
+        expect(ability).not_to be_able_to :admin, resource_product
+        expect(ability).not_to be_able_to :update, resource_product
+        # ability.should_not be_able_to :show, resource_product # Fails
+
+        expect(ability).not_to be_able_to :admin, resource_user
+        expect(ability).not_to be_able_to :update, resource_user
+        expect(ability).to be_able_to :update, user
+        # ability.should_not be_able_to :create, resource_user # Fails
+        # It can create new users if is has access to the :admin, User!!
+
+        # TODO change the Ability class so only users and customers get the extra premissions?
+
+        Spree::Ability.remove_ability(BarAbility)
+      end
+    end
+
+    context 'with customer' do
+      it 'should not be able to admin' do
+        expect(ability).not_to be_able_to :admin, resource
+        expect(ability).not_to be_able_to :admin, resource_order
+        expect(ability).not_to be_able_to :admin, resource_product
+        expect(ability).not_to be_able_to :admin, resource_user
+      end
+    end
+  end
+
+  context 'as Guest User' do
+
+    context 'for Country' do
+      let(:resource) { Spree::Country.new }
+      context 'requested by any user' do
+        it_should_behave_like 'read only'
+      end
+    end
+
+    context 'for OptionType' do
+      let(:resource) { Spree::OptionType.new }
+      context 'requested by any user' do
+        it_should_behave_like 'read only'
+      end
+    end
+
+    context 'for OptionValue' do
+      let(:resource) { Spree::OptionType.new }
+      context 'requested by any user' do
+        it_should_behave_like 'read only'
+      end
+    end
+
+    context 'for Order' do
+      let(:resource) { Spree::Order.new }
+
+      context 'requested by same user' do
+        before(:each) { resource.user = user }
+        it_should_behave_like 'access granted'
+        it_should_behave_like 'no index allowed'
+      end
+
+      context 'requested by other user' do
+        before(:each) { resource.user = Spree.user_class.new }
+        it_should_behave_like 'create only'
+      end
+
+      context 'requested with proper token' do
+        let(:token) { 'TOKEN123' }
+        before(:each) { allow(resource).to receive_messages guest_token: 'TOKEN123' }
+        it_should_behave_like 'access granted'
+        it_should_behave_like 'no index allowed'
+      end
+
+      context 'requested with inproper token' do
+        let(:token) { 'FAIL' }
+        before(:each) { allow(resource).to receive_messages guest_token: 'TOKEN123' }
+        it_should_behave_like 'create only'
+      end
+    end
+
+    context 'for Product' do
+      let(:resource) { Spree::Product.new }
+      context 'requested by any user' do
+        it_should_behave_like 'read only'
+      end
+    end
+
+    context 'for ProductProperty' do
+      let(:resource) { Spree::Product.new }
+      context 'requested by any user' do
+        it_should_behave_like 'read only'
+      end
+    end
+
+    context 'for Property' do
+      let(:resource) { Spree::Product.new }
+      context 'requested by any user' do
+        it_should_behave_like 'read only'
+      end
+    end
+
+    context 'for State' do
+      let(:resource) { Spree::State.new }
+      context 'requested by any user' do
+        it_should_behave_like 'read only'
+      end
+    end
+
+    context 'for Stock Item' do
+      let(:resource) { Spree::StockItem.new }
+      context 'active stock location' do
+        before { resource.build_stock_location(active: true) }
+        it_should_behave_like 'read only'
+      end
+
+      context 'inactive stock location' do
+        before { resource.build_stock_location(active: false) }
+        it_should_behave_like 'access denied'
+      end
+    end
+
+    context 'for Stock Location' do
+      let(:resource) { Spree::StockLocation.new }
+      context 'active' do
+        before { resource.active = true }
+        it_should_behave_like 'read only'
+      end
+
+      context 'inactive' do
+        before { resource.active = false }
+        it_should_behave_like 'access denied'
+      end
+    end
+
+    context 'for Taxons' do
+      let(:resource) { Spree::Taxon.new }
+      context 'requested by any user' do
+        it_should_behave_like 'read only'
+      end
+    end
+
+    context 'for Taxonomy' do
+      let(:resource) { Spree::Taxonomy.new }
+      context 'requested by any user' do
+        it_should_behave_like 'read only'
+      end
+    end
+
+    context 'for User' do
+      context 'requested by same user' do
+        let(:resource) { user }
+        it_should_behave_like 'access granted'
+        it_should_behave_like 'no index allowed'
+      end
+      context 'requested by other user' do
+        let(:resource) { Spree.user_class.create }
+        it_should_behave_like 'create only'
+      end
+    end
+
+    context 'for Variant' do
+      let(:resource) { Spree::Variant.new }
+      context 'requested by any user' do
+        it_should_behave_like 'read only'
+      end
+    end
+
+    context 'for Zone' do
+      let(:resource) { Spree::Zone.new }
+      context 'requested by any user' do
+        it_should_behave_like 'read only'
+      end
+    end
+
+  end
+
+end