solidus_core 1.0.2 → 1.0.3

data/spec/models/spree/taxon_spec.rb

@@ -0,0 +1,74 @@
+# coding: UTF-8
+
+require 'spec_helper'
+
+describe Spree::Taxon, :type => :model do
+  let(:taxon) { FactoryGirl.build(:taxon, :name => "Ruby on Rails") }
+
+  describe '#to_param' do
+    subject { super().to_param }
+    it { is_expected.to eql taxon.permalink }
+  end
+
+  context "set_permalink" do
+
+    it "should set permalink correctly when no parent present" do
+      taxon.set_permalink
+      expect(taxon.permalink).to eql "ruby-on-rails"
+    end
+
+    it "should support Chinese characters" do
+      taxon.name = "你好"
+      taxon.set_permalink
+      expect(taxon.permalink).to eql 'ni-hao'
+    end
+
+    context "with parent taxon" do
+      let(:parent) { FactoryGirl.build(:taxon, :permalink => "brands") }
+      before       { allow(taxon).to receive_messages parent: parent }
+
+      it "should set permalink correctly when taxon has parent" do
+        taxon.set_permalink
+        expect(taxon.permalink).to eql "brands/ruby-on-rails"
+      end
+
+      it "should set permalink correctly with existing permalink present" do
+        taxon.permalink = "b/rubyonrails"
+        taxon.set_permalink
+        expect(taxon.permalink).to eql "brands/rubyonrails"
+      end
+
+      it "should support Chinese characters" do
+        taxon.name = "我"
+        taxon.set_permalink
+        expect(taxon.permalink).to eql "brands/wo"
+      end
+
+      # Regression test for #3390
+      context "setting a new node sibling position via :child_index=" do
+        let(:idx) { rand(0..100) }
+        before { allow(parent).to receive(:move_to_child_with_index) }
+
+        context "taxon is not new" do
+          before { allow(taxon).to receive(:new_record?).and_return(false) }
+
+          it "passes the desired index move_to_child_with_index of :parent " do
+            expect(taxon).to receive(:move_to_child_with_index).with(parent, idx)
+
+            taxon.child_index = idx
+          end
+        end
+      end
+
+    end
+  end
+
+  # Regression test for #2620
+  context "creating a child node using first_or_create" do
+    let(:taxonomy) { create(:taxonomy) }
+
+    it "does not error out" do
+      expect { taxonomy.root.children.unscoped.where(:name => "Some name").first_or_create }.not_to raise_error
+    end
+  end
+end

data/spec/models/spree/taxonomy_spec.rb

@@ -0,0 +1,18 @@
+require 'spec_helper'
+
+describe Spree::Taxonomy, :type => :model do
+  context "#destroy" do
+    before do
+       @taxonomy = create(:taxonomy)
+       @root_taxon = @taxonomy.root
+       @child_taxon = create(:taxon, :taxonomy_id => @taxonomy.id, :parent => @root_taxon)
+    end
+
+    it "should destroy all associated taxons" do
+      @taxonomy.destroy
+      expect{ Spree::Taxon.find(@root_taxon.id) }.to raise_error(ActiveRecord::RecordNotFound)
+      expect{ Spree::Taxon.find(@child_taxon.id) }.to raise_error(ActiveRecord::RecordNotFound)
+    end
+  end
+end
+

data/spec/models/spree/tracker_spec.rb

@@ -0,0 +1,21 @@
+require 'spec_helper'
+
+describe Spree::Tracker, :type => :model do
+  describe "current" do
+    before(:each) { @tracker = create(:tracker) }
+
+    it "returns the first active tracker for the environment" do
+      expect(Spree::Tracker.current).to eq(@tracker)
+    end
+
+    it "does not return a tracker with a blank analytics_id" do
+      @tracker.update_attribute(:analytics_id, '')
+      expect(Spree::Tracker.current).to be_nil
+    end
+
+    it "does not return an inactive tracker" do
+      @tracker.update_attribute(:active, false)
+      expect(Spree::Tracker.current).to be_nil
+    end
+  end
+end

data/spec/models/spree/transfer_item_spec.rb

@@ -0,0 +1,264 @@
+require 'spec_helper'
+
+describe Spree::TransferItem do
+  let(:stock_location) { create(:stock_location, name: "Warehouse") }
+  let(:stock_transfer) { create(:stock_transfer_with_items, source_location: stock_location) }
+  let(:transfer_item)  { stock_transfer.transfer_items.first }
+
+  subject { transfer_item }
+
+  describe "validation" do
+    before do
+      transfer_item.assign_attributes(expected_quantity: expected_quantity, received_quantity: received_quantity)
+    end
+
+    describe "expected vs received quantity" do
+      context "expected quantity is the same as the received quantity" do
+        let(:expected_quantity) { 1 }
+        let(:received_quantity) { 1 }
+        it { is_expected.to be_valid }
+      end
+
+      context "expected quantity is larger than the received quantity" do
+        let(:expected_quantity) { 3 }
+        let(:received_quantity) { 1 }
+        it { is_expected.to be_valid }
+      end
+
+      context "expected quantity is lower than the received quantity" do
+        let(:expected_quantity) { 1 }
+        let(:received_quantity) { 3 }
+        it { is_expected.to_not be_valid }
+      end
+    end
+
+    describe "numericality" do
+      context "expected_quantity is less than 0" do
+        let(:expected_quantity) { -1 }
+        let(:received_quantity) { 3 }
+        it { is_expected.to_not be_valid }
+      end
+
+      context "received_quantity is less than 0" do
+        let(:expected_quantity) { 1 }
+        let(:received_quantity) { -3 }
+        it { is_expected.to_not be_valid }
+      end
+    end
+
+    describe "availability" do
+      let(:stock_item) do
+        transfer_item.variant.stock_items.find_by(stock_location: stock_transfer.source_location)
+      end
+      let(:expected_quantity) { 1 }
+      let(:received_quantity) { 1 }
+
+      subject { transfer_item.valid? }
+
+      shared_examples_for 'availability check fails' do
+        it "validates the availability" do
+          subject
+          expect(transfer_item.errors.full_messages).to include Spree.t('errors.messages.transfer_item_insufficient_stock')
+        end
+      end
+
+      shared_examples_for 'availability check passes' do
+        it "doesn't validate the availability" do
+          subject
+          expect(transfer_item.errors.full_messages).to_not include Spree.t('errors.messages.transfer_item_insufficient_stock')
+        end
+      end
+
+      context "transfer order is closed" do
+        before do
+          stock_transfer.update_attributes!(closed_at: Time.now)
+        end
+
+        context "variant is not available" do
+          before do
+            stock_item.set_count_on_hand(0)
+          end
+          include_examples 'availability check passes'
+
+          context "stock location doesn't check stock" do
+            before do
+              stock_location.update_attributes!(check_stock_on_transfer: false)
+            end
+            include_examples 'availability check passes'
+          end
+        end
+
+        context "variant available" do
+          before do
+            stock_item.set_count_on_hand(transfer_item.expected_quantity)
+          end
+          include_examples 'availability check passes'
+        end
+
+        context "variant does not exist in stock location" do
+          before do
+            stock_item.destroy
+          end
+          include_examples 'availability check passes'
+        end
+      end
+
+      context "transfer order isn't closed" do
+        before do
+          stock_transfer.update_attributes!(closed_at: nil)
+        end
+
+        context "variant is not available" do
+          before do
+            stock_item.set_count_on_hand(0)
+          end
+          include_examples 'availability check fails'
+
+          context "stock location doesn't check stock" do
+            before do
+              stock_location.update_attributes!(check_stock_on_transfer: false)
+            end
+            include_examples 'availability check passes'
+          end
+        end
+
+        context "variant available" do
+          before do
+            stock_item.set_count_on_hand(transfer_item.expected_quantity)
+          end
+          include_examples 'availability check passes'
+        end
+
+        context "variant does not exist in stock location" do
+          before do
+            stock_item.destroy
+          end
+          include_examples 'availability check fails'
+        end
+      end
+    end
+  end
+
+  describe "received stock transfer guard" do
+    subject { transfer_item.reload.update_attributes(received_quantity: 2) }
+
+    describe "closed stock transfer" do
+      context "stock_transfer is not closed" do
+        before do
+          stock_transfer.update_attributes!(closed_at: nil)
+        end
+
+        it { is_expected.to eq true }
+      end
+
+      context "stock_transfer is closed" do
+        before do
+          stock_transfer.update_attributes!(closed_at: Time.now)
+        end
+
+        it { is_expected.to eq false }
+
+        it "adds an error message" do
+          subject
+          expect(transfer_item.errors.full_messages).to include Spree.t('errors.messages.cannot_modify_transfer_item_closed_stock_transfer')
+        end
+      end
+    end
+  end
+
+  describe "expected quantity update guard" do
+    let(:attrs) { { expected_quantity: 1 } }
+
+    subject { transfer_item.update_attributes(attrs) }
+
+    context "stock transfer is finalized" do
+      before do
+        stock_transfer.update_attributes(finalized_at: Time.now)
+      end
+
+      it "adds an error message" do
+        subject
+        expect(transfer_item.errors.full_messages).to include Spree.t('errors.messages.cannot_update_expected_transfer_item_with_finalized_stock_transfer')
+      end
+
+      context "updating received_quantity" do
+        let(:attrs) { { received_quantity: 1 } }
+
+        it "updates the received quantity successfully" do
+          expect { subject }.to change { transfer_item.received_quantity }.to(1)
+        end
+      end
+    end
+
+    context "stock transfer is not finalized" do
+      before do
+        stock_transfer.update_attributes(finalized_at: nil, shipped_at: nil)
+      end
+
+      it "updates the expected quantity successfully" do
+        expect { subject }.to change { transfer_item.expected_quantity }.to(1)
+      end
+    end
+  end
+
+  describe "destroy finalized stock transfer guard" do
+    subject { transfer_item.destroy }
+
+    context "stock transfer is finalized" do
+      before do
+        stock_transfer.update_attributes(finalized_at: Time.now)
+      end
+
+      it "does not destroy the transfer item" do
+        expect { subject }.to_not change { Spree::TransferItem.count }
+      end
+
+      it "adds an error message" do
+        subject
+        expect(transfer_item.errors.full_messages).to include Spree.t('errors.messages.cannot_delete_transfer_item_with_finalized_stock_transfer')
+      end
+    end
+
+    context "stock transfer is not finalized" do
+      before do
+        stock_transfer.update_attributes(finalized_at: nil, shipped_at: nil)
+      end
+
+      it "destroys the transfer item" do
+        expect { subject }.to change { Spree::TransferItem.count }.by(-1)
+      end
+    end
+
+    context "scopes" do
+      let(:partially_received) { stock_transfer.transfer_items.first }
+      let(:fully_received) { stock_transfer.transfer_items.last }
+      let(:variant) { create(:variant)}
+
+      before do
+        fully_received.update_attributes(expected_quantity: 1, received_quantity: 1)
+        partially_received.update_attributes(expected_quantity: 2, received_quantity: 1)
+
+        stock_transfer.source_location.stock_item(variant).set_count_on_hand(5)
+        stock_transfer.transfer_items.create!(variant: variant, expected_quantity: 1, received_quantity: 0)
+      end
+
+      context '.received' do
+        it 'only returns items that have received quantity greater than 0' do
+          expect(Spree::TransferItem.received).to match_array [fully_received, partially_received]
+        end
+      end
+
+      context '.fully_received' do
+        it 'returns only items that have not been fully received' do
+          expect(Spree::TransferItem.fully_received).to eq [fully_received]
+        end
+      end
+
+      context '.partially_received' do
+        it 'returns only items where received quantity is less that expected' do
+          expect(Spree::TransferItem.partially_received).to eq [partially_received]
+        end
+      end
+    end
+  end
+end

data/spec/models/spree/unit_cancel_spec.rb

@@ -0,0 +1,148 @@
+require 'spec_helper'
+
+describe Spree::UnitCancel do
+  let(:unit_cancel) { Spree::UnitCancel.create!(inventory_unit: inventory_unit, reason: Spree::UnitCancel::SHORT_SHIP) }
+  let(:inventory_unit) { create(:inventory_unit) }
+
+  describe '#adjust!' do
+    subject { unit_cancel.adjust! }
+
+    it "creates an adjustment with the correct attributes" do
+      expect { subject }.to change{ Spree::Adjustment.count }.by(1)
+
+      adjustment = Spree::Adjustment.last
+      expect(adjustment.adjustable).to eq inventory_unit.line_item
+      expect(adjustment.amount).to eq -10.0
+      expect(adjustment.order).to eq inventory_unit.order
+      expect(adjustment.label).to eq "Cancellation - Short Ship"
+      expect(adjustment.eligible).to eq true
+      expect(adjustment.state).to eq 'closed'
+    end
+
+    context "when an adjustment has already been created" do
+      before { unit_cancel.adjust! }
+
+      it "raises" do
+        expect { subject }.to raise_error("Adjustment is already created")
+      end
+    end
+  end
+
+  describe '#compute_amount' do
+    subject { unit_cancel.compute_amount(line_item) }
+
+    let(:line_item) { inventory_unit.line_item }
+    let!(:inventory_unit2) { create(:inventory_unit, line_item: inventory_unit.line_item) }
+
+    context "all inventory on the line item are not canceled" do
+      it "divides the line item total by the inventory units size" do
+        expect(subject).to eq -5.0
+      end
+    end
+
+    context "some inventory on the line item is canceled" do
+      before { inventory_unit2.cancel! }
+
+      it "divides the line item total by the uncanceled units size" do
+        expect(subject).to eq -10.0
+      end
+    end
+
+    context "it is called with a line item that doesnt belong to the inventory unit" do
+      let(:line_item) { create(:line_item) }
+
+      it "raises an error" do
+        expect { subject }.to raise_error RuntimeError
+      end
+    end
+
+    context "when exchanges are present" do
+      let!(:order) { create(:order, ship_address: create(:address)) }
+      let!(:product) { create(:product, price: 10.00) }
+      let!(:variant) do
+        create(:variant, price: 10, product: product, track_inventory: false)
+      end
+      let!(:shipping_method) { create(:free_shipping_method) }
+      let(:exchange_variant) do
+        create(:variant, product: variant.product, price: 10, track_inventory: false)
+      end
+
+      before do
+        @old_expedited_exchanges_value = Spree::Config[:expedited_exchanges]
+        Spree::Config[:expedited_exchanges] = true
+      end
+      after do
+        Spree::Config[:expedited_exchanges] = @old_expedited_exchanges_value
+      end
+
+      # This sets up an order with one shipped inventory unit, one unshipped
+      # inventory unit, and one unshipped exchange inventory unit.
+      before do
+        # Complete an order with 1 line item with quantity=2
+        order.contents.add(variant, 2)
+        order.contents.advance
+        create(:payment, order: order, amount: order.total)
+        order.payments.reload
+        order.complete!
+        order.reload
+
+        # Ship _one_ of the inventory units
+        @shipment = order.shipments.first
+        @shipped_inventory_unit = order.inventory_units[0]
+        @unshipped_inventory_unit = order.inventory_units[1]
+        order.shipping.ship(
+          inventory_units: [@shipped_inventory_unit],
+          stock_location: @shipment.stock_location,
+          address: order.ship_address,
+          shipping_method: @shipment.shipping_method,
+        )
+
+        # Create an expedited exchange for the shipped inventory unit.
+        # This generates a new inventory unit attached to the existing line item.
+        Spree::ReturnAuthorization.create!(
+          order: order,
+          stock_location: @shipment.stock_location,
+          reason: create(:return_reason),
+          return_items: [
+            Spree::ReturnItem.new(
+              inventory_unit: @shipped_inventory_unit,
+              exchange_variant: exchange_variant,
+            ),
+          ],
+        )
+        @exchange_inventory_unit = order.inventory_units.reload[2]
+      end
+
+      context 'when canceling an unshipped inventory unit from the original order' do
+        subject do
+          unit_cancel.compute_amount(@unshipped_inventory_unit.line_item)
+        end
+
+        let(:unit_cancel) do
+          Spree::UnitCancel.create!(
+            inventory_unit: @unshipped_inventory_unit,
+            reason: Spree::UnitCancel::SHORT_SHIP,
+          )
+        end
+
+        it { is_expected.to eq(-10.00) }
+      end
+
+      context 'when canceling an unshipped exchange inventory unit' do
+        subject do
+          unit_cancel.compute_amount(@exchange_inventory_unit.line_item)
+        end
+
+        let(:unit_cancel) do
+          Spree::UnitCancel.create!(
+            inventory_unit: @exchange_inventory_unit,
+            reason: Spree::UnitCancel::SHORT_SHIP,
+          )
+        end
+
+        it { is_expected.to eq(-10.00) }
+      end
+    end
+  end
+
+end