solidus_core 1.0.2 → 1.0.3

data/spec/lib/spree/core/role_configuration_spec.rb

@@ -0,0 +1,138 @@
+require 'spec_helper'
+
+describe Spree::RoleConfiguration do
+  class DummyPermissionSet < Spree::PermissionSets::Base
+    def activate!
+      can :manage, :things
+    end
+  end
+  class OtherDummyPermissionSet < Spree::PermissionSets::Base; end
+
+  let(:instance) { described_class.instance }
+  let!(:default_roles) do
+    Hash.new do |h, name|
+      h[name] = described_class::Role.new(name, Set.new)
+    end
+  end
+
+  describe ".configure" do
+    it "yields with the instance" do
+      expect { |b| described_class.configure &b }.to yield_with_args(described_class.instance)
+    end
+
+    it "only yields once" do
+      expect { |b| described_class.configure &b }.to yield_control.once
+    end
+  end
+
+  describe "#assign_permissions" do
+    let(:name) { "thing" }
+    subject { instance.assign_permissions name, [DummyPermissionSet]}
+
+    after do
+      instance.roles = default_roles
+    end
+
+    context "when a role for the name exists" do
+      before do
+        instance.roles.merge!({ name => described_class::Role.new(name, Set.new(existing_roles)) })
+      end
+
+      context "when adding duplicate permission sets" do
+        let(:existing_roles) { [DummyPermissionSet] }
+
+        it "does not add another role" do
+          expect{subject}.to_not change{instance.roles.count}
+        end
+
+        it "does not add duplicate permission sets" do
+          subject
+          role = instance.roles.values.detect { |r| r.name == name }
+          expect(role.permission_sets).to match_array([DummyPermissionSet])
+        end
+      end
+
+      context "when adding new permission sets to an existing role" do
+        let(:existing_roles) { [OtherDummyPermissionSet] }
+
+        it "does not add another role" do
+          expect{subject}.to_not change{instance.roles.count}
+        end
+
+        it "appends the permission set to the existing role" do
+          subject
+          role = instance.roles.values.detect { |r| r.name == name }
+          expect(role.permission_sets).to match_array([OtherDummyPermissionSet, DummyPermissionSet])
+        end
+      end
+    end
+
+    context "when a role for the name does not yet exist" do
+      it "creates a new role" do
+        expect{subject}.to change{instance.roles.count}.from(0).to(1)
+      end
+
+      it "sets the roles name accordingly" do
+        subject
+        expect(instance.roles.values.first.name).to eql(name)
+      end
+
+      it "sets the permission sets accordingly" do
+        subject
+        expect(instance.roles.values.first.permission_sets).to match_array([DummyPermissionSet])
+      end
+    end
+  end
+
+  describe "#activate_permissions!" do
+    let(:user) { build :user }
+    let(:roles_double) { double pluck: user_roles, any?: true }
+    let(:role_name) { "testrole" }
+    let(:ability) { DummyAbility.new }
+
+    before do
+      allow(user).to receive(:spree_roles).and_return(roles_double)
+      allow(user).to receive(:has_spree_role?).with("admin").and_return(false)
+    end
+
+    after do
+      instance.roles = default_roles
+    end
+
+    subject { described_class.instance.activate_permissions! ability, user }
+
+    context "when the configuration has roles" do
+      before do
+        instance.roles.merge!({ role_name => described_class::Role.new(role_name, [DummyPermissionSet])})
+      end
+
+      context "when the configuration has applicable roles" do
+        let(:user_roles) {[role_name, "someotherrandomrole"]}
+
+        it "activates the applicable permissions on the ability" do
+          expect{subject}.to change{ability.can? :manage, :things}.
+            from(false).
+            to(true)
+        end
+      end
+
+      context "when the configuration does not have applicable roles" do
+        let(:user_roles) {["somerandomrole"]}
+
+        it "doesn't activate non matching roles" do
+          subject
+          expect(ability.can? :manage, :things).to be false
+        end
+      end
+    end
+
+    context "when the configuration does not have roles" do
+      let(:user_roles) {["somerandomrole"]}
+
+      it "doesnt activate any new permissions" do
+        subject
+        expect(ability.can? :manage, :things).to be false
+      end
+    end
+  end
+end

data/spec/lib/spree/core/validators/email_spec.rb

@@ -0,0 +1,48 @@
+require 'spec_helper'
+
+describe EmailValidator do
+
+  class Tester
+    include ActiveModel::Validations
+    attr_accessor :email_address
+    validates :email_address, email: true
+  end
+
+  let(:valid_emails) {[
+    'valid@email.com',
+    'valid@email.com.uk',
+    'e@email.com',
+    'valid+email@email.com',
+    'valid-email@email.com',
+    'valid_email@email.com',
+    'valid.email@email.com'
+  ]}
+  let(:invalid_emails) {[
+    'invalid email@email.com',
+    '.invalid.email@email.com',
+    'invalid.email.@email.com',
+    '@email.com',
+    '.@email.com',
+    'invalidemailemail.com',
+    '@invalid.email@email.com',
+    'invalid@email@email.com',
+    'invalid.email@@email.com'
+  ]}
+
+  it 'validates valid email addresses' do
+    tester = Tester.new
+    valid_emails.each do |email|
+      tester.email_address = email
+      expect(tester.valid?).to be true
+    end
+  end
+
+  it 'validates invalid email addresses' do
+    tester = Tester.new
+    invalid_emails.each do |email|
+      tester.email_address = email
+      expect(tester.valid?).to be false
+    end
+  end
+
+end

data/spec/lib/spree/localized_number_spec.rb

@@ -0,0 +1,38 @@
+require 'spec_helper'
+
+describe Spree::LocalizedNumber do
+
+  context ".parse" do
+    before do
+      I18n.enforce_available_locales = false
+      I18n.locale = I18n.default_locale
+      I18n.backend.store_translations(:de, { :number => { :currency => { :format => { :delimiter => '.', :separator => ',' } } } })
+    end
+
+    after do
+      I18n.locale = I18n.default_locale
+      I18n.enforce_available_locales = true
+    end
+
+    context "with decimal point" do
+      it "captures the proper amount for a formatted price" do
+        expect(subject.class.parse('1,599.99')).to eql 1599.99
+      end
+    end
+
+    context "with decimal comma" do
+      it "captures the proper amount for a formatted price" do
+        I18n.locale = :de
+        expect(subject.class.parse('1.599,99')).to eql 1599.99
+      end
+    end
+
+    context "with a numeric price" do
+      it "uses the price as is" do
+        I18n.locale = :de
+        expect(subject.class.parse(1599.99)).to eql 1599.99
+      end
+    end
+  end
+
+end

data/spec/lib/spree/migrations_spec.rb

@@ -0,0 +1,36 @@
+require 'spec_helper'
+
+module Spree
+  describe Migrations do
+    let(:app_migrations) { [".", "34_add_title.rb", "52_add_text.rb"] }
+    let(:engine_migrations) { [".", "334_create_orders.spree.rb", "777_create_products.spree.rb"] }
+
+    let(:config) { double("Config", root: "dir") }
+
+    let(:engine_dir) { "dir/db/migrate" }
+    let(:app_dir) { "#{Rails.root}/db/migrate" }
+
+    subject { described_class.new(config, "spree")  }
+
+    before do
+      expect(File).to receive(:directory?).with(app_dir).and_return true
+    end
+
+    it "warns about missing migrations" do
+      expect(Dir).to receive(:entries).with(app_dir).and_return app_migrations
+      expect(Dir).to receive(:entries).with(engine_dir).and_return engine_migrations
+
+      silence_stream(STDOUT) {
+        expect(subject.check).to eq true
+      }
+    end
+
+    context "no missing migrations" do
+      it "says nothing" do
+        expect(Dir).to receive(:entries).with(engine_dir).and_return engine_migrations
+        expect(Dir).to receive(:entries).with(app_dir).and_return (app_migrations + engine_migrations)
+        expect(subject.check).to eq nil
+      end
+    end
+  end
+end

data/spec/lib/spree/money_spec.rb

@@ -0,0 +1,127 @@
+# coding: utf-8
+require 'spec_helper'
+
+describe Spree::Money do
+  before do
+    configure_spree_preferences do |config|
+      config.currency = "USD"
+    end
+  end
+
+  it "formats correctly" do
+    money = Spree::Money.new(10)
+    expect(money.to_s).to eq("$10.00")
+  end
+
+  it "can get cents" do
+    money = Spree::Money.new(10)
+    expect(money.cents).to eq(1000)
+  end
+
+  context "with currency" do
+    it "passed in option" do
+      money = Spree::Money.new(10, :with_currency => true, :html => false)
+      expect(money.to_s).to eq("$10.00 USD")
+    end
+  end
+
+  context "hide cents" do
+    it "hides cents suffix" do
+      money = Spree::Money.new(10, no_cents: true)
+      expect(money.to_s).to eq("$10")
+    end
+
+    it "shows cents suffix" do
+      money = Spree::Money.new(10)
+      expect(money.to_s).to eq("$10.00")
+    end
+  end
+
+  context "currency parameter" do
+    context "when currency is specified in Canadian Dollars" do
+      it "uses the currency param over the global configuration" do
+        money = Spree::Money.new(10, :currency => 'CAD', :with_currency => true, :html => false)
+        expect(money.to_s).to eq("$10.00 CAD")
+      end
+    end
+
+    context "when currency is specified in Japanese Yen" do
+      it "uses the currency param over the global configuration" do
+        money = Spree::Money.new(100, :currency => 'JPY', :html => false)
+        expect(money.to_s).to eq("¥100")
+      end
+    end
+  end
+
+  context "symbol positioning" do
+    it "passed in option" do
+      money = Spree::Money.new(10, :symbol_position => :after, :html => false)
+      expect(money.to_s).to eq("10.00 $")
+    end
+
+    it "config option" do
+      money = Spree::Money.new(10, symbol_position: :after, html: false)
+      expect(money.to_s).to eq("10.00 $")
+    end
+  end
+
+  context "sign before symbol" do
+    it "defaults to -$10.00" do
+      money = Spree::Money.new(-10)
+      expect(money.to_s).to eq("-$10.00")
+    end
+
+    it "passed in option" do
+      money = Spree::Money.new(-10, :sign_before_symbol => false)
+      expect(money.to_s).to eq("$-10.00")
+    end
+  end
+
+  context "JPY" do
+    before do
+      configure_spree_preferences do |config|
+        config.currency = "JPY"
+      end
+    end
+
+    it "formats correctly" do
+      money = Spree::Money.new(1000, :html => false)
+      expect(money.to_s).to eq("¥1,000")
+    end
+  end
+
+  context "EUR" do
+    before do
+      configure_spree_preferences do |config|
+        config.currency = "EUR"
+      end
+    end
+
+    # Regression test for #2634
+    it "formats as plain by default" do
+      money = Spree::Money.new(10, symbol_position: :after)
+      expect(money.to_s).to eq("10.00 €")
+    end
+
+    it "formats as HTML if asked (nicely) to" do
+      money = Spree::Money.new(10, symbol_position: :after)
+      # The HTML'ified version of "10.00 €"
+      expect(money.to_html).to eq("10.00 €")
+    end
+
+    it "formats as HTML with currency" do
+      money = Spree::Money.new(10, symbol_position: :after, with_currency: true)
+      # The HTML'ified version of "10.00 €"
+      expect(money.to_html).to eq("10.00&nbsp;&#x20AC; <span class=\"currency\">EUR</span>")
+    end
+  end
+
+  describe "#as_json" do
+    let(:options) { double('options') }
+
+    it "returns the expected string" do
+      money = Spree::Money.new(10)
+      expect(money.as_json(options)).to eq("$10.00")
+    end
+  end
+end

data/spec/lib/tasks/exchanges_spec.rb

@@ -0,0 +1,231 @@
+require 'spec_helper'
+
+describe "exchanges:charge_unreturned_items" do
+  let(:task) do
+    Rake::Task['exchanges:charge_unreturned_items']
+  end
+
+  before do
+    Rails.application.load_tasks
+    task.reenable
+  end
+
+  subject { task }
+
+  describe '#prerequisites' do
+    it { expect(subject.prerequisites).to include("environment") }
+  end
+
+  before do
+    @original_expedited_exchanges_pref = Spree::Config[:expedited_exchanges]
+    Spree::Config[:expedited_exchanges] = true
+    Spree::StockItem.update_all(count_on_hand: 10)
+  end
+
+  after { Spree::Config[:expedited_exchanges] = @original_expedited_exchanges_pref }
+
+  context "there are no unreturned items" do
+    it { expect { subject.invoke }.not_to change { Spree::Order.count } }
+  end
+
+  context "there are return items in an intermediate return status" do
+    let!(:order) { create(:shipped_order, line_items_count: 2) }
+    let(:return_item_1) { build(:exchange_return_item, inventory_unit: order.inventory_units.first) }
+    let(:return_item_2) { build(:exchange_return_item, inventory_unit: order.inventory_units.last) }
+    let!(:rma) { create(:return_authorization, order: order, return_items: [return_item_1, return_item_2]) }
+    let!(:tax_rate) { create(:tax_rate, zone: order.tax_zone, tax_category: return_item_2.exchange_variant.tax_category) }
+    before do
+      rma.save!
+      Spree::Shipment.last.ship!
+      return_item_1.lost!
+      return_item_2.give!
+      Timecop.travel (Spree::Config[:expedited_exchanges_days_window] + 1).days
+    end
+    after { Timecop.return }
+    it { expect { subject.invoke }.not_to change { Spree::Order.count } }
+  end
+
+  context "there are unreturned items" do
+    let!(:order) { create(:shipped_order, line_items_count: 2) }
+    let(:return_item_1) { build(:exchange_return_item, inventory_unit: order.inventory_units.first) }
+    let(:return_item_2) { build(:exchange_return_item, inventory_unit: order.inventory_units.last) }
+    let!(:rma) { create(:return_authorization, order: order, return_items: [return_item_1, return_item_2]) }
+    let!(:tax_rate) { create(:tax_rate, zone: order.tax_zone, tax_category: return_item_2.exchange_variant.tax_category) }
+
+    before do
+      rma.save!
+      Spree::Shipment.last.ship!
+      return_item_1.receive!
+      Timecop.travel travel_time
+    end
+
+    after { Timecop.return }
+
+    context "fewer than the config allowed days have passed" do
+      let(:travel_time) { (Spree::Config[:expedited_exchanges_days_window] - 1).days }
+
+      it "does not create a new order" do
+        expect { subject.invoke }.not_to change { Spree::Order.count }
+      end
+    end
+
+    context "more than the config allowed days have passed" do
+
+      let(:travel_time) { (Spree::Config[:expedited_exchanges_days_window] + 1).days }
+
+      it "creates a new completed order" do
+        expect { subject.invoke }.to change { Spree::Order.count }
+        expect(Spree::Order.last).to be_completed
+      end
+
+      it "sets frontend_viewable to false" do
+        subject.invoke
+        expect(Spree::Order.last).not_to be_frontend_viewable
+      end
+
+      it "moves the shipment for the unreturned items to the new order" do
+        subject.invoke
+        new_order = Spree::Order.last
+        expect(new_order.shipments.count).to eq 1
+        expect(return_item_2.reload.exchange_shipment.order).to eq Spree::Order.last
+      end
+
+      it "creates line items on the order for the unreturned items" do
+        subject.invoke
+        expect(Spree::Order.last.line_items.map(&:variant)).to eq [return_item_2.exchange_variant]
+      end
+
+      it "associates the exchanges inventory units with the new line items" do
+        subject.invoke
+        expect(return_item_2.reload.exchange_inventory_unit.try(:line_item).try(:order)).to eq Spree::Order.last
+      end
+
+      it "uses the credit card from the previous order" do
+        subject.invoke
+        new_order = Spree::Order.last
+        expect(new_order.credit_cards).to be_present
+        expect(new_order.credit_cards.first).to eq order.valid_credit_cards.first
+      end
+
+      context "payments" do
+        it "authorizes the order for the full amount of the unreturned items including taxes" do
+          expect { subject.invoke }.to change { Spree::Payment.count }.by(1)
+          new_order = Spree::Order.last
+          expected_amount = return_item_2.reload.exchange_variant.price + new_order.additional_tax_total + new_order.included_tax_total + new_order.shipment_total
+          expect(new_order.total).to eq expected_amount
+          payment = new_order.payments.first
+          expect(payment.amount).to eq expected_amount
+          expect(new_order.item_total).to eq return_item_2.reload.exchange_variant.price
+        end
+
+        context "auto_capture_exchanges is true" do
+          before do
+            @original_auto_capture_exchanges = Spree::Config[:auto_capture_exchanges]
+            Spree::Config[:auto_capture_exchanges] = true
+          end
+
+          after { Spree::Config[:auto_capture_exchanges] = @original_auto_capture_exchanges }
+
+          it 'creates a pending payment' do
+            expect { subject.invoke }.to change { Spree::Payment.count }.by(1)
+            payment = Spree::Payment.last
+            expect(payment).to be_completed
+          end
+        end
+
+        context "auto_capture_exchanges is false" do
+          before do
+            @original_auto_capture_exchanges = Spree::Config[:auto_capture_exchanges]
+            Spree::Config[:auto_capture_exchanges] = false
+          end
+
+          after { Spree::Config[:auto_capture_exchanges] = @original_auto_capture_exchanges }
+
+          it 'captures payment' do
+            expect { subject.invoke }.to change { Spree::Payment.count }.by(1)
+            payment = Spree::Payment.last
+            expect(payment).to be_pending
+          end
+        end
+      end
+
+      it "does not attempt to create a new order for the item more than once" do
+        subject.invoke
+        subject.reenable
+        expect { subject.invoke }.not_to change { Spree::Order.count }
+      end
+
+      it "associates the store of the original order with the exchange order" do
+        store = order.store
+        expect(Spree::Order).to receive(:create!).once.with(hash_including({store_id: store.id})).and_call_original
+        subject.invoke
+      end
+
+      it 'approves the order' do
+        subject.invoke
+        new_order = Spree::Order.last
+        expect(new_order).to be_approved
+        expect(new_order.is_risky?).to eq false
+        expect(new_order.approver_name).to eq "Spree::UnreturnedItemCharger"
+        expect(new_order.approver).to be nil
+      end
+
+      context "there is no card from the previous order" do
+        let!(:credit_card) { create(:credit_card, user: order.user, default: true, gateway_customer_profile_id: "BGS-123") }
+        before { allow_any_instance_of(Spree::Order).to receive(:valid_credit_cards) { [] } }
+
+        it "attempts to use the user's default card" do
+          expect { subject.invoke }.to change { Spree::Payment.count }.by(1)
+          new_order = Spree::Order.last
+          expect(new_order.credit_cards).to be_present
+          expect(new_order.credit_cards.first).to eq credit_card
+        end
+      end
+
+      context "it is unable to authorize the credit card" do
+        before { allow_any_instance_of(Spree::Payment).to receive(:authorize!).and_raise(RuntimeError) }
+
+        it "raises an error with the order" do
+          expect { subject.invoke }.to raise_error(Spree::ChargeUnreturnedItemsFailures)
+        end
+      end
+
+      context "the exchange inventory unit is not shipped" do
+        before { return_item_2.reload.exchange_inventory_unit.update_columns(state: "on hand") }
+        it "does not create a new order" do
+          expect { subject.invoke }.not_to change { Spree::Order.count }
+        end
+      end
+
+      context "the exchange inventory unit has been returned" do
+        before { return_item_2.reload.exchange_inventory_unit.update_columns(state: "returned") }
+        it "does not create a new order" do
+          expect { subject.invoke }.not_to change { Spree::Order.count }
+        end
+      end
+
+      context 'rma for unreturned exchanges' do
+        context 'config to not create' do
+          before { Spree::Config[:create_rma_for_unreturned_exchange] = false }
+
+          it 'does not create rma' do
+            expect { subject.invoke }.not_to change { Spree::ReturnAuthorization.count }
+          end
+        end
+
+        context 'config to create' do
+          before do
+            Spree::Config[:create_rma_for_unreturned_exchange] = true
+          end
+
+          it 'creates with return items' do
+            expect { subject.invoke }.to change { Spree::ReturnAuthorization.count }
+            rma = Spree::ReturnAuthorization.last
+
+            expect(rma.return_items.all?(&:awaiting?)).to be true
+          end
+        end
+      end
+    end
+  end
+end