shipit-engine 0.28.1 → 0.33.0

Sign up to get free protection for your applications and to get access to all the features.
Files changed (410) hide show
  1. checksums.yaml +4 -4
  2. data/README.md +41 -2
  3. data/Rakefile +4 -2
  4. data/app/assets/images/archive-solid.svg +1 -0
  5. data/app/assets/images/magic-solid.svg +1 -0
  6. data/app/assets/javascripts/shipit/repositories_search.js.coffee +60 -0
  7. data/app/assets/javascripts/shipit/{search.js.coffee → stack_search.js.coffee} +0 -0
  8. data/app/assets/stylesheets/_pages/_repositories.scss +148 -0
  9. data/app/assets/stylesheets/_pages/_stacks.scss +95 -3
  10. data/app/assets/stylesheets/merge_status.scss +0 -3
  11. data/app/assets/stylesheets/shipit.scss +1 -0
  12. data/app/controllers/concerns/shipit/active_model_serializers_patch.rb +13 -0
  13. data/app/controllers/concerns/shipit/api/cacheable.rb +1 -0
  14. data/app/controllers/concerns/shipit/api/paginable.rb +3 -2
  15. data/app/controllers/concerns/shipit/api/rendering.rb +5 -4
  16. data/app/controllers/concerns/shipit/authentication.rb +3 -2
  17. data/app/controllers/concerns/shipit/pagination.rb +2 -1
  18. data/app/controllers/shipit/api/base_controller.rb +11 -6
  19. data/app/controllers/shipit/api/ccmenu_controller.rb +2 -1
  20. data/app/controllers/shipit/api/commits_controller.rb +2 -1
  21. data/app/controllers/shipit/api/deploys_controller.rb +4 -3
  22. data/app/controllers/shipit/api/hooks_controller.rb +6 -5
  23. data/app/controllers/shipit/api/locks_controller.rb +5 -4
  24. data/app/controllers/shipit/api/merge_requests_controller.rb +37 -0
  25. data/app/controllers/shipit/api/outputs_controller.rb +2 -1
  26. data/app/controllers/shipit/api/release_statuses_controller.rb +3 -2
  27. data/app/controllers/shipit/api/rollbacks_controller.rb +33 -0
  28. data/app/controllers/shipit/api/stacks_controller.rb +50 -5
  29. data/app/controllers/shipit/api/tasks_controller.rb +6 -5
  30. data/app/controllers/shipit/api_clients_controller.rb +50 -0
  31. data/app/controllers/shipit/ccmenu_url_controller.rb +4 -3
  32. data/app/controllers/shipit/commit_checks_controller.rb +2 -1
  33. data/app/controllers/shipit/commits_controller.rb +2 -1
  34. data/app/controllers/shipit/deploys_controller.rb +5 -4
  35. data/app/controllers/shipit/github_authentication_controller.rb +4 -3
  36. data/app/controllers/shipit/merge_requests_controller.rb +31 -0
  37. data/app/controllers/shipit/merge_status_controller.rb +33 -28
  38. data/app/controllers/shipit/release_statuses_controller.rb +3 -2
  39. data/app/controllers/shipit/repositories_controller.rb +74 -0
  40. data/app/controllers/shipit/rollbacks_controller.rb +3 -2
  41. data/app/controllers/shipit/shipit_controller.rb +2 -1
  42. data/app/controllers/shipit/stacks_controller.rb +78 -14
  43. data/app/controllers/shipit/status_controller.rb +2 -1
  44. data/app/controllers/shipit/tasks_controller.rb +9 -8
  45. data/app/controllers/shipit/webhooks_controller.rb +5 -132
  46. data/app/helpers/shipit/chunks_helper.rb +3 -2
  47. data/app/helpers/shipit/deploys_helper.rb +4 -3
  48. data/app/helpers/shipit/github_url_helper.rb +9 -0
  49. data/app/helpers/shipit/merge_status_helper.rb +1 -0
  50. data/app/helpers/shipit/shipit_helper.rb +1 -0
  51. data/app/helpers/shipit/stacks_helper.rb +9 -0
  52. data/app/helpers/shipit/tasks_helper.rb +1 -0
  53. data/app/jobs/shipit/background_job.rb +4 -0
  54. data/app/jobs/shipit/background_job/unique.rb +4 -1
  55. data/app/jobs/shipit/cache_deploy_spec_job.rb +1 -0
  56. data/app/jobs/shipit/chunk_rollup_job.rb +4 -0
  57. data/app/jobs/shipit/clear_git_cache_job.rb +1 -0
  58. data/app/jobs/shipit/continuous_delivery_job.rb +3 -1
  59. data/app/jobs/shipit/create_on_github_job.rb +7 -1
  60. data/app/jobs/shipit/create_release_statuses_job.rb +1 -0
  61. data/app/jobs/shipit/deferred_touch_job.rb +4 -0
  62. data/app/jobs/shipit/deliver_hook_job.rb +1 -0
  63. data/app/jobs/shipit/destroy_job.rb +1 -0
  64. data/app/jobs/shipit/destroy_repository_job.rb +24 -0
  65. data/app/jobs/shipit/destroy_stack_job.rb +5 -4
  66. data/app/jobs/shipit/emit_event_job.rb +2 -1
  67. data/app/jobs/shipit/fetch_commit_stats_job.rb +1 -0
  68. data/app/jobs/shipit/fetch_deployed_revision_job.rb +1 -0
  69. data/app/jobs/shipit/github_sync_job.rb +2 -1
  70. data/app/jobs/shipit/{mark_deploy_healty_job.rb → mark_deploy_healthy_job.rb} +1 -0
  71. data/app/jobs/shipit/perform_commit_checks_job.rb +1 -0
  72. data/app/jobs/shipit/perform_task_job.rb +5 -90
  73. data/app/jobs/shipit/process_merge_requests_job.rb +32 -0
  74. data/app/jobs/shipit/purge_old_deliveries_job.rb +1 -0
  75. data/app/jobs/shipit/reap_dead_tasks_job.rb +21 -0
  76. data/app/jobs/shipit/refresh_check_runs_job.rb +1 -0
  77. data/app/jobs/shipit/refresh_github_user_job.rb +1 -0
  78. data/app/jobs/shipit/refresh_merge_request_job.rb +11 -0
  79. data/app/jobs/shipit/refresh_statuses_job.rb +1 -0
  80. data/app/jobs/shipit/setup_github_hook_job.rb +1 -0
  81. data/app/jobs/shipit/update_estimated_deploy_duration_job.rb +1 -0
  82. data/app/jobs/shipit/update_github_last_deployed_ref_job.rb +4 -3
  83. data/app/models/concerns/shipit/deferred_touch.rb +4 -3
  84. data/app/models/shipit/anonymous_user.rb +9 -0
  85. data/app/models/shipit/api_client.rb +3 -2
  86. data/app/models/shipit/application_record.rb +2 -1
  87. data/app/models/shipit/check_run.rb +5 -4
  88. data/app/models/shipit/command_line_user.rb +5 -0
  89. data/app/models/shipit/commit.rb +41 -22
  90. data/app/models/shipit/commit_checks.rb +2 -0
  91. data/app/models/shipit/commit_deployment.rb +17 -12
  92. data/app/models/shipit/commit_deployment_status.rb +8 -3
  93. data/app/models/shipit/commit_message.rb +1 -0
  94. data/app/models/shipit/delivery.rb +4 -3
  95. data/app/models/shipit/deploy.rb +41 -10
  96. data/app/models/shipit/deploy_spec.rb +38 -7
  97. data/app/models/shipit/deploy_spec/bundler_discovery.rb +2 -1
  98. data/app/models/shipit/deploy_spec/capistrano_discovery.rb +1 -0
  99. data/app/models/shipit/deploy_spec/file_system.rb +20 -7
  100. data/app/models/shipit/deploy_spec/kubernetes_discovery.rb +1 -0
  101. data/app/models/shipit/deploy_spec/lerna_discovery.rb +1 -0
  102. data/app/models/shipit/deploy_spec/npm_discovery.rb +5 -4
  103. data/app/models/shipit/deploy_spec/pypi_discovery.rb +1 -0
  104. data/app/models/shipit/deploy_spec/rubygems_discovery.rb +1 -0
  105. data/app/models/shipit/deploy_stats.rb +58 -0
  106. data/app/models/shipit/duration.rb +3 -2
  107. data/app/models/shipit/ephemeral_commit_checks.rb +1 -0
  108. data/app/models/shipit/github_hook.rb +2 -1
  109. data/app/models/shipit/github_status.rb +2 -1
  110. data/app/models/shipit/hook.rb +8 -5
  111. data/app/models/shipit/membership.rb +3 -2
  112. data/app/models/shipit/merge_request.rb +302 -0
  113. data/app/models/shipit/output_chunk.rb +7 -2
  114. data/app/models/shipit/provisioning_handler.rb +32 -0
  115. data/app/models/shipit/provisioning_handler/base.rb +30 -0
  116. data/app/models/shipit/provisioning_handler/unregistered_provisioning_handler.rb +35 -0
  117. data/app/models/shipit/pull_request.rb +27 -260
  118. data/app/models/shipit/pull_request_assignment.rb +10 -0
  119. data/app/models/shipit/record.rb +18 -0
  120. data/app/models/shipit/release_status.rb +3 -2
  121. data/app/models/shipit/repository.rb +97 -0
  122. data/app/models/shipit/review_stack.rb +116 -0
  123. data/app/models/shipit/review_stack_provisioning_queue.rb +39 -0
  124. data/app/models/shipit/rollback.rb +1 -0
  125. data/app/models/shipit/stack.rb +130 -57
  126. data/app/models/shipit/status.rb +3 -2
  127. data/app/models/shipit/status/common.rb +7 -6
  128. data/app/models/shipit/status/group.rb +1 -0
  129. data/app/models/shipit/status/missing.rb +2 -1
  130. data/app/models/shipit/status/unknown.rb +2 -1
  131. data/app/models/shipit/task.rb +118 -14
  132. data/app/models/shipit/task_definition.rb +1 -0
  133. data/app/models/shipit/task_execution_strategy/base.rb +20 -0
  134. data/app/models/shipit/task_execution_strategy/default.rb +110 -0
  135. data/app/models/shipit/team.rb +2 -1
  136. data/app/models/shipit/undeployed_commit.rb +1 -0
  137. data/app/models/shipit/unlimited_api_client.rb +1 -0
  138. data/app/models/shipit/user.rb +15 -8
  139. data/app/models/shipit/variable_definition.rb +1 -0
  140. data/app/models/shipit/webhooks.rb +43 -0
  141. data/app/models/shipit/webhooks/handlers/check_suite_handler.rb +20 -0
  142. data/app/models/shipit/webhooks/handlers/handler.rb +41 -0
  143. data/app/models/shipit/webhooks/handlers/membership_handler.rb +46 -0
  144. data/app/models/shipit/webhooks/handlers/pull_request/assigned_handler.rb +74 -0
  145. data/app/models/shipit/webhooks/handlers/pull_request/closed_handler.rb +68 -0
  146. data/app/models/shipit/webhooks/handlers/pull_request/edited_handler.rb +74 -0
  147. data/app/models/shipit/webhooks/handlers/pull_request/label_capturing_handler.rb +127 -0
  148. data/app/models/shipit/webhooks/handlers/pull_request/labeled_handler.rb +106 -0
  149. data/app/models/shipit/webhooks/handlers/pull_request/opened_handler.rb +83 -0
  150. data/app/models/shipit/webhooks/handlers/pull_request/reopened_handler.rb +88 -0
  151. data/app/models/shipit/webhooks/handlers/pull_request/review_stack_adapter.rb +103 -0
  152. data/app/models/shipit/webhooks/handlers/pull_request/unlabeled_handler.rb +107 -0
  153. data/app/models/shipit/webhooks/handlers/push_handler.rb +21 -0
  154. data/app/models/shipit/webhooks/handlers/status_handler.rb +27 -0
  155. data/app/serializers/concerns/shipit/conditional_attributes.rb +1 -0
  156. data/app/serializers/shipit/anonymous_user_serializer.rb +1 -0
  157. data/app/serializers/shipit/command_line_user_serializer.rb +1 -0
  158. data/app/serializers/shipit/commit_serializer.rb +1 -0
  159. data/app/serializers/shipit/deploy_serializer.rb +8 -1
  160. data/app/serializers/shipit/hook_serializer.rb +1 -0
  161. data/app/serializers/shipit/merge_request_serializer.rb +21 -0
  162. data/app/serializers/shipit/pull_request_serializer.rb +6 -8
  163. data/app/serializers/shipit/review_stack_serializer.rb +7 -0
  164. data/app/serializers/shipit/rollback_serializer.rb +1 -0
  165. data/app/serializers/shipit/short_commit_serializer.rb +1 -0
  166. data/app/serializers/shipit/stack_serializer.rb +12 -5
  167. data/app/serializers/shipit/tail_task_serializer.rb +11 -2
  168. data/app/serializers/shipit/task_serializer.rb +2 -17
  169. data/app/serializers/shipit/user_serializer.rb +6 -1
  170. data/app/validators/ascii_only_validator.rb +4 -3
  171. data/app/validators/subset_validator.rb +1 -0
  172. data/app/views/layouts/_head.html.erb +0 -0
  173. data/app/views/layouts/shipit.html.erb +5 -3
  174. data/app/views/shipit/_variables.html.erb +1 -1
  175. data/app/views/shipit/api_clients/index.html.erb +36 -0
  176. data/app/views/shipit/api_clients/new.html.erb +33 -0
  177. data/app/views/shipit/api_clients/show.html.erb +35 -0
  178. data/app/views/shipit/ccmenu/project.xml.builder +2 -1
  179. data/app/views/shipit/deploys/show.html.erb +2 -2
  180. data/app/views/shipit/merge_requests/_merge_request.html.erb +29 -0
  181. data/app/views/shipit/{pull_requests → merge_requests}/index.html.erb +2 -2
  182. data/app/views/shipit/merge_requests/merge_requests/_pull_request.html.erb +29 -0
  183. data/app/views/shipit/merge_requests/merge_requests/index.html.erb +20 -0
  184. data/app/views/shipit/merge_status/_merge_queue_button.html.erb +3 -3
  185. data/app/views/shipit/merge_status/backlogged.html.erb +1 -1
  186. data/app/views/shipit/merge_status/failure.html.erb +1 -1
  187. data/app/views/shipit/merge_status/locked.html.erb +1 -1
  188. data/app/views/shipit/merge_status/logged_out.erb +1 -1
  189. data/app/views/shipit/merge_status/success.html.erb +2 -2
  190. data/app/views/shipit/repositories/_header.html.erb +19 -0
  191. data/app/views/shipit/repositories/index.html.erb +31 -0
  192. data/app/views/shipit/repositories/new.html.erb +23 -0
  193. data/app/views/shipit/repositories/settings.html.erb +53 -0
  194. data/app/views/shipit/repositories/show.html.erb +30 -0
  195. data/app/views/shipit/stacks/_banners.html.erb +13 -0
  196. data/app/views/shipit/stacks/_header.html.erb +30 -12
  197. data/app/views/shipit/stacks/_links.html.erb +1 -0
  198. data/app/views/shipit/stacks/_stack.html.erb +8 -0
  199. data/app/views/shipit/stacks/all_tasks.html.erb +28 -0
  200. data/app/views/shipit/stacks/index.html.erb +9 -3
  201. data/app/views/shipit/stacks/settings.html.erb +22 -3
  202. data/app/views/shipit/stacks/show.html.erb +1 -1
  203. data/app/views/shipit/stacks/statistics.html.erb +82 -0
  204. data/app/views/shipit/tasks/_task_output.html.erb +1 -1
  205. data/app/views/shipit/tasks/show.html.erb +1 -1
  206. data/config/initializers/inflections.rb +2 -1
  207. data/config/locales/en.yml +18 -5
  208. data/config/routes.rb +29 -7
  209. data/db/migrate/20191209231045_create_shipit_repositories.rb +12 -0
  210. data/db/migrate/20191209231307_add_repository_reference_to_stacks.rb +15 -0
  211. data/db/migrate/20191216162728_backfill_repository_data.rb +22 -0
  212. data/db/migrate/20191216163010_remove_repository_information_from_stacks.rb +20 -0
  213. data/db/migrate/20191219205202_add_archived_since_to_stacks.rb +6 -0
  214. data/db/migrate/20200102175621_optional_task_commits.rb +6 -0
  215. data/db/migrate/20200109132519_add_sha_to_commit_deployments.rb +5 -0
  216. data/db/migrate/20200226211925_add_index_to_tasks_status.rb +5 -0
  217. data/db/migrate/20200427135152_add_pull_request_head_sha_to_commit.rb +5 -0
  218. data/db/migrate/20200615181558_add_rollback_once_aborted_to.rb +5 -0
  219. data/db/migrate/20200706145406_add_review_stacks.rb +12 -0
  220. data/db/migrate/20200804144639_rename_pull_request_to_merge_request.rb +7 -0
  221. data/db/migrate/20200804161512_rename_commits_pull_request_id_to_merge_request_id.rb +5 -0
  222. data/db/migrate/20200813134712_recreate_shipit_pull_requests.rb +22 -0
  223. data/db/migrate/20200813194056_create_pull_request_assignments.rb +8 -0
  224. data/db/migrate/20201001125502_add_provision_pr_stacks_flag_to_repositories.rb +7 -0
  225. data/db/migrate/20201008145809_add_retry_attempt_to_tasks.rb +5 -0
  226. data/db/migrate/20201008152744_add_max_retries_to_tasks.rb +5 -0
  227. data/lib/shipit.rb +23 -3
  228. data/lib/shipit/cast_value.rb +1 -0
  229. data/lib/shipit/command.rb +14 -18
  230. data/lib/shipit/commands.rb +5 -4
  231. data/lib/shipit/csv_serializer.rb +1 -0
  232. data/lib/shipit/deploy_commands.rb +1 -0
  233. data/lib/shipit/engine.rb +11 -2
  234. data/lib/shipit/environment_variables.rb +11 -1
  235. data/lib/shipit/first_parent_commits_iterator.rb +1 -0
  236. data/lib/shipit/flock.rb +1 -0
  237. data/lib/shipit/github_app.rb +41 -10
  238. data/lib/shipit/github_http_cache_middleware.rb +1 -0
  239. data/lib/shipit/null_serializer.rb +1 -0
  240. data/lib/shipit/octokit_check_runs.rb +3 -2
  241. data/lib/shipit/octokit_iterator.rb +3 -2
  242. data/lib/shipit/paginator.rb +3 -2
  243. data/lib/shipit/review_stack_commands.rb +8 -0
  244. data/lib/shipit/rollback_commands.rb +1 -0
  245. data/lib/shipit/same_site_cookie_middleware.rb +29 -0
  246. data/lib/shipit/simple_message_verifier.rb +1 -0
  247. data/lib/shipit/stack_commands.rb +12 -4
  248. data/lib/shipit/stat.rb +1 -0
  249. data/lib/shipit/task_commands.rb +23 -14
  250. data/lib/shipit/version.rb +2 -1
  251. data/lib/snippets/release-gem +5 -1
  252. data/lib/tasks/cron.rake +13 -2
  253. data/lib/tasks/dev.rake +3 -2
  254. data/lib/tasks/shipit.rake +16 -17
  255. data/lib/tasks/teams.rake +1 -0
  256. data/test/controllers/api/base_controller_test.rb +3 -2
  257. data/test/controllers/api/ccmenu_controller_test.rb +9 -8
  258. data/test/controllers/api/commits_controller_test.rb +3 -2
  259. data/test/controllers/api/deploys_controller_test.rb +15 -14
  260. data/test/controllers/api/hooks_controller_test.rb +8 -7
  261. data/test/controllers/api/locks_controller_test.rb +7 -6
  262. data/test/controllers/api/{pull_requests_controller_test.rb → merge_requests_controller_test.rb} +17 -16
  263. data/test/controllers/api/outputs_controller_test.rb +4 -2
  264. data/test/controllers/api/release_statuses_controller_test.rb +2 -1
  265. data/test/controllers/api/rollback_controller_test.rb +113 -0
  266. data/test/controllers/api/stacks_controller_test.rb +65 -16
  267. data/test/controllers/api/tasks_controller_test.rb +13 -12
  268. data/test/controllers/api_clients_controller_test.rb +104 -0
  269. data/test/controllers/ccmenu_controller_test.rb +4 -3
  270. data/test/controllers/commit_checks_controller_test.rb +4 -3
  271. data/test/controllers/commits_controller_test.rb +3 -2
  272. data/test/controllers/deploys_controller_test.rb +33 -22
  273. data/test/controllers/github_authentication_controller_test.rb +1 -0
  274. data/test/controllers/merge_requests_controller_test.rb +32 -0
  275. data/test/controllers/merge_status_controller_test.rb +27 -9
  276. data/test/controllers/release_statuses_controller_test.rb +3 -2
  277. data/test/controllers/repositories_controller_test.rb +71 -0
  278. data/test/controllers/rollbacks_controller_test.rb +9 -8
  279. data/test/controllers/stacks_controller_test.rb +72 -15
  280. data/test/controllers/status_controller_test.rb +1 -0
  281. data/test/controllers/tasks_controller_test.rb +33 -20
  282. data/test/controllers/webhooks_controller_test.rb +36 -9
  283. data/test/dummy/config/application.rb +7 -2
  284. data/test/dummy/config/environments/development.rb +23 -6
  285. data/test/dummy/config/environments/test.rb +2 -5
  286. data/test/dummy/db/schema.rb +76 -24
  287. data/test/dummy/db/seeds.rb +30 -16
  288. data/test/fixtures/payloads/check_suite_master.json +2 -2
  289. data/test/fixtures/payloads/invalid_pull_request.json +117 -0
  290. data/test/fixtures/payloads/provision_disabled_pull_request.json +454 -0
  291. data/test/fixtures/payloads/pull_request_assigned.json +480 -0
  292. data/test/fixtures/payloads/pull_request_closed.json +454 -0
  293. data/test/fixtures/payloads/pull_request_labeled.json +461 -0
  294. data/test/fixtures/payloads/pull_request_opened.json +454 -0
  295. data/test/fixtures/payloads/pull_request_reopened.json +454 -0
  296. data/test/fixtures/payloads/pull_request_unlabeled.json +454 -0
  297. data/test/fixtures/payloads/pull_request_with_no_repo.json +454 -0
  298. data/test/fixtures/shipit/commit_deployment_statuses.yml +4 -4
  299. data/test/fixtures/shipit/commit_deployments.yml +8 -8
  300. data/test/fixtures/shipit/commits.yml +52 -1
  301. data/test/fixtures/shipit/merge_requests.yml +141 -0
  302. data/test/fixtures/shipit/pull_request_assignments.yml +3 -0
  303. data/test/fixtures/shipit/pull_requests.yml +10 -131
  304. data/test/fixtures/shipit/repositories.yml +28 -0
  305. data/test/fixtures/shipit/stacks.yml +335 -30
  306. data/test/fixtures/shipit/statuses.yml +9 -0
  307. data/test/fixtures/shipit/tasks.yml +69 -3
  308. data/test/fixtures/shipit/users.yml +7 -0
  309. data/test/fixtures/timeout +2 -1
  310. data/test/helpers/api_helper.rb +1 -0
  311. data/test/helpers/fixture_aliases_helper.rb +1 -0
  312. data/test/helpers/hooks_helper.rb +2 -1
  313. data/test/helpers/json_helper.rb +15 -11
  314. data/test/helpers/links_helper.rb +4 -3
  315. data/test/helpers/payloads_helper.rb +5 -0
  316. data/test/helpers/queries_helper.rb +3 -2
  317. data/test/jobs/cache_deploy_spec_job_test.rb +2 -1
  318. data/test/jobs/chunk_rollup_job_test.rb +16 -1
  319. data/test/jobs/deliver_hook_job_test.rb +1 -0
  320. data/test/jobs/destroy_repository_job_test.rb +27 -0
  321. data/test/jobs/destroy_stack_job_test.rb +10 -0
  322. data/test/jobs/emit_event_job_test.rb +2 -1
  323. data/test/jobs/fetch_commit_stats_job_test.rb +1 -0
  324. data/test/jobs/fetch_deployed_revision_job_test.rb +1 -0
  325. data/test/jobs/github_sync_job_test.rb +1 -0
  326. data/test/jobs/mark_deploy_healthy_job_test.rb +1 -0
  327. data/test/jobs/perform_task_job_test.rb +12 -11
  328. data/test/jobs/{merge_pull_requests_job_test.rb → process_merge_requests_job_test.rb} +19 -18
  329. data/test/jobs/purge_old_deliveries_job_test.rb +1 -0
  330. data/test/jobs/reap_dead_tasks_job_test.rb +68 -0
  331. data/test/jobs/refresh_github_user_job_test.rb +1 -0
  332. data/test/jobs/refresh_status_job_test.rb +1 -0
  333. data/test/jobs/unique_job_test.rb +1 -0
  334. data/test/jobs/update_github_last_deployed_ref_job_test.rb +1 -0
  335. data/test/lib/shipit/deploy_commands_test.rb +16 -0
  336. data/test/lib/shipit/task_commands_test.rb +17 -0
  337. data/test/middleware/same_site_cookie_middleware_test.rb +52 -0
  338. data/test/models/api_client_test.rb +1 -0
  339. data/test/models/commit_checks_test.rb +1 -0
  340. data/test/models/commit_deployment_status_test.rb +34 -4
  341. data/test/models/commit_deployment_test.rb +9 -11
  342. data/test/models/commits_test.rb +116 -21
  343. data/test/models/delivery_test.rb +2 -1
  344. data/test/models/deploy_spec_test.rb +103 -65
  345. data/test/models/deploy_stats_test.rb +113 -0
  346. data/test/models/deploys_test.rb +207 -26
  347. data/test/models/duration_test.rb +1 -0
  348. data/test/models/github_hook_test.rb +1 -0
  349. data/test/models/hook_test.rb +20 -16
  350. data/test/models/membership_test.rb +1 -0
  351. data/test/models/{pull_request_test.rb → merge_request_test.rb} +48 -41
  352. data/test/models/pull_request_assignment_test.rb +16 -0
  353. data/test/models/release_statuses_test.rb +1 -0
  354. data/test/models/rollbacks_test.rb +1 -0
  355. data/test/models/shipit/check_run_test.rb +1 -0
  356. data/test/models/shipit/provisioning_handler/base_test.rb +33 -0
  357. data/test/models/shipit/provisioning_handler/unregistered_provisioning_handler_test.rb +49 -0
  358. data/test/models/shipit/provisioning_handler_test.rb +64 -0
  359. data/test/models/shipit/pull_request_test.rb +52 -0
  360. data/test/models/shipit/repository_test.rb +81 -0
  361. data/test/models/shipit/review_stack_provision_status_test.rb +77 -0
  362. data/test/models/shipit/review_stack_provisioning_queue_test.rb +63 -0
  363. data/test/models/shipit/review_stack_test.rb +59 -0
  364. data/test/models/{stacks_test.rb → shipit/stacks_test.rb} +120 -60
  365. data/test/models/shipit/webhooks/handlers/pull_request/assigned_handler_test.rb +45 -0
  366. data/test/models/shipit/webhooks/handlers/pull_request/closed_handler_test.rb +192 -0
  367. data/test/models/shipit/webhooks/handlers/pull_request/edited_handler_test.rb +47 -0
  368. data/test/models/shipit/webhooks/handlers/pull_request/label_capturing_handler_test.rb +209 -0
  369. data/test/models/shipit/webhooks/handlers/pull_request/labeled_handler_test.rb +332 -0
  370. data/test/models/shipit/webhooks/handlers/pull_request/opened_handler_test.rb +238 -0
  371. data/test/models/shipit/webhooks/handlers/pull_request/reopened_handler_test.rb +282 -0
  372. data/test/models/shipit/webhooks/handlers/pull_request/review_stack_adapter_test.rb +83 -0
  373. data/test/models/shipit/webhooks/handlers/pull_request/unlabeled_handler_test.rb +324 -0
  374. data/test/models/shipit/webhooks/handlers_test.rb +27 -0
  375. data/test/models/status/group_test.rb +1 -0
  376. data/test/models/status/missing_test.rb +1 -0
  377. data/test/models/status_test.rb +1 -0
  378. data/test/models/task_definitions_test.rb +9 -8
  379. data/test/models/tasks_test.rb +59 -1
  380. data/test/models/team_test.rb +4 -2
  381. data/test/models/undeployed_commits_test.rb +14 -0
  382. data/test/models/users_test.rb +13 -5
  383. data/test/serializers/shipit/pull_request_serializer_test.rb +29 -0
  384. data/test/test_command_integration.rb +3 -2
  385. data/test/test_helper.rb +37 -32
  386. data/test/unit/anonymous_user_serializer_test.rb +14 -0
  387. data/test/unit/command_test.rb +15 -10
  388. data/test/unit/commands_test.rb +1 -0
  389. data/test/unit/commit_serializer_test.rb +16 -0
  390. data/test/unit/csv_serializer_test.rb +3 -2
  391. data/test/unit/deploy_commands_test.rb +14 -4
  392. data/test/unit/deploy_serializer_test.rb +17 -0
  393. data/test/unit/environment_variables_test.rb +5 -4
  394. data/test/unit/github_app_test.rb +137 -0
  395. data/test/unit/github_url_helper_test.rb +6 -0
  396. data/test/unit/rollback_commands_test.rb +2 -1
  397. data/test/unit/shipit_helper_test.rb +17 -0
  398. data/test/unit/shipit_task_execution_strategy_test.rb +47 -0
  399. data/test/unit/shipit_test.rb +1 -0
  400. data/test/unit/user_serializer_test.rb +14 -0
  401. data/test/unit/variable_definition_test.rb +1 -0
  402. metadata +334 -169
  403. data/app/controllers/shipit/api/pull_requests_controller.rb +0 -36
  404. data/app/controllers/shipit/pull_requests_controller.rb +0 -30
  405. data/app/jobs/shipit/merge_pull_requests_job.rb +0 -31
  406. data/app/jobs/shipit/refresh_pull_request_job.rb +0 -10
  407. data/app/views/shipit/pull_requests/_pull_request.html.erb +0 -29
  408. data/test/controllers/pull_requests_controller_test.rb +0 -31
  409. data/test/fixtures/shipit/output_chunks.yml +0 -47
  410. data/test/models/output_chunk_test.rb +0 -20
@@ -1,3 +1,4 @@
1
+ # frozen_string_literal: true
1
2
  module Shipit
2
3
  class CommitMessage
3
4
  GITHUB_MERGE_COMMIT_PATTERN = /\AMerge pull request #(?<pr_id>\d+) from \S+\n\n(?<pr_title>.*)/
@@ -1,11 +1,12 @@
1
+ # frozen_string_literal: true
1
2
  module Shipit
2
- class Delivery < ActiveRecord::Base
3
+ class Delivery < Record
3
4
  STATUSES = %w(pending scheduled sent).freeze
4
5
  enum status: STATUSES.zip(STATUSES).to_h
5
6
 
6
7
  belongs_to :hook
7
8
 
8
- validates :url, presence: true, url: {no_local: true, allow_blank: true}
9
+ validates :url, presence: true, url: { no_local: true, allow_blank: true }
9
10
  validates :content_type, presence: true
10
11
 
11
12
  serialize :response_headers, JSON
@@ -36,7 +37,7 @@ module Shipit
36
37
  def http
37
38
  Faraday::Connection.new do |connection|
38
39
  connection.headers = headers
39
- connection.adapter Faraday.default_adapter
40
+ connection.adapter(Faraday.default_adapter)
40
41
  end
41
42
  end
42
43
 
@@ -1,3 +1,4 @@
1
+ # frozen_string_literal: true
1
2
  require 'fileutils'
2
3
 
3
4
  module Shipit
@@ -14,20 +15,41 @@ module Shipit
14
15
  after_transition any => any, do: :update_last_deploy_time
15
16
  end
16
17
 
18
+ belongs_to :until_commit, class_name: 'Commit', required: true, inverse_of: :deploys
19
+ belongs_to :since_commit, class_name: 'Commit', required: true, inverse_of: :deploys
17
20
  has_many :commit_deployments, dependent: :destroy, inverse_of: :task, foreign_key: :task_id do
18
21
  GITHUB_STATUSES = {
19
22
  'pending' => 'pending',
23
+ 'running' => 'in_progress',
20
24
  'failed' => 'failure',
25
+ 'timedout' => 'failure',
21
26
  'success' => 'success',
27
+ 'faulty' => 'error',
22
28
  'error' => 'error',
23
29
  'aborted' => 'error',
24
30
  }.freeze
25
31
 
26
32
  def append_status(task_status)
27
33
  if github_status = GITHUB_STATUSES[task_status]
28
- each do |deployment|
34
+ # Deployments and statuses are created async, we reload the association to ensure we update all instances
35
+ reload.each do |deployment|
36
+ Rails.logger.info(
37
+ "Creating #{github_status} deploy status for deployment #{deployment.id}. "\
38
+ "Commit: #{deployment.sha}, Github id: #{deployment.github_id}, "\
39
+ "Repo: #{deployment.stack.repo_name}, Environment: #{deployment.stack.environment}, "\
40
+ "API Url: #{deployment.api_url}.",
41
+ )
29
42
  deployment.statuses.create!(status: github_status)
30
43
  end
44
+ else
45
+ each do |deployment|
46
+ Rails.logger.warn(
47
+ "No GitHub status for task status #{task_status}. "\
48
+ "Commit: #{deployment.sha}, Github id: #{deployment.github_id}, "\
49
+ "Repo: #{deployment.stack.repo_name}, Environment: #{deployment.stack.environment}, "\
50
+ "API Url: #{deployment.api_url}.",
51
+ )
52
+ end
31
53
  end
32
54
  end
33
55
  end
@@ -70,6 +92,7 @@ module Shipit
70
92
  env: env&.to_h || {},
71
93
  allow_concurrency: force,
72
94
  ignored_safeties: force,
95
+ max_retries: stack.retries_on_rollback,
73
96
  )
74
97
  end
75
98
 
@@ -87,8 +110,8 @@ module Shipit
87
110
  end
88
111
 
89
112
  # Rolls the stack back to the most recent **previous** successful deploy
90
- def trigger_revert(force: false)
91
- previous_successful_commit = commit_to_rollback_to
113
+ def trigger_revert(force: false, rollback_to: nil)
114
+ previous_successful_commit = rollback_to&.until_commit || commit_to_rollback_to
92
115
 
93
116
  rollback = Rollback.create!(
94
117
  user_id: user_id,
@@ -215,12 +238,24 @@ module Shipit
215
238
  end
216
239
  end
217
240
 
241
+ def update_commit_deployments
242
+ commit_deployments.append_status(status)
243
+ end
244
+
218
245
  private
219
246
 
220
247
  def create_commit_deployments
221
- commits.each do |commit|
222
- commit_deployments.create!(commit: commit)
248
+ # Create one deployment for the head of the batch
249
+ commit_deployments.create!(sha: until_commit.sha)
250
+
251
+ # Create one for each pull request in the batch, to give feedback on the PR timeline
252
+ commits.select(&:pull_request?).each do |commit|
253
+ next if commit.pull_request_head_sha.blank? # This attribute was not always populated
254
+ commit_deployments.create!(sha: commit.pull_request_head_sha)
223
255
  end
256
+
257
+ # Immediately update to publish the status to the commit deployments
258
+ update_commit_deployments
224
259
  end
225
260
 
226
261
  def update_release_status
@@ -245,14 +280,10 @@ module Shipit
245
280
  end
246
281
  end
247
282
 
248
- def update_commit_deployments
249
- commit_deployments.append_status(status)
250
- end
251
-
252
283
  def trigger_revert_if_required
253
284
  return unless rollback_once_aborted?
254
285
  return unless supports_rollback?
255
- trigger_revert
286
+ trigger_revert(rollback_to: rollback_once_aborted_to)
256
287
  end
257
288
 
258
289
  def default_since_commit_id
@@ -1,3 +1,4 @@
1
+ # frozen_string_literal: true
1
2
  require 'pathname'
2
3
 
3
4
  module Shipit
@@ -5,20 +6,34 @@ module Shipit
5
6
  Error = Class.new(StandardError)
6
7
 
7
8
  class << self
9
+ attr_accessor :pretty_generate
10
+
8
11
  def load(json)
9
12
  config = json.blank? ? {} : JSON.parse(json)
10
13
  new(config)
11
14
  end
12
15
 
13
16
  def dump(spec)
14
- JSON.dump(spec.cacheable.config) if spec
17
+ return unless spec
18
+
19
+ if pretty_generate?
20
+ JSON.pretty_generate(spec.cacheable.config)
21
+ else
22
+ JSON.dump(spec.cacheable.config)
23
+ end
15
24
  end
16
25
 
17
26
  def bundle_path
18
27
  Rails.root.join('data', 'bundler')
19
28
  end
29
+
30
+ def pretty_generate?
31
+ @pretty_generate
32
+ end
20
33
  end
21
34
 
35
+ self.pretty_generate = false
36
+
22
37
  def initialize(config)
23
38
  @config = config
24
39
  end
@@ -40,6 +55,10 @@ module Shipit
40
55
  end
41
56
  end
42
57
 
58
+ def blank?
59
+ config.empty?
60
+ end
61
+
43
62
  def supports_fetch_deployed_revision?
44
63
  fetch_deployed_revision_steps.present?
45
64
  end
@@ -85,6 +104,10 @@ module Shipit
85
104
  Duration.parse(config('deploy', 'interval') { 0 })
86
105
  end
87
106
 
107
+ def provisioning_handler_name
108
+ config('provision', 'handler_name')
109
+ end
110
+
88
111
  def deploy_steps
89
112
  around_steps('deploy') do
90
113
  config('deploy', 'override') { discover_deploy_steps }
@@ -103,6 +126,10 @@ module Shipit
103
126
  deploy_variables.map { |v| [v.name, v.default] }.to_h
104
127
  end
105
128
 
129
+ def retries_on_deploy
130
+ config('deploy', 'retries') { nil }
131
+ end
132
+
106
133
  def rollback_steps
107
134
  around_steps('rollback') do
108
135
  config('rollback', 'override') { discover_rollback_steps }
@@ -113,6 +140,10 @@ module Shipit
113
140
  rollback_steps || cant_detect!(:rollback)
114
141
  end
115
142
 
143
+ def retries_on_rollback
144
+ config('rollback', 'retries') { nil }
145
+ end
146
+
116
147
  def fetch_deployed_revision_steps
117
148
  config('fetch') || discover_fetch_deployed_revision_steps
118
149
  end
@@ -160,12 +191,12 @@ module Shipit
160
191
  Array.wrap(config('ci', 'blocking'))
161
192
  end
162
193
 
163
- def pull_request_merge_method
194
+ def merge_request_merge_method
164
195
  method = config('merge', 'method')
165
196
  method if %w(merge rebase squash).include?(method)
166
197
  end
167
198
 
168
- def pull_request_required_statuses
199
+ def merge_request_required_statuses
169
200
  if config('merge', 'require') || config('merge', 'ignore')
170
201
  Array.wrap(config('merge', 'require'))
171
202
  else
@@ -173,7 +204,7 @@ module Shipit
173
204
  end
174
205
  end
175
206
 
176
- def pull_request_ignored_statuses
207
+ def merge_request_ignored_statuses
177
208
  if config('merge', 'require') || config('merge', 'ignore')
178
209
  Array.wrap(config('merge', 'ignore')) + [release_status_context].compact
179
210
  else
@@ -181,7 +212,7 @@ module Shipit
181
212
  end
182
213
  end
183
214
 
184
- def revalidate_pull_requests_after
215
+ def revalidate_merge_requests_after
185
216
  if timeout = config('merge', 'revalidate_after')
186
217
  begin
187
218
  Duration.parse(timeout)
@@ -255,11 +286,11 @@ module Shipit
255
286
  end
256
287
 
257
288
  def task_not_found!(id)
258
- raise TaskDefinition::NotFound.new("No definition for task #{id.inspect}")
289
+ raise TaskDefinition::NotFound, "No definition for task #{id.inspect}"
259
290
  end
260
291
 
261
292
  def cant_detect!(type)
262
- raise DeploySpec::Error.new(I18n.t("deploy_spec.hint.#{type}"))
293
+ raise DeploySpec::Error, I18n.t("deploy_spec.hint.#{type}")
263
294
  end
264
295
  end
265
296
  end
@@ -1,3 +1,4 @@
1
+ # frozen_string_literal: true
1
2
  module Shipit
2
3
  class DeploySpec
3
4
  module BundlerDiscovery
@@ -31,7 +32,7 @@ module Shipit
31
32
 
32
33
  def remove_ruby_version_from_gemfile
33
34
  # Heroku apps often specify a ruby version.
34
- if /darwin/ =~ RUBY_PLATFORM
35
+ if /darwin/i.match?(RUBY_PLATFORM)
35
36
  # OSX is nitpicky about the -i.
36
37
  %q(/usr/bin/sed -i '' '/^ruby\s/d' Gemfile)
37
38
  else
@@ -1,3 +1,4 @@
1
+ # frozen_string_literal: true
1
2
  module Shipit
2
3
  class DeploySpec
3
4
  module CapistranoDiscovery
@@ -1,3 +1,4 @@
1
+ # frozen_string_literal: true
1
2
  module Shipit
2
3
  class DeploySpec
3
4
  class FileSystem < DeploySpec
@@ -12,6 +13,7 @@ module Shipit
12
13
  def initialize(app_dir, env)
13
14
  @app_dir = Pathname(app_dir)
14
15
  @env = env
16
+ super(nil)
15
17
  end
16
18
 
17
19
  def cacheable
@@ -31,10 +33,10 @@ module Shipit
31
33
  def cacheable_config
32
34
  (config || {}).deep_merge(
33
35
  'merge' => {
34
- 'require' => pull_request_required_statuses,
35
- 'ignore' => pull_request_ignored_statuses,
36
- 'revalidate_after' => revalidate_pull_requests_after&.to_i,
37
- 'method' => pull_request_merge_method,
36
+ 'require' => merge_request_required_statuses,
37
+ 'ignore' => merge_request_ignored_statuses,
38
+ 'revalidate_after' => revalidate_merge_requests_after&.to_i,
39
+ 'method' => merge_request_merge_method,
38
40
  'max_divergence' => {
39
41
  'commits' => max_divergence_commits&.to_i,
40
42
  'age' => max_divergence_age&.to_i,
@@ -61,14 +63,19 @@ module Shipit
61
63
  'context' => release_status_context,
62
64
  'delay' => release_status_delay,
63
65
  },
64
- 'dependencies' => {'override' => dependencies_steps},
66
+ 'dependencies' => { 'override' => dependencies_steps },
67
+ 'provision' => { 'handler_name' => provisioning_handler_name },
65
68
  'deploy' => {
66
69
  'override' => deploy_steps,
67
70
  'variables' => deploy_variables.map(&:to_h),
68
71
  'max_commits' => maximum_commits_per_deploy,
69
72
  'interval' => pause_between_deploys,
73
+ 'retries' => retries_on_deploy,
74
+ },
75
+ 'rollback' => {
76
+ 'override' => rollback_steps,
77
+ 'retries' => retries_on_rollback,
70
78
  },
71
- 'rollback' => {'override' => rollback_steps},
72
79
  'fetch' => fetch_deployed_revision_steps,
73
80
  'tasks' => cacheable_tasks,
74
81
  )
@@ -84,10 +91,16 @@ module Shipit
84
91
  end
85
92
 
86
93
  def load_config
87
- read_config(file("shipit.#{@env}.yml", root: true)) ||
94
+ read_config(file("#{app_name}.#{@env}.yml", root: true)) ||
95
+ read_config(file("#{app_name}.yml", root: true)) ||
96
+ read_config(file("shipit.#{@env}.yml", root: true)) ||
88
97
  read_config(file('shipit.yml', root: true))
89
98
  end
90
99
 
100
+ def app_name
101
+ @app_name ||= Shipit.app_name.downcase
102
+ end
103
+
91
104
  def read_config(path)
92
105
  SafeYAML.load(path.read) if path.exist?
93
106
  end
@@ -1,3 +1,4 @@
1
+ # frozen_string_literal: true
1
2
  module Shipit
2
3
  class DeploySpec
3
4
  module KubernetesDiscovery
@@ -1,3 +1,4 @@
1
+ # frozen_string_literal: true
1
2
  require 'json'
2
3
 
3
4
  module Shipit
@@ -1,13 +1,14 @@
1
+ # frozen_string_literal: true
1
2
  require 'json'
2
3
 
3
4
  module Shipit
4
5
  class DeploySpec
5
6
  module NpmDiscovery
6
7
  # https://docs.npmjs.com/cli/publish
7
- PUBLIC = 'public'.freeze
8
- PRIVATE = 'restricted'.freeze
8
+ PUBLIC = 'public'
9
+ PRIVATE = 'restricted'
9
10
  VALID_ACCESS = [PUBLIC, PRIVATE].freeze
10
- NPM_REGISTRY = "https://registry.npmjs.org/".freeze
11
+ NPM_REGISTRY = "https://registry.npmjs.org/"
11
12
 
12
13
  def discover_dependencies_steps
13
14
  discover_package_json || super
@@ -57,7 +58,7 @@ module Shipit
57
58
  # are treated as 'next' npm dist-tags.
58
59
  # An 1.0.0-beta.1 would be installable using both:
59
60
  # `yarn add package@1.0.0-beta.1` and `yarn add package@next`
60
- return 'next' if ['-beta', '-alpha', '-rc', '-next'].any? { |tag| version.include? tag }
61
+ return 'next' if ['-beta', '-alpha', '-rc', '-next'].any? { |tag| version.include?(tag) }
61
62
  'latest'
62
63
  end
63
64
 
@@ -1,3 +1,4 @@
1
+ # frozen_string_literal: true
1
2
  module Shipit
2
3
  class DeploySpec
3
4
  module PypiDiscovery
@@ -1,3 +1,4 @@
1
+ # frozen_string_literal: true
1
2
  module Shipit
2
3
  class DeploySpec
3
4
  module RubygemsDiscovery
@@ -0,0 +1,58 @@
1
+ # frozen_string_literal: true
2
+ module Shipit
3
+ class DeployStats
4
+ delegate :empty?, to: :@deploys
5
+
6
+ def initialize(deploys)
7
+ @deploys = deploys
8
+ @durations = @deploys.map { |d| d.duration&.value }.compact
9
+ end
10
+
11
+ def count
12
+ @deploys.length
13
+ end
14
+
15
+ def average_duration
16
+ return if empty?
17
+ @durations.sum / @durations.length.to_f
18
+ end
19
+
20
+ def max_duration
21
+ @durations.max
22
+ end
23
+
24
+ def min_duration
25
+ @durations.min
26
+ end
27
+
28
+ def median_duration
29
+ return if @durations.empty?
30
+ (sorted_durations[(@durations.length - 1) / 2] + sorted_durations[@durations.length / 2]) / 2.0
31
+ end
32
+
33
+ def success_rate
34
+ return if empty?
35
+ (@deploys.count(&:success?) / @deploys.length.to_f) * 100
36
+ end
37
+
38
+ def compare(compare_stats)
39
+ {
40
+ count: percent_change(compare_stats.count, count),
41
+ average_duration: percent_change(compare_stats.average_duration, average_duration),
42
+ median_duration: percent_change(compare_stats.median_duration, median_duration),
43
+ }
44
+ end
45
+
46
+ protected
47
+
48
+ def sorted_durations
49
+ @sorted ||= @durations.sort
50
+ end
51
+
52
+ def percent_change(from, to)
53
+ return if to.nil? || from.nil?
54
+ return to * 100 if from.zero?
55
+ ((to - from) / from.to_f) * 100
56
+ end
57
+ end
58
+ end