shipit-engine 0.28.1 → 0.33.0

data/test/models/deploy_stats_test.rb

@@ -0,0 +1,113 @@
+# frozen_string_literal: true
+require 'test_helper'
+
+module Shipit
+  class DeployStatsTest < ActiveSupport::TestCase
+    def setup
+      @stack = shipit_stacks(:shipit_stats)
+      @stats = Shipit::DeployStats.new(@stack.deploys.not_active)
+      @old_deploys = @stack.deploys.not_active.where(created_at: 62.minutes.ago..32.minutes.ago)
+      @new_deploys = @stack.deploys.not_active.where("created_at > ?", 32.minutes.ago)
+    end
+
+    test "#average_duration is accurate" do
+      assert_equal 225.0, @stats.average_duration
+    end
+
+    test "#median_duration is accurate" do
+      assert_equal 210.0, @stats.median_duration
+    end
+
+    test "#max_duration is accurate" do
+      assert_equal 360.0, @stats.max_duration
+    end
+
+    test "#min_duration is accurate" do
+      assert_equal 120.0, @stats.min_duration
+    end
+
+    test "#success_rate is accurate" do
+      assert_equal 75.0, @stats.success_rate
+    end
+
+    test "#average_duration handles empty deploy data" do
+      stats = Shipit::DeployStats.new([])
+      assert_nil stats.average_duration
+    end
+
+    test "#median_duration handles empty deploy data" do
+      stats = Shipit::DeployStats.new([])
+      assert_nil stats.median_duration
+    end
+
+    test "#max_duration handles empty deploy data" do
+      stats = Shipit::DeployStats.new([])
+      assert_nil stats.max_duration
+    end
+
+    test "#min_duration handles empty deploy data" do
+      stats = Shipit::DeployStats.new([])
+      assert_nil stats.min_duration
+    end
+
+    test "#success_rate handles empty deploy data" do
+      stats = Shipit::DeployStats.new([])
+      assert_nil stats.success_rate
+    end
+
+    test "#compare count handles empty compare count" do
+      comparison = Shipit::DeployStats.new([])
+      results = @stats.compare(comparison)
+      assert_equal 400, results[:count]
+    end
+
+    test "#compare average and median handles empty array" do
+      comparison = Shipit::DeployStats.new([])
+      results = @stats.compare(comparison)
+      assert_nil results[:average_duration]
+      assert_nil results[:median_duration]
+    end
+
+    test "#compare average is accurate when negative" do
+      new_data = Shipit::DeployStats.new(@new_deploys)
+      old_data = Shipit::DeployStats.new(@old_deploys)
+      results = new_data.compare(old_data)
+      assert_equal(-53.84615384615385, results[:average_duration])
+    end
+
+    test "#compare median is accurate when negative" do
+      new_data = Shipit::DeployStats.new(@new_deploys)
+      old_data = Shipit::DeployStats.new(@old_deploys)
+      results = new_data.compare(old_data)
+      assert_equal(-50, results[:median_duration])
+    end
+
+    test "#compare count is accurate when negative" do
+      new_data = Shipit::DeployStats.new(@new_deploys)
+      old_data = Shipit::DeployStats.new(@old_deploys)
+      results = new_data.compare(old_data)
+      assert_equal(-66.66666666666666, results[:count])
+    end
+
+    test "#compare average is accurate" do
+      old_data = Shipit::DeployStats.new(@new_deploys)
+      new_data = Shipit::DeployStats.new(@old_deploys)
+      results = new_data.compare(old_data)
+      assert_equal(116.66666666666667, results[:average_duration])
+    end
+
+    test "#compare median is accurate" do
+      old_data = Shipit::DeployStats.new(@new_deploys)
+      new_data = Shipit::DeployStats.new(@old_deploys)
+      results = new_data.compare(old_data)
+      assert_equal(100, results[:median_duration])
+    end
+
+    test "#compare count is accurate" do
+      old_data = Shipit::DeployStats.new(@new_deploys)
+      new_data = Shipit::DeployStats.new(@old_deploys)
+      results = new_data.compare(old_data)
+      assert_equal(200, results[:count])
+    end
+  end
+end

data/test/models/deploys_test.rb

@@ -1,9 +1,11 @@
+# frozen_string_literal: true
 require 'test_helper'
 
 module Shipit
   class DeploysTest < ActiveSupport::TestCase
     def setup
       @deploy = shipit_deploys(:shipit)
+      @deploy.write("dummy output")
       @deploy.pid = 42
       @stack = shipit_stacks(:shipit)
       @user = shipit_users(:walrus)
@@ -59,6 +61,146 @@ module Shipit
       assert_equal [], @deploy.commits
     end
 
+    test "deploys retry up to limit upon timeout when configured" do
+      runnable_deploy = shipit_deploys(:shipit_pending)
+      deploy_stack = runnable_deploy.stack
+
+      Shipit::Deploy.any_instance.expects(:acquire_git_cache_lock).twice
+        .raises(Shipit::Command::TimedOut, 'Deploy timed out')
+        .then.raises(Shipit::Command::Error, "Second command error failure")
+
+      perform_enqueued_jobs(only: Shipit::PerformTaskJob) do
+        runnable_deploy.enqueue
+      end
+      assert_performed_jobs 2
+
+      runnable_deploy.reload
+      assert_equal 'timedout', runnable_deploy.status
+
+      retried_deploy = deploy_stack.deploys.last
+      assert_not_equal runnable_deploy.id, retried_deploy.id
+      assert_equal runnable_deploy.since_commit, retried_deploy.since_commit
+      assert_equal runnable_deploy.until_commit, retried_deploy.until_commit
+      assert_equal 'failed', retried_deploy.status
+      assert_equal 1, retried_deploy.retry_attempt
+    end
+
+    test "deploys retry up to limit upon failure when configured" do
+      runnable_deploy = shipit_deploys(:shipit_pending)
+      deploy_stack = runnable_deploy.stack
+
+      Shipit::Deploy.any_instance.expects(:acquire_git_cache_lock).twice
+        .raises(Shipit::Command::Error, 'Deploy failed')
+        .then.raises(Shipit::Command::Error, "Second deploy failed")
+
+      perform_enqueued_jobs(only: Shipit::PerformTaskJob) do
+        runnable_deploy.enqueue
+      end
+      assert_performed_jobs 2
+
+      runnable_deploy.reload
+      assert_equal 'failed', runnable_deploy.status
+
+      retried_deploy = deploy_stack.deploys.last
+      assert_not_equal runnable_deploy.id, retried_deploy.id
+      assert_equal runnable_deploy.since_commit, retried_deploy.since_commit
+      assert_equal runnable_deploy.until_commit, retried_deploy.until_commit
+      assert_equal 'failed', retried_deploy.status
+      assert_equal 1, retried_deploy.retry_attempt
+    end
+
+    test "deploys retry up to limit upon error when configured" do
+      runnable_deploy = shipit_deploys(:shipit_pending)
+      deploy_stack = runnable_deploy.stack
+
+      Shipit::Deploy.any_instance.expects(:acquire_git_cache_lock).twice
+        .raises(StandardError, 'Deploy failed')
+        .then.raises(StandardError, "Second deploy failed")
+
+      perform_enqueued_jobs(only: Shipit::PerformTaskJob) do
+        runnable_deploy.enqueue
+      end
+      assert_performed_jobs 2
+
+      runnable_deploy.reload
+      assert_equal 'error', runnable_deploy.status
+
+      retried_deploy = deploy_stack.deploys.last
+      assert_not_equal runnable_deploy.id, retried_deploy.id
+      assert_equal runnable_deploy.since_commit, retried_deploy.since_commit
+      assert_equal runnable_deploy.until_commit, retried_deploy.until_commit
+      assert_equal 'error', retried_deploy.status
+      assert_equal 1, retried_deploy.retry_attempt
+    end
+
+    test "deploys do not retry upon timeout when not configured" do
+      runnable_deploy = shipit_deploys(:shipit_pending)
+      runnable_deploy.update!(retry_attempt: 0, max_retries: 0)
+
+      Shipit::Deploy.any_instance.expects(:acquire_git_cache_lock)
+        .raises(Shipit::Command::TimedOut, 'Deploy timed out')
+
+      perform_enqueued_jobs(only: Shipit::PerformTaskJob) do
+        runnable_deploy.enqueue
+      end
+      assert_performed_jobs 1
+
+      runnable_deploy.reload
+
+      assert_equal 'timedout', runnable_deploy.status
+    end
+
+    test "rollbacks retry on timeouts if configured" do
+      deploy = shipit_deploys(:shipit)
+      deploy_stack = deploy.stack
+
+      DeploySpec.any_instance.expects(:retries_on_rollback).returns(1)
+
+      Shipit::Command.any_instance.expects(:run).twice
+        .raises(Shipit::Command::TimedOut, 'Rollback timed out')
+        .then.raises(Shipit::Command::Error, "Second command error failure")
+
+      first_rollback = nil
+
+      perform_enqueued_jobs(only: Shipit::PerformTaskJob) do
+        first_rollback = deploy.trigger_rollback(@user, force: true)
+      end
+      assert_performed_jobs 2
+
+      first_rollback.reload
+
+      assert_equal 'timedout', first_rollback.status
+      retried_rollback = deploy_stack.deploys_and_rollbacks.last
+
+      assert_not_equal first_rollback.id, retried_rollback.id
+      assert_equal first_rollback.since_commit, retried_rollback.since_commit
+      assert_equal first_rollback.until_commit, retried_rollback.until_commit
+      assert_equal 'failed', retried_rollback.status
+      assert_equal 1, retried_rollback.max_retries
+    end
+
+    test "rollbacks do not retry if not configured" do
+      deploy_stack = @deploy.stack
+
+      DeploySpec.any_instance.expects(:retries_on_rollback).returns(0)
+
+      Shipit::Command.any_instance.expects(:run).once
+        .raises(Shipit::Command::TimedOut, 'Rollback timed out')
+        .then.raises(Shipit::Command::Error, "Second command error failure")
+
+      first_rollback = nil
+
+      perform_enqueued_jobs(only: Shipit::PerformTaskJob) do
+        first_rollback = @deploy.trigger_rollback(@user, force: true)
+      end
+      assert_performed_jobs 1
+
+      first_rollback.reload
+
+      assert_equal 'timedout', first_rollback.status
+      assert_equal first_rollback, deploy_stack.deploys_and_rollbacks.last
+    end
+
     test "additions and deletions are denormalized on before create" do
       stack = shipit_stacks(:shipit)
       first = shipit_commits(:first)
@@ -199,6 +341,7 @@ module Shipit
         since_commit: shipit.commits.first,
         until_commit: shipit.commits.last,
       )
+      deploy.stubs(:merge_request_head_for_commit).returns(nil)
 
       expect_event(deploy)
       deploy.save!
@@ -246,6 +389,8 @@ module Shipit
     end
 
     test "transitioning to success enqueues a last-deployed git reference update" do
+      Shipit.stubs(:update_latest_deployed_ref).returns(true)
+
       @deploy = shipit_deploys(:shipit_running)
       assert_enqueued_with(job: UpdateGithubLastDeployedRefJob, args: [@deploy.stack]) do
         @deploy.complete!
@@ -259,9 +404,9 @@ module Shipit
       assert_in_delta @deploy.ended_at, @stack.last_deployed_at, 2
     end
 
-    test "transitioning to success schedule a MergePullRequests job" do
+    test "transitioning to success schedule a MergeMergeRequests job" do
       @deploy = shipit_deploys(:shipit_running)
-      assert_enqueued_with(job: MergePullRequestsJob, args: [@deploy.stack]) do
+      assert_enqueued_with(job: ProcessMergeRequestsJob, args: [@deploy.stack]) do
         @deploy.complete!
       end
     end
@@ -300,15 +445,17 @@ module Shipit
       end
     end
 
-    test "creating a deploy creates one CommitDeployment per commit" do
-      shipit = shipit_stacks(:shipit)
-      deploy = shipit.deploys.build(
-        since_commit: shipit.commits.first,
-        until_commit: shipit.commits.last,
-      )
+    test "transitioning to aborted schedule a rollback to the designated deploy if set" do
+      @rollback_to = shipit_deploys(:shipit_pending)
+      @deploy = shipit_deploys(:shipit_running)
+      @deploy.ping
+      @deploy.pid = 42
+      @deploy.abort!(rollback_once_aborted: true, rollback_once_aborted_to: @rollback_to, aborted_by: @user)
 
-      assert_difference -> { CommitDeployment.count }, deploy.commits.size do
-        deploy.save!
+      assert_difference -> { @stack.rollbacks.count }, 1 do
+        assert_enqueued_with(job: PerformTaskJob) do
+          @deploy.aborted!
+        end
       end
     end
 
@@ -338,10 +485,9 @@ module Shipit
       assert_equal shipit_commits(:second), @stack.last_deployed_commit
     end
 
-    def create_test_stack
+    def create_test_stack(repository: Shipit::Repository.find_or_create_by!(owner: "shopify-test", name: "shipit-engine-test"))
       Shipit::Stack.create(
-        repo_owner: "shopify-test",
-        repo_name: "shipit-engine-test",
+        repository: repository,
         environment: 'production',
         branch: "master",
         merge_queue_enabled: true,
@@ -388,7 +534,7 @@ module Shipit
     # Check that the next item in the series is 1 greater than the last.
     def assert_generated_record_ids_are_sequential(record_id_series)
       record_id_series[0..-2].each_with_index do |id_element, index|
-        assert_equal id_element + 1, record_id_series[index + 1]
+        assert_equal(id_element + 1, record_id_series[index + 1])
       end
     end
 
@@ -441,6 +587,20 @@ module Shipit
       assert_equal "Shipit::Rollback", last_deploy.type
     end
 
+    test "#trigger_revert uses rollback_to if set" do
+      test_stack = create_test_stack
+      test_stack.save
+      test_stack.reload
+
+      running_deploy = shipit_deploys(:shipit_running)
+      rollback_to = shipit_deploys(:shipit_pending)
+
+      final_rollback = running_deploy.trigger_revert(rollback_to: rollback_to)
+
+      assert_equal "Shipit::Rollback", final_rollback.type
+      assert_equal 4, final_rollback.until_commit_id
+    end
+
     test "#trigger_revert skips unsuccessful deploys when reverting" do
       user_id = @user.id
       test_stack = create_test_stack
@@ -552,8 +712,7 @@ module Shipit
       user_id = @user.id
       test_stack = create_test_stack
       test_stack.save
-      other_stack = create_test_stack
-      other_stack.repo_name += "_other"
+      other_stack = create_test_stack(repository: Shipit::Repository.create!(owner: "_", name: "_some-other-repository"))
       other_stack.save
       other_stack.reload
       stack_id = test_stack.id
@@ -681,20 +840,13 @@ module Shipit
       assert_predicate @deploy, :error?
     end
 
-    test "destroy deletes the related output chunks" do
-      assert_difference -> { @deploy.chunks.count }, -@deploy.chunks.count do
-        @deploy.destroy
-      end
-    end
-
-    test "#chunk_output joins all chunk test if logs not rolled up" do
-      assert_equal @deploy.chunks.count, @deploy.chunks.count
-      assert_equal @deploy.chunks.pluck(:text).join, @deploy.chunk_output
+    test "#chunk_output fetches from Redis if logs not rolled up" do
+      assert_equal Shipit.redis.get(@deploy.send(:output_key)), @deploy.chunk_output
       refute @deploy.rolled_up
     end
 
     test "#chunk_output returns logs from records if rolled up" do
-      expected_output = @deploy.chunks.pluck(:text).join
+      expected_output = Shipit.redis.get(@deploy.send(:output_key))
       @deploy.rollup_chunks
 
       assert_no_queries do
@@ -860,6 +1012,35 @@ module Shipit
       end
     end
 
+    test "succeeding a deploy creates CommitDeploymentStatuses" do
+      @deploy = shipit_deploys(:shipit_running)
+      refute_empty @deploy.commit_deployments
+
+      assert_difference -> { CommitDeploymentStatus.count }, @deploy.commit_deployments.size do
+        @deploy.report_complete!
+      end
+
+      assert_equal 'success', CommitDeploymentStatus.last.status
+    end
+
+    test "creates one CommitDeployment and status per commit, and one more for the batch head" do
+      template_task = shipit_tasks(:shipit_pending)
+      deploy = template_task.stack.deploys.build(
+        since_commit: template_task.since_commit,
+        until_commit: template_task.until_commit,
+      )
+
+      expected_delta = deploy.commits.select(&:pull_request?).size + 1
+      assert_difference -> { CommitDeployment.count }, expected_delta do
+        assert_difference -> { CommitDeploymentStatus.count }, expected_delta do
+          deploy.save!
+        end
+      end
+
+      refute_nil CommitDeployment.find_by(sha: '6dcb09b5b57875f334f61aebed695e2e4193db5e')
+      refute_nil CommitDeployment.find_by(sha: deploy.until_commit.sha)
+    end
+
     private
 
     def expect_event(deploy)

data/test/models/duration_test.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'test_helper'
 
 module Shipit

data/test/models/github_hook_test.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'test_helper'
 
 module Shipit

data/test/models/hook_test.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'test_helper'
 
 module Shipit
@@ -50,26 +51,29 @@ module Shipit
     end
 
     test ".emit calls #deliver on internal hooks" do
-      begin
-        original_receivers = Shipit.internal_hook_receivers
-        FakeReceiver = Module.new
-        FakeReceiver.expects(:deliver).with(:deploy, @stack, 'foo' => 42)
+      original_receivers = Shipit.internal_hook_receivers
+      FakeReceiver = Module.new
+      FakeReceiver.expects(:deliver).with(:deploy, @stack, 'foo' => 42)
 
-        Shipit.internal_hook_receivers << FakeReceiver
-        Hook.emit(:deploy, @stack, 'foo' => 42)
-      ensure
-        Shipit.internal_hook_receivers = original_receivers
-      end
+      Shipit.internal_hook_receivers << FakeReceiver
+      Hook.emit(:deploy, @stack, 'foo' => 42)
+    ensure
+      Shipit.internal_hook_receivers = original_receivers
     end
 
     test ".emit calls no internal hooks if there are no internal_hook_receivers" do
-      begin
-        original_receivers = Shipit.internal_hook_receivers
-        Shipit.internal_hook_receivers = nil
-        Hook.emit(:deploy, @stack, 'foo' => 42)
-      ensure
-        Shipit.internal_hook_receivers = original_receivers
-      end
+      original_receivers = Shipit.internal_hook_receivers
+      Shipit.internal_hook_receivers = nil
+      Hook.emit(:deploy, @stack, 'foo' => 42)
+    ensure
+      Shipit.internal_hook_receivers = original_receivers
+    end
+
+    test ".coerce_payload coerces anonymous user correctly" do
+      locked_stack = Stack.first
+      locked_stack.lock("Some Reason", nil)
+      serialized = Hook.coerce_payload(stack: locked_stack)
+      assert_json("stack.lock_author.anonymous", true, document: serialized)
     end
   end
 end