RubyGems - shipit-engine - Versions diffs - 0.28.1 → 0.33.0 - Mend

shipit-engine 0.28.1 → 0.33.0

Files changed (410) hide show

checksums.yaml +4 -4
data/README.md +41 -2
data/Rakefile +4 -2
data/app/assets/images/archive-solid.svg +1 -0
data/app/assets/images/magic-solid.svg +1 -0
data/app/assets/javascripts/shipit/repositories_search.js.coffee +60 -0
data/app/assets/javascripts/shipit/{search.js.coffee → stack_search.js.coffee} +0 -0
data/app/assets/stylesheets/_pages/_repositories.scss +148 -0
data/app/assets/stylesheets/_pages/_stacks.scss +95 -3
data/app/assets/stylesheets/merge_status.scss +0 -3
data/app/assets/stylesheets/shipit.scss +1 -0
data/app/controllers/concerns/shipit/active_model_serializers_patch.rb +13 -0
data/app/controllers/concerns/shipit/api/cacheable.rb +1 -0
data/app/controllers/concerns/shipit/api/paginable.rb +3 -2
data/app/controllers/concerns/shipit/api/rendering.rb +5 -4
data/app/controllers/concerns/shipit/authentication.rb +3 -2
data/app/controllers/concerns/shipit/pagination.rb +2 -1
data/app/controllers/shipit/api/base_controller.rb +11 -6
data/app/controllers/shipit/api/ccmenu_controller.rb +2 -1
data/app/controllers/shipit/api/commits_controller.rb +2 -1
data/app/controllers/shipit/api/deploys_controller.rb +4 -3
data/app/controllers/shipit/api/hooks_controller.rb +6 -5
data/app/controllers/shipit/api/locks_controller.rb +5 -4
data/app/controllers/shipit/api/merge_requests_controller.rb +37 -0
data/app/controllers/shipit/api/outputs_controller.rb +2 -1
data/app/controllers/shipit/api/release_statuses_controller.rb +3 -2
data/app/controllers/shipit/api/rollbacks_controller.rb +33 -0
data/app/controllers/shipit/api/stacks_controller.rb +50 -5
data/app/controllers/shipit/api/tasks_controller.rb +6 -5
data/app/controllers/shipit/api_clients_controller.rb +50 -0
data/app/controllers/shipit/ccmenu_url_controller.rb +4 -3
data/app/controllers/shipit/commit_checks_controller.rb +2 -1
data/app/controllers/shipit/commits_controller.rb +2 -1
data/app/controllers/shipit/deploys_controller.rb +5 -4
data/app/controllers/shipit/github_authentication_controller.rb +4 -3
data/app/controllers/shipit/merge_requests_controller.rb +31 -0
data/app/controllers/shipit/merge_status_controller.rb +33 -28
data/app/controllers/shipit/release_statuses_controller.rb +3 -2
data/app/controllers/shipit/repositories_controller.rb +74 -0
data/app/controllers/shipit/rollbacks_controller.rb +3 -2
data/app/controllers/shipit/shipit_controller.rb +2 -1
data/app/controllers/shipit/stacks_controller.rb +78 -14
data/app/controllers/shipit/status_controller.rb +2 -1
data/app/controllers/shipit/tasks_controller.rb +9 -8
data/app/controllers/shipit/webhooks_controller.rb +5 -132
data/app/helpers/shipit/chunks_helper.rb +3 -2
data/app/helpers/shipit/deploys_helper.rb +4 -3
data/app/helpers/shipit/github_url_helper.rb +9 -0
data/app/helpers/shipit/merge_status_helper.rb +1 -0
data/app/helpers/shipit/shipit_helper.rb +1 -0
data/app/helpers/shipit/stacks_helper.rb +9 -0
data/app/helpers/shipit/tasks_helper.rb +1 -0
data/app/jobs/shipit/background_job.rb +4 -0
data/app/jobs/shipit/background_job/unique.rb +4 -1
data/app/jobs/shipit/cache_deploy_spec_job.rb +1 -0
data/app/jobs/shipit/chunk_rollup_job.rb +4 -0
data/app/jobs/shipit/clear_git_cache_job.rb +1 -0
data/app/jobs/shipit/continuous_delivery_job.rb +3 -1
data/app/jobs/shipit/create_on_github_job.rb +7 -1
data/app/jobs/shipit/create_release_statuses_job.rb +1 -0
data/app/jobs/shipit/deferred_touch_job.rb +4 -0
data/app/jobs/shipit/deliver_hook_job.rb +1 -0
data/app/jobs/shipit/destroy_job.rb +1 -0
data/app/jobs/shipit/destroy_repository_job.rb +24 -0
data/app/jobs/shipit/destroy_stack_job.rb +5 -4
data/app/jobs/shipit/emit_event_job.rb +2 -1
data/app/jobs/shipit/fetch_commit_stats_job.rb +1 -0
data/app/jobs/shipit/fetch_deployed_revision_job.rb +1 -0
data/app/jobs/shipit/github_sync_job.rb +2 -1
data/app/jobs/shipit/{mark_deploy_healty_job.rb → mark_deploy_healthy_job.rb} +1 -0
data/app/jobs/shipit/perform_commit_checks_job.rb +1 -0
data/app/jobs/shipit/perform_task_job.rb +5 -90
data/app/jobs/shipit/process_merge_requests_job.rb +32 -0
data/app/jobs/shipit/purge_old_deliveries_job.rb +1 -0
data/app/jobs/shipit/reap_dead_tasks_job.rb +21 -0
data/app/jobs/shipit/refresh_check_runs_job.rb +1 -0
data/app/jobs/shipit/refresh_github_user_job.rb +1 -0
data/app/jobs/shipit/refresh_merge_request_job.rb +11 -0
data/app/jobs/shipit/refresh_statuses_job.rb +1 -0
data/app/jobs/shipit/setup_github_hook_job.rb +1 -0
data/app/jobs/shipit/update_estimated_deploy_duration_job.rb +1 -0
data/app/jobs/shipit/update_github_last_deployed_ref_job.rb +4 -3
data/app/models/concerns/shipit/deferred_touch.rb +4 -3
data/app/models/shipit/anonymous_user.rb +9 -0
data/app/models/shipit/api_client.rb +3 -2
data/app/models/shipit/application_record.rb +2 -1
data/app/models/shipit/check_run.rb +5 -4
data/app/models/shipit/command_line_user.rb +5 -0
data/app/models/shipit/commit.rb +41 -22
data/app/models/shipit/commit_checks.rb +2 -0
data/app/models/shipit/commit_deployment.rb +17 -12
data/app/models/shipit/commit_deployment_status.rb +8 -3
data/app/models/shipit/commit_message.rb +1 -0
data/app/models/shipit/delivery.rb +4 -3
data/app/models/shipit/deploy.rb +41 -10
data/app/models/shipit/deploy_spec.rb +38 -7
data/app/models/shipit/deploy_spec/bundler_discovery.rb +2 -1
data/app/models/shipit/deploy_spec/capistrano_discovery.rb +1 -0
data/app/models/shipit/deploy_spec/file_system.rb +20 -7
data/app/models/shipit/deploy_spec/kubernetes_discovery.rb +1 -0
data/app/models/shipit/deploy_spec/lerna_discovery.rb +1 -0
data/app/models/shipit/deploy_spec/npm_discovery.rb +5 -4
data/app/models/shipit/deploy_spec/pypi_discovery.rb +1 -0
data/app/models/shipit/deploy_spec/rubygems_discovery.rb +1 -0
data/app/models/shipit/deploy_stats.rb +58 -0
data/app/models/shipit/duration.rb +3 -2
data/app/models/shipit/ephemeral_commit_checks.rb +1 -0
data/app/models/shipit/github_hook.rb +2 -1
data/app/models/shipit/github_status.rb +2 -1
data/app/models/shipit/hook.rb +8 -5
data/app/models/shipit/membership.rb +3 -2
data/app/models/shipit/merge_request.rb +302 -0
data/app/models/shipit/output_chunk.rb +7 -2
data/app/models/shipit/provisioning_handler.rb +32 -0
data/app/models/shipit/provisioning_handler/base.rb +30 -0
data/app/models/shipit/provisioning_handler/unregistered_provisioning_handler.rb +35 -0
data/app/models/shipit/pull_request.rb +27 -260
data/app/models/shipit/pull_request_assignment.rb +10 -0
data/app/models/shipit/record.rb +18 -0
data/app/models/shipit/release_status.rb +3 -2
data/app/models/shipit/repository.rb +97 -0
data/app/models/shipit/review_stack.rb +116 -0
data/app/models/shipit/review_stack_provisioning_queue.rb +39 -0
data/app/models/shipit/rollback.rb +1 -0
data/app/models/shipit/stack.rb +130 -57
data/app/models/shipit/status.rb +3 -2
data/app/models/shipit/status/common.rb +7 -6
data/app/models/shipit/status/group.rb +1 -0
data/app/models/shipit/status/missing.rb +2 -1
data/app/models/shipit/status/unknown.rb +2 -1
data/app/models/shipit/task.rb +118 -14
data/app/models/shipit/task_definition.rb +1 -0
data/app/models/shipit/task_execution_strategy/base.rb +20 -0
data/app/models/shipit/task_execution_strategy/default.rb +110 -0
data/app/models/shipit/team.rb +2 -1
data/app/models/shipit/undeployed_commit.rb +1 -0
data/app/models/shipit/unlimited_api_client.rb +1 -0
data/app/models/shipit/user.rb +15 -8
data/app/models/shipit/variable_definition.rb +1 -0
data/app/models/shipit/webhooks.rb +43 -0
data/app/models/shipit/webhooks/handlers/check_suite_handler.rb +20 -0
data/app/models/shipit/webhooks/handlers/handler.rb +41 -0
data/app/models/shipit/webhooks/handlers/membership_handler.rb +46 -0
data/app/models/shipit/webhooks/handlers/pull_request/assigned_handler.rb +74 -0
data/app/models/shipit/webhooks/handlers/pull_request/closed_handler.rb +68 -0
data/app/models/shipit/webhooks/handlers/pull_request/edited_handler.rb +74 -0
data/app/models/shipit/webhooks/handlers/pull_request/label_capturing_handler.rb +127 -0
data/app/models/shipit/webhooks/handlers/pull_request/labeled_handler.rb +106 -0
data/app/models/shipit/webhooks/handlers/pull_request/opened_handler.rb +83 -0
data/app/models/shipit/webhooks/handlers/pull_request/reopened_handler.rb +88 -0
data/app/models/shipit/webhooks/handlers/pull_request/review_stack_adapter.rb +103 -0
data/app/models/shipit/webhooks/handlers/pull_request/unlabeled_handler.rb +107 -0
data/app/models/shipit/webhooks/handlers/push_handler.rb +21 -0
data/app/models/shipit/webhooks/handlers/status_handler.rb +27 -0
data/app/serializers/concerns/shipit/conditional_attributes.rb +1 -0
data/app/serializers/shipit/anonymous_user_serializer.rb +1 -0
data/app/serializers/shipit/command_line_user_serializer.rb +1 -0
data/app/serializers/shipit/commit_serializer.rb +1 -0
data/app/serializers/shipit/deploy_serializer.rb +8 -1
data/app/serializers/shipit/hook_serializer.rb +1 -0
data/app/serializers/shipit/merge_request_serializer.rb +21 -0
data/app/serializers/shipit/pull_request_serializer.rb +6 -8
data/app/serializers/shipit/review_stack_serializer.rb +7 -0
data/app/serializers/shipit/rollback_serializer.rb +1 -0
data/app/serializers/shipit/short_commit_serializer.rb +1 -0
data/app/serializers/shipit/stack_serializer.rb +12 -5
data/app/serializers/shipit/tail_task_serializer.rb +11 -2
data/app/serializers/shipit/task_serializer.rb +2 -17
data/app/serializers/shipit/user_serializer.rb +6 -1
data/app/validators/ascii_only_validator.rb +4 -3
data/app/validators/subset_validator.rb +1 -0
data/app/views/layouts/_head.html.erb +0 -0
data/app/views/layouts/shipit.html.erb +5 -3
data/app/views/shipit/_variables.html.erb +1 -1
data/app/views/shipit/api_clients/index.html.erb +36 -0
data/app/views/shipit/api_clients/new.html.erb +33 -0
data/app/views/shipit/api_clients/show.html.erb +35 -0
data/app/views/shipit/ccmenu/project.xml.builder +2 -1
data/app/views/shipit/deploys/show.html.erb +2 -2
data/app/views/shipit/merge_requests/_merge_request.html.erb +29 -0
data/app/views/shipit/{pull_requests → merge_requests}/index.html.erb +2 -2
data/app/views/shipit/merge_requests/merge_requests/_pull_request.html.erb +29 -0
data/app/views/shipit/merge_requests/merge_requests/index.html.erb +20 -0
data/app/views/shipit/merge_status/_merge_queue_button.html.erb +3 -3
data/app/views/shipit/merge_status/backlogged.html.erb +1 -1
data/app/views/shipit/merge_status/failure.html.erb +1 -1
data/app/views/shipit/merge_status/locked.html.erb +1 -1
data/app/views/shipit/merge_status/logged_out.erb +1 -1
data/app/views/shipit/merge_status/success.html.erb +2 -2
data/app/views/shipit/repositories/_header.html.erb +19 -0
data/app/views/shipit/repositories/index.html.erb +31 -0
data/app/views/shipit/repositories/new.html.erb +23 -0
data/app/views/shipit/repositories/settings.html.erb +53 -0
data/app/views/shipit/repositories/show.html.erb +30 -0
data/app/views/shipit/stacks/_banners.html.erb +13 -0
data/app/views/shipit/stacks/_header.html.erb +30 -12
data/app/views/shipit/stacks/_links.html.erb +1 -0
data/app/views/shipit/stacks/_stack.html.erb +8 -0
data/app/views/shipit/stacks/all_tasks.html.erb +28 -0
data/app/views/shipit/stacks/index.html.erb +9 -3
data/app/views/shipit/stacks/settings.html.erb +22 -3
data/app/views/shipit/stacks/show.html.erb +1 -1
data/app/views/shipit/stacks/statistics.html.erb +82 -0
data/app/views/shipit/tasks/_task_output.html.erb +1 -1
data/app/views/shipit/tasks/show.html.erb +1 -1
data/config/initializers/inflections.rb +2 -1
data/config/locales/en.yml +18 -5
data/config/routes.rb +29 -7
data/db/migrate/20191209231045_create_shipit_repositories.rb +12 -0
data/db/migrate/20191209231307_add_repository_reference_to_stacks.rb +15 -0
data/db/migrate/20191216162728_backfill_repository_data.rb +22 -0
data/db/migrate/20191216163010_remove_repository_information_from_stacks.rb +20 -0
data/db/migrate/20191219205202_add_archived_since_to_stacks.rb +6 -0
data/db/migrate/20200102175621_optional_task_commits.rb +6 -0
data/db/migrate/20200109132519_add_sha_to_commit_deployments.rb +5 -0
data/db/migrate/20200226211925_add_index_to_tasks_status.rb +5 -0
data/db/migrate/20200427135152_add_pull_request_head_sha_to_commit.rb +5 -0
data/db/migrate/20200615181558_add_rollback_once_aborted_to.rb +5 -0
data/db/migrate/20200706145406_add_review_stacks.rb +12 -0
data/db/migrate/20200804144639_rename_pull_request_to_merge_request.rb +7 -0
data/db/migrate/20200804161512_rename_commits_pull_request_id_to_merge_request_id.rb +5 -0
data/db/migrate/20200813134712_recreate_shipit_pull_requests.rb +22 -0
data/db/migrate/20200813194056_create_pull_request_assignments.rb +8 -0
data/db/migrate/20201001125502_add_provision_pr_stacks_flag_to_repositories.rb +7 -0
data/db/migrate/20201008145809_add_retry_attempt_to_tasks.rb +5 -0
data/db/migrate/20201008152744_add_max_retries_to_tasks.rb +5 -0
data/lib/shipit.rb +23 -3
data/lib/shipit/cast_value.rb +1 -0
data/lib/shipit/command.rb +14 -18
data/lib/shipit/commands.rb +5 -4
data/lib/shipit/csv_serializer.rb +1 -0
data/lib/shipit/deploy_commands.rb +1 -0
data/lib/shipit/engine.rb +11 -2
data/lib/shipit/environment_variables.rb +11 -1
data/lib/shipit/first_parent_commits_iterator.rb +1 -0
data/lib/shipit/flock.rb +1 -0
data/lib/shipit/github_app.rb +41 -10
data/lib/shipit/github_http_cache_middleware.rb +1 -0
data/lib/shipit/null_serializer.rb +1 -0
data/lib/shipit/octokit_check_runs.rb +3 -2
data/lib/shipit/octokit_iterator.rb +3 -2
data/lib/shipit/paginator.rb +3 -2
data/lib/shipit/review_stack_commands.rb +8 -0
data/lib/shipit/rollback_commands.rb +1 -0
data/lib/shipit/same_site_cookie_middleware.rb +29 -0
data/lib/shipit/simple_message_verifier.rb +1 -0
data/lib/shipit/stack_commands.rb +12 -4
data/lib/shipit/stat.rb +1 -0
data/lib/shipit/task_commands.rb +23 -14
data/lib/shipit/version.rb +2 -1
data/lib/snippets/release-gem +5 -1
data/lib/tasks/cron.rake +13 -2
data/lib/tasks/dev.rake +3 -2
data/lib/tasks/shipit.rake +16 -17
data/lib/tasks/teams.rake +1 -0
data/test/controllers/api/base_controller_test.rb +3 -2
data/test/controllers/api/ccmenu_controller_test.rb +9 -8
data/test/controllers/api/commits_controller_test.rb +3 -2
data/test/controllers/api/deploys_controller_test.rb +15 -14
data/test/controllers/api/hooks_controller_test.rb +8 -7
data/test/controllers/api/locks_controller_test.rb +7 -6
data/test/controllers/api/{pull_requests_controller_test.rb → merge_requests_controller_test.rb} +17 -16
data/test/controllers/api/outputs_controller_test.rb +4 -2
data/test/controllers/api/release_statuses_controller_test.rb +2 -1
data/test/controllers/api/rollback_controller_test.rb +113 -0
data/test/controllers/api/stacks_controller_test.rb +65 -16
data/test/controllers/api/tasks_controller_test.rb +13 -12
data/test/controllers/api_clients_controller_test.rb +104 -0
data/test/controllers/ccmenu_controller_test.rb +4 -3
data/test/controllers/commit_checks_controller_test.rb +4 -3
data/test/controllers/commits_controller_test.rb +3 -2
data/test/controllers/deploys_controller_test.rb +33 -22
data/test/controllers/github_authentication_controller_test.rb +1 -0
data/test/controllers/merge_requests_controller_test.rb +32 -0
data/test/controllers/merge_status_controller_test.rb +27 -9
data/test/controllers/release_statuses_controller_test.rb +3 -2
data/test/controllers/repositories_controller_test.rb +71 -0
data/test/controllers/rollbacks_controller_test.rb +9 -8
data/test/controllers/stacks_controller_test.rb +72 -15
data/test/controllers/status_controller_test.rb +1 -0
data/test/controllers/tasks_controller_test.rb +33 -20
data/test/controllers/webhooks_controller_test.rb +36 -9
data/test/dummy/config/application.rb +7 -2
data/test/dummy/config/environments/development.rb +23 -6
data/test/dummy/config/environments/test.rb +2 -5
data/test/dummy/db/schema.rb +76 -24
data/test/dummy/db/seeds.rb +30 -16
data/test/fixtures/payloads/check_suite_master.json +2 -2
data/test/fixtures/payloads/invalid_pull_request.json +117 -0
data/test/fixtures/payloads/provision_disabled_pull_request.json +454 -0
data/test/fixtures/payloads/pull_request_assigned.json +480 -0
data/test/fixtures/payloads/pull_request_closed.json +454 -0
data/test/fixtures/payloads/pull_request_labeled.json +461 -0
data/test/fixtures/payloads/pull_request_opened.json +454 -0
data/test/fixtures/payloads/pull_request_reopened.json +454 -0
data/test/fixtures/payloads/pull_request_unlabeled.json +454 -0
data/test/fixtures/payloads/pull_request_with_no_repo.json +454 -0
data/test/fixtures/shipit/commit_deployment_statuses.yml +4 -4
data/test/fixtures/shipit/commit_deployments.yml +8 -8
data/test/fixtures/shipit/commits.yml +52 -1
data/test/fixtures/shipit/merge_requests.yml +141 -0
data/test/fixtures/shipit/pull_request_assignments.yml +3 -0
data/test/fixtures/shipit/pull_requests.yml +10 -131
data/test/fixtures/shipit/repositories.yml +28 -0
data/test/fixtures/shipit/stacks.yml +335 -30
data/test/fixtures/shipit/statuses.yml +9 -0
data/test/fixtures/shipit/tasks.yml +69 -3
data/test/fixtures/shipit/users.yml +7 -0
data/test/fixtures/timeout +2 -1
data/test/helpers/api_helper.rb +1 -0
data/test/helpers/fixture_aliases_helper.rb +1 -0
data/test/helpers/hooks_helper.rb +2 -1
data/test/helpers/json_helper.rb +15 -11
data/test/helpers/links_helper.rb +4 -3
data/test/helpers/payloads_helper.rb +5 -0
data/test/helpers/queries_helper.rb +3 -2
data/test/jobs/cache_deploy_spec_job_test.rb +2 -1
data/test/jobs/chunk_rollup_job_test.rb +16 -1
data/test/jobs/deliver_hook_job_test.rb +1 -0
data/test/jobs/destroy_repository_job_test.rb +27 -0
data/test/jobs/destroy_stack_job_test.rb +10 -0
data/test/jobs/emit_event_job_test.rb +2 -1
data/test/jobs/fetch_commit_stats_job_test.rb +1 -0
data/test/jobs/fetch_deployed_revision_job_test.rb +1 -0
data/test/jobs/github_sync_job_test.rb +1 -0
data/test/jobs/mark_deploy_healthy_job_test.rb +1 -0
data/test/jobs/perform_task_job_test.rb +12 -11
data/test/jobs/{merge_pull_requests_job_test.rb → process_merge_requests_job_test.rb} +19 -18
data/test/jobs/purge_old_deliveries_job_test.rb +1 -0
data/test/jobs/reap_dead_tasks_job_test.rb +68 -0
data/test/jobs/refresh_github_user_job_test.rb +1 -0
data/test/jobs/refresh_status_job_test.rb +1 -0
data/test/jobs/unique_job_test.rb +1 -0
data/test/jobs/update_github_last_deployed_ref_job_test.rb +1 -0
data/test/lib/shipit/deploy_commands_test.rb +16 -0
data/test/lib/shipit/task_commands_test.rb +17 -0
data/test/middleware/same_site_cookie_middleware_test.rb +52 -0
data/test/models/api_client_test.rb +1 -0
data/test/models/commit_checks_test.rb +1 -0
data/test/models/commit_deployment_status_test.rb +34 -4
data/test/models/commit_deployment_test.rb +9 -11
data/test/models/commits_test.rb +116 -21
data/test/models/delivery_test.rb +2 -1
data/test/models/deploy_spec_test.rb +103 -65
data/test/models/deploy_stats_test.rb +113 -0
data/test/models/deploys_test.rb +207 -26
data/test/models/duration_test.rb +1 -0
data/test/models/github_hook_test.rb +1 -0
data/test/models/hook_test.rb +20 -16
data/test/models/membership_test.rb +1 -0
data/test/models/{pull_request_test.rb → merge_request_test.rb} +48 -41
data/test/models/pull_request_assignment_test.rb +16 -0
data/test/models/release_statuses_test.rb +1 -0
data/test/models/rollbacks_test.rb +1 -0
data/test/models/shipit/check_run_test.rb +1 -0
data/test/models/shipit/provisioning_handler/base_test.rb +33 -0
data/test/models/shipit/provisioning_handler/unregistered_provisioning_handler_test.rb +49 -0
data/test/models/shipit/provisioning_handler_test.rb +64 -0
data/test/models/shipit/pull_request_test.rb +52 -0
data/test/models/shipit/repository_test.rb +81 -0
data/test/models/shipit/review_stack_provision_status_test.rb +77 -0
data/test/models/shipit/review_stack_provisioning_queue_test.rb +63 -0
data/test/models/shipit/review_stack_test.rb +59 -0
data/test/models/{stacks_test.rb → shipit/stacks_test.rb} +120 -60
data/test/models/shipit/webhooks/handlers/pull_request/assigned_handler_test.rb +45 -0
data/test/models/shipit/webhooks/handlers/pull_request/closed_handler_test.rb +192 -0
data/test/models/shipit/webhooks/handlers/pull_request/edited_handler_test.rb +47 -0
data/test/models/shipit/webhooks/handlers/pull_request/label_capturing_handler_test.rb +209 -0
data/test/models/shipit/webhooks/handlers/pull_request/labeled_handler_test.rb +332 -0
data/test/models/shipit/webhooks/handlers/pull_request/opened_handler_test.rb +238 -0
data/test/models/shipit/webhooks/handlers/pull_request/reopened_handler_test.rb +282 -0
data/test/models/shipit/webhooks/handlers/pull_request/review_stack_adapter_test.rb +83 -0
data/test/models/shipit/webhooks/handlers/pull_request/unlabeled_handler_test.rb +324 -0
data/test/models/shipit/webhooks/handlers_test.rb +27 -0
data/test/models/status/group_test.rb +1 -0
data/test/models/status/missing_test.rb +1 -0
data/test/models/status_test.rb +1 -0
data/test/models/task_definitions_test.rb +9 -8
data/test/models/tasks_test.rb +59 -1
data/test/models/team_test.rb +4 -2
data/test/models/undeployed_commits_test.rb +14 -0
data/test/models/users_test.rb +13 -5
data/test/serializers/shipit/pull_request_serializer_test.rb +29 -0
data/test/test_command_integration.rb +3 -2
data/test/test_helper.rb +37 -32
data/test/unit/anonymous_user_serializer_test.rb +14 -0
data/test/unit/command_test.rb +15 -10
data/test/unit/commands_test.rb +1 -0
data/test/unit/commit_serializer_test.rb +16 -0
data/test/unit/csv_serializer_test.rb +3 -2
data/test/unit/deploy_commands_test.rb +14 -4
data/test/unit/deploy_serializer_test.rb +17 -0
data/test/unit/environment_variables_test.rb +5 -4
data/test/unit/github_app_test.rb +137 -0
data/test/unit/github_url_helper_test.rb +6 -0
data/test/unit/rollback_commands_test.rb +2 -1
data/test/unit/shipit_helper_test.rb +17 -0
data/test/unit/shipit_task_execution_strategy_test.rb +47 -0
data/test/unit/shipit_test.rb +1 -0
data/test/unit/user_serializer_test.rb +14 -0
data/test/unit/variable_definition_test.rb +1 -0
metadata +334 -169
data/app/controllers/shipit/api/pull_requests_controller.rb +0 -36
data/app/controllers/shipit/pull_requests_controller.rb +0 -30
data/app/jobs/shipit/merge_pull_requests_job.rb +0 -31
data/app/jobs/shipit/refresh_pull_request_job.rb +0 -10
data/app/views/shipit/pull_requests/_pull_request.html.erb +0 -29
data/test/controllers/pull_requests_controller_test.rb +0 -31
data/test/fixtures/shipit/output_chunks.yml +0 -47
data/test/models/output_chunk_test.rb +0 -20

data/test/fixtures/shipit/commit_deployment_statuses.yml CHANGED Viewed

@@ -1,6 +1,6 @@
-shipit_deploy_second_pending:
+shipit_deploy_second_in_progress:
   commit_deployment: shipit_deploy_second
-  status: pending
+  status: in_progress
   github_id: 42
   api_url: https://api.github.com/repos/shopify/shipit-engine/deployments/1/statuses/42
@@ -10,9 +10,9 @@ shipit_deploy_second_success:
   github_id: 43
   api_url: https://api.github.com/repos/shopify/shipit-engine/deployments/1/statuses/43
-shipit2_deploy_third_pending:
+shipit2_deploy_third_in_progress:
   commit_deployment: shipit2_deploy_third
-  status: pending
+  status: in_progress
 shipit2_deploy_third_failure:
   commit_deployment: shipit2_deploy_third

data/test/fixtures/shipit/commit_deployments.yml CHANGED Viewed

@@ -1,37 +1,37 @@
 shipit_deploy_second:
-  commit_id: 2 # second
+  sha: f890fd8b5f2be05d1fedb763a3605ee461c39074 # second
   task_id: 1 # shipit
   api_url: https://api.github.com/repos/shopify/shipit-engine/deployments/1
   github_id: 1
 shipit2_deploy_third:
-  commit_id: 3 # third
+  sha: 367578b362bf2b4df5903e1c7960929361c39074 # third
   task_id: 2 # shipit2
   api_url: https://api.github.com/repos/shopify/shipit-engine/deployments/2
   github_id: 2
 shipit_pending_third:
-  commit_id: 3 # third
+  sha: 367578b362bf2b4df5903e1c7960929361c39074 # third
   task_id: 4 # shipit_pending
   api_url: https://api.github.com/repos/shopify/shipit-engine/deployments/3
   github_id: 3
 shipit_pending_fourth:
-  commit_id: 4 # fourth
+  sha: 467578b362bf2b4df5903e1c7960929361c3435a # fourth
   task_id: 4 # shipit_pending
 shipit_running_fourth:
-  commit_id: 4 # fourth
+  sha: 467578b362bf2b4df5903e1c7960929361c3435a # fourth
   task_id: 5 # shipit_running
 shipit_complete_fourth:
-  commit_id: 4 # fourth
+  sha: 467578b362bf2b4df5903e1c7960929361c3435a # fourth
   task_id: 6 # shipit_complete
 shipit_aborted_fourth:
-  commit_id: 4 # fourth
+  sha: 467578b362bf2b4df5903e1c7960929361c3435a # fourth
   task_id: 7 # shipit_aborted
 shipit_rollback_fourth:
-  commit_id: 4 # fourth
+  sha: 467578b362bf2b4df5903e1c7960929361c3435a # fourth
   task_id: 8 # shipit_rollback

data/test/fixtures/shipit/commits.yml CHANGED Viewed

@@ -10,6 +10,7 @@ first:
   additions: 42
   deletions: 24
   updated_at: <%= 8.days.ago.to_s(:db) %>
+  created_at: <%= 1.day.ago.to_s(:db) %>
 second:
   id: 2
@@ -23,6 +24,7 @@ second:
   additions: 1
   deletions: 1
   updated_at: <%= 8.days.ago.to_s(:db) %>
+  created_at: <%= 1.day.ago.to_s(:db) %>
 third:
   id: 3
@@ -36,6 +38,7 @@ third:
   additions: 12
   deletions: 64
   updated_at: <%= 8.days.ago.to_s(:db) %>
+  created_at: <%= 1.day.ago.to_s(:db) %>
 fourth:
   id: 4
@@ -49,6 +52,8 @@ fourth:
   additions: 420
   deletions: 342
   updated_at: <%= 8.days.ago.to_s(:db) %>
+  created_at: <%= 1.day.ago.to_s(:db) %>
+  pull_request_head_sha: '6dcb09b5b57875f334f61aebed695e2e4193db5e'
 fifth:
   id: 5
@@ -62,6 +67,7 @@ fifth:
   additions: 1
   deletions: 24
   updated_at: <%= 8.days.ago.to_s(:db) %>
+  created_at: <%= 1.day.ago.to_s(:db) %>
 cyclimse_first:
   id: 6
@@ -115,7 +121,7 @@ cyclimse_merged:
   additions: 420
   deletions: 342
   updated_at: <%= 8.days.ago.to_s(:db) %>
-  pull_request_id: 99
+  merge_request_id: 99
 anonymous:
   id: 10
@@ -194,6 +200,7 @@ canaries_first:
   additions: 42
   deletions: 24
   updated_at: <%= 8.days.ago.to_s(:db) %>
+  created_at: <%= 1.day.ago.to_s(:db) %>
 canaries_second:
   id: 302
@@ -207,6 +214,7 @@ canaries_second:
   additions: 1
   deletions: 1
   updated_at: <%= 8.days.ago.to_s(:db) %>
+  created_at: <%= 1.day.ago.to_s(:db) %>
 canaries_third:
   id: 303
@@ -220,6 +228,7 @@ canaries_third:
   additions: 12
   deletions: 64
   updated_at: <%= 8.days.ago.to_s(:db) %>
+  created_at: <%= 1.day.ago.to_s(:db) %>
 canaries_fourth:
   id: 304
@@ -233,6 +242,7 @@ canaries_fourth:
   additions: 420
   deletions: 342
   updated_at: <%= 8.days.ago.to_s(:db) %>
+  created_at: <%= 1.day.ago.to_s(:db) %>
 canaries_fifth:
   id: 305
@@ -246,6 +256,7 @@ canaries_fifth:
   additions: 1
   deletions: 24
   updated_at: <%= 8.days.ago.to_s(:db) %>
+  created_at: <%= 1.day.ago.to_s(:db) %>
 undeployed_1:
   id: 401
@@ -350,3 +361,43 @@ single:
   additions: 420
   deletions: 342
   updated_at: <%= 8.days.ago.to_s(:db) %>
+task_no_commits:
+  id: 601
+  sha: 547578b362bf2b4df5903e1c7960929361c3435a
+  message: "first commit"
+  stack: shipit_task_no_commits
+  author: walrus
+  committer: walrus
+  authored_at: <%= 4.days.ago.to_s(:db) %>
+  committed_at: <%= 3.days.ago.to_s(:db) %>
+  additions: 420
+  deletions: 342
+  updated_at: <%= 8.days.ago.to_s(:db) %>
+check_deploy_spec_first:
+  id: 701
+  sha: 547578b362bf2b4df5903e1c7960929361c3435a
+  message: "Removing deploy spec"
+  stack: check_deploy_spec
+  author: walrus
+  committer: walrus
+  authored_at: <%= 4.days.ago.to_s(:db) %>
+  committed_at: <%= 3.days.ago.to_s(:db) %>
+  additions: 420
+  deletions: 342
+  updated_at: <%= 8.days.ago.to_s(:db) %>
+deployable_review_stack_commit:
+  id: 801
+  sha: ec26c3e57ca3a959ca5aad62de7213c562f8c821
+  message: "lets go"
+  stack: review_stack
+  author: walrus
+  committer: walrus
+  authored_at: <%= 10.days.ago.to_s(:db) %>
+  committed_at: <%= 9.days.ago.to_s(:db) %>
+  additions: 42
+  deletions: 24
+  updated_at: <%= 8.days.ago.to_s(:db) %>
+  created_at: <%= 1.day.ago.to_s(:db) %>

data/test/fixtures/shipit/merge_requests.yml ADDED Viewed

@@ -0,0 +1,141 @@
+shipit_fetching:
+  stack: shipit
+  number: 63
+  merge_status: fetching
+  merge_requested_at: <%= 1.minute.ago.to_s(:db) %>
+  merge_requested_by: walrus
+shipit_pending:
+  stack: shipit
+  number: 62
+  title: Super duper nice feature
+  merge_status: pending
+  merge_requested_at: <%= 5.minute.ago.to_s(:db) %>
+  revalidated_at: <%= 5.minute.ago.to_s(:db) %>
+  merge_requested_by: walrus
+  github_id: 42424424242424
+  api_url: https://api.github.com/repos/shopify/shipit-engine/pulls/62
+  state: open
+  branch: feature-62
+  head_id: 8
+  mergeable: true
+  additions: 23
+  deletions: 43
+shipit_pending_unmergeable:
+  stack: shipit
+  number: 61
+  title: Other cool feature
+  merge_status: pending
+  merge_requested_at: <%= 4.minute.ago.to_s(:db) %>
+  revalidated_at: <%= 4.minute.ago.to_s(:db) %>
+  merge_requested_by: walrus
+  github_id: 43434434343434
+  api_url: https://api.github.com/repos/shopify/shipit-engine/pulls/61
+  state: open
+  branch: feature-61
+  head_id: 8
+  mergeable: false
+  additions: 23
+  deletions: 43
+shipit_pending_not_mergeable_yet:
+  stack: shipit
+  number: 64
+  merge_status: pending
+  merge_requested_by: walrus
+  merge_requested_at: <%= 3.minute.ago.to_s(:db) %>
+  revalidated_at: <%= 3.minute.ago.to_s(:db) %>
+  github_id: 45454454545454
+  api_url: https://api.github.com/repos/shopify/shipit-engine/pulls/64
+  state: open
+  branch: feature-64
+  head_id: 8
+  mergeable: null
+  additions: 23
+  deletions: 43
+shipit_pending_closed:
+  stack: shipit
+  number: 65
+  merge_status: pending
+  merge_requested_by: walrus
+  merge_requested_at: <%= 3.minute.ago.to_s(:db) %>
+  revalidated_at: <%= 3.minute.ago.to_s(:db) %>
+  github_id: 43243243243243
+  api_url: https://api.github.com/repos/shopify/shipit-engine/pulls/65
+  state: closed
+  branch: feature-64
+  head_id: 8
+  mergeable: null
+  additions: 23
+  deletions: 43
+shipit_pending_merged:
+  stack: shipit
+  number: 66
+  merge_status: pending
+  merge_requested_by: walrus
+  merge_requested_at: <%= 3.minute.ago.to_s(:db) %>
+  merged_at: <%= 2.minute.ago.to_s(:db) %>
+  revalidated_at: <%= 3.minute.ago.to_s(:db) %>
+  github_id: 43243243243232
+  api_url: https://api.github.com/repos/shopify/shipit-engine/pulls/66
+  state: closed
+  branch: feature-64
+  head_id: 8
+  mergeable: null
+  additions: 23
+  deletions: 43
+shipit_mergeable_pending_ci:
+  stack: shipit
+  number: 67
+  title: Super duper nice feature
+  merge_status: pending
+  merge_requested_at: <%= 5.minute.ago.to_s(:db) %>
+  revalidated_at: <%= 5.minute.ago.to_s(:db) %>
+  merge_requested_by: walrus
+  github_id: 424244242424241
+  api_url: https://api.github.com/repos/shopify/shipit-engine/pulls/67
+  state: open
+  branch: feature-67
+  head_id: 4
+  mergeable: true
+  additions: 23
+  deletions: 43
+shipit_pending_expired:
+  stack: shipit
+  number: 68
+  title: Noice !
+  merge_status: pending
+  merge_requested_at: <%= 50.minute.ago.to_s(:db) %>
+  revalidated_at: <%= 25.minute.ago.to_s(:db) %>
+  merge_requested_by: walrus
+  github_id: 48484848484848
+  api_url: https://api.github.com/repos/shopify/shipit-engine/pulls/68
+  state: open
+  branch: feature-68
+  head_id: 8
+  mergeable: true
+  additions: 23
+  deletions: 43
+cyclimse_pending_merged:
+  id: 99
+  stack: cyclimse
+  number: 66
+  merge_status: merged
+  merge_requested_by: walrus
+  merge_requested_at: <%= 3.minute.ago.to_s(:db) %>
+  merged_at: <%= 2.minute.ago.to_s(:db) %>
+  revalidated_at: <%= 3.minute.ago.to_s(:db) %>
+  github_id: 43243243243232
+  api_url: https://api.github.com/repos/shopify/cyclimse/pulls/66
+  state: closed
+  branch: feature-64
+  head_id: 8
+  mergeable: null
+  additions: 23
+  deletions: 43

data/test/fixtures/shipit/pull_request_assignments.yml ADDED Viewed

@@ -0,0 +1,3 @@
+walrus_shopify_developers:
+  pull_request: shipit_pending
+  user: walrus

data/test/fixtures/shipit/pull_requests.yml CHANGED Viewed

@@ -1,141 +1,20 @@
-shipit_fetching:
-  stack: shipit
-  number: 63
-  merge_status: fetching
-  merge_requested_at: <%= 1.minute.ago.to_s(:db) %>
-  merge_requested_by: walrus
-shipit_pending:
+shipit_review:
   stack: shipit
   number: 62
   title: Super duper nice feature
-  merge_status: pending
-  merge_requested_at: <%= 5.minute.ago.to_s(:db) %>
-  revalidated_at: <%= 5.minute.ago.to_s(:db) %>
-  merge_requested_by: walrus
   github_id: 42424424242424
   api_url: https://api.github.com/repos/shopify/shipit-engine/pulls/62
   state: open
-  branch: feature-62
-  head_id: 8
-  mergeable: true
-  additions: 23
-  deletions: 43
-shipit_pending_unmergeable:
-  stack: shipit
-  number: 61
-  title: Other cool feature
-  merge_status: pending
-  merge_requested_at: <%= 4.minute.ago.to_s(:db) %>
-  revalidated_at: <%= 4.minute.ago.to_s(:db) %>
-  merge_requested_by: walrus
-  github_id: 43434434343434
-  api_url: https://api.github.com/repos/shopify/shipit-engine/pulls/61
-  state: open
-  branch: feature-61
-  head_id: 8
-  mergeable: false
-  additions: 23
-  deletions: 43
-shipit_pending_not_mergeable_yet:
-  stack: shipit
-  number: 64
-  merge_status: pending
-  merge_requested_by: walrus
-  merge_requested_at: <%= 3.minute.ago.to_s(:db) %>
-  revalidated_at: <%= 3.minute.ago.to_s(:db) %>
-  github_id: 45454454545454
-  api_url: https://api.github.com/repos/shopify/shipit-engine/pulls/64
-  state: open
-  branch: feature-64
-  head_id: 8
-  mergeable: null
-  additions: 23
-  deletions: 43
-shipit_pending_closed:
-  stack: shipit
-  number: 65
-  merge_status: pending
-  merge_requested_by: walrus
-  merge_requested_at: <%= 3.minute.ago.to_s(:db) %>
-  revalidated_at: <%= 3.minute.ago.to_s(:db) %>
-  github_id: 43243243243243
-  api_url: https://api.github.com/repos/shopify/shipit-engine/pulls/65
-  state: closed
-  branch: feature-64
-  head_id: 8
-  mergeable: null
-  additions: 23
-  deletions: 43
-shipit_pending_merged:
-  stack: shipit
-  number: 66
-  merge_status: pending
-  merge_requested_by: walrus
-  merge_requested_at: <%= 3.minute.ago.to_s(:db) %>
-  merged_at: <%= 2.minute.ago.to_s(:db) %>
-  revalidated_at: <%= 3.minute.ago.to_s(:db) %>
-  github_id: 43243243243232
-  api_url: https://api.github.com/repos/shopify/shipit-engine/pulls/66
-  state: closed
-  branch: feature-64
-  head_id: 8
-  mergeable: null
-  additions: 23
-  deletions: 43
-shipit_mergeable_pending_ci:
-  stack: shipit
-  number: 67
-  title: Super duper nice feature
-  merge_status: pending
-  merge_requested_at: <%= 5.minute.ago.to_s(:db) %>
-  revalidated_at: <%= 5.minute.ago.to_s(:db) %>
-  merge_requested_by: walrus
-  github_id: 424244242424241
-  api_url: https://api.github.com/repos/shopify/shipit-engine/pulls/67
-  state: open
-  branch: feature-67
-  head_id: 4
-  mergeable: true
   additions: 23
   deletions: 43
-shipit_pending_expired:
-  stack: shipit
-  number: 68
-  title: Noice !
-  merge_status: pending
-  merge_requested_at: <%= 50.minute.ago.to_s(:db) %>
-  revalidated_at: <%= 25.minute.ago.to_s(:db) %>
-  merge_requested_by: walrus
-  github_id: 48484848484848
-  api_url: https://api.github.com/repos/shopify/shipit-engine/pulls/68
+review_stack_review:
+  stack: review_stack
+  number: 100
+  head_id: 801
+  title: Review Stack Pull Request
+  github_id: 100110001
+  api_url: https://api.github.com/repos/shopify/shipit-engine/pulls/100
   state: open
-  branch: feature-68
-  head_id: 8
-  mergeable: true
-  additions: 23
-  deletions: 43
-cyclimse_pending_merged:
-  id: 99
-  stack: cyclimse
-  number: 66
-  merge_status: merged
-  merge_requested_by: walrus
-  merge_requested_at: <%= 3.minute.ago.to_s(:db) %>
-  merged_at: <%= 2.minute.ago.to_s(:db) %>
-  revalidated_at: <%= 3.minute.ago.to_s(:db) %>
-  github_id: 43243243243232
-  api_url: https://api.github.com/repos/shopify/cyclimse/pulls/66
-  state: closed
-  branch: feature-64
-  head_id: 8
-  mergeable: null
-  additions: 23
-  deletions: 43
+  additions: 1
+  deletions: 70