shipit-engine 0.28.1 → 0.33.0

data/test/models/membership_test.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'test_helper'
 
 module Shipit

data/test/models/{pull_request_test.rb → merge_request_test.rb}

@@ -1,24 +1,25 @@
+# frozen_string_literal: true
 require 'test_helper'
 
 module Shipit
-  class PullRequestTest < ActiveSupport::TestCase
+  class MergeRequestTest < ActiveSupport::TestCase
     setup do
       @stack = shipit_stacks(:shipit)
-      @pr = shipit_pull_requests(:shipit_pending)
+      @pr = shipit_merge_requests(:shipit_pending)
       @user = shipit_users(:walrus)
     end
 
     test ".request_merge! creates a record and schedule a refresh" do
-      pull_request = nil
-      assert_enqueued_with(job: RefreshPullRequestJob) do
-        pull_request = PullRequest.request_merge!(@stack, 64, @user)
+      merge_request = nil
+      assert_enqueued_with(job: RefreshMergeRequestJob) do
+        merge_request = MergeRequest.request_merge!(@stack, 64, @user)
       end
-      assert_predicate pull_request, :persisted?
+      assert_predicate merge_request, :persisted?
     end
 
     test ".request_merge! only track pull requests once" do
-      assert_difference -> { PullRequest.count }, +1 do
-        5.times { PullRequest.request_merge!(@stack, 999, @user) }
+      assert_difference -> { MergeRequest.count }, +1 do
+        5.times { MergeRequest.request_merge!(@stack, 999, @user) }
       end
     end
 
@@ -26,7 +27,7 @@ module Shipit
       original_merge_requested_at = @pr.merge_requested_at
       @pr.cancel!
       assert_predicate @pr, :canceled?
-      PullRequest.request_merge!(@stack, @pr.number, @user)
+      MergeRequest.request_merge!(@stack, @pr.number, @user)
       assert_predicate @pr.reload, :pending?
       assert_not_equal original_merge_requested_at, @pr.merge_requested_at
       assert_in_delta Time.now.utc, @pr.merge_requested_at, 2
@@ -36,7 +37,7 @@ module Shipit
       original_merge_requested_at = @pr.merge_requested_at
       @pr.reject!('merge_conflict')
       assert_predicate @pr, :rejected?
-      PullRequest.request_merge!(@stack, @pr.number, @user)
+      MergeRequest.request_merge!(@stack, @pr.number, @user)
       assert_predicate @pr.reload, :pending?
       assert_not_equal original_merge_requested_at, @pr.merge_requested_at
       assert_in_delta Time.now.utc, @pr.merge_requested_at, 2
@@ -47,29 +48,29 @@ module Shipit
       original_merge_requested_at = @pr.merge_requested_at
       @pr.revalidate!
       assert_predicate @pr, :revalidating?
-      PullRequest.request_merge!(@stack, @pr.number, @user)
+      MergeRequest.request_merge!(@stack, @pr.number, @user)
       assert_predicate @pr.reload, :pending?
       assert_equal original_merge_requested_at, @pr.merge_requested_at
     end
 
     test ".extract_number can get a pull request number from different formats" do
-      assert_equal 42, PullRequest.extract_number(@stack, '42')
-      assert_equal 42, PullRequest.extract_number(@stack, '#42')
-      assert_equal 42, PullRequest.extract_number(@stack, 'https://github.com/Shopify/shipit-engine/pull/42')
+      assert_equal 42, MergeRequest.extract_number(@stack, '42')
+      assert_equal 42, MergeRequest.extract_number(@stack, '#42')
+      assert_equal 42, MergeRequest.extract_number(@stack, 'https://github.com/Shopify/shipit-engine/pull/42')
 
-      assert_nil PullRequest.extract_number(@stack, 'https://github.com/ACME/shipit-engine/pull/42')
+      assert_nil MergeRequest.extract_number(@stack, 'https://github.com/ACME/shipit-engine/pull/42')
 
       Shipit.github.expects(:domain).returns('github.acme.com').at_least_once
-      assert_equal 42, PullRequest.extract_number(@stack, 'https://github.acme.com/Shopify/shipit-engine/pull/42')
-      assert_nil PullRequest.extract_number(@stack, 'https://github.com/Shopify/shipit-engine/pull/42')
+      assert_equal 42, MergeRequest.extract_number(@stack, 'https://github.acme.com/Shopify/shipit-engine/pull/42')
+      assert_nil MergeRequest.extract_number(@stack, 'https://github.com/Shopify/shipit-engine/pull/42')
     end
 
     test "refresh! pulls state from GitHub" do
-      pull_request = shipit_pull_requests(:shipit_fetching)
+      merge_request = shipit_merge_requests(:shipit_fetching)
 
       head_sha = '64b3833d39def7ec65b57b42f496eb27ab4980b6'
       base_sha = 'ba7ab50e02286f7d6c60c1ef75258133dd9ea763'
-      Shipit.github.api.expects(:pull_request).with(@stack.github_repo_name, pull_request.number).returns(
+      Shipit.github.api.expects(:pull_request).with(@stack.github_repo_name, merge_request.number).returns(
         stub(
           id: 4_857_578,
           url: 'https://api.github.com/repos/Shopify/shipit-engine/pulls/64',
@@ -116,7 +117,7 @@ module Shipit
         )
       end
 
-      Shipit.github.api.expects(:statuses).with(@stack.github_repo_name, head_sha).returns([stub(
+      Shipit.github.api.expects(:statuses).with(@stack.github_repo_name, head_sha, per_page: 100).returns([stub(
         state: 'success',
         description: nil,
         context: 'default',
@@ -124,15 +125,15 @@ module Shipit
         created_at: 1.day.ago,
       )])
 
-      pull_request.refresh!
+      merge_request.refresh!
 
-      assert_predicate pull_request, :mergeable?
-      assert_predicate pull_request, :pending?
-      assert_equal 'super-branch', pull_request.branch
+      assert_predicate merge_request, :mergeable?
+      assert_predicate merge_request, :pending?
+      assert_equal 'super-branch', merge_request.branch
 
-      assert_not_nil pull_request.head
-      assert_predicate pull_request.head, :detached?
-      assert_predicate pull_request.head, :success?
+      assert_not_nil merge_request.head
+      assert_predicate merge_request.head, :detached?
+      assert_predicate merge_request.head, :success?
     end
 
     test "#reject! records the reason" do
@@ -183,23 +184,29 @@ module Shipit
       refute_predicate @pr, :rejected?
     end
 
-    test "#reject_unless_mergeable! reject the PR if it has a missing CI status" do
+    test "#reject_unless_mergeable! reject the PR if it has a missing required CI status" do
+      @pr.stack.cached_deploy_spec.stubs(:required_statuses).returns(['ci/circle'])
       @pr.head.statuses.where(context: 'ci/circle').delete_all
 
-      assert_predicate @pr, :all_status_checks_passed?
+      refute_predicate @pr, :all_status_checks_passed?
       refute_predicate @pr, :any_status_checks_failed?
-      assert_equal false, @pr.reject_unless_mergeable!
-      refute_predicate @pr, :rejected?
+      assert_predicate @pr, :any_status_checks_missing?
+      assert_equal true, @pr.reject_unless_mergeable!
+      assert_predicate @pr, :rejected?
+      assert_equal 'ci_missing', @pr.rejection_reason
     end
 
     test "#reject_unless_mergeable! reject the PR if it has a missing CI status (multi-status)" do
+      @pr.stack.cached_deploy_spec.stubs(:required_statuses).returns(['ci/circle'])
       @pr.head.statuses.where(context: 'ci/circle').delete_all
       @pr.head.statuses.create!(stack: @pr.stack, state: 'success', context: 'ci/travis')
 
-      assert_predicate @pr, :all_status_checks_passed?
+      refute_predicate @pr, :all_status_checks_passed?
       refute_predicate @pr, :any_status_checks_failed?
-      assert_equal false, @pr.reject_unless_mergeable!
-      refute_predicate @pr, :rejected?
+      assert_predicate @pr, :any_status_checks_missing?
+      assert_equal true, @pr.reject_unless_mergeable!
+      assert_predicate @pr, :rejected?
+      assert_equal 'ci_missing', @pr.rejection_reason
     end
 
     test "#reject_unless_mergeable! rejects the PR if it is stale" do
@@ -209,11 +216,11 @@ module Shipit
       assert_equal 'requires_rebase', @pr.rejection_reason
     end
 
-    test "#merge! raises a PullRequest::NotReady if the PR isn't mergeable yet" do
+    test "#merge! raises a MergeRequest::NotReady if the PR isn't mergeable yet" do
       @pr.update!(mergeable: nil)
 
       assert_predicate @pr, :not_mergeable_yet?
-      assert_raises PullRequest::NotReady do
+      assert_raises MergeRequest::NotReady do
         @pr.merge!
       end
       @pr.reload
@@ -227,8 +234,8 @@ module Shipit
       params = job.arguments.first
       assert_equal 'merge', params[:event]
       assert_json 'status', 'rejected', document: params[:payload]
-      assert_json 'pull_request.rejection_reason', 'merge_conflict', document: params[:payload]
-      assert_json 'pull_request.number', @pr.number, document: params[:payload]
+      assert_json 'merge_request.rejection_reason', 'merge_conflict', document: params[:payload]
+      assert_json 'merge_request.number', @pr.number, document: params[:payload]
     end
 
     test "#merge! doesnt delete the branch if there are open PRs against it" do
@@ -265,7 +272,7 @@ module Shipit
           behind_by: 10,
         ),
       )
-      spec = {'merge' => {'max_divergence' => {'commits' => 1}}}
+      spec = { 'merge' => { 'max_divergence' => { 'commits' => 1 } } }
       @pr.stack.cached_deploy_spec = DeploySpec.new(spec)
       assert_predicate @pr, :stale?
     end
@@ -273,14 +280,14 @@ module Shipit
     test "#stale? returns true when the branch falls behind the maximum age" do
       @pr.base_commit = shipit_commits(:second)
       @pr.head.committed_at = 2.hours.ago
-      spec = {'merge' => {'max_divergence' => {'age' => '1h'}}}
+      spec = { 'merge' => { 'max_divergence' => { 'age' => '1h' } } }
       @pr.stack.cached_deploy_spec = DeploySpec.new(spec)
       assert_predicate @pr, :stale?
     end
 
     test "#stale? is false when base_commit information is missing" do
       @pr.base_commit = nil
-      spec = {'merge' => {'max_divergence' => {'age' => '1h', 'commits' => 10}}}
+      spec = { 'merge' => { 'max_divergence' => { 'age' => '1h', 'commits' => 10 } } }
       @pr.stack.cached_deploy_spec = DeploySpec.new(spec)
       refute_predicate @pr, :stale?
     end

data/test/models/pull_request_assignment_test.rb

@@ -0,0 +1,16 @@
+# frozen_string_literal: true
+
+require 'test_helper'
+
+module Shipit
+  class PullRequestAssignmentTest < ActiveSupport::TestCase
+    setup do
+      @assignment = shipit_pull_request_assignments(:walrus_shopify_developers)
+    end
+
+    test "no duplicates are accepted" do
+      assignment = PullRequestAssignment.new(user: @assignment.user, pull_request: @assignment.pull_request)
+      refute assignment.valid?
+    end
+  end
+end

data/test/models/release_statuses_test.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'test_helper'
 
 module Shipit

data/test/models/rollbacks_test.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'test_helper'
 
 module Shipit

data/test/models/shipit/check_run_test.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'test_helper'
 
 module Shipit

data/test/models/shipit/provisioning_handler/base_test.rb

@@ -0,0 +1,33 @@
+# frozen_string_literal: true
+
+require 'test_helper'
+
+module Shipit
+  module ProvisioningHandler
+    class BaseTest < ActiveSupport::TestCase
+      test "provides a default #up handler" do
+        assert(
+          handler.respond_to?(:up),
+          "expected #{handler.class.name} to provide a default #up handler"
+        )
+      end
+
+      test "provides a default #down handler" do
+        assert(
+          handler.respond_to?(:down),
+          "expected #{handler.class.name} to provide a default #down handler"
+        )
+      end
+
+      test "provides a default #provision? handler" do
+        assert_equal true, handler.provision?
+      end
+
+      private
+
+      def handler
+        ProvisioningHandler::Base.new(mock("Stack"))
+      end
+    end
+  end
+end

data/test/models/shipit/provisioning_handler/unregistered_provisioning_handler_test.rb

@@ -0,0 +1,49 @@
+# frozen_string_literal: true
+
+require 'test_helper'
+
+module Shipit
+  module ProvisioningHandler
+    class UnregisteredProvisioningHandlerTest < ActiveSupport::TestCase
+      test "#up stops transitions" do
+        stack = shipit_stacks(:shipit)
+        stack.update(provision_status: :deprovisioned)
+
+        assert_throws :halt do
+          UnregisteredProvisioningHandler.new(stack).up
+        end
+      end
+
+      test "#up locks the stack" do
+        stack = shipit_stacks(:shipit)
+        stack.update(provision_status: :deprovisioned)
+
+        assert_changes -> { stack.locked? }, from: false, to: true do
+          catch :halt do
+            UnregisteredProvisioningHandler.new(stack).up
+          end
+        end
+      end
+
+      test "#down stops transitions" do
+        stack = shipit_stacks(:shipit)
+        stack.update(provision_status: :deprovisioned)
+
+        assert_throws :halt do
+          UnregisteredProvisioningHandler.new(stack).down
+        end
+      end
+
+      test "#down prevents transitions" do
+        stack = shipit_stacks(:shipit)
+        stack.update(provision_status: :deprovisioned)
+
+        assert_changes -> { stack.locked? }, from: false, to: true do
+          catch :halt do
+            UnregisteredProvisioningHandler.new(stack).down
+          end
+        end
+      end
+    end
+  end
+end

data/test/models/shipit/provisioning_handler_test.rb

@@ -0,0 +1,64 @@
+# frozen_string_literal: true
+
+require 'test_helper'
+
+module Shipit
+  class StackProvisioningHandlerTest < ActiveSupport::TestCase
+    teardown do
+      Shipit::ProvisioningHandler.reset_registry!
+    end
+
+    test "uses the no-op handler as default when no default handler is registered" do
+      assert_equal Shipit::ProvisioningHandler::Base, Shipit::ProvisioningHandler.default
+    end
+
+    test "allows registration of a default handler" do
+      mock_handler = mock("Mock Provisioning Handler")
+
+      Shipit::ProvisioningHandler.default = mock_handler
+
+      assert_equal mock_handler, Shipit::ProvisioningHandler.default
+    end
+
+    test "UnregisteredProvisioningHandler is returned when an attempt to fetch an unregistered handler is made" do
+      unregistered_handler = mock("Mock Provisioning Handler")
+
+      assert_equal(
+        Shipit::ProvisioningHandler::UnregisteredProvisioningHandler,
+        Shipit::ProvisioningHandler.fetch(unregistered_handler)
+      )
+    end
+
+    test "registers handlers so they become fetchable" do
+      mock_handler = mock("Mock Provisioning Handler")
+
+      Shipit::ProvisioningHandler.register(mock_handler)
+
+      assert_equal mock_handler, Shipit::ProvisioningHandler.fetch(mock_handler.to_s)
+    end
+
+    test "handlers are called during provisioning" do
+      stack = shipit_stacks(:review_stack)
+      stack.update(
+        provision_status: :deprovisioned
+      )
+      handler = Shipit::ProvisioningHandler.default
+
+      handler.any_instance.expects(:up)
+
+      assert stack.provision!, "stack should have provisioned."
+    end
+
+    test "handlers are called during deprovisioning" do
+      stack = shipit_stacks(:review_stack)
+      stack.update(
+        provision_status: :provisioned
+      )
+      handler = Shipit::ProvisioningHandler.default
+
+      handler.any_instance.expects(:down)
+
+      assert stack.deprovision!, "stack should have deprovisioned."
+    end
+  end
+end

data/test/models/shipit/pull_request_test.rb

@@ -0,0 +1,52 @@
+# frozen_string_literal: true
+
+require "test_helper"
+
+module Shipit
+  class PullRequestTest < ActiveSupport::TestCase
+    test "github_pull_request= parses into a a Shipit::PullRequest" do
+      github_pull_request = resource(
+        {
+          url: "https://api.github.com/repos/Codertocat/Hello-World/pulls/2",
+          id: 279147437,
+          number: 2,
+          state: "open",
+          additions: 100,
+          deletions: 101,
+          title: "Update the README with new information.",
+          head: {
+            sha: "ec26c3e57ca3a959ca5aad62de7213c562f8c821",
+          },
+          user: {
+            login: "Codertocat",
+          },
+          assignees: [
+            {
+              login: "bob",
+            },
+          ],
+          labels: [
+            {
+              name: "deploy",
+            },
+          ],
+        }
+      )
+      stack = shipit_stacks(:review_stack)
+      pull_request = stack.pull_request
+
+      stack.pull_request.github_pull_request = github_pull_request
+
+      assert_equal 279147437, pull_request.github_id
+      assert_equal 2, pull_request.number
+      assert_equal "https://api.github.com/repos/Codertocat/Hello-World/pulls/2", pull_request.api_url
+      assert_equal "Update the README with new information.", pull_request.title
+      assert_equal "open", pull_request.state
+      assert_equal 100, pull_request.additions
+      assert_equal 101, pull_request.deletions
+      assert_equal shipit_users(:codertocat), pull_request.user
+      assert_equal [shipit_users(:bob)], pull_request.assignees
+      assert_equal ["deploy"], pull_request.labels
+    end
+  end
+end