shipit-engine 0.28.1 → 0.33.0

data/test/controllers/api/stacks_controller_test.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'test_helper'
 
 module Shipit
@@ -13,7 +14,7 @@ module Shipit
         @client.save!
 
         assert_no_difference 'Stack.count' do
-          post :create, params: {repo_name: 'rails', repo_owner: 'rails', environment: 'staging', branch: 'staging'}
+          post :create, params: { repo_name: 'rails', repo_owner: 'rails', environment: 'staging', branch: 'staging' }
         end
 
         assert_response :forbidden
@@ -22,15 +23,15 @@ module Shipit
 
       test "#create fails with invalid stack" do
         assert_no_difference "Stack.count" do
-          post :create, params: {repo_owner: 'some', repo_name: 'owner/path'}
+          post :create, params: { repo_owner: 'some', repo_name: 'owner/path' }
         end
         assert_response :unprocessable_entity
-        assert_json 'errors', 'repo_name' => ['is invalid']
+        assert_json 'errors', 'repository' => ['is invalid']
       end
 
       test "#create creates a stack and renders it back" do
         assert_difference -> { Stack.count } do
-          post :create, params: {repo_name: 'rails', repo_owner: 'rails', environment: 'staging', branch: 'staging'}
+          post :create, params: { repo_name: 'rails', repo_owner: 'rails', environment: 'staging', branch: 'staging' }
         end
 
         assert_response :ok
@@ -38,24 +39,51 @@ module Shipit
       end
 
       test "#create fails to create stack if it already exists" do
-        Stack.create!(
-          repo_name: 'rails',
-          repo_owner: 'rails',
+        repository = shipit_repositories(:rails)
+        existing_stack = Stack.create!(
+          repository: repository,
           environment: 'staging',
           branch: 'staging',
         )
 
         assert_no_difference -> { Stack.count } do
-          post :create, params: {repo_name: 'rails', repo_owner: 'rails', environment: 'staging', branch: 'staging'}
+          post :create,
+               params: {
+                 repo_name: existing_stack.repo_name,
+                 repo_owner: existing_stack.repo_owner,
+                 environment: existing_stack.environment,
+                 branch: existing_stack.branch,
+               }
         end
 
         assert_response :unprocessable_entity
-        assert_json 'errors', 'repo_name' => ['cannot be used more than once with this environment']
+        assert_json 'errors', 'repository' => [
+          'cannot be used more than once with this environment. Check archived stacks.',
+        ]
+      end
+
+      test "#update updates a stack and renders it back" do
+        assert_equal true, @stack.merge_queue_enabled
+        assert_equal false, @stack.ignore_ci
+        assert_equal false, @stack.continuous_deployment
+
+        patch :update, params: {
+          id: @stack.to_param,
+          merge_queue_enabled: false,
+          ignore_ci: true,
+          continuous_deployment: true,
+        }
+
+        assert_response :ok
+        @stack.reload
+
+        assert_equal false, @stack.merge_queue_enabled
+        assert_equal true, @stack.ignore_ci
+        assert_equal true, @stack.continuous_deployment
       end
 
       test "#index returns a list of stacks" do
         stack = Stack.last
-
         get :index
         assert_response :ok
         assert_json '0.id', stack.id
@@ -64,8 +92,29 @@ module Shipit
         end
       end
 
+      test "#index returns a list of stacks filtered by repo if name and owner given" do
+        repo = shipit_repositories(:shipit)
+        get :index, params: { repo_owner: repo.owner, repo_name: repo.name }
+        assert_response :ok
+        assert_json do |stacks|
+          assert_equal stacks.size, repo.stacks.size
+        end
+      end
+
+      test "#index returns a list of stacks filtered by repo and api client" do
+        authenticate!(:here_come_the_walrus)
+
+        repo = shipit_repositories(:soc)
+
+        get :index, params: { repo_owner: repo.owner, repo_name: repo.name }
+        assert_response :ok
+        assert_json do |stacks|
+          assert_equal 0, stacks.size
+        end
+      end
+
       test "#index is paginable" do
-        get :index, params: {page_size: 1}
+        get :index, params: { page_size: 1 }
         assert_json do |list|
           assert_instance_of Array, list
           assert_equal 1, list.size
@@ -77,7 +126,7 @@ module Shipit
       end
 
       test "the `next` link is not provided when the last page is reached" do
-        get :index, params: {page_size: Stack.count}
+        get :index, params: { page_size: Stack.count }
         assert_no_link 'next'
       end
 
@@ -97,20 +146,20 @@ module Shipit
       end
 
       test "#show renders the stack" do
-        get :show, params: {id: @stack.to_param}
+        get :show, params: { id: @stack.to_param }
         assert_response :ok
         assert_json 'id', @stack.id
       end
 
       test "#show returns last_deployed_at column for stack" do
-        get :show, params: {id: @stack.to_param}
+        get :show, params: { id: @stack.to_param }
         assert_response :ok
         assert_json 'last_deployed_at', @stack.last_deployed_at
       end
 
       test "#destroy schedules stack deletion job" do
         assert_enqueued_with(job: DestroyStackJob) do
-          delete :destroy, params: {id: @stack.to_param}
+          delete :destroy, params: { id: @stack.to_param }
         end
         assert_response :accepted
       end
@@ -120,7 +169,7 @@ module Shipit
         @client.save!
 
         assert_no_difference 'Stack.count' do
-          delete :destroy, params: {id: @stack.to_param}
+          delete :destroy, params: { id: @stack.to_param }
         end
 
         assert_response :forbidden

data/test/controllers/api/tasks_controller_test.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'test_helper'
 
 module Shipit
@@ -11,7 +12,7 @@ module Shipit
       test "#index returns a list of tasks" do
         task = @stack.tasks.last
 
-        get :index, params: {stack_id: @stack.to_param}
+        get :index, params: { stack_id: @stack.to_param }
         assert_response :ok
         assert_json '0.id', task.id
       end
@@ -19,18 +20,18 @@ module Shipit
       test "#show returns a task" do
         task = @stack.tasks.last
 
-        get :show, params: {stack_id: @stack.to_param, id: task.id}
+        get :show, params: { stack_id: @stack.to_param, id: task.id }
         assert_response :ok
         assert_json 'id', task.id
       end
 
       test "#trigger returns 404 with unknown task" do
-        post :trigger, params: {stack_id: @stack.to_param, task_name: 'shave_the_yak'}
+        post :trigger, params: { stack_id: @stack.to_param, task_name: 'shave_the_yak' }
         assert_response :not_found
       end
 
       test "#trigger triggers a custom task" do
-        post :trigger, params: {stack_id: @stack.to_param, task_name: 'restart'}
+        post :trigger, params: { stack_id: @stack.to_param, task_name: 'restart' }
         assert_response :accepted
         assert_json 'type', 'task'
         assert_json 'status', 'pending'
@@ -43,15 +44,15 @@ module Shipit
       end
 
       test "#trigger refuses to trigger a task with tasks not whitelisted" do
-        env = {'DANGEROUS_VARIABLE' => 'bar'}
-        post :trigger, params: {stack_id: @stack.to_param, task_name: 'restart', env: env}
+        env = { 'DANGEROUS_VARIABLE' => 'bar' }
+        post :trigger, params: { stack_id: @stack.to_param, task_name: 'restart', env: env }
         assert_response :unprocessable_entity
         assert_json 'message', 'Variables DANGEROUS_VARIABLE have not been whitelisted'
       end
 
       test "#trigger triggers a task with only whitelisted env variables" do
-        env = {'FOO' => 'bar'}
-        post :trigger, params: {stack_id: @stack.to_param, task_name: 'restart', env: env}
+        env = { 'FOO' => 'bar' }
+        post :trigger, params: { stack_id: @stack.to_param, task_name: 'restart', env: env }
         assert_response :accepted
         assert_json 'type', 'task'
         assert_json 'status', 'pending'
@@ -64,8 +65,8 @@ module Shipit
       end
 
       test "#trigger triggers a task with explicitly passed and default variables" do
-        env = {'WALRUS' => 'overridden value'}
-        post :trigger, params: {stack_id: @stack.to_param, task_name: 'restart', env: env}
+        env = { 'WALRUS' => 'overridden value' }
+        post :trigger, params: { stack_id: @stack.to_param, task_name: 'restart', env: env }
         assert_response :accepted
 
         # FOO and BAR are variables with a default value
@@ -78,14 +79,14 @@ module Shipit
       end
 
       test "#trigger returns a 404 when the task doesn't exist" do
-        post :trigger, params: {stack_id: @stack.to_param, task_name: 'doesnt_exist'}
+        post :trigger, params: { stack_id: @stack.to_param, task_name: 'doesnt_exist' }
         assert_response :not_found
       end
 
       test "#trigger returns 409 when a task is already running" do
         shipit_deploys(:shipit_running).update!(allow_concurrency: false, status: 'running')
         assert_predicate @stack, :active_task?
-        post :trigger, params: {stack_id: @stack.to_param, task_name: 'restart'}
+        post :trigger, params: { stack_id: @stack.to_param, task_name: 'restart' }
         assert_response :conflict
         assert_json 'message', 'A task is already running.'
       end

data/test/controllers/api_clients_controller_test.rb

@@ -0,0 +1,104 @@
+# frozen_string_literal: true
+
+require 'test_helper'
+
+module Shipit
+  class ApiClientsControllerTest < ActionController::TestCase
+    setup do
+      @routes = Shipit::Engine.routes
+      @api_client = shipit_api_clients(:here_come_the_walrus)
+      session[:user_id] = shipit_users(:walrus).id
+    end
+
+    test "GitHub authentication is mandatory" do
+      session[:user_id] = nil
+      get :index
+      assert_redirected_to '/github/auth/github?origin=http%3A%2F%2Ftest.host%2Fapi_clients'
+    end
+
+    test "current_user must be a member of at least a Shipit.github_teams" do
+      session[:user_id] = shipit_users(:bob).id
+      Shipit.stubs(:github_teams).returns([shipit_teams(:cyclimse_cooks), shipit_teams(:shopify_developers)])
+      get :index
+      assert_response :forbidden
+      assert_equal(
+        'You must be a member of cyclimse/cooks or shopify/developers to access this application.',
+        response.body,
+      )
+    end
+
+    test "#index is successful with a valid user" do
+      get :index
+      assert_response :ok
+    end
+
+    test "#new is success" do
+      get :new
+      assert_response :ok
+    end
+
+    test "#create creates a new api_client" do
+      assert_difference "ApiClient.count", +1 do
+        post :create, params: {
+          api_client: {
+            name: 'walrus_app',
+            permissions: [
+              'read:stack',
+              'lock:stack',
+            ],
+          },
+        }
+      end
+
+      assert_redirected_to api_client_path(ApiClient.last)
+    end
+
+    test "#create attaches the current user to the created api client" do
+      post :create, params: {
+        api_client: {
+          name: 'walrus_app',
+          permissions: [
+            'read:stack',
+            'lock:stack',
+          ],
+        },
+      }
+
+      assert_equal shipit_users(:walrus).id, ApiClient.last.creator.id
+    end
+
+    test "#create when not valid renders new" do
+      assert_no_difference "Stack.count" do
+        post :create, params: { api_client: { name: 'walrus_app', permissions: ['invalid'] } }
+      end
+
+      assert flash[:warning]
+      assert_response :success
+    end
+
+    test "#show is success" do
+      get :show, params: { id: @api_client.id }
+      assert_response :ok
+    end
+
+    test "#update updates an existing api_client" do
+      new_permissions = [
+        'read:stack',
+        'lock:stack',
+      ]
+
+      assert_difference "ApiClient.count", 0 do
+        patch :update, params: {
+          id: @api_client.id,
+          api_client: {
+            permissions: new_permissions,
+          },
+        }
+      end
+      @api_client.reload
+
+      assert_redirected_to api_client_path(@api_client)
+      assert_equal new_permissions, @api_client.permissions
+    end
+  end
+end

data/test/controllers/ccmenu_controller_test.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'uri'
 require 'test_helper'
 
@@ -10,7 +11,7 @@ module Shipit
     end
 
     test ":fetch returns ok with json" do
-      get :fetch, params: {stack_id: @stack.to_param}
+      get :fetch, params: { stack_id: @stack.to_param }
       assert_response :ok
       data = JSON.parse(response.body)
       assert_includes data, 'ccmenu_url'
@@ -18,12 +19,12 @@ module Shipit
 
     test ":fetch creates a read only api client" do
       assert_difference 'ApiClient.count' do
-        get :fetch, params: {stack_id: @stack.to_param}
+        get :fetch, params: { stack_id: @stack.to_param }
       end
     end
 
     test ":fetch url includes api token on query string" do
-      get :fetch, params: {stack_id: @stack.to_param}
+      get :fetch, params: { stack_id: @stack.to_param }
       data = JSON.parse(response.body)
       client = ApiClient.last
       query = Rack::Utils.parse_nested_query(URI(data['ccmenu_url']).query)

data/test/controllers/commit_checks_controller_test.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'test_helper'
 
 module Shipit
@@ -12,7 +13,7 @@ module Shipit
     end
 
     test ":tail is success" do
-      get :tail, params: {stack_id: @stack.to_param, sha: @commit.sha}
+      get :tail, params: { stack_id: @stack.to_param, sha: @commit.sha }
       assert_response :success
       assert_json 'output', 'foobar'
       assert_json 'url', stack_tail_commit_checks_path(@stack, sha: @commit.sha, since: 6)
@@ -21,14 +22,14 @@ module Shipit
 
     test ":tail doesn't provide another url if the task is finished" do
       @checks.status = 'success'
-      get :tail, params: {stack_id: @stack.to_param, sha: @commit.sha}
+      get :tail, params: { stack_id: @stack.to_param, sha: @commit.sha }
       assert_response :success
       assert_json 'url', nil
     end
 
     test ":tail returns only the output after the provided offset" do
       @checks.status = 'success'
-      get :tail, params: {stack_id: @stack.to_param, sha: @commit.sha, since: 5}
+      get :tail, params: { stack_id: @stack.to_param, sha: @commit.sha, since: 5 }
       assert_response :success
       assert_json 'output', 'r'
     end

data/test/controllers/commits_controller_test.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'test_helper'
 
 module Shipit
@@ -15,7 +16,7 @@ module Shipit
       patch(:update, params: {
         stack_id: @stack.to_param,
         id: @commit.id,
-        commit: {locked: true},
+        commit: { locked: true },
       })
 
       assert_response(:ok)
@@ -30,7 +31,7 @@ module Shipit
       patch(:update, params: {
         stack_id: @stack.to_param,
         id: @commit.id,
-        commit: {locked: false},
+        commit: { locked: false },
       })
 
       assert_response(:ok)

data/test/controllers/deploys_controller_test.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'test_helper'
 
 module Shipit
@@ -12,30 +13,30 @@ module Shipit
     end
 
     test ":show is success" do
-      get :show, params: {stack_id: @stack.to_param, id: @stack.deploys.last.id}
+      get :show, params: { stack_id: @stack.to_param, id: @stack.deploys.last.id }
       assert_response :success
     end
 
     test "deploys can be observed as raw text" do
-      get :show, params: {stack_id: @stack, id: @deploy.id, format: 'txt'}
+      get :show, params: { stack_id: @stack, id: @deploy.id, format: 'txt' }
       assert_response :success
-      assert_equal("text/plain", @response.content_type)
+      assert_equal("text/plain", @response.media_type)
     end
 
     test ":new is success" do
-      get :new, params: {stack_id: @stack.to_param, sha: @commit.sha}
+      get :new, params: { stack_id: @stack.to_param, sha: @commit.sha }
       assert_response :success
     end
 
     test ":new works for not yet deployed stacks" do
       @stack = shipit_stacks(:undeployed_stack)
-      get :new, params: {stack_id: @stack.to_param, sha: @stack.commits.last.sha}
+      get :new, params: { stack_id: @stack.to_param, sha: @stack.commits.last.sha }
     end
 
     test ":new shows a warning if a deploy is already running" do
       shipit_deploys(:shipit_running).update!(allow_concurrency: false, status: 'running')
 
-      get :new, params: {stack_id: @stack.to_param, sha: @commit.sha}
+      get :new, params: { stack_id: @stack.to_param, sha: @commit.sha }
       assert_response :success
       assert_select '.warning.concurrent-deploy h2' do |elements|
         assert_equal 'Lando Walrussian is already deploying!', elements.first.text
@@ -43,21 +44,31 @@ module Shipit
       assert_select '#new_deploy #force', 1
     end
 
+    test ":new selects default value" do
+      @stack = shipit_stacks(:shipit_undeployed)
+      get :new, params: { stack_id: @stack.to_param, sha: @stack.commits.last.sha }
+      assert_response :success
+
+      assert_select '.variables-fields option[selected=selected]' do |elements|
+        assert_equal 'us-central', elements.first.text
+      end
+    end
+
     test ":create persists a new deploy" do
       assert_difference '@stack.deploys.count', 1 do
-        post :create, params: {stack_id: @stack.to_param, deploy: {until_commit_id: @commit.id}}
+        post :create, params: { stack_id: @stack.to_param, deploy: { until_commit_id: @commit.id } }
       end
     end
 
     test ":create can receive an :env hash" do
-      env = {'SAFETY_DISABLED' => '1'}
-      post :create, params: {stack_id: @stack.to_param, deploy: {until_commit_id: @commit.id, env: env}}
+      env = { 'SAFETY_DISABLED' => '1' }
+      post :create, params: { stack_id: @stack.to_param, deploy: { until_commit_id: @commit.id, env: env } }
       new_deploy = Deploy.last
       assert_equal env, new_deploy.env
     end
 
     test ":create ignore :env keys not declared in the deploy spec" do
-      post :create, params: {stack_id: @stack.to_param, deploy: {until_commit_id: @commit.id, env: {'H4X0R' => '1'}}}
+      post :create, params: { stack_id: @stack.to_param, deploy: { until_commit_id: @commit.id, env: { 'H4X0R' => '1' } } }
       new_deploy = Deploy.last
       assert_equal({}, new_deploy.env)
     end
@@ -66,7 +77,7 @@ module Shipit
       shipit_deploys(:shipit_running).update_column(:status, 'running')
 
       assert_difference '@stack.deploys.count', 1 do
-        post :create, params: {stack_id: @stack.to_param, deploy: {until_commit_id: @commit.id}, force: 'true'}
+        post :create, params: { stack_id: @stack.to_param, deploy: { until_commit_id: @commit.id }, force: 'true' }
       end
     end
 
@@ -74,26 +85,26 @@ module Shipit
       shipit_deploys(:shipit_running).update!(allow_concurrency: false, status: 'running')
 
       assert_no_difference '@stack.deploys.count' do
-        post :create, params: {stack_id: @stack.to_param, deploy: {until_commit_id: @commit.id}}
+        post :create, params: { stack_id: @stack.to_param, deploy: { until_commit_id: @commit.id } }
       end
       assert_redirected_to new_stack_deploy_path(@stack, sha: @commit.sha)
     end
 
     test ":create redirects to the new deploy" do
-      post :create, params: {stack_id: @stack.to_param, deploy: {until_commit_id: @commit.id}}
+      post :create, params: { stack_id: @stack.to_param, deploy: { until_commit_id: @commit.id } }
       new_deploy = Deploy.last
       assert_redirected_to stack_deploy_path(@stack, new_deploy)
     end
 
     test ":rollback is success" do
-      get :rollback, params: {stack_id: @stack.to_param, id: @deploy.id}
+      get :rollback, params: { stack_id: @stack.to_param, id: @deploy.id }
       assert_response :success
     end
 
     test ":rollback shows a warning if a deploy is already running" do
       shipit_deploys(:shipit_running).update!(allow_concurrency: false, status: 'running')
 
-      get :rollback, params: {stack_id: @stack.to_param, id: @deploy.id}
+      get :rollback, params: { stack_id: @stack.to_param, id: @deploy.id }
       assert_response :success
       assert_select '.warning.concurrent-deploy h2' do |elements|
         assert_equal 'Lando Walrussian is already deploying!', elements.first.text
@@ -118,13 +129,13 @@ module Shipit
 
       rollback_commit = @stack.commits.where(id: 2).first
 
-      get :show, params: {stack_id: @stack, id: latest_deploy.id, format: 'html'}
+      get :show, params: { stack_id: @stack, id: latest_deploy.id, format: 'html' }
 
       expected_result = "Abort and Rollback to <span class=\"short-sha-no-bg\">#{rollback_commit.short_sha}</span>"
       expected_rolling_back_element = "Aborting with Rollback... to <span class=\"short-sha-no-bg\">#{rollback_commit.short_sha}</span>"
 
-      assert_select 'span.caption--ready', {html: expected_result}, "rollback button element was not found, or did not match the expected result of '#{expected_result}'"
-      assert_select 'span.caption--pending', {html: expected_rolling_back_element}, "ready rollback button element was not found, or did not match the expected result of '#{expected_rolling_back_element}'"
+      assert_select 'span.caption--ready', { html: expected_result }, "rollback button element was not found, or did not match the expected result of '#{expected_result}'"
+      assert_select 'span.caption--pending', { html: expected_rolling_back_element }, "ready rollback button element was not found, or did not match the expected result of '#{expected_rolling_back_element}'"
     end
 
     test ":rollback (regression) works correctly when a previous deploy is not found" do
@@ -140,17 +151,17 @@ module Shipit
 
       rollback_commit = @stack.commits.where(id: rollback_commit_id).take
 
-      get :show, params: {stack_id: @stack, id: latest_deploy.id, format: 'html'}
+      get :show, params: { stack_id: @stack, id: latest_deploy.id, format: 'html' }
 
       expected_result = "Abort and Rollback to <span class=\"short-sha-no-bg\">#{rollback_commit.short_sha}</span>"
       expected_rolling_back_element = "Aborting with Rollback... to <span class=\"short-sha-no-bg\">#{rollback_commit.short_sha}</span>"
 
-      assert_select 'span.caption--ready', {html: expected_result}, "rollback button element was not found, or did not match the expected result of '#{expected_result}'"
-      assert_select 'span.caption--pending', {html: expected_rolling_back_element}, "ready rollback button element was not found, or did not match the expected result of '#{expected_rolling_back_element}'"
+      assert_select 'span.caption--ready', { html: expected_result }, "rollback button element was not found, or did not match the expected result of '#{expected_result}'"
+      assert_select 'span.caption--pending', { html: expected_rolling_back_element }, "ready rollback button element was not found, or did not match the expected result of '#{expected_rolling_back_element}'"
     end
 
     test ":revert redirect to the proper rollback page" do
-      get :revert, params: {stack_id: @stack.to_param, id: shipit_deploys(:shipit2).id}
+      get :revert, params: { stack_id: @stack.to_param, id: shipit_deploys(:shipit2).id }
       assert_redirected_to rollback_stack_deploy_path(@stack, shipit_deploys(:shipit))
     end
   end