scss-lint 0.33.0 → 0.34.0

data/spec/scss_lint/linter/nesting_depth_spec.rb

@@ -2,7 +2,7 @@ require 'spec_helper'
 
 describe SCSSLint::Linter::NestingDepth do
   context 'and selectors are nested up to depth 3' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       .one {
         .two {
           .three {
@@ -10,13 +10,13 @@ describe SCSSLint::Linter::NestingDepth do
           }
         }
       }
-    CSS
+    SCSS
 
     it { should_not report_lint }
   end
 
   context 'and selectors are nested greater than depth 3' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       .one {
         .two {
           .three {
@@ -29,7 +29,7 @@ describe SCSSLint::Linter::NestingDepth do
           }
         }
       }
-    CSS
+    SCSS
 
     it { should report_lint line: 4 }
     it { should report_lint line: 7 }
@@ -39,17 +39,17 @@ describe SCSSLint::Linter::NestingDepth do
     let(:linter_config) { { 'max_depth' => 1 } }
 
     context 'when nesting has a depth of one' do
-      let(:css) { <<-CSS }
+      let(:scss) { <<-SCSS }
         .one {
           font-style: italic;
         }
-      CSS
+      SCSS
 
       it { should_not report_lint }
     end
 
     context 'when nesting has a depth of two' do
-      let(:css) { <<-CSS }
+      let(:scss) { <<-SCSS }
         .one {
           .two {
             font-style: italic;
@@ -58,13 +58,13 @@ describe SCSSLint::Linter::NestingDepth do
         .one {
           font-style: italic;
         }
-      CSS
+      SCSS
 
       it { should report_lint line: 2 }
     end
 
     context 'when nesting has a depth of three' do
-      let(:css) { <<-CSS }
+      let(:scss) { <<-SCSS }
         .one {
           .two {
             .three {
@@ -75,7 +75,7 @@ describe SCSSLint::Linter::NestingDepth do
             font-style: italic;
           }
         }
-      CSS
+      SCSS
 
       it { should report_lint line: 2 }
       it { should report_lint line: 7 }
@@ -83,20 +83,20 @@ describe SCSSLint::Linter::NestingDepth do
     end
 
     context 'when nesting properties' do
-      let(:css) { <<-CSS }
+      let(:scss) { <<-SCSS }
         .one {
           font: {
             family: monospace;
             style: italic;
           }
         }
-      CSS
+      SCSS
 
       it { should_not report_lint }
     end
 
     context 'when sequence contains a @keyframe' do
-      let(:css) { <<-CSS }
+      let(:scss) { <<-SCSS }
         @keyframe my-keyframe {
           0% {
             background: #000;
@@ -106,7 +106,7 @@ describe SCSSLint::Linter::NestingDepth do
             background: #fff;
           }
         }
-      CSS
+      SCSS
 
       it { should_not report_lint }
     end

data/spec/scss_lint/linter/placeholder_in_extend_spec.rb

@@ -2,61 +2,61 @@ require 'spec_helper'
 
 describe SCSSLint::Linter::PlaceholderInExtend do
   context 'when extending with a class' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       p {
         @extend .error;
       }
-    CSS
+    SCSS
 
     it { should report_lint line: 2 }
   end
 
   context 'when extending with a type' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       p {
         @extend span;
       }
-    CSS
+    SCSS
 
     it { should report_lint line: 2 }
   end
 
   context 'when extending with an id' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       p {
         @extend #some-identifer;
       }
-    CSS
+    SCSS
 
     it { should report_lint line: 2 }
   end
 
   context 'when extending with a placeholder' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       p {
         @extend %placeholder;
       }
-    CSS
+    SCSS
 
     it { should_not report_lint }
   end
 
   context 'when extending with a selector whose prefix is not a placeholder' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       p {
         @extend .blah-\#{$dynamically_generated_name};
       }
-    CSS
+    SCSS
 
     it { should report_lint line: 2 }
   end
 
   context 'when extending with a selector whose prefix is dynamic' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       p {
         @extend \#{$dynamically_generated_placeholder_name};
       }
-    CSS
+    SCSS
 
     it { should_not report_lint }
   end

data/spec/scss_lint/linter/property_count_spec.rb

@@ -0,0 +1,104 @@
+require 'spec_helper'
+
+describe SCSSLint::Linter::PropertyCount do
+  let(:linter_config) { { 'max_properties' => 3 } }
+
+  context 'when the number of properties in each individual rule set is under the limit' do
+    let(:scss) { <<-SCSS }
+      p {
+        margin: 0;
+        padding: 0;
+        float: left;
+
+        a {
+          color: #f00;
+          text-decoration: none;
+          text-transform: uppercase;
+        }
+      }
+
+      i {
+        color: #000;
+        text-decoration: underline;
+        text-transform: lowercase;
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when the number of properties in an individual rule set is over the limit' do
+    let(:scss) { <<-SCSS }
+      p {
+        margin: 0;
+        padding: 0;
+        float: left;
+
+        a {
+          color: #f00;
+          font: 15px arial, sans-serif;
+          text-decoration: none;
+          text-transform: uppercase;
+        }
+      }
+
+      i {
+        color: #000;
+        text-decoration: underline;
+        text-transform: lowercase;
+      }
+    SCSS
+
+    it { should_not report_lint line: 1 }
+    it { should report_lint line: 6 }
+  end
+
+  context 'when nested rule sets are included in the count' do
+    let(:linter_config) { super().merge('include_nested' => true) }
+
+    context 'when the number of total nested properties under the limit' do
+      let(:scss) { <<-SCSS }
+        p {
+          margin: 0;
+
+          a {
+            color: #f00;
+            text-transform: uppercase;
+          }
+        }
+
+        i {
+          color: #000;
+          text-decoration: underline;
+          text-transform: lowercase;
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+
+    context 'when the number of total nested properties is over the limit' do
+      let(:scss) { <<-SCSS }
+        p {
+          margin: 0;
+          padding: 0;
+
+          a {
+            color: #f00;
+            text-decoration: none;
+            text-transform: uppercase;
+          }
+        }
+
+        i {
+          color: #000;
+          text-decoration: underline;
+          text-transform: lowercase;
+        }
+      SCSS
+
+      it { should report_lint line: 1 }
+      it { should_not report_lint line: 12 }
+    end
+  end
+end

data/spec/scss_lint/linter/property_sort_order_spec.rb

@@ -2,29 +2,29 @@ require 'spec_helper'
 
 describe SCSSLint::Linter::PropertySortOrder do
   context 'when rule is empty' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       p {
       }
-    CSS
+    SCSS
 
     it { should_not report_lint }
   end
 
   context 'when rule contains properties in sorted order' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       p {
         background: #000;
         display: none;
         margin: 5px;
         padding: 10px;
       }
-    CSS
+    SCSS
 
     it { should_not report_lint }
   end
 
   context 'when rule contains mixins followed by properties in sorted order' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       p {
         @include border-radius(5px);
         background: #000;
@@ -32,13 +32,13 @@ describe SCSSLint::Linter::PropertySortOrder do
         margin: 5px;
         padding: 10px;
       }
-    CSS
+    SCSS
 
     it { should_not report_lint }
   end
 
   context 'when rule contains nested rules after sorted properties' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       p {
         background: #000;
         display: none;
@@ -48,25 +48,25 @@ describe SCSSLint::Linter::PropertySortOrder do
           color: #555;
         }
       }
-    CSS
+    SCSS
 
     it { should_not report_lint }
   end
 
   context 'when rule contains properties in random order' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       p {
         padding: 5px;
         display: block;
         margin: 10px;
       }
-    CSS
+    SCSS
 
     it { should report_lint line: 2 }
   end
 
   context 'when there are multiple rules with out of order properties' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       p {
         display: block;
         background: #fff;
@@ -75,14 +75,14 @@ describe SCSSLint::Linter::PropertySortOrder do
         margin: 5px;
         color: #444;
       }
-    CSS
+    SCSS
 
     it { should report_lint line: 2 }
     it { should report_lint line: 6 }
   end
 
   context 'when there are nested rules with out of order properties' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       p {
         display: block;
         background: #fff;
@@ -91,138 +91,138 @@ describe SCSSLint::Linter::PropertySortOrder do
           color: #444;
         }
       }
-    CSS
+    SCSS
 
     it { should report_lint line: 2 }
     it { should report_lint line: 5 }
   end
 
   context 'when out-of-order property is the second last in the list of sorted properties' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       p {
         border: 0;
         border-radius: 3px;
         float: left;
         display: block;
       }
-    CSS
+    SCSS
 
     it { should report_lint line: 4 }
   end
 
   context 'when vendor-prefixed properties are ordered after the non-prefixed property' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       p {
         border-radius: 3px;
         -moz-border-radius: 3px;
         -o-border-radius: 3px;
         -webkit-border-radius: 3px;
       }
-    CSS
+    SCSS
 
     it { should report_lint line: 2 }
   end
 
   context 'when vendor-prefixed properties are ordered before the non-prefixed property' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       p {
         -moz-border-radius: 3px;
         -o-border-radius: 3px;
         -webkit-border-radius: 3px;
         border-radius: 3px;
       }
-    CSS
+    SCSS
 
     it { should_not report_lint }
   end
 
   context 'when using -moz-osx vendor-prefixed property' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       p {
         -moz-osx-font-smoothing: grayscale;
         -webkit-font-smoothing: antialiased;
       }
-    CSS
+    SCSS
 
     it { should_not report_lint }
   end
 
   context 'when vendor properties are ordered out-of-order before the non-prefixed property' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       p {
         -moz-border-radius: 3px;
         -webkit-border-radius: 3px;
         -o-border-radius: 3px;
         border-radius: 3px;
       }
-    CSS
+    SCSS
 
     it { should report_lint line: 3 }
   end
 
   context 'when include block contains properties in sorted order' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       @include some-mixin {
         background: #000;
         display: none;
         margin: 5px;
         padding: 10px;
       }
-    CSS
+    SCSS
 
     it { should_not report_lint }
   end
 
   context 'when include block contains properties not in sorted order' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       @include some-mixin {
         background: #000;
         margin: 5px;
         display: none;
       }
-    CSS
+    SCSS
 
     it { should report_lint line: 3 }
   end
 
   context 'when @media block contains properties not in sorted order' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       @media screen and (min-width: 500px) {
         margin: 5px;
         display: none;
       }
-    CSS
+    SCSS
 
     it { should report_lint line: 2 }
   end
 
   context 'when if block contains properties in sorted order' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       @if $var {
         background: #000;
         display: none;
         margin: 5px;
         padding: 10px;
       }
-    CSS
+    SCSS
 
     it { should_not report_lint }
   end
 
   context 'when if block contains properties not in sorted order' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       @if $var {
         background: #000;
         margin: 5px;
         display: none;
       }
-    CSS
+    SCSS
 
     it { should report_lint line: 3 }
   end
 
   context 'when if block contains properties in sorted order' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       @if $var {
         // Content
       } @else {
@@ -231,13 +231,13 @@ describe SCSSLint::Linter::PropertySortOrder do
         margin: 5px;
         padding: 10px;
       }
-    CSS
+    SCSS
 
     it { should_not report_lint }
   end
 
   context 'when else block contains properties not in sorted order' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       @if $var {
         // Content
       } @else {
@@ -245,7 +245,7 @@ describe SCSSLint::Linter::PropertySortOrder do
         margin: 5px;
         display: none;
       }
-    CSS
+    SCSS
 
     it { should report_lint line: 5 }
   end
@@ -254,31 +254,31 @@ describe SCSSLint::Linter::PropertySortOrder do
     let(:linter_config) { { 'order' => %w[position display padding margin width] } }
 
     context 'and the properties match the specified order' do
-      let(:css) { <<-CSS }
+      let(:scss) { <<-SCSS }
         p {
           display: block;
           padding: 5px;
           margin: 10px;
         }
-      CSS
+      SCSS
 
       it { should_not report_lint }
     end
 
     context 'and the properties do not match the specified order' do
-      let(:css) { <<-CSS }
+      let(:scss) { <<-SCSS }
         p {
           padding: 5px;
           display: block;
           margin: 10px;
         }
-      CSS
+      SCSS
 
       it { should report_lint line: 2 }
     end
 
     context 'and there are properties that are not specified in the explicit ordering' do
-      let(:css) { <<-CSS }
+      let(:scss) { <<-SCSS }
         p {
           display: block;
           padding: 5px;
@@ -288,7 +288,7 @@ describe SCSSLint::Linter::PropertySortOrder do
           background: red;   // Unspecified
           width: 100%;
         }
-      CSS
+      SCSS
 
       context 'and the ignore_unspecified option is enabled' do
         let(:linter_config) { super().merge('ignore_unspecified' => true) }
@@ -308,29 +308,119 @@ describe SCSSLint::Linter::PropertySortOrder do
     let(:linter_config) { { 'order' => 'concentric' } }
 
     context 'and the properties match the order' do
-      let(:css) { <<-CSS }
+      let(:scss) { <<-SCSS }
         p {
           display: block;
           position: absolute;
           float: left;
           clear: both;
         }
-      CSS
+      SCSS
 
       it { should_not report_lint }
     end
 
     context 'and the properties do not match the order' do
-      let(:css) { <<-CSS }
+      let(:scss) { <<-SCSS }
         p {
           clear: both;
           display: block;
           float: left;
           position: absolute;
         }
-      CSS
+      SCSS
 
       it { should report_lint }
     end
   end
+
+  context 'when separation between groups of properties is enforced' do
+    let(:order) do
+      %w[display position top right bottom left] + [nil] +
+      %w[width height margin padding] + [nil] +
+      %w[float clear]
+    end
+
+    let(:linter_config) { { 'separate_groups' => true, 'order' => order } }
+
+    context 'and the groups are separated correctly' do
+      let(:scss) { <<-SCSS }
+        p {
+          display: none;
+          position: absolute;
+
+          margin: 0;
+          padding: 0;
+
+          float: left;
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+
+    context 'and the groups are separated incorrectly' do
+      let(:scss) { <<-SCSS }
+        p {
+          display: none;
+          position: absolute;
+          margin: 0;
+
+          padding: 0;
+
+          float: left;
+        }
+      SCSS
+
+      it { should report_lint line: 4 }
+    end
+
+    context 'and the groups are separated by a comment' do
+      let(:scss) { <<-SCSS }
+        p {
+          display: none;
+          position: absolute;
+          //
+          margin: 0;
+          padding: 0;
+          //
+          float: left;
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+
+    context 'when the sort order has multiple gaps separating two groups' do
+      let(:order) { %w[display position] + [nil, nil] + %w[margin padding] }
+
+      context 'and the groups are separated correctly' do
+        let(:scss) { <<-SCSS }
+          p {
+            display: none;
+            position: absolute;
+
+            margin: 0;
+            padding: 0;
+          }
+        SCSS
+
+        it { should_not report_lint }
+      end
+
+      context 'and the groups are separated incorrectly' do
+        let(:scss) { <<-SCSS }
+          p {
+            display: none;
+            position: absolute;
+            margin: 0;
+
+            padding: 0;
+          }
+        SCSS
+
+        it { should report_lint line: 4 }
+      end
+    end
+  end
 end