scss-lint 0.33.0 → 0.34.0

data/spec/scss_lint/linter/mergeable_selector_spec.rb

@@ -2,16 +2,16 @@ require 'spec_helper'
 
 describe SCSSLint::Linter::MergeableSelector do
   context 'when single root' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       p {
       }
-    CSS
+    SCSS
 
     it { should_not report_lint }
   end
 
   context 'when different roots' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       p {
         background: #000;
         margin: 5px;
@@ -20,13 +20,13 @@ describe SCSSLint::Linter::MergeableSelector do
         background: #000;
         margin: 5px;
       }
-    CSS
+    SCSS
 
     it { should_not report_lint }
   end
 
   context 'when different roots with matching inner rules' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       p {
         background: #000;
         margin: 5px;
@@ -41,13 +41,13 @@ describe SCSSLint::Linter::MergeableSelector do
           color: red;
         }
       }
-    CSS
+    SCSS
 
     it { should_not report_lint }
   end
 
   context 'when multi-selector roots and parital rule match' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       p, a {
         background: #000;
         margin: 5px;
@@ -62,13 +62,13 @@ describe SCSSLint::Linter::MergeableSelector do
           color: red;
         }
       }
-    CSS
+    SCSS
 
     it { should_not report_lint }
   end
 
   context 'when nested and unnested selectors match' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       a.current {
         background: #000;
         margin: 5px;
@@ -85,7 +85,7 @@ describe SCSSLint::Linter::MergeableSelector do
           }
         }
       }
-    CSS
+    SCSS
 
     context 'when force_nesting is enabled' do
       let(:linter_config) { { 'force_nesting' => true } }
@@ -99,7 +99,7 @@ describe SCSSLint::Linter::MergeableSelector do
   end
 
   context 'when same class roots' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       .warn {
         font-weight: bold;
       }
@@ -110,13 +110,13 @@ describe SCSSLint::Linter::MergeableSelector do
           color: #ccc;
         }
       }
-    CSS
+    SCSS
 
     it { should report_lint }
   end
 
   context 'when same compond selector roots' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       .warn .alert {
         font-weight: bold;
       }
@@ -127,13 +127,13 @@ describe SCSSLint::Linter::MergeableSelector do
           color: #ccc;
         }
       }
-    CSS
+    SCSS
 
     it { should report_lint }
   end
 
   context 'when same class roots separated by another class' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       .warn {
         font-weight: bold;
       }
@@ -147,13 +147,13 @@ describe SCSSLint::Linter::MergeableSelector do
           color: #ccc;
         }
       }
-    CSS
+    SCSS
 
     it { should report_lint }
   end
 
   context 'when rule in a mixin @include matches a root root' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       p {
         font-weight: bold;
       }
@@ -162,13 +162,13 @@ describe SCSSLint::Linter::MergeableSelector do
           font-weight: normal;
         }
       }
-    CSS
+    SCSS
 
     it { should_not report_lint }
   end
 
   context 'when rule in a mixin definition matches a root rule' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       p {
         font-weight: bold;
       }
@@ -177,13 +177,13 @@ describe SCSSLint::Linter::MergeableSelector do
           font-weight: normal;
         }
       }
-    CSS
+    SCSS
 
     it { should_not report_lint }
   end
 
   context 'when rule in a media directive matches a root rule' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       p {
         font-weight: bold;
       }
@@ -192,13 +192,13 @@ describe SCSSLint::Linter::MergeableSelector do
           font-weight: normal;
         }
       }
-    CSS
+    SCSS
 
     it { should_not report_lint }
   end
 
   context 'when rule in a keyframes directive matches a root rule' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       @keyframes slideouttoleft {
         from {
           transform: translateX(0);
@@ -218,13 +218,13 @@ describe SCSSLint::Linter::MergeableSelector do
           transform: translateX(100%);
         }
       }
-    CSS
+    SCSS
 
     it { should_not report_lint }
   end
 
   context 'when there are duplicate rules nested in a rule set' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       .foo {
         .bar {
           font-weight: bold;
@@ -236,7 +236,7 @@ describe SCSSLint::Linter::MergeableSelector do
           color: #ff0;
         }
       }
-    CSS
+    SCSS
 
     it { should report_lint }
   end
@@ -245,7 +245,7 @@ describe SCSSLint::Linter::MergeableSelector do
     let(:linter_config) { { 'force_nesting' => true } }
 
     context 'when one of the duplicate rules is in a comma sequence' do
-      let(:css) { <<-CSS }
+      let(:scss) { <<-SCSS }
         .foo,
         .bar {
           color: #000;
@@ -253,29 +253,29 @@ describe SCSSLint::Linter::MergeableSelector do
         .foo {
           color: #f00;
         }
-      CSS
+      SCSS
 
       it { should_not report_lint }
     end
 
     context 'when rules start with the same prefix but are not the same' do
-      let(:css) { <<-CSS }
+      let(:scss) { <<-SCSS }
         .foo {
           color: #000;
         }
         .foobar {
           color: #f00;
         }
-      CSS
+      SCSS
 
       it { should_not report_lint }
     end
 
     context 'when a rule contains interpolation' do
-      let(:css) { <<-CSS }
+      let(:scss) { <<-SCSS }
         .\#{$class-name} {}
         .foobar {}
-      CSS
+      SCSS
 
       it { should_not report_lint }
     end

data/spec/scss_lint/linter/name_format_spec.rb

@@ -3,127 +3,127 @@ require 'spec_helper'
 describe SCSSLint::Linter::NameFormat do
   shared_examples 'hyphenated_lowercase' do
     context 'when no variable, functions, or mixin declarations exist' do
-      let(:css) { <<-CSS }
+      let(:scss) { <<-SCSS }
         p {
           margin: 0;
         }
-      CSS
+      SCSS
 
       it { should_not report_lint }
     end
 
     context 'when a variable name contains a hyphen' do
-      let(:css) { '$content-padding: 10px;' }
+      let(:scss) { '$content-padding: 10px;' }
 
       it { should_not report_lint }
     end
 
     context 'when a variable name contains an underscore' do
-      let(:css) { '$content_padding: 10px;' }
+      let(:scss) { '$content_padding: 10px;' }
 
       it { should report_lint line: 1 }
     end
 
     context 'when a variable name contains an uppercase character' do
-      let(:css) { '$contentPadding: 10px;' }
+      let(:scss) { '$contentPadding: 10px;' }
 
       it { should report_lint line: 1 }
     end
 
     context 'when a function is declared with a capital letter' do
-      let(:css) { <<-CSS }
+      let(:scss) { <<-SCSS }
         @function badFunction() {
         }
-      CSS
+      SCSS
 
       it { should report_lint line: 1 }
     end
 
     context 'when a function is declared with an underscore' do
-      let(:css) { <<-CSS }
+      let(:scss) { <<-SCSS }
         @function bad_function() {
         }
-      CSS
+      SCSS
 
       it { should report_lint line: 1 }
     end
 
     context 'when a mixin is declared with a capital letter' do
-      let(:css) { <<-CSS }
+      let(:scss) { <<-SCSS }
         @mixin badMixin() {
         }
-      CSS
+      SCSS
 
       it { should report_lint line: 1 }
     end
 
     context 'when a mixin is declared with an underscore' do
-      let(:css) { <<-CSS }
+      let(:scss) { <<-SCSS }
         @mixin bad_mixin() {
         }
-      CSS
+      SCSS
 
       it { should report_lint line: 1 }
     end
 
     context 'when no invalid usages exist' do
-      let(:css) { <<-CSS }
+      let(:scss) { <<-SCSS }
         p {
           margin: 0;
         }
-      CSS
+      SCSS
 
       it { should_not report_lint }
     end
 
     context 'when a referenced variable name has a capital letter' do
-      let(:css) { <<-CSS }
+      let(:scss) { <<-SCSS }
         p {
           margin: $badVar;
         }
-      CSS
+      SCSS
 
       it { should report_lint line: 2 }
     end
 
     context 'when a referenced variable name has an underscore' do
-      let(:css) { <<-CSS }
+      let(:scss) { <<-SCSS }
         p {
           margin: $bad_var;
         }
-      CSS
+      SCSS
 
       it { should report_lint line: 2 }
     end
 
     context 'when a referenced function name has a capital letter' do
-      let(:css) { <<-CSS }
+      let(:scss) { <<-SCSS }
         p {
           margin: badFunc();
         }
-      CSS
+      SCSS
 
       it { should report_lint line: 2 }
     end
 
     context 'when a referenced function name has an underscore' do
-      let(:css) { <<-CSS }
+      let(:scss) { <<-SCSS }
         p {
           margin: bad_func();
         }
-      CSS
+      SCSS
 
       it { should report_lint line: 2 }
     end
 
     context 'when an included mixin name has a capital letter' do
-      let(:css) { '@include badMixin();' }
+      let(:scss) { '@include badMixin();' }
 
       it { should report_lint line: 1 }
     end
 
     context 'when an included mixin name has an underscore' do
-      let(:css) { '@include bad_mixin();' }
+      let(:scss) { '@include bad_mixin();' }
 
       it { should report_lint line: 1 }
     end
@@ -133,34 +133,34 @@ describe SCSSLint::Linter::NameFormat do
          scaleX scaleY scaleZ
          skewX skewY
          translateX translateY translateZ].each do |function|
-        let(:css) { <<-CSS }
+        let(:scss) { <<-SCSS }
           p {
             transform: #{function}(2);
           }
-        CSS
+        SCSS
 
         it { should_not report_lint }
       end
     end
 
     context 'when mixin is a transform function' do
-      let(:css) { <<-CSS }
+      let(:scss) { <<-SCSS }
         p {
           @include translateX(2);
         }
-      CSS
+      SCSS
 
       it { should_not report_lint }
     end
 
     context 'when a mixin contains keyword arguments with underscores' do
-      let(:css) { '@include mixin($some_var: 4);' }
+      let(:scss) { '@include mixin($some_var: 4);' }
 
       it { should report_lint }
     end
 
     context 'when a mixin contains keyword arguments with hyphens' do
-      let(:css) { '@include mixin($some-var: 4);' }
+      let(:scss) { '@include mixin($some-var: 4);' }
 
       it { should_not report_lint }
     end
@@ -170,10 +170,10 @@ describe SCSSLint::Linter::NameFormat do
     it_behaves_like 'hyphenated_lowercase'
 
     context 'when a name contains a leading underscore' do
-      let(:css) { <<-CSS }
+      let(:scss) { <<-SCSS }
         @function _private-method() {
         }
-      CSS
+      SCSS
 
       it { should_not report_lint }
     end
@@ -185,10 +185,10 @@ describe SCSSLint::Linter::NameFormat do
     it_behaves_like 'hyphenated_lowercase'
 
     context 'when a name contains a leading underscore' do
-      let(:css) { <<-CSS }
+      let(:scss) { <<-SCSS }
         @function _private-method() {
         }
-      CSS
+      SCSS
 
       it { should report_lint line: 1 }
     end
@@ -198,39 +198,73 @@ describe SCSSLint::Linter::NameFormat do
     let(:linter_config) { { 'convention' => 'BEM' } }
 
     context 'when a name contains no underscores or hyphens' do
-      let(:css) { '@extend %block;' }
+      let(:scss) { '@extend %block;' }
 
       it { should_not report_lint }
     end
 
     context 'when a name contains a single underscore' do
-      let(:css) { '@extend %block_thing;' }
+      let(:scss) { '@extend %block_thing;' }
 
       it { should report_lint }
     end
 
     context 'when a name contains a single hyphen' do
-      let(:css) { '@extend %block-thing;' }
+      let(:scss) { '@extend %block-thing;' }
 
       it { should_not report_lint }
     end
 
     context 'when a name contains a double hyphen' do
-      let(:css) { '@extend %block--thing;' }
+      let(:scss) { '@extend %block--thing;' }
 
       it { should_not report_lint }
     end
 
     context 'when a name contains a double underscore' do
-      let(:css) { '@extend %block__thing;' }
+      let(:scss) { '@extend %block__thing;' }
 
       it { should_not report_lint }
     end
 
     context 'when a name contains a double underscore and double hyphen' do
-      let(:css) { '@extend %block--thing__word;' }
+      let(:scss) { '@extend %block--thing__word;' }
 
       it { should_not report_lint }
     end
   end
+
+  context 'when a regexp convention is specified' do
+    let(:linter_config) { { 'convention' => '^[a-v_-]+$' } }
+
+    context 'when a name contains no underscores or hyphens' do
+      let(:scss) { '@extend %block;' }
+
+      it { should_not report_lint }
+    end
+
+    context 'when a name contains a single underscore' do
+      let(:scss) { '@extend %block_thing;' }
+
+      it { should_not report_lint }
+    end
+
+    context 'when a name contains a single hyphen' do
+      let(:scss) { '@extend %block-thing;' }
+
+      it { should_not report_lint }
+    end
+
+    context 'when a name contains a uppercase character' do
+      let(:scss) { '@extend Block-thing;' }
+
+      it { should report_lint }
+    end
+
+    context 'when a name contains an unallowed character' do
+      let(:scss) { '@extend zoo;' }
+
+      it { should report_lint }
+    end
+  end
 end