scss-lint 0.33.0 → 0.34.0

data/spec/scss_lint/engine_spec.rb

@@ -1,13 +1,13 @@
 require 'spec_helper'
 
 describe SCSSLint::Engine do
-  let(:engine) { described_class.new(css) }
+  let(:engine) { described_class.new(scss) }
 
   context 'when a @media directive is present' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       @media only screen {
       }
-    CSS
+    SCSS
 
     it 'has a parse tree' do
       engine.tree.should_not be_nil
@@ -15,7 +15,7 @@ describe SCSSLint::Engine do
   end
 
   context 'when the file being linted has an invalid byte sequence' do
-    let(:css) { "\xC0\u0001" }
+    let(:scss) { "\xC0\u0001" }
 
     it 'raises a SyntaxError' do
       expect { engine }.to raise_error(SCSSLint::FileEncodingError)

data/spec/scss_lint/file_finder_spec.rb

@@ -0,0 +1,110 @@
+require 'spec_helper'
+
+describe SCSSLint::FileFinder do
+  let(:config) { SCSSLint::Config.default }
+
+  subject { described_class.new(config) }
+
+  describe '#find' do
+    include_context 'isolated environment'
+
+    subject { super().find(patterns) }
+
+    context 'when no patterns are given' do
+      let(:patterns) { [] }
+
+      context 'and there are no SCSS files under the current directory' do
+        it { should == [] }
+      end
+
+      context 'and there are SCSS files under the current directory' do
+        before do
+          `touch blah.scss`
+          `mkdir -p more`
+          `touch more/more.scss`
+        end
+
+        it { should == ['blah.scss', 'more/more.scss'] }
+      end
+
+      context 'and a default set of files is specified in the config' do
+        let(:files) { ['file1.scss', 'file2.scss'] }
+
+        before do
+          config.stub(:scss_files).and_return(files)
+        end
+
+        it { should == files }
+      end
+    end
+
+    context 'when files without valid extension are given' do
+      let(:patterns) { ['test.txt'] }
+
+      context 'and those files exist' do
+        before do
+          `touch test.txt`
+        end
+
+        it { should == ['test.txt'] }
+      end
+
+      context 'and those files do not exist' do
+        it { should == ['test.txt'] }
+      end
+    end
+
+    context 'when directories are given' do
+      let(:patterns) { ['some-dir'] }
+
+      context 'and those directories exist' do
+        before do
+          `mkdir -p some-dir`
+        end
+
+        context 'and they contain SCSS files' do
+          before do
+            `touch some-dir/test.scss`
+          end
+
+          it { should == ['some-dir/test.scss'] }
+        end
+
+        context 'and they contain CSS files' do
+          before do
+            `touch some-dir/test.css`
+          end
+
+          it { should == ['some-dir/test.css'] }
+        end
+
+        context 'and they contain more directories with files with recognized extensions' do
+          before do
+            `mkdir -p some-dir/more-dir`
+            `touch some-dir/more-dir/test.scss`
+          end
+
+          it { should == ['some-dir/more-dir/test.scss'] }
+        end
+
+        context 'and they contain files with some other extension' do
+          before do
+            `touch some-dir/test.txt`
+          end
+
+          it { should == [] }
+        end
+      end
+
+      context 'and those directories do not exist' do
+        it { should == ['some-dir'] }
+      end
+    end
+
+    context 'when the same file is specified multiple times' do
+      let(:patterns) { ['test.scss'] * 3 }
+
+      it { should == ['test.scss'] }
+    end
+  end
+end

data/spec/scss_lint/linter/bang_format_spec.rb

@@ -2,41 +2,41 @@ require 'spec_helper'
 
 describe SCSSLint::Linter::BangFormat do
   context 'when no bang is used' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       p {
         color: #000;
       }
-    CSS
+    SCSS
 
     it { should_not report_lint }
   end
 
   context 'when !important is used correctly' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       p {
         color: #000 !important;
       }
-    CSS
+    SCSS
 
     it { should_not report_lint }
   end
 
   context 'when !important has no space before' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       p {
         color: #000!important;
       }
-    CSS
+    SCSS
 
     it { should report_lint line: 2 }
   end
 
   context 'when !important has a space after' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       p {
         color: #000 ! important;
       }
-    CSS
+    SCSS
 
     it { should report_lint line: 2 }
   end
@@ -44,11 +44,11 @@ describe SCSSLint::Linter::BangFormat do
   context 'when !important has a space after and config allows it' do
     let(:linter_config) { { 'space_before_bang' => true, 'space_after_bang' => true } }
 
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       p {
         color: #000 ! important;
       }
-    CSS
+    SCSS
 
     it { should_not report_lint }
   end
@@ -56,11 +56,11 @@ describe SCSSLint::Linter::BangFormat do
   context 'when !important has a space before but config does not allow it' do
     let(:linter_config) { { 'space_before_bang' => false, 'space_after_bang' => true } }
 
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       p {
         color: #000 ! important;
       }
-    CSS
+    SCSS
 
     it { should report_lint line: 2 }
   end
@@ -68,17 +68,17 @@ describe SCSSLint::Linter::BangFormat do
   context 'when !important has no spaces around and config allows it' do
     let(:linter_config) { { 'space_before_bang' => false, 'space_after_bang' => false } }
 
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       p {
         color: #000!important;
       }
-    CSS
+    SCSS
 
     it { should_not report_lint }
   end
 
   context 'when ! appears within a string' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       p:before { content: "!important"; }
       p:before { content: "imp!ortant"; }
       p:after { content: '!'; }
@@ -92,20 +92,30 @@ describe SCSSLint::Linter::BangFormat do
       $foo: "bar!";
       $foo: "!bar";
       $foo: "b!ar";
-    CSS
+    SCSS
 
     it { should_not report_lint }
   end
 
   context 'when !<word> is not followed by a semicolon' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       .class {
         margin: 0 !important
       }
-    CSS
+    SCSS
 
     it 'does not loop forever' do
       subject.should_not report_lint
     end
   end
+
+  context 'when property contains a list literal with an empty list' do
+    let(:scss) { <<-SCSS }
+      p {
+        content: 0 ();
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
 end

data/spec/scss_lint/linter/border_zero_spec.rb

@@ -2,83 +2,117 @@ require 'spec_helper'
 
 describe SCSSLint::Linter::BorderZero do
   context 'when a rule is empty' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       p {
       }
-    CSS
+    SCSS
 
     it { should_not report_lint }
   end
 
   context 'when a property' do
     context 'contains a normal border' do
-      let(:css) { <<-CSS }
+      let(:scss) { <<-SCSS }
         p {
           border: 1px solid #000;
         }
-      CSS
+      SCSS
 
       it { should_not report_lint }
     end
 
     context 'has a border of 0' do
-      let(:css) { <<-CSS }
+      let(:scss) { <<-SCSS }
         p {
           border: 0;
         }
-      CSS
+      SCSS
 
       it { should_not report_lint }
     end
 
     context 'has a border of none' do
-      let(:css) { <<-CSS }
+      let(:scss) { <<-SCSS }
         p {
           border: none;
         }
-      CSS
+      SCSS
 
       it { should report_lint line: 2 }
     end
 
     context 'has a border-top of none' do
-      let(:css) { <<-CSS }
+      let(:scss) { <<-SCSS }
         p {
           border-top: none;
         }
-      CSS
+      SCSS
 
       it { should report_lint line: 2 }
     end
 
     context 'has a border-right of none' do
-      let(:css) { <<-CSS }
+      let(:scss) { <<-SCSS }
         p {
           border-right: none;
         }
-      CSS
+      SCSS
 
       it { should report_lint line: 2 }
     end
 
     context 'has a border-bottom of none' do
-      let(:css) { <<-CSS }
+      let(:scss) { <<-SCSS }
         p {
           border-bottom: none;
         }
-      CSS
+      SCSS
 
       it { should report_lint line: 2 }
     end
 
     context 'has a border-left of none' do
-      let(:css) { <<-CSS }
+      let(:scss) { <<-SCSS }
         p {
           border-left: none;
         }
-      CSS
+      SCSS
 
       it { should report_lint line: 2 }
     end
   end
+
+  context 'when a convention of `none` is preferred' do
+    let(:linter_config) { { 'convention' => 'none' } }
+
+    context 'and the border is `none`' do
+      let(:scss) { <<-SCSS }
+        p {
+          border: none;
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+
+    context 'and the border is `0`' do
+      let(:scss) { <<-SCSS }
+        p {
+          border: 0;
+        }
+      SCSS
+
+      it { should report_lint }
+    end
+
+    context 'and the border is a non-zero value' do
+      let(:scss) { <<-SCSS }
+        p {
+          border: 5px;
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+  end
 end

data/spec/scss_lint/linter/color_keyword_spec.rb

@@ -2,81 +2,81 @@ require 'spec_helper'
 
 describe SCSSLint::Linter::ColorKeyword do
   context 'when a color is specified as a hex' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       p {
         color: #fff;
       }
-    CSS
+    SCSS
 
     it { should_not report_lint }
   end
 
   context 'when a color is specified as a keyword' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       p {
         color: white;
       }
-    CSS
+    SCSS
 
     it { should report_lint line: 2 }
   end
 
   context 'when a color keyword exists in a shorthand property' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       p {
         border: 1px solid black;
       }
-    CSS
+    SCSS
 
     it { should report_lint line: 2 }
   end
 
   context 'when a property contains a color keyword as a string' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       p {
         content: 'white';
       }
-    CSS
+    SCSS
 
     it { should_not report_lint }
   end
 
   context 'when a function call contains a color keyword' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       p {
         color: function(red);
       }
-    CSS
+    SCSS
 
     it { should report_lint line: 2 }
   end
 
   context 'when a mixin include contains a color keyword' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       p {
         @include some-mixin(red);
       }
-    CSS
+    SCSS
 
     it { should report_lint line: 2 }
   end
 
   context 'when the "transparent" color keyword is used' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       p {
         @include mixin(transparent);
       }
-    CSS
+    SCSS
 
     it { should_not report_lint }
   end
 
   context 'when color keyword appears in a string identifier' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       p {
         content: content-with-blue-in-name;
       }
-    CSS
+    SCSS
 
     it { should_not report_lint }
   end