scss-lint 0.33.0 → 0.34.0

data/spec/scss_lint/linter/unnecessary_mantissa_spec.rb

@@ -2,37 +2,37 @@ require 'spec_helper'
 
 describe SCSSLint::Linter::UnnecessaryMantissa do
   context 'when value is zero' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       p {
         margin: 0;
         padding: func(0);
         top: 0em;
       }
-    CSS
+    SCSS
 
     it { should_not report_lint }
   end
 
   context 'when value contains no mantissa' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       p {
         margin: 1;
         padding: func(1);
         top: 1em;
       }
-    CSS
+    SCSS
 
     it { should_not report_lint }
   end
 
   context 'when value contains a mantissa with a zero' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       p {
         margin: 1.0;
         padding: func(1.0);
         top: 1.0em;
       }
-    CSS
+    SCSS
 
     it { should report_lint line: 2 }
     it { should report_lint line: 3 }
@@ -40,13 +40,13 @@ describe SCSSLint::Linter::UnnecessaryMantissa do
   end
 
   context 'when value contains a mantissa with multiple zeroes' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       p {
         margin: 1.000;
         padding: func(1.000);
         top: 1.000em;
       }
-    CSS
+    SCSS
 
     it { should report_lint line: 2 }
     it { should report_lint line: 3 }
@@ -54,13 +54,13 @@ describe SCSSLint::Linter::UnnecessaryMantissa do
   end
 
   context 'when value contains a mantissa with multiple zeroes followed by a number' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       p {
         margin: 1.0001;
         padding: func(1.0001);
         top: 1.0001em;
       }
-    CSS
+    SCSS
 
     it { should_not report_lint }
   end

data/spec/scss_lint/linter/unnecessary_parent_reference_spec.rb

@@ -2,68 +2,68 @@ require 'spec_helper'
 
 describe SCSSLint::Linter::UnnecessaryParentReference do
   context 'when an amperand precedes a direct descendant operator' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       p {
         & > a {}
       }
-    CSS
+    SCSS
 
     it { should report_lint line: 2 }
   end
 
   context 'when an amperand precedes a general child' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       p {
         & a {}
       }
-    CSS
+    SCSS
 
     it { should report_lint line: 2 }
   end
 
   context 'when an amperand is chained with class' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       p {
         &.foo {}
       }
-    CSS
+    SCSS
 
     it { should_not report_lint }
   end
 
   context 'when an amperand follows a direct descendant operator' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       p {
         .foo > & {}
       }
-    CSS
+    SCSS
 
     it { should_not report_lint }
   end
 
   context 'when an ampersand precedes a sibling operator' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       p {
         & + & {}
         & ~ & {}
       }
-    CSS
+    SCSS
 
     it { should_not report_lint }
   end
 
   context 'when multiple ampersands exist with one concatenated' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       p {
         & + &:hover {}
       }
-    CSS
+    SCSS
 
     it { should_not report_lint }
   end
 
   context 'when an amperand is used in a comma sequence to DRY up code' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       p {
         &,
         .foo,
@@ -71,27 +71,27 @@ describe SCSSLint::Linter::UnnecessaryParentReference do
           margin: 0;
         }
       }
-    CSS
+    SCSS
 
     it { should_not report_lint }
   end
 
   context 'when an ampersand is used by itself' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       p {
         & {}
       }
-    CSS
+    SCSS
 
     it { should report_lint line: 2 }
   end
 
   context 'when an ampersand is used in concatentation' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       .icon {
         &-small {}
       }
-    CSS
+    SCSS
 
     it { should_not report_lint }
   end

data/spec/scss_lint/linter/url_format_spec.rb

@@ -34,21 +34,21 @@ describe SCSSLint::Linter::UrlFormat do
   end
 
   context 'when URL is enclosed in quotes' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       .block {
         background: url('#{url}');
       }
-    CSS
+    SCSS
 
     it_should_behave_like 'UrlFormat linter'
   end
 
   context 'when URL is not enclosed in quotes' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       .block {
         background: url(#{url});
       }
-    CSS
+    SCSS
 
     it_should_behave_like 'UrlFormat linter'
   end

data/spec/scss_lint/linter/url_quotes_spec.rb

@@ -2,71 +2,71 @@ require 'spec_helper'
 
 describe SCSSLint::Linter::UrlQuotes do
   context 'when property has a literal URL' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       p {
         background: url(example.png);
       }
-    CSS
+    SCSS
 
     it { should report_lint line: 2 }
   end
 
   context 'when property has a URL enclosed in single quotes' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       p {
         background: url('example.png');
       }
-    CSS
+    SCSS
 
     it { should_not report_lint }
   end
 
   context 'when property has a URL enclosed in double quotes' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       p {
         background: url("example.png");
       }
-    CSS
+    SCSS
 
     it { should_not report_lint }
   end
 
   context 'when property has a literal URL in a list' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       p {
         background: transparent url(example.png);
       }
-    CSS
+    SCSS
 
     it { should report_lint line: 2 }
   end
 
   context 'when property has a single-quoted URL in a list' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       p {
         background: transparent url('example.png');
       }
-    CSS
+    SCSS
 
     it { should_not report_lint }
   end
 
   context 'when property has a double-quoted URL in a list' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       p {
         background: transparent url("example.png");
       }
-    CSS
+    SCSS
 
     it { should_not report_lint }
   end
 
   context 'when property has a data URI' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       .tracking-pixel {
         background: url(data:image/gif;base64,R0lGODlhAQABAAAAACH5BAEKAAEALAAAAAABAAEAAAICTAEAOw==);
       }
-    CSS
+    SCSS
 
     it { should_not report_lint }
   end

data/spec/scss_lint/linter/variable_for_property_spec.rb

@@ -0,0 +1,115 @@
+require 'spec_helper'
+
+describe SCSSLint::Linter::VariableForProperty do
+  context 'when properties are specified' do
+    let(:linter_config) { { 'properties' => %w[color font] } }
+
+    context 'when configured property value is a variable' do
+      let(:scss) { <<-SCSS }
+        p {
+          color: $black;
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+
+    context 'when configured property value is a hex string' do
+      let(:scss) { <<-SCSS }
+        p {
+          color: #000;
+        }
+      SCSS
+
+      it { should report_lint line: 2 }
+    end
+
+    context 'when configured property value is a color keyword' do
+      let(:scss) { <<-SCSS }
+        p {
+          color: red;
+        }
+      SCSS
+
+      it { should report_lint line: 2 }
+    end
+
+    context 'when an unspecified property value is a variable' do
+      let(:scss) { <<-SCSS }
+        p {
+          background-color: $black;
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+
+    context 'when an unspecified property value is not a variable' do
+      let(:scss) { <<-SCSS }
+        p {
+          background-color: #000;
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+
+    context 'when multiple configured property values are variables' do
+      let(:scss) { <<-SCSS }
+        p {
+          color: $black;
+          font: $small;
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+
+    context 'when multiple configured property values are not variables' do
+      let(:scss) { <<-SCSS }
+        p {
+          color: #000;
+          font: 8px;
+        }
+      SCSS
+
+      it { should report_lint line: 2 }
+      it { should report_lint line: 3 }
+    end
+
+    context 'when configured property values are mixed' do
+      let(:scss) { <<-SCSS }
+        p {
+          color: $black;
+          font: 8px;
+        }
+      SCSS
+
+      it { should report_lint line: 3 }
+    end
+  end
+
+  context 'when properties are not specified' do
+    let(:linter_config) { { 'properties' => [] } }
+
+    context 'when property value is a variable' do
+      let(:scss) { <<-SCSS }
+        p {
+          color: $black;
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+
+    context 'when property value is not a variable' do
+      let(:scss) { <<-SCSS }
+        p {
+          color: #000;
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+  end
+end

data/spec/scss_lint/linter/vendor_prefixes_spec.rb

@@ -2,20 +2,20 @@ require 'spec_helper'
 
 describe SCSSLint::Linter::VendorPrefixes do
   context 'when no vendor-prefix is used' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       div {
         transition: none;
       }
-    CSS
+    SCSS
 
     it { should_not report_lint }
   end
 
   context 'when a rule is empty' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       div {
       }
-    CSS
+    SCSS
 
     it { should_not report_lint }
   end
@@ -23,31 +23,31 @@ describe SCSSLint::Linter::VendorPrefixes do
   # Properties
 
   context 'when a vendor-prefixed listed property is used' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       div {
         -webkit-transition: none;
       }
-    CSS
+    SCSS
 
     it { should report_lint line: 2 }
   end
 
   context 'when an unprefixed listed property is used' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       div {
         transition: none;
       }
-    CSS
+    SCSS
 
     it { should_not report_lint }
   end
 
   context 'when a vendor-prefixed unlisted property is used' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       div {
         -webkit-appearance: none;
       }
-    CSS
+    SCSS
 
     it { should_not report_lint }
   end
@@ -55,21 +55,21 @@ describe SCSSLint::Linter::VendorPrefixes do
   context 'when a vendor-prefixed custom-listed property is used' do
     let(:linter_config) { { 'identifier_list' => ['transform'] } }
 
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       div {
         -webkit-transform: none;
       }
-    CSS
+    SCSS
 
     it { should report_lint line: 2 }
   end
 
   context 'when a proprietary unlisted vendor-prefixed property is used' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       div {
         -moz-padding-end: 0;
       }
-    CSS
+    SCSS
 
     it { should_not report_lint }
   end
@@ -77,11 +77,11 @@ describe SCSSLint::Linter::VendorPrefixes do
   context 'when a proprietary listed vendor-prefixed property is used' do
     let(:linter_config) { { 'identifier_list' => ['padding-end'] } }
 
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       div {
         -moz-padding-end: 0;
       }
-    CSS
+    SCSS
 
     it { should report_lint line: 2 }
   end
@@ -89,7 +89,7 @@ describe SCSSLint::Linter::VendorPrefixes do
   # Selectors
 
   context 'when a vendor-prefixed listed selector is used' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       ::-moz-placeholder {
         color: red;
       }
@@ -99,7 +99,7 @@ describe SCSSLint::Linter::VendorPrefixes do
       :-moz-fullscreen p {
         font-size: 200%;
       }
-    CSS
+    SCSS
 
     it { should report_lint line: 1 }
     it { should report_lint line: 4 }
@@ -107,14 +107,14 @@ describe SCSSLint::Linter::VendorPrefixes do
   end
 
   context 'when an unprefixed listed selector is used' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       ::placeholder {
         color: red;
       }
       :fullscreen p {
         font-size: 200%;
       }
-    CSS
+    SCSS
 
     it { should_not report_lint }
   end
@@ -122,11 +122,11 @@ describe SCSSLint::Linter::VendorPrefixes do
   context 'when a vendor-prefixed unlisted selector is used' do
     let(:linter_config) { { 'identifier_list' => ['transform'] } }
 
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       ::-moz-placeholder {
         color: red;
       }
-    CSS
+    SCSS
 
     it { should_not report_lint }
   end
@@ -134,11 +134,11 @@ describe SCSSLint::Linter::VendorPrefixes do
   context 'when a vendor-prefixed custom-listed selector is used' do
     let(:linter_config) { { 'identifier_list' => ['placeholder'] } }
 
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       ::-moz-placeholder {
         color: red;
       }
-    CSS
+    SCSS
 
     it { should report_lint line: 1 }
   end
@@ -146,21 +146,21 @@ describe SCSSLint::Linter::VendorPrefixes do
   # Directives
 
   context 'when a vendor-prefixed listed directive is used' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       @-webkit-keyframes anim {
         0% { opacity: 0; }
       }
-    CSS
+    SCSS
 
     it { should report_lint line: 1 }
   end
 
   context 'when an unprefixed listed directive is used' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       @keyframes anim {
         0% { opacity: 0; }
       }
-    CSS
+    SCSS
 
     it { should_not report_lint }
   end
@@ -168,11 +168,11 @@ describe SCSSLint::Linter::VendorPrefixes do
   context 'when an vendor-prefixed unlisted directive is used' do
     let(:linter_config) { { 'identifier_list' => ['placeholder'] } }
 
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       @-webkit-keyframes anim {
         0% { opacity: 0; }
       }
-    CSS
+    SCSS
 
     it { should_not report_lint }
   end
@@ -180,11 +180,11 @@ describe SCSSLint::Linter::VendorPrefixes do
   context 'when an vendor-prefixed custom-listed directive is used' do
     let(:linter_config) { { 'identifier_list' => ['keyframes'] } }
 
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       @-webkit-keyframes anim {
         0% { opacity: 0; }
       }
-    CSS
+    SCSS
 
     it { should report_lint line: 1 }
   end
@@ -192,23 +192,23 @@ describe SCSSLint::Linter::VendorPrefixes do
   # Values
 
   context 'when a vendor-prefixed listed value is used' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       div {
         background-image: -webkit-linear-gradient(#000, #fff);
         position: -moz-sticky;
       }
-    CSS
+    SCSS
 
     it { should report_lint line: 2 }
     it { should report_lint line: 3 }
   end
 
   context 'when an unprefixed listed value is used' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       div {
         background-image: linear-gradient(#000, #fff);
       }
-    CSS
+    SCSS
 
     it { should_not report_lint }
   end
@@ -216,12 +216,12 @@ describe SCSSLint::Linter::VendorPrefixes do
   context 'when a vendor-unprefixed unlisted value is used' do
     let(:linter_config) { { 'identifier_list' => ['keyframes'] } }
 
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       div {
         background-image: -webkit-linear-gradient(#000, #fff);
         position: -moz-sticky;
       }
-    CSS
+    SCSS
 
     it { should_not report_lint }
   end
@@ -229,12 +229,12 @@ describe SCSSLint::Linter::VendorPrefixes do
   context 'when a vendor-unprefixed custom-listed value is used' do
     let(:linter_config) { { 'identifier_list' => ['linear-gradient'] } }
 
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       div {
         background-image: -webkit-linear-gradient(#000, #fff);
         position: -moz-sticky;
       }
-    CSS
+    SCSS
 
     it { should report_lint line: 2 }
   end
@@ -245,33 +245,33 @@ describe SCSSLint::Linter::VendorPrefixes do
     let(:linter_config) { { 'identifier_list' => 'bourbon' } }
 
     context 'and a standard vendor-prefixed property is used' do
-      let(:css) { <<-CSS }
+      let(:scss) { <<-SCSS }
         div {
           background-image: -webkit-linear-gradient(#000, #fff);
         }
-      CSS
+      SCSS
 
       it { should report_lint line: 2 }
     end
 
     context 'and a list-specific vendor-prefixed property is used' do
-      let(:css) { <<-CSS }
+      let(:scss) { <<-SCSS }
         div {
           image-rendering: -moz-crisp-edges;
           -webkit-appearance: none;
         }
-      CSS
+      SCSS
 
       it { should report_lint line: 2 }
       it { should report_lint line: 3 }
     end
 
     context 'and a list-exempt vendor-prefixed property is used' do
-      let(:css) { <<-CSS }
+      let(:scss) { <<-SCSS }
         div {
           -webkit-mask-repeat: inherit;
         }
-      CSS
+      SCSS
 
       it { should_not report_lint }
     end
@@ -282,14 +282,14 @@ describe SCSSLint::Linter::VendorPrefixes do
   context 'when manually excluding identifiers' do
     let(:linter_config) { { 'exclude' => %w[transform selection] } }
 
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       div {
         -wekit-transform: translateZ(0);
       }
       ::-moz-selection {
         color: #000;
       }
-    CSS
+    SCSS
 
     it { should_not report_lint }
   end
@@ -297,24 +297,24 @@ describe SCSSLint::Linter::VendorPrefixes do
   context 'when manually including identifiers' do
     let(:linter_config) { { 'include' => ['padding-end'] } }
 
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       div {
         -moz-padding-end: 0;
       }
-    CSS
+    SCSS
 
     it { should report_lint line: 2 }
   end
 
   # More
   context 'when dealing with many-hyphened vendor-prefixed identifiers' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       div {
         -moz-animation-timing-function: ease-out;
         -webkit-border-bottom-right-radius: 5px;
         background: -o-repeating-radial-gradient(#000, #000 5px, #fff 5px, #fff 10px)
       }
-    CSS
+    SCSS
 
     it { should report_lint line: 2 }
     it { should report_lint line: 3 }
@@ -322,19 +322,19 @@ describe SCSSLint::Linter::VendorPrefixes do
   end
 
   context 'when dealing with many-hyphened unprefixed identifiers' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       div {
         animation-timing-function: ease-out;
         border-bottom-right-radius: 5px;
         background: repeating-radial-gradient(#000, #000 5px, #fff 5px, #fff 10px)
       }
-    CSS
+    SCSS
 
     it { should_not report_lint }
   end
 
   context 'when vendor-prefixed media queries are used' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
     @media
       only screen and (-webkit-min-device-pixel-ratio: 1.3),
       only screen and (-o-min-device-pixel-ratio: 13/10),
@@ -343,7 +343,17 @@ describe SCSSLint::Linter::VendorPrefixes do
           background: #fff;
         }
       }
-    CSS
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when property contains a list literal with an empty list' do
+    let(:scss) { <<-SCSS }
+      p {
+        content: 0 ();
+      }
+    SCSS
 
     it { should_not report_lint }
   end