scss-lint 0.33.0 → 0.34.0

data/spec/scss_lint/linter/color_variable_spec.rb

@@ -0,0 +1,102 @@
+require 'spec_helper'
+
+describe SCSSLint::Linter::ColorVariable do
+  context 'when a color literal is used in a variable declaration' do
+    let(:scss) { <<-SCSS }
+      $my-color: #f00;
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when a color literal is used in a property' do
+    let(:scss) { <<-SCSS }
+      p {
+        color: #f00;
+      }
+    SCSS
+
+    it { should report_lint line: 2 }
+  end
+
+  context 'when a color literal is used in a function call' do
+    let(:scss) { <<-SCSS }
+      p {
+        color: my-func(#f00);
+      }
+    SCSS
+
+    it { should report_lint line: 2 }
+  end
+
+  context 'when a color literal is used in a mixin' do
+    let(:scss) { <<-SCSS }
+      p {
+        @include my-mixin(#f00);
+      }
+    SCSS
+
+    it { should report_lint line: 2 }
+  end
+
+  context 'when a color literal is used in a shorthand property' do
+    let(:scss) { <<-SCSS }
+      p {
+        border: 1px solid #f00;
+      }
+    SCSS
+
+    it { should report_lint line: 2 }
+  end
+
+  context 'when a number is used in a property' do
+    let(:scss) { <<-SCSS }
+      p {
+        z-index: 9000;
+        transition-duration: 250ms;
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when a non-color keyword is used in a property' do
+    let(:scss) { <<-SCSS }
+      p {
+        overflow: hidden;
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when a variable is used in a property' do
+    let(:scss) { <<-SCSS }
+      p {
+        color: $my-color;
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when a variable is used in a function call' do
+    let(:scss) { <<-SCSS }
+      p {
+        color: my-func($my-color);
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when a variable is used in a shorthand property' do
+    let(:scss) { <<-SCSS }
+      p {
+        border: 1px solid $my-color;
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+end

data/spec/scss_lint/linter/comment_spec.rb

@@ -2,33 +2,33 @@ require 'spec_helper'
 
 describe SCSSLint::Linter::Comment do
   context 'when no comments exist' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       p {
         margin: 0;
       }
-    CSS
+    SCSS
 
     it { should_not report_lint }
   end
 
   context 'when comment is a single line comment' do
-    let(:css) { '// Single line comment' }
+    let(:scss) { '// Single line comment' }
 
     it { should_not report_lint }
   end
 
   context 'when comment is a single line comment at the end of a line' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       p {
         margin: 0; // Comment at end of line
       }
-    CSS
+    SCSS
 
     it { should_not report_lint }
   end
 
   context 'when comment is a multi-line comment' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       h1 {
         color: #eee;
       }
@@ -38,17 +38,17 @@ describe SCSSLint::Linter::Comment do
       p {
         color: #DDD;
       }
-    CSS
+    SCSS
 
     it { should report_lint line: 4 }
   end
 
   context 'when multi-line-style comment is a at the end of a line' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       h1 {
         color: #eee; /* This is a comment */
       }
-    CSS
+    SCSS
 
     it { should report_lint line: 2 }
   end

data/spec/scss_lint/linter/compass/property_with_mixin_spec.rb

@@ -2,41 +2,41 @@ require 'spec_helper'
 
 describe SCSSLint::Linter::Compass::PropertyWithMixin do
   context 'when a rule has a property with an equivalent Compass mixin' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       p {
         opacity: .5;
       }
-    CSS
+    SCSS
 
     it { should report_lint line: 2 }
   end
 
   context 'when a rule includes a Compass property mixin' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       p {
         @include opacity(.5);
       }
-    CSS
+    SCSS
 
     it { should_not report_lint }
   end
 
   context 'when a rule does not have a property with a corresponding Compass mixin' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       p {
         margin: 0;
       }
-    CSS
+    SCSS
 
     it { should_not report_lint }
   end
 
   context 'when a rule includes display: inline-block' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       p {
         display: inline-block;
       }
-    CSS
+    SCSS
 
     it { should report_lint line: 2 }
   end
@@ -44,11 +44,11 @@ describe SCSSLint::Linter::Compass::PropertyWithMixin do
   context 'when properties are ignored' do
     let(:linter_config) { { 'ignore' => %w[inline-block] } }
 
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       p {
         display: inline-block;
       }
-    CSS
+    SCSS
 
     it { should_not report_lint }
   end

data/spec/scss_lint/linter/debug_statement_spec.rb

@@ -2,19 +2,19 @@ require 'spec_helper'
 
 describe SCSSLint::Linter::DebugStatement do
   context 'when no debug statements are present' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       p {
         color: #fff;
       }
-    CSS
+    SCSS
 
     it { should_not report_lint }
   end
 
   context 'when a debug statement is present' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       @debug 'This is a debug statement';
-    CSS
+    SCSS
 
     it { should report_lint line: 1 }
   end

data/spec/scss_lint/linter/declaration_order_spec.rb

@@ -2,50 +2,50 @@ require 'spec_helper'
 
 describe SCSSLint::Linter::DeclarationOrder do
   context 'when rule is empty' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       p {
       }
-    CSS
+    SCSS
 
     it { should_not report_lint }
   end
 
   context 'when rule contains only properties' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       p {
         background: #000;
         margin: 5px;
       }
-    CSS
+    SCSS
 
     it { should_not report_lint }
   end
 
   context 'when rule contains only mixins' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       p {
         @include border-radius(5px);
         @include box-shadow(5px);
       }
-    CSS
+    SCSS
 
     it { should_not report_lint }
   end
 
   context 'when rule contains no mixins or properties' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       p {
         a {
           color: #f00;
         }
       }
-    CSS
+    SCSS
 
     it { should_not report_lint }
   end
 
   context 'when rule contains properties after nested rules' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       p {
         a {
           color: #f00;
@@ -53,13 +53,13 @@ describe SCSSLint::Linter::DeclarationOrder do
         color: #f00;
         margin: 5px;
       }
-    CSS
+    SCSS
 
     it { should report_lint }
   end
 
   context 'when @extend appears before any properties or rules' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       .warn {
         font-weight: bold;
       }
@@ -70,13 +70,13 @@ describe SCSSLint::Linter::DeclarationOrder do
           color: #ccc;
         }
       }
-    CSS
+    SCSS
 
     it { should_not report_lint }
   end
 
   context 'when @extend appears after a property' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       .warn {
         font-weight: bold;
       }
@@ -87,40 +87,40 @@ describe SCSSLint::Linter::DeclarationOrder do
           color: #ccc;
         }
       }
-    CSS
+    SCSS
 
     it { should report_lint }
   end
 
   context 'when nested rule set' do
     context 'contains @extend before a property' do
-      let(:css) { <<-CSS }
+      let(:scss) { <<-SCSS }
         p {
           a {
             @extend foo;
             color: #f00;
           }
         }
-      CSS
+      SCSS
 
       it { should_not report_lint }
     end
 
     context 'contains @extend after a property' do
-      let(:css) { <<-CSS }
+      let(:scss) { <<-SCSS }
         p {
           a {
             color: #f00;
             @extend foo;
           }
         }
-      CSS
+      SCSS
 
       it { should report_lint }
     end
 
     context 'contains @extend after nested rule set' do
-      let(:css) { <<-CSS }
+      let(:scss) { <<-SCSS }
         p {
           a {
             span {
@@ -129,7 +129,7 @@ describe SCSSLint::Linter::DeclarationOrder do
             @extend foo;
           }
         }
-      CSS
+      SCSS
 
       it { should report_lint }
     end
@@ -137,7 +137,7 @@ describe SCSSLint::Linter::DeclarationOrder do
 
   context 'when @include appears' do
     context 'before a property and rule set' do
-      let(:css) { <<-CSS }
+      let(:scss) { <<-SCSS }
         .error {
           @include warn;
           color: #f00;
@@ -145,13 +145,13 @@ describe SCSSLint::Linter::DeclarationOrder do
             color: #ccc;
           }
         }
-      CSS
+      SCSS
 
       it { should_not report_lint }
     end
 
     context 'after a property and before a rule set' do
-      let(:css) { <<-CSS }
+      let(:scss) { <<-SCSS }
         .error {
           color: #f00;
           @include warn;
@@ -159,7 +159,7 @@ describe SCSSLint::Linter::DeclarationOrder do
             color: #ccc;
           }
         }
-      CSS
+      SCSS
 
       it { should report_lint }
     end
@@ -167,46 +167,46 @@ describe SCSSLint::Linter::DeclarationOrder do
 
   context 'when @include that features @content appears' do
     context 'before a property' do
-      let(:css) { <<-CSS }
+      let(:scss) { <<-SCSS }
         .foo {
           @include breakpoint("phone") {
             color: #ccc;
           }
           color: #f00;
         }
-      CSS
+      SCSS
 
       it { should report_lint }
     end
 
     context 'after a property' do
-      let(:css) { <<-CSS }
+      let(:scss) { <<-SCSS }
         .foo {
           color: #f00;
           @include breakpoint("phone") {
             color: #ccc;
           }
         }
-      CSS
+      SCSS
 
       it { should_not report_lint }
     end
 
     context 'before an @extend' do
-      let(:css) { <<-CSS }
+      let(:scss) { <<-SCSS }
         .foo {
           @include breakpoint("phone") {
             color: #ccc;
           }
           @extend .bar;
         }
-      CSS
+      SCSS
 
       it { should report_lint }
     end
 
     context 'before a rule set' do
-      let(:css) { <<-CSS }
+      let(:scss) { <<-SCSS }
         .foo {
           @include breakpoint("phone") {
             color: #ccc;
@@ -215,13 +215,13 @@ describe SCSSLint::Linter::DeclarationOrder do
             color: #fff;
           }
         }
-      CSS
+      SCSS
 
       it { should_not report_lint }
     end
 
     context 'after a rule set' do
-      let(:css) { <<-CSS }
+      let(:scss) { <<-SCSS }
         .foo {
           a {
             color: #fff;
@@ -230,34 +230,34 @@ describe SCSSLint::Linter::DeclarationOrder do
             color: #ccc;
           }
         }
-      CSS
+      SCSS
 
       it { should report_lint }
     end
 
     context 'with its own nested rule set' do
       context 'before a property' do
-        let(:css) { <<-CSS }
+        let(:scss) { <<-SCSS }
           @include breakpoint("phone") {
             a {
               color: #000;
             }
             color: #ccc;
           }
-        CSS
+        SCSS
 
         it { should report_lint }
       end
 
       context 'after a property' do
-        let(:css) { <<-CSS }
+        let(:scss) { <<-SCSS }
           @include breakpoint("phone") {
             color: #ccc;
             a {
               color: #000;
             }
           }
-        CSS
+        SCSS
 
         it { should_not report_lint }
       end
@@ -266,7 +266,7 @@ describe SCSSLint::Linter::DeclarationOrder do
 
   context 'when the nesting is crazy deep' do
     context 'and nothing is wrong' do
-      let(:css) { <<-CSS }
+      let(:scss) { <<-SCSS }
         div {
           ul {
             @extend .thing;
@@ -282,13 +282,13 @@ describe SCSSLint::Linter::DeclarationOrder do
             }
           }
         }
-      CSS
+      SCSS
 
       it { should_not report_lint }
     end
 
     context 'and something is wrong' do
-      let(:css) { <<-CSS }
+      let(:scss) { <<-SCSS }
         div {
           ul {
             li {
@@ -301,7 +301,7 @@ describe SCSSLint::Linter::DeclarationOrder do
             }
           }
         }
-      CSS
+      SCSS
 
       it { should report_lint }
     end
@@ -309,33 +309,33 @@ describe SCSSLint::Linter::DeclarationOrder do
 
   context 'when inside a @media query and rule set' do
     context 'contains @extend before a property' do
-      let(:css) { <<-CSS }
+      let(:scss) { <<-SCSS }
         @media only screen and (max-width: 1px) {
           a {
             @extend foo;
             color: #f00;
           }
         }
-      CSS
+      SCSS
 
       it { should_not report_lint }
     end
 
     context 'contains @extend after a property' do
-      let(:css) { <<-CSS }
+      let(:scss) { <<-SCSS }
         @media only screen and (max-width: 1px) {
           a {
             color: #f00;
             @extend foo;
           }
         }
-      CSS
+      SCSS
 
       it { should report_lint }
     end
 
     context 'contains @extend after nested rule set' do
-      let(:css) { <<-CSS }
+      let(:scss) { <<-SCSS }
         @media only screen and (max-width: 1px) {
           a {
             span {
@@ -344,216 +344,216 @@ describe SCSSLint::Linter::DeclarationOrder do
             @extend foo;
           }
         }
-      CSS
+      SCSS
 
       it { should report_lint }
     end
   end
 
   context 'when a pseudo-element appears before a property' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       a {
         &:hover {
           color: #000;
         }
         color: #fff;
       }
-    CSS
+    SCSS
 
     it { should report_lint }
   end
 
   context 'when a pseudo-element appears after a property' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       a {
         color: #fff;
         &:focus {
           color: #000;
         }
       }
-    CSS
+    SCSS
 
     it { should_not report_lint }
   end
 
   context 'when a chained selector appears after a property' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       a {
         color: #fff;
         &.is-active {
           color: #000;
         }
       }
-    CSS
+    SCSS
 
     it { should_not report_lint }
   end
 
   context 'when a chained selector appears before a property' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       a {
         &.is-active {
           color: #000;
         }
         color: #fff;
       }
-    CSS
+    SCSS
 
     it { should report_lint }
   end
 
   context 'when a selector with parent reference appears after a property' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       a {
         color: #fff;
         .is-active & {
           color: #000;
         }
       }
-    CSS
+    SCSS
 
     it { should_not report_lint }
   end
 
   context 'when a selector with parent reference appears before a property' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       a {
         .is-active & {
           color: #000;
         }
         color: #fff;
       }
-    CSS
+    SCSS
 
     it { should report_lint }
   end
 
   context 'when a pseudo-element appears after a property' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       a {
         color: #fff;
         &:before {
           color: #000;
         }
       }
-    CSS
+    SCSS
 
     it { should_not report_lint }
   end
 
   context 'when a pseudo-element appears before a property' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       a {
         &:before {
           color: #000;
         }
         color: #fff;
       }
-    CSS
+    SCSS
 
     it { should report_lint }
   end
 
   context 'when a direct descendent appears after a property' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       a {
         color: #fff;
         > .foo {
           color: #000;
         }
       }
-    CSS
+    SCSS
 
     it { should_not report_lint }
   end
 
   context 'when a direct descendent appears before a property' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       a {
         > .foo {
           color: #000;
         }
         color: #fff;
       }
-    CSS
+    SCSS
 
     it { should report_lint }
   end
 
   context 'when an adjacent sibling appears after a property' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       a {
         color: #fff;
         & + .foo {
           color: #000;
         }
       }
-    CSS
+    SCSS
 
     it { should_not report_lint }
   end
 
   context 'when an adjacent sibling appears before a property' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       a {
         & + .foo {
           color: #000;
         }
         color: #fff;
       }
-    CSS
+    SCSS
 
     it { should report_lint }
   end
 
   context 'when a general sibling appears after a property' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       a {
         color: #fff;
         & ~ .foo {
           color: #000;
         }
       }
-    CSS
+    SCSS
 
     it { should_not report_lint }
   end
 
   context 'when a general sibling appears before a property' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       a {
         & ~ .foo {
           color: #000;
         }
         color: #fff;
       }
-    CSS
+    SCSS
 
     it { should report_lint }
   end
 
   context 'when a descendent appears after a property' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       a {
         color: #fff;
         .foo {
           color: #000;
         }
       }
-    CSS
+    SCSS
 
     it { should_not report_lint }
   end
 
   context 'when a descendent appears before a property' do
-    let(:css) { <<-CSS }
+    let(:scss) { <<-SCSS }
       a {
         .foo {
           color: #000;
         }
         color: #fff;
       }
-    CSS
+    SCSS
 
     it { should report_lint }
   end