rubocop 0.70.0 → 1.6.1
Sign up to get free protection for your applications and to get access to all the features.
- checksums.yaml +4 -4
- data/LICENSE.txt +1 -1
- data/README.md +64 -40
- data/config/default.yml +1316 -986
- data/config/obsoletion.yml +196 -0
- data/exe/rubocop +1 -1
- data/lib/rubocop/ast_aliases.rb +8 -0
- data/lib/rubocop/cached_data.rb +4 -2
- data/lib/rubocop/cli/command/auto_genenerate_config.rb +141 -0
- data/lib/rubocop/cli/command/base.rb +35 -0
- data/lib/rubocop/cli/command/execute_runner.rb +100 -0
- data/lib/rubocop/cli/command/init_dotfile.rb +46 -0
- data/lib/rubocop/cli/command/show_cops.rb +77 -0
- data/lib/rubocop/cli/command/suggest_extensions.rb +80 -0
- data/lib/rubocop/cli/command/version.rb +18 -0
- data/lib/rubocop/cli/command.rb +22 -0
- data/lib/rubocop/cli/environment.rb +22 -0
- data/lib/rubocop/cli.rb +22 -230
- data/lib/rubocop/comment_config.rb +29 -16
- data/lib/rubocop/config.rb +80 -509
- data/lib/rubocop/config_loader.rb +122 -91
- data/lib/rubocop/config_loader_resolver.rb +65 -24
- data/lib/rubocop/config_obsoletion/changed_enforced_styles.rb +33 -0
- data/lib/rubocop/config_obsoletion/changed_parameter.rb +21 -0
- data/lib/rubocop/config_obsoletion/cop_rule.rb +34 -0
- data/lib/rubocop/config_obsoletion/extracted_cop.rb +44 -0
- data/lib/rubocop/config_obsoletion/parameter_rule.rb +44 -0
- data/lib/rubocop/config_obsoletion/removed_cop.rb +41 -0
- data/lib/rubocop/config_obsoletion/renamed_cop.rb +34 -0
- data/lib/rubocop/config_obsoletion/rule.rb +41 -0
- data/lib/rubocop/config_obsoletion/split_cop.rb +27 -0
- data/lib/rubocop/config_obsoletion.rb +101 -0
- data/lib/rubocop/config_regeneration.rb +33 -0
- data/lib/rubocop/config_store.rb +19 -5
- data/lib/rubocop/config_validator.rb +239 -0
- data/lib/rubocop/cop/autocorrect_logic.rb +83 -6
- data/lib/rubocop/cop/badge.rb +15 -30
- data/lib/rubocop/cop/base.rb +447 -0
- data/lib/rubocop/cop/bundler/duplicated_gem.rb +28 -4
- data/lib/rubocop/cop/bundler/gem_comment.rb +83 -9
- data/lib/rubocop/cop/bundler/insecure_protocol_source.rb +15 -23
- data/lib/rubocop/cop/bundler/ordered_gems.rb +1 -1
- data/lib/rubocop/cop/commissioner.rb +102 -70
- data/lib/rubocop/cop/cop.rb +102 -186
- data/lib/rubocop/cop/corrector.rb +71 -122
- data/lib/rubocop/cop/correctors/alignment_corrector.rb +45 -23
- data/lib/rubocop/cop/correctors/condition_corrector.rb +3 -6
- data/lib/rubocop/cop/correctors/empty_line_corrector.rb +9 -10
- data/lib/rubocop/cop/correctors/lambda_literal_to_method_corrector.rb +4 -4
- data/lib/rubocop/cop/correctors/line_break_corrector.rb +10 -10
- data/lib/rubocop/cop/correctors/multiline_literal_brace_corrector.rb +36 -5
- data/lib/rubocop/cop/correctors/parentheses_corrector.rb +5 -8
- data/lib/rubocop/cop/correctors/percent_literal_corrector.rb +9 -14
- data/lib/rubocop/cop/correctors/punctuation_corrector.rb +8 -10
- data/lib/rubocop/cop/correctors/space_corrector.rb +2 -5
- data/lib/rubocop/cop/correctors/string_literal_corrector.rb +6 -8
- data/lib/rubocop/cop/correctors/unused_arg_corrector.rb +15 -18
- data/lib/rubocop/cop/documentation.rb +22 -0
- data/lib/rubocop/cop/force.rb +2 -1
- data/lib/rubocop/cop/gemspec/duplicated_assignment.rb +5 -5
- data/lib/rubocop/cop/gemspec/ordered_dependencies.rb +3 -5
- data/lib/rubocop/cop/gemspec/required_ruby_version.rb +45 -20
- data/lib/rubocop/cop/gemspec/ruby_version_globals_usage.rb +55 -0
- data/lib/rubocop/cop/generator/configuration_injector.rb +12 -7
- data/lib/rubocop/cop/generator/require_file_injector.rb +1 -1
- data/lib/rubocop/cop/generator.rb +15 -21
- data/lib/rubocop/cop/ignored_node.rb +1 -3
- data/lib/rubocop/cop/internal_affairs/method_name_equal.rb +52 -0
- data/lib/rubocop/cop/internal_affairs/node_destructuring.rb +3 -3
- data/lib/rubocop/cop/internal_affairs/node_type_predicate.rb +13 -15
- data/lib/rubocop/cop/internal_affairs/offense_location_keyword.rb +11 -10
- data/lib/rubocop/cop/internal_affairs/redundant_location_argument.rb +12 -8
- data/lib/rubocop/cop/internal_affairs/redundant_message_argument.rb +10 -10
- data/lib/rubocop/cop/internal_affairs/useless_message_assertion.rb +5 -5
- data/lib/rubocop/cop/internal_affairs.rb +1 -0
- data/lib/rubocop/cop/layout/{align_arguments.rb → argument_alignment.rb} +1 -1
- data/lib/rubocop/cop/layout/array_alignment.rb +83 -0
- data/lib/rubocop/cop/layout/{indent_assignment.rb → assignment_indentation.rb} +11 -2
- data/lib/rubocop/cop/layout/begin_end_alignment.rb +77 -0
- data/lib/rubocop/cop/layout/block_alignment.rb +30 -27
- data/lib/rubocop/cop/layout/block_end_newline.rb +5 -3
- data/lib/rubocop/cop/layout/case_indentation.rb +21 -25
- data/lib/rubocop/cop/layout/class_structure.rb +53 -69
- data/lib/rubocop/cop/layout/closing_heredoc_indentation.rb +4 -6
- data/lib/rubocop/cop/layout/closing_parenthesis_indentation.rb +1 -1
- data/lib/rubocop/cop/layout/comment_indentation.rb +14 -17
- data/lib/rubocop/cop/layout/condition_position.rb +16 -8
- data/lib/rubocop/cop/layout/def_end_alignment.rb +7 -4
- data/lib/rubocop/cop/layout/dot_position.rb +21 -20
- data/lib/rubocop/cop/layout/else_alignment.rb +23 -2
- data/lib/rubocop/cop/layout/empty_comment.rb +38 -40
- data/lib/rubocop/cop/layout/empty_line_after_guard_clause.rb +43 -25
- data/lib/rubocop/cop/layout/empty_line_after_magic_comment.rb +15 -15
- data/lib/rubocop/cop/layout/empty_line_after_multiline_condition.rb +136 -0
- data/lib/rubocop/cop/layout/empty_line_between_defs.rb +100 -31
- data/lib/rubocop/cop/layout/empty_lines.rb +6 -9
- data/lib/rubocop/cop/layout/empty_lines_around_access_modifier.rb +21 -20
- data/lib/rubocop/cop/layout/empty_lines_around_arguments.rb +13 -9
- data/lib/rubocop/cop/layout/empty_lines_around_attribute_accessor.rb +118 -0
- data/lib/rubocop/cop/layout/empty_lines_around_begin_body.rb +2 -5
- data/lib/rubocop/cop/layout/empty_lines_around_block_body.rb +4 -5
- data/lib/rubocop/cop/layout/empty_lines_around_class_body.rb +4 -7
- data/lib/rubocop/cop/layout/empty_lines_around_exception_handling_keywords.rb +3 -7
- data/lib/rubocop/cop/layout/empty_lines_around_method_body.rb +2 -5
- data/lib/rubocop/cop/layout/empty_lines_around_module_body.rb +2 -5
- data/lib/rubocop/cop/layout/end_alignment.rb +17 -22
- data/lib/rubocop/cop/layout/end_of_line.rb +16 -11
- data/lib/rubocop/cop/layout/extra_spacing.rb +34 -94
- data/lib/rubocop/cop/layout/{indent_first_argument.rb → first_argument_indentation.rb} +28 -15
- data/lib/rubocop/cop/layout/{indent_first_array_element.rb → first_array_element_indentation.rb} +18 -14
- data/lib/rubocop/cop/layout/first_array_element_line_break.rb +3 -6
- data/lib/rubocop/cop/layout/{indent_first_hash_element.rb → first_hash_element_indentation.rb} +5 -5
- data/lib/rubocop/cop/layout/first_hash_element_line_break.rb +2 -5
- data/lib/rubocop/cop/layout/first_method_argument_line_break.rb +5 -11
- data/lib/rubocop/cop/layout/first_method_parameter_line_break.rb +2 -5
- data/lib/rubocop/cop/layout/{indent_first_parameter.rb → first_parameter_indentation.rb} +8 -4
- data/lib/rubocop/cop/layout/{align_hash.rb → hash_alignment.rb} +41 -37
- data/lib/rubocop/cop/layout/heredoc_argument_closing_parenthesis.rb +30 -17
- data/lib/rubocop/cop/layout/heredoc_indentation.rb +176 -0
- data/lib/rubocop/cop/layout/indentation_consistency.rb +13 -12
- data/lib/rubocop/cop/layout/indentation_style.rb +115 -0
- data/lib/rubocop/cop/layout/indentation_width.rb +29 -13
- data/lib/rubocop/cop/layout/initial_indentation.rb +6 -7
- data/lib/rubocop/cop/layout/leading_comment_space.rb +72 -11
- data/lib/rubocop/cop/layout/{leading_blank_lines.rb → leading_empty_lines.rb} +6 -11
- data/lib/rubocop/cop/{metrics → layout}/line_length.rb +92 -130
- data/lib/rubocop/cop/layout/multiline_array_brace_layout.rb +2 -5
- data/lib/rubocop/cop/layout/multiline_array_line_breaks.rb +2 -5
- data/lib/rubocop/cop/layout/multiline_assignment_layout.rb +11 -15
- data/lib/rubocop/cop/layout/multiline_block_layout.rb +70 -27
- data/lib/rubocop/cop/layout/multiline_hash_brace_layout.rb +2 -9
- data/lib/rubocop/cop/layout/multiline_hash_key_line_breaks.rb +2 -5
- data/lib/rubocop/cop/layout/multiline_method_argument_line_breaks.rb +7 -11
- data/lib/rubocop/cop/layout/multiline_method_call_brace_layout.rb +2 -5
- data/lib/rubocop/cop/layout/multiline_method_call_indentation.rb +8 -4
- data/lib/rubocop/cop/layout/multiline_method_definition_brace_layout.rb +2 -5
- data/lib/rubocop/cop/layout/multiline_operation_indentation.rb +13 -4
- data/lib/rubocop/cop/layout/{align_parameters.rb → parameter_alignment.rb} +1 -1
- data/lib/rubocop/cop/layout/rescue_ensure_alignment.rb +59 -26
- data/lib/rubocop/cop/layout/space_after_colon.rb +12 -8
- data/lib/rubocop/cop/layout/space_after_comma.rb +2 -5
- data/lib/rubocop/cop/layout/space_after_method_name.rb +5 -6
- data/lib/rubocop/cop/layout/space_after_not.rb +9 -11
- data/lib/rubocop/cop/layout/space_after_semicolon.rb +2 -5
- data/lib/rubocop/cop/layout/space_around_block_parameters.rb +47 -42
- data/lib/rubocop/cop/layout/space_around_equals_in_parameter_default.rb +17 -21
- data/lib/rubocop/cop/layout/space_around_keyword.rb +31 -20
- data/lib/rubocop/cop/layout/space_around_method_call_operator.rb +98 -0
- data/lib/rubocop/cop/layout/space_around_operators.rb +127 -44
- data/lib/rubocop/cop/layout/space_before_block_braces.rb +54 -22
- data/lib/rubocop/cop/layout/space_before_comma.rb +3 -5
- data/lib/rubocop/cop/layout/space_before_comment.rb +9 -8
- data/lib/rubocop/cop/layout/space_before_first_arg.rb +15 -7
- data/lib/rubocop/cop/layout/space_before_semicolon.rb +2 -5
- data/lib/rubocop/cop/layout/space_in_lambda_literal.rb +17 -23
- data/lib/rubocop/cop/layout/space_inside_array_literal_brackets.rb +32 -33
- data/lib/rubocop/cop/layout/space_inside_array_percent_literal.rb +3 -8
- data/lib/rubocop/cop/layout/space_inside_block_braces.rb +37 -21
- data/lib/rubocop/cop/layout/space_inside_hash_literal_braces.rb +21 -46
- data/lib/rubocop/cop/layout/space_inside_parens.rb +43 -26
- data/lib/rubocop/cop/layout/space_inside_percent_literal_delimiters.rb +5 -10
- data/lib/rubocop/cop/layout/space_inside_range_literal.rb +9 -18
- data/lib/rubocop/cop/layout/space_inside_reference_brackets.rb +17 -27
- data/lib/rubocop/cop/layout/space_inside_string_interpolation.rb +24 -41
- data/lib/rubocop/cop/layout/{trailing_blank_lines.rb → trailing_empty_lines.rb} +10 -15
- data/lib/rubocop/cop/layout/trailing_whitespace.rb +56 -16
- data/lib/rubocop/cop/legacy/corrections_proxy.rb +49 -0
- data/lib/rubocop/cop/legacy/corrector.rb +29 -0
- data/lib/rubocop/cop/lint/ambiguous_block_association.rb +9 -4
- data/lib/rubocop/cop/lint/ambiguous_operator.rb +53 -5
- data/lib/rubocop/cop/lint/ambiguous_regexp_literal.rb +36 -6
- data/lib/rubocop/cop/lint/assignment_in_condition.rb +19 -6
- data/lib/rubocop/cop/lint/big_decimal_new.rb +10 -11
- data/lib/rubocop/cop/lint/binary_operator_with_identical_operands.rb +50 -0
- data/lib/rubocop/cop/lint/boolean_symbol.rb +22 -2
- data/lib/rubocop/cop/lint/circular_argument_reference.rb +1 -1
- data/lib/rubocop/cop/lint/constant_definition_in_block.rb +98 -0
- data/lib/rubocop/cop/lint/constant_resolution.rb +89 -0
- data/lib/rubocop/cop/lint/debugger.rb +18 -26
- data/lib/rubocop/cop/lint/deprecated_class_methods.rb +7 -10
- data/lib/rubocop/cop/lint/deprecated_open_ssl_constant.rb +141 -0
- data/lib/rubocop/cop/lint/disjunctive_assignment_in_constructor.rb +9 -3
- data/lib/rubocop/cop/lint/duplicate_branch.rb +93 -0
- data/lib/rubocop/cop/lint/duplicate_case_condition.rb +3 -13
- data/lib/rubocop/cop/lint/duplicate_elsif_condition.rb +39 -0
- data/lib/rubocop/cop/lint/{duplicated_key.rb → duplicate_hash_key.rb} +1 -1
- data/lib/rubocop/cop/lint/duplicate_methods.rb +10 -13
- data/lib/rubocop/cop/lint/duplicate_regexp_character_class_element.rb +77 -0
- data/lib/rubocop/cop/lint/duplicate_require.rb +46 -0
- data/lib/rubocop/cop/lint/duplicate_rescue_exception.rb +47 -0
- data/lib/rubocop/cop/lint/each_with_object_argument.rb +4 -3
- data/lib/rubocop/cop/lint/else_layout.rb +30 -4
- data/lib/rubocop/cop/lint/empty_block.rb +82 -0
- data/lib/rubocop/cop/lint/empty_class.rb +93 -0
- data/lib/rubocop/cop/lint/empty_conditional_body.rb +67 -0
- data/lib/rubocop/cop/lint/empty_ensure.rb +5 -5
- data/lib/rubocop/cop/lint/empty_expression.rb +2 -2
- data/lib/rubocop/cop/lint/empty_file.rb +50 -0
- data/lib/rubocop/cop/lint/empty_interpolation.rb +8 -9
- data/lib/rubocop/cop/lint/empty_when.rb +31 -8
- data/lib/rubocop/cop/lint/ensure_return.rb +29 -14
- data/lib/rubocop/cop/lint/erb_new_arguments.rb +66 -8
- data/lib/rubocop/cop/lint/flip_flop.rb +9 -3
- data/lib/rubocop/cop/lint/float_comparison.rb +93 -0
- data/lib/rubocop/cop/lint/float_out_of_range.rb +2 -2
- data/lib/rubocop/cop/lint/format_parameter_mismatch.rb +52 -41
- data/lib/rubocop/cop/lint/hash_compare_by_identity.rb +37 -0
- data/lib/rubocop/cop/lint/heredoc_method_call_position.rb +13 -14
- data/lib/rubocop/cop/lint/identity_comparison.rb +51 -0
- data/lib/rubocop/cop/lint/implicit_string_concatenation.rb +6 -5
- data/lib/rubocop/cop/lint/ineffective_access_modifier.rb +12 -15
- data/lib/rubocop/cop/lint/inherit_exception.rb +13 -8
- data/lib/rubocop/cop/lint/interpolation_check.rb +26 -5
- data/lib/rubocop/cop/lint/literal_as_condition.rb +24 -15
- data/lib/rubocop/cop/lint/literal_in_interpolation.rb +46 -15
- data/lib/rubocop/cop/lint/loop.rb +30 -7
- data/lib/rubocop/cop/lint/missing_cop_enable_directive.rb +8 -7
- data/lib/rubocop/cop/lint/missing_super.rb +102 -0
- data/lib/rubocop/cop/lint/mixed_regexp_capture_types.rb +37 -0
- data/lib/rubocop/cop/lint/{multiple_compare.rb → multiple_comparison.rb} +11 -12
- data/lib/rubocop/cop/lint/nested_method_definition.rb +20 -26
- data/lib/rubocop/cop/lint/nested_percent_literal.rb +16 -2
- data/lib/rubocop/cop/lint/next_without_accumulator.rb +2 -2
- data/lib/rubocop/cop/lint/no_return_in_begin_end_blocks.rb +58 -0
- data/lib/rubocop/cop/lint/non_deterministic_require_order.rb +160 -0
- data/lib/rubocop/cop/lint/non_local_exit_from_iterator.rb +10 -10
- data/lib/rubocop/cop/lint/number_conversion.rb +54 -23
- data/lib/rubocop/cop/lint/ordered_magic_comments.rb +11 -13
- data/lib/rubocop/cop/lint/out_of_range_regexp_ref.rb +98 -0
- data/lib/rubocop/cop/lint/parentheses_as_grouped_expression.rb +33 -12
- data/lib/rubocop/cop/lint/percent_string_array.rb +6 -11
- data/lib/rubocop/cop/lint/percent_symbol_array.rb +14 -13
- data/lib/rubocop/cop/lint/raise_exception.rb +86 -0
- data/lib/rubocop/cop/lint/rand_one.rb +4 -3
- data/lib/rubocop/cop/lint/{unneeded_cop_disable_directive.rb → redundant_cop_disable_directive.rb} +84 -76
- data/lib/rubocop/cop/lint/redundant_cop_enable_directive.rb +128 -0
- data/lib/rubocop/cop/lint/{unneeded_require_statement.rb → redundant_require_statement.rb} +9 -11
- data/lib/rubocop/cop/lint/redundant_safe_navigation.rb +78 -0
- data/lib/rubocop/cop/lint/{unneeded_splat_expansion.rb → redundant_splat_expansion.rb} +25 -16
- data/lib/rubocop/cop/lint/{string_conversion_in_interpolation.rb → redundant_string_coercion.rb} +11 -18
- data/lib/rubocop/cop/lint/redundant_with_index.rb +13 -16
- data/lib/rubocop/cop/lint/redundant_with_object.rb +13 -16
- data/lib/rubocop/cop/lint/regexp_as_condition.rb +6 -2
- data/lib/rubocop/cop/lint/require_parentheses.rb +2 -2
- data/lib/rubocop/cop/lint/rescue_exception.rb +2 -2
- data/lib/rubocop/cop/lint/rescue_type.rb +8 -9
- data/lib/rubocop/cop/lint/return_in_void_context.rb +2 -4
- data/lib/rubocop/cop/lint/safe_navigation_chain.rb +11 -15
- data/lib/rubocop/cop/lint/safe_navigation_consistency.rb +14 -10
- data/lib/rubocop/cop/lint/safe_navigation_with_empty.rb +11 -3
- data/lib/rubocop/cop/lint/script_permission.rb +10 -7
- data/lib/rubocop/cop/lint/self_assignment.rb +78 -0
- data/lib/rubocop/cop/lint/send_with_mixin_argument.rb +87 -0
- data/lib/rubocop/cop/lint/shadowed_argument.rb +3 -3
- data/lib/rubocop/cop/lint/shadowed_exception.rb +12 -13
- data/lib/rubocop/cop/lint/shadowing_outer_local_variable.rb +20 -7
- data/lib/rubocop/cop/lint/struct_new_override.rb +59 -0
- data/lib/rubocop/cop/lint/{handle_exceptions.rb → suppressed_exception.rb} +21 -27
- data/lib/rubocop/cop/lint/syntax.rb +11 -28
- data/lib/rubocop/cop/lint/to_enum_arguments.rb +86 -0
- data/lib/rubocop/cop/lint/to_json.rb +21 -12
- data/lib/rubocop/cop/lint/top_level_return_with_argument.rb +34 -0
- data/lib/rubocop/cop/lint/trailing_comma_in_attribute_declaration.rb +57 -0
- data/lib/rubocop/cop/lint/underscore_prefixed_variable_name.rb +4 -4
- data/lib/rubocop/cop/lint/unexpected_block_arity.rb +85 -0
- data/lib/rubocop/cop/lint/unified_integer.rb +5 -9
- data/lib/rubocop/cop/lint/unmodified_reduce_accumulator.rb +199 -0
- data/lib/rubocop/cop/lint/unreachable_code.rb +3 -3
- data/lib/rubocop/cop/lint/unreachable_loop.rb +171 -0
- data/lib/rubocop/cop/lint/unused_block_argument.rb +30 -9
- data/lib/rubocop/cop/lint/unused_method_argument.rb +63 -14
- data/lib/rubocop/cop/lint/uri_escape_unescape.rb +5 -3
- data/lib/rubocop/cop/lint/uri_regexp.rb +12 -47
- data/lib/rubocop/cop/lint/useless_access_modifier.rb +95 -47
- data/lib/rubocop/cop/lint/useless_assignment.rb +7 -6
- data/lib/rubocop/cop/lint/useless_else_without_rescue.rb +7 -11
- data/lib/rubocop/cop/lint/useless_method_definition.rb +68 -0
- data/lib/rubocop/cop/lint/useless_setter_call.rb +15 -8
- data/lib/rubocop/cop/lint/useless_times.rb +106 -0
- data/lib/rubocop/cop/lint/void.rb +10 -33
- data/lib/rubocop/cop/message_annotator.rb +16 -7
- data/lib/rubocop/cop/metrics/abc_size.rb +27 -3
- data/lib/rubocop/cop/metrics/block_length.rb +40 -10
- data/lib/rubocop/cop/metrics/block_nesting.rb +2 -2
- data/lib/rubocop/cop/metrics/class_length.rb +39 -8
- data/lib/rubocop/cop/metrics/cyclomatic_complexity.rb +37 -4
- data/lib/rubocop/cop/metrics/method_length.rb +33 -5
- data/lib/rubocop/cop/metrics/module_length.rb +27 -4
- data/lib/rubocop/cop/metrics/parameter_lists.rb +71 -9
- data/lib/rubocop/cop/metrics/perceived_complexity.rb +7 -8
- data/lib/rubocop/cop/metrics/utils/abc_size_calculator.rb +95 -14
- data/lib/rubocop/cop/metrics/utils/code_length_calculator.rb +158 -0
- data/lib/rubocop/cop/metrics/utils/iterating_block.rb +61 -0
- data/lib/rubocop/cop/metrics/utils/repeated_attribute_discount.rb +146 -0
- data/lib/rubocop/cop/metrics/utils/repeated_csend_discount.rb +42 -0
- data/lib/rubocop/cop/migration/department_name.rb +83 -0
- data/lib/rubocop/cop/mixin/alignment.rb +8 -6
- data/lib/rubocop/cop/mixin/allowed_methods.rb +21 -0
- data/lib/rubocop/cop/mixin/annotation_comment.rb +5 -0
- data/lib/rubocop/cop/mixin/array_min_size.rb +2 -4
- data/lib/rubocop/cop/mixin/auto_corrector.rb +12 -0
- data/lib/rubocop/cop/mixin/check_line_breakable.rb +20 -17
- data/lib/rubocop/cop/mixin/code_length.rb +26 -5
- data/lib/rubocop/cop/mixin/comments_help.rb +48 -0
- data/lib/rubocop/cop/mixin/configurable_enforced_style.rb +5 -3
- data/lib/rubocop/cop/mixin/configurable_formatting.rb +3 -5
- data/lib/rubocop/cop/mixin/configurable_naming.rb +2 -2
- data/lib/rubocop/cop/mixin/configurable_numbering.rb +4 -3
- data/lib/rubocop/cop/mixin/def_node.rb +1 -1
- data/lib/rubocop/cop/mixin/documentation_comment.rb +2 -4
- data/lib/rubocop/cop/mixin/empty_lines_around_body.rb +8 -7
- data/lib/rubocop/cop/mixin/empty_parameter.rb +4 -2
- data/lib/rubocop/cop/mixin/end_keyword_alignment.rb +18 -2
- data/lib/rubocop/cop/mixin/enforce_superclass.rb +15 -5
- data/lib/rubocop/cop/mixin/first_element_line_break.rb +4 -2
- data/lib/rubocop/cop/mixin/frozen_string_literal.rb +15 -6
- data/lib/rubocop/cop/mixin/{hash_alignment.rb → hash_alignment_styles.rb} +5 -1
- data/lib/rubocop/cop/mixin/hash_transform_method.rb +197 -0
- data/lib/rubocop/cop/mixin/ignored_methods.rb +36 -3
- data/lib/rubocop/cop/mixin/ignored_pattern.rb +1 -1
- data/lib/rubocop/cop/mixin/interpolation.rb +27 -0
- data/lib/rubocop/cop/mixin/line_length_help.rb +87 -0
- data/lib/rubocop/cop/mixin/method_complexity.rb +24 -4
- data/lib/rubocop/cop/mixin/multiline_element_line_breaks.rb +3 -1
- data/lib/rubocop/cop/mixin/multiline_expression_indentation.rb +5 -5
- data/lib/rubocop/cop/mixin/multiline_literal_brace_layout.rb +13 -12
- data/lib/rubocop/cop/mixin/negative_conditional.rb +2 -2
- data/lib/rubocop/cop/mixin/nil_methods.rb +4 -6
- data/lib/rubocop/cop/mixin/ordered_gem_node.rb +6 -1
- data/lib/rubocop/cop/mixin/parentheses.rb +1 -2
- data/lib/rubocop/cop/mixin/percent_array.rb +16 -9
- data/lib/rubocop/cop/mixin/preceding_following_alignment.rb +88 -1
- data/lib/rubocop/cop/mixin/range_help.rb +19 -5
- data/lib/rubocop/cop/mixin/rational_literal.rb +18 -0
- data/lib/rubocop/cop/mixin/rescue_node.rb +11 -1
- data/lib/rubocop/cop/mixin/space_after_punctuation.rb +4 -3
- data/lib/rubocop/cop/mixin/space_before_punctuation.rb +4 -3
- data/lib/rubocop/cop/mixin/statement_modifier.rb +51 -23
- data/lib/rubocop/cop/mixin/string_help.rb +4 -1
- data/lib/rubocop/cop/mixin/string_literals_help.rb +1 -1
- data/lib/rubocop/cop/mixin/surrounding_space.rb +19 -33
- data/lib/rubocop/cop/mixin/target_ruby_version.rb +5 -1
- data/lib/rubocop/cop/mixin/trailing_comma.rb +27 -33
- data/lib/rubocop/cop/mixin/uncommunicative_name.rb +13 -18
- data/lib/rubocop/cop/mixin/unused_argument.rb +4 -6
- data/lib/rubocop/cop/mixin/visibility_help.rb +36 -0
- data/lib/rubocop/cop/naming/accessor_method_name.rb +19 -3
- data/lib/rubocop/cop/naming/ascii_identifiers.rb +29 -6
- data/lib/rubocop/cop/naming/binary_operator_parameter_name.rb +16 -6
- data/lib/rubocop/cop/naming/{uncommunicative_block_param_name.rb → block_parameter_name.rb} +3 -3
- data/lib/rubocop/cop/naming/class_and_module_camel_case.rb +13 -3
- data/lib/rubocop/cop/naming/constant_name.rb +5 -4
- data/lib/rubocop/cop/naming/file_name.rb +40 -22
- data/lib/rubocop/cop/naming/heredoc_delimiter_case.rb +12 -6
- data/lib/rubocop/cop/naming/heredoc_delimiter_naming.rb +8 -8
- data/lib/rubocop/cop/naming/memoized_instance_variable_name.rb +69 -20
- data/lib/rubocop/cop/naming/method_name.rb +39 -2
- data/lib/rubocop/cop/naming/{uncommunicative_method_param_name.rb → method_parameter_name.rb} +3 -3
- data/lib/rubocop/cop/naming/predicate_name.rb +12 -15
- data/lib/rubocop/cop/naming/rescued_exceptions_variable_name.rb +27 -28
- data/lib/rubocop/cop/naming/variable_name.rb +2 -1
- data/lib/rubocop/cop/naming/variable_number.rb +101 -9
- data/lib/rubocop/cop/offense.rb +62 -12
- data/lib/rubocop/cop/registry.rb +97 -11
- data/lib/rubocop/cop/security/eval.rb +4 -3
- data/lib/rubocop/cop/security/json_load.rb +8 -9
- data/lib/rubocop/cop/security/marshal_load.rb +4 -5
- data/lib/rubocop/cop/security/open.rb +15 -12
- data/lib/rubocop/cop/security/yaml_load.rb +8 -7
- data/lib/rubocop/cop/severity.rb +1 -11
- data/lib/rubocop/cop/style/access_modifier_declarations.rb +36 -12
- data/lib/rubocop/cop/style/accessor_grouping.rb +152 -0
- data/lib/rubocop/cop/style/alias.rb +45 -38
- data/lib/rubocop/cop/style/and_or.rb +27 -22
- data/lib/rubocop/cop/style/arguments_forwarding.rb +142 -0
- data/lib/rubocop/cop/style/array_coercion.rb +67 -0
- data/lib/rubocop/cop/style/array_join.rb +8 -9
- data/lib/rubocop/cop/style/ascii_comments.rb +4 -4
- data/lib/rubocop/cop/style/attr.rb +22 -13
- data/lib/rubocop/cop/style/auto_resource_cleanup.rb +7 -7
- data/lib/rubocop/cop/style/bare_percent_literals.rb +12 -14
- data/lib/rubocop/cop/style/begin_block.rb +2 -2
- data/lib/rubocop/cop/style/bisected_attr_accessor.rb +137 -0
- data/lib/rubocop/cop/style/block_comments.rb +14 -18
- data/lib/rubocop/cop/style/block_delimiters.rb +79 -27
- data/lib/rubocop/cop/style/case_equality.rb +54 -4
- data/lib/rubocop/cop/style/case_like_if.rb +248 -0
- data/lib/rubocop/cop/style/character_literal.rb +10 -11
- data/lib/rubocop/cop/style/class_and_module_children.rb +26 -16
- data/lib/rubocop/cop/style/class_check.rb +6 -11
- data/lib/rubocop/cop/style/class_equality_comparison.rb +64 -0
- data/lib/rubocop/cop/style/class_methods.rb +7 -11
- data/lib/rubocop/cop/style/class_methods_definitions.rb +157 -0
- data/lib/rubocop/cop/style/class_vars.rb +23 -7
- data/lib/rubocop/cop/style/collection_compact.rb +91 -0
- data/lib/rubocop/cop/style/collection_methods.rb +13 -17
- data/lib/rubocop/cop/style/colon_method_call.rb +9 -10
- data/lib/rubocop/cop/style/colon_method_definition.rb +6 -6
- data/lib/rubocop/cop/style/combinable_loops.rb +91 -0
- data/lib/rubocop/cop/style/command_literal.rb +24 -25
- data/lib/rubocop/cop/style/comment_annotation.rb +23 -17
- data/lib/rubocop/cop/style/commented_keyword.rb +23 -35
- data/lib/rubocop/cop/style/conditional_assignment.rb +77 -82
- data/lib/rubocop/cop/style/constant_visibility.rb +17 -5
- data/lib/rubocop/cop/style/copyright.rb +27 -23
- data/lib/rubocop/cop/style/date_time.rb +17 -6
- data/lib/rubocop/cop/style/def_with_parentheses.rb +8 -10
- data/lib/rubocop/cop/style/dir.rb +11 -13
- data/lib/rubocop/cop/style/disable_cops_within_source_code_directive.rb +47 -0
- data/lib/rubocop/cop/style/document_dynamic_eval_definition.rb +169 -0
- data/lib/rubocop/cop/style/documentation.rb +62 -15
- data/lib/rubocop/cop/style/documentation_method.rb +46 -2
- data/lib/rubocop/cop/style/double_cop_disable_directive.rb +52 -0
- data/lib/rubocop/cop/style/double_negation.rb +49 -6
- data/lib/rubocop/cop/style/each_for_simple_loop.rb +6 -9
- data/lib/rubocop/cop/style/each_with_object.rb +17 -20
- data/lib/rubocop/cop/style/empty_block_parameter.rb +9 -10
- data/lib/rubocop/cop/style/empty_case_condition.rb +29 -28
- data/lib/rubocop/cop/style/empty_else.rb +17 -19
- data/lib/rubocop/cop/style/empty_lambda_parameter.rb +9 -10
- data/lib/rubocop/cop/style/empty_literal.rb +26 -27
- data/lib/rubocop/cop/style/empty_method.rb +13 -20
- data/lib/rubocop/cop/style/encoding.rb +6 -10
- data/lib/rubocop/cop/style/end_block.rb +6 -2
- data/lib/rubocop/cop/style/eval_with_location.rb +10 -10
- data/lib/rubocop/cop/style/even_odd.rb +10 -13
- data/lib/rubocop/cop/style/expand_path_arguments.rb +30 -29
- data/lib/rubocop/cop/style/explicit_block_argument.rb +106 -0
- data/lib/rubocop/cop/style/exponential_notation.rb +117 -0
- data/lib/rubocop/cop/style/float_division.rb +136 -0
- data/lib/rubocop/cop/style/for.rb +7 -15
- data/lib/rubocop/cop/style/format_string.rb +48 -37
- data/lib/rubocop/cop/style/format_string_token.rb +70 -77
- data/lib/rubocop/cop/style/frozen_string_literal_comment.rb +113 -65
- data/lib/rubocop/cop/style/global_std_stream.rb +65 -0
- data/lib/rubocop/cop/style/global_vars.rb +2 -2
- data/lib/rubocop/cop/style/guard_clause.rb +69 -16
- data/lib/rubocop/cop/style/hash_as_last_array_item.rb +88 -0
- data/lib/rubocop/cop/style/hash_each_methods.rb +86 -0
- data/lib/rubocop/cop/style/hash_like_case.rb +76 -0
- data/lib/rubocop/cop/style/hash_syntax.rb +32 -23
- data/lib/rubocop/cop/style/hash_transform_keys.rb +91 -0
- data/lib/rubocop/cop/style/hash_transform_values.rb +88 -0
- data/lib/rubocop/cop/style/identical_conditional_branches.rb +9 -4
- data/lib/rubocop/cop/style/if_inside_else.rb +80 -2
- data/lib/rubocop/cop/style/if_unless_modifier.rb +124 -44
- data/lib/rubocop/cop/style/if_unless_modifier_of_if_unless.rb +11 -3
- data/lib/rubocop/cop/style/if_with_semicolon.rb +51 -3
- data/lib/rubocop/cop/style/implicit_runtime_error.rb +2 -1
- data/lib/rubocop/cop/style/infinite_loop.rb +33 -28
- data/lib/rubocop/cop/style/inline_comment.rb +4 -4
- data/lib/rubocop/cop/style/inverse_methods.rb +39 -39
- data/lib/rubocop/cop/style/ip_addresses.rb +6 -6
- data/lib/rubocop/cop/style/keyword_parameters_order.rb +65 -0
- data/lib/rubocop/cop/style/lambda.rb +9 -15
- data/lib/rubocop/cop/style/lambda_call.rb +17 -34
- data/lib/rubocop/cop/style/line_end_concatenation.rb +33 -26
- data/lib/rubocop/cop/style/method_call_with_args_parentheses/omit_parentheses.rb +169 -0
- data/lib/rubocop/cop/style/method_call_with_args_parentheses/require_parentheses.rb +44 -0
- data/lib/rubocop/cop/style/method_call_with_args_parentheses.rb +32 -226
- data/lib/rubocop/cop/style/method_call_without_args_parentheses.rb +18 -10
- data/lib/rubocop/cop/style/method_called_on_do_end_block.rb +12 -3
- data/lib/rubocop/cop/style/method_def_parentheses.rb +21 -22
- data/lib/rubocop/cop/style/min_max.rb +9 -13
- data/lib/rubocop/cop/style/missing_else.rb +11 -21
- data/lib/rubocop/cop/style/missing_respond_to_missing.rb +10 -3
- data/lib/rubocop/cop/style/mixin_grouping.rb +26 -33
- data/lib/rubocop/cop/style/mixin_usage.rb +12 -21
- data/lib/rubocop/cop/style/module_function.rb +64 -21
- data/lib/rubocop/cop/style/multiline_block_chain.rb +12 -3
- data/lib/rubocop/cop/style/multiline_if_modifier.rb +4 -11
- data/lib/rubocop/cop/style/multiline_if_then.rb +5 -11
- data/lib/rubocop/cop/style/multiline_memoization.rb +16 -14
- data/lib/rubocop/cop/style/multiline_method_signature.rb +2 -2
- data/lib/rubocop/cop/style/multiline_ternary_operator.rb +31 -9
- data/lib/rubocop/cop/style/multiline_when_then.rb +73 -0
- data/lib/rubocop/cop/style/multiple_comparison.rb +56 -8
- data/lib/rubocop/cop/style/mutable_constant.rb +30 -29
- data/lib/rubocop/cop/style/negated_if.rb +9 -9
- data/lib/rubocop/cop/style/negated_if_else_condition.rb +106 -0
- data/lib/rubocop/cop/style/negated_unless.rb +9 -9
- data/lib/rubocop/cop/style/negated_while.rb +7 -15
- data/lib/rubocop/cop/style/nested_modifier.rb +31 -16
- data/lib/rubocop/cop/style/nested_parenthesized_calls.rb +21 -22
- data/lib/rubocop/cop/style/nested_ternary_operator.rb +29 -2
- data/lib/rubocop/cop/style/next.rb +19 -23
- data/lib/rubocop/cop/style/nil_comparison.rb +13 -11
- data/lib/rubocop/cop/style/nil_lambda.rb +52 -0
- data/lib/rubocop/cop/style/non_nil_check.rb +55 -35
- data/lib/rubocop/cop/style/not.rb +20 -26
- data/lib/rubocop/cop/style/numeric_literal_prefix.rb +6 -11
- data/lib/rubocop/cop/style/numeric_literals.rb +21 -14
- data/lib/rubocop/cop/style/numeric_predicate.rb +14 -19
- data/lib/rubocop/cop/style/one_line_conditional.rb +76 -29
- data/lib/rubocop/cop/style/option_hash.rb +5 -5
- data/lib/rubocop/cop/style/optional_arguments.rb +2 -2
- data/lib/rubocop/cop/style/optional_boolean_parameter.rb +53 -0
- data/lib/rubocop/cop/style/or_assignment.rb +24 -15
- data/lib/rubocop/cop/style/parallel_assignment.rb +18 -18
- data/lib/rubocop/cop/style/parentheses_around_condition.rb +21 -7
- data/lib/rubocop/cop/style/percent_literal_delimiters.rb +21 -27
- data/lib/rubocop/cop/style/percent_q_literals.rb +8 -10
- data/lib/rubocop/cop/style/perl_backrefs.rb +91 -16
- data/lib/rubocop/cop/style/preferred_hash_methods.rb +11 -14
- data/lib/rubocop/cop/style/proc.rb +7 -7
- data/lib/rubocop/cop/style/raise_args.rb +33 -30
- data/lib/rubocop/cop/style/random_with_offset.rb +29 -34
- data/lib/rubocop/cop/style/redundant_argument.rb +88 -0
- data/lib/rubocop/cop/style/redundant_assignment.rb +107 -0
- data/lib/rubocop/cop/style/redundant_begin.rb +35 -9
- data/lib/rubocop/cop/style/{unneeded_capital_w.rb → redundant_capital_w.rb} +6 -9
- data/lib/rubocop/cop/style/{unneeded_condition.rb → redundant_condition.rb} +43 -15
- data/lib/rubocop/cop/style/redundant_conditional.rb +11 -11
- data/lib/rubocop/cop/style/redundant_exception.rb +21 -15
- data/lib/rubocop/cop/style/redundant_fetch_block.rb +113 -0
- data/lib/rubocop/cop/style/redundant_file_extension_in_require.rb +51 -0
- data/lib/rubocop/cop/style/redundant_freeze.rb +7 -9
- data/lib/rubocop/cop/style/{unneeded_interpolation.rb → redundant_interpolation.rb} +31 -25
- data/lib/rubocop/cop/style/redundant_parentheses.rb +53 -32
- data/lib/rubocop/cop/style/{unneeded_percent_q.rb → redundant_percent_q.rb} +13 -15
- data/lib/rubocop/cop/style/redundant_regexp_character_class.rb +104 -0
- data/lib/rubocop/cop/style/redundant_regexp_escape.rb +121 -0
- data/lib/rubocop/cop/style/redundant_return.rb +52 -44
- data/lib/rubocop/cop/style/redundant_self.rb +36 -21
- data/lib/rubocop/cop/style/redundant_self_assignment.rb +116 -0
- data/lib/rubocop/cop/style/{unneeded_sort.rb → redundant_sort.rb} +31 -34
- data/lib/rubocop/cop/style/redundant_sort_by.rb +6 -10
- data/lib/rubocop/cop/style/regexp_literal.rb +10 -21
- data/lib/rubocop/cop/style/rescue_modifier.rb +53 -9
- data/lib/rubocop/cop/style/rescue_standard_error.rb +23 -19
- data/lib/rubocop/cop/style/return_nil.rb +7 -7
- data/lib/rubocop/cop/style/safe_navigation.rb +54 -20
- data/lib/rubocop/cop/style/sample.rb +14 -16
- data/lib/rubocop/cop/style/self_assignment.rb +26 -22
- data/lib/rubocop/cop/style/semicolon.rb +23 -12
- data/lib/rubocop/cop/style/send.rb +4 -5
- data/lib/rubocop/cop/style/signal_exception.rb +26 -20
- data/lib/rubocop/cop/style/single_argument_dig.rb +55 -0
- data/lib/rubocop/cop/style/single_line_block_params.rb +32 -7
- data/lib/rubocop/cop/style/single_line_methods.rb +26 -18
- data/lib/rubocop/cop/style/slicing_with_range.rb +37 -0
- data/lib/rubocop/cop/style/sole_nested_conditional.rb +128 -0
- data/lib/rubocop/cop/style/special_global_vars.rb +18 -41
- data/lib/rubocop/cop/style/stabby_lambda_parentheses.rb +17 -23
- data/lib/rubocop/cop/style/static_class.rb +97 -0
- data/lib/rubocop/cop/style/stderr_puts.rb +7 -8
- data/lib/rubocop/cop/style/string_concatenation.rb +143 -0
- data/lib/rubocop/cop/style/string_hash_keys.rb +8 -9
- data/lib/rubocop/cop/style/string_literals.rb +14 -8
- data/lib/rubocop/cop/style/string_literals_in_interpolation.rb +4 -3
- data/lib/rubocop/cop/style/string_methods.rb +7 -17
- data/lib/rubocop/cop/style/strip.rb +10 -15
- data/lib/rubocop/cop/style/struct_inheritance.rb +23 -5
- data/lib/rubocop/cop/style/swap_values.rb +108 -0
- data/lib/rubocop/cop/style/symbol_array.rb +13 -24
- data/lib/rubocop/cop/style/symbol_literal.rb +6 -8
- data/lib/rubocop/cop/style/symbol_proc.rb +22 -24
- data/lib/rubocop/cop/style/ternary_parentheses.rb +57 -31
- data/lib/rubocop/cop/style/trailing_body_on_class.rb +3 -6
- data/lib/rubocop/cop/style/trailing_body_on_method_definition.rb +4 -7
- data/lib/rubocop/cop/style/trailing_body_on_module.rb +3 -6
- data/lib/rubocop/cop/style/trailing_comma_in_arguments.rb +39 -25
- data/lib/rubocop/cop/style/trailing_comma_in_array_literal.rb +43 -5
- data/lib/rubocop/cop/style/trailing_comma_in_block_args.rb +90 -0
- data/lib/rubocop/cop/style/trailing_comma_in_hash_literal.rb +46 -5
- data/lib/rubocop/cop/style/trailing_method_end_statement.rb +9 -34
- data/lib/rubocop/cop/style/trailing_underscore_variable.rb +19 -22
- data/lib/rubocop/cop/style/trivial_accessors.rb +36 -39
- data/lib/rubocop/cop/style/unless_else.rb +6 -9
- data/lib/rubocop/cop/style/unpack_first.rb +5 -12
- data/lib/rubocop/cop/style/variable_interpolation.rb +11 -24
- data/lib/rubocop/cop/style/when_then.rb +5 -7
- data/lib/rubocop/cop/style/while_until_do.rb +6 -16
- data/lib/rubocop/cop/style/while_until_modifier.rb +17 -22
- data/lib/rubocop/cop/style/word_array.rb +8 -26
- data/lib/rubocop/cop/style/yoda_condition.rb +29 -8
- data/lib/rubocop/cop/style/zero_length_predicate.rb +25 -27
- data/lib/rubocop/cop/team.rb +159 -87
- data/lib/rubocop/cop/util.rb +36 -19
- data/lib/rubocop/cop/utils/format_string.rb +135 -0
- data/lib/rubocop/cop/variable_force/assignment.rb +1 -0
- data/lib/rubocop/cop/variable_force/branch.rb +2 -7
- data/lib/rubocop/cop/variable_force/scope.rb +2 -1
- data/lib/rubocop/cop/variable_force/variable.rb +20 -8
- data/lib/rubocop/cop/variable_force.rb +16 -17
- data/lib/rubocop/cops_documentation_generator.rb +284 -0
- data/lib/rubocop/core_ext/hash.rb +20 -0
- data/lib/rubocop/core_ext/string.rb +2 -26
- data/lib/rubocop/directive_comment.rb +32 -0
- data/lib/rubocop/error.rb +24 -0
- data/lib/rubocop/ext/processed_source.rb +18 -0
- data/lib/rubocop/ext/regexp_node.rb +87 -0
- data/lib/rubocop/ext/regexp_parser.rb +95 -0
- data/lib/rubocop/file_finder.rb +13 -12
- data/lib/rubocop/formatter/auto_gen_config_formatter.rb +2 -1
- data/lib/rubocop/formatter/base_formatter.rb +0 -4
- data/lib/rubocop/formatter/clang_style_formatter.rb +8 -5
- data/lib/rubocop/formatter/disabled_config_formatter.rb +36 -22
- data/lib/rubocop/formatter/emacs_style_formatter.rb +24 -9
- data/lib/rubocop/formatter/file_list_formatter.rb +1 -1
- data/lib/rubocop/formatter/formatter_set.rb +20 -19
- data/lib/rubocop/formatter/git_hub_actions_formatter.rb +47 -0
- data/lib/rubocop/formatter/html_formatter.rb +2 -0
- data/lib/rubocop/formatter/json_formatter.rb +6 -5
- data/lib/rubocop/formatter/junit_formatter.rb +84 -0
- data/lib/rubocop/formatter/offense_count_formatter.rb +1 -1
- data/lib/rubocop/formatter/pacman_formatter.rb +80 -0
- data/lib/rubocop/formatter/progress_formatter.rb +2 -1
- data/lib/rubocop/formatter/quiet_formatter.rb +1 -1
- data/lib/rubocop/formatter/simple_text_formatter.rb +54 -10
- data/lib/rubocop/formatter/tap_formatter.rb +19 -6
- data/lib/rubocop/formatter/worst_offenders_formatter.rb +1 -1
- data/lib/rubocop/lockfile.rb +40 -0
- data/lib/rubocop/magic_comment.rb +7 -3
- data/lib/rubocop/name_similarity.rb +18 -10
- data/lib/rubocop/options.rb +131 -60
- data/lib/rubocop/path_util.rb +19 -19
- data/lib/rubocop/platform.rb +1 -1
- data/lib/rubocop/rake_task.rb +10 -11
- data/lib/rubocop/remote_config.rb +2 -3
- data/lib/rubocop/result_cache.rb +69 -27
- data/lib/rubocop/rspec/cop_helper.rb +11 -32
- data/lib/rubocop/rspec/expect_offense.rb +107 -25
- data/lib/rubocop/rspec/shared_contexts.rb +89 -40
- data/lib/rubocop/rspec/support.rb +0 -1
- data/lib/rubocop/runner.rb +127 -73
- data/lib/rubocop/string_interpreter.rb +3 -0
- data/lib/rubocop/target_finder.rb +61 -48
- data/lib/rubocop/target_ruby.rb +224 -0
- data/lib/rubocop/version.rb +65 -7
- data/lib/rubocop/yaml_duplication_checker.rb +9 -2
- data/lib/rubocop.rb +172 -145
- metadata +230 -184
- data/bin/console +0 -9
- data/bin/setup +0 -7
- data/lib/rubocop/ast/builder.rb +0 -79
- data/lib/rubocop/ast/node/alias_node.rb +0 -24
- data/lib/rubocop/ast/node/and_node.rb +0 -29
- data/lib/rubocop/ast/node/args_node.rb +0 -29
- data/lib/rubocop/ast/node/array_node.rb +0 -57
- data/lib/rubocop/ast/node/block_node.rb +0 -115
- data/lib/rubocop/ast/node/break_node.rb +0 -17
- data/lib/rubocop/ast/node/case_node.rb +0 -56
- data/lib/rubocop/ast/node/class_node.rb +0 -31
- data/lib/rubocop/ast/node/def_node.rb +0 -71
- data/lib/rubocop/ast/node/defined_node.rb +0 -17
- data/lib/rubocop/ast/node/ensure_node.rb +0 -17
- data/lib/rubocop/ast/node/for_node.rb +0 -53
- data/lib/rubocop/ast/node/hash_node.rb +0 -109
- data/lib/rubocop/ast/node/if_node.rb +0 -175
- data/lib/rubocop/ast/node/keyword_splat_node.rb +0 -45
- data/lib/rubocop/ast/node/mixin/basic_literal_node.rb +0 -16
- data/lib/rubocop/ast/node/mixin/binary_operator_node.rb +0 -43
- data/lib/rubocop/ast/node/mixin/collection_node.rb +0 -15
- data/lib/rubocop/ast/node/mixin/conditional_node.rb +0 -45
- data/lib/rubocop/ast/node/mixin/hash_element_node.rb +0 -125
- data/lib/rubocop/ast/node/mixin/method_dispatch_node.rb +0 -261
- data/lib/rubocop/ast/node/mixin/method_identifier_predicates.rb +0 -114
- data/lib/rubocop/ast/node/mixin/modifier_node.rb +0 -17
- data/lib/rubocop/ast/node/mixin/parameterized_node.rb +0 -61
- data/lib/rubocop/ast/node/mixin/predicate_operator_node.rb +0 -35
- data/lib/rubocop/ast/node/module_node.rb +0 -24
- data/lib/rubocop/ast/node/or_node.rb +0 -29
- data/lib/rubocop/ast/node/pair_node.rb +0 -63
- data/lib/rubocop/ast/node/range_node.rb +0 -18
- data/lib/rubocop/ast/node/regexp_node.rb +0 -35
- data/lib/rubocop/ast/node/resbody_node.rb +0 -29
- data/lib/rubocop/ast/node/retry_node.rb +0 -17
- data/lib/rubocop/ast/node/self_class_node.rb +0 -24
- data/lib/rubocop/ast/node/send_node.rb +0 -13
- data/lib/rubocop/ast/node/str_node.rb +0 -16
- data/lib/rubocop/ast/node/super_node.rb +0 -21
- data/lib/rubocop/ast/node/symbol_node.rb +0 -12
- data/lib/rubocop/ast/node/until_node.rb +0 -35
- data/lib/rubocop/ast/node/when_node.rb +0 -53
- data/lib/rubocop/ast/node/while_node.rb +0 -35
- data/lib/rubocop/ast/node/yield_node.rb +0 -21
- data/lib/rubocop/ast/node.rb +0 -646
- data/lib/rubocop/ast/sexp.rb +0 -16
- data/lib/rubocop/ast/traversal.rb +0 -183
- data/lib/rubocop/cop/layout/align_array.rb +0 -39
- data/lib/rubocop/cop/layout/indent_heredoc.rb +0 -256
- data/lib/rubocop/cop/layout/tab.rb +0 -87
- data/lib/rubocop/cop/lint/end_in_method.rb +0 -40
- data/lib/rubocop/cop/lint/unneeded_cop_enable_directive.rb +0 -116
- data/lib/rubocop/cop/lint/useless_comparison.rb +0 -28
- data/lib/rubocop/cop/mixin/classish_length.rb +0 -37
- data/lib/rubocop/cop/mixin/ignored_method_patterns.rb +0 -19
- data/lib/rubocop/cop/mixin/parser_diagnostic.rb +0 -37
- data/lib/rubocop/cop/mixin/safe_mode.rb +0 -22
- data/lib/rubocop/cop/mixin/target_rails_version.rb +0 -16
- data/lib/rubocop/cop/mixin/too_many_lines.rb +0 -35
- data/lib/rubocop/cop/rails/action_filter.rb +0 -117
- data/lib/rubocop/cop/rails/active_record_aliases.rb +0 -48
- data/lib/rubocop/cop/rails/active_record_override.rb +0 -82
- data/lib/rubocop/cop/rails/active_support_aliases.rb +0 -69
- data/lib/rubocop/cop/rails/application_job.rb +0 -40
- data/lib/rubocop/cop/rails/application_record.rb +0 -40
- data/lib/rubocop/cop/rails/assert_not.rb +0 -44
- data/lib/rubocop/cop/rails/belongs_to.rb +0 -102
- data/lib/rubocop/cop/rails/blank.rb +0 -164
- data/lib/rubocop/cop/rails/bulk_change_table.rb +0 -289
- data/lib/rubocop/cop/rails/create_table_with_timestamps.rb +0 -91
- data/lib/rubocop/cop/rails/date.rb +0 -161
- data/lib/rubocop/cop/rails/delegate.rb +0 -132
- data/lib/rubocop/cop/rails/delegate_allow_blank.rb +0 -37
- data/lib/rubocop/cop/rails/dynamic_find_by.rb +0 -91
- data/lib/rubocop/cop/rails/enum_uniqueness.rb +0 -45
- data/lib/rubocop/cop/rails/environment_comparison.rb +0 -68
- data/lib/rubocop/cop/rails/exit.rb +0 -67
- data/lib/rubocop/cop/rails/file_path.rb +0 -108
- data/lib/rubocop/cop/rails/find_by.rb +0 -55
- data/lib/rubocop/cop/rails/find_each.rb +0 -51
- data/lib/rubocop/cop/rails/has_and_belongs_to_many.rb +0 -25
- data/lib/rubocop/cop/rails/has_many_or_has_one_dependent.rb +0 -106
- data/lib/rubocop/cop/rails/http_positional_arguments.rb +0 -117
- data/lib/rubocop/cop/rails/http_status.rb +0 -179
- data/lib/rubocop/cop/rails/ignored_skip_action_filter_option.rb +0 -94
- data/lib/rubocop/cop/rails/inverse_of.rb +0 -246
- data/lib/rubocop/cop/rails/lexically_scoped_action_filter.rb +0 -175
- data/lib/rubocop/cop/rails/link_to_blank.rb +0 -98
- data/lib/rubocop/cop/rails/not_null_column.rb +0 -67
- data/lib/rubocop/cop/rails/output.rb +0 -49
- data/lib/rubocop/cop/rails/output_safety.rb +0 -99
- data/lib/rubocop/cop/rails/pluralization_grammar.rb +0 -107
- data/lib/rubocop/cop/rails/presence.rb +0 -124
- data/lib/rubocop/cop/rails/present.rb +0 -153
- data/lib/rubocop/cop/rails/read_write_attribute.rb +0 -74
- data/lib/rubocop/cop/rails/redundant_allow_nil.rb +0 -111
- data/lib/rubocop/cop/rails/redundant_receiver_in_with_options.rb +0 -136
- data/lib/rubocop/cop/rails/reflection_class_name.rb +0 -37
- data/lib/rubocop/cop/rails/refute_methods.rb +0 -76
- data/lib/rubocop/cop/rails/relative_date_constant.rb +0 -93
- data/lib/rubocop/cop/rails/request_referer.rb +0 -56
- data/lib/rubocop/cop/rails/reversible_migration.rb +0 -286
- data/lib/rubocop/cop/rails/safe_navigation.rb +0 -87
- data/lib/rubocop/cop/rails/save_bang.rb +0 -316
- data/lib/rubocop/cop/rails/scope_args.rb +0 -29
- data/lib/rubocop/cop/rails/skips_model_validations.rb +0 -87
- data/lib/rubocop/cop/rails/time_zone.rb +0 -238
- data/lib/rubocop/cop/rails/uniq_before_pluck.rb +0 -105
- data/lib/rubocop/cop/rails/unknown_env.rb +0 -63
- data/lib/rubocop/cop/rails/validation.rb +0 -109
- data/lib/rubocop/cop/style/braces_around_hash_parameters.rb +0 -190
- data/lib/rubocop/cop/style/method_missing_super.rb +0 -34
- data/lib/rubocop/formatter/disabled_lines_formatter.rb +0 -57
- data/lib/rubocop/node_pattern.rb +0 -720
- data/lib/rubocop/processed_source.rb +0 -208
- data/lib/rubocop/rspec/shared_examples.rb +0 -59
- data/lib/rubocop/string_util.rb +0 -14
- data/lib/rubocop/token.rb +0 -114
@@ -1,87 +0,0 @@
|
|
1
|
-
# frozen_string_literal: true
|
2
|
-
|
3
|
-
module RuboCop
|
4
|
-
module Cop
|
5
|
-
module Rails
|
6
|
-
# This cop checks for the use of methods which skip
|
7
|
-
# validations which are listed in
|
8
|
-
# https://guides.rubyonrails.org/active_record_validations.html#skipping-validations
|
9
|
-
#
|
10
|
-
# Methods may be ignored from this rule by configuring a `Whitelist`.
|
11
|
-
#
|
12
|
-
# @example
|
13
|
-
# # bad
|
14
|
-
# Article.first.decrement!(:view_count)
|
15
|
-
# DiscussionBoard.decrement_counter(:post_count, 5)
|
16
|
-
# Article.first.increment!(:view_count)
|
17
|
-
# DiscussionBoard.increment_counter(:post_count, 5)
|
18
|
-
# person.toggle :active
|
19
|
-
# product.touch
|
20
|
-
# Billing.update_all("category = 'authorized', author = 'David'")
|
21
|
-
# user.update_attribute(:website, 'example.com')
|
22
|
-
# user.update_columns(last_request_at: Time.current)
|
23
|
-
# Post.update_counters 5, comment_count: -1, action_count: 1
|
24
|
-
#
|
25
|
-
# # good
|
26
|
-
# user.update(website: 'example.com')
|
27
|
-
# FileUtils.touch('file')
|
28
|
-
#
|
29
|
-
# @example Whitelist: ["touch"]
|
30
|
-
# # bad
|
31
|
-
# DiscussionBoard.decrement_counter(:post_count, 5)
|
32
|
-
# DiscussionBoard.increment_counter(:post_count, 5)
|
33
|
-
# person.toggle :active
|
34
|
-
#
|
35
|
-
# # good
|
36
|
-
# user.touch
|
37
|
-
#
|
38
|
-
class SkipsModelValidations < Cop
|
39
|
-
MSG = 'Avoid using `%<method>s` because it skips validations.'
|
40
|
-
|
41
|
-
METHODS_WITH_ARGUMENTS = %w[decrement!
|
42
|
-
decrement_counter
|
43
|
-
increment!
|
44
|
-
increment_counter
|
45
|
-
toggle!
|
46
|
-
update_all
|
47
|
-
update_attribute
|
48
|
-
update_column
|
49
|
-
update_columns
|
50
|
-
update_counters].freeze
|
51
|
-
|
52
|
-
def_node_matcher :good_touch?, <<-PATTERN
|
53
|
-
(send (const nil? :FileUtils) :touch ...)
|
54
|
-
PATTERN
|
55
|
-
|
56
|
-
def on_send(node)
|
57
|
-
return if whitelist.include?(node.method_name.to_s)
|
58
|
-
return unless blacklist.include?(node.method_name.to_s)
|
59
|
-
return if allowed_method?(node)
|
60
|
-
return if good_touch?(node)
|
61
|
-
|
62
|
-
add_offense(node, location: :selector)
|
63
|
-
end
|
64
|
-
alias on_csend on_send
|
65
|
-
|
66
|
-
private
|
67
|
-
|
68
|
-
def message(node)
|
69
|
-
format(MSG, method: node.method_name)
|
70
|
-
end
|
71
|
-
|
72
|
-
def allowed_method?(node)
|
73
|
-
METHODS_WITH_ARGUMENTS.include?(node.method_name.to_s) &&
|
74
|
-
!node.arguments?
|
75
|
-
end
|
76
|
-
|
77
|
-
def blacklist
|
78
|
-
cop_config['Blacklist'] || []
|
79
|
-
end
|
80
|
-
|
81
|
-
def whitelist
|
82
|
-
cop_config['Whitelist'] || []
|
83
|
-
end
|
84
|
-
end
|
85
|
-
end
|
86
|
-
end
|
87
|
-
end
|
@@ -1,238 +0,0 @@
|
|
1
|
-
# frozen_string_literal: true
|
2
|
-
|
3
|
-
module RuboCop
|
4
|
-
module Cop
|
5
|
-
module Rails
|
6
|
-
# This cop checks for the use of Time methods without zone.
|
7
|
-
#
|
8
|
-
# Built on top of Ruby on Rails style guide (https://github.com/rubocop-hq/rails-style-guide#time)
|
9
|
-
# and the article http://danilenko.org/2012/7/6/rails_timezones/
|
10
|
-
#
|
11
|
-
# Two styles are supported for this cop. When EnforcedStyle is 'strict'
|
12
|
-
# then only use of Time.zone is allowed.
|
13
|
-
#
|
14
|
-
# When EnforcedStyle is 'flexible' then it's also allowed
|
15
|
-
# to use Time.in_time_zone.
|
16
|
-
#
|
17
|
-
# @example EnforcedStyle: strict
|
18
|
-
# # `strict` means that `Time` should be used with `zone`.
|
19
|
-
#
|
20
|
-
# # bad
|
21
|
-
# Time.now
|
22
|
-
# Time.parse('2015-03-02 19:05:37')
|
23
|
-
#
|
24
|
-
# # bad
|
25
|
-
# Time.current
|
26
|
-
# Time.at(timestamp).in_time_zone
|
27
|
-
#
|
28
|
-
# # good
|
29
|
-
# Time.zone.now
|
30
|
-
# Time.zone.parse('2015-03-02 19:05:37')
|
31
|
-
#
|
32
|
-
# @example EnforcedStyle: flexible (default)
|
33
|
-
# # `flexible` allows usage of `in_time_zone` instead of `zone`.
|
34
|
-
#
|
35
|
-
# # bad
|
36
|
-
# Time.now
|
37
|
-
# Time.parse('2015-03-02 19:05:37')
|
38
|
-
#
|
39
|
-
# # good
|
40
|
-
# Time.zone.now
|
41
|
-
# Time.zone.parse('2015-03-02 19:05:37')
|
42
|
-
#
|
43
|
-
# # good
|
44
|
-
# Time.current
|
45
|
-
# Time.at(timestamp).in_time_zone
|
46
|
-
class TimeZone < Cop
|
47
|
-
include ConfigurableEnforcedStyle
|
48
|
-
|
49
|
-
MSG = 'Do not use `%<current>s` without zone. Use `%<prefer>s` ' \
|
50
|
-
'instead.'
|
51
|
-
|
52
|
-
MSG_ACCEPTABLE = 'Do not use `%<current>s` without zone. ' \
|
53
|
-
'Use one of %<prefer>s instead.'
|
54
|
-
|
55
|
-
MSG_LOCALTIME = 'Do not use `Time.localtime` without ' \
|
56
|
-
'offset or zone.'
|
57
|
-
|
58
|
-
TIMECLASSES = %i[Time DateTime].freeze
|
59
|
-
|
60
|
-
GOOD_METHODS = %i[zone zone_default find_zone find_zone!].freeze
|
61
|
-
|
62
|
-
DANGEROUS_METHODS = %i[now local new parse at current].freeze
|
63
|
-
|
64
|
-
ACCEPTED_METHODS = %i[in_time_zone utc getlocal xmlschema iso8601
|
65
|
-
jisx0301 rfc3339 httpdate to_i to_f].freeze
|
66
|
-
|
67
|
-
def on_const(node)
|
68
|
-
mod, klass = *node
|
69
|
-
# we should only check core classes
|
70
|
-
# (`DateTime`, `Time`, `::DateTime` or `::Time`)
|
71
|
-
return unless (mod.nil? || mod.cbase_type?) && method_send?(node)
|
72
|
-
|
73
|
-
check_time_node(klass, node.parent) if TIMECLASSES.include?(klass)
|
74
|
-
end
|
75
|
-
|
76
|
-
def autocorrect(node)
|
77
|
-
lambda do |corrector|
|
78
|
-
# add `.zone`: `Time.at` => `Time.zone.at`
|
79
|
-
corrector.insert_after(node.children[0].source_range, '.zone')
|
80
|
-
# replace `Time.zone.current` => `Time.zone.now`
|
81
|
-
if node.method_name == :current
|
82
|
-
corrector.replace(node.loc.selector, 'now')
|
83
|
-
end
|
84
|
-
# prefer `Time` over `DateTime` class
|
85
|
-
if strict?
|
86
|
-
corrector.replace(node.children.first.source_range, 'Time')
|
87
|
-
end
|
88
|
-
remove_redundant_in_time_zone(corrector, node)
|
89
|
-
end
|
90
|
-
end
|
91
|
-
|
92
|
-
private
|
93
|
-
|
94
|
-
# remove redundant `.in_time_zone` from `Time.zone.now.in_time_zone`
|
95
|
-
def remove_redundant_in_time_zone(corrector, node)
|
96
|
-
time_methods_called = extract_method_chain(node)
|
97
|
-
return unless time_methods_called.include?(:in_time_zone) ||
|
98
|
-
time_methods_called.include?(:zone)
|
99
|
-
|
100
|
-
while node&.send_type?
|
101
|
-
if node.children.last == :in_time_zone
|
102
|
-
in_time_zone_with_dot =
|
103
|
-
node.loc.selector.adjust(begin_pos: -1)
|
104
|
-
corrector.remove(in_time_zone_with_dot)
|
105
|
-
end
|
106
|
-
node = node.parent
|
107
|
-
end
|
108
|
-
end
|
109
|
-
|
110
|
-
def check_time_node(klass, node)
|
111
|
-
chain = extract_method_chain(node)
|
112
|
-
return if not_danger_chain?(chain)
|
113
|
-
|
114
|
-
return check_localtime(node) if need_check_localtime?(chain)
|
115
|
-
|
116
|
-
method_name = (chain & DANGEROUS_METHODS).join('.')
|
117
|
-
|
118
|
-
return if offset_provided?(node)
|
119
|
-
|
120
|
-
message = build_message(klass, method_name, node)
|
121
|
-
|
122
|
-
add_offense(node, location: :selector, message: message)
|
123
|
-
end
|
124
|
-
|
125
|
-
def build_message(klass, method_name, node)
|
126
|
-
if flexible?
|
127
|
-
format(
|
128
|
-
MSG_ACCEPTABLE,
|
129
|
-
current: "#{klass}.#{method_name}",
|
130
|
-
prefer: acceptable_methods(klass, method_name, node).join(', ')
|
131
|
-
)
|
132
|
-
else
|
133
|
-
safe_method_name = safe_method(method_name, node)
|
134
|
-
format(MSG,
|
135
|
-
current: "#{klass}.#{method_name}",
|
136
|
-
prefer: "Time.zone.#{safe_method_name}")
|
137
|
-
end
|
138
|
-
end
|
139
|
-
|
140
|
-
def extract_method_chain(node)
|
141
|
-
chain = []
|
142
|
-
while !node.nil? && node.send_type?
|
143
|
-
chain << node.method_name if method_from_time_class?(node)
|
144
|
-
node = node.parent
|
145
|
-
end
|
146
|
-
chain
|
147
|
-
end
|
148
|
-
|
149
|
-
# Only add the method to the chain if the method being
|
150
|
-
# called is part of the time class.
|
151
|
-
def method_from_time_class?(node)
|
152
|
-
receiver, method_name, *_args = *node
|
153
|
-
if (receiver.is_a? RuboCop::AST::Node) && !receiver.cbase_type?
|
154
|
-
method_from_time_class?(receiver)
|
155
|
-
else
|
156
|
-
TIMECLASSES.include?(method_name)
|
157
|
-
end
|
158
|
-
end
|
159
|
-
|
160
|
-
# checks that parent node of send_type
|
161
|
-
# and receiver is the given node
|
162
|
-
def method_send?(node)
|
163
|
-
return false unless node.parent&.send_type?
|
164
|
-
|
165
|
-
node.parent.receiver == node
|
166
|
-
end
|
167
|
-
|
168
|
-
def safe_method(method_name, node)
|
169
|
-
if %w[new current].include?(method_name)
|
170
|
-
node.arguments? ? 'local' : 'now'
|
171
|
-
else
|
172
|
-
method_name
|
173
|
-
end
|
174
|
-
end
|
175
|
-
|
176
|
-
def check_localtime(node)
|
177
|
-
selector_node = node
|
178
|
-
|
179
|
-
while node&.send_type?
|
180
|
-
break if node.method_name == :localtime
|
181
|
-
|
182
|
-
node = node.parent
|
183
|
-
end
|
184
|
-
|
185
|
-
return if node.arguments?
|
186
|
-
|
187
|
-
add_offense(selector_node,
|
188
|
-
location: :selector, message: MSG_LOCALTIME)
|
189
|
-
end
|
190
|
-
|
191
|
-
def not_danger_chain?(chain)
|
192
|
-
(chain & DANGEROUS_METHODS).empty? || !(chain & good_methods).empty?
|
193
|
-
end
|
194
|
-
|
195
|
-
def need_check_localtime?(chain)
|
196
|
-
flexible? && chain.include?(:localtime)
|
197
|
-
end
|
198
|
-
|
199
|
-
def flexible?
|
200
|
-
style == :flexible
|
201
|
-
end
|
202
|
-
|
203
|
-
def strict?
|
204
|
-
style == :strict
|
205
|
-
end
|
206
|
-
|
207
|
-
def good_methods
|
208
|
-
if strict?
|
209
|
-
GOOD_METHODS
|
210
|
-
else
|
211
|
-
GOOD_METHODS + [:current] + ACCEPTED_METHODS
|
212
|
-
end
|
213
|
-
end
|
214
|
-
|
215
|
-
def acceptable_methods(klass, method_name, node)
|
216
|
-
acceptable = [
|
217
|
-
"`Time.zone.#{safe_method(method_name, node)}`",
|
218
|
-
"`#{klass}.current`"
|
219
|
-
]
|
220
|
-
|
221
|
-
ACCEPTED_METHODS.each do |am|
|
222
|
-
acceptable << "`#{klass}.#{method_name}.#{am}`"
|
223
|
-
end
|
224
|
-
|
225
|
-
acceptable
|
226
|
-
end
|
227
|
-
|
228
|
-
# Time.new can be called with a time zone offset
|
229
|
-
# When it is, that should be considered safe
|
230
|
-
# Example:
|
231
|
-
# Time.new(1988, 3, 15, 3, 0, 0, "-05:00")
|
232
|
-
def offset_provided?(node)
|
233
|
-
node.arguments.size >= 7
|
234
|
-
end
|
235
|
-
end
|
236
|
-
end
|
237
|
-
end
|
238
|
-
end
|
@@ -1,105 +0,0 @@
|
|
1
|
-
# frozen_string_literal: true
|
2
|
-
|
3
|
-
module RuboCop
|
4
|
-
module Cop
|
5
|
-
module Rails
|
6
|
-
# Prefer the use of uniq (or distinct), before pluck instead of after.
|
7
|
-
#
|
8
|
-
# The use of uniq before pluck is preferred because it executes within
|
9
|
-
# the database.
|
10
|
-
#
|
11
|
-
# This cop has two different enforcement modes. When the EnforcedStyle
|
12
|
-
# is conservative (the default) then only calls to pluck on a constant
|
13
|
-
# (i.e. a model class) before uniq are added as offenses.
|
14
|
-
#
|
15
|
-
# When the EnforcedStyle is aggressive then all calls to pluck before
|
16
|
-
# uniq are added as offenses. This may lead to false positives as the cop
|
17
|
-
# cannot distinguish between calls to pluck on an ActiveRecord::Relation
|
18
|
-
# vs a call to pluck on an ActiveRecord::Associations::CollectionProxy.
|
19
|
-
#
|
20
|
-
# Autocorrect is disabled by default for this cop since it may generate
|
21
|
-
# false positives.
|
22
|
-
#
|
23
|
-
# @example EnforcedStyle: conservative (default)
|
24
|
-
# # bad
|
25
|
-
# Model.pluck(:id).uniq
|
26
|
-
#
|
27
|
-
# # good
|
28
|
-
# Model.uniq.pluck(:id)
|
29
|
-
#
|
30
|
-
# @example EnforcedStyle: aggressive
|
31
|
-
# # bad
|
32
|
-
# # this will return a Relation that pluck is called on
|
33
|
-
# Model.where(cond: true).pluck(:id).uniq
|
34
|
-
#
|
35
|
-
# # bad
|
36
|
-
# # an association on an instance will return a CollectionProxy
|
37
|
-
# instance.assoc.pluck(:id).uniq
|
38
|
-
#
|
39
|
-
# # bad
|
40
|
-
# Model.pluck(:id).uniq
|
41
|
-
#
|
42
|
-
# # good
|
43
|
-
# Model.uniq.pluck(:id)
|
44
|
-
#
|
45
|
-
class UniqBeforePluck < RuboCop::Cop::Cop
|
46
|
-
include ConfigurableEnforcedStyle
|
47
|
-
include RangeHelp
|
48
|
-
|
49
|
-
MSG = 'Use `%<method>s` before `pluck`.'
|
50
|
-
NEWLINE = "\n"
|
51
|
-
PATTERN = '[!^block (send (send %<type>s :pluck ...) ' \
|
52
|
-
'${:uniq :distinct} ...)]'
|
53
|
-
|
54
|
-
def_node_matcher :conservative_node_match,
|
55
|
-
format(PATTERN, type: 'const')
|
56
|
-
|
57
|
-
def_node_matcher :aggressive_node_match,
|
58
|
-
format(PATTERN, type: '_')
|
59
|
-
|
60
|
-
def on_send(node)
|
61
|
-
method = if style == :conservative
|
62
|
-
conservative_node_match(node)
|
63
|
-
else
|
64
|
-
aggressive_node_match(node)
|
65
|
-
end
|
66
|
-
|
67
|
-
return unless method
|
68
|
-
|
69
|
-
add_offense(node, location: :selector,
|
70
|
-
message: format(MSG, method: method))
|
71
|
-
end
|
72
|
-
|
73
|
-
def autocorrect(node)
|
74
|
-
lambda do |corrector|
|
75
|
-
method = node.method_name
|
76
|
-
|
77
|
-
corrector.remove(dot_method_with_whitespace(method, node))
|
78
|
-
corrector.insert_before(node.receiver.loc.dot.begin, ".#{method}")
|
79
|
-
end
|
80
|
-
end
|
81
|
-
|
82
|
-
private
|
83
|
-
|
84
|
-
def style_parameter_name
|
85
|
-
'EnforcedStyle'
|
86
|
-
end
|
87
|
-
|
88
|
-
def dot_method_with_whitespace(method, node)
|
89
|
-
range_between(dot_method_begin_pos(method, node),
|
90
|
-
node.loc.selector.end_pos)
|
91
|
-
end
|
92
|
-
|
93
|
-
def dot_method_begin_pos(method, node)
|
94
|
-
lines = node.source.split(NEWLINE)
|
95
|
-
|
96
|
-
if lines.last.strip == ".#{method}"
|
97
|
-
node.source.rindex(NEWLINE)
|
98
|
-
else
|
99
|
-
node.loc.dot.begin_pos
|
100
|
-
end
|
101
|
-
end
|
102
|
-
end
|
103
|
-
end
|
104
|
-
end
|
105
|
-
end
|
@@ -1,63 +0,0 @@
|
|
1
|
-
# frozen_string_literal: true
|
2
|
-
|
3
|
-
module RuboCop
|
4
|
-
module Cop
|
5
|
-
module Rails
|
6
|
-
# This cop checks that environments called with `Rails.env` predicates
|
7
|
-
# exist.
|
8
|
-
#
|
9
|
-
# @example
|
10
|
-
# # bad
|
11
|
-
# Rails.env.proudction?
|
12
|
-
#
|
13
|
-
# # good
|
14
|
-
# Rails.env.production?
|
15
|
-
class UnknownEnv < Cop
|
16
|
-
include NameSimilarity
|
17
|
-
|
18
|
-
MSG = 'Unknown environment `%<name>s`.'
|
19
|
-
MSG_SIMILAR = 'Unknown environment `%<name>s`. ' \
|
20
|
-
'Did you mean `%<similar>s`?'
|
21
|
-
|
22
|
-
def_node_matcher :unknown_environment?, <<-PATTERN
|
23
|
-
(send
|
24
|
-
(send
|
25
|
-
{(const nil? :Rails) (const (cbase) :Rails)}
|
26
|
-
:env)
|
27
|
-
$#unknown_env_name?)
|
28
|
-
PATTERN
|
29
|
-
|
30
|
-
def on_send(node)
|
31
|
-
unknown_environment?(node) do |name|
|
32
|
-
add_offense(node, location: :selector, message: message(name))
|
33
|
-
end
|
34
|
-
end
|
35
|
-
|
36
|
-
private
|
37
|
-
|
38
|
-
def collect_variable_like_names(_scope)
|
39
|
-
environments.map { |env| env + '?' }
|
40
|
-
end
|
41
|
-
|
42
|
-
def message(name)
|
43
|
-
similar = find_similar_name(name.to_s, [])
|
44
|
-
if similar
|
45
|
-
format(MSG_SIMILAR, name: name, similar: similar)
|
46
|
-
else
|
47
|
-
format(MSG, name: name)
|
48
|
-
end
|
49
|
-
end
|
50
|
-
|
51
|
-
def unknown_env_name?(name)
|
52
|
-
name = name.to_s
|
53
|
-
name.end_with?('?') &&
|
54
|
-
!environments.include?(name[0..-2])
|
55
|
-
end
|
56
|
-
|
57
|
-
def environments
|
58
|
-
cop_config['Environments']
|
59
|
-
end
|
60
|
-
end
|
61
|
-
end
|
62
|
-
end
|
63
|
-
end
|
@@ -1,109 +0,0 @@
|
|
1
|
-
# frozen_string_literal: true
|
2
|
-
|
3
|
-
module RuboCop
|
4
|
-
module Cop
|
5
|
-
module Rails
|
6
|
-
# This cop checks for the use of old-style attribute validation macros.
|
7
|
-
#
|
8
|
-
# @example
|
9
|
-
# # bad
|
10
|
-
# validates_acceptance_of :foo
|
11
|
-
# validates_confirmation_of :foo
|
12
|
-
# validates_exclusion_of :foo
|
13
|
-
# validates_format_of :foo
|
14
|
-
# validates_inclusion_of :foo
|
15
|
-
# validates_length_of :foo
|
16
|
-
# validates_numericality_of :foo
|
17
|
-
# validates_presence_of :foo
|
18
|
-
# validates_absence_of :foo
|
19
|
-
# validates_size_of :foo
|
20
|
-
# validates_uniqueness_of :foo
|
21
|
-
#
|
22
|
-
# # good
|
23
|
-
# validates :foo, acceptance: true
|
24
|
-
# validates :foo, confirmation: true
|
25
|
-
# validates :foo, exclusion: true
|
26
|
-
# validates :foo, format: true
|
27
|
-
# validates :foo, inclusion: true
|
28
|
-
# validates :foo, length: true
|
29
|
-
# validates :foo, numericality: true
|
30
|
-
# validates :foo, presence: true
|
31
|
-
# validates :foo, absence: true
|
32
|
-
# validates :foo, size: true
|
33
|
-
# validates :foo, uniqueness: true
|
34
|
-
#
|
35
|
-
class Validation < Cop
|
36
|
-
MSG = 'Prefer the new style validations `%<prefer>s` over ' \
|
37
|
-
'`%<current>s`.'
|
38
|
-
|
39
|
-
TYPES = %w[
|
40
|
-
acceptance
|
41
|
-
confirmation
|
42
|
-
exclusion
|
43
|
-
format
|
44
|
-
inclusion
|
45
|
-
length
|
46
|
-
numericality
|
47
|
-
presence
|
48
|
-
absence
|
49
|
-
size
|
50
|
-
uniqueness
|
51
|
-
].freeze
|
52
|
-
|
53
|
-
DENYLIST = TYPES.map { |p| "validates_#{p}_of".to_sym }.freeze
|
54
|
-
ALLOWLIST = TYPES.map { |p| "validates :column, #{p}: value" }.freeze
|
55
|
-
|
56
|
-
def on_send(node)
|
57
|
-
return unless !node.receiver && DENYLIST.include?(node.method_name)
|
58
|
-
|
59
|
-
add_offense(node, location: :selector)
|
60
|
-
end
|
61
|
-
|
62
|
-
def autocorrect(node)
|
63
|
-
last_argument = node.arguments.last
|
64
|
-
return if !last_argument.literal? && !last_argument.splat_type?
|
65
|
-
|
66
|
-
lambda do |corrector|
|
67
|
-
corrector.replace(node.loc.selector, 'validates')
|
68
|
-
correct_validate_type(corrector, node)
|
69
|
-
end
|
70
|
-
end
|
71
|
-
|
72
|
-
private
|
73
|
-
|
74
|
-
def message(node)
|
75
|
-
format(MSG, prefer: preferred_method(node.method_name),
|
76
|
-
current: node.method_name)
|
77
|
-
end
|
78
|
-
|
79
|
-
def preferred_method(method)
|
80
|
-
ALLOWLIST[DENYLIST.index(method.to_sym)]
|
81
|
-
end
|
82
|
-
|
83
|
-
def correct_validate_type(corrector, node)
|
84
|
-
last_argument = node.arguments.last
|
85
|
-
validate_type = node.method_name.to_s.split('_')[1]
|
86
|
-
|
87
|
-
if last_argument.hash_type?
|
88
|
-
corrector.replace(
|
89
|
-
last_argument.loc.expression,
|
90
|
-
"#{validate_type}: #{braced_options(last_argument)}"
|
91
|
-
)
|
92
|
-
else
|
93
|
-
range = last_argument.source_range
|
94
|
-
|
95
|
-
corrector.insert_after(range, ", #{validate_type}: true")
|
96
|
-
end
|
97
|
-
end
|
98
|
-
|
99
|
-
def braced_options(options)
|
100
|
-
if options.braces?
|
101
|
-
options.source
|
102
|
-
else
|
103
|
-
"{ #{options.source} }"
|
104
|
-
end
|
105
|
-
end
|
106
|
-
end
|
107
|
-
end
|
108
|
-
end
|
109
|
-
end
|